Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

Sanitize document names on upload and rename

Cursor Agentcc0dd5ea27ae
diff --git a/app/(ee)/api/links/[id]/upload/route.ts b/app/(ee)/api/links/[id]/upload/route.ts
index 3767e8aa..78baabe6 100644
--- a/app/(ee)/api/links/[id]/upload/route.ts
+++ b/app/(ee)/api/links/[id]/upload/route.ts
@@ -5,6 +5,7 @@ import { verifyDataroomSession } from "@/lib/auth/dataroom-auth";
import { DocumentData } from "@/lib/documents/create-document";
import prisma from "@/lib/prisma";
import { sendDataroomUploadNotificationTask } from "@/lib/trigger/dataroom-upload-notification";
+import { sanitizePlainText } from "@/lib/utils/sanitize-html";
import { supportsAdvancedExcelMode } from "@/lib/utils/get-content-type";
import { runs } from "@trigger.dev/sdk/v3";
import { waitUntil } from "@vercel/functions";
@@ -94,9 +95,31 @@ export async function POST(
);
}
+ if (typeof documentData.name !== "string") {
+ return NextResponse.json(
+ { message: "Document name is required" },
+ { status: 400 },
+ );
+ }
+
+ const sanitizedDocumentName = sanitizePlainText(documentData.name);
+ if (!sanitizedDocumentName) {
+ return NextResponse.json(
+ { message: "Document name is required" },
+ { status: 400 },
+ );
+ }
+
+ if (sanitizedDocumentName.length > 255) {
+ return NextResponse.json(
+ { message: "Document name too long" },
+ { status: 400 },
+ );
+ }
const updatedDocumentData = {
...documentData,
+ name: sanitizedDocumentName,
enableExcelAdvancedMode: documentData.supportedFileType === "sheet" &&
link.team?.enableExcelAdvancedMode &&
supportsAdvancedExcelMode(documentData.contentType),
diff --git a/lib/utils/sanitize-html.ts b/lib/utils/sanitize-html.ts
index 5f54f9de..99848c36 100644
--- a/lib/utils/sanitize-html.ts
+++ b/lib/utils/sanitize-html.ts
@@ -1,17 +1,23 @@
import sanitizeHtml from "sanitize-html";
+const plainTextSanitizeConfig = {
+ allowedTags: [],
+ allowedAttributes: {},
+};
+
+export function sanitizePlainText(content: string) {
+ return sanitizeHtml(content, plainTextSanitizeConfig).trim();
+}
+
export function validateContent(html: string, length: number = 1000) {
if (html.length > length) {
throw new Error(`Content cannot be longer than ${length} characters`);
}
- const sanitized = sanitizeHtml(html, {
- allowedTags: [],
- allowedAttributes: {},
- });
+ const sanitized = sanitizePlainText(html);
if (sanitized.length === 0 || sanitized === "") {
throw new Error("Content cannot be empty");
}
- return sanitized.trim();
+ return sanitized;
}
diff --git a/lib/zod/url-validation.ts b/lib/zod/url-validation.ts
index d4f6ad4e..9ab3fac0 100644
--- a/lib/zod/url-validation.ts
+++ b/lib/zod/url-validation.ts
@@ -9,6 +9,7 @@ import {
getNotionPageIdFromSlug,
isCustomNotionDomain,
} from "@/lib/notion/utils";
+import { sanitizePlainText } from "@/lib/utils/sanitize-html";
import { getSupportedContentType } from "@/lib/utils/get-content-type";
/**
@@ -221,8 +222,13 @@ export const documentUploadSchema = z
.object({
name: z
.string()
- .min(1, "Document name is required")
- .max(255, "Document name too long"),
+ .transform((value) => sanitizePlainText(value))
+ .pipe(
+ z
+ .string()
+ .min(1, "Document name is required")
+ .max(255, "Document name too long"),
+ ),
url: z.string().min(1, "URL is required"), // Use string for now, will validate based on type
storageType: z
.enum(["S3_PATH", "VERCEL_BLOB"], {
diff --git a/pages/api/teams/[teamId]/documents/[id]/update-name.ts b/pages/api/teams/[teamId]/documents/[id]/update-name.ts
index 0ffedb58..3a6e9a39 100644
--- a/pages/api/teams/[teamId]/documents/[id]/update-name.ts
+++ b/pages/api/teams/[teamId]/documents/[id]/update-name.ts
@@ -7,12 +7,18 @@ import { z } from "zod";
import { errorhandler } from "@/lib/errorHandler";
import prisma from "@/lib/prisma";
import { CustomUser } from "@/lib/types";
+import { sanitizePlainText } from "@/lib/utils/sanitize-html";
const updateNameSchema = z.object({
name: z
.string()
- .min(1, "Document name is required")
- .max(255, "Document name too long"),
+ .transform((value) => sanitizePlainText(value))
+ .pipe(
+ z
+ .string()
+ .min(1, "Document name is required")
+ .max(255, "Document name too long"),
+ ),
});
export default async function handle(