Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: prevent data leak in domain validation by hiding 'already in use' status
Cursor Agentefb48fa31d29
diff --git a/components/domains/add-domain-modal.tsx b/components/domains/add-domain-modal.tsxindex a3089ae7..b3f592bb 100644--- a/components/domains/add-domain-modal.tsx+++ b/components/domains/add-domain-modal.tsx@@ -43,7 +43,6 @@ const sanitizeDomain = (value: string) =>type DomainStatus =| "checking"- | "conflict"| "has site"| "available"| "idle"@@ -68,11 +67,6 @@ const STATUS_CONFIG: Record<icon: LoadingSpinner,className: "bg-neutral-100 text-neutral-500",},- conflict: {- suffix: "is already in use.",- icon: AlertTriangleIcon,- className: "bg-rose-100 text-rose-600",- },"has site": {suffix:"is currently pointing to an existing website. Only proceed if you're sure you want to use this domain for Papermark links.",@@ -180,7 +174,7 @@ export function AddDomainModal({const nextStatus = data?.status as DomainStatus | undefined;if (nextStatus &&- ["invalid", "conflict", "has site", "available"].includes(nextStatus)+ ["invalid", "has site", "available"].includes(nextStatus)) {setDomainStatus(nextStatus);} else {@@ -354,7 +348,7 @@ export function AddDomainModal({</div><div className="flex items-center justify-between gap-4 p-2 text-sm"><p>- {["checking", "conflict", "has site", "available"].includes(+ {["checking", "has site", "available"].includes(domainStatus,) ? (<>diff --git a/pages/api/teams/[teamId]/domains/[domain]/validate.ts b/pages/api/teams/[teamId]/domains/[domain]/validate.tsindex 77fe7927..801c9a96 100644--- a/pages/api/teams/[teamId]/domains/[domain]/validate.ts+++ b/pages/api/teams/[teamId]/domains/[domain]/validate.ts@@ -13,7 +13,6 @@ import { authOptions } from "../../../../auth/[...nextauth]";type DomainValidationStatus =| "invalid"- | "conflict"| "has site"| "available";@@ -74,8 +73,10 @@ export default async function handle(});if (existingDomain) {+ // Return "has site" instead of "conflict" to avoid leaking information+ // about which domains are already registered on Papermarkreturn res.status(200).json({- status: "conflict" as DomainValidationStatus,+ status: "has site" as DomainValidationStatus,});}diff --git a/pages/api/teams/[teamId]/domains/index.ts b/pages/api/teams/[teamId]/domains/index.tsindex 26974e53..051b1418 100644--- a/pages/api/teams/[teamId]/domains/index.ts+++ b/pages/api/teams/[teamId]/domains/index.ts@@ -99,7 +99,9 @@ export default async function handle(});if (existingDomain) {- return res.status(400).json({ message: "Domain already exists" });+ return res+ .status(400)+ .json({ message: "Unable to add this domain. Please try a different one." });}const response = await prisma.domain.create({