Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.
fix: codeql
Marc Seitzf3f16bcd06a4
diff --git a/components/links/links-table.tsx b/components/links/links-table.tsxindex 23db65ba..3db05d2b 100644--- a/components/links/links-table.tsx+++ b/components/links/links-table.tsx@@ -18,6 +18,7 @@ import {import { useQueryState } from "nuqs";import { toast } from "sonner";import useSWR, { mutate } from "swr";+import z from "zod";import { usePlan } from "@/lib/swr/use-billing";import useLimits from "@/lib/swr/use-limits";@@ -105,7 +106,7 @@ export default function LinksTable({const now = Date.now();const router = useRouter();const { isFree, isTrial } = usePlan();- const teamInfo = useTeam();+ const { currentTeamId } = useTeam();const { id: targetId, groupId } = router.query as {id: string;groupId?: string;@@ -267,7 +268,7 @@ export default function LinksTable({"Content-Type": "application/json",},body: JSON.stringify({- teamId: teamInfo?.currentTeam?.id,+ teamId: currentTeamId,}),});@@ -280,7 +281,7 @@ export default function LinksTable({// Update the duplicated link in the list of linksmutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(link.documentId ?? link.dataroomId ?? "",)}/links`,(links || []).concat(duplicatedLink),@@ -292,7 +293,7 @@ export default function LinksTable({const groupLinks =links?.filter((link) => link.groupId === groupId) || [];mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(duplicatedLink.documentId ?? duplicatedLink.dataroomId ?? "",)}/groups/${duplicatedLink.groupId}/links`,groupLinks.concat(duplicatedLink),@@ -316,8 +317,15 @@ export default function LinksTable({if (permissions === null && editPermissionLink.permissionGroupId) {// Delete the permission group - database will set permissionGroupId to null automaticallytry {+ const teamIdParsed = z.string().cuid().parse(currentTeamId);+ const targetIdParsed = z.string().cuid().parse(targetId);+ const permissionGroupIdParsed = z+ .string()+ .cuid()+ .parse(editPermissionLink.permissionGroupId);+const deleteResponse = await fetch(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups/${editPermissionLink.permissionGroupId}`,+ `/api/teams/${teamIdParsed}/datarooms/${targetIdParsed}/permission-groups/${permissionGroupIdParsed}`,{method: "DELETE",},@@ -331,8 +339,8 @@ export default function LinksTable({// Refresh the links cacheconst endpointTargetType = `${targetType.toLowerCase()}s`;mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(- targetId,+ `/api/teams/${teamIdParsed}/${endpointTargetType}/${encodeURIComponent(+ targetIdParsed,)}/links`,(currentLinks: LinkWithViews[] | undefined) =>(currentLinks || []).map((link: LinkWithViews) =>@@ -345,7 +353,7 @@ export default function LinksTable({// Invalidate the permission group cachemutate(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups/${editPermissionLink.permissionGroupId}`,+ `/api/teams/${teamIdParsed}/datarooms/${targetIdParsed}/permission-groups/${permissionGroupIdParsed}`,);setShowPermissionsSheet(false);@@ -361,8 +369,10 @@ export default function LinksTable({if (!editPermissionLink.permissionGroupId) {setIsLoading(true);try {+ const teamIdParsed = z.string().cuid().parse(currentTeamId);+ const targetIdParsed = z.string().cuid().parse(targetId);const response = await fetch(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups`,+ `/api/teams/${teamIdParsed}/datarooms/${targetIdParsed}/permission-groups`,{method: "POST",headers: {@@ -386,7 +396,7 @@ export default function LinksTable({// Refresh the links cacheconst endpointTargetType = `${targetType.toLowerCase()}s`;mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(targetId,)}/links`,);@@ -394,7 +404,7 @@ export default function LinksTable({// Cache the new permission group dataif (newPermissionGroup?.id) {mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups/${newPermissionGroup.id}`,+ `/api/teams/${currentTeamId}/datarooms/${targetId}/permission-groups/${newPermissionGroup.id}`,newPermissionGroup,false,);@@ -412,8 +422,15 @@ export default function LinksTable({} else {try {// Update the permissions for the existing link+ const teamIdParsed = z.string().cuid().parse(currentTeamId);+ const targetIdParsed = z.string().cuid().parse(targetId);+ const permissionGroupIdParsed = z+ .string()+ .cuid()+ .parse(editPermissionLink.permissionGroupId);+const res = await fetch(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups/${editPermissionLink.permissionGroupId}`,+ `/api/teams/${teamIdParsed}/datarooms/${targetIdParsed}/permission-groups/${permissionGroupIdParsed}`,{method: "PUT",headers: {@@ -434,7 +451,7 @@ export default function LinksTable({// Refresh the links cacheconst endpointTargetType = `${targetType.toLowerCase()}s`;mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(targetId,)}/links`,);@@ -442,7 +459,7 @@ export default function LinksTable({// Invalidate the permission group cacheif (editPermissionLink.permissionGroupId) {mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/datarooms/${targetId}/permission-groups/${editPermissionLink.permissionGroupId}`,+ `/api/teams/${currentTeamId}/datarooms/${targetId}/permission-groups/${editPermissionLink.permissionGroupId}`,);}@@ -502,7 +519,7 @@ export default function LinksTable({// Update the archived link in the list of linksmutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(targetId,)}/links`,(links || []).map((link) => (link.id === linkId ? archivedLink : link)),@@ -514,7 +531,7 @@ export default function LinksTable({const groupLinks =links?.filter((link) => link.groupId === groupId) || [];mutate(- `/api/teams/${teamInfo?.currentTeam?.id}/${endpointTargetType}/${encodeURIComponent(+ `/api/teams/${currentTeamId}/${endpointTargetType}/${encodeURIComponent(archivedLink.documentId ?? archivedLink.dataroomId ?? "",)}/groups/${groupId}/links`,groupLinks.map((link) => (link.id === linkId ? archivedLink : link)),@@ -969,4 +986,4 @@ export default function LinksTable({</div></>);-}\ No newline at end of file+}diff --git a/components/welcome/containers/upload-container.tsx b/components/welcome/containers/upload-container.tsxindex 5fcf50dd..fa7b4a50 100644--- a/components/welcome/containers/upload-container.tsx+++ b/components/welcome/containers/upload-container.tsx@@ -5,6 +5,7 @@ import { Dispatch, SetStateAction, useState } from "react";import { useTeam } from "@/context/team-context";import { motion } from "motion/react";import { toast } from "sonner";+import z from "zod";import { useAnalytics } from "@/lib/analytics";import { STAGGER_CHILD_VARIANTS } from "@/lib/constants";@@ -34,8 +35,7 @@ export function UploadContainer({const analytics = useAnalytics();const [uploading, setUploading] = useState<boolean>(false);- const teamInfo = useTeam();- const teamId = teamInfo?.currentTeam?.id as string;+ const { currentTeamId: teamId } = useTeam();const handleBrowserUpload = async (event: any) => {event.preventDefault();@@ -62,7 +62,7 @@ export function UploadContainer({const { type, data, numPages, fileSize } = await putFile({file: currentFile,- teamId,+ teamId: teamId as string,});setCurrentFile(null);@@ -79,7 +79,7 @@ export function UploadContainer({// create a document in the databaseconst response = await createDocument({documentData,- teamId,+ teamId: teamId as string,numPages,createLink: dataroomId ? false : true, // don't create a link if the document is being added to a dataroom});@@ -89,55 +89,64 @@ export function UploadContainer({if (dataroomId) {// add document to dataroom- await fetch(- `/api/teams/${teamId}/datarooms/${dataroomId}/documents`,- {+ try {+ const dataroomIdParsed = z.string().cuid().parse(dataroomId);++ await fetch(+ `/api/teams/${teamId}/datarooms/${dataroomIdParsed}/documents`,+ {+ method: "POST",+ headers: {+ "Content-Type": "application/json",+ },+ body: JSON.stringify({ documentId: document.id }),+ },+ );++ analytics.capture("Document Added to Dataroom", {+ documentId: document.id,+ name: document.name,+ numPages: document.numPages,+ path: router.asPath,+ type: document.type,+ teamId: teamId,+ dataroomId: dataroomId,+ });++ // create link to dataroom+ const newLinkResponse = await fetch(`/api/links`, {method: "POST",headers: {"Content-Type": "application/json",},- body: JSON.stringify({ documentId: document.id }),- },- );-- analytics.capture("Document Added to Dataroom", {- documentId: document.id,- name: document.name,- numPages: document.numPages,- path: router.asPath,- type: document.type,- teamId: teamInfo?.currentTeam?.id,- dataroomId: dataroomId,- });+ body: JSON.stringify({+ targetId: dataroomId,+ linkType: "DATAROOM_LINK",+ teamId,+ }),+ });- // create link to dataroom- const newLinkResponse = await fetch(`/api/links`, {- method: "POST",- headers: {- "Content-Type": "application/json",- },- body: JSON.stringify({- targetId: dataroomId,- linkType: "DATAROOM_LINK",- teamId,- }),- });+ if (newLinkResponse.ok) {+ const link = await newLinkResponse.json();+ setCurrentLinkId(link.id);- if (newLinkResponse.ok) {- const link = await newLinkResponse.json();- setCurrentLinkId(link.id);+ analytics.capture("Link Added", {+ linkId: link.id,+ dataroomId: dataroomId,+ customDomain: null,+ teamId: teamId,+ });+ }- analytics.capture("Link Added", {- linkId: link.id,- dataroomId: dataroomId,- customDomain: null,- teamId: teamInfo?.currentTeam?.id,- });- }-- setTimeout(() => {+ setTimeout(() => {+ setUploading(false);+ }, 2000);+ } catch (error) {+ console.error("Error adding document to dataroom:", error);+ toast.error("Failed to add document to dataroom");setUploading(false);- }, 2000);+ return;+ }} else {const linkId = document.links[0].id;@@ -149,13 +158,13 @@ export function UploadContainer({path: router.asPath,type: document.type,contentType: document.contentType,- teamId: teamInfo?.currentTeam?.id,+ teamId: teamId,});analytics.capture("Link Added", {linkId: linkId,documentId: document.id,customDomain: null,- teamId: teamInfo?.currentTeam?.id,+ teamId: teamId,});setTimeout(() => {diff --git a/ee/features/conversations/components/conversations-not-enabled-banner.tsx b/ee/features/conversations/components/conversations-not-enabled-banner.tsxindex a5860d8e..c11f5226 100644--- a/ee/features/conversations/components/conversations-not-enabled-banner.tsx+++ b/ee/features/conversations/components/conversations-not-enabled-banner.tsx@@ -4,6 +4,7 @@ import { useEffect, useState } from "react";import { ChevronDown, ChevronUp, X } from "lucide-react";import { toast } from "sonner";+import z from "zod";import { Button } from "@/components/ui/button";import {@@ -74,8 +75,10 @@ export function ConversationsNotEnabledBanner({const handleToggleConversations = async (newValue: boolean) => {setIsProcessing(true);try {+ const dataroomIdParsed = z.string().cuid().parse(dataroomId);+const response = await fetch(- `/api/teams/${teamId}/datarooms/${dataroomId}/conversations/toggle-conversations`,+ `/api/teams/${teamId}/datarooms/${dataroomIdParsed}/conversations/toggle-conversations`,{method: "POST",headers: {diff --git a/ee/features/conversations/pages/conversation-overview.tsx b/ee/features/conversations/pages/conversation-overview.tsxindex 842ef5af..609f6de5 100644--- a/ee/features/conversations/pages/conversation-overview.tsx+++ b/ee/features/conversations/pages/conversation-overview.tsx@@ -7,6 +7,7 @@ import { ConversationsNotEnabledBanner } from "@/ee/features/conversations/compoimport { Loader2, MessageSquare, Search } from "lucide-react";import { toast } from "sonner";import useSWR from "swr";+import z from "zod";import { useDataroom } from "@/lib/swr/use-dataroom";import useLimits from "@/lib/swr/use-limits";@@ -119,8 +120,14 @@ export default function DataroomConversationsPage() {setIsDeleting(true);try {+ const dataroomIdParsed = z.string().cuid().parse(dataroom.id);+ const conversationToDeleteParsed = z+ .string()+ .cuid()+ .parse(conversationToDelete);+const response = await fetch(- `/api/teams/${teamId}/datarooms/${dataroom.id}/conversations/${conversationToDelete}`,+ `/api/teams/${teamId}/datarooms/${dataroomIdParsed}/conversations/${conversationToDeleteParsed}`,{method: "DELETE",},diff --git a/lib/documents/create-document.ts b/lib/documents/create-document.tsindex b05f13f4..6047605d 100644--- a/lib/documents/create-document.ts+++ b/lib/documents/create-document.ts@@ -1,4 +1,5 @@import { DocumentStorageType } from "@prisma/client";+import z from "zod";export type DocumentData = {name: string;@@ -105,27 +106,34 @@ export const createNewDocumentVersion = async ({teamId: string;numPages?: number;}) => {- const response = await fetch(- `/api/teams/${teamId}/documents/${documentId}/versions`,- {- method: "POST",- headers: {- "Content-Type": "application/json",+ try {+ const documentIdParsed = z.string().cuid().parse(documentId);++ const response = await fetch(+ `/api/teams/${teamId}/documents/${documentIdParsed}/versions`,+ {+ method: "POST",+ headers: {+ "Content-Type": "application/json",+ },+ body: JSON.stringify({+ url: documentData.key,+ storageType: documentData.storageType,+ numPages: numPages,+ type: documentData.supportedFileType,+ contentType: documentData.contentType,+ fileSize: documentData.fileSize,+ }),},- body: JSON.stringify({- url: documentData.key,- storageType: documentData.storageType,- numPages: numPages,- type: documentData.supportedFileType,- contentType: documentData.contentType,- fileSize: documentData.fileSize,- }),- },- );+ );- if (!response.ok) {- throw new Error(`HTTP error! status: ${response.status}`);- }+ if (!response.ok) {+ throw new Error(`HTTP error! status: ${response.status}`);+ }- return response;+ return response;+ } catch (error) {+ console.error("Error creating new document version:", error);+ throw new Error("Invalid document ID or team ID");+ }};