Skip to content

Papermark is the open-source DocSend alternative and secure data rooms with built-in analytics and custom domains.

Security: fix cross-tenant IDOR in viewer-group member deletion + mirror MCP fixes

Marc Seitzf9e5b62adc4f
diff --git a/.gitignore b/.gitignore
index 8973adf7..629a7264 100644
--- a/.gitignore
+++ b/.gitignore
@@ -72,4 +72,5 @@ changelog
# Local sync workflow dry-run output
_public/
-.opencode
\ No newline at end of file
+.opencode
+plans/
\ No newline at end of file
diff --git a/pages/api/teams/[teamId]/datarooms/[id]/groups/[groupId]/members/[memberId].ts b/pages/api/teams/[teamId]/datarooms/[id]/groups/[groupId]/members/[memberId].ts
index 9c20a9ef..16bfbcc9 100644
--- a/pages/api/teams/[teamId]/datarooms/[id]/groups/[groupId]/members/[memberId].ts
+++ b/pages/api/teams/[teamId]/datarooms/[id]/groups/[groupId]/members/[memberId].ts
@@ -47,8 +47,27 @@ export default async function handle(
return res.status(401).json("Unauthorized");
}
+ // Confirm the target membership belongs to a group inside THIS team's dataroom.
+ const membership = await prisma.viewerGroupMembership.findFirst({
+ where: {
+ id: memberId,
+ group: {
+ id: groupId,
+ dataroom: {
+ id: dataroomId,
+ teamId: teamId,
+ },
+ },
+ },
+ select: { id: true },
+ });
+
+ if (!membership) {
+ return res.status(404).json({ error: "Member not found" });
+ }
+
await prisma.viewerGroupMembership.delete({
- where: { id: memberId },
+ where: { id: membership.id },
});
return res.status(204).end();
} catch (error) {