Skip to content

armgit / papra

Public Imported from GitHub
0

The minimalistic document archiving platform.

chore(client,server): suppress oxlint warnings for defensive patterns (#1191)

Corentin Thomasset09794ca9529a
diff --git a/apps/papra-client/src/modules/command-palette/command-palette.provider.tsx b/apps/papra-client/src/modules/command-palette/command-palette.provider.tsx
index 75180066..4289c0e0 100644
--- a/apps/papra-client/src/modules/command-palette/command-palette.provider.tsx
+++ b/apps/papra-client/src/modules/command-palette/command-palette.provider.tsx
@@ -72,6 +72,7 @@ export const CommandPaletteProvider: ParentComponent = (props) => {
document.removeEventListener('keydown', handleKeyDown);
});
+ // oxlint-disable-next-line no-unassigned-vars -- assigned via Solid ref binding in JSX
let inputRef: HTMLInputElement | undefined;
createEffect(
diff --git a/apps/papra-client/src/modules/documents/components/pdf-viewer/sidebar/thumbnails-panel.component.tsx b/apps/papra-client/src/modules/documents/components/pdf-viewer/sidebar/thumbnails-panel.component.tsx
index 48ab0b67..94ca3392 100644
--- a/apps/papra-client/src/modules/documents/components/pdf-viewer/sidebar/thumbnails-panel.component.tsx
+++ b/apps/papra-client/src/modules/documents/components/pdf-viewer/sidebar/thumbnails-panel.component.tsx
@@ -50,6 +50,7 @@ const PageThumbnail: Component<{
export const ThumbnailsPanel: Component<ThumbnailsPanelProps> = (props) => {
const { t } = useI18n();
+ // oxlint-disable-next-line no-unassigned-vars -- assigned via Solid ref binding in JSX
let containerRef!: HTMLDivElement;
const [containerWidth, setContainerWidth] = createSignal(200);
diff --git a/apps/papra-client/src/modules/documents/components/pdf-viewer/toolbar/pdf-viewer-toolbar.component.tsx b/apps/papra-client/src/modules/documents/components/pdf-viewer/toolbar/pdf-viewer-toolbar.component.tsx
index e007bf1f..b38d9c4d 100644
--- a/apps/papra-client/src/modules/documents/components/pdf-viewer/toolbar/pdf-viewer-toolbar.component.tsx
+++ b/apps/papra-client/src/modules/documents/components/pdf-viewer/toolbar/pdf-viewer-toolbar.component.tsx
@@ -9,6 +9,7 @@ import { MoreActionsMenu } from './more-actions-menu.component';
import { ZoomSelector } from './zoom-selector.component';
export const PdfViewerToolbar: Component<ToolbarProps> = (props) => {
+ // oxlint-disable-next-line no-unassigned-vars -- assigned via Solid ref binding in JSX
let pageNumberRef!: HTMLInputElement;
const { t } = useI18n();
diff --git a/apps/papra-client/src/modules/tags/components/tag-list.component.tsx b/apps/papra-client/src/modules/tags/components/tag-list.component.tsx
index 090afe96..a02ba0d9 100644
--- a/apps/papra-client/src/modules/tags/components/tag-list.component.tsx
+++ b/apps/papra-client/src/modules/tags/components/tag-list.component.tsx
@@ -22,6 +22,7 @@ export const TagPickerFilter: Component<{
isOpen?: boolean;
}> = (props) => {
const { t } = useI18n();
+ // oxlint-disable-next-line no-unassigned-vars -- assigned via Solid ref binding in JSX
let ref: HTMLInputElement | undefined;
createEffect(() => {
@@ -182,6 +183,7 @@ export const TagList: Component<{
organizationId: string;
}> = (props) => {
const TagItem = (props.asLink ?? true) ? TagLink : TagComponent;
+ // oxlint-disable-next-line no-unassigned-vars -- assigned via Solid ref binding in JSX
let containerRef: HTMLDivElement | undefined;
const [isOpen, setIsOpen] = createSignal(false);
diff --git a/apps/papra-server/src/modules/organizations/organizations.repository.ts b/apps/papra-server/src/modules/organizations/organizations.repository.ts
index 8bb42599..96b79b35 100644
--- a/apps/papra-server/src/modules/organizations/organizations.repository.ts
+++ b/apps/papra-server/src/modules/organizations/organizations.repository.ts
@@ -782,6 +782,7 @@ async function getExpiredSoftDeletedOrganizations({
}
async function getOrganizationCount({ db }: { db: Database }) {
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const [{ organizationCount = 0 } = {}] = await db
.select({ organizationCount: count() })
.from(organizationsTable)
@@ -828,6 +829,7 @@ async function listOrganizations({
pageSize,
});
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const [{ totalCount = 0 } = {}] = await db
.select({ totalCount: count() })
.from(organizationsTable)
diff --git a/apps/papra-server/src/modules/tagging-rules/tagging-rules.repository.ts b/apps/papra-server/src/modules/tagging-rules/tagging-rules.repository.ts
index 6a890ddf..f3d2f5d7 100644
--- a/apps/papra-server/src/modules/tagging-rules/tagging-rules.repository.ts
+++ b/apps/papra-server/src/modules/tagging-rules/tagging-rules.repository.ts
@@ -87,6 +87,7 @@ async function getOrganizationTaggingRule({
)
.leftJoin(tagsTable, eq(taggingRuleActionsTable.tagId, tagsTable.id));
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const { taggingRules = [] } = aggregateTaggingRules({ rawTaggingRules });
const [taggingRule] = taggingRules;
diff --git a/apps/papra-server/src/modules/users/users.repository.ts b/apps/papra-server/src/modules/users/users.repository.ts
index ed5959fa..650405a2 100644
--- a/apps/papra-server/src/modules/users/users.repository.ts
+++ b/apps/papra-server/src/modules/users/users.repository.ts
@@ -96,6 +96,7 @@ async function deleteUser({ userId, db }: { userId: string; db: Database }) {
}
export async function getUserCount({ db }: { db: Database }) {
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const [{ userCount = 0 } = {}] = await db.select({ userCount: count() }).from(usersTable);
return {
@@ -133,6 +134,7 @@ async function listUsers({
pageSize,
});
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const [{ totalCount = 0 } = {}] = await db
.select({ totalCount: count() })
.from(usersTable)
diff --git a/apps/papra-server/src/scripts/migrate-document-storage.script.ts b/apps/papra-server/src/scripts/migrate-document-storage.script.ts
index 172b1731..4d1ecfba 100644
--- a/apps/papra-server/src/scripts/migrate-document-storage.script.ts
+++ b/apps/papra-server/src/scripts/migrate-document-storage.script.ts
@@ -55,6 +55,7 @@ export async function migrateDocumentStorage({
error: unknown;
}[] = [];
+ // oxlint-disable-next-line typescript/no-useless-default-assignment -- defensive fallback for empty result set
const [{ count: documentCount = 0 } = {}] = await db
.select({ count: count() })
.from(documentsTable);