The minimalistic document archiving platform.
feat(document-share-links): prevent access to share links of deleted organizations (#1348)
Corentin Thomasset12e1d4b6db35
diff --git a/.changeset/tidy-paths-cover.md b/.changeset/tidy-paths-cover.mdnew file mode 100644index 00000000..9a3898a0--- /dev/null+++ b/.changeset/tidy-paths-cover.md@@ -0,0 +1,7 @@+---+'@papra/app': patch+---++Security fix: document share links belonging to a soft-deleted organization were still publicly accessible. Public access (document metadata, file download, and password verification) now stops with a 410 Gone as soon as the organization is deleted, and resumes automatically if the organization is restored during the grace period.++Thank you to [Thammachart Sittharod](https://github.com/penthammachat-creator) for the responsible disclosure of this issue.diff --git a/apps/papra-server/src/modules/document-share-links/document-share-links.routes.ts b/apps/papra-server/src/modules/document-share-links/document-share-links.routes.tsindex 03956827..41d30bd1 100644--- a/apps/papra-server/src/modules/document-share-links/document-share-links.routes.ts+++ b/apps/papra-server/src/modules/document-share-links/document-share-links.routes.ts@@ -215,12 +215,14 @@ function setupGetSharedDocumentRoute({ app, db, config, kvStore }: RouteDefiniticonst shareLinksRepository = createShareLinksRepository({ db });const documentsRepository = createDocumentsRepository({ db });+ const organizationsRepository = createOrganizationsRepository({ db });const { document } = await getSharedDocument({shareLinkToken,accessToken,shareLinksRepository,documentsRepository,+ organizationsRepository,config,});@@ -246,10 +248,13 @@ function setupVerifySharePasswordRoute({ app, db, config, kvStore }: RouteDefini});const shareLinksRepository = createShareLinksRepository({ db });+ const organizationsRepository = createOrganizationsRepository({ db });+const { accessToken } = await verifySharePassword({shareLinkToken,password,shareLinksRepository,+ organizationsRepository,config,});@@ -280,9 +285,12 @@ function setupGetSharedDocumentFileRoute({});const shareLinksRepository = createShareLinksRepository({ db });+ const organizationsRepository = createOrganizationsRepository({ db });+const { shareLink } = await resolveUsableShareLinkByToken({shareLinkToken,shareLinksRepository,+ organizationsRepository,});await ensureShareLinkAccessGranted({ shareLink, accessToken, config });diff --git a/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.test.ts b/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.test.tsindex e0783d1b..73db5d12 100644--- a/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.test.ts+++ b/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.test.ts@@ -1,3 +1,4 @@+import { eq } from 'drizzle-orm';import { describe, expect, test } from 'vitest';import { createInMemoryDatabase } from '../app/database/database.test-utils';import { overrideConfig } from '../config/config.test-utils';@@ -14,6 +15,8 @@ import {updateShareLink,verifySharePassword,} from './document-share-links.usecases';+import { createOrganizationsRepository } from '../organizations/organizations.repository';+import { organizationsTable } from '../organizations/organizations.table';const config = overrideConfig({ auth: { secret: 'test-secret-that-is-at-least-32-chars-long' } });@@ -38,8 +41,9 @@ async function setup({ now = '2026-05-12T00:00:00Z' }: { now?: string } = {}) {const shareLinksRepository = createShareLinksRepository({ db });const documentsRepository = createDocumentsRepository({ db });+ const organizationsRepository = createOrganizationsRepository({ db });- return { clock, db, shareLinksRepository, documentsRepository };+ return { clock, db, shareLinksRepository, documentsRepository, organizationsRepository };}describe('document-share-links usecases', () => {@@ -139,15 +143,20 @@ describe('document-share-links usecases', () => {describe('resolveUsableShareLinkByToken', () => {test('throws 404 when the token is unknown', async () => {- const { clock, shareLinksRepository } = await setup();+ const { clock, shareLinksRepository, organizationsRepository } = await setup();await expect(- resolveUsableShareLinkByToken({ shareLinkToken: 'unknown', shareLinksRepository, clock }),+ resolveUsableShareLinkByToken({+ shareLinkToken: 'unknown',+ shareLinksRepository,+ organizationsRepository,+ clock,+ }),).rejects.toThrowError('Share link not found.');});test('throws 410 when the link is disabled', async () => {- const { clock, db, shareLinksRepository } = await setup();+ const { clock, db, shareLinksRepository, organizationsRepository } = await setup();await db.insert(documentShareLinksTable).values({id: 'dsl_1',organizationId: 'org_1',@@ -160,13 +169,16 @@ describe('document-share-links usecases', () => {resolveUsableShareLinkByToken({shareLinkToken: 't'.repeat(64),shareLinksRepository,+ organizationsRepository,clock,}),).rejects.toThrowError('no longer available');});test('throws 410 when the link is expired', async () => {- const { clock, db, shareLinksRepository } = await setup({ now: '2026-05-20T00:00:00Z' });+ const { clock, db, shareLinksRepository, organizationsRepository } = await setup({+ now: '2026-05-20T00:00:00Z',+ });await db.insert(documentShareLinksTable).values({id: 'dsl_1',organizationId: 'org_1',@@ -179,6 +191,30 @@ describe('document-share-links usecases', () => {resolveUsableShareLinkByToken({shareLinkToken: 't'.repeat(64),shareLinksRepository,+ organizationsRepository,+ clock,+ }),+ ).rejects.toThrowError('no longer available');+ });++ test('throws 410 when the organization is soft-deleted', async () => {+ const { clock, db, shareLinksRepository, organizationsRepository } = await setup();+ await db.insert(documentShareLinksTable).values({+ id: 'dsl_1',+ organizationId: 'org_1',+ documentId: 'doc_1',+ token: 't'.repeat(64),+ });+ await db+ .update(organizationsTable)+ .set({ deletedAt: new Date('2026-05-11T00:00:00Z') })+ .where(eq(organizationsTable.id, 'org_1'));++ await expect(+ resolveUsableShareLinkByToken({+ shareLinkToken: 't'.repeat(64),+ shareLinksRepository,+ organizationsRepository,clock,}),).rejects.toThrowError('no longer available');@@ -187,7 +223,8 @@ describe('document-share-links usecases', () => {describe('verifySharePassword + ensureShareLinkAccessGranted', () => {test('a correct password yields an access token that grants access to the document', async () => {- const { clock, shareLinksRepository, documentsRepository } = await setup();+ const { clock, shareLinksRepository, documentsRepository, organizationsRepository } =+ await setup();const { shareLink } = await createShareLink({organizationId: 'org_1',@@ -203,6 +240,7 @@ describe('document-share-links usecases', () => {shareLinkToken: shareLink.token,password: 'hunter2',shareLinksRepository,+ organizationsRepository,config,clock,});@@ -212,7 +250,8 @@ describe('document-share-links usecases', () => {});test('an incorrect password is rejected', async () => {- const { clock, shareLinksRepository, documentsRepository } = await setup();+ const { clock, shareLinksRepository, documentsRepository, organizationsRepository } =+ await setup();const { shareLink } = await createShareLink({organizationId: 'org_1',documentId: 'doc_1',@@ -228,6 +267,7 @@ describe('document-share-links usecases', () => {shareLinkToken: shareLink.token,password: 'wrong',shareLinksRepository,+ organizationsRepository,config,clock,}),@@ -235,7 +275,8 @@ describe('document-share-links usecases', () => {});test('verifying a password on a non-protected link throws', async () => {- const { clock, shareLinksRepository, documentsRepository } = await setup();+ const { clock, shareLinksRepository, documentsRepository, organizationsRepository } =+ await setup();const { shareLink } = await createShareLink({organizationId: 'org_1',documentId: 'doc_1',@@ -250,6 +291,7 @@ describe('document-share-links usecases', () => {shareLinkToken: shareLink.token,password: 'whatever',shareLinksRepository,+ organizationsRepository,config,clock,}),@@ -302,7 +344,8 @@ describe('document-share-links usecases', () => {});test('rotating the password invalidates previously issued access tokens', async () => {- const { clock, shareLinksRepository, documentsRepository } = await setup();+ const { clock, shareLinksRepository, documentsRepository, organizationsRepository } =+ await setup();const { shareLink } = await createShareLink({organizationId: 'org_1',documentId: 'doc_1',@@ -317,6 +360,7 @@ describe('document-share-links usecases', () => {shareLinkToken: shareLink.token,password: 'hunter2',shareLinksRepository,+ organizationsRepository,config,clock,});@@ -340,7 +384,8 @@ describe('document-share-links usecases', () => {describe('getSharedDocument', () => {test('returns the document for a non-protected, usable link and records the access time', async () => {- const { clock, shareLinksRepository, documentsRepository } = await setup();+ const { clock, shareLinksRepository, documentsRepository, organizationsRepository } =+ await setup();const { shareLink } = await createShareLink({organizationId: 'org_1',documentId: 'doc_1',@@ -355,6 +400,7 @@ describe('document-share-links usecases', () => {accessToken: undefined,shareLinksRepository,documentsRepository,+ organizationsRepository,config,clock,});diff --git a/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.ts b/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.tsindex cda46039..94bfe19d 100644--- a/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.ts+++ b/apps/papra-server/src/modules/document-share-links/document-share-links.usecases.ts@@ -23,6 +23,7 @@ import {shouldTouchShareLinkLastAccessedAt,} from './document-share-links.models';import { hashPassword, verifyPassword } from './document-share-links.password';+import type { OrganizationsRepository } from '../organizations/organizations.repository';function isShareLinkExpired({shareLink,@@ -153,10 +154,12 @@ export async function getShareLinkDocumentOrThrow({export async function resolveUsableShareLinkByToken({shareLinkToken,shareLinksRepository,+ organizationsRepository,clock = systemClock,}: {shareLinkToken: string;shareLinksRepository: ShareLinksRepository;+ organizationsRepository: OrganizationsRepository;clock?: Clock;}) {const { shareLink } = await shareLinksRepository.getShareLinkByToken({ token: shareLinkToken });@@ -165,6 +168,14 @@ export async function resolveUsableShareLinkByToken({throw createShareLinkNotFoundError();}+ const { organization } = await organizationsRepository.getOrganizationById({+ organizationId: shareLink.organizationId,+ });++ if (!organization || !isNil(organization.deletedAt)) {+ throw createShareLinkGoneError();+ }+if (!shareLink.isEnabled || isShareLinkExpired({ shareLink, clock })) {throw createShareLinkGoneError();}@@ -206,18 +217,21 @@ export async function verifySharePassword({shareLinkToken,password,shareLinksRepository,+ organizationsRepository,config,clock = systemClock,}: {shareLinkToken: string;password: string;shareLinksRepository: ShareLinksRepository;+ organizationsRepository: OrganizationsRepository;config: Config;clock?: Clock;}) {const { shareLink } = await resolveUsableShareLinkByToken({shareLinkToken,shareLinksRepository,+ organizationsRepository,clock,});@@ -270,6 +284,7 @@ export async function getSharedDocument({accessToken,shareLinksRepository,documentsRepository,+ organizationsRepository,config,clock = systemClock,}: {@@ -277,12 +292,14 @@ export async function getSharedDocument({accessToken: string | undefined;shareLinksRepository: ShareLinksRepository;documentsRepository: DocumentsRepository;+ organizationsRepository: OrganizationsRepository;config: Config;clock?: Clock;}) {const { shareLink } = await resolveUsableShareLinkByToken({shareLinkToken,shareLinksRepository,+ organizationsRepository,clock,});diff --git a/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts b/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.tsindex df41834a..fab15286 100644--- a/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts+++ b/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts@@ -233,4 +233,71 @@ describe('shared document access e2e', () => {expect(restoredFileResponse.status).toBe(200);expect(await restoredFileResponse.text()).toBe('File content.');});++ test('a document in a soft-deleted organization is no longer reachable through its share link, and access resumes once the organization is restored', async () => {+ const { app } = await createTestApp();++ const createResponse = await app.request(+ '/api/organizations/org_222222222222222222222222/documents/doc_333333333333333333333333/share-links',+ {+ method: 'POST',+ headers: { 'Content-Type': 'application/json' },+ body: JSON.stringify({}),+ },+ { loggedInUserId: 'usr_111111111111111111111111' },+ );++ expect(createResponse.status).toBe(201);+ const { shareLink } = (await createResponse.json()) as { shareLink: { token: string } };++ // Sanity check: the link works while the organization is live.+ expect((await app.request(`/api/share-links/${shareLink.token}/document`)).status).toBe(200);++ // Soft-delete the organization.+ const deleteResponse = await app.request(+ '/api/organizations/org_222222222222222222222222',+ { method: 'DELETE' },+ { loggedInUserId: 'usr_111111111111111111111111' },+ );+ expect(deleteResponse.status).toBe(204);++ // Public access to both the metadata and the file must stop with a 410 Gone.+ const deletedOrgDocumentResponse = await app.request(+ `/api/share-links/${shareLink.token}/document`,+ );+ expect(deletedOrgDocumentResponse.status).toBe(410);+ expect(await deletedOrgDocumentResponse.json()).toMatchObject({+ error: { code: 'share_link.gone' },+ });++ const deletedOrgFileResponse = await app.request(+ `/api/share-links/${shareLink.token}/document/file`,+ );+ expect(deletedOrgFileResponse.status).toBe(410);+ expect(await deletedOrgFileResponse.json()).toMatchObject({+ error: { code: 'share_link.gone' },+ });++ // Restoring the organization brings the same link back to life.+ const restoreResponse = await app.request(+ '/api/organizations/org_222222222222222222222222/restore',+ { method: 'POST' },+ { loggedInUserId: 'usr_111111111111111111111111' },+ );+ expect(restoreResponse.status).toBe(204);++ const restoredDocumentResponse = await app.request(+ `/api/share-links/${shareLink.token}/document`,+ );+ expect(restoredDocumentResponse.status).toBe(200);+ expect(await restoredDocumentResponse.json()).toEqual({+ document: { name: 'invoice.pdf', size: 1024, mimeType: 'application/pdf' },+ });++ const restoredFileResponse = await app.request(+ `/api/share-links/${shareLink.token}/document/file`,+ );+ expect(restoredFileResponse.status).toBe(200);+ expect(await restoredFileResponse.text()).toBe('File content.');+ });});