Skip to content

armgit / papra

Public Imported from GitHub
0

The minimalistic document archiving platform.

refactor(intake-emails): remove unused legacy webhook secret validation code (#175)

Corentin Thomasset400541f0ce86
diff --git a/apps/papra-server/src/modules/intake-emails/intake-emails.models.test.ts b/apps/papra-server/src/modules/intake-emails/intake-emails.models.test.ts
index f7997608..f7b80407 100644
--- a/apps/papra-server/src/modules/intake-emails/intake-emails.models.test.ts
+++ b/apps/papra-server/src/modules/intake-emails/intake-emails.models.test.ts
@@ -1,39 +1,7 @@
import { describe, expect, test } from 'vitest';
-import { buildEmailAddress, getEmailUsername, getIsFromAllowedOrigin, getIsIntakeEmailWebhookSecretValid, parseEmailAddress } from './intake-emails.models';
+import { buildEmailAddress, getEmailUsername, getIsFromAllowedOrigin, parseEmailAddress } from './intake-emails.models';
describe('intake-emails models', () => {
- describe('getIsIntakeEmailWebhookSecretValid', () => {
- test('the authorization header from the email intake webhook should be a bearer token with the api secret', () => {
- expect(
- getIsIntakeEmailWebhookSecretValid({
- secret: 'foo',
- authorizationHeader: 'Bearer foo',
- }),
- ).to.eql(true);
-
- expect(
- getIsIntakeEmailWebhookSecretValid({
- secret: 'foo',
- authorizationHeader: 'Bearer bar',
- }),
- ).to.eql(false);
-
- expect(
- getIsIntakeEmailWebhookSecretValid({
- secret: 'foo',
- authorizationHeader: 'Bearer ',
- }),
- ).to.eql(false);
-
- expect(
- getIsIntakeEmailWebhookSecretValid({
- secret: 'foo',
- authorizationHeader: undefined,
- }),
- ).to.eql(false);
- });
- });
-
describe('getEmailUsername', () => {
test('the username is the whole part of the email address before the @', () => {
expect(getEmailUsername({ email: '[email protected]' })).to.eql({ username: 'foo' });
diff --git a/apps/papra-server/src/modules/intake-emails/intake-emails.models.ts b/apps/papra-server/src/modules/intake-emails/intake-emails.models.ts
index b527f30f..d92dadee 100644
--- a/apps/papra-server/src/modules/intake-emails/intake-emails.models.ts
+++ b/apps/papra-server/src/modules/intake-emails/intake-emails.models.ts
@@ -18,16 +18,6 @@ export function parseEmailAddress({ email }: { email: string }) {
return { username, domain, plusPart };
}
-export function getIsIntakeEmailWebhookSecretValid({
- secret,
- authorizationHeader,
-}: {
- secret: string;
- authorizationHeader: string | undefined;
-}) {
- return authorizationHeader === `Bearer ${secret}`;
-}
-
export function getEmailUsername({ email }: { email: string | undefined }) {
if (!email) {
return { username: undefined };