The minimalistic document archiving platform.
fix(api): return 204 when trashing documents (#1474)
Corentin Thomassetaa26524ef380
diff --git a/.changeset/jolly-lilies-fold.md b/.changeset/jolly-lilies-fold.mdnew file mode 100644index 00000000..a02aef25--- /dev/null+++ b/.changeset/jolly-lilies-fold.md@@ -0,0 +1,5 @@+---+'@papra/app': minor+---++API breaking change: The route to trash a document `DELETE /api/organizations/:organizationId/documents/:documentId` now returns a 204 No Content status code instead of `{ success: true }` JSON body.diff --git a/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts b/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.tsindex 883993fe..23e30bfc 100644--- a/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts+++ b/apps/papra-server/src/modules/document-share-links/e2e/shared-document-access.e2e.test.ts@@ -194,7 +194,7 @@ describe('shared document access e2e', () => {{ method: 'DELETE' },{ loggedInUserId: 'usr_111111111111111111111111' },);- expect(trashResponse.status).toBe(200);+ expect(trashResponse.status).toBe(204);// Public access to both the metadata and the file must stop with a 410 Gone.const trashedDocumentResponse = await app.request(diff --git a/apps/papra-server/src/modules/documents/documents.routes.ts b/apps/papra-server/src/modules/documents/documents.routes.tsindex 67e072af..7b03713a 100644--- a/apps/papra-server/src/modules/documents/documents.routes.ts+++ b/apps/papra-server/src/modules/documents/documents.routes.ts@@ -222,9 +222,7 @@ function setupDeleteDocumentRoute({ app, db, eventServices }: RouteDefinitionConeventServices,});- return context.json({- success: true,- });+ return context.body(null, 204);},);}