Skip to content

armgit / papra

Public Imported from GitHub
0

The minimalistic document archiving platform.

refactor(mobile): replace custom file size formatting with formatBytes (#832)

Corentin Thomassetf3a9dca1a04c
diff --git a/apps/mobile/src/modules/documents/components/document-action-sheet.tsx b/apps/mobile/src/modules/documents/components/document-action-sheet.tsx
index 16a5db7e..fccd1ff8 100644
--- a/apps/mobile/src/modules/documents/components/document-action-sheet.tsx
+++ b/apps/mobile/src/modules/documents/components/document-action-sheet.tsx
@@ -1,6 +1,7 @@
import type { CoerceDates } from '@/modules/api/api.models';
import type { Document } from '@/modules/documents/documents.types';
import type { ThemeColors } from '@/modules/ui/theme.constants';
+import { formatBytes } from '@corentinth/chisels';
import { MaterialCommunityIcons } from '@expo/vector-icons';
import { router } from 'expo-router';
import * as Sharing from 'expo-sharing';
@@ -44,16 +45,6 @@ export function DocumentActionSheet({
= document.mimeType.startsWith('image/')
|| document.mimeType.startsWith('application/pdf');
- const formatFileSize = (bytes: number): string => {
- if (bytes < 1024) {
- return `${bytes} B`;
- }
- if (bytes < 1024 * 1024) {
- return `${(bytes / 1024).toFixed(1)} KB`;
- }
- return `${(bytes / (1024 * 1024)).toFixed(1)} MB`;
- };
-
const formatDate = (dateString: string): string => {
const date = new Date(dateString);
return date.toLocaleDateString('en-US', {
@@ -146,7 +137,7 @@ export function DocumentActionSheet({
color={themeColors.mutedForeground}
style={styles.detailIcon}
/>
- <Text style={styles.detailText}>{formatFileSize(document.originalSize)}</Text>
+ <Text style={styles.detailText}>{formatBytes({ bytes: document.originalSize })}</Text>
</View>
<View style={styles.detailRow}>
<MaterialCommunityIcons
diff --git a/apps/mobile/src/modules/documents/screens/documents-list.screen.tsx b/apps/mobile/src/modules/documents/screens/documents-list.screen.tsx
index 618257b4..97a329d9 100644
--- a/apps/mobile/src/modules/documents/screens/documents-list.screen.tsx
+++ b/apps/mobile/src/modules/documents/screens/documents-list.screen.tsx
@@ -1,6 +1,7 @@
import type { Document } from '../documents.types';
import type { CoerceDates } from '@/modules/api/api.models';
import type { ThemeColors } from '@/modules/ui/theme.constants';
+import { formatBytes } from '@corentinth/chisels';
import { useQuery } from '@tanstack/react-query';
import { useState } from 'react';
import {
@@ -57,16 +58,6 @@ export function DocumentsListScreen() {
}).format(date);
};
- const formatFileSize = (bytes: number) => {
- if (bytes < 1024) {
- return `${bytes} B`;
- }
- if (bytes < 1024 * 1024) {
- return `${(bytes / 1024).toFixed(1)} KB`;
- }
- return `${(bytes / (1024 * 1024)).toFixed(1)} MB`;
- };
-
const onRefresh = async () => {
await documentsQuery.refetch();
if (currentOrganizationId != null) {
@@ -117,7 +108,7 @@ export function DocumentsListScreen() {
{item.name}
</Text>
<View style={styles.documentMeta}>
- <Text style={styles.metaText}>{formatFileSize(item.originalSize)}</Text>
+ <Text style={styles.metaText}>{formatBytes({ bytes: item.originalSize })}</Text>
<Text style={styles.metaSplitter}>-</Text>
<Text style={styles.metaText}>{formatDate(item.createdAt)}</Text>
{item.localUri !== undefined && (