Skip to content

armgit / pdfcn

Public Imported from GitHub
0

Beautiful pdf components, built on Takumi and Forme. 100% Free, Zero config, one command setup.

refactor: replace NativeSelect with Select component in HomePdfShowcase and ThemePreview for improved UI consistency

Aniket-508749f06783816
diff --git a/components/home-pdf-showcase.tsx b/components/home-pdf-showcase.tsx
index 8bc2de5..7af6076 100644
--- a/components/home-pdf-showcase.tsx
+++ b/components/home-pdf-showcase.tsx
@@ -24,9 +24,12 @@ import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
import {
- NativeSelect,
- NativeSelectOption,
-} from "@/components/ui/native-select";
+ Select,
+ SelectContent,
+ SelectItem,
+ SelectTrigger,
+ SelectValue,
+} from "@/components/ui/select";
import { Separator } from "@/components/ui/separator";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
import { Toggle } from "@/components/ui/toggle";
@@ -123,7 +126,7 @@ export const HomePdfShowcase = () => {
const [selectedComponentId, setSelectedComponentId] =
useState<ComponentPartId>("page-header");
const [workspaceTab, setWorkspaceTab] = useState<WorkspaceTab>("preview");
- const [pdfBase, setPdfBase] = useState<HomePdfBase>("forme");
+ const [pdfBase, setPdfBase] = useState<HomePdfBase>("takumi");
const [codeRequest, setCodeRequest] = useState<{
data: HomePdfCodeOutput | null;
error: string | null;
@@ -276,21 +279,28 @@ export const HomePdfShowcase = () => {
>
Choose base
</label>
- <NativeSelect
- id="home-pdf-base"
- size="sm"
+ <Select
value={pdfBase}
- onChange={(e) =>
- handlePdfBaseChange(e.target.value as HomePdfBase)
+ onValueChange={(value) =>
+ handlePdfBaseChange(value as HomePdfBase)
}
- className="w-40 min-w-0 sm:w-48"
>
- {homePdfBases.map((base) => (
- <NativeSelectOption key={base.id} value={base.id}>
- {base.label}
- </NativeSelectOption>
- ))}
- </NativeSelect>
+ <SelectTrigger
+ id="home-pdf-base"
+ size="sm"
+ aria-label="Choose base"
+ className="w-40 min-w-0 sm:w-48"
+ >
+ <SelectValue />
+ </SelectTrigger>
+ <SelectContent align="end">
+ {homePdfBases.map((base) => (
+ <SelectItem key={base.id} value={base.id}>
+ {base.label}
+ </SelectItem>
+ ))}
+ </SelectContent>
+ </Select>
</div>
</CardHeader>
@@ -345,21 +355,28 @@ export const HomePdfShowcase = () => {
>
Choose template
</label>
- <NativeSelect
- id="home-pdf-template"
- size="sm"
+ <Select
value={selectedPdfId}
- onChange={(e) =>
- handlePdfChange(e.target.value as PdfRecipeId)
+ onValueChange={(value) =>
+ handlePdfChange(value as PdfRecipeId)
}
- className="w-40 min-w-0 sm:w-48"
>
- {homePdfPreviews.map((pdf) => (
- <NativeSelectOption key={pdf.id} value={pdf.id}>
- {pdf.name}
- </NativeSelectOption>
- ))}
- </NativeSelect>
+ <SelectTrigger
+ id="home-pdf-template"
+ size="sm"
+ aria-label="Choose template"
+ className="w-40 min-w-0 sm:w-48"
+ >
+ <SelectValue />
+ </SelectTrigger>
+ <SelectContent align="end">
+ {homePdfPreviews.map((pdf) => (
+ <SelectItem key={pdf.id} value={pdf.id}>
+ {pdf.name}
+ </SelectItem>
+ ))}
+ </SelectContent>
+ </Select>
</div>
<Separator className="lg:hidden" />
diff --git a/components/theme-preview.tsx b/components/theme-preview.tsx
index 8519f06..4ae598d 100644
--- a/components/theme-preview.tsx
+++ b/components/theme-preview.tsx
@@ -58,7 +58,7 @@ export const ThemePreview = ({
value={selectedTheme}
onValueChange={(v) => setSelectedTheme(v as RegistryThemeName)}
>
- <SelectTrigger className="h-8 w-35 bg-background text-sm font-medium">
+ <SelectTrigger className="w-35 bg-background">
<SelectValue placeholder="Theme" />
</SelectTrigger>
<SelectContent>
diff --git a/components/ui/native-select.tsx b/components/ui/native-select.tsx
deleted file mode 100644
index e05aad9..0000000
--- a/components/ui/native-select.tsx
+++ /dev/null
@@ -1,73 +0,0 @@
-"use client";
-
-import { ChevronDownIcon } from "lucide-react";
-
-import { useFeedback } from "@/hooks/use-feedback";
-import { cn } from "@/lib/utils";
-
-const NativeSelect = ({
- className,
- size = "default",
- onChange,
- ...props
-}: Omit<React.ComponentProps<"select">, "size"> & {
- size?: "sm" | "default";
-}) => {
- const playSelect = useFeedback({ sound: "select" });
-
- const handleChange = (e: React.ChangeEvent<HTMLSelectElement>) => {
- playSelect();
- onChange?.(e);
- };
-
- return (
- <div
- className="group/native-select relative w-fit has-[select:disabled]:opacity-50"
- data-slot="native-select-wrapper"
- data-size={size}
- >
- <select
- data-slot="native-select"
- data-size={size}
- className={cn(
- "h-9 w-full min-w-0 appearance-none rounded-md border border-input bg-transparent px-3 py-2 pr-9 text-sm shadow-xs transition-[color,box-shadow] outline-none selection:bg-primary selection:text-primary-foreground placeholder:text-muted-foreground disabled:pointer-events-none disabled:cursor-not-allowed dark:bg-input/30 dark:hover:bg-input/50",
- "data-[size=sm]:h-8 data-[size=sm]:rounded-sm data-[size=sm]:px-2.5 data-[size=sm]:py-1 data-[size=sm]:pr-7 data-[size=sm]:text-xs",
- "focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50",
- "aria-invalid:border-destructive aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40",
- className
- )}
- onChange={handleChange}
- {...props}
- />
- <ChevronDownIcon
- className="pointer-events-none absolute top-1/2 right-3.5 size-4 -translate-y-1/2 text-muted-foreground opacity-50 select-none group-data-[size=sm]/native-select:right-2.5 group-data-[size=sm]/native-select:size-3.5"
- aria-hidden="true"
- data-slot="native-select-icon"
- />
- </div>
- );
-};
-
-const NativeSelectOption = ({
- className,
- ...props
-}: React.ComponentProps<"option">) => (
- <option
- data-slot="native-select-option"
- className={cn("bg-[Canvas] text-[CanvasText]", className)}
- {...props}
- />
-);
-
-const NativeSelectOptGroup = ({
- className,
- ...props
-}: React.ComponentProps<"optgroup">) => (
- <optgroup
- data-slot="native-select-optgroup"
- className={cn("bg-[Canvas] text-[CanvasText]", className)}
- {...props}
- />
-);
-
-export { NativeSelect, NativeSelectOptGroup, NativeSelectOption };
diff --git a/components/ui/select.tsx b/components/ui/select.tsx
index 8ae0f0c..e54c3e0 100644
--- a/components/ui/select.tsx
+++ b/components/ui/select.tsx
@@ -48,37 +48,84 @@ const SelectTrigger = ({
</SelectPrimitive.Trigger>
);
+const SelectScrollUpButton = ({
+ className,
+ ...props
+}: React.ComponentProps<typeof SelectPrimitive.ScrollUpButton>) => (
+ <SelectPrimitive.ScrollUpButton
+ data-slot="select-scroll-up-button"
+ className={cn(
+ "flex cursor-default items-center justify-center py-1",
+ className
+ )}
+ {...props}
+ >
+ <ChevronUpIcon className="size-4" />
+ </SelectPrimitive.ScrollUpButton>
+);
+
+const SelectScrollDownButton = ({
+ className,
+ ...props
+}: React.ComponentProps<typeof SelectPrimitive.ScrollDownButton>) => (
+ <SelectPrimitive.ScrollDownButton
+ data-slot="select-scroll-down-button"
+ className={cn(
+ "flex cursor-default items-center justify-center py-1",
+ className
+ )}
+ {...props}
+ >
+ <ChevronDownIcon className="size-4" />
+ </SelectPrimitive.ScrollDownButton>
+);
+
const SelectContent = ({
className,
children,
- position = "popper",
+ position = "item-aligned",
+ align = "center",
...props
}: React.ComponentProps<typeof SelectPrimitive.Content>) => (
<SelectPrimitive.Portal>
<SelectPrimitive.Content
data-slot="select-content"
className={cn(
- "relative z-50 max-h-96 min-w-[8rem] overflow-hidden rounded-md border bg-popover text-popover-foreground shadow-md data-[side=bottom]:translate-y-1 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[state=open]:animate-in data-[state=open]:fade-in-0 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
+ "relative z-50 max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-md border bg-popover text-popover-foreground shadow-md data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[state=open]:animate-in data-[state=open]:fade-in-0 data-[state=open]:zoom-in-95",
position === "popper" &&
"data-[side=bottom]:translate-y-1 data-[side=left]:-translate-x-1 data-[side=right]:translate-x-1 data-[side=top]:-translate-y-1",
className
)}
position={position}
+ align={align}
{...props}
>
+ <SelectScrollUpButton />
<SelectPrimitive.Viewport
className={cn(
"p-1",
position === "popper" &&
- "h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)]"
+ "h-[var(--radix-select-trigger-height)] w-full min-w-[var(--radix-select-trigger-width)] scroll-my-1"
)}
>
{children}
</SelectPrimitive.Viewport>
+ <SelectScrollDownButton />
</SelectPrimitive.Content>
</SelectPrimitive.Portal>
);
+const SelectLabel = ({
+ className,
+ ...props
+}: React.ComponentProps<typeof SelectPrimitive.Label>) => (
+ <SelectPrimitive.Label
+ data-slot="select-label"
+ className={cn("px-2 py-1.5 text-xs text-muted-foreground", className)}
+ {...props}
+ />
+);
+
const SelectItem = ({
className,
children,
@@ -87,12 +134,15 @@ const SelectItem = ({
<SelectPrimitive.Item
data-slot="select-item"
className={cn(
- "relative flex w-full cursor-default select-none items-center rounded-sm py-1.5 pl-8 pr-2 text-sm outline-none focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50",
+ "relative flex w-full cursor-default items-center gap-2 rounded-sm py-1.5 pr-8 pl-2 text-sm outline-hidden select-none focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4 [&_svg:not([class*='text-'])]:text-muted-foreground *:[span]:last:flex *:[span]:last:items-center *:[span]:last:gap-2",
className
)}
{...props}
>
- <span className="absolute left-2 flex size-3.5 items-center justify-center">
+ <span
+ data-slot="select-item-indicator"
+ className="absolute right-2 flex size-3.5 items-center justify-center"
+ >
<SelectPrimitive.ItemIndicator>
<CheckIcon className="size-4" />
</SelectPrimitive.ItemIndicator>
@@ -112,43 +162,12 @@ const SelectSeparator = ({
/>
);
-const SelectScrollUpButton = ({
- className,
- ...props
-}: React.ComponentProps<typeof SelectPrimitive.ScrollUpButton>) => (
- <SelectPrimitive.ScrollUpButton
- data-slot="select-scroll-up-button"
- className={cn(
- "flex cursor-default items-center justify-center py-1",
- className
- )}
- {...props}
- >
- <ChevronUpIcon className="size-4" />
- </SelectPrimitive.ScrollUpButton>
-);
-
-const SelectScrollDownButton = ({
- className,
- ...props
-}: React.ComponentProps<typeof SelectPrimitive.ScrollDownButton>) => (
- <SelectPrimitive.ScrollDownButton
- data-slot="select-scroll-down-button"
- className={cn(
- "flex cursor-default items-center justify-center py-1",
- className
- )}
- {...props}
- >
- <ChevronDownIcon className="size-4" />
- </SelectPrimitive.ScrollDownButton>
-);
-
export {
Select,
SelectContent,
SelectGroup,
SelectItem,
+ SelectLabel,
SelectScrollDownButton,
SelectScrollUpButton,
SelectSeparator,