Skip to content

PdfCraft: An open-source PDF reader and editor written by scratch in pure Rust

Name the Pages sidebar keyboard group and record its accessible snapshot

FredApps7227eb68ab38
diff --git a/crates/ui-egui/src/panels/pages.rs b/crates/ui-egui/src/panels/pages.rs
index cda3cb5ec..1d16331eb 100644
--- a/crates/ui-egui/src/panels/pages.rs
+++ b/crates/ui-egui/src/panels/pages.rs
@@ -91,6 +91,7 @@ pub(super) fn pages(ui: &mut egui::Ui, t: &Tokens, info: &DocInfo, view: &mut cr
let focus_id = ui.make_persistent_id(("pages-keyboard", view.id));
view.pages_focus_id = Some(focus_id);
let keyboard = ui.interact(ui.clip_rect(), focus_id, Sense::focusable_noninteractive());
+ keyboard.widget_info(|| egui::WidgetInfo::labeled(egui::Role::Group, ui.is_enabled(), tl!("Pages")));
let owns_keyboard = keyboard.has_focus();
// Escape remains with the panel after the pointer moves away.
ui.memory_mut(|m| m.set_focus_lock_filter(focus_id, egui::EventFilter { escape: true, ..Default::default() }));
diff --git a/crates/ui-egui/tests/it/view.rs b/crates/ui-egui/tests/it/view.rs
index c04bc1631..b9a01f408 100644
--- a/crates/ui-egui/tests/it/view.rs
+++ b/crates/ui-egui/tests/it/view.rs
@@ -57,6 +57,7 @@ fn sidebar_key(h: &mut Harness<'static, PdfCraftApp>, key: Key, modifiers: Modif
fn pages_sidebar_select_all_keeps_current_page_and_keyboard_scope() {
use egui_kittest::kittest::Queryable;
let mut h = harness(&[("panel", "pages")]);
+ let _ = h.get_by_role_and_label(egui::accesskit::Role::Group, "Pages");
h.get_by_label("Page 2").click();
h.run_steps(3);
assert_eq!(h.state().views[0].current, 1);
diff --git a/crates/ui-egui/tests/snapshots/panel_pages.txt b/crates/ui-egui/tests/snapshots/panel_pages.txt
index 7f432057d..e438fe379 100644
--- a/crates/ui-egui/tests/snapshots/panel_pages.txt
+++ b/crates/ui-egui/tests/snapshots/panel_pages.txt
@@ -7,6 +7,7 @@ Label = "100%"
Button "Smaller thumbnails" [off]
Slider "Thumbnail size"
Button "Larger thumbnails" [off]
+Group "Pages"
Button "Page 1" [off]
Label = "1"
Button "Page 2" [off]