Skip to content

PdfCraft: An open-source PDF reader and editor written by scratch in pure Rust

Review: isolate_annotations says that an index off the page's list is an error

Oliver Hagmannf0cd96e90bf6
diff --git a/crates/annot/src/lookup.rs b/crates/annot/src/lookup.rs
index 50097a5e9..c7a0fd983 100644
--- a/crates/annot/src/lookup.rs
+++ b/crates/annot/src/lookup.rs
@@ -231,6 +231,8 @@ pub fn isolate_annotation(doc: &mut Document, page: usize, index: usize) -> Resu
/// [`isolate_annotation`] for several annotations of one page: those of them with a normal
/// appearance stay, in their order on the page. `false`, with `doc` unchanged, when none has one.
+/// An index that isn't one of the page's annotations is an error even when the others are, and
+/// leaves `doc` unchanged too.
pub fn isolate_annotations(doc: &mut Document, page: usize, indices: &[usize]) -> Result<bool, AnnotError> {
let p = page_ref(doc, page)?;
let list = annots(doc, p);