PdfCraft: An open-source PDF reader and editor written by scratch in pure Rust
fix(xfa): require full save when stripping XFA packets (#4568)
Dylan M. Taylorf4f91d0d5cfc
diff --git a/crates/xfa/src/pdf.rs b/crates/xfa/src/pdf.rsindex 8e930c8f4..fd80949e8 100644--- a/crates/xfa/src/pdf.rs+++ b/crates/xfa/src/pdf.rs@@ -1203,6 +1203,7 @@ pub fn strip(doc: &mut Document) -> Result<Stripped, XfaError> {for r in streams {doc.free(r);}+ doc.require_full_save();Ok(out)}diff --git a/crates/xfa/src/tests.rs b/crates/xfa/src/tests.rsindex 3175882f8..f0e6816c2 100644--- a/crates/xfa/src/tests.rs+++ b/crates/xfa/src/tests.rs@@ -3350,6 +3350,7 @@ fn stripping_takes_the_xfa_out_and_leaves_an_ordinary_document() {ur.set(b"UR3".to_vec(), Object::Dict(pdfcraft_cos::Dict::new()));doc.update_dict(root, |d| d.set(b"Perms".to_vec(), Object::Dict(ur))).unwrap();let r = strip(&mut doc).unwrap();+ assert!(doc.full_save_required());assert_eq!(r.packets, vec!["template".to_string(), "datasets".to_string()]);assert_eq!(r.unbound_data, Some(0));assert_eq!((r.script_buttons, r.image_fields), (0, 1), "{r:?}");@@ -3435,6 +3436,16 @@ fn stripping_takes_the_xfa_out_and_leaves_an_ordinary_document() {assert!(started.elapsed() < std::time::Duration::from_secs(5), "{:?}", started.elapsed());}+#[test]+fn strip_marks_document_as_requiring_full_save() {+ use crate::pdf::strip;+ let mut doc = Document::open(Arc::new(shell(&fields_template("<form><page1><country>JP</country></page1></form>")))).unwrap();+ render_into(&mut doc).unwrap();+ assert!(!doc.full_save_required());+ strip(&mut doc).unwrap();+ assert!(doc.full_save_required(), "stripping XFA packets must require a full save to prevent data exposure in incremental saves");+}+#[test]fn som_indices_count_earlier_same_named_siblings() {let draw = |name: Option<&str>| {