Skip to content

armgit / peach

Public Imported from GitHub
0

Peach: Local-first video metadata scraper and media manager.

test(desktop): 隔离制品验收的远程诊断

longmeidao538d9dc653d2
diff --git a/docs/DIAGNOSTICS.md b/docs/DIAGNOSTICS.md
index 60d5ce152..2534a42ac 100644
--- a/docs/DIAGNOSTICS.md
+++ b/docs/DIAGNOSTICS.md
@@ -2,6 +2,8 @@
本页说明异常日志、浏览器错误上报、诊断导出与可选远程诊断的边界。正常取消、缓存回退、来源未命中和任务互斥保留各自状态。
+桌面制品验收在临时数据根显式关闭版本统计与错误上传,并在首启提交中保持关闭,避免合成测试进入正式遥测。
+
## 反馈入口
馆藏处理失败时,重试失败项,再从托盘「导出诊断报告」或系统诊断页「下载诊断报告」取得 ZIP。用户只需提供一个 ZIP。下载限运行 Peach 的本机,已登录的同源设备可以上报浏览器错误;开放访问模式不提供匿名远程上报。
diff --git a/scripts/smoke_desktop.py b/scripts/smoke_desktop.py
index f47d91ba7..d993c01d0 100644
--- a/scripts/smoke_desktop.py
+++ b/scripts/smoke_desktop.py
@@ -215,6 +215,11 @@ def wait_for(check, description: str, *, timeout: float = 60):
def smoke_environment(data: Path) -> dict[str, str]:
+ state = data / 'state'
+ state.mkdir(parents=True, exist_ok=True)
+ (state / 'remote-reporting.json').write_text(json.dumps({
+ 'usage': False, 'errors': False, 'revision': 'desktop-smoke',
+ }), encoding='utf-8')
environment = dict(os.environ, PEACH_DATA_ROOT=str(data), PYTHONIOENCODING="utf-8")
environment["LOCALAPPDATA"] = str(data.parent / "local-app-data")
environment.pop("PYTHONPATH", None)
@@ -369,7 +374,8 @@ def complete_first_run(opener, base: str, media: Path, port: int, password: str,
assert response.status == 200, path
answers = {"media_dir": [{"path": str(media), "location": "115"}], "host": "2",
"port": str(port), "mdns_name": "peach", "access_enabled": True,
- "access_password": password, "access_confirm": password}
+ "access_password": password, "access_confirm": password,
+ "remote_reporting": {"usage": False, "errors": False}}
if data_root is not None:
answers["data_root"] = str(data_root)
request = urllib.request.Request(base + "/api/setup", data=json.dumps(answers).encode(),
diff --git a/tests/test_scripts.py b/tests/test_scripts.py
index 7298f2764..fa5225f54 100644
--- a/tests/test_scripts.py
+++ b/tests/test_scripts.py
@@ -226,6 +226,24 @@ class DesktopSmokeTests(unittest.TestCase):
def setUpClass(cls):
cls.script = load_script("smoke_desktop")
+ def test_smoke_environment_disables_remote_reporting_before_startup(self):
+ from peach import remote_reporting
+ with tempfile.TemporaryDirectory() as directory:
+ data = Path(directory).resolve() / 'data'
+ environment = self.script.smoke_environment(data)
+ self.assertEqual(environment['PEACH_DATA_ROOT'], str(data))
+ config = SimpleNamespace(directory=lambda name: data / name)
+ self.assertEqual(remote_reporting.consent(config), {
+ 'usage': False, 'errors': False, 'revision': 'desktop-smoke',
+ })
+ with mock.patch.dict(os.environ, {
+ 'PEACH_SENTRY_DSN': 'https://[email protected]/1',
+ }), mock.patch.object(remote_reporting, '_disabled', False), \
+ mock.patch.object(remote_reporting, '_new_client') as client:
+ remote_reporting.usage(config)
+ remote_reporting.send('errors', {'level': 'error'}, config)
+ client.assert_not_called()
+
def test_distribution_resources_accept_an_application_without_private_exports(self):
with tempfile.TemporaryDirectory() as directory:
application = Path(directory).resolve()