Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Four small types that decide something get tests of their own

Țugui Dragoș98e0f6673e3b
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/DamagedFileTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/DamagedFileTests.swift
new file mode 100644
index 00000000..49428cf6
--- /dev/null
+++ b/Packages/PeelCore/Tests/PeelCoreTests/DamagedFileTests.swift
@@ -0,0 +1,31 @@
+import Foundation
+@testable import PeelCore
+import Testing
+
+struct DamagedFileTests {
+ @Test func setsAFileAsideWithoutReplacingOneSetAsideBefore() throws {
+ let directory = try TemporaryDirectory()
+ let url = try directory.file("Peel/removals.json", contents: Data("damaged".utf8))
+ let stamp = DateFormatter()
+ stamp.calendar = Calendar(identifier: .gregorian)
+ stamp.locale = Locale(identifier: "en_US_POSIX")
+ stamp.dateFormat = "yyyy-MM-dd-HHmmss"
+ let now = Date.now
+ let taken = try (0..<3).map { second in
+ let name = "removals-damaged-\(stamp.string(from: now.addingTimeInterval(Double(second)))).json"
+ return try directory.file("Peel/\(name)", contents: Data("earlier".utf8))
+ }
+
+ let aside = try #require(DamagedFile.setAside(url))
+
+ #expect(aside.lastPathComponent.wholeMatch(of: /removals-damaged-\d{4}-\d{2}-\d{2}-\d{6}-2\.json/) != nil)
+ #expect(try String(contentsOf: aside, encoding: .utf8) == "damaged")
+ #expect(try taken.allSatisfy { try String(contentsOf: $0, encoding: .utf8) == "earlier" })
+ #expect(!FileManager.default.fileExists(atPath: url.path(percentEncoded: false)))
+ }
+
+ @Test func answersNothingForAFileThatIsNotThere() throws {
+ let directory = try TemporaryDirectory()
+ #expect(DamagedFile.setAside(directory.url.appending(path: "missing.json")) == nil)
+ }
+}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/DeclaredIdentifierTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/DeclaredIdentifierTests.swift
new file mode 100644
index 00000000..8f81905c
--- /dev/null
+++ b/Packages/PeelCore/Tests/PeelCoreTests/DeclaredIdentifierTests.swift
@@ -0,0 +1,33 @@
+import Foundation
+@testable import PeelCore
+import Testing
+
+struct DeclaredIdentifierTests {
+ private func plist(_ values: [String: String]) throws -> Data {
+ try PropertyListSerialization.data(fromPropertyList: values, format: .xml, options: 0)
+ }
+
+ @Test func aPlugInDeclaresTheIdentifierInItsBundle() throws {
+ let directory = try TemporaryDirectory()
+ let plugIn = try directory.directory("Massive.vst3")
+ let info = try plist(["CFBundleIdentifier": "org.example.massive"])
+ try directory.file("Massive.vst3/Contents/Info.plist", contents: info)
+
+ #expect(DeclaredIdentifier.of(plugIn, kind: .plugIns) == "org.example.massive")
+ #expect(DeclaredIdentifier.of(plugIn, kind: .caches) == nil)
+ #expect(DeclaredIdentifier.of(try directory.directory("Empty.component"), kind: .plugIns) == nil)
+ }
+
+ @Test func aContainerNamedByAUUIDDeclaresItsOwner() throws {
+ let directory = try TemporaryDirectory()
+ let metadata = try plist(["MCMMetadataIdentifier": "org.example.notes"])
+ let file = ".com.apple.containermanagerd.metadata.plist"
+ let byUUID = try directory.directory("3F2504E0-4F89-11D3-9A0C-0305E82C3301")
+ try directory.file("3F2504E0-4F89-11D3-9A0C-0305E82C3301/\(file)", contents: metadata)
+ let byName = try directory.directory("org.example.other")
+ try directory.file("org.example.other/\(file)", contents: metadata)
+
+ #expect(DeclaredIdentifier.of(byUUID, kind: .containers) == "org.example.notes")
+ #expect(DeclaredIdentifier.of(byName, kind: .containers) == nil)
+ }
+}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/FileAccessTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/FileAccessTests.swift
new file mode 100644
index 00000000..dc877a20
--- /dev/null
+++ b/Packages/PeelCore/Tests/PeelCoreTests/FileAccessTests.swift
@@ -0,0 +1,24 @@
+import Foundation
+@testable import PeelCore
+import Testing
+
+struct FileAccessTests {
+ @Test func anItemInAFolderOfOnesOwnNeedsNoAdministrator() throws {
+ let directory = try TemporaryDirectory()
+ #expect(!FileAccess.requiresPrivilegesToRemove(try directory.file("Folder/file.txt")))
+ #expect(!FileAccess.requiresPrivilegesToRemove(try directory.directory("Folder/Inner")))
+ }
+
+ @Test(.permissionsHold) func anItemInAFolderThatCannotBeWrittenNeedsAnAdministrator() throws {
+ let directory = try TemporaryDirectory()
+ let file = try directory.file("Locked/file.txt")
+ try directory.setPermissions(0o555, of: "Locked")
+ defer { try? directory.setPermissions(0o755, of: "Locked") }
+
+ #expect(FileAccess.requiresPrivilegesToRemove(file))
+ }
+
+ @Test func whatMacOSOwnsNeedsAnAdministrator() {
+ #expect(FileAccess.requiresPrivilegesToRemove(URL(filePath: "/System/Applications/Calculator.app")))
+ }
+}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/FileLockTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/FileLockTests.swift
new file mode 100644
index 00000000..0efe31dd
--- /dev/null
+++ b/Packages/PeelCore/Tests/PeelCoreTests/FileLockTests.swift
@@ -0,0 +1,35 @@
+import Darwin
+import Foundation
+@testable import PeelCore
+import Testing
+
+struct FileLockTests {
+ private func isLocked(_ url: URL) -> Bool {
+ let descriptor = open(url.path(percentEncoded: false) + ".lock", O_RDWR | O_CLOEXEC)
+ guard descriptor >= 0 else { return false }
+ defer { close(descriptor) }
+ guard flock(descriptor, LOCK_EX | LOCK_NB) == 0 else { return errno == EWOULDBLOCK }
+ flock(descriptor, LOCK_UN)
+ return false
+ }
+
+ @Test func holdsTheLockForTheChangeAndNoLonger() throws {
+ let directory = try TemporaryDirectory()
+ let url = directory.url.appending(path: "Peel/exclusions.json")
+
+ let heldDuringTheChange = FileLock.whileHeld(beside: url) { isLocked(url) }
+
+ #expect(heldDuringTheChange)
+ #expect(!isLocked(url))
+ #expect(FileManager.default.fileExists(atPath: url.deletingLastPathComponent().path(percentEncoded: false)))
+ }
+
+ @Test(.permissionsHold) func runsTheChangeWhenNoLockCanBeMade() throws {
+ let directory = try TemporaryDirectory()
+ try directory.directory("Locked")
+ try directory.setPermissions(0o555, of: "Locked")
+ defer { try? directory.setPermissions(0o755, of: "Locked") }
+
+ #expect(FileLock.whileHeld(beside: directory.url.appending(path: "Locked/exclusions.json")) { 42 } == 42)
+ }
+}