Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Hold the package's tests to warnings as errors, as the checks do

Țugui Dragoș9a97a03b7ef7
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index b7973353..022e85bf 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -10,7 +10,7 @@
## Checklist
-- [ ] The app builds with no warnings, and `swift test --package-path Packages/PeelCore` passes, apart from `StringCatalogTests` for new or changed interface text, whose translations are added before merging.
+- [ ] The app builds with no warnings, and `swift test --package-path Packages/PeelCore -Xswiftc -warnings-as-errors` passes, apart from `StringCatalogTests` for new or changed interface text, whose translations are added before merging.
- [ ] Nothing of the user's is deleted for good: every removal goes through `TrashService`.
- [ ] New or changed interface text is in English, and `python3 Scripts/sync_localizations.py` ran after a Debug build.
- [ ] Nothing the change left unused stays behind.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 8b1cdfae..c987f87a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -55,10 +55,11 @@ without build output rather than empty the catalogs. After changing a command of
built.
The project's targets build with warnings as errors, and that is the bar a change has to clear. The package's
-manifest doesn't set it, so ask for it on the command line to hold the package to the same bar:
+manifest doesn't set it, so ask for it on the command line to hold the package, its tests included, to the
+same bar, as the Checks workflow and `Scripts/release.sh` do:
```bash
-swift build --package-path Packages/PeelCore -Xswiftc -warnings-as-errors
+swift test --package-path Packages/PeelCore -Xswiftc -warnings-as-errors
```
Tests run through the code Peel runs, on the Mac running them: a scan asks this Mac's Launch Services and reads its