Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Look in Shared and the account's temporary folder for an unusual command

Țugui Dragoșa79e57520766
diff --git a/Localization/Peel/Localizable.xcstrings b/Localization/Peel/Localizable.xcstrings
index a061d6a1..3e63c658 100644
--- a/Localization/Peel/Localizable.xcstrings
+++ b/Localization/Peel/Localizable.xcstrings
@@ -75242,108 +75242,216 @@
}
}
},
- "Its program sits in a temporary folder, where any program on this Mac can write. Software installed on purpose can do this too." : {
+ "Its program sits in /Users/Shared, where every account on this Mac can write. Software installed on purpose can do this too." : {
+ "comment" : "On a background job’s page, why its command is worth a second look: its program is in the folder every account shares. Keep /Users/Shared as written.",
"localizations" : {
"cs" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Program, který položka spouští, je v dočasné složce, kam může zapisovat kterýkoli program v tomto Macu. Totéž může dělat i záměrně nainstalovaný software."
+ "value" : "Program, který položka spouští, je ve složce /Users/Shared, kam může zapisovat každý účet v tomto Macu. Totéž může dělat i záměrně nainstalovaný software."
}
},
"de" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Sein Programm liegt in einem temporären Ordner, in den jedes Programm auf diesem Mac schreiben kann. Auch absichtlich installierte Software kann das tun."
+ "value" : "Sein Programm liegt in /Users/Shared, wo jeder Benutzeraccount auf diesem Mac schreiben kann. Auch absichtlich installierte Software kann das tun."
}
},
"es" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Su programa está en una carpeta temporal, donde cualquier programa de este Mac puede escribir. El software instalado a propósito también puede hacerlo."
+ "value" : "Su programa está en /Users/Shared, donde todas las cuentas de este Mac pueden escribir. El software instalado a propósito también puede hacerlo."
}
},
"fr" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Son programme se trouve dans un dossier temporaire, où n’importe quel programme de ce Mac peut écrire. Un logiciel installé volontairement peut aussi le faire."
+ "value" : "Son programme se trouve dans /Users/Shared, où tous les comptes de ce Mac peuvent écrire. Un logiciel installé volontairement peut aussi le faire."
}
},
"it" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Il suo programma si trova in una cartella temporanea, dove qualsiasi programma su questo Mac può scrivere. Anche un software installato di proposito può farlo."
+ "value" : "Il suo programma si trova in /Users/Shared, dove tutti gli account di questo Mac possono scrivere. Anche un software installato di proposito può farlo."
}
},
"ja" : {
"stringUnit" : {
"state" : "translated",
- "value" : "プログラムが一時フォルダにあり、そこにはこのMac上のどのプログラムでも書き込めます。意図的にインストールしたソフトウェアでも、同じことをする場合があります。"
+ "value" : "プログラムが/Users/Sharedにあり、そこにはこのMacのすべてのアカウントが書き込めます。意図的にインストールしたソフトウェアでも、同じことをする場合があります。"
}
},
"ko" : {
"stringUnit" : {
"state" : "translated",
- "value" : "이 항목의 프로그램은 이 Mac의 모든 프로그램이 쓸 수 있는 임시 폴더에 있습니다. 의도적으로 설치한 소프트웨어도 이렇게 할 수 있습니다."
+ "value" : "이 항목의 프로그램은 이 Mac의 모든 계정이 쓸 수 있는 /Users/Shared에 있습니다. 의도적으로 설치한 소프트웨어도 이렇게 할 수 있습니다."
}
},
"nl" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Het programma staat in een tijdelijke map, waarin elk programma op deze Mac kan schrijven. Software die bewust is geïnstalleerd, kan dit ook doen."
+ "value" : "Het programma staat in /Users/Shared, waarin elke account op deze Mac kan schrijven. Software die bewust is geïnstalleerd, kan dit ook doen."
}
},
"pl" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Program tej rzeczy znajduje się w folderze tymczasowym, w którym może zapisywać każdy program na tym Macu. Oprogramowanie zainstalowane celowo też może tak działać."
+ "value" : "Program tej rzeczy znajduje się w folderze /Users/Shared, w którym może zapisywać każde konto na tym Macu. Oprogramowanie zainstalowane celowo też może tak działać."
}
},
"pt" : {
"stringUnit" : {
"state" : "translated",
- "value" : "O programa que ele executa fica em uma pasta temporária, onde qualquer programa deste Mac pode gravar. Software instalado intencionalmente também pode fazer isso."
+ "value" : "O programa que ele executa fica em /Users/Shared, onde todas as contas deste Mac podem gravar. Software instalado intencionalmente também pode fazer isso."
}
},
"ro" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Programul său se află într‑un dosar temporar, în care poate scrie orice program de pe acest Mac. Și software‑ul instalat intenționat poate face acest lucru."
+ "value" : "Programul său se află în /Users/Shared, în care poate scrie orice cont de pe acest Mac. Și software‑ul instalat intenționat poate face acest lucru."
}
},
"ru" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Его программа находится во временной папке, в которую может записывать любая программа на этом Mac. Так может делать и намеренно установленное ПО."
+ "value" : "Его программа находится в папке /Users/Shared, в которую может записывать любая учетная запись на этом Mac. Так может делать и намеренно установленное ПО."
}
},
"sv" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Programmet ligger i en tillfällig mapp, där alla program på den här datorn kan skriva. Programvara som installerats avsiktligt kan också göra så."
+ "value" : "Programmet ligger i /Users/Shared, där alla konton på den här datorn kan skriva. Programvara som installerats avsiktligt kan också göra så."
}
},
"tr" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Programı, bu Mac’teki her programın yazabildiği geçici bir klasörde duruyor. Bilerek yüklenen yazılımlar da bunu yapabilir."
+ "value" : "Programı, bu Mac’teki her hesabın yazabildiği /Users/Shared klasöründe duruyor. Bilerek yüklenen yazılımlar da bunu yapabilir."
}
},
"uk" : {
"stringUnit" : {
"state" : "translated",
- "value" : "Його виконуваний файл лежить у тимчасовій папці, куди може записувати будь-яка програма на цьому Mac. Так може робити й ПЗ, інстальоване навмисно."
+ "value" : "Його виконуваний файл лежить у /Users/Shared, куди може записувати кожен обліковий запис на цьому Mac. Так може робити й ПЗ, інстальоване навмисно."
}
},
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
- "value" : "它的程序位于临时文件夹中,这台Mac上的任何程序都可以在那里写入。有意安装的软件也可能这样做。"
+ "value" : "它的程序位于/Users/Shared中,这台Mac上的每个账户都可以在那里写入。有意安装的软件也可能这样做。"
}
},
"zh-Hant" : {
"stringUnit" : {
"state" : "translated",
- "value" : "它的程式位於暫存檔案夾中,這部Mac上的任何程式都能寫入該處。刻意安裝的軟體也可能這樣做。"
+ "value" : "它的程式位於/Users/Shared中,這部Mac上的每個帳號都能寫入該處。刻意安裝的軟體也可能這樣做。"
+ }
+ }
+ }
+ },
+ "Its program sits in a temporary folder, a place for files that aren’t meant to stay. Software installed on purpose can do this too." : {
+ "comment" : "On a background job’s page, why its command is worth a second look: its program is in a temporary folder, the Mac’s own (/tmp) or the account’s.",
+ "localizations" : {
+ "cs" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Program, který položka spouští, je v dočasné složce, tedy na místě pro soubory, které tam nemají zůstat. Totéž může dělat i záměrně nainstalovaný software."
+ }
+ },
+ "de" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Sein Programm liegt in einem temporären Ordner, einem Ort für Dateien, die nicht dauerhaft bleiben sollen. Auch absichtlich installierte Software kann das tun."
+ }
+ },
+ "es" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Su programa está en una carpeta temporal, un lugar para archivos que no están pensados para quedarse. El software instalado a propósito también puede hacerlo."
+ }
+ },
+ "fr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Son programme se trouve dans un dossier temporaire, un emplacement destiné aux fichiers qui ne sont pas censés rester. Un logiciel installé volontairement peut aussi le faire."
+ }
+ },
+ "it" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Il suo programma si trova in una cartella temporanea, pensata per file non destinati a restare. Anche un software installato di proposito può farlo."
+ }
+ },
+ "ja" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "プログラムが一時フォルダにあります。一時フォルダは、残しておくことを想定していないファイルを置く場所です。意図的にインストールしたソフトウェアでも、同じことをする場合があります。"
+ }
+ },
+ "ko" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "이 항목의 프로그램은 계속 남겨 둘 목적이 아닌 파일을 두는 임시 폴더에 있습니다. 의도적으로 설치한 소프트웨어도 이렇게 할 수 있습니다."
+ }
+ },
+ "nl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Het programma staat in een tijdelijke map, een plek voor bestanden die niet bedoeld zijn om te blijven. Software die bewust is geïnstalleerd, kan dit ook doen."
+ }
+ },
+ "pl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Program tej rzeczy znajduje się w folderze tymczasowym, przeznaczonym na pliki, które nie mają zostawać na stałe. Oprogramowanie zainstalowane celowo też może tak działać."
+ }
+ },
+ "pt" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "O programa que ele executa fica em uma pasta temporária, um lugar para arquivos que não devem permanecer. Software instalado intencionalmente também pode fazer isso."
+ }
+ },
+ "ro" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Programul său se află într‑un dosar temporar, un loc pentru fișiere care nu sunt menite să rămână. Și software‑ul instalat intenționat poate face acest lucru."
+ }
+ },
+ "ru" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Его программа находится во временной папке, предназначенной для файлов, которые не должны там оставаться. Так может делать и намеренно установленное ПО."
+ }
+ },
+ "sv" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Programmet ligger i en tillfällig mapp, en plats för filer som inte är tänkta att ligga kvar. Programvara som installerats avsiktligt kan också göra så."
+ }
+ },
+ "tr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Programı, kalıcı olması amaçlanmayan dosyalara ayrılmış geçici bir klasörde duruyor. Bilerek yüklenen yazılımlar da bunu yapabilir."
+ }
+ },
+ "uk" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Його виконуваний файл лежить у тимчасовій папці, призначеній для файлів, які не мають там лишатися. Так може робити й ПЗ, інстальоване навмисно."
+ }
+ },
+ "zh-Hans" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "它的程序位于临时文件夹中,这类文件夹用来存放不打算长期保留的文件。有意安装的软件也可能这样做。"
+ }
+ },
+ "zh-Hant" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "它的程式位於暫存檔案夾中,那是存放不打算長久保留之檔案的地方。刻意安裝的軟體也可能這樣做。"
}
}
}
diff --git a/Packages/PeelCore/Sources/PeelCore/BackgroundItems/UnusualCommand.swift b/Packages/PeelCore/Sources/PeelCore/BackgroundItems/UnusualCommand.swift
index 501afafa..47444dad 100644
--- a/Packages/PeelCore/Sources/PeelCore/BackgroundItems/UnusualCommand.swift
+++ b/Packages/PeelCore/Sources/PeelCore/BackgroundItems/UnusualCommand.swift
@@ -4,8 +4,10 @@ internal import PeelPrivileged
/// What in a job's command is worth a second look, read from the command's shape and never from a name. It claims
/// nothing about the job: software installed on purpose can do any of these.
public enum UnusualCommand: String, Sendable, Hashable {
- /// The program sits in a temporary folder, which any process on the Mac can write to.
+ /// The program sits in a temporary folder: one any process on the Mac can write to, or an account's own.
case runsFromATemporaryFolder
+ /// The program sits in `/Users/Shared`, which every account on the Mac can write to.
+ case runsFromTheSharedFolder
/// The command downloads, with `curl` or `wget`.
case downloads
/// The command decodes base64, a way to carry a script that can't be read at a glance.
@@ -14,6 +16,9 @@ public enum UnusualCommand: String, Sendable, Hashable {
case runsCodeFromItsSettings
private static let temporaryFolders = ["/tmp", "/private/tmp", "/var/tmp", "/private/var/tmp"]
+ /// Where macOS keeps each account's folders, its temporary one being `<two names>/T` inside.
+ private static let accountFolders = ["/var/folders", "/private/var/folders"]
+ private static let decodingFlags: Set = ["-d", "-D", "--decode"]
private static let downloaders: Set = ["curl", "wget"]
private static let interpreters: Set = [
"sh", "bash", "zsh", "dash", "ksh", "csh", "tcsh", "fish",
@@ -24,11 +29,13 @@ public enum UnusualCommand: String, Sendable, Hashable {
init?(arguments: [String]) {
guard let program = arguments.first else { return nil }
let name = (program as NSString).lastPathComponent
- if Self.temporaryFolders.contains(where: { PathComponents.isPath(program, inside: $0) }) {
+ if Self.isTemporary(program) {
self = .runsFromATemporaryFolder
+ } else if PathComponents.isPath(program, inside: "/Users/Shared") {
+ self = .runsFromTheSharedFolder
} else if Self.downloaders.contains(name) {
self = .downloads
- } else if arguments.contains(where: { $0.contains("base64") }) {
+ } else if Self.decodesBase64(arguments) {
self = .decodesBase64
} else if Self.interpreters.contains(name), arguments.dropFirst().contains(where: ["-c", "-e"].contains) {
self = .runsCodeFromItsSettings
@@ -36,4 +43,23 @@ public enum UnusualCommand: String, Sendable, Hashable {
return nil
}
}
+
+ private static func isTemporary(_ program: String) -> Bool {
+ if temporaryFolders.contains(where: { PathComponents.isPath(program, inside: $0) }) { return true }
+ return accountFolders.contains { folder in
+ guard PathComponents.isPath(program, inside: folder) else { return false }
+ let below = PathComponents.of(program).dropFirst(PathComponents.of(folder).count)
+ return below.count > 3 && below.dropFirst(2).first == "T"
+ }
+ }
+
+ /// Whether the command runs `base64` to decode: the program, as a word of any argument, and a decoding flag after
+ /// it. A file or an option merely named so says nothing.
+ private static func decodesBase64(_ arguments: [String]) -> Bool {
+ let words = arguments.flatMap { $0.split { " \t\n|;&()".contains($0) }.map(String.init) }
+ guard let index = words.firstIndex(where: { ($0 as NSString).lastPathComponent == "base64" }) else {
+ return false
+ }
+ return words[(index + 1)...].contains(where: decodingFlags.contains)
+ }
}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/UnusualCommandTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/UnusualCommandTests.swift
index c84d7bbe..96dd399b 100644
--- a/Packages/PeelCore/Tests/PeelCoreTests/UnusualCommandTests.swift
+++ b/Packages/PeelCore/Tests/PeelCoreTests/UnusualCommandTests.swift
@@ -17,6 +17,15 @@ struct UnusualCommandTests {
(["/Applications/Example.app/Contents/MacOS/Example", "--background"], nil),
(["/bin/sh", "/Library/Application Support/Example/start.sh"], nil),
(["/usr/bin/open", "-e", "/Users/Shared/notes.txt"], nil),
+ (["/Users/Shared/org.example.helper"], .runsFromTheSharedFolder),
+ (["/private/var/folders/xy/abc123/T/org.example.helper"], .runsFromATemporaryFolder),
+ (["/var/folders/xy/abc123/T/helper", "--daemon"], .runsFromATemporaryFolder),
+ (["/private/var/folders/xy/abc123/C/org.example.app/helper"], nil),
+ (["/bin/sh", "-c", "echo aGk= | base64 -d | sh"], .decodesBase64),
+ (["/usr/bin/base64", "-D", "-i", "/Library/Example/payload"], .decodesBase64),
+ (["/Applications/Example.app/Contents/MacOS/tool", "--encoding=base64"], nil),
+ (["/usr/local/bin/convert", "/Users/me/notes-base64.txt", "--decode"], nil),
+ (["/usr/bin/base64", "-i", "in.bin", "-o", "out.txt"], nil),
]
for (arguments, expected) in cases {
#expect(UnusualCommand(arguments: arguments) == expected, "\(arguments)")
diff --git a/Peel/Views/BackgroundItems/BackgroundItemDetailView.swift b/Peel/Views/BackgroundItems/BackgroundItemDetailView.swift
index 8bac4f42..ec27834e 100644
--- a/Peel/Views/BackgroundItems/BackgroundItemDetailView.swift
+++ b/Peel/Views/BackgroundItems/BackgroundItemDetailView.swift
@@ -499,7 +499,9 @@ extension UnusualCommand {
var explanation: LocalizedStringResource {
switch self {
case .runsFromATemporaryFolder:
- "Its program sits in a temporary folder, where any program on this Mac can write. Software installed on purpose can do this too."
+ "Its program sits in a temporary folder, a place for files that aren’t meant to stay. Software installed on purpose can do this too."
+ case .runsFromTheSharedFolder:
+ "Its program sits in /Users/Shared, where every account on this Mac can write. Software installed on purpose can do this too."
case .downloads:
"Its command downloads from the internet each time it runs. Software installed on purpose can do this too."
case .decodesBase64: