Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Ask every change to be followed along its whole path

Țugui Dragoșa7e4d01dcd22
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index cff2fb12..17ce1c90 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -19,7 +19,7 @@
## Checklist
- [ ] The app builds with no warnings, and `swift test --package-path Packages/PeelCore -Xswiftc -warnings-as-errors` passes, apart from `StringCatalogTests` for new or changed interface text, whose translations are added before merging.
-- [ ] The change follows [AGENTS.md](../AGENTS.md): the problem was proved on a Mac before the change, and a test failed first.
+- [ ] The change follows [AGENTS.md](../AGENTS.md): the problem was proved on a Mac before the change, a test failed first, and everything that depends on the change was followed along its path and checked.
- [ ] Nothing of the user's is deleted for good: every removal goes through `TrashService`.
- [ ] New or changed interface text is in English, and `python3 Scripts/sync_localizations.py` ran after a Debug build.
- [ ] A changed command of `peel` has its manual page written again with `python3 Scripts/generate_manual.py`.
diff --git a/AGENTS.md b/AGENTS.md
index e29dc3a1..bb39b0ff 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -24,8 +24,11 @@ prove, and only then fix.
Check that it really catches the problem: put the old code back, watch it fail, and restore the fix.
4. **Fix the cause**, in the type or the rule where the fact belongs. No workaround, no special case keyed by a
name, no table on the side. A defect found on the way is fixed the same way, with its own test.
-5. **Follow the change end to end**, from where it starts to where it shows, and check that nothing depending on
- it changes behavior: callers, overrides, observers, the app and `peel` alike.
+5. **Follow the change along its whole path**, from where it starts to where it shows, and check every step of it
+ carefully. Find every function the change touches and every function that touches what it changed: callers,
+ readers, overrides, observers, the app, `peel`, the helper, and the tests. Check that none of them works worse
+ because of the change, and follow each one you find the same way, along its own path, until nothing that depends
+ on the change is left unchecked.
6. **Build and test after every change**, not only at the end: the whole package suite with warnings as errors,
and the app's Debug build ([CONTRIBUTING.md](CONTRIBUTING.md#what-you-need) has the commands).
7. **Check it where it shows**, live: open the page the change touches, or run the `peel` command it changes, and