Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Know where a test's root puts the helper's plug-in folders

Țugui Dragoșc3095a1782e2
diff --git a/Packages/PeelCore/Sources/PeelCore/Removal/HelperReach.swift b/Packages/PeelCore/Sources/PeelCore/Removal/HelperReach.swift
index c0037d5d..d750bd42 100644
--- a/Packages/PeelCore/Sources/PeelCore/Removal/HelperReach.swift
+++ b/Packages/PeelCore/Sources/PeelCore/Removal/HelperReach.swift
@@ -15,7 +15,8 @@ struct HelperReach: Sendable {
applicationLocations: [base + "/Applications"],
restoreLocations: PrivilegedPathPolicy.restoreLocations.map { base + $0 },
linkLocations: PrivilegedPathPolicy.linkLocations.map { base + $0 },
- manifestLocations: PrivilegedPathPolicy.manifestLocations.map { base + $0 }
+ manifestLocations: PrivilegedPathPolicy.manifestLocations.map { base + $0 },
+ plugInLocations: PrivilegedPathPolicy.plugInLocations.map { base + $0 }
)
}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/PluginsTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/PluginsTests.swift
index 496e82d0..e39f8834 100644
--- a/Packages/PeelCore/Tests/PeelCoreTests/PluginsTests.swift
+++ b/Packages/PeelCore/Tests/PeelCoreTests/PluginsTests.swift
@@ -65,6 +65,24 @@ struct PluginsTests {
#expect(plugins.first { $0.name == "Own" }?.staysInTheTrash == false)
}
+ @Test(.permissionsHold) func knowsAPlugInHistoryCouldNotPutBackInAFolderOfApplicationSupport() async throws {
+ let directory = try TemporaryDirectory()
+ try directory.directory("root/Library/Application Support/Avid/Audio/Plug-Ins/Synth.aaxplugin/Contents")
+ let folder = directory.url.appending(
+ path: "root/Library/Application Support/Avid/Audio/Plug-Ins", directoryHint: .isDirectory
+ )
+ try directory.setPermissions(0o555, of: folder)
+ defer { try? directory.setPermissions(0o755, of: folder) }
+ let environment = SearchEnvironment(
+ homeDirectory: directory.url.appending(path: "home", directoryHint: .isDirectory),
+ rootDirectory: directory.url.appending(path: "root", directoryHint: .isDirectory)
+ )
+
+ let plugins = await Plugins.scan(environment: environment).plugins
+
+ #expect(plugins.first { $0.name == "Synth" }?.staysInTheTrash == true)
+ }
+
@Test func knowsThePlugInsNothingLoadsAnymore() async throws {
let directory = try TemporaryDirectory()
try directory.directory("home/Library/QuickLook/Markdown.qlgenerator/Contents")