Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Keep Homebrew's own quit step out of an upgrade from Peel

Țugui Dragoșc3d22164d271
diff --git a/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift b/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
index af70491a..5a0534d4 100644
--- a/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
+++ b/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
@@ -1437,6 +1437,9 @@ public enum Homebrew {
// `brew upgrade` asks before it goes on unless this is set, and nobody is there to answer. It skips
// the question only because no terminal is attached (`ask.rb`). A version without it ignores it.
"HOMEBREW_NO_ASK": "1",
+ // Peel asks a cask's apps to quit before an upgrade. Homebrew's own step would ask again through Apple
+ // events, which macOS judges as Peel's. A version without it ignores it.
+ "HOMEBREW_NO_UPGRADE_QUIT_CASKS": "1",
]
// `brew.rb` writes each line as it goes only under `CI`. Otherwise Ruby holds what goes to standard output back
// in a pipe, and an error printed after a step shows before it. `brew doctor` reads `CI` as a CI run, though,
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
index 26714efb..59b66f4c 100644
--- a/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
+++ b/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
@@ -322,6 +322,7 @@ struct HomebrewTests {
@Test func anUpgradeNeverWaitsForAnAnswer() {
for autoUpdate in [true, false] {
#expect(Homebrew.environment(autoUpdate: autoUpdate)["HOMEBREW_NO_ASK"] == "1")
+ #expect(Homebrew.environment(autoUpdate: autoUpdate)["HOMEBREW_NO_UPGRADE_QUIT_CASKS"] == "1")
}
}