Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Stop asking contributors to sign off their commits

Țugui Dragoșd2f2960de45b
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 17ce1c90..e1b20d14 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -24,4 +24,3 @@
- [ ] New or changed interface text is in English, and `python3 Scripts/sync_localizations.py` ran after a Debug build.
- [ ] A changed command of `peel` has its manual page written again with `python3 Scripts/generate_manual.py`.
- [ ] Nothing the change left unused stays behind.
-- [ ] Every commit is signed off (`git commit -s`).
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index 4953aa79..2c2bf4c2 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -15,31 +15,6 @@ concurrency:
cancel-in-progress: true
jobs:
- # Every commit a pull request brings is signed off by its author, as CONTRIBUTING.md asks.
- sign-off:
- if: github.event_name == 'pull_request' && !github.event.repository.private
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
- with:
- fetch-depth: 0
-
- - name: Every commit is signed off by its author
- env:
- BASE: ${{ github.event.pull_request.base.sha }}
- HEAD: ${{ github.event.pull_request.head.sha }}
- run: |
- missing=0
- for commit in $(git rev-list --no-merges "$BASE..$HEAD"); do
- author=$(git show -s --format='%an <%ae>' "$commit")
- trailers=$(git show -s --format=%B "$commit" | git interpret-trailers --parse)
- if ! printf '%s\n' "$trailers" | grep -qxF "Signed-off-by: $author"; then
- echo "::error::Commit $(git rev-parse --short "$commit") is not signed off by its author."
- missing=1
- fi
- done
- exit $missing
-
test:
if: github.event_name == 'workflow_dispatch' || !github.event.repository.private
# Peel needs Swift 6.4, which comes with Xcode 27. GitHub offers Xcode 27 only on this preview image, on Apple
diff --git a/AGENTS.md b/AGENTS.md
index 7906a45b..4d7d891f 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -251,7 +251,7 @@ Peel runs on macOS 26 and later, and the two versions are treated differently in
## Commits and pull requests
- One change per commit, each building and passing the tests, with a message that says in plain words what changed
- for the person using Peel and why. Sign off every commit (`git commit -s`).
+ for the person using Peel and why.
- One change per pull request. Its description says what goes wrong without it, how it was tested (the test that
failed before and passes after, and the page or command it was checked on), and what couldn't be checked.
- If an assistant helped, say so in the description, and exactly how: what it wrote, what it reviewed, what it
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index d4656091..97a2ad53 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -107,8 +107,7 @@ Everyone taking part is expected to follow the [Code of Conduct](CODE_OF_CONDUCT
Peel is free software under the GNU General Public License, version 3 or later, and it will stay free. It isn't
sold and has no paid edition, so there is no separate commercial license for your work to be folded into.
-Sign off your commits with `git commit -s`. That is the [Developer Certificate of
-Origin](https://developercertificate.org/): you are saying the contribution is yours to give, under the same
-license as the rest of Peel. There is no copyright assignment and no agreement to sign, because nothing here will
-ever be relicensed out from under you. The Checks workflow checks every commit of a pull request for a sign-off by
-its author.
+What you contribute is under the same license as the rest of Peel, as [GitHub's Terms of
+Service](https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license)
+say for any repository with a license, and you are saying it is yours to give. There is no copyright assignment and
+no agreement to sign, because nothing here will ever be relicensed out from under you.