Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Leave a disabled Homebrew package out of what waits for an upgrade

Țugui Dragoșe5ad7811d220
diff --git a/Localization/Peel/Localizable.xcstrings b/Localization/Peel/Localizable.xcstrings
index adb842f0..64db17ab 100644
--- a/Localization/Peel/Localizable.xcstrings
+++ b/Localization/Peel/Localizable.xcstrings
@@ -105243,6 +105243,112 @@
}
}
},
+ "Only Homebrew could say whether %@ is up to date, but Homebrew has disabled it and no longer upgrades it. Look for an update inside the app, or on its maker’s website." : {
+ "localizations" : {
+ "cs" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Jen Homebrew by mohl říct, zda je aplikace %@ aktuální, ale Homebrew ji vyřadil a už ji neupgraduje. Aktualizaci hledejte přímo v aplikaci nebo na webu jejího výrobce."
+ }
+ },
+ "de" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Nur Homebrew könnte sagen, ob „%@“ auf dem neuesten Stand ist, aber Homebrew hat die App deaktiviert und führt keine Upgrades mehr für sie aus. Suche in der App selbst oder auf der Website des Herstellers nach einem Update."
+ }
+ },
+ "es" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Solo Homebrew podría decir si %@ está actualizada, pero Homebrew la ha desactivado y ya no la actualiza. Busca actualizaciones dentro de la app o en el sitio web de su fabricante."
+ }
+ },
+ "fr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Seul Homebrew pourrait dire si %@ est à jour, mais Homebrew l’a désactivé et ne le met plus à niveau. Recherchez une mise à jour dans l’app ou sur le site web de son éditeur."
+ }
+ },
+ "it" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Solo Homebrew potrebbe dire se %@ è aggiornata, ma Homebrew l’ha disabilitata e non la aggiorna più. Cerca un aggiornamento dall’interno dell’app o sul sito web del suo produttore."
+ }
+ },
+ "ja" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "“%@”が最新の状態かどうかがわかるのはHomebrewだけですが、Homebrewはこのアプリの提供を終了しており、今後はアップグレードしません。アプリ内か、開発元のWebサイトでアップデートを探してください。"
+ }
+ },
+ "ko" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "‘%@’이(가) 최신 버전인지는 Homebrew만 알려 줄 수 있지만, Homebrew가 이 앱을 비활성화하여 더 이상 업그레이드하지 않습니다. 앱 안이나 제작자의 웹사이트에서 업데이트를 찾아보십시오."
+ }
+ },
+ "nl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Alleen Homebrew zou kunnen zeggen of %@ up-to-date is, maar Homebrew heeft de app uitgeschakeld en upgradet die niet meer. Zoek in de app zelf of op de website van de maker naar een update."
+ }
+ },
+ "pl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Tylko Homebrew mógłby określić, czy aplikacja %@ jest aktualna, ale Homebrew ją wyłączył i już jej nie uaktualnia. Poszukaj uaktualnienia w samej aplikacji lub w witrynie jej producenta."
+ }
+ },
+ "pt" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Só o Homebrew poderia dizer se %@ está atualizado, mas o Homebrew o desativou e não faz mais upgrade dele. Procure uma atualização dentro do app ou no site do fabricante."
+ }
+ },
+ "ro" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Doar Homebrew ar putea spune dacă aplicația %@ este actualizată, dar Homebrew a dezactivat‑o și nu îi mai face upgrade. Căutați actualizări chiar în aplicație sau pe site‑ul web al producătorului ei."
+ }
+ },
+ "ru" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Только Homebrew мог бы сообщить, установлена ли новейшая версия приложения «%@», но Homebrew отключил его и больше не обновляет. Поищите обновление в самом приложении или на сайте его производителя."
+ }
+ },
+ "sv" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Bara Homebrew skulle kunna avgöra om %@ är uppdaterad, men Homebrew har avaktiverat den och uppgraderar den inte längre. Leta efter en uppdatering i appen eller på tillverkarens webbplats."
+ }
+ },
+ "tr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "%@ uygulamasının güncel olup olmadığını yalnızca Homebrew söyleyebilirdi, ancak Homebrew onu etkisizleştirdi ve artık yükseltmiyor. Uygulamanın içinde veya üreticisinin web sitesinde bir güncelleme olup olmadığına bakın."
+ }
+ },
+ "uk" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Сказати, чи потребує програма «%@» оновлення, міг би лише Homebrew, але Homebrew вимкнув цей пакет і більше його не оновлює. Пошукайте оновлення в самій програмі або на вебсайті її виробника."
+ }
+ },
+ "zh-Hans" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "只有Homebrew能判断“%@”是否为最新版本,但Homebrew已停用它,不再升级它。请在App内或其厂商的网站上查找更新。"
+ }
+ },
+ "zh-Hant" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "只有Homebrew能說明「%@」是否已是最新版本,但Homebrew已停用它,不再升級它。請在該App內或其廠商的網站上檢查更新。"
+ }
+ }
+ }
+ },
"Only Homebrew could say whether %@ is up to date, but Homebrew’s settings leave apps that update themselves to their own updates, so it doesn’t compare their versions. Look for an update inside the app." : {
"localizations" : {
"cs" : {
diff --git a/Packages/PeelCore/Sources/PeelCommandLine/Commands/AppCommands.swift b/Packages/PeelCore/Sources/PeelCommandLine/Commands/AppCommands.swift
index d85bf199..69f15450 100644
--- a/Packages/PeelCore/Sources/PeelCommandLine/Commands/AppCommands.swift
+++ b/Packages/PeelCore/Sources/PeelCommandLine/Commands/AppCommands.swift
@@ -862,6 +862,10 @@ struct UpdatesCommand: AsyncParsableCommand {
if left > 0 {
notes.append("Homebrew's settings leave \(Output.count(left, "app", "apps")) to update \(left == 1 ? "itself" : "themselves") (HOMEBREW_NO_UPGRADE_AUTO_UPDATES_CASKS), so Homebrew doesn't compare \(left == 1 ? "its version" : "their versions"), and whether \(left == 1 ? "it is" : "they are") up to date isn't known.")
}
+ let disabled = casks(.disabled).count
+ if disabled > 0 {
+ notes.append("Homebrew no longer upgrades \(Output.count(disabled, "app", "apps")) it installed, since it has disabled \(disabled == 1 ? "its cask" : "their casks"), so whether \(disabled == 1 ? "it is" : "they are") up to date isn't known.")
+ }
return notes.compactMap(\.self)
}
diff --git a/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift b/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
index 246afece..8bd39a83 100644
--- a/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
+++ b/Packages/PeelCore/Sources/PeelCore/Homebrew/Homebrew.swift
@@ -75,6 +75,7 @@ public struct HomebrewPackage: Sendable, Hashable, Identifiable {
/// Why Homebrew's `outdated` says nothing of whether this cask's app is behind, or nil when Homebrew compares its
/// version: a cask written `version :latest` installs whatever is newest each time.
public var whyHomebrewCannotCompare: HomebrewCannotTell.Reason? {
+ if !isStillUpgraded { return .disabled }
if latestVersion == "latest" { return .installsTheNewest }
return isLeftToItsApp ? .leftToTheApp : nil
}
@@ -89,13 +90,19 @@ public struct HomebrewPackage: Sendable, Hashable, Identifiable {
/// Whether Upgrade All takes it along when it is out of date: a pinned package is held at its version on purpose,
/// and a cask whose upgrade needs an administrator is upgraded in Terminal.
public var joinsUpgradeAll: Bool {
- !isPinned && !upgradeNeedsAnAdministrator && !isMissingWhatItInstalled && !isStoppedMidUpgrade
+ isStillUpgraded && !isPinned && !upgradeNeedsAnAdministrator && !isMissingWhatItInstalled
+ && !isStoppedMidUpgrade
}
/// Whether Homebrew offers a newer version that it can install. It upgrades a cask's app where it put it, so it
/// can't upgrade a cask whose apps are gone.
public var waitsForAnUpgrade: Bool {
- isOutdated && !isMissingWhatItInstalled && !isStoppedMidUpgrade
+ isOutdated && isStillUpgraded && !isMissingWhatItInstalled && !isStoppedMidUpgrade
+ }
+
+ /// Whether Homebrew still upgrades it: one it has disabled gets no more upgrades, though `outdated` may say it is.
+ public var isStillUpgraded: Bool {
+ retirement?.stage != .disabled
}
/// Returns a copy that notes whether what the installed cask put on the Mac is all gone, asked of the disk now: its
diff --git a/Packages/PeelCore/Sources/PeelCore/Updates/UpdateChecker.swift b/Packages/PeelCore/Sources/PeelCore/Updates/UpdateChecker.swift
index 2020a804..b9bcfb7f 100644
--- a/Packages/PeelCore/Sources/PeelCore/Updates/UpdateChecker.swift
+++ b/Packages/PeelCore/Sources/PeelCore/Updates/UpdateChecker.swift
@@ -159,7 +159,7 @@ public struct UpdateChecker: Sendable {
/// The status Homebrew reports at `now` for `cask`, known to be the app's at `appVersion`, or nil when it can't
/// tell (`whyHomebrewCannotTell(about:at:)`).
static func homebrewStatus(of cask: HomebrewPackage, appVersion: String?, at now: Date) -> UpdateStatus? {
- if cask.isOutdated, let latest = cask.latestVersion, !isAlready(appVersion, at: latest) {
+ if cask.waitsForAnUpgrade, let latest = cask.latestVersion, !isAlready(appVersion, at: latest) {
return .updateAvailable(version: latest, source: .homebrew, releaseNotes: cask.homepage)
}
return whyHomebrewCannotTell(about: cask, at: now) == nil ? .upToDate : nil
@@ -538,6 +538,8 @@ public struct HomebrewCannotTell: Sendable, Hashable {
/// The app updates itself, and Homebrew's settings leave such casks to their apps
/// (`HOMEBREW_NO_UPGRADE_AUTO_UPDATES_CASKS`).
case leftToTheApp
+ /// Homebrew has disabled the cask, so it no longer upgrades it.
+ case disabled
}
public let cask: HomebrewPackage
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/CommandLineTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/CommandLineTests.swift
index c5b1518b..5db11750 100644
--- a/Packages/PeelCore/Tests/PeelCoreTests/CommandLineTests.swift
+++ b/Packages/PeelCore/Tests/PeelCoreTests/CommandLineTests.swift
@@ -1044,11 +1044,12 @@ struct CommandLineTests {
#expect(UpdatesCommand.notes(about: [], timeZone: utc).isEmpty)
#expect(UpdatesCommand.notes(about: [notChecked(checked)], timeZone: utc) == ["Homebrew last checked for new versions on 2026-10-18, so whether 1 app it installed is up to date isn't known. Run `brew update`, then check again."])
#expect(UpdatesCommand.notes(about: [notChecked(cask), notChecked(cask)], timeZone: utc) == ["Homebrew doesn't say when it last checked for new versions, so whether 2 apps it installed are up to date isn't known."])
- let reasons: [HomebrewCannotTell.Reason] = [.installsTheNewest, .leftToTheApp, .leftToTheApp]
+ let reasons: [HomebrewCannotTell.Reason] = [.installsTheNewest, .leftToTheApp, .leftToTheApp, .disabled]
let others = reasons.map { HomebrewCannotTell(cask: cask, reason: $0) }
#expect(UpdatesCommand.notes(about: others, timeZone: utc) == [
"1 app Homebrew installed gets whatever is newest each time, so Homebrew has no version to compare, and whether it is up to date isn't known.",
"Homebrew's settings leave 2 apps to update themselves (HOMEBREW_NO_UPGRADE_AUTO_UPDATES_CASKS), so Homebrew doesn't compare their versions, and whether they are up to date isn't known.",
+ "Homebrew no longer upgrades 1 app it installed, since it has disabled its cask, so whether it is up to date isn't known.",
])
}
diff --git a/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift b/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
index fb8e166e..287a68e6 100644
--- a/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
+++ b/Packages/PeelCore/Tests/PeelCoreTests/HomebrewTests.swift
@@ -19,6 +19,22 @@ struct HomebrewTests {
/// `man brew`: unless `HOMEBREW_NO_INSTALL_CLEANUP` is set, `brew upgrade` runs `brew cleanup` by itself, for
/// the upgraded packages and every 30 days for all of them, which deletes old versions and downloads for good.
/// Peel deletes those only through Clean Up, which asks first, so no call it makes may clean up on its own.
+ @Test func aDisabledPackageWaitsForNoUpgrade() {
+ func package(_ stage: HomebrewRetirement.Stage?) -> HomebrewPackage {
+ HomebrewPackage(
+ name: "tool", kind: .cask, installedVersion: "1.0", latestVersion: "2.0", isOutdated: true,
+ retirement: stage.map { HomebrewRetirement(stage: $0, reason: nil, disableDate: nil, replacement: nil) }
+ )
+ }
+
+ #expect(package(nil).waitsForAnUpgrade && package(nil).joinsUpgradeAll)
+ #expect(package(.deprecated).waitsForAnUpgrade && package(.deprecated).joinsUpgradeAll)
+ #expect(!package(.disabled).waitsForAnUpgrade)
+ #expect(!package(.disabled).joinsUpgradeAll)
+ #expect(package(.disabled).whyHomebrewCannotCompare == .disabled)
+ #expect(UpdateChecker.homebrewStatus(of: package(.disabled), appVersion: "1.0", at: .now) == nil)
+ }
+
@Test func knowsWhenSudoAskedForAPassword() {
let sudo = """
==> Running installer for zoom with sudo; the password may be necessary.
diff --git a/Peel/Views/Homebrew/HomebrewVulnerabilities.swift b/Peel/Views/Homebrew/HomebrewVulnerabilities.swift
index c6e53fe1..704fe17d 100644
--- a/Peel/Views/Homebrew/HomebrewVulnerabilities.swift
+++ b/Peel/Views/Homebrew/HomebrewVulnerabilities.swift
@@ -10,7 +10,7 @@ struct HomebrewVulnerabilitySections: View {
var body: some View {
Section {
Group {
- if package.isOutdated, let latest = package.latestVersion {
+ if package.waitsForAnUpgrade, let latest = package.latestVersion {
Text("Homebrew’s scan found these in version \(advisory.version), installed on this Mac. Homebrew offers \(latest): once it is installed, scan again to see which of these it fixes.")
} else {
Text("Homebrew’s scan found these in version \(advisory.version), installed on this Mac. They leave this list once the formula is upgraded to a version with the fix and the scan runs again.")
diff --git a/Peel/Views/UpdateStatusBadge.swift b/Peel/Views/UpdateStatusBadge.swift
index 40054ad7..c7085838 100644
--- a/Peel/Views/UpdateStatusBadge.swift
+++ b/Peel/Views/UpdateStatusBadge.swift
@@ -81,6 +81,8 @@ struct UpdateStatusBadge: View {
Text("Only Homebrew could say whether \(app.name) is up to date, but it installs whatever is newest each time, so it has no version to compare this copy with. Look for an update inside the app.")
case .leftToTheApp:
Text("Only Homebrew could say whether \(app.name) is up to date, but Homebrew’s settings leave apps that update themselves to their own updates, so it doesn’t compare their versions. Look for an update inside the app.")
+ case .disabled:
+ Text("Only Homebrew could say whether \(app.name) is up to date, but Homebrew has disabled it and no longer upgrades it. Look for an update inside the app, or on its maker’s website.")
}
case .cameWithMacOS:
Text("\(app.name) came with macOS. Software Update is what keeps it current, so Peel has nothing to ask.")