Skip to content

armgit / peel

Public Imported from GitHub
0

Uninstall Mac apps with every file they leave behind, and see why each belongs. Free up space, fine-tune macOS, and set up Terminal.

Upgrading one Homebrew package asks first, as Upgrade All does

Țugui Dragoșfce81625e319
diff --git a/Localization/Peel/Localizable.xcstrings b/Localization/Peel/Localizable.xcstrings
index a198739f..38744f57 100644
--- a/Localization/Peel/Localizable.xcstrings
+++ b/Localization/Peel/Localizable.xcstrings
@@ -135581,6 +135581,112 @@
}
}
},
+ "Upgrade %@?" : {
+ "localizations" : {
+ "cs" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Upgradovat %@?"
+ }
+ },
+ "de" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "„%@“ upgraden?"
+ }
+ },
+ "es" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "¿Actualizar %@?"
+ }
+ },
+ "fr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Mettre à niveau %@ ?"
+ }
+ },
+ "it" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Vuoi aggiornare %@?"
+ }
+ },
+ "ja" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "“%@”をアップグレードしますか?"
+ }
+ },
+ "ko" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "‘%@’을(를) 업그레이드하겠습니까?"
+ }
+ },
+ "nl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "%@ upgraden?"
+ }
+ },
+ "pl" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Uaktualnić %@?"
+ }
+ },
+ "pt" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Fazer upgrade de %@?"
+ }
+ },
+ "ro" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Faceți upgrade la %@?"
+ }
+ },
+ "ru" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Обновить «%@»?"
+ }
+ },
+ "sv" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Vill du uppgradera %@?"
+ }
+ },
+ "tr" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "%@ paketi yükseltilsin mi?"
+ }
+ },
+ "uk" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "Оновити «%@»?"
+ }
+ },
+ "zh-Hans" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "要升级“%@”吗?"
+ }
+ },
+ "zh-Hant" : {
+ "stringUnit" : {
+ "state" : "translated",
+ "value" : "要升級「%@」嗎?"
+ }
+ }
+ }
+ },
"Upgrade All" : {
"localizations" : {
"cs" : {
diff --git a/Peel/Views/Homebrew/HomebrewDetailView.swift b/Peel/Views/Homebrew/HomebrewDetailView.swift
index d4a71f61..1f22c519 100644
--- a/Peel/Views/Homebrew/HomebrewDetailView.swift
+++ b/Peel/Views/Homebrew/HomebrewDetailView.swift
@@ -6,6 +6,7 @@ struct HomebrewDetailView: View {
@Environment(AppLibrary.self) private var library
@Environment(ExclusionsStore.self) private var exclusions
@State private var isConfirmingUninstall = false
+ @State private var isConfirmingUpgrade = false
let package: HomebrewPackage
var body: some View {
@@ -89,7 +90,7 @@ struct HomebrewDetailView: View {
CopyButton(text: "brew upgrade \(kind) \(package.fullName)", title: "Copy Upgrade Command")
} else {
Button("Upgrade", systemImage: "arrow.down.circle") {
- Task { await homebrew.run(.upgrade(package.id)) }
+ isConfirmingUpgrade = true
}
.buttonStyle(.borderedProminent)
.disabled(package.isPinned)
@@ -130,6 +131,13 @@ struct HomebrewDetailView: View {
.formStyle(.grouped)
.navigationTitle(package.name)
.toolbar(removing: .title)
+ // Asked first, as Upgrade All is: an upgrade can run for a long time while Homebrew builds on this Mac.
+ .confirmationDialog("Upgrade \(package.name)?", isPresented: $isConfirmingUpgrade) {
+ Button("Upgrade") { Task { await homebrew.run(.upgrade(package.id)) } }
+ Button("Cancel", role: .cancel) {}
+ } message: {
+ Text("This can take a long time, since Homebrew builds some packages on this Mac. Its progress shows on this page as it works, and you can stop it there.")
+ }
.confirmationDialog("Uninstall \(package.name)?", isPresented: $isConfirmingUninstall) {
Button("Uninstall", role: .destructive) {
// Checks again, since the exclusions can change while the dialog is open.