Skip to content

Fully autonomous AI Agents system capable of performing complex penetration testing tasks

refactor(editor): standardize view mode as Rich/Raw segmented toggle

Sergey Kozyrenko15d802618019
diff --git a/frontend/src/components/shared/editor-view-mode.tsx b/frontend/src/components/shared/editor-view-mode.tsx
new file mode 100644
index 00000000..aa602bca
--- /dev/null
+++ b/frontend/src/components/shared/editor-view-mode.tsx
@@ -0,0 +1,41 @@
+import { Code, Eye } from 'lucide-react';
+
+import { Tabs, TabsList, TabsTrigger } from '@/components/ui/tabs';
+
+// 'rich' reflows whitespace on save (tiptap); 'raw' is a byte-exact textarea over the source.
+export type EditorViewMode = 'raw' | 'rich';
+
+interface EditorViewModeToggleProps {
+ className?: string;
+ mode: EditorViewMode;
+ onModeChange: (mode: EditorViewMode) => void;
+ rawTooltip?: string;
+}
+
+export function EditorViewModeToggle({ className, mode, onModeChange, rawTooltip }: EditorViewModeToggleProps) {
+ return (
+ <Tabs
+ className={className}
+ onValueChange={(value) => onModeChange(value as EditorViewMode)}
+ value={mode}
+ >
+ <TabsList className="h-7 p-0.5">
+ <TabsTrigger
+ aria-label="Rich editor"
+ className="h-6 px-2"
+ value="rich"
+ >
+ <Eye className="size-4" />
+ </TabsTrigger>
+ <TabsTrigger
+ aria-label="Raw source"
+ className="h-6 px-2"
+ title={rawTooltip}
+ value="raw"
+ >
+ <Code className="size-4" />
+ </TabsTrigger>
+ </TabsList>
+ </Tabs>
+ );
+}
diff --git a/frontend/src/features/knowledges/knowledge-form-controls.tsx b/frontend/src/features/knowledges/knowledge-form-controls.tsx
index c64366f7..385d7b1b 100644
--- a/frontend/src/features/knowledges/knowledge-form-controls.tsx
+++ b/frontend/src/features/knowledges/knowledge-form-controls.tsx
@@ -5,6 +5,7 @@ import type {
KnowledgeGuideType as KnowledgeGuideTypeT,
} from '@/graphql/types';
+import { type EditorViewMode } from '@/components/shared/editor-view-mode';
import { MarkdownEditor } from '@/components/shared/markdown-editor';
import {
Autocomplete,
@@ -76,8 +77,7 @@ interface KnowledgeContentFieldProps {
fillParent?: boolean;
hasLabel?: boolean;
isSaving: boolean;
- /** 'visual' (default) = rich MarkdownEditor; 'plain' = raw-markdown textarea. */
- viewMode?: 'plain' | 'visual';
+ viewMode?: EditorViewMode;
}
interface KnowledgeMetaFieldsProps {
@@ -91,7 +91,7 @@ export function KnowledgeContentField({
fillParent = false,
hasLabel = false,
isSaving,
- viewMode = 'visual',
+ viewMode = 'rich',
}: KnowledgeContentFieldProps) {
return (
<FormField
@@ -101,7 +101,7 @@ export function KnowledgeContentField({
<FormItem className={fillParent ? 'flex min-h-0 flex-1 flex-col' : undefined}>
{hasLabel ? <FormLabel>Content</FormLabel> : null}
<FormControl>
- {viewMode === 'plain' ? (
+ {viewMode === 'raw' ? (
<Textarea
autoSize={false}
className={cn(
diff --git a/frontend/src/features/knowledges/knowledge-form-layout.tsx b/frontend/src/features/knowledges/knowledge-form-layout.tsx
index 49ae51cb..59e494a5 100644
--- a/frontend/src/features/knowledges/knowledge-form-layout.tsx
+++ b/frontend/src/features/knowledges/knowledge-form-layout.tsx
@@ -3,6 +3,7 @@ import type { Control } from 'react-hook-form';
import type { KnowledgeDocumentFragmentFragment } from '@/graphql/types';
import { DetailTwoPanelLayout } from '@/components/shared/detail-two-panel-layout';
+import { type EditorViewMode } from '@/components/shared/editor-view-mode';
import { Badge } from '@/components/ui/badge';
import type { FormValues } from './knowledge-form';
@@ -14,7 +15,7 @@ interface KnowledgeFormLayoutProps {
isNew: boolean;
isSaving: boolean;
knowledge?: KnowledgeDocumentFragmentFragment | null;
- viewMode?: 'plain' | 'visual';
+ viewMode?: EditorViewMode;
}
interface KnowledgeIntroBlockProps {
diff --git a/frontend/src/features/knowledges/knowledge-form.tsx b/frontend/src/features/knowledges/knowledge-form.tsx
index 7b1887e9..2f74b0f9 100644
--- a/frontend/src/features/knowledges/knowledge-form.tsx
+++ b/frontend/src/features/knowledges/knowledge-form.tsx
@@ -14,6 +14,7 @@ import type {
} from '@/graphql/types';
import { AppHeaderAction } from '@/components/layouts/app/app-header';
+import { type EditorViewMode } from '@/components/shared/editor-view-mode';
import { UnsavedChangesDialog, useUnsavedChangesGuard } from '@/components/shared/unsaved-changes';
import { Form } from '@/components/ui/form';
import { Spinner } from '@/components/ui/spinner';
@@ -193,7 +194,7 @@ export function KnowledgeForm({ initialValues, isNew, knowledge, onSubmit }: Kno
const { isDesktop } = useBreakpoint();
const [isSaving, setIsSaving] = useState(false);
const [isAnonymizing, setIsAnonymizing] = useState(false);
- const [viewMode, setViewMode] = useState<'plain' | 'visual'>('visual');
+ const [viewMode, setViewMode] = useState<EditorViewMode>('rich');
const [anonymizeMutation] = useMutation(AnonymizeTextDocument);
const { authInfo } = useUser();
const canAnonymize = authInfo?.privileges?.includes('anonymize.call') ?? false;
@@ -382,7 +383,7 @@ export function KnowledgeForm({ initialValues, isNew, knowledge, onSubmit }: Kno
knowledge={knowledge}
onAnonymize={handleAnonymize}
onBeforeNavigateAway={skipNextBlock}
- onToggleViewMode={() => setViewMode((m) => (m === 'visual' ? 'plain' : 'visual'))}
+ onModeChange={setViewMode}
saveButton={saveButton}
viewMode={viewMode}
/>
diff --git a/frontend/src/features/knowledges/knowledge-header.tsx b/frontend/src/features/knowledges/knowledge-header.tsx
index cf7dea42..e3ed9f8e 100644
--- a/frontend/src/features/knowledges/knowledge-header.tsx
+++ b/frontend/src/features/knowledges/knowledge-header.tsx
@@ -1,6 +1,6 @@
import type { ReactNode } from 'react';
-import { Code, Ellipsis, Eye, HatGlasses, LibraryBig, Loader2, Pencil, Trash } from 'lucide-react';
+import { Ellipsis, HatGlasses, LibraryBig, Loader2, Pencil, Trash } from 'lucide-react';
import { useCallback, useState } from 'react';
import { useNavigate } from 'react-router-dom';
import { toast } from 'sonner';
@@ -14,6 +14,7 @@ import {
DetailNavigationSheet,
DetailNavigationToolbar,
} from '@/components/shared/detail-navigation';
+import { type EditorViewMode, EditorViewModeToggle } from '@/components/shared/editor-view-mode';
import { InlineEditInput, useInlineEdit } from '@/components/shared/inline-edit';
import { Badge } from '@/components/ui/badge';
import { Breadcrumb, BreadcrumbItem, BreadcrumbList, BreadcrumbPage } from '@/components/ui/breadcrumb';
@@ -52,9 +53,9 @@ interface KnowledgeHeaderProps {
*/
onAnonymize?: () => void;
onBeforeNavigateAway?: () => void;
- onToggleViewMode?: () => void;
+ onModeChange?: (mode: EditorViewMode) => void;
saveButton?: ReactNode;
- viewMode?: 'plain' | 'visual';
+ viewMode?: EditorViewMode;
}
const renderKnowledgeItem = (item: Knowledge, isCurrent: boolean): ReactNode => (
@@ -77,9 +78,9 @@ export function KnowledgeHeader({
knowledge,
onAnonymize,
onBeforeNavigateAway,
- onToggleViewMode,
+ onModeChange,
saveButton,
- viewMode = 'visual',
+ viewMode = 'rich',
}: KnowledgeHeaderProps) {
const navigate = useNavigate();
const { isMobile } = useBreakpoint();
@@ -214,7 +215,7 @@ export function KnowledgeHeader({
/>
)}
{saveButton}
- {(canShowActions || (isMobile && canAnonymize) || !!onToggleViewMode) && (
+ {(canShowActions || (isMobile && canAnonymize) || !!onModeChange) && (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
@@ -249,7 +250,7 @@ export function KnowledgeHeader({
</>
)}
</DropdownMenuItem>
- {(canShowActions || onToggleViewMode) && <DropdownMenuSeparator />}
+ {(canShowActions || onModeChange) && <DropdownMenuSeparator />}
</>
)}
{isMobile && knowledgeNav.total > 0 && (
@@ -271,19 +272,23 @@ export function KnowledgeHeader({
<DropdownMenuSeparator />
</>
)}
- {onToggleViewMode ? (
- <DropdownMenuItem onClick={onToggleViewMode}>
- {viewMode === 'plain' ? (
- <Eye className="size-4" />
- ) : (
- <Code className="size-4" />
- )}
- {viewMode === 'plain' ? 'Visual editor' : 'Plain text'}
+ {onModeChange ? (
+ <DropdownMenuItem
+ className="gap-4"
+ onSelect={(event) => event.preventDefault()}
+ >
+ View
+ <EditorViewModeToggle
+ className="-my-1.5 -mr-2 ml-auto"
+ mode={viewMode}
+ onModeChange={onModeChange}
+ rawTooltip="Edit the raw markdown"
+ />
</DropdownMenuItem>
) : null}
{canShowActions && (
<>
- {onToggleViewMode ? <DropdownMenuSeparator /> : null}
+ {onModeChange ? <DropdownMenuSeparator /> : null}
<DropdownMenuItem onClick={handleRenameStart}>
<Pencil className="size-3" />
Rename
diff --git a/frontend/src/pages/settings/settings-prompt.tsx b/frontend/src/pages/settings/settings-prompt.tsx
index a966cfae..4d44385b 100644
--- a/frontend/src/pages/settings/settings-prompt.tsx
+++ b/frontend/src/pages/settings/settings-prompt.tsx
@@ -12,7 +12,6 @@ import {
Loader2,
RotateCcw,
Save,
- Type,
User,
Wrench,
XCircle,
@@ -48,6 +47,8 @@ import type {
ValidatePromptMutation,
} from '@/graphql/types';
+import { type EditorViewMode, EditorViewModeToggle } from '@/components/shared/editor-view-mode';
+
type AgentPrompt = AgentPrompts;
type AgentPrompts = { human?: DefaultPrompt; system: DefaultPrompt };
@@ -384,14 +385,14 @@ function SettingsPrompt() {
const [validationResult, setValidationResult] = useState<null | ValidatePromptMutation['validatePrompt']>(null);
const [validationDialogOpen, setValidationDialogOpen] = useState(false);
const [isDiffDialogOpen, setIsDiffDialogOpen] = useState(false);
- const [viewMode, setViewMode] = useState<'code' | 'plain'>('code');
+ const [viewMode, setViewMode] = useState<EditorViewMode>('rich');
const editorRef = useRef<MarkdownEditorHandle>(null);
const isLoading = isCreateLoading || isUpdateLoading || isDeleteLoading || isValidateLoading;
const handleVariableClick = useCallback(
(variable: string, field: { onChange: (value: string) => void; value: string }, formId: string) => {
- if (viewMode === 'code') {
+ if (viewMode === 'rich') {
if (!editorRef.current?.cycleToVariable(variable)) {
editorRef.current?.insertAtCursor(`{{.${variable}}}`);
}
@@ -858,10 +859,16 @@ function SettingsPrompt() {
className="min-w-24"
>
<DropdownMenuItem
- onClick={() => setViewMode((mode) => (mode === 'code' ? 'plain' : 'code'))}
+ className="gap-4"
+ onSelect={(event) => event.preventDefault()}
>
- {viewMode === 'code' ? <Type className="size-4" /> : <Code className="size-4" />}
- {viewMode === 'code' ? 'Plain text' : 'Code editor'}
+ View
+ <EditorViewModeToggle
+ className="-my-1.5 -mr-2 ml-auto"
+ mode={viewMode}
+ onModeChange={setViewMode}
+ rawTooltip="Edit the raw prompt template"
+ />
</DropdownMenuItem>
{hasOverride && (
<>
@@ -1008,7 +1015,7 @@ function SettingsPrompt() {
id="system-prompt-form"
onSubmit={systemForm.handleSubmit(handleSystemSubmit)}
>
- {viewMode === 'code' ? (
+ {viewMode === 'rich' ? (
<FormCodeItem
control={systemForm.control}
disabled={isLoading}
@@ -1039,7 +1046,7 @@ function SettingsPrompt() {
id="human-prompt-form"
onSubmit={humanForm.handleSubmit(handleHumanSubmit)}
>
- {viewMode === 'code' ? (
+ {viewMode === 'rich' ? (
<FormCodeItem
control={humanForm.control}
disabled={isLoading}
diff --git a/frontend/src/pages/templates/template.tsx b/frontend/src/pages/templates/template.tsx
index c5a6e759..ce2de4f2 100644
--- a/frontend/src/pages/templates/template.tsx
+++ b/frontend/src/pages/templates/template.tsx
@@ -2,7 +2,7 @@ import type { ReactNode } from 'react';
import { skipToken, useQuery } from '@apollo/client/react';
import { zodResolver } from '@hookform/resolvers/zod';
-import { ChevronDown, Code, Ellipsis, FileSymlink, FileText, Loader2, Pencil, Save, Trash, Type } from 'lucide-react';
+import { ChevronDown, Ellipsis, FileSymlink, FileText, Loader2, Pencil, Save, Trash } from 'lucide-react';
import { lazy, Suspense, useCallback, useMemo, useState } from 'react';
import { useForm } from 'react-hook-form';
import { useNavigate, useParams } from 'react-router-dom';
@@ -17,6 +17,7 @@ import {
DetailNavigationToolbar,
} from '@/components/shared/detail-navigation';
import { DetailTwoPanelLayout } from '@/components/shared/detail-two-panel-layout';
+import { type EditorViewMode, EditorViewModeToggle } from '@/components/shared/editor-view-mode';
import { InlineEditInput, useInlineEdit } from '@/components/shared/inline-edit';
import { UnsavedChangesDialog, useUnsavedChangesGuard } from '@/components/shared/unsaved-changes';
import { Badge } from '@/components/ui/badge';
@@ -256,7 +257,7 @@ function Template() {
const [isRenaming, setIsRenaming] = useState(false);
const [isDeleting, setIsDeleting] = useState(false);
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false);
- const [viewMode, setViewMode] = useState<'code' | 'plain'>('code');
+ const [viewMode, setViewMode] = useState<EditorViewMode>('rich');
const {
handleDropdownCloseAutoFocus,
@@ -495,10 +496,16 @@ function Template() {
onCloseAutoFocus={handleDropdownCloseAutoFocus}
>
<DropdownMenuItem
- onClick={() => setViewMode((mode) => (mode === 'code' ? 'plain' : 'code'))}
+ className="gap-4"
+ onSelect={(event) => event.preventDefault()}
>
- {viewMode === 'code' ? <Type className="size-4" /> : <Code className="size-4" />}
- {viewMode === 'code' ? 'Plain text' : 'Code editor'}
+ View
+ <EditorViewModeToggle
+ className="-my-1.5 -mr-2 ml-auto"
+ mode={viewMode}
+ onModeChange={setViewMode}
+ rawTooltip="Edit the raw template"
+ />
</DropdownMenuItem>
{canShowActions && (
<>
@@ -667,7 +674,7 @@ function Template() {
render={({ field }) => (
<FormItem className="flex min-h-0 flex-1 flex-col">
<FormControl>
- {viewMode === 'code' ? (
+ {viewMode === 'rich' ? (
<Suspense
fallback={
<div className="flex min-h-0 flex-1 items-center justify-center rounded-md border">