Fully autonomous AI Agents system capable of performing complex penetration testing tasks
Go ai-agentsai-security-toolanthropicautonomous-agentsgolanggptgraphqlmulti-agent-systemoffensive-securityopen-sourceopenaipenetration-testingpenetration-testing-toolsreactsecurity-automationsecurity-testingsecurity-toolsself-hosted
test(frontend): make the e2e suite falsifiable, and fix what it found (#380)
Dmitry Ng45c84c500f7e
diff --git a/.dockerignore b/.dockerignoreindex 5c3616dc..48c900a5 100644--- a/.dockerignore+++ b/.dockerignore@@ -1,9 +1,16 @@frontend/coveragefrontend/distfrontend/node_modules+frontend/e2e/test-results+frontend/e2e/playwright-report+frontend/e2e/blob-report+frontend/e2e/.auth+**/*.tsbuildinfofrontend/ssl**/*.log**/*.env+**/.env.*+!**/.env.example**/.DS_Store**/Thumbs.dbdiff --git a/.github/scripts/codegen-inputs-changed.sh b/.github/scripts/codegen-inputs-changed.shnew file mode 100755index 00000000..0efa1041--- /dev/null+++ b/.github/scripts/codegen-inputs-changed.sh@@ -0,0 +1,57 @@+#!/usr/bin/env bash+# Decide whether a run has to re-check that frontend/src/graphql/types.ts is fresh.+# Echoes `changed=true|false`. Split out of ci.yml so the range selection is testable+# (frontend/e2e/ci-codegen-gate.unit.test.ts drives it over real git fixtures).+#+# Usage: codegen-inputs-changed.sh <event_name> <before_sha> <base_sha> <head_sha>+set -uo pipefail++EVENT="${1:-}"+BEFORE="${2:-}"+BASE_SHA="${3:-}"+HEAD_SHA="${4:-}"++# On pull_request, `before` is the PR's PREVIOUS HEAD, so a follow-up push diffs a range+# that no longer contains the commit that edited the schema — the gate would skip itself+# on every push after the first. The PR's base is the range that always spans the change.+if [ "$EVENT" = "pull_request" ]; then+ base="$BASE_SHA"+else+ base="$BEFORE"+fi++# When the range can't be resolved (new branch, force-push, tag), check anyway.+# stdout is consumed verbatim as a workflow output, so diagnostics go to stderr.+if [ -z "$base" ] || [ "$base" = "0000000000000000000000000000000000000000" ] \+ || ! git cat-file -e "$base^{commit}" 2>/dev/null; then+ echo "reason=unresolvable-base" >&2+ echo "changed=true"+ exit 0+fi++# The generated file is in the list too: a push that edits only it would otherwise skip+# the check, and the drift surfaces later on someone else's unrelated codegen push.+INPUTS=(+ backend/pkg/graph/schema.graphqls+ frontend/graphql-schema.graphql+ frontend/graphql-codegen.ts+ frontend/pnpm-lock.yaml+ frontend/src/graphql/types.ts+)++if ! files=$(git diff --name-only "$base" "$HEAD_SHA"); then+ echo "reason=diff-failed" >&2+ echo "changed=true"+ exit 0+fi++for input in "${INPUTS[@]}"; do+ case $'\n'"$files"$'\n' in+ *$'\n'"$input"$'\n'*)+ echo "changed=true"+ exit 0+ ;;+ esac+done++echo "changed=false"diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.ymlindex 346cdcfb..558d4c44 100644--- a/.github/workflows/ci.yml+++ b/.github/workflows/ci.yml@@ -1,13 +1,23 @@name: Docker build and pushon:+ # pull_request so the lint/codegen/test gate runs on fork PRs too: a fork's commits never push to+ # this repo, so a push-only trigger let a fork edit the schema without regenerating types.ts (or+ # ship a lint/test failure) and merge green, since e2e.yml's tsc build cannot see stale codegen.+ # lint-and-test uses no secrets and is fork-safe; docker-build stays gated to main/tags below.+ pull_request:+ types: [opened, synchronize, reopened]push:branches:- - "**"+ - maintags:- "v[0-9]+.[0-9]+.[0-9]+"workflow_dispatch:+concurrency:+ group: ci-${{ github.event.pull_request.number || github.ref }}+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}+permissions:contents: read@@ -32,7 +42,7 @@ jobs:- name: Set up Gouses: actions/setup-go@v6with:- go-version: '1.24'+ go-version: "1.24"cache: truecache-dependency-path: backend/go.sum@@ -47,8 +57,8 @@ jobs:uses: actions/setup-node@v6with:node-version-file: frontend/.nvmrc- cache: 'pnpm'- cache-dependency-path: 'frontend/pnpm-lock.yaml'+ cache: "pnpm"+ cache-dependency-path: "frontend/pnpm-lock.yaml"# Frontend lint and test- name: Frontend - Install dependencies@@ -70,21 +80,14 @@ jobs:# Only when a codegen input moved. The lockfile is included on purpose: a codegen# version bump can change the output, and skipping it there would let types.ts go# stale and fail the next schema push for something its author did not do.- # When the range can't be resolved (new branch, force-push, tag), check anyway.- name: Frontend - Detect GraphQL codegen input changesid: codegen-inputsrun: |- base='${{ github.event.before }}'- if [ -z "$base" ] || [ "$base" = "0000000000000000000000000000000000000000" ] \- || ! git cat-file -e "$base^{commit}" 2>/dev/null; then- echo "changed=true" >> "$GITHUB_OUTPUT"- exit 0- fi- if git diff --name-only "$base" "${{ github.sha }}" | grep -qE '^(backend/pkg/graph/schema\.graphqls|frontend/graphql-schema\.graphql|frontend/graphql-codegen\.ts|frontend/pnpm-lock\.yaml)$'; then- echo "changed=true" >> "$GITHUB_OUTPUT"- else- echo "changed=false" >> "$GITHUB_OUTPUT"- fi+ .github/scripts/codegen-inputs-changed.sh \+ '${{ github.event_name }}' \+ '${{ github.event.before }}' \+ '${{ github.event.pull_request.base.sha }}' \+ '${{ github.sha }}' >> "$GITHUB_OUTPUT"# The app ships the operations compiled into src/graphql/types.ts; regenerate and# diff so it can't drift from graphql-schema.graphql (the codegen input the stand's@@ -133,17 +136,17 @@ jobs:PACKAGE_VER=${LATEST_TAG#v}CURRENT_COMMIT=$(git rev-parse HEAD)TAG_COMMIT=$(git rev-list -n 1 "$LATEST_TAG" 2>/dev/null || echo "")-+if [ "$CURRENT_COMMIT" != "$TAG_COMMIT" ]; thenPACKAGE_REV=$(git rev-parse --short HEAD)elsePACKAGE_REV=""fi-+LDFLAGS="-X pentagi/pkg/version.PackageName=pentagi -X pentagi/pkg/version.PackageVer=${PACKAGE_VER} -X pentagi/pkg/version.PackageRev=${PACKAGE_REV}"-+echo "Building with version: ${PACKAGE_VER}${PACKAGE_REV:+-$PACKAGE_REV}"-+# Build for AMD64GOOS=linux GOARCH=amd64 go build -trimpath -ldflags "$LDFLAGS" -o /tmp/pentagi-amd64 ./cmd/pentagiecho "✓ Successfully built for linux/amd64"@@ -179,13 +182,13 @@ jobs:# Get latest tag version (without 'v' prefix)LATEST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "v0.0.0")VERSION=${LATEST_TAG#v}-+# Get current commit hashCURRENT_COMMIT=$(git rev-parse HEAD)-+# Get commit hash of the latest tagTAG_COMMIT=$(git rev-list -n 1 "$LATEST_TAG" 2>/dev/null || echo "")-+# Set revision only if current commit differs from tag commitif [ "$CURRENT_COMMIT" != "$TAG_COMMIT" ]; thenPACKAGE_REV=$(git rev-parse --short HEAD)@@ -205,7 +208,7 @@ jobs:echo "patch=${VERSION}" >> $GITHUB_OUTPUTecho " Docker tags: latest, ${major}, ${major}.${minor}, ${VERSION}"fi-+echo "version=${VERSION}" >> $GITHUB_OUTPUT- name: Generate Docker metadatadiff --git a/.github/workflows/e2e-report.yml b/.github/workflows/e2e-report.ymlindex 24aa7e79..d28ea491 100644--- a/.github/workflows/e2e-report.yml+++ b/.github/workflows/e2e-report.yml@@ -28,6 +28,7 @@ jobs:timeout-minutes: 5steps:- name: Download results+ id: resultscontinue-on-error: trueuses: actions/download-artifact@v4with:@@ -55,15 +56,25 @@ jobs:const fs = require('fs');const run = context.payload.workflow_run;- // workflow_run.pull_requests is empty for fork PRs — resolve by head SHA.- let prNumber = run.pull_requests[0]?.number;+ // Match the PR whose head is still this run's — one commit can belong to several PRs, so+ // taking the first association (either source) could hand the report to a stale or+ // foreign one. Same filter on both paths: workflow_run.pull_requests (empty for forks)+ // and the head-SHA lookup that covers them.+ // workflow_run.pull_requests carries head.repo.name but no full_name, unlike the API+ // lookup — enforce the repo only when it is present, so the primary path still matches.+ const isThisRun = (pr) =>+ pr.head?.sha === run.head_sha &&+ pr.head?.ref === run.head_branch &&+ (pr.head?.repo?.full_name == null || pr.head.repo.full_name === run.head_repository?.full_name);++ let prNumber = run.pull_requests.find(isThisRun)?.number;if (!prNumber) {const { data: prs } = await github.rest.repos.listPullRequestsAssociatedWithCommit({owner: context.repo.owner,repo: context.repo.repo,commit_sha: run.head_sha,});- prNumber = prs[0]?.number;+ prNumber = prs.find(isThisRun)?.number;}if (!prNumber) {core.info(`No PR found for ${run.head_sha}; skipping comment.`);@@ -94,7 +105,15 @@ jobs:return;}- let statsLine = 'The run produced no results file (it likely failed before the tests started).';+ // e2e.yml uploads results.json with `if-no-files-found: ignore`, so a run that never+ // wrote one publishes no artifact at all: a failed download means the file is absent,+ // a successful download with unreadable stats means it is corrupt.+ const resultsDownloaded = '${{ steps.results.outcome }}' === 'success';++ let statsLine = resultsDownloaded+ ? 'The results file could not be parsed, so no test counts are available.'+ : 'No results artifact was produced for this run.';+ let statsRead = false;let noFailures = false;try {const report = JSON.parse(fs.readFileSync('results/results.json', 'utf8'));@@ -102,24 +121,39 @@ jobs:const { expected, unexpected, flaky, skipped } = report.stats ?? {};statsLine = `**${n(expected)} passed**, ${n(unexpected)} failed, ${n(flaky)} flaky, ${n(skipped)} skipped.`;noFailures = n(unexpected) === 0;+ statsRead = true;} catch (error) {core.info(`results.json unavailable: ${error}`);}- // Both halves are required: results.json is written before an abort can be- // observed, so a run killed by the global timeout still reports zero failures.- // When the jobs API was unreachable, fall back to results.json alone.- const mockPassed = noFailures && (jobsFetched ? mockJob?.conclusion === 'success' : true);+ // The job conclusion is load-bearing, not a nicety: results.json is written before a+ // global-timeout abort can be observed (its un-run tests land in `skipped`, so+ // `unexpected` stays 0), and only the job's own conclusion reflects the abort. So a+ // green needs BOTH zero failures AND a successful job; whenever either source is+ // unreadable the verdict is unknown — never a green, and never a red.+ const jobFailed = jobsFetched && mockJob?.conclusion !== 'success';+ const mockStatus = jobFailed || (statsRead && !noFailures)+ ? 'fail'+ : statsRead && jobsFetched+ ? 'pass'+ : 'unknown';// Key the advisory on the e2e-visual-diffs artifact (uploaded only when the snapshot// step itself failed), not on the visual job's conclusion — a tag-guard, install or// build failure would otherwise read as "snapshots differ".const visualDiffers = '${{ steps.visualdiffs.outcome }}' === 'success';- const conclusion = !mockPassed ? '❌' : visualDiffers ? '⚠️' : '✅';+ const conclusion = mockStatus === 'fail' ? '❌' : mockStatus === 'unknown' || visualDiffers ? '⚠️' : '✅';const marker = '<!-- e2e-report -->';- const advisoryLine = visualDiffers- ? '⚠️ **Visual snapshots differ** — advisory only, does not block merge. Download the `e2e-visual-diffs` artifact to compare expected / actual / diff.'+ const unconfirmedReason = !jobsFetched && !statsRead+ ? 'neither the workflow jobs API nor `results.json` could be read'+ : !jobsFetched+ ? 'the workflow jobs API was unreachable, so this reflects `results.json` alone, which cannot distinguish a clean pass from a run killed mid-flight'+ : '`results.json` could not be read, so this reflects the job conclusion alone and no test counts were checked';+ const advisoryLine = mockStatus === 'unknown'+ ? `⚠️ **Result unconfirmed** — ${unconfirmedReason}. Check the run before merging.`+ : visualDiffers+ ? '⚠️ **Visual snapshots differ** — advisory only, does not block merge. Download the `e2e-visual-diffs` artifact to compare expected / actual / diff (a missing baseline uploads actual only).': null;const body = [marker,diff --git a/.github/workflows/e2e-stand.yml b/.github/workflows/e2e-stand.ymlindex b7058167..ccc3dfb5 100644--- a/.github/workflows/e2e-stand.yml+++ b/.github/workflows/e2e-stand.yml@@ -10,27 +10,26 @@ on:pull_request:types: [labeled]workflow_dispatch:- inputs:- tier:- description: "Run the stand tier"- type: choice- options:- - stand- - all- default: standpermissions:contents: read+# Keyed on the label too: concurrency is evaluated for the whole run before the job's `if`, so a run+# started by an unrelated label would share this group and cancel an approved stand run mid-flight.concurrency:- group: e2e-stand-${{ github.event.pull_request.number || github.run_id }}+ group: e2e-stand-${{ github.event.pull_request.number || github.run_id }}-${{ github.event.label.name }}cancel-in-progress: ${{ github.event_name == 'pull_request' }}jobs:e2e-stand:+ # GitHub withholds secrets from fork `pull_request` runs: without the fork check a labelled fork+ # PR holds reviewers for an environment approval and then fails on empty credentials. Assert repo+ # identity rather than negating `head.repo.fork`: a deleted fork sends `head.repo: null`, and+ # GitHub coerces null and false alike to 0, so the negation lets that PR through.if: >github.event_name == 'workflow_dispatch' ||- contains(github.event.pull_request.labels.*.name, 'e2e:stand')+ (github.event.label.name == 'e2e:stand' &&+ github.event.pull_request.head.repo.full_name == github.repository)runs-on: ubuntu-latesttimeout-minutes: 30environment: e2e-stand@@ -78,11 +77,41 @@ jobs:E2E_USER: ${{ secrets.E2E_STAND_USER }}E2E_PASSWORD: ${{ secrets.E2E_STAND_PASSWORD }}- # Traces, videos and screenshots are all disabled on this tier — they would- # embed the live session cookie, the stand URL or the login into a- # public-repo artifact. results.json carries none of those.- - name: Upload report+ # Traces, videos and screenshots are disabled on this tier. results.json still+ # embeds the stand URL (baseURL in navigation/locator error messages) and the+ # user (in locator text) on a failing run, so redact the secrets before the+ # public-repo upload — GitHub masks secrets in logs, never in artifacts.+ - name: Redact secrets from report+ id: redactif: always()+ working-directory: frontend+ run: |+ node -e '+ const fs = require("fs");+ const f = "e2e/test-results/results.json";+ if (!fs.existsSync(f)) process.exit(0);+ let s = fs.readFileSync(f, "utf8");+ // Derived forms too, not just the raw value: auth.setup.ts builds a locator name from+ // the regex-escaped user, so a failed login writes `user@host\.com` into the error —+ // and since this redacts the JSON text, that backslash is itself encoded as `\\`.+ const regexEscaped = (v) => v.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");+ const jsonEncoded = (v) => JSON.stringify(v).slice(1, -1);+ for (const v of [process.env.E2E_BASE_URL, process.env.E2E_USER, process.env.E2E_PASSWORD]) {+ if (!v) continue;+ const forms = [v, regexEscaped(v), encodeURIComponent(v)];+ for (const form of new Set([...forms, ...forms.map(jsonEncoded)])) {+ s = s.split(form).join("<redacted>");+ }+ }+ fs.writeFileSync(f, s);+ '+ env:+ E2E_BASE_URL: ${{ secrets.E2E_STAND_URL }}+ E2E_USER: ${{ secrets.E2E_STAND_USER }}+ E2E_PASSWORD: ${{ secrets.E2E_STAND_PASSWORD }}++ - name: Upload report+ if: always() && steps.redact.outcome == 'success'uses: actions/upload-artifact@v4with:name: e2e-stand-reportdiff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.ymlindex e2d0f898..98d54fe9 100644--- a/.github/workflows/e2e.yml+++ b/.github/workflows/e2e.yml@@ -117,11 +117,14 @@ jobs:# Compare the container's own Playwright build to @playwright/test rather than a# hardcoded literal, so bumping the package without re-tagging the image (or vice- # versa) fails here instead of drifting the pixel baselines.+ # versa) fails here instead of drifting the pixel baselines. Read the version from+ # the image's own /ms-playwright/.docker-info: this image ships no global+ # playwright, so `npx playwright --version` (before pnpm install) would fetch the+ # registry latest and compare the package against that, not against the container.- name: Verify container image matches @playwright/testrun: |pkg="$(node -p "require('./frontend/package.json').devDependencies['@playwright/test'].replace(/[^0-9.]/g, '')")"- container="$(npx playwright --version | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)"+ container="$(node -p "JSON.parse(require('fs').readFileSync('/ms-playwright/.docker-info','utf8')).driverVersion")"if [ "$pkg" != "$container" ]; thenecho "::error::e2e-visual container ships Playwright $container but @playwright/test is $pkg — bump the container tag to v$pkg-noble and regenerate baselines"exit 1@@ -153,10 +156,25 @@ jobs:working-directory: frontendrun: E2E_VISUAL=1 E2E_VISUAL_CONTAINER=1 npx playwright test -c e2e/playwright.config.ts- # Only on a real snapshot diff (not a tag-guard/install/build failure), so its- # presence is the precise "snapshots differ" signal the report keys the advisory on.- - name: Upload diffs+ # The step failing is not the same signal as a snapshot differing: a webServer or build+ # failure inside it also exits non-zero and still leaves results.json behind, which would+ # publish the artifact and make the report say "snapshots differ". Look for the diff images.+ - name: Detect snapshot diffs+ id: diffsif: failure() && steps.snapshots.outcome == 'failure'+ working-directory: frontend+ run: |+ # -actual.png too: a missing baseline fails the test but writes no diff image, and only the+ # snapshot matcher writes either name — a non-snapshot failure leaves test-failed-N.png.+ if find e2e/test-results \( -name '*-diff.png' -o -name '*-actual.png' \) -print -quit | grep -q .; then+ echo "found=true" >> "$GITHUB_OUTPUT"+ else+ echo "found=false" >> "$GITHUB_OUTPUT"+ fi++ # Its presence is the precise "snapshots differ" signal the report keys the advisory on.+ - name: Upload diffs+ if: always() && steps.diffs.outputs.found == 'true'uses: actions/upload-artifact@v4with:name: e2e-visual-diffs@@ -169,8 +187,7 @@ jobs:e2e-local:if: >github.event_name == 'schedule' ||- (github.event_name == 'workflow_dispatch' &&- contains(fromJSON('["local", "all"]'), inputs.tier))+ (github.event_name == 'workflow_dispatch' && inputs.tier == 'local')runs-on: ubuntu-latesttimeout-minutes: 40steps:diff --git a/CLAUDE.md b/CLAUDE.mdindex b92e1953..3a6da8ad 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -6,7 +6,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co1. **Always use English** for all interactions, responses, explanations, and questions with users.2. **Password Complexity Requirements**: For all password-related development (registration, password reset, API token generation, etc.), enforce the same policy in **both** backend and frontend — never rely on frontend validation alone. Source of truth, keep the two in sync: `backend/pkg/server/models/init.go` → `strongPasswordValidatorString` and `frontend/src/features/authentication/password-change-form.tsx` (zod schema). The policy:- - Length 8–100 characters.+ - Length 8–72 characters (72 **bytes**, the most bcrypt will hash — a longer value fails inside `bcrypt.GenerateFromPassword`, after validation).- A password is valid if it is **either** 16+ characters (any composition), **or** 8–15 characters containing at least 1 lowercase letter, 1 uppercase letter, 1 number, and 1 special character from `!@#$&*`.## Project Overviewdiff --git a/README.md b/README.mdindex 44e6cf11..f9b315d9 100644--- a/README.md+++ b/README.md@@ -1943,7 +1943,7 @@ PROXY_URL=http://your-proxy:8080#### Custom Provider Config and Models (advanced)-By default the Bedrock provider uses a per-agent config and model catalog compiled into the binary. Two optional paths override them without rebuilding:+By default the Bedrock provider uses a per-agent config and model catalog compiled into the binary. One optional path overrides them without rebuilding:- `BEDROCK_CONFIG_PATH` — a YAML file (same shape as the other provider configs) that **replaces** the built-in per-agent model/price assignments. See [`examples/configs/bedrock-glm-flash.provider.yml`](examples/configs/bedrock-glm-flash.provider.yml).@@ -1952,9 +1952,9 @@ This is useful to expose a Bedrock model newer than the compiled-in catalog —With Docker Compose, set the host-side mount source and the in-container path together:```bash-# host files mounted into the container+# host file mounted into the container at /opt/pentagi/conf/bedrock.provider.ymlPENTAGI_BEDROCK_CONFIG_PATH=./examples/configs/bedrock-glm-flash.provider.yml-# tell the backend to read the mounted files+# tell the backend to read the mounted fileBEDROCK_CONFIG_PATH=/opt/pentagi/conf/bedrock.provider.yml```diff --git a/backend/pkg/config/config.go b/backend/pkg/config/config.goindex 1c50af77..bd2c0ec2 100644--- a/backend/pkg/config/config.go+++ b/backend/pkg/config/config.go@@ -257,7 +257,6 @@ type Config struct {}func NewConfig() (*Config, error) {- // Attempt to load .env file (silently ignore if not present)_ = godotenv.Load()var config Config@@ -282,12 +281,10 @@ func NewConfig() (*Config, error) {}func ensureInstallationID(config *Config) {- // validate current installation ID from environmentif config.InstallationID != "" && uuid.Validate(config.InstallationID) == nil {return}- // check local file for installation IDinstallationIDPath := filepath.Join(config.DataDir, "installation_id")installationID, err := os.ReadFile(installationIDPath)if err != nil {@@ -298,17 +295,14 @@ func ensureInstallationID(config *Config) {config.InstallationID = uuid.New().String()}- // write installation ID to local file_ = os.WriteFile(installationIDPath, []byte(config.InstallationID), 0644)}func ensureLicenseKey(config *Config) {- // validate current license key from environmentif config.LicenseKey == "" {return}- // check license key validity, if invalid, set to emptyinfo, err := sdk.IntrospectLicenseKey(config.LicenseKey)if err != nil {config.LicenseKey = ""@@ -364,7 +358,6 @@ func (c *Config) GetSecretPatterns() []patterns.Pattern {continue}- // escape regex special charactersescaped := regexp.QuoteMeta(trimmed)pattern := patterns.Pattern{Name: s.name,diff --git a/backend/pkg/controller/aslog.go b/backend/pkg/controller/aslog.goindex ab1a48ef..ff19e8cd 100644--- a/backend/pkg/controller/aslog.go+++ b/backend/pkg/controller/aslog.go@@ -287,7 +287,7 @@ func (aslw *flowAssistantLogWorker) workerMsgUpdater(contentBuf := bytes.NewBuffer(contentData)thinkingData := make([]byte, 0, defaultMaxMessageLength)thinkingBuf := bytes.NewBuffer(thinkingData)- wasUpdated := false // track if we actually updated the record+ wasUpdated := falsemsgLog, err := aslw.db.GetFlowAssistantLog(ctx, msgID)if err != nil {diff --git a/backend/pkg/controller/assistant.go b/backend/pkg/controller/assistant.goindex d32b0aee..d2d3cdab 100644--- a/backend/pkg/controller/assistant.go+++ b/backend/pkg/controller/assistant.go@@ -559,7 +559,7 @@ func (aw *assistantWorker) PutInput(ctx context.Context, input string, useAgentsselect {case err := <-ain.done:- return err // nil or error+ return errcase <-timer.C:return nil // no early errorcase <-aw.ctx.Done():diff --git a/backend/pkg/controller/flow.go b/backend/pkg/controller/flow.goindex 8cf3a5b5..7b0d684f 100644--- a/backend/pkg/controller/flow.go+++ b/backend/pkg/controller/flow.go@@ -124,7 +124,7 @@ type flowInput struct {func NewFlowWorker(ctx context.Context,fwc newFlowWorkerCtx,-) (FlowWorker, error) {+) (_ FlowWorker, err error) {ctx, span := obs.Observer.NewSpan(ctx, obs.SpanKindInternal, "controller.NewFlowWorker")defer span.End()@@ -152,6 +152,25 @@ func NewFlowWorker(})logger.Info("flow created in DB")+ // Held separately because `flow` is reassigned below by UpdateFlow, which — like every sqlc query —+ // returns a zero-valued row alongside an error, and a cleanup aimed at id 0 deletes nothing.+ flowID := flow.ID++ // DeleteFlow is a soft delete and the listings filter on deleted_at, so this is what keeps a flow+ // the caller was told it never got out of the UI. Disarmed once the worker goroutine owns the flow —+ // from there a failure is the worker's to unwind, not ours.+ cleanupFlow := true+ defer func() {+ if err == nil || !cleanupFlow {+ return+ }++ // The caller's context is usually already cancelled by whatever failed.+ if _, cerr := fwc.db.DeleteFlow(context.WithoutCancel(ctx), flowID); cerr != nil {+ logger.WithError(cerr).Error("failed to drop the flow left behind by a failed start")+ }+ }()+user, err := fwc.db.GetUser(ctx, fwc.userID)if err != nil {logger.WithError(err).Error("failed to get user")@@ -282,6 +301,8 @@ func NewFlowWorker(fw.flowCtx.Publisher.FlowCreated(ctx, flow, containers)+ cleanupFlow = false+fw.wg.Add(1)go fw.worker()@@ -630,7 +651,7 @@ func (fw *flowWorker) PutInput(select {case err := <-flin.done:- return err // nil or error+ return errcase <-timer.C:return nil // no early errorcase <-fw.ctx.Done():diff --git a/backend/pkg/csum/chain_summary.go b/backend/pkg/csum/chain_summary.goindex bf9e1c78..32b078f2 100644--- a/backend/pkg/csum/chain_summary.go+++ b/backend/pkg/csum/chain_summary.go@@ -110,7 +110,6 @@ func (s *summarizer) SummarizeChain(chain []llms.MessageContent,tcIDTemplate string,) ([]llms.MessageContent, error) {- // Skip summarization for empty chainsif len(chain) == 0 {return chain, nil}@@ -191,7 +190,6 @@ func summarizeSections(continue}- // Add human message if it existsvar humanMessages []llms.MessageContentif section.Header.HumanMessage != nil {humanMessages = append(humanMessages, *section.Header.HumanMessage)@@ -201,7 +199,6 @@ func summarizeSections(go func(section *cast.ChainSection, i int) {defer wg.Done()- // Generate summarysummaryText, err := GenerateSummary(ctx, handler, humanMessages, messagesToSummarize)if err != nil {ch <- fmt.Errorf("section %d summary generation failed: %w", i, err)@@ -286,13 +283,11 @@ func summarizeLastSection(messagesToSummarize = append(messagesToSummarize, pair.Messages()...)}- // Add human message if it existsvar humanMessages []llms.MessageContentif lastSection.Header.HumanMessage != nil {humanMessages = append(humanMessages, *lastSection.Header.HumanMessage)}- // Generate summarysummaryText, err := GenerateSummary(ctx, handler, humanMessages, messagesToSummarize)if err != nil {// If summary generation fails, just keep the most recent messages@@ -405,7 +400,6 @@ func summarizeOversizedBodyPairs(continue}- // Add human message if it existsvar humanMessages []llms.MessageContentif section.Header.HumanMessage != nil {humanMessages = append(humanMessages, *section.Header.HumanMessage)@@ -415,7 +409,6 @@ func summarizeOversizedBodyPairs(go func(pair *cast.BodyPair, i int) {defer wg.Done()- // Generate summarysummaryText, err := GenerateSummary(ctx, handler, humanMessages, pairMessages)if err != nil {return // It's should collected next step in summarizeLastSection function@@ -549,7 +542,6 @@ func summarizeQAPairs(}}- // Generate summaryvar (err erroraiSummary string@@ -697,7 +689,6 @@ func convertSectionsHeadersToMessages(sections []*cast.ChainSection) []llms.Messvar messages []llms.MessageContentfor _, section := range sections {- // Add human message if it existsif section.Header.HumanMessage != nil {messages = append(messages, *section.Header.HumanMessage)}@@ -715,7 +706,6 @@ func convertSectionsPairsToMessages(sections []*cast.ChainSection) []llms.Messagvar messages []llms.MessageContentfor _, section := range sections {- // Get all messages from each body pair using the Messages() methodfor _, pair := range section.Body {pairMessages := pair.Messages()messages = append(messages, pairMessages...)diff --git a/backend/pkg/database/converter/analytics.go b/backend/pkg/database/converter/analytics.goindex 809e4d40..546c449a 100644--- a/backend/pkg/database/converter/analytics.go+++ b/backend/pkg/database/converter/analytics.go@@ -22,7 +22,6 @@ func CalculateSubtaskDuration(subtask database.Subtask, msgchains []database.Msgreturn 0}- // Calculate linear durationvar linearDuration float64if subtask.Status == database.SubtaskStatusRunning {// For running subtasks: from created_at to nowdiff --git a/backend/pkg/database/converter/converter.go b/backend/pkg/database/converter/converter.goindex e24a5167..63ab9149 100644--- a/backend/pkg/database/converter/converter.go+++ b/backend/pkg/database/converter/converter.go@@ -695,6 +695,18 @@ func ConvertAgentConfigToGqlModel(ac *pconfig.AgentConfig) *model.AgentConfig {if ac.PresencePenalty != 0 {result.PresencePenalty = &ac.PresencePenalty}+ if ac.MinP != 0 {+ result.MinP = &ac.MinP+ }+ if ac.N != 0 {+ result.N = &ac.N+ }+ if ac.JSON {+ result.JSON = &ac.JSON+ }+ if ac.ResponseMIMEType != "" {+ result.ResponseMimeType = &ac.ResponseMIMEType+ }if !ac.Reasoning.IsZero() {reasoning := &model.ReasoningConfig{}@@ -796,6 +808,21 @@ func ConvertAgentConfigFromGqlModel(ac *model.AgentConfig) *pconfig.AgentConfigif ac.PresencePenalty != nil {rawConfig["presence_penalty"] = *ac.PresencePenalty}+ // BuildOptions gates these on the key being present, not on its value, so a zero has to be+ // written as an absent key — otherwise `json: false` would switch JSON mode on and `n: 0`+ // would emit an invalid request parameter.+ if ac.MinP != nil && *ac.MinP != 0 {+ rawConfig["min_p"] = *ac.MinP+ }+ if ac.N != nil && *ac.N != 0 {+ rawConfig["n"] = *ac.N+ }+ if ac.JSON != nil && *ac.JSON {+ rawConfig["json"] = *ac.JSON+ }+ if ac.ResponseMimeType != nil && *ac.ResponseMimeType != "" {+ rawConfig["response_mime_type"] = *ac.ResponseMimeType+ }if ac.Reasoning != nil {reasoning := map[string]any{}@@ -932,7 +959,6 @@ func ConvertUsageStats[T UsageStatsRow](stats T) *model.UsageStats {var in, out, cacheIn, cacheOut int64var costIn, costOut float64- // Extract fields based on typeswitch v := any(stats).(type) {case database.GetFlowUsageStatsRow:in, out = v.TotalUsageIn, v.TotalUsageOut@@ -1107,7 +1133,6 @@ func ConvertToolcallsStats[T ToolcallsStatsRow](stats T) *model.ToolcallsStats {var count int64var duration float64- // Extract fields based on typeswitch v := any(stats).(type) {case database.GetFlowToolcallsStatsRow:count, duration = v.TotalCount, v.TotalDurationSeconds@@ -1177,7 +1202,6 @@ func isAgentTool(functionName string) bool {if !exists {return false}- // Agent tools include AgentToolType and StoreAgentResultToolTypereturn toolType == tools.AgentToolType || toolType == tools.StoreAgentResultToolType}@@ -1217,7 +1241,6 @@ func ConvertFunctionToolcallsStatsForFlow(stats []database.GetToolcallsStatsByFufunc ConvertFlowsStats[T FlowsStatsRow](stats T) *model.FlowsStats {var flowsCount, tasksCount, subtasksCount, assistantsCount int64- // Extract fields based on typeswitch v := any(stats).(type) {case database.GetUserTotalFlowsStatsRow:flowsCount, tasksCount, subtasksCount, assistantsCount = v.TotalFlowsCount, v.TotalTasksCount, v.TotalSubtasksCount, v.TotalAssistantsCount@@ -1235,7 +1258,6 @@ func ConvertFlowsStats[T FlowsStatsRow](stats T) *model.FlowsStats {func ConvertFlowStats[T FlowStatsRow](stats T) *model.FlowStats {var tasksCount, subtasksCount, assistantsCount int64- // Extract fields based on typeswitch v := any(stats).(type) {case database.GetFlowStatsRow:tasksCount, subtasksCount, assistantsCount = v.TotalTasksCount, v.TotalSubtasksCount, v.TotalAssistantsCountdiff --git a/backend/pkg/database/converter/converter_test.go b/backend/pkg/database/converter/converter_test.goindex 5c7805d6..62ff707a 100644--- a/backend/pkg/database/converter/converter_test.go+++ b/backend/pkg/database/converter/converter_test.go@@ -4,6 +4,7 @@ import ("testing""pentagi/pkg/graph/model"+ "pentagi/pkg/providers/openai""pentagi/pkg/providers/pconfig""github.com/stretchr/testify/assert"@@ -207,3 +208,77 @@ func TestConvertAgentConfigExtraBodyNilStaysNil(t *testing.T) {assert.Nil(t, ConvertAgentConfigToGqlModel(from).ExtraBody)}++func ptr[T any](value T) *T { return &value }++func TestConvertAgentConfigCallOptionFieldsRoundTrip(t *testing.T) {+ from := ConvertAgentConfigFromGqlModel(&model.AgentConfig{+ Model: "m",+ MinP: ptr(0.05),+ N: ptr(3),+ JSON: ptr(true),+ ResponseMimeType: ptr("application/json"),+ })+ require.NotNil(t, from)+ assert.Equal(t, 0.05, from.MinP)+ assert.Equal(t, 3, from.N)+ assert.True(t, from.JSON)+ assert.Equal(t, "application/json", from.ResponseMIMEType)++ back := ConvertAgentConfigToGqlModel(from)+ require.NotNil(t, back)+ require.NotNil(t, back.MinP)+ require.NotNil(t, back.N)+ require.NotNil(t, back.JSON)+ require.NotNil(t, back.ResponseMimeType)+ assert.Equal(t, 0.05, *back.MinP)+ assert.Equal(t, 3, *back.N)+ assert.True(t, *back.JSON)+ assert.Equal(t, "application/json", *back.ResponseMimeType)+}++// pconfig gates each emitter on the raw key being PRESENT, not on its value, so a zero written+// through would switch the option on: `json: false` must not reach the LLM as WithJSONMode().+func TestConvertAgentConfigZeroCallOptionFieldsStayAbsent(t *testing.T) {+ from := ConvertAgentConfigFromGqlModel(&model.AgentConfig{+ Model: "m",+ MinP: ptr(0.0),+ N: ptr(0),+ JSON: ptr(false),+ ResponseMimeType: ptr(""),+ })+ require.NotNil(t, from)++ options := from.BuildOptions()+ call := llms.CallOptions{}+ for _, option := range options {+ option(&call)+ }++ assert.False(t, call.JSONMode, "json:false must not enable JSON mode")+ assert.Nil(t, call.N, "n:0 must not reach the request as an explicit parameter")+ assert.Empty(t, call.ResponseMIMEType)+}++// The shipped simple_json default carries `json: true`; saving a provider through the UI used to+// strip it, so the reloaded config called the LLM without JSON mode while the built-in one did not.+func TestShippedSimpleJSONKeepsJSONModeThroughTheGraphQLRoundTrip(t *testing.T) {+ pc, err := openai.DefaultProviderConfig()+ require.NoError(t, err)+ require.NotNil(t, pc.SimpleJSON)+ require.True(t, pc.SimpleJSON.JSON, "the shipped default is what makes this test meaningful")++ gql := ConvertProviderConfigToGqlModel(pc)+ require.NotNil(t, gql)++ restored := ConvertAgentsConfigFromGqlModel(gql)+ require.NotNil(t, restored)+ require.NotNil(t, restored.SimpleJSON)++ call := llms.CallOptions{}+ for _, option := range restored.SimpleJSON.BuildOptions() {+ option(&call)+ }++ assert.True(t, call.JSONMode, "the simple_json agent must still ask for JSON mode after a save")+}diff --git a/backend/pkg/database/database.go b/backend/pkg/database/database.goindex 96abc95a..1c4222d6 100644--- a/backend/pkg/database/database.go+++ b/backend/pkg/database/database.go@@ -70,15 +70,13 @@ func SanitizeUTF8(msg string) string {}var builder strings.Builder- builder.Grow(len(msg)) // Pre-allocate for efficiency+ builder.Grow(len(msg))for i := 0; i < len(msg); {- // Explicitly skip null bytesif msg[i] == '\x00' {i++continue}- // Decode rune and check for errorsr, size := utf8.DecodeRuneInString(msg[i:])if r == utf8.RuneError && size == 1 {// Invalid UTF-8 byte, replace with Unicode replacement characterdiff --git a/backend/pkg/graph/generated.go b/backend/pkg/graph/generated.goindex e6c1ac11..aac0cce2 100644--- a/backend/pkg/graph/generated.go+++ b/backend/pkg/graph/generated.go@@ -78,14 +78,18 @@ type ComplexityRoot struct {AgentConfig struct {ExtraBody func(childComplexity int) intFrequencyPenalty func(childComplexity int) int+ JSON func(childComplexity int) intMaxLength func(childComplexity int) intMaxTokens func(childComplexity int) intMinLength func(childComplexity int) int+ MinP func(childComplexity int) intModel func(childComplexity int) int+ N func(childComplexity int) intPresencePenalty func(childComplexity int) intPrice func(childComplexity int) intReasoning func(childComplexity int) intRepetitionPenalty func(childComplexity int) int+ ResponseMimeType func(childComplexity int) intTemperature func(childComplexity int) intTopK func(childComplexity int) intTopP func(childComplexity int) int@@ -1035,6 +1039,13 @@ func (e *executableSchema) Complexity(typeName, field string, childComplexity inreturn e.complexity.AgentConfig.FrequencyPenalty(childComplexity), true+ case "AgentConfig.json":+ if e.complexity.AgentConfig.JSON == nil {+ break+ }++ return e.complexity.AgentConfig.JSON(childComplexity), true+case "AgentConfig.maxLength":if e.complexity.AgentConfig.MaxLength == nil {break@@ -1056,6 +1067,13 @@ func (e *executableSchema) Complexity(typeName, field string, childComplexity inreturn e.complexity.AgentConfig.MinLength(childComplexity), true+ case "AgentConfig.minP":+ if e.complexity.AgentConfig.MinP == nil {+ break+ }++ return e.complexity.AgentConfig.MinP(childComplexity), true+case "AgentConfig.model":if e.complexity.AgentConfig.Model == nil {break@@ -1063,6 +1081,13 @@ func (e *executableSchema) Complexity(typeName, field string, childComplexity inreturn e.complexity.AgentConfig.Model(childComplexity), true+ case "AgentConfig.n":+ if e.complexity.AgentConfig.N == nil {+ break+ }++ return e.complexity.AgentConfig.N(childComplexity), true+case "AgentConfig.presencePenalty":if e.complexity.AgentConfig.PresencePenalty == nil {break@@ -1091,6 +1116,13 @@ func (e *executableSchema) Complexity(typeName, field string, childComplexity inreturn e.complexity.AgentConfig.RepetitionPenalty(childComplexity), true+ case "AgentConfig.responseMimeType":+ if e.complexity.AgentConfig.ResponseMimeType == nil {+ break+ }++ return e.complexity.AgentConfig.ResponseMimeType(childComplexity), true+case "AgentConfig.temperature":if e.complexity.AgentConfig.Temperature == nil {break@@ -9776,6 +9808,170 @@ func (ec *executionContext) fieldContext_AgentConfig_presencePenalty(_ context.Creturn fc, nil}+func (ec *executionContext) _AgentConfig_minP(ctx context.Context, field graphql.CollectedField, obj *model.AgentConfig) (ret graphql.Marshaler) {+ fc, err := ec.fieldContext_AgentConfig_minP(ctx, field)+ if err != nil {+ return graphql.Null+ }+ ctx = graphql.WithFieldContext(ctx, fc)+ defer func() {+ if r := recover(); r != nil {+ ec.Error(ctx, ec.Recover(ctx, r))+ ret = graphql.Null+ }+ }()+ resTmp, err := ec.ResolverMiddleware(ctx, func(rctx context.Context) (interface{}, error) {+ ctx = rctx // use context from middleware stack in children+ return obj.MinP, nil+ })+ if err != nil {+ ec.Error(ctx, err)+ return graphql.Null+ }+ if resTmp == nil {+ return graphql.Null+ }+ res := resTmp.(*float64)+ fc.Result = res+ return ec.marshalOFloat2ᚖfloat64(ctx, field.Selections, res)+}++func (ec *executionContext) fieldContext_AgentConfig_minP(_ context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {+ fc = &graphql.FieldContext{+ Object: "AgentConfig",+ Field: field,+ IsMethod: false,+ IsResolver: false,+ Child: func(ctx context.Context, field graphql.CollectedField) (*graphql.FieldContext, error) {+ return nil, errors.New("field of type Float does not have child fields")+ },+ }+ return fc, nil+}++func (ec *executionContext) _AgentConfig_n(ctx context.Context, field graphql.CollectedField, obj *model.AgentConfig) (ret graphql.Marshaler) {+ fc, err := ec.fieldContext_AgentConfig_n(ctx, field)+ if err != nil {+ return graphql.Null+ }+ ctx = graphql.WithFieldContext(ctx, fc)+ defer func() {+ if r := recover(); r != nil {+ ec.Error(ctx, ec.Recover(ctx, r))+ ret = graphql.Null+ }+ }()+ resTmp, err := ec.ResolverMiddleware(ctx, func(rctx context.Context) (interface{}, error) {+ ctx = rctx // use context from middleware stack in children+ return obj.N, nil+ })+ if err != nil {+ ec.Error(ctx, err)+ return graphql.Null+ }+ if resTmp == nil {+ return graphql.Null+ }+ res := resTmp.(*int)+ fc.Result = res+ return ec.marshalOInt2ᚖint(ctx, field.Selections, res)+}++func (ec *executionContext) fieldContext_AgentConfig_n(_ context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {+ fc = &graphql.FieldContext{+ Object: "AgentConfig",+ Field: field,+ IsMethod: false,+ IsResolver: false,+ Child: func(ctx context.Context, field graphql.CollectedField) (*graphql.FieldContext, error) {+ return nil, errors.New("field of type Int does not have child fields")+ },+ }+ return fc, nil+}++func (ec *executionContext) _AgentConfig_json(ctx context.Context, field graphql.CollectedField, obj *model.AgentConfig) (ret graphql.Marshaler) {+ fc, err := ec.fieldContext_AgentConfig_json(ctx, field)+ if err != nil {+ return graphql.Null+ }+ ctx = graphql.WithFieldContext(ctx, fc)+ defer func() {+ if r := recover(); r != nil {+ ec.Error(ctx, ec.Recover(ctx, r))+ ret = graphql.Null+ }+ }()+ resTmp, err := ec.ResolverMiddleware(ctx, func(rctx context.Context) (interface{}, error) {+ ctx = rctx // use context from middleware stack in children+ return obj.JSON, nil+ })+ if err != nil {+ ec.Error(ctx, err)+ return graphql.Null+ }+ if resTmp == nil {+ return graphql.Null+ }+ res := resTmp.(*bool)+ fc.Result = res+ return ec.marshalOBoolean2ᚖbool(ctx, field.Selections, res)+}++func (ec *executionContext) fieldContext_AgentConfig_json(_ context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {+ fc = &graphql.FieldContext{+ Object: "AgentConfig",+ Field: field,+ IsMethod: false,+ IsResolver: false,+ Child: func(ctx context.Context, field graphql.CollectedField) (*graphql.FieldContext, error) {+ return nil, errors.New("field of type Boolean does not have child fields")+ },+ }+ return fc, nil+}++func (ec *executionContext) _AgentConfig_responseMimeType(ctx context.Context, field graphql.CollectedField, obj *model.AgentConfig) (ret graphql.Marshaler) {+ fc, err := ec.fieldContext_AgentConfig_responseMimeType(ctx, field)+ if err != nil {+ return graphql.Null+ }+ ctx = graphql.WithFieldContext(ctx, fc)+ defer func() {+ if r := recover(); r != nil {+ ec.Error(ctx, ec.Recover(ctx, r))+ ret = graphql.Null+ }+ }()+ resTmp, err := ec.ResolverMiddleware(ctx, func(rctx context.Context) (interface{}, error) {+ ctx = rctx // use context from middleware stack in children+ return obj.ResponseMimeType, nil+ })+ if err != nil {+ ec.Error(ctx, err)+ return graphql.Null+ }+ if resTmp == nil {+ return graphql.Null+ }+ res := resTmp.(*string)+ fc.Result = res+ return ec.marshalOString2ᚖstring(ctx, field.Selections, res)+}++func (ec *executionContext) fieldContext_AgentConfig_responseMimeType(_ context.Context, field graphql.CollectedField) (fc *graphql.FieldContext, err error) {+ fc = &graphql.FieldContext{+ Object: "AgentConfig",+ Field: field,+ IsMethod: false,+ IsResolver: false,+ Child: func(ctx context.Context, field graphql.CollectedField) (*graphql.FieldContext, error) {+ return nil, errors.New("field of type String does not have child fields")+ },+ }+ return fc, nil+}+func (ec *executionContext) _AgentConfig_reasoning(ctx context.Context, field graphql.CollectedField, obj *model.AgentConfig) (ret graphql.Marshaler) {fc, err := ec.fieldContext_AgentConfig_reasoning(ctx, field)if err != nil {@@ -10684,6 +10880,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_simple(_ context.Context,return ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -10756,6 +10960,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_simpleJson(_ context.Contereturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -10828,6 +11040,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_primaryAgent(_ context.Conreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -10900,6 +11120,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_assistant(_ context.Contexreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -10972,6 +11200,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_generator(_ context.Contexreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11044,6 +11280,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_refiner(_ context.Context,return ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11116,6 +11360,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_adviser(_ context.Context,return ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11188,6 +11440,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_reflector(_ context.Contexreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11260,6 +11520,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_searcher(_ context.Contextreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11332,6 +11600,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_enricher(_ context.Contextreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11404,6 +11680,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_coder(_ context.Context, freturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11476,6 +11760,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_installer(_ context.Contexreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -11548,6 +11840,14 @@ func (ec *executionContext) fieldContext_AgentsConfig_pentester(_ context.Contexreturn ec.fieldContext_AgentConfig_frequencyPenalty(ctx, field)case "presencePenalty":return ec.fieldContext_AgentConfig_presencePenalty(ctx, field)+ case "minP":+ return ec.fieldContext_AgentConfig_minP(ctx, field)+ case "n":+ return ec.fieldContext_AgentConfig_n(ctx, field)+ case "json":+ return ec.fieldContext_AgentConfig_json(ctx, field)+ case "responseMimeType":+ return ec.fieldContext_AgentConfig_responseMimeType(ctx, field)case "reasoning":return ec.fieldContext_AgentConfig_reasoning(ctx, field)case "price":@@ -36725,7 +37025,7 @@ func (ec *executionContext) unmarshalInputAgentConfigInput(ctx context.Context,asMap[k] = v}- fieldsInOrder := [...]string{"model", "maxTokens", "temperature", "topK", "topP", "minLength", "maxLength", "repetitionPenalty", "frequencyPenalty", "presencePenalty", "reasoning", "price", "extraBody"}+ fieldsInOrder := [...]string{"model", "maxTokens", "temperature", "topK", "topP", "minLength", "maxLength", "repetitionPenalty", "frequencyPenalty", "presencePenalty", "minP", "n", "json", "responseMimeType", "reasoning", "price", "extraBody"}for _, k := range fieldsInOrder {v, ok := asMap[k]if !ok {@@ -36802,6 +37102,34 @@ func (ec *executionContext) unmarshalInputAgentConfigInput(ctx context.Context,return it, err}it.PresencePenalty = data+ case "minP":+ ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("minP"))+ data, err := ec.unmarshalOFloat2ᚖfloat64(ctx, v)+ if err != nil {+ return it, err+ }+ it.MinP = data+ case "n":+ ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("n"))+ data, err := ec.unmarshalOInt2ᚖint(ctx, v)+ if err != nil {+ return it, err+ }+ it.N = data+ case "json":+ ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("json"))+ data, err := ec.unmarshalOBoolean2ᚖbool(ctx, v)+ if err != nil {+ return it, err+ }+ it.JSON = data+ case "responseMimeType":+ ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("responseMimeType"))+ data, err := ec.unmarshalOString2ᚖstring(ctx, v)+ if err != nil {+ return it, err+ }+ it.ResponseMimeType = datacase "reasoning":ctx := graphql.WithPathContext(ctx, graphql.NewPathWithField("reasoning"))data, err := ec.unmarshalOReasoningConfigInput2ᚖpentagiᚋpkgᚋgraphᚋmodelᚐReasoningConfig(ctx, v)@@ -37564,6 +37892,14 @@ func (ec *executionContext) _AgentConfig(ctx context.Context, sel ast.SelectionSout.Values[i] = ec._AgentConfig_frequencyPenalty(ctx, field, obj)case "presencePenalty":out.Values[i] = ec._AgentConfig_presencePenalty(ctx, field, obj)+ case "minP":+ out.Values[i] = ec._AgentConfig_minP(ctx, field, obj)+ case "n":+ out.Values[i] = ec._AgentConfig_n(ctx, field, obj)+ case "json":+ out.Values[i] = ec._AgentConfig_json(ctx, field, obj)+ case "responseMimeType":+ out.Values[i] = ec._AgentConfig_responseMimeType(ctx, field, obj)case "reasoning":out.Values[i] = ec._AgentConfig_reasoning(ctx, field, obj)case "price":diff --git a/backend/pkg/graph/model/models_gen.go b/backend/pkg/graph/model/models_gen.goindex ebfb1370..37872d2b 100644--- a/backend/pkg/graph/model/models_gen.go+++ b/backend/pkg/graph/model/models_gen.go@@ -45,6 +45,10 @@ type AgentConfig struct {RepetitionPenalty *float64 `json:"repetitionPenalty,omitempty"`FrequencyPenalty *float64 `json:"frequencyPenalty,omitempty"`PresencePenalty *float64 `json:"presencePenalty,omitempty"`+ MinP *float64 `json:"minP,omitempty"`+ N *int `json:"n,omitempty"`+ JSON *bool `json:"json,omitempty"`+ ResponseMimeType *string `json:"responseMimeType,omitempty"`Reasoning *ReasoningConfig `json:"reasoning,omitempty"`Price *ModelPrice `json:"price,omitempty"`ExtraBody map[string]interface{} `json:"extraBody,omitempty"`diff --git a/backend/pkg/graph/schema.graphqls b/backend/pkg/graph/schema.graphqlsindex 7fb3f410..863d7011 100644--- a/backend/pkg/graph/schema.graphqls+++ b/backend/pkg/graph/schema.graphqls@@ -815,6 +815,10 @@ type AgentConfig {repetitionPenalty: FloatfrequencyPenalty: FloatpresencePenalty: Float+ minP: Float+ n: Int+ json: Boolean+ responseMimeType: Stringreasoning: ReasoningConfigprice: ModelPriceextraBody: Map@@ -866,6 +870,10 @@ input AgentConfigInput {repetitionPenalty: FloatfrequencyPenalty: FloatpresencePenalty: Float+ minP: Float+ n: Int+ json: Boolean+ responseMimeType: Stringreasoning: ReasoningConfigInputprice: ModelPriceInputextraBody: Mapdiff --git a/backend/pkg/graph/schema.resolvers.go b/backend/pkg/graph/schema.resolvers.goindex d285d0ef..9eb0d6cf 100644--- a/backend/pkg/graph/schema.resolvers.go+++ b/backend/pkg/graph/schema.resolvers.go@@ -257,7 +257,6 @@ func (r *mutationResolver) RenameFlow(ctx context.Context, flowID int64, title serr = r.Controller.RenameFlow(ctx, flowID, title)if errors.Is(err, controller.ErrFlowNotFound) {- // if flow worker not found, update flow title in DB and notify about itflow, err := r.DB.UpdateFlowTitle(ctx, database.UpdateFlowTitleParams{ID: flowID,Title: title,@@ -1956,7 +1955,6 @@ func (r *queryResolver) FlowsExecutionStatsByPeriod(ctx context.Context, period"period": period,}).Debug("get flows execution stats by period")- // Step 1: Get flows for the periodtype flowInfo struct {ID int64Title string@@ -1992,23 +1990,19 @@ func (r *queryResolver) FlowsExecutionStatsByPeriod(ctx context.Context, periodreturn nil, fmt.Errorf("unsupported period: %s", period)}- // Step 2: Build stats for each flow using analytics functionsresult := make([]*model.FlowExecutionStats, 0, len(flows))for _, flow := range flows {- // Get raw data for this flowtasks, err := r.DB.GetTasksForFlow(ctx, flow.ID)if err != nil {return nil, err}- // Collect task IDstaskIDs := make([]int64, len(tasks))for i, task := range tasks {taskIDs[i] = task.ID}- // Get subtasks for all tasksvar subtasks []database.GetSubtasksForTasksRowif len(taskIDs) > 0 {subtasks, err = r.DB.GetSubtasksForTasks(ctx, taskIDs)@@ -2017,25 +2011,21 @@ func (r *queryResolver) FlowsExecutionStatsByPeriod(ctx context.Context, period}}- // Get msgchains for the flowmsgchains, err := r.DB.GetMsgchainsForFlow(ctx, flow.ID)if err != nil {return nil, err}- // Get toolcalls for the flowtoolcalls, err := r.DB.GetToolcallsForFlow(ctx, flow.ID)if err != nil {return nil, err}- // Get assistants count for the flowassistantsCount, err := r.DB.GetAssistantsCountForFlow(ctx, flow.ID)if err != nil {return nil, err}- // Build execution stats using analytics functionsflowStats := converter.BuildFlowExecutionStats(flow.ID, flow.Title, tasks, subtasks, msgchains, toolcalls, int(assistantsCount))result = append(result, flowStats)}diff --git a/backend/pkg/graphiti/client.go b/backend/pkg/graphiti/client.goindex 3b4c2a43..3e648c24 100644--- a/backend/pkg/graphiti/client.go+++ b/backend/pkg/graphiti/client.go@@ -45,6 +45,13 @@ type Client struct {timeout time.Duration}+// The verdict is permanent for the process: on failure the caller keeps a disabled client for its whole+// lifetime, so one timeout against a slow endpoint must not decide it.+const (+ healthCheckAttempts = 3+ healthCheckBackoff = 2 * time.Second+)+// NewClient creates a new Graphiti client wrapperfunc NewClient(url string, timeout time.Duration, enabled bool) (*Client, error) {if !enabled {@@ -53,9 +60,17 @@ func NewClient(url string, timeout time.Duration, enabled bool) (*Client, error)client := graphiti.NewClient(url, graphiti.WithTimeout(timeout))- _, err := client.HealthCheck()- if err != nil {- return nil, fmt.Errorf("graphiti health check failed: %w", err)+ var err error+ for attempt := 1; ; attempt++ {+ if _, err = client.HealthCheck(); err == nil {+ break+ }++ if attempt == healthCheckAttempts {+ return nil, fmt.Errorf("graphiti health check failed after %d attempts: %w", attempt, err)+ }++ time.Sleep(healthCheckBackoff)}return &Client{diff --git a/backend/pkg/graphiti/client_test.go b/backend/pkg/graphiti/client_test.goindex 4e5cc439..23a8e303 100644--- a/backend/pkg/graphiti/client_test.go+++ b/backend/pkg/graphiti/client_test.go@@ -1,6 +1,9 @@package graphitiimport (+ "net/http"+ "net/http/httptest"+ "sync/atomic""testing""time"@@ -148,3 +151,42 @@ func TestSearchMethods_Disabled(t *testing.T) {})}}++func TestNewClient_RetriesAFlakyHealthCheck(t *testing.T) {+ t.Parallel()++ var probes atomic.Int32++ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {+ if probes.Add(1) == 1 {+ w.WriteHeader(http.StatusServiceUnavailable)++ return+ }++ w.WriteHeader(http.StatusOK)+ _, _ = w.Write([]byte(`{"status":"ok"}`))+ }))+ defer server.Close()++ client, err := NewClient(server.URL, 5*time.Second, true)+ require.NoError(t, err)+ assert.True(t, client.IsEnabled())+ assert.EqualValues(t, 2, probes.Load(), "the first probe failed, so a second one had to run")+}++func TestNewClient_GivesUpAfterEveryAttemptFails(t *testing.T) {+ t.Parallel()++ var probes atomic.Int32++ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {+ probes.Add(1)+ w.WriteHeader(http.StatusServiceUnavailable)+ }))+ defer server.Close()++ _, err := NewClient(server.URL, 5*time.Second, true)+ require.Error(t, err)+ assert.EqualValues(t, healthCheckAttempts, probes.Load())+}diff --git a/backend/pkg/providers/custom/custom.go b/backend/pkg/providers/custom/custom.goindex 327822a9..5e52e275 100644--- a/backend/pkg/providers/custom/custom.go+++ b/backend/pkg/providers/custom/custom.go@@ -92,10 +92,8 @@ func New(return nil, err}- // Use centralized model loading with prefix filteringmodels, err := provider.LoadModelsFromHTTP(baseURL, baseKey, httpClient, cfg.LLMServerProvider)if err != nil {- // If loading fails, fallback to empty models listmodels = pconfig.ModelsConfig{}}diff --git a/backend/pkg/providers/gemini/gemini_test.go b/backend/pkg/providers/gemini/gemini_test.goindex 04f81c44..bd95ffb6 100644--- a/backend/pkg/providers/gemini/gemini_test.go+++ b/backend/pkg/providers/gemini/gemini_test.go@@ -250,7 +250,6 @@ func TestAPIKeyTransportRoundTrip(t *testing.T) {for _, tt := range tests {t.Run(tt.name, func(t *testing.T) {- // create mock round tripper that captures the requestvar capturedReq *http.RequestmockRT := &mockRoundTripper{roundTripFunc: func(req *http.Request) (*http.Response, error) {@@ -270,7 +269,6 @@ func TestAPIKeyTransportRoundTrip(t *testing.T) {ProxyURL: "",}- // create test requestreqURL := tt.requestURLif tt.requestQuery != "" {reqURL += "?" + tt.requestQuery@@ -280,13 +278,11 @@ func TestAPIKeyTransportRoundTrip(t *testing.T) {t.Fatalf("Failed to create request: %v", err)}- // execute RoundTrip_, err = transport.RoundTrip(req)if err != nil {t.Fatalf("RoundTrip failed: %v", err)}- // verify captured requestif capturedReq == nil {t.Fatal("Request was not captured")}diff --git a/backend/pkg/providers/pconfig/config.go b/backend/pkg/providers/pconfig/config.goindex fa5c6bdf..4e305e6b 100644--- a/backend/pkg/providers/pconfig/config.go+++ b/backend/pkg/providers/pconfig/config.go@@ -432,7 +432,6 @@ func (mc *ModelConfig) UnmarshalJSON(data []byte) error {return err}- // Parse each field manuallyif name, ok := raw["name"].(string); ok {mc.Name = name}@@ -487,7 +486,6 @@ func (mc *ModelConfig) UnmarshalYAML(value *yaml.Node) error {return err}- // Parse each field manuallyif name, ok := raw["name"].(string); ok {mc.Name = name}@@ -763,7 +761,6 @@ func (ac *AgentConfig) marshalMap() map[string]any {return nil}- // use raw map if available, otherwise create a new oneif ac.raw != nil {return ac.raw}diff --git a/backend/pkg/providers/performer.go b/backend/pkg/providers/performer.goindex 4e718e52..2ed993cf 100644--- a/backend/pkg/providers/performer.go+++ b/backend/pkg/providers/performer.go@@ -70,7 +70,6 @@ func (fp *flowProvider) performAgentChain("msg_chain_id": chainID,}))- // Track execution time for duration calculationlastUpdateTime := time.Now()rollLastUpdateTime := func() float64 {durationDelta := time.Since(lastUpdateTime).Seconds()diff --git a/backend/pkg/providers/performers.go b/backend/pkg/providers/performers.goindex d9748a82..1f35d34a 100644--- a/backend/pkg/providers/performers.go+++ b/backend/pkg/providers/performers.go@@ -194,7 +194,6 @@ func (fp *flowProvider) performSubtasksRefiner(logger.Debug("starting subtasks refiner")- // Track execution time for duration calculationstartTime := time.Now()restoreChain := func(msgChain json.RawMessage) ([]llms.MessageContent, error) {diff --git a/backend/pkg/providers/provider.go b/backend/pkg/providers/provider.goindex eb996c99..b1aab2ad 100644--- a/backend/pkg/providers/provider.go+++ b/backend/pkg/providers/provider.go@@ -187,7 +187,6 @@ func (fp *flowProvider) SetProvider(ctx context.Context, newProvider provider.Prfp.mx.Lock()defer fp.mx.Unlock()- // Update provider-specific fieldsfp.Provider = newProvidervar err errordiff --git a/backend/pkg/providers/provider/agents.go b/backend/pkg/providers/provider/agents.goindex ba21fb40..3cd3f4f3 100644--- a/backend/pkg/providers/provider/agents.go+++ b/backend/pkg/providers/provider/agents.go@@ -57,30 +57,23 @@ func testTemplate(prompter templates.Prompter,template string,) bool {- // If no template provided, skip validationif template == "" {return false}- // Collect one sample to validate the templatesamples, err := runToolCallIDCollector(ctx, provider, opt, prompter)if err != nil {- // Any error means validation failedreturn false}- // If no samples collected, validation failedif len(samples) == 0 {return false}- // Validate the template against collected samplesif err := templates.ValidatePattern(template, samples); err != nil {- // Template doesn't matchreturn false}- // Template validated successfullyreturn true}diff --git a/backend/pkg/providers/subtask_patch.go b/backend/pkg/providers/subtask_patch.goindex ae468452..ae9baf57 100644--- a/backend/pkg/providers/subtask_patch.go+++ b/backend/pkg/providers/subtask_patch.go@@ -24,7 +24,6 @@ func applySubtaskOperations("message": patch.Message,}).Debug("applying subtask operations")- // Fix the patch to ensure it is validpatch = fixSubtaskPatch(planned, patch)// Convert database.Subtask to tools.SubtaskInfo with IDsdiff --git a/backend/pkg/server/auth/api_token_cache.go b/backend/pkg/server/auth/api_token_cache.goindex 9f3d196f..fc5260a1 100644--- a/backend/pkg/server/auth/api_token_cache.go+++ b/backend/pkg/server/auth/api_token_cache.go@@ -39,25 +39,20 @@ func (tc *TokenCache) SetTTL(ttl time.Duration) {// GetStatus retrieves token status and privileges from cache or databasefunc (tc *TokenCache) GetStatus(tokenID string) (models.TokenStatus, []string, error) {- // check cache firstif entry, ok := tc.cache.Load(tokenID); ok {cached := entry.(tokenCacheEntry)if time.Now().Before(cached.expiresAt) {- // return cached "not found" errorif cached.notFound {return "", nil, gorm.ErrRecordNotFound}return cached.status, cached.privileges, nil}- // cache entry expired, remove ittc.cache.Delete(tokenID)}- // load from database with role privilegesvar token models.APITokenif err := tc.db.Where("token_id = ? AND deleted_at IS NULL", tokenID).First(&token).Error; err != nil {if gorm.IsRecordNotFoundError(err) {- // cache negative result (token not found)tc.cache.Store(tokenID, tokenCacheEntry{notFound: true,expiresAt: time.Now().Add(tc.ttl),@@ -67,13 +62,11 @@ func (tc *TokenCache) GetStatus(tokenID string) (models.TokenStatus, []string, ereturn "", nil, err}- // load privileges for the token's rolevar privileges []models.Privilegeif err := tc.db.Where("role_id = ?", token.RoleID).Find(&privileges).Error; err != nil {return "", nil, err}- // extract privilege namesprivNames := make([]string, len(privileges))for i, priv := range privileges {privNames[i] = priv.Name@@ -82,7 +75,6 @@ func (tc *TokenCache) GetStatus(tokenID string) (models.TokenStatus, []string, e// always add automation privilege for API tokensprivNames = append(privNames, PrivilegeAutomation)- // update cache with positive resulttc.cache.Store(tokenID, tokenCacheEntry{status: token.Status,privileges: privNames,@@ -100,13 +92,11 @@ func (tc *TokenCache) Invalidate(tokenID string) {// InvalidateUser removes all tokens for a specific user from cachefunc (tc *TokenCache) InvalidateUser(userID uint64) {- // load all tokens for this uservar tokens []models.APITokenif err := tc.db.Where("user_id = ? AND deleted_at IS NULL", userID).Find(&tokens).Error; err != nil {return}- // invalidate each token in cachefor _, token := range tokens {tc.cache.Delete(token.TokenID)}diff --git a/backend/pkg/server/auth/auth_middleware.go b/backend/pkg/server/auth/auth_middleware.goindex 266e907d..ab175614 100644--- a/backend/pkg/server/auth/auth_middleware.go+++ b/backend/pkg/server/auth/auth_middleware.go@@ -123,7 +123,6 @@ func (p *AuthMiddleware) tryUserCookieAuthentication(c *gin.Context) (authResultreturn authResultFail, errors.New("no permissions granted")}- // Verify session expirationexpVal, ok := exp.(int64)if !ok {return authResultFail, errors.New("token claim invalid")diff --git a/backend/pkg/server/auth/session.go b/backend/pkg/server/auth/session.goindex e7563c46..26cc9df6 100644--- a/backend/pkg/server/auth/session.go+++ b/backend/pkg/server/auth/session.go@@ -22,7 +22,6 @@ const (// MakeCookieStoreKey is function to generate auth and encryption keys for cookie storefunc MakeCookieStoreKey(globalSalt string) [][]byte {- // Check cache for existing keysif cached, ok := cookieStoreKeys.Load(globalSalt); ok {return cached.([][]byte)}@@ -51,7 +50,6 @@ func MakeCookieStoreKey(globalSalt string) [][]byte {// MakeJWTSigningKey is function to generate signing key for JWT tokensfunc MakeJWTSigningKey(globalSalt string) []byte {- // Check cache for existing keyif cached, ok := jwtSigningKeys.Load(globalSalt); ok {return cached.([]byte)}diff --git a/backend/pkg/server/auth/users_cache.go b/backend/pkg/server/auth/users_cache.goindex a3ec9dc0..7263dc8d 100644--- a/backend/pkg/server/auth/users_cache.go+++ b/backend/pkg/server/auth/users_cache.go@@ -39,25 +39,20 @@ func (uc *UserCache) SetTTL(ttl time.Duration) {// GetUserHash retrieves user hash and status from cache or databasefunc (uc *UserCache) GetUserHash(userID uint64) (string, models.UserStatus, error) {- // check cache firstif entry, ok := uc.cache.Load(userID); ok {cached := entry.(userCacheEntry)if time.Now().Before(cached.expiresAt) {- // return cached "not found" errorif cached.notFound {return "", "", gorm.ErrRecordNotFound}return cached.hash, cached.status, nil}- // cache entry expired, remove ituc.cache.Delete(userID)}- // load from databasevar user models.Userif err := uc.db.Where("id = ?", userID).First(&user).Error; err != nil {if gorm.IsRecordNotFoundError(err) {- // cache negative result (user not found)uc.cache.Store(userID, userCacheEntry{notFound: true,expiresAt: time.Now().Add(uc.ttl),@@ -67,7 +62,6 @@ func (uc *UserCache) GetUserHash(userID uint64) (string, models.UserStatus, erroreturn "", "", err}- // update cache with positive resultuc.cache.Store(userID, userCacheEntry{hash: user.Hash,status: user.Status,diff --git a/backend/pkg/server/models/init.go b/backend/pkg/server/models/init.goindex 1847252d..9db52973 100644--- a/backend/pkg/server/models/init.go+++ b/backend/pkg/server/models/init.go@@ -87,6 +87,22 @@ func strongPasswordValidatorString() validator.Func {}}+// MaxPasswordBytes is the longest password bcrypt.GenerateFromPassword accepts.+const MaxPasswordBytes = 72++func passwordLengthValidatorString() validator.Func {+ return func(fl validator.FieldLevel) bool {+ field := fl.Field()++ switch field.Kind() {+ case reflect.String:+ return len(field.String()) <= MaxPasswordBytes+ default:+ return false+ }+ }+}+var emailFormatRegex = regexp.MustCompile(`^[a-zA-Z0-9._%+\-]+@[a-zA-Z0-9.\-]+\.[a-zA-Z]{2,}$`)func isRealEmail(email string) bool {@@ -223,6 +239,7 @@ func init() {_ = validate.RegisterValidation("semver", templateValidatorString(semverRegexString))_ = validate.RegisterValidation("semverex", templateValidatorString(semverexRegexString))_ = validate.RegisterValidation("stpass", strongPasswordValidatorString())+ _ = validate.RegisterValidation("passlen", passwordLengthValidatorString())_ = validate.RegisterValidation("vmail", emailValidatorString())_ = validate.RegisterValidation("realemail", strictEmailValidatorString())_ = validate.RegisterValidation("oauth_min_scope", oauthMinScope())diff --git a/backend/pkg/server/models/users.go b/backend/pkg/server/models/users.goindex d5486e4a..f53698b5 100644--- a/backend/pkg/server/models/users.go+++ b/backend/pkg/server/models/users.go@@ -103,7 +103,7 @@ func (u User) Validate(db *gorm.DB) {// UserPassword is model to contain user informationtype UserPassword struct {- Password string `form:"password" json:"password" validate:"max=100,required" gorm:"column:password;type:TEXT"`+ Password string `form:"password" json:"password" validate:"passlen,required" gorm:"column:password;type:TEXT"`User `form:"" json:""`}@@ -168,7 +168,7 @@ func (au AuthCallback) Valid() error {// nolint:llltype Password struct {CurrentPassword string `form:"current_password" json:"current_password" validate:"nefield=Password,min=5,max=100,required" gorm:"-"`- Password string `form:"password" json:"password" validate:"stpass,max=100,required" gorm:"type:TEXT"`+ Password string `form:"password" json:"password" validate:"stpass,passlen,required" gorm:"type:TEXT"`ConfirmPassword string `form:"confirm_password" json:"confirm_password" validate:"eqfield=Password" gorm:"-"`}diff --git a/backend/pkg/server/models/users_test.go b/backend/pkg/server/models/users_test.goindex 7c6fde29..55922957 100644--- a/backend/pkg/server/models/users_test.go+++ b/backend/pkg/server/models/users_test.go@@ -1,6 +1,7 @@package modelsimport (+ "strings""testing""github.com/stretchr/testify/assert"@@ -196,6 +197,24 @@ func TestPasswordValid(t *testing.T) {},wantErr: true,},+ {+ name: "new password at the bcrypt limit",+ pw: Password{+ CurrentPassword: "OldPass1!abc",+ Password: strings.Repeat("a", MaxPasswordBytes),+ ConfirmPassword: strings.Repeat("a", MaxPasswordBytes),+ },+ wantErr: false,+ },+ {+ name: "new password over the bcrypt limit",+ pw: Password{+ CurrentPassword: "OldPass1!abc",+ Password: strings.Repeat("a", MaxPasswordBytes+1),+ ConfirmPassword: strings.Repeat("a", MaxPasswordBytes+1),+ },+ wantErr: true,+ },}for _, tt := range tests {@@ -309,6 +328,52 @@ func TestUserPasswordValid(t *testing.T) {}assert.Error(t, up.Valid())})++ for _, tc := range []struct {+ name string+ length int+ wantErr bool+ }{+ {name: "password at the bcrypt limit", length: MaxPasswordBytes, wantErr: false},+ {name: "password over the bcrypt limit", length: MaxPasswordBytes + 1, wantErr: true},+ } {+ t.Run(tc.name, func(t *testing.T) {+ t.Parallel()+ up := UserPassword{+ Password: strings.Repeat("a", tc.length),+ User: User{+ ID: 1,+ Hash: "abcdef1234567890abcdef1234567890",+ Type: UserTypeLocal,+ Mail: "[email protected]",+ Status: UserStatusActive,+ RoleID: RoleUser,+ },+ }+ if tc.wantErr {+ assert.Error(t, up.Valid())+ } else {+ assert.NoError(t, up.Valid())+ }+ })+ }++ t.Run("multibyte password within the rune count but over the byte limit", func(t *testing.T) {+ t.Parallel()+ up := UserPassword{+ // 40 runes, 80 bytes: a rune-counting `max=72` would let this through.+ Password: strings.Repeat("é", 40),+ User: User{+ ID: 1,+ Hash: "abcdef1234567890abcdef1234567890",+ Type: UserTypeLocal,+ Mail: "[email protected]",+ Status: UserStatusActive,+ RoleID: RoleUser,+ },+ }+ assert.Error(t, up.Valid())+ })}func TestUserPasswordTableName(t *testing.T) {diff --git a/backend/pkg/server/services/api_tokens.go b/backend/pkg/server/services/api_tokens.goindex 653a1c42..75ace985 100644--- a/backend/pkg/server/services/api_tokens.go+++ b/backend/pkg/server/services/api_tokens.go@@ -56,7 +56,6 @@ func NewTokenService(// @Failure 500 {object} response.errorResp "internal error on creating token"// @Router /tokens [post]func (s *TokenService) CreateToken(c *gin.Context) {- // check for default saltif s.globalSalt == "" || s.globalSalt == "salt" {logger.FromContext(c).Errorf("token creation attempted with default salt")response.Error(c, response.ErrTokenCreationDisabled, errors.New("token creation is disabled with default salt"))@@ -79,7 +78,6 @@ func (s *TokenService) CreateToken(c *gin.Context) {return}- // check if name is unique for this user (if provided)if req.Name != nil && *req.Name != "" {var existing models.APITokenerr := s.db.@@ -93,7 +91,6 @@ func (s *TokenService) CreateToken(c *gin.Context) {}}- // generate token_idtokenID, err := auth.GenerateTokenID()if err != nil {logger.FromContext(c).WithError(err).Errorf("error generating token ID")@@ -101,10 +98,8 @@ func (s *TokenService) CreateToken(c *gin.Context) {return}- // create JWT claimsclaims := auth.MakeAPITokenClaims(tokenID, uhash, uid, rid, req.TTL)- // sign tokentoken, err := auth.MakeAPIToken(s.globalSalt, claims)if err != nil {logger.FromContext(c).WithError(err).Errorf("error signing token")@@ -112,7 +107,6 @@ func (s *TokenService) CreateToken(c *gin.Context) {return}- // save to databaseapiToken := models.APIToken{TokenID: tokenID,UserID: uid,@@ -162,10 +156,8 @@ func (s *TokenService) ListTokens(c *gin.Context) {query := s.db.Where("deleted_at IS NULL")- // check if user has admin privilegehasAdmin := auth.LookupPerm(prms, "settings.tokens.admin")if !hasAdmin {- // regular user sees only their own tokensquery = query.Where("user_id = ?", uid)}@@ -220,7 +212,6 @@ func (s *TokenService) GetToken(c *gin.Context) {return}- // check authorizationhasAdmin := auth.LookupPerm(prms, "settings.tokens.admin")if !hasAdmin && token.UserID != uid {logger.FromContext(c).Errorf("user %d attempted to access token of user %d", uid, token.UserID)@@ -283,7 +274,6 @@ func (s *TokenService) UpdateToken(c *gin.Context) {return}- // check authorizationhasAdmin := auth.LookupPerm(prms, "settings.tokens.admin")if !hasAdmin && token.UserID != uid {logger.FromContext(c).Errorf("user %d attempted to update token of user %d", uid, token.UserID)@@ -291,10 +281,8 @@ func (s *TokenService) UpdateToken(c *gin.Context) {return}- // update fieldsupdates := make(map[string]any)if req.Name != nil {- // check uniqueness if name is changingif token.Name == nil || *token.Name != *req.Name {if *req.Name != "" {var existing models.APIToken@@ -327,14 +315,12 @@ func (s *TokenService) UpdateToken(c *gin.Context) {return}- // invalidate cache if status changedif req.Status != "" {s.tokenCache.Invalidate(tokenID)// also invalidate all tokens for this user (in case of role change or security event)s.tokenCache.InvalidateUser(token.UserID)}- // reload tokenif err := s.db.Where("token_id = ?", tokenID).First(&token).Error; err != nil {logger.FromContext(c).WithError(err).Errorf("error reloading token")response.Error(c, response.ErrInternal, err)@@ -381,7 +367,6 @@ func (s *TokenService) DeleteToken(c *gin.Context) {return}- // check authorizationhasAdmin := auth.LookupPerm(prms, "settings.tokens.admin")if !hasAdmin && token.UserID != uid {logger.FromContext(c).Errorf("user %d attempted to delete token of user %d", uid, token.UserID)@@ -396,7 +381,6 @@ func (s *TokenService) DeleteToken(c *gin.Context) {return}- // invalidate cache for this token and all user's tokenss.tokenCache.Invalidate(tokenID)s.tokenCache.InvalidateUser(token.UserID)diff --git a/backend/pkg/terminal/output.go b/backend/pkg/terminal/output.goindex 51b9b077..75ddd631 100644--- a/backend/pkg/terminal/output.go+++ b/backend/pkg/terminal/output.go@@ -151,14 +151,11 @@ func RenderMarkdown(markdown string) {// InteractivePromptContext prompts the user for input with support for context cancellationfunc InteractivePromptContext(ctx context.Context, message string, reader io.Reader) (string, error) {- // Display the promptinfoColor.Printf("%s: ", message)- // Create a channel for the user inputinputCh := make(chan string, 1)errCh := make(chan error, 1)- // Start a goroutine to read user inputgo func() {// Use a buffered reader to properly handle inputr, ok := reader.(*os.File)@@ -186,7 +183,6 @@ func InteractivePromptContext(ctx context.Context, message string, reader io.Rea}}()- // Wait for input or context cancellationselect {case input := <-inputCh:return input, nil@@ -228,7 +224,6 @@ func GetYesNoInputContext(ctx context.Context, message string, reader io.Reader)// IsMarkdownContent checks if the input string is likely markdown contentfunc IsMarkdownContent(content string) bool {- // Determine if content is likely markdown by checking for common indicatorsif strings.HasPrefix(content, "#") ||strings.Contains(content, "\n#") ||strings.Contains(content, "[") && strings.Contains(content, "](") ||diff --git a/backend/pkg/tools/browser.go b/backend/pkg/tools/browser.goindex 4f5f7f31..a3f2932e 100644--- a/backend/pkg/tools/browser.go+++ b/backend/pkg/tools/browser.go@@ -42,7 +42,6 @@ var nonHTMLExtensions = []string{// isBinaryURL returns true when the URL points to a known non-HTML resource.func isBinaryURL(rawURL string) bool {lower := strings.ToLower(rawURL)- // strip query string for extension matchingif idx := strings.Index(lower, "?"); idx != -1 {lower = lower[:idx]}@@ -303,7 +302,6 @@ func (b *browser) resolveUrl(targetURL string) (*url.URL, error) {host = u.Host}- // determine if target is private or publicisPrivate := falsehostIP := net.ParseIP(host)@@ -328,7 +326,6 @@ func (b *browser) resolveUrl(targetURL string) (*url.URL, error) {}}- // select appropriate scraper URL with fallbackvar scraperURL stringif isPrivate {scraperURL = b.scPrvURLdiff --git a/backend/pkg/tools/code.go b/backend/pkg/tools/code.goindex 238860f2..7891cb58 100644--- a/backend/pkg/tools/code.go+++ b/backend/pkg/tools/code.go@@ -126,7 +126,6 @@ func (c *code) Handle(ctx context.Context, name string, args json.RawMessage) (s"filters": filters,})- // Execute multiple queries and collect all documentsvar allDocs []schema.Documentfor i, query := range action.Questions {queryLogger := logger.WithFields(logrus.Fields{@@ -154,7 +153,6 @@ func (c *code) Handle(ctx context.Context, name string, args json.RawMessage) (s"total_docs_before_dedup": len(allDocs),}).Debug("all queries completed")- // Merge, deduplicate, sort by score, and limit resultsdocs := MergeAndDeduplicateDocs(allDocs, codeVectorStoreResultLimit)logger.WithFields(logrus.Fields{@@ -202,7 +200,6 @@ func (c *code) Handle(ctx context.Context, name string, args json.RawMessage) (slogger.WithError(err).Error("failed to marshal filters")return "", fmt.Errorf("failed to marshal filters: %w", err)}- // Join all queries for loggingqueriesText := strings.Join(action.Questions, "\n--------------------------------\n")_, _ = c.vslp.PutLog(ctx,@@ -256,7 +253,6 @@ func (c *code) Handle(ctx context.Context, name string, args json.RawMessage) (s"code": action.Code[:min(len(action.Code), 1000)],})- // Build common metadata for the document.metadata := map[string]any{"user_id": c.userID,"flow_id": c.flowID,diff --git a/backend/pkg/tools/executor.go b/backend/pkg/tools/executor.goindex f9385adc..e63df479 100644--- a/backend/pkg/tools/executor.go+++ b/backend/pkg/tools/executor.go@@ -126,7 +126,6 @@ func (w *noopObservationWrapper) ctx() context.Context {}func (w *noopObservationWrapper) end(result string, err error, durationSeconds float64) {- // no-op}type customExecutor struct {@@ -258,7 +257,6 @@ func (ce *customExecutor) Execute(return fmt.Sprintf("failed to unmarshal '%s' tool call arguments: %v: fix it", name, err), nil}- // Create observation based on tool typetoolType := GetToolType(name)var obsWrapper observationWrapper@@ -273,11 +271,9 @@ func (ce *customExecutor) Execute(// Skip - handlers create RETRIEVER internallyobsWrapper = &noopObservationWrapper{context: ctx}default:- // Unknown type - use no-op wrapperobsWrapper = &noopObservationWrapper{context: ctx}}- // Use context from observation wrapperctx = obsWrapper.ctx()var err errordiff --git a/backend/pkg/tools/flow_manager.go b/backend/pkg/tools/flow_manager.goindex 00845104..e8d02102 100644--- a/backend/pkg/tools/flow_manager.go+++ b/backend/pkg/tools/flow_manager.go@@ -838,7 +838,6 @@ func (t *patchFlowSubtasksTool) Handle(ctx context.Context, name string, args js}}- // Verify task_id belongs to this flow.taskBelongsToFlow := falsefor _, task := range tasks {if task.ID == action.TaskID {@@ -853,7 +852,6 @@ func (t *patchFlowSubtasksTool) Handle(ctx context.Context, name string, args jsaction.TaskID, GetFlowStatusToolName)}- // Verify there are planned subtasks to patch.planned, err := t.db.GetTaskPlannedSubtasks(ctx, action.TaskID)if err != nil {return "", fmt.Errorf("failed to get planned subtasks for task %d: %w", action.TaskID, err)diff --git a/backend/pkg/tools/graphiti_search.go b/backend/pkg/tools/graphiti_search.goindex 7e5c8b8d..fb9a8eaf 100644--- a/backend/pkg/tools/graphiti_search.go+++ b/backend/pkg/tools/graphiti_search.go@@ -159,7 +159,6 @@ func (t *graphitiSearchTool) Handle(ctx context.Context, name string, args json.searchArgs.Query = strings.TrimSpace(searchArgs.Query)- // Validate required parametersif searchArgs.Query == "" {logger.Error("query parameter is required")return "", fmt.Errorf("query parameter is required")@@ -169,7 +168,6 @@ func (t *graphitiSearchTool) Handle(ctx context.Context, name string, args json.return "", fmt.Errorf("search_type parameter is required")}- // Get group ID from flow contextgroupID := fmt.Sprintf("flow-%d", t.flowID)ctx, observation := obs.Observer.NewObservation(ctx)@@ -199,7 +197,6 @@ func (t *graphitiSearchTool) Handle(ctx context.Context, name string, args json.Time: time.Now().UTC(),}- // Route to appropriate search methodvar (err errorresult stringdiff --git a/backend/pkg/tools/guide.go b/backend/pkg/tools/guide.goindex a0d304c5..04b6f4a7 100644--- a/backend/pkg/tools/guide.go+++ b/backend/pkg/tools/guide.go@@ -123,7 +123,6 @@ func (g *guide) Handle(ctx context.Context, name string, args json.RawMessage) ("type": action.Type,})- // Execute multiple queries and collect all documentsvar allDocs []schema.Documentfor i, query := range action.Questions {queryLogger := logger.WithFields(logrus.Fields{@@ -151,7 +150,6 @@ func (g *guide) Handle(ctx context.Context, name string, args json.RawMessage) ("total_docs_before_dedup": len(allDocs),}).Debug("all queries completed")- // Merge, deduplicate, sort by score, and limit resultsdocs := MergeAndDeduplicateDocs(allDocs, guideVectorStoreResultLimit)logger.WithFields(logrus.Fields{@@ -199,7 +197,6 @@ func (g *guide) Handle(ctx context.Context, name string, args json.RawMessage) (logger.WithError(err).Error("failed to marshal filters")return "", fmt.Errorf("failed to marshal filters: %w", err)}- // Join all queries for loggingqueriesText := strings.Join(action.Questions, "\n--------------------------------\n")_, _ = g.vslp.PutLog(ctx,@@ -252,7 +249,6 @@ func (g *guide) Handle(ctx context.Context, name string, args json.RawMessage) ("guide": action.Guide[:min(len(action.Guide), 1000)],})- // Build common metadata for the document.metadata := map[string]any{"user_id": g.userID,"flow_id": g.flowID,diff --git a/backend/pkg/tools/memory.go b/backend/pkg/tools/memory.goindex 04aca6a7..2b779b23 100644--- a/backend/pkg/tools/memory.go+++ b/backend/pkg/tools/memory.go@@ -111,7 +111,6 @@ func (m *memory) Handle(ctx context.Context, name string, args json.RawMessage)logger = logger.WithFields(fields)- // Execute multiple queries and collect all documentsvar allDocs []schema.Documentfor i, query := range action.Questions {queryLogger := logger.WithFields(logrus.Fields{@@ -168,7 +167,6 @@ func (m *memory) Handle(ctx context.Context, name string, args json.RawMessage)"total_docs_before_dedup": len(allDocs),}).Debug("all queries completed")- // Merge, deduplicate, sort by score, and limit resultsdocs := MergeAndDeduplicateDocs(allDocs, memoryVectorStoreResultLimit)logger.WithFields(logrus.Fields{@@ -224,7 +222,6 @@ func (m *memory) Handle(ctx context.Context, name string, args json.RawMessage)logger.WithError(err).Error("failed to marshal filters")return "", fmt.Errorf("failed to marshal filters: %w", err)}- // Join all queries for loggingqueriesText := strings.Join(action.Questions, "\n--------------------------------\n")_, _ = m.vslp.PutLog(ctx,diff --git a/backend/pkg/tools/memory_utils.go b/backend/pkg/tools/memory_utils.goindex 5d1b2b5c..719ed5eb 100644--- a/backend/pkg/tools/memory_utils.go+++ b/backend/pkg/tools/memory_utils.go@@ -28,7 +28,6 @@ func MergeAndDeduplicateDocs(docs []schema.Document, maxDocs int) []schema.Documfor _, doc := range docs {hash := hashContent(doc.PageContent)- // If document with this hash already exists, keep the one with higher scoreif existing, found := docMap[hash]; found {if doc.Score > existing.Score {docMap[hash] = doc@@ -38,18 +37,15 @@ func MergeAndDeduplicateDocs(docs []schema.Document, maxDocs int) []schema.Docum}}- // Convert map to sliceresult := make([]schema.Document, 0, len(docMap))for _, doc := range docMap {result = append(result, doc)}- // Sort by score in descending order (highest score first)sort.Slice(result, func(i, j int) bool {return result[i].Score > result[j].Score})- // Limit to maxDocsif len(result) > maxDocs {result = result[:maxDocs]}diff --git a/backend/pkg/tools/search.go b/backend/pkg/tools/search.goindex ab852d89..6af9a482 100644--- a/backend/pkg/tools/search.go+++ b/backend/pkg/tools/search.go@@ -121,7 +121,6 @@ func (s *search) Handle(ctx context.Context, name string, args json.RawMessage)"answer_type": action.Type,})- // Execute multiple queries and collect all documentsvar allDocs []schema.Documentfor i, query := range action.Questions {queryLogger := logger.WithFields(logrus.Fields{@@ -149,7 +148,6 @@ func (s *search) Handle(ctx context.Context, name string, args json.RawMessage)"total_docs_before_dedup": len(allDocs),}).Debug("all queries completed")- // Merge, deduplicate, sort by score, and limit resultsdocs := MergeAndDeduplicateDocs(allDocs, searchVectorStoreResultLimit)logger.WithFields(logrus.Fields{@@ -197,7 +195,6 @@ func (s *search) Handle(ctx context.Context, name string, args json.RawMessage)logger.WithError(err).Error("failed to marshal filters")return "", fmt.Errorf("failed to marshal filters: %w", err)}- // Join all queries for loggingqueriesText := strings.Join(action.Questions, "\n--------------------------------\n")_, _ = s.vslp.PutLog(ctx,@@ -247,7 +244,6 @@ func (s *search) Handle(ctx context.Context, name string, args json.RawMessage)"answer": action.Answer[:min(len(action.Answer), 1000)],})- // Build common metadata for the document.metadata := map[string]any{"user_id": s.userID,"flow_id": s.flowID,diff --git a/backend/pkg/tools/terminal.go b/backend/pkg/tools/terminal.goindex c1d2e8dc..503feb4a 100644--- a/backend/pkg/tools/terminal.go+++ b/backend/pkg/tools/terminal.go@@ -192,14 +192,12 @@ func (t *terminal) ExecCommand() (string, error) {containerName := PrimaryTerminalName(t.flowID)- // create options for starting the exec processcmd := []string{"sh","-c",command,}- // verify container runtime statusisRunning, err := t.dockerClient.IsContainerRunning(ctx, t.containerLID)if err != nil {return "", fmt.Errorf("runtime verification failed: %w", err)@@ -265,7 +263,6 @@ func (t *terminal) getExecResult(ctx context.Context, id string, timeout time.Dudefer cancel()}- // attach to the exec processresp, err := t.dockerClient.ContainerExecAttach(ctx, id, container.ExecAttachOptions{Tty: true,})diff --git a/backend/pkg/tools/tools.go b/backend/pkg/tools/tools.goindex fa2cd322..1d18c137 100644--- a/backend/pkg/tools/tools.go+++ b/backend/pkg/tools/tools.go@@ -657,7 +657,6 @@ func (fte *flowToolsExecutor) findMissingInContainer(ctx context.Context, entriereturn nil, fmt.Errorf("file-check exec failed with exit code %d: %s", inspect.ExitCode, strings.TrimSpace(string(output)))}- // Build a lookup map for O(1) access.byContainerPath := make(map[string]fileSyncEntry, len(entries))for _, e := range entries {byContainerPath[e.containerPath] = ediff --git a/docker-compose.yml b/docker-compose.ymlindex cb5f26ce..790d219e 100644--- a/docker-compose.yml+++ b/docker-compose.yml@@ -190,7 +190,7 @@ services:- ${PENTAGI_DOCKER_SOCKET:-/var/run/docker.sock}:/var/run/docker.sock- ${PENTAGI_LLM_SERVER_CONFIG_PATH:-./example.custom.provider.yml}:/opt/pentagi/conf/custom.provider.yml- ${PENTAGI_OLLAMA_SERVER_CONFIG_PATH:-./example.ollama.provider.yml}:/opt/pentagi/conf/ollama.provider.yml- - ${BEDROCK_CONFIG_PATH:-./example.bedrock.provider.yml}:/opt/pentagi/conf/bedrock.provider.yml+ - ${PENTAGI_BEDROCK_CONFIG_PATH:-./example.bedrock.provider.yml}:/opt/pentagi/conf/bedrock.provider.yml- ${PENTAGI_DOCKER_CERT_PATH:-./docker-ssl}:/opt/pentagi/docker/ssluser: root:root # while using docker.socknetworks:diff --git a/frontend/.gitignore b/frontend/.gitignoreindex 866f0df2..74607e0d 100644--- a/frontend/.gitignore+++ b/frontend/.gitignore@@ -25,6 +25,7 @@ ssl# Playwrighte2e/test-results/+test-results/e2e/playwright-report/e2e/blob-report/e2e/.auth/diff --git a/frontend/docs/e2e.md b/frontend/docs/e2e.mdindex 0fe088be..fc14a6a9 100644--- a/frontend/docs/e2e.md+++ b/frontend/docs/e2e.md@@ -100,8 +100,19 @@ Key conventions:types — schema or operation drift fails `pnpm typescript`, not the runtime.- **The clock is pinned** (UTC, fixed epoch) on the mock tier: keep cassettetimestamps on the `CASSETTE_EPOCH` day or date renders change under you.-- **Unmatched calls fail the test** — the mock tier is hermetic by design;- nothing ever leaks to a real backend.+- **Unmatched HTTP calls fail the test** — every GraphQL POST and REST call needs+ a cassette entry or teardown fails. An unmatched _subscription_ is legal (a flow+ page opens ~15 and a cassette mocks only the ones it cares about): it gets ack'd+ silence, so a typo'd subscription key surfaces as a UI timeout, with the missed+ operations in the `unmatched-subscriptions` report attachment. Either way nothing+ reaches a real backend: the WebSocket is routed too, and the HTTP route is re-armed+ on every page the context opens, so a popup (the report tabs) is mocked like the+ page that opened it — Playwright does not inherit a page's routes into its popups.+- **Downloads are the one hole in that.** The browser performs an `<a download>`+ transfer outside the page, so no route — page- or context-scoped — is ever offered+ it: it goes to the `vite preview` proxy and out to whatever `VITE_API_URL` names. A+ mock-tier spec must therefore never start one — assert the anchor's `href`/`download`+ (see `specs/crud/resources.spec.ts`) and leave the bytes to `specs/real/**`.- Assert errors via `pageerror`/`unhandledrejection` (`expectCleanPage`): theproduction bundle strips app console output, so console-based asserts aremeaningless on the mock tier.@@ -133,14 +144,15 @@ Two conventions the gate reserves:## Stand tier (Tier 3)Runs the LLM-independent `@stand` smoke against a real deployment. It lives in its-own workflow (`e2e-stand.yml`) so the PR gate never subscribes to `labeled`. Label a-PR `e2e:stand` (or dispatch the workflow with `tier: stand`); the job runs in a-protected `e2e-stand` Environment whose required reviewers approve before any secret-is exposed. That Environment gate — not the job's label condition — is what protects-the secrets, so even a mislabeled or fork-PR run blocks on a human before it can reach-them. The stand's URL and login come from the `E2E_STAND_URL` / `E2E_STAND_USER` /-`E2E_STAND_PASSWORD` secrets (exposed to the tools as `E2E_BASE_URL` / `E2E_USER` /-`E2E_PASSWORD`).+own workflow (`e2e-stand.yml`) so the PR gate never subscribes to `labeled`. Trigger+it by labelling a PR `e2e:stand`, or from **Actions → E2E Stand → Run workflow**+(`workflow_dispatch` takes no inputs). The job's `if` is the first gate: it runs only+for a `workflow_dispatch`, or a labelled PR whose head is **not** a fork — a+mislabeled or fork-PR run skips the job entirely and never reaches the secrets. For a+run that clears that gate, the protected `e2e-stand` Environment is the second gate:+its required reviewers approve before any secret is exposed. The stand's URL and login+come from the `E2E_STAND_URL` / `E2E_STAND_USER` / `E2E_STAND_PASSWORD` secrets+(exposed to the tools as `E2E_BASE_URL` / `E2E_USER` / `E2E_PASSWORD`).Before the browser specs, a **schema-compat pre-flight**(`e2e/tools/schema-compat.mjs`) introspects the stand's live GraphQL schema and@@ -163,6 +175,33 @@ prefix `NODE_TLS_REJECT_UNAUTHORIZED=0`; a real stand has a valid cert).substrate for scoping runs and the exploratory agent to the changed surface;the mapping logic is unit-tested (`e2e/affected-routes.unit.test.ts`).+## Reviewing with agents++Verifying a claim about a gate usually means breaking something on purpose — deleting a+guard, injecting the regression it should catch, patching a fixture. Do that in a sandbox,+never in your checkout:++```bash+SANDBOX=$(./e2e/tools/review-sandbox.sh create --dirty --with-deps)+# …mutate and run anything inside $SANDBOX…+./e2e/tools/review-sandbox.sh clean "$SANDBOX"+```++`--dirty` carries uncommitted work across (usually what you are reviewing); `--with-deps`+hardlinks `node_modules` so pnpm, vitest and playwright run there — skip it for read-only+work, it costs ~30s. `clean` takes a path under the sandbox root and refuses anything else,+including the root itself; `clean --all` sweeps sandboxes untouched for two hours, so it+cannot take out a concurrent agent's live one. A bare `clean` is an error, not a sweep.++The sandbox is a `git worktree` under `$TMPDIR`, so a deleted file or an edited spec inside+it cannot reach your tree. `--with-deps` needs the root to be on the repo's own filesystem —+hardlinks cannot cross mounts — so where `$TMPDIR` is its own mount (tmpfs `/tmp`, a separate+`/home`) the tool says so and falls back to `.pentagi-review-sandboxes` beside the repo;+`PENTAGI_SANDBOX_ROOT` overrides both. Two caveats: an absolute path still escapes it, and a tool that+rewrites a dependency **in place** would reach the shared inode — don't hand `--with-deps`+to an agent whose job is patching libraries. Check `git status` in your own tree when a run+finishes; that is the only proof nothing leaked.+## LLM advisory layer (Phase 3, opt-in)Deterministic specs are the gate; an LLM is only ever an advisory seconddiff --git a/frontend/docs/list_detail_pages.md b/frontend/docs/list_detail_pages.mdindex 6002e095..3fe58f47 100644--- a/frontend/docs/list_detail_pages.md+++ b/frontend/docs/list_detail_pages.md@@ -4,9 +4,12 @@ Reusable surface for **list-and-detail** pages: a filterable/sortable table, aPrev/Next/Sheet toolbar that walks the _same_ filtered subset on detail pages,inline-rename inputs, and the URL-vs-storage state model that keeps them inlockstep. Every list page in the app (`/flows`, `/knowledges`, `/templates`,-`/settings/prompts`, `/settings/providers`, `/settings/api-tokens`) is built-from these pieces, as is each one's detail page — `/settings/api-tokens` is the-exception, editing its rows in place with no detail route of its own.+`/settings/prompts`, `/settings/providers`, `/settings/api-tokens`) renders a+`<DataTable>`. The detail half applies to `/flows/:id`, `/knowledges/:id` and+`/templates/:id` only. `/settings/api-tokens` has no detail route at all (it edits+rows in place, through its own state rather than the inline-edit surface below),+and `/settings/prompts/:name` and `/settings/providers/:id` are single-entity+forms with no sibling navigation, so neither has a feature nav hook.> **Scope / how to trust this doc.** It describes code under `frontend/src`.> Signatures below are copied verbatim from source. If a signature and the code@@ -46,8 +49,9 @@ Two rules make the whole thing predictable:1. **URL is authoritative** for filter + page, so a shared link reproduces theexact view.-2. **Prev/Next walks the same subset** — the detail toolbar runs the same- matcher the list filter uses, so siblings stay in step with the table.+2. **Prev/Next walks the same subset** — the detail toolbar filters on the same+ `?q=` the table does, so siblings stay in step with the list. The two+ matchers are close but not identical; see the caveat below.## Mental model@@ -152,11 +156,17 @@ The current page index and the ad-hoc `?q=` filter stay URL-only.### Prev/Next walks the same subset`useDetailNavigation` subscribes to the URL filter via-`useTableQueryFilterReader`, runs the same pure matcher the list uses, and+`useTableQueryFilterReader`, applies a pure matcher over the same `?q=`, andresolves the Prev / Next siblings + a `"3/10"` position label over that filtered-subset — so the toolbar is always in step with what the user saw in the table.-It also threads the current `?q=` through every prev/next/select destination via-`mergeHrefWithSearchParams`, so navigating siblings never drops the filter.+subset. It also threads the current `?q=` through every prev/next/select+destination via `mergeHrefWithSearchParams`, so navigating siblings never drops+the filter.++The two matchers are not the same function, and they disagree on diacritics:+the toolbar folds them (`createTextMatcher` normalizes NFKD and strips combining+marks), while `DataTable`'s `globalFilterFn` only lowercases. Searching `cafe`+therefore hides a `café` row from the table while Prev/Next still steps onto it.+Align the two before relying on the subsets being identical.## Hooks@@ -343,7 +353,7 @@ function DetailNavigationToolbar<T extends { id: string }>(props: {renderItem?: (item: T, isCurrent: boolean) => ReactNode;hasSearch?: boolean; // default true — in-sheet search inputsearchPlaceholder?: string;-}): JSX.Element | null; // null when controller.itemsEmpty+}): JSX.Element;```The toolbar composes `<DetailNavigationButtons>` (Prev / position / Next) and@@ -466,8 +476,13 @@ export function EntitiesPage() {const pageHeader = <AppHeader title="Entities" /* ...actions */ />;- // Canonical 4-branch render gate — pageHeader renders in ALL branches:- if (isLoading) {+ // Canonical 4-branch render gate — pageHeader renders in ALL branches.+ // Both loading and error gate on "nothing to show yet": the query is+ // cache-and-network, so a background revalidation reports loading (and, on+ // failure, error) with cached data still present. Without `&& !data` that+ // refetch blanks a working list — or an edit form with unsaved changes —+ // with the spinner/error for the round-trip.+ if (isLoading && entities.length === 0) {return (<>{pageHeader}@@ -475,8 +490,6 @@ export function EntitiesPage() {</>);}- // Show the error surface only when there's no data — a failed background- // refetch must not blank a working list.if (error && entities.length === 0) {return (<>@@ -619,9 +632,10 @@ legacy keys in on first mount and deletes them.filter (`?q=`, via `useTableState`) and a server-side semantic search (`?qs=`,via page-local `useSearchParams`) are independent — don't conflate them. Acopied list recipe only needs the `?q=` one.-- **`DetailNavigationToolbar` renders `null` when `controller.itemsEmpty`** (raw- items empty, pre-filter), so it can mount before the provider's list arrives- without flashing "–/0".+- **`DetailNavigationToolbar` always renders.** It has no empty-list branch, so+ it mounts before the provider's list arrives and shows the buttons' own+ disabled/"–/0" state until items land. `controller.itemsEmpty` exists for a+ caller that wants to skip rendering it, but nothing reads it today.## Testing@@ -661,3 +675,5 @@ not reintroduce them:| `toolbarProps` spread into `<DetailNavigationToolbar>` | No such object. Pass `controller={nav}` + discrete `renderItem`/`sheetIcon`/`sheetTitle`. || `hooks/use-inline-edit` | Wrong path. It lives at `components/shared/inline-edit/use-inline-edit.ts`. || `components/shared/data-table` | Wrong path. It lives at `components/ui/data-table.tsx`. |+| `features/providers/use-provider-detail-navigation.ts` | Never existed. `/settings/providers/:id` is a form with no sibling nav — only `flows`, `knowledges` and `templates` have nav hooks. |+| `features/prompts/use-prompt-detail-navigation.ts` | Never existed. Same for `/settings/prompts/:name`. |diff --git a/frontend/e2e/affected-routes.ts b/frontend/e2e/affected-routes.tsindex 5e493bd0..14f53b9c 100644--- a/frontend/e2e/affected-routes.ts+++ b/frontend/e2e/affected-routes.ts@@ -7,15 +7,11 @@ const owns = (dir: string, file: string): boolean => file === dir || file.starts/*** Maps a set of changed repo files to the manifest routes they touch, by- * prefix-matching each change against a route's owning source dirs. This is the- * substrate for selective runs and for scoping the exploratory agent to the- * changed surface. Pure — the CLI and the vitest unit test both drive it.+ * prefix-matching each change against a route's owning source dirs.*- * - no frontend change → no routes (a backend-only diff; the caller falls back- * to the full suite, and schema-compat covers the backend contract);- * - a frontend change owned by no route → all routes (shared infra: the e2e- * engine, config, src/lib, a provider used everywhere) — conservative on- * purpose, since over-running is safe and under-running hides a regression;+ * - no frontend change → no routes (the caller falls back to the full suite);+ * - a frontend change owned by no route → all routes (shared infra: e2e engine,+ * config, src/lib, an everywhere-provider) — over-run rather than under-run;* - otherwise → the routes whose `sources` the changes fall under.** Paths are repo-relative (`frontend/...`); `sources` are `frontend/`-relative.diff --git a/frontend/e2e/affected-routes.unit.test.ts b/frontend/e2e/affected-routes.unit.test.tsindex 53e73d66..c8fbed50 100644--- a/frontend/e2e/affected-routes.unit.test.ts+++ b/frontend/e2e/affected-routes.unit.test.ts@@ -3,6 +3,7 @@ import { describe, expect, it } from 'vitest';import type { RouteSource } from './affected-routes.ts';import { affectedRoutes } from './affected-routes.ts';+import { ROUTE_MANIFEST } from './routes.ts';const MANIFEST: RouteSource[] = [{@@ -58,4 +59,12 @@ describe('affectedRoutes', () => {expect(result.map((route) => route.path)).toEqual(['/flows']);});++ // The fake manifest above cannot catch ownership drift in the real one: a shared provider claimed+ // by a single route silently scopes a run away from the other routes that mount its consumers.+ it('scopes a shared provider to every route that mounts a consumer', () => {+ const result = affectedRoutes(['frontend/src/providers/templates-provider.tsx'], ROUTE_MANIFEST);++ expect(result.map((route) => route.path).sort()).toEqual(['/flows/5', '/templates']);+ });});diff --git a/frontend/e2e/ci-codegen-gate.unit.test.ts b/frontend/e2e/ci-codegen-gate.unit.test.tsnew file mode 100644index 00000000..0895da98--- /dev/null+++ b/frontend/e2e/ci-codegen-gate.unit.test.ts@@ -0,0 +1,91 @@+import { execFileSync, spawnSync } from 'node:child_process';+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { afterAll, beforeAll, describe, expect, it } from 'vitest';++const SCRIPT = join(__dirname, '..', '..', '.github', 'scripts', 'codegen-inputs-changed.sh');++let repo = '';+const sha = { base: '', merge: '', schema: '', unrelated: '' };++// -c user.* is passed on every invocation (not just `commit`) because `commit-tree` also refuses+// to run without an author identity, and CI runners have none configured globally.+const git = (...args: string[]) =>+ execFileSync('git', ['-C', repo, '-c', '[email protected]', '-c', 'user.name=e2e', ...args], {+ encoding: 'utf8',+ }).trim();++const commit = (path: string, body: string, message: string) => {+ mkdirSync(join(repo, path.slice(0, path.lastIndexOf('/'))), { recursive: true });+ writeFileSync(join(repo, path), body);+ git('add', '-A');+ git('commit', '-m', message);++ return git('rev-parse', 'HEAD');+};++const run = (event: string, before: string, baseSha: string, headSha: string) =>+ execFileSync(SCRIPT, [event, before, baseSha, headSha], { cwd: repo, encoding: 'utf8' }).trim();++const runReason = (event: string, before: string, baseSha: string, headSha: string) =>+ spawnSync(SCRIPT, [event, before, baseSha, headSha], { cwd: repo, encoding: 'utf8' }).stderr.trim();++// The PR arrives as the merge commit GitHub builds, not as the branch head — the range the gate+// picks has to span the whole PR, not the newest push.+beforeAll(() => {+ repo = mkdtempSync(join(tmpdir(), 'codegen-gate-'));+ git('init', '-q', '-b', 'main');+ sha.base = commit('README.md', 'base\n', 'base');+ sha.schema = commit('backend/pkg/graph/schema.graphqls', 'type Query { a: Int }\n', 'edit the schema');+ sha.unrelated = commit('README.md', 'base\nmore\n', 'unrelated follow-up');+ sha.merge = git('commit-tree', `${sha.unrelated}^{tree}`, '-p', sha.base, '-p', sha.unrelated, '-m', 'merge');+});++afterAll(() => rmSync(repo, { force: true, recursive: true }));++describe('codegen freshness gate — range selection', () => {+ it('checks a follow-up push whose newest commit did not touch a codegen input', () => {+ expect(run('pull_request', sha.schema, sha.base, sha.merge)).toBe('changed=true');+ });++ it('checks a freshly opened PR, where there is no previous head', () => {+ expect(run('pull_request', '', sha.base, sha.merge)).toBe('changed=true');+ });++ // The answer alone cannot tell this branch from the diff-failed fallback below, which prints+ // the same `changed=true`; only the reason distinguishes them.+ it('checks a force-push, where the previous head no longer resolves', () => {+ expect(run('push', 'b'.repeat(40), '', sha.schema)).toBe('changed=true');+ expect(runReason('push', 'b'.repeat(40), '', sha.schema)).toContain('reason=unresolvable-base');+ });++ it('checks the first push of a branch, where there is no previous head at all', () => {+ expect(run('push', '0'.repeat(40), '', sha.schema)).toBe('changed=true');+ expect(runReason('push', '0'.repeat(40), '', sha.schema)).toContain('reason=unresolvable-base');+ });++ it('keeps checking a push by its own range', () => {+ expect(run('push', sha.base, '', sha.schema)).toBe('changed=true');+ });++ it('still skips a PR that touches no codegen input', () => {+ expect(run('pull_request', '', sha.schema, sha.unrelated)).toBe('changed=false');+ });++ it('checks a codegen input whose diff is larger than one pipe buffer', () => {+ const pad = 'x'.repeat(180);+ mkdirSync(join(repo, 'frontend', 'filler'), { recursive: true });++ for (let i = 0; i < 1000; i += 1) {+ writeFileSync(join(repo, 'frontend', 'filler', `${i}-${pad}.txt`), '');+ }++ const bulk = commit('backend/pkg/graph/schema.graphqls', 'type Query { a: Int, b: Int }\n', 'bulk');+ const names = git('diff', '--name-only', sha.unrelated, bulk);++ expect(names.split('\n')[0]).toBe('backend/pkg/graph/schema.graphqls');+ expect(names.length).toBeGreaterThan(64 * 1024);+ expect(run('push', sha.unrelated, '', bulk)).toBe('changed=true');+ });+});diff --git a/frontend/e2e/fixtures/auth.ts b/frontend/e2e/fixtures/auth.tsindex ae74c3c9..bcb3de22 100644--- a/frontend/e2e/fixtures/auth.ts+++ b/frontend/e2e/fixtures/auth.ts@@ -147,9 +147,16 @@ export const guestInfoEntry = (): RestCassetteEntry => ({export const seedAuthenticated = async (page: Page): Promise<void> => {await page.addInitScript(- ([key, value]) => {+ ([key, value, sentinel]) => {+ // Init scripts run on every document, so an unguarded seed would resurrect the session+ // the app just cleared and no logout/expiry spec could observe the signed-out state.+ if (window.sessionStorage.getItem(String(sentinel))) {+ return;+ }++ window.sessionStorage.setItem(String(sentinel), '1');window.localStorage.setItem(String(key), String(value));},- [AUTH_STORAGE_KEY, JSON.stringify(seededAuthInfo())] as const,+ [AUTH_STORAGE_KEY, JSON.stringify(seededAuthInfo()), 'e2e-auth-seeded'] as const,);};diff --git a/frontend/e2e/fixtures/backend.ts b/frontend/e2e/fixtures/backend.tsindex e433c148..ed9f6c6e 100644--- a/frontend/e2e/fixtures/backend.ts+++ b/frontend/e2e/fixtures/backend.ts@@ -33,7 +33,7 @@ export const test = base.extend<BackendFixtures & BackendOptions & { _installMoc// first 401 wipes it and hard-redirects to login. Real tiers authenticate// once in the setup project and reuse storageState._installMocks: [- async ({ backend, isAuthSeeded, page, world }, use, testInfo) => {+ async ({ backend, context, isAuthSeeded, page, world }, use, testInfo) => {if (!backend.installMocks) {await use();@@ -46,7 +46,7 @@ export const test = base.extend<BackendFixtures & BackendOptions & { _installMocawait seedAuthenticated(page);}- await installMockRoutes(page, world);+ await installMockRoutes(context, world);await use();// Silently-dead subscriptions are legal (cassettes mock only thediff --git a/frontend/e2e/fixtures/test.ts b/frontend/e2e/fixtures/test.tsindex 69ec656b..c6b3be16 100644--- a/frontend/e2e/fixtures/test.ts+++ b/frontend/e2e/fixtures/test.ts@@ -1,4 +1,4 @@-import { test as base, mergeTests } from '@playwright/test';+import { test as base, expect as baseExpect, mergeTests } from '@playwright/test';import type { PageErrorLog } from '../helpers/errors.ts';@@ -6,9 +6,18 @@ import { watchPageErrors } from '../helpers/errors.ts';import { test as backendTest } from './backend.ts';const errorsTest = base.extend<{ pageErrorLog: PageErrorLog }>({- pageErrorLog: async ({ page }, use) => {- await use(watchPageErrors(page));- },+ pageErrorLog: [+ async ({ page }, use) => {+ const log = watchPageErrors(page);++ await use(log);++ // Auto (not opt-in): a spec that never destructured this fixture would assert nothing.+ // Console errors stay with `expectCleanPage` — several specs drive 4xx paths that log one.+ baseExpect(log.pageErrors, 'no uncaught page errors').toEqual([]);+ },+ { auto: true },+ ],});export const test = mergeTests(backendTest, errorsTest);diff --git a/frontend/e2e/helpers/a11y.ts b/frontend/e2e/helpers/a11y.tsindex 433d48f6..688c5336 100644--- a/frontend/e2e/helpers/a11y.ts+++ b/frontend/e2e/helpers/a11y.ts@@ -12,9 +12,18 @@ import { expect } from '@playwright/test';*/export interface A11yWaiver {rule: string;+ /**+ * Flow-detail tab names whose panel owns this debt. Omitted = route-wide (applies to the base+ * view and every tab). Scoped so a Files-tab waiver cannot silence the same rule on Assistant.+ */+ tabs?: string[];target: RegExp;}+/** Waivers in force for one scan: route-wide ones always, tab-scoped ones only on their own tab. */+export const waiversForScan = (waivers: A11yWaiver[] = [], tab?: string): A11yWaiver[] =>+ waivers.filter((waiver) => !waiver.tabs || (tab !== undefined && waiver.tabs.includes(tab)));+const BLOCKING_IMPACTS = new Set(['critical', 'serious']);export const scanA11y = async (page: Page, route: string, waivers: A11yWaiver[] = []): Promise<void> => {diff --git a/frontend/e2e/helpers/contrast.ts b/frontend/e2e/helpers/contrast.tsindex a8e361d4..2716ee8d 100644--- a/frontend/e2e/helpers/contrast.ts+++ b/frontend/e2e/helpers/contrast.ts@@ -82,68 +82,188 @@ export const mountEditorProbes = async (page: Page, probes: Record<string, Edito);};-export const measureContrast = async (page: Page, probe: string): Promise<number> =>- page.evaluate((name) => {- const element = document.querySelector<HTMLElement>(`[data-contrast="${name}"]`);+export const parseColorAlpha = (color: string): number => {+ const value = color.trim().toLowerCase();- if (!element?.parentElement) {- throw new Error(`contrast probe "${name}" is not mounted`);+ if (value === 'transparent') {+ return 0;+ }++ if (value.startsWith('#')) {+ const digits = value.slice(1);+ const hex = digits.length === 4 ? digits.slice(3).repeat(2) : digits.length === 8 ? digits.slice(6) : '';++ return hex ? parseInt(hex, 16) / 255 : 1;+ }++ const args = /^[a-z-]+\(([^)]*)\)$/.exec(value)?.[1];++ if (args === undefined) {+ return 1;+ }++ const raw = (args.includes('/') ? args.split('/').at(-1) : args.split(',').at(3))?.trim();++ if (raw === undefined) {+ return 1;+ }++ const alpha = raw.endsWith('%') ? Number(raw.slice(0, -1)) / 100 : Number(raw);++ return Number.isFinite(alpha) ? Math.min(Math.max(alpha, 0), 1) : 1;+};++// Walk to the first opaque ancestor, not just the parent: a probe inside a code block sits on+// `pre.hljs` through a transparent `code`, and stopping at the parent would measure it against+// nothing. The stack is painted onto a cleared canvas, so a translucent layer with no opaque base+// under it keeps its own colour and reads as a contrast it does not have.+export const resolveGroundLayers = (ancestorBackgrounds: string[]): string[] => {+ const stack: string[] = [];++ for (const background of ancestorBackgrounds) {+ const alpha = parseColorAlpha(background);++ if (alpha === 0) {+ continue;}- const canvas = document.createElement('canvas');+ stack.unshift(background);++ if (alpha === 1) {+ break;+ }+ }- canvas.width = 1;- canvas.height = 1;+ return stack;+};- const context = canvas.getContext('2d', { willReadFrequently: true });+export const mountFenceProbes = async (page: Page, tokens: string[]): Promise<void> => {+ await page.evaluate(+ ({ classNames, hostId }) => {+ const fence = document.querySelector('.tiptap-content .ProseMirror pre');+ const code = fence?.querySelector('code');++ if (!fence || !code) {+ throw new Error('no code fence mounted to probe');+ }++ document.getElementById(hostId)?.remove();+ const host = document.createElement('div');++ host.id = hostId;+ host.className = 'tiptap-content';+ host.style.cssText = 'position:fixed;inset:0 auto auto 0;z-index:2147483647';++ const surface = document.createElement('div');++ surface.className = 'ProseMirror';++ const pre = fence.cloneNode(false) as HTMLElement;+ const holder = code.cloneNode(false) as HTMLElement;++ for (const className of classNames) {+ const probe = document.createElement('span');- if (!context) {- throw new Error('2d canvas context unavailable');+ probe.className = className;+ probe.dataset.contrast = className;+ probe.textContent = 'Sample';+ holder.append(probe);+ }++ pre.append(holder);+ surface.append(pre);+ host.append(surface);+ document.body.append(host);++ const cloned = getComputedStyle(pre).backgroundColor;+ const real = getComputedStyle(fence).backgroundColor;++ if (cloned !== real) {+ throw new Error(`fence clone sits on ${cloned}, the editor's fence on ${real}`);+ }+ },+ { classNames: tokens, hostId: 'contrast-fence-probes' },+ );+};++export const measureContrast = async (page: Page, probe: string): Promise<number> =>+ measureContrastAt(page, `[data-contrast="${probe}"]`);++export const measureContrastAt = async (page: Page, selector: string): Promise<number> => {+ const { ancestors, backgroundColor, color } = await page.evaluate((target) => {+ const element = document.querySelector<HTMLElement>(target);++ if (!element?.parentElement) {+ throw new Error(`contrast target "${target}" is not mounted`);}- const paint = (...layers: string[]) => {- context.clearRect(0, 0, 1, 1);+ const chain: string[] = [];++ for (let node: HTMLElement | null = element.parentElement; node; node = node.parentElement) {+ chain.push(getComputedStyle(node).backgroundColor);+ }- for (const layer of layers) {- // An unparseable colour is a silent no-op on fillStyle, leaving the previous- // value — which measures as a spurious ~21:1 pass. Assign it against two- // different sentinels: a colour that applied lands on the same value both- // times, an invalid one keeps whichever sentinel preceded it.- context.fillStyle = '#000000';- context.fillStyle = layer;- const fromBlack = context.fillStyle;+ const own = getComputedStyle(element);- context.fillStyle = '#ffffff';- context.fillStyle = layer;+ return { ancestors: chain, backgroundColor: own.backgroundColor, color: own.color };+ }, selector);- if (context.fillStyle !== fromBlack) {- throw new Error(`contrast: colour "${layer}" did not apply`);- }+ return page.evaluate(+ ({ ground, text }) => {+ const canvas = document.createElement('canvas');- context.fillRect(0, 0, 1, 1);+ canvas.width = 1;+ canvas.height = 1;++ const context = canvas.getContext('2d', { willReadFrequently: true });++ if (!context) {+ throw new Error('2d canvas context unavailable');}- const [r = 0, g = 0, b = 0] = context.getImageData(0, 0, 1, 1).data;+ const paint = (...layers: string[]) => {+ context.clearRect(0, 0, 1, 1);++ for (const layer of layers) {+ // An unparseable colour is a silent no-op on fillStyle, leaving the previous+ // value — which measures as a spurious ~21:1 pass. Assign it against two+ // different sentinels: a colour that applied lands on the same value both+ // times, an invalid one keeps whichever sentinel preceded it.+ context.fillStyle = '#000000';+ context.fillStyle = layer;+ const fromBlack = context.fillStyle;++ context.fillStyle = '#ffffff';+ context.fillStyle = layer;- return { b, g, r };- };+ if (context.fillStyle !== fromBlack) {+ throw new Error(`contrast: colour "${layer}" did not apply`);+ }- const luminance = ({ b, g, r }: { b: number; g: number; r: number }) => {- const channel = (value: number) => {- const ratio = value / 255;+ context.fillRect(0, 0, 1, 1);+ }++ const [r = 0, g = 0, b = 0] = context.getImageData(0, 0, 1, 1).data;- return ratio <= 0.03928 ? ratio / 12.92 : ((ratio + 0.055) / 1.055) ** 2.4;+ return { b, g, r };};- return 0.2126 * channel(r) + 0.7152 * channel(g) + 0.0722 * channel(b);- };+ const luminance = ({ b, g, r }: { b: number; g: number; r: number }) => {+ const channel = (value: number) => {+ const ratio = value / 255;++ return ratio <= 0.03928 ? ratio / 12.92 : ((ratio + 0.055) / 1.055) ** 2.4;+ };++ return 0.2126 * channel(r) + 0.7152 * channel(g) + 0.0722 * channel(b);+ };- const surface = paint(- getComputedStyle(element.parentElement).backgroundColor,- getComputedStyle(element).backgroundColor,- );- const label = paint(getComputedStyle(element).color);- const [high = 0, low = 0] = [luminance(label), luminance(surface)].sort((a, b) => b - a);+ const surface = paint(...ground);+ const label = paint(...ground, text);+ const [high = 0, low = 0] = [luminance(label), luminance(surface)].sort((a, b) => b - a);- return (high + 0.05) / (low + 0.05);- }, probe);+ return (high + 0.05) / (low + 0.05);+ },+ { ground: [...resolveGroundLayers(ancestors), backgroundColor], text: color },+ );+};diff --git a/frontend/e2e/helpers/contrast.unit.test.ts b/frontend/e2e/helpers/contrast.unit.test.tsnew file mode 100644index 00000000..f55ce9b0--- /dev/null+++ b/frontend/e2e/helpers/contrast.unit.test.ts@@ -0,0 +1,57 @@+import { describe, expect, it } from 'vitest';++import { parseColorAlpha, resolveGroundLayers } from './contrast.ts';++// Every colour below is a verbatim `getComputedStyle(...).backgroundColor` reading from the+// Chromium the e2e suite drives: Chrome leaves oklch/lab/color() in their own function.+describe('parseColorAlpha', () => {+ it('reads the alpha of the colour functions Chrome keeps unconverted', () => {+ expect(parseColorAlpha('oklch(0.7 0.1 250 / 0.3)')).toBeCloseTo(0.3);+ expect(parseColorAlpha('oklch(0.7 0.1 250)')).toBe(1);+ expect(parseColorAlpha('oklch(0.216 0.006 56.043 / 0.3)')).toBeCloseTo(0.3);+ expect(parseColorAlpha('color(srgb 1 0 0 / 0.4)')).toBeCloseTo(0.4);+ expect(parseColorAlpha('color(srgb 1 0 0)')).toBe(1);+ expect(parseColorAlpha('lab(50 40 59.5 / 0.5)')).toBeCloseTo(0.5);+ });++ it('reads the alpha of the legacy sRGB forms', () => {+ expect(parseColorAlpha('rgba(255, 0, 0, 0.5)')).toBeCloseTo(0.5);+ expect(parseColorAlpha('rgba(64, 149, 191, 0.25)')).toBeCloseTo(0.25);+ expect(parseColorAlpha('rgba(0, 0, 0, 0)')).toBe(0);+ expect(parseColorAlpha('transparent')).toBe(0);+ });++ it('treats an opaque rgb() as opaque instead of reading its blue channel as the alpha', () => {+ expect(parseColorAlpha('rgb(255, 0, 0)')).toBe(1);+ expect(parseColorAlpha('rgb(24, 24, 27)')).toBe(1);+ expect(parseColorAlpha('rgb(0, 0, 0)')).toBe(1);+ });++ it('reads alpha out of hex and percentage forms', () => {+ expect(parseColorAlpha('#ff0000')).toBe(1);+ expect(parseColorAlpha('#ff000080')).toBeCloseTo(0.5, 2);+ expect(parseColorAlpha('#f008')).toBeCloseTo(0.53, 2);+ expect(parseColorAlpha('rgb(255 0 0 / 30%)')).toBeCloseTo(0.3);+ });+});++describe('resolveGroundLayers', () => {+ it('stops on an opaque rgb() ancestor instead of skipping it as invisible', () => {+ expect(resolveGroundLayers(['rgba(0, 0, 0, 0)', 'rgb(255, 0, 0)', 'rgb(0, 0, 255)'])).toEqual([+ 'rgb(255, 0, 0)',+ ]);+ });++ it('keeps walking under a translucent oklch ancestor instead of grounding on it', () => {+ expect(resolveGroundLayers(['oklch(0.7 0.1 250 / 0.3)', 'oklch(0.985 0 0)', 'oklch(0.145 0 0)'])).toEqual([+ 'oklch(0.985 0 0)',+ 'oklch(0.7 0.1 250 / 0.3)',+ ]);+ });++ it('skips a fully transparent ancestor and keeps the layers outermost first', () => {+ expect(+ resolveGroundLayers(['rgba(0, 0, 0, 0)', 'color(srgb 1 0 0 / 0.4)', 'rgba(0, 0, 0, 0)', '#101014']),+ ).toEqual(['#101014', 'color(srgb 1 0 0 / 0.4)']);+ });+});diff --git a/frontend/e2e/helpers/pdf.ts b/frontend/e2e/helpers/pdf.tsnew file mode 100644index 00000000..a1560df4--- /dev/null+++ b/frontend/e2e/helpers/pdf.ts@@ -0,0 +1,68 @@+import { inflateSync } from 'node:zlib';++export interface PdfShape {+ /** Embedded font subsets — a document that drew no text embeds none. */+ fonts: number;+ isPdf: boolean;+ pages: number;+ /** Text-showing operators across every content stream. */+ textRuns: number;+ trailerComplete: boolean;+}++const inflateStreams = (pdf: Buffer): Buffer[] => {+ const streams: Buffer[] = [];+ const marker = Buffer.from('stream');+ const end = Buffer.from('endstream');++ let from = 0;++ for (;;) {+ const start = pdf.indexOf(marker, from);++ if (start === -1) {+ return streams;+ }++ const stop = pdf.indexOf(end, start);++ if (stop === -1) {+ return streams;+ }++ // Skip the EOL that must follow the `stream` keyword.+ const body = pdf.subarray(start + marker.length, stop);++ try {+ streams.push(inflateSync(body.subarray(body[0] === 0x0d ? 2 : 1)));+ } catch {+ // Not every stream is Flate-encoded (font programs, images) — those are not text.+ }++ from = stop + end.length;+ }+};++/**+ * Structural read of a generated PDF. It deliberately does not decode the text: each font subset+ * carries its own glyph map, so a merged decode garbles the result. The report's wording is checked+ * on the markdown export instead, which is built from the same string and whose bytes are searched+ * for the task and result text.+ */+export const inspectPdf = (pdf: Buffer): PdfShape => {+ const head = pdf.subarray(0, 5).toString();+ const tail = pdf.subarray(-1024).toString();+ const body = pdf.toString('latin1');+ const streams = inflateStreams(pdf);++ return {+ fonts: (body.match(/\/FontFile\d?/g) ?? []).length,+ isPdf: head === '%PDF-',+ pages: (body.match(/\/Type\s*\/Page[^s]/g) ?? []).length,+ textRuns: streams.reduce(+ (total, stream) => total + (stream.toString('latin1').match(/\bTJ\b|\bTj\b/g) ?? []).length,+ 0,+ ),+ trailerComplete: tail.includes('%%EOF'),+ };+};diff --git a/frontend/e2e/helpers/subscriptions.ts b/frontend/e2e/helpers/subscriptions.tsindex 955fcf7d..3a7a8cf6 100644--- a/frontend/e2e/helpers/subscriptions.ts+++ b/frontend/e2e/helpers/subscriptions.ts@@ -2,7 +2,9 @@ import type { Locator, TestInfo } from '@playwright/test';import { expect } from '@playwright/test';-export const MESSAGE_ID_TESTID = 'flow-message-id';+/** The message-id badge carries no accessible name, so it is addressed by its slot like every other+ * shadcn primitive in this codebase — `data-testid` is not used in product code. */+export const MESSAGE_ID_SELECTOR = '[data-slot="flow-message-id"]';export const attachIdSet = async (testInfo: TestInfo, name: string, ids: string[]): Promise<void> => {await testInfo.attach(name, {@@ -12,7 +14,7 @@ export const attachIdSet = async (testInfo: TestInfo, name: string, ids: string[};export const extractMessageIds = async (panel: Locator): Promise<string[]> => {- const raw = await panel.getByTestId(MESSAGE_ID_TESTID).allTextContents();+ const raw = await panel.locator(MESSAGE_ID_SELECTOR).allTextContents();return raw.map((text) => text.replace(/\D/g, '')).filter(Boolean);};diff --git a/frontend/e2e/mock-llm/scenario.mjs b/frontend/e2e/mock-llm/scenario.mjsindex c38dbdc4..f845d0de 100644--- a/frontend/e2e/mock-llm/scenario.mjs+++ b/frontend/e2e/mock-llm/scenario.mjs@@ -35,8 +35,6 @@ export const RULES = [match: /get_number/,toolCalls: [{ args: { value: 1 }, name: 'get_number' }],},- // The task reporter summarizes the finished task and only accepts the- // report_result tool.{label: 'task-report',match: /report_result|TASK EXECUTION EVALUATOR AND REPORTER/,@@ -51,8 +49,7 @@ export const RULES = [},],},- // The refiner re-plans between subtasks and only accepts subtask_patch;- // an empty operations list means "plan unchanged".+ // An empty operations list means "plan unchanged".{label: 'subtask-refine',match: /subtask_patch/,@@ -81,7 +78,7 @@ export const RULES = [// matching that agent's turn.{label: 'subagent-terminal-report',- match: /(?=[\s\S]*"hack_result")(?=[\s\S]*E2E_TERMINAL_OK)/,+ match: /^(?=[\s\S]*"hack_result")(?=[\s\S]*E2E_TERMINAL_OK)/,toolCalls: [{args: {diff --git a/frontend/e2e/mock-llm/server.mjs b/frontend/e2e/mock-llm/server.mjsindex a02f90f3..a8354ada 100644--- a/frontend/e2e/mock-llm/server.mjs+++ b/frontend/e2e/mock-llm/server.mjs@@ -137,7 +137,10 @@ createServer(async (request, response) => {}const rule = pickAnswer(payload);- const toolNames = (payload.tools ?? []).map((tool) => tool.function?.name ?? tool.type).join(',');+ // Defensive end to end because this runs outside the try/catch above, where a throw kills+ // the process: the top-level guard admits {"tools":5} and {"tools":[null]} alike.+ const toolList = Array.isArray(payload.tools) ? payload.tools : [];+ const toolNames = toolList.map((tool) => tool?.function?.name ?? tool?.type ?? '?').join(',');console.log(`[mock-llm] ${rule.label}: ${payload.stream ? 'stream' : 'plain'} tools=[${toolNames}]`);respondCompletion(response, payload, rule);diff --git a/frontend/e2e/mocks/cassette.ts b/frontend/e2e/mocks/cassette.tsindex 94577f60..8415051f 100644--- a/frontend/e2e/mocks/cassette.ts+++ b/frontend/e2e/mocks/cassette.ts@@ -28,6 +28,14 @@ export const mergeCassettes = (base: Cassette, override: Cassette): Cassette =>});export interface GraphQLCassetteEntry extends GraphQLPayload, WorldFlagged {+ /**+ * Served verbatim in place of the `{ data, errors }` envelope. The GraphQL endpoint sits behind+ * the same auth middleware as the REST ones, so a rejected request answers with the REST error+ * body and never reaches gqlgen.+ */+ body?: unknown;+ /** A transport-level status the client reads instead of the GraphQL `errors` array. */+ status?: number;variables?: Record<string, unknown>;}@@ -51,6 +59,13 @@ export interface RestCassetteEntry extends WorldFlagged {* a broken image while the request still counts as matched.*/contentType?: string;+ /**+ * Subset match against the request's query string, the counterpart to `bodySubset` for+ * endpoints that carry their payload there and send no body — a delete addressed by+ * `?paths[]=…` is otherwise answered success whatever it names. Repeated keys are compared+ * as the full list of values.+ */+ querySubset?: Record<string, string | string[]>;status?: number;}diff --git a/frontend/e2e/mocks/cassettes/assistants.ts b/frontend/e2e/mocks/cassettes/assistants.tsnew file mode 100644index 00000000..2f09258d--- /dev/null+++ b/frontend/e2e/mocks/cassettes/assistants.ts@@ -0,0 +1,72 @@+import type { ResultOf } from '@graphql-typed-document-node/core';++import type { AssistantFragmentFragment, AssistantLogFragmentFragment, AssistantsDocument } from '@/graphql/types';++import { MessageLogType, ResultFormat, StatusType } from '@/graphql/types';++import type { Cassette } from '../cassette.ts';++import { entity, mergeCassettes } from '../cassette.ts';+import { flowsCassette, PROVIDER } from './flows.ts';++const T = '2026-01-15T11:30:00Z';++export const makeAssistant = (+ id: string,+ title: string,+ status: StatusType = StatusType.Waiting,+): AssistantFragmentFragment =>+ entity('Assistant', {+ createdAt: T,+ flowId: '5',+ id,+ provider: PROVIDER,+ status,+ title,+ updatedAt: T,+ useAgents: false,+ });++export const WAITING_ASSISTANT = makeAssistant('11', 'E2E Assistant Waiting');+export const RUNNING_ASSISTANT = makeAssistant('12', 'E2E Assistant Running', StatusType.Running);+export const CREATED_ASSISTANT = makeAssistant('13', 'E2E Assistant Created');++export const ASSISTANT_ANSWER = 'The scan found an open port on 8080.';++const assistantLog = (id: string, assistantId: string, message: string): AssistantLogFragmentFragment =>+ entity('AssistantLog', {+ appendPart: false,+ assistantId,+ createdAt: T,+ flowId: '5',+ id,+ message,+ result: ASSISTANT_ANSWER,+ resultFormat: ResultFormat.Markdown,+ thinking: null,+ type: MessageLogType.Answer,+ });++const seeded: ResultOf<typeof AssistantsDocument> = { assistants: [WAITING_ASSISTANT, RUNNING_ASSISTANT] };++export const assistantsCassette = (override: Cassette = {}): Cassette =>+ mergeCassettes(+ flowsCassette({+ queries: {+ assistantLogs: [+ {+ data: { assistantLogs: [assistantLog('41', '11', 'what did the scan find?')] },+ variables: { assistantId: '11', flowId: '5' },+ },+ {+ data: { assistantLogs: [assistantLog('42', '12', 'keep going')] },+ variables: { assistantId: '12', flowId: '5' },+ },+ { data: { assistantLogs: [] }, variables: { assistantId: '13', flowId: '5' } },+ ],+ assistants: [{ data: seeded, variables: { flowId: '5' } }],+ providers: [{ data: { providers: [PROVIDER] } }],+ },+ }),+ override,+ );diff --git a/frontend/e2e/mocks/cassettes/assistants.unit.test.ts b/frontend/e2e/mocks/cassettes/assistants.unit.test.tsnew file mode 100644index 00000000..0a33e04d--- /dev/null+++ b/frontend/e2e/mocks/cassettes/assistants.unit.test.ts@@ -0,0 +1,28 @@+import { describe, expect, it } from 'vitest';++import { MockWorld } from '../world.ts';+import { assistantsCassette, CREATED_ASSISTANT, RUNNING_ASSISTANT, WAITING_ASSISTANT } from './assistants.ts';++const transcript = (world: MockWorld, assistantId: string): undefined | unknown[] =>+ (+ world.matchGraphQL('assistantLogs', { assistantId, flowId: '5' })?.data as+ | undefined+ | { assistantLogs: unknown[] }+ )?.assistantLogs;++describe('assistants cassette — assistantLogs', () => {+ it('serves an assistant its own transcript on every read, not only the first', () => {+ const world = new MockWorld(assistantsCassette());++ expect(transcript(world, WAITING_ASSISTANT.id)).toHaveLength(1);+ expect(transcript(world, WAITING_ASSISTANT.id)).toHaveLength(1);+ expect(transcript(world, RUNNING_ASSISTANT.id)).toHaveLength(1);+ expect(transcript(world, RUNNING_ASSISTANT.id)).toHaveLength(1);+ });++ it('answers the freshly created assistant with an empty transcript', () => {+ const world = new MockWorld(assistantsCassette());++ expect(transcript(world, CREATED_ASSISTANT.id)).toEqual([]);+ });+});diff --git a/frontend/e2e/mocks/cassettes/base.ts b/frontend/e2e/mocks/cassettes/base.tsindex f7a26753..b6c2238b 100644--- a/frontend/e2e/mocks/cassettes/base.ts+++ b/frontend/e2e/mocks/cassettes/base.ts@@ -18,9 +18,8 @@ const flows: ResultOf<typeof FlowsDocument> = { flows: [] };const flowTemplates: ResultOf<typeof FlowTemplatesDocument> = { flowTemplates: [] };-// Live entry, not dead weight: after a websocket reconnect the app re-requests-// resources on the wire with {recursive:true} (removing this red-lights the-// reconnect spec on the 501 gate).+// After a websocket reconnect the app re-requests resources on the wire with {recursive:true};+// removing this entry red-lights the reconnect spec on the 501 gate.const resources: ResultOf<typeof ResourcesDocument> = { resources: [] };const providers: ResultOf<typeof ProvidersDocument> = { providers: [] };diff --git a/frontend/e2e/mocks/cassettes/flows.ts b/frontend/e2e/mocks/cassettes/flows.tsindex 6ab4e314..0c697d27 100644--- a/frontend/e2e/mocks/cassettes/flows.ts+++ b/frontend/e2e/mocks/cassettes/flows.ts@@ -5,6 +5,7 @@ import type {FlowDocument,FlowFilesDocument,FlowFragmentFragment,+ FlowReportDocument,FlowStatsByFlowDocument,MessageLogFragmentFragment,TerminalLogFragmentFragment,@@ -85,11 +86,13 @@ export const VARIED_MESSAGES = [resultFormat: ResultFormat.Markdown,type: MessageLogType.Report,}),+ // Terminal, not Report: `getMessageType` pairs the terminal tool's output with the terminal+ // type, so a Report carrying a Terminal body is a state the backend cannot emit.makeMessage('503', '5', {message: '',result: 'e2e-terminal-marker\nexit 0',resultFormat: ResultFormat.Terminal,- type: MessageLogType.Report,+ type: MessageLogType.Terminal,}),makeMessage('504', '5', { message: 'run the smoke command', type: MessageLogType.Input }),];@@ -179,8 +182,8 @@ export const flowsCassette = (override: Cassette = {}): Cassette =>{frames: [...FLOW_A_STREAMED_IDS.map((id) => addedFrame(makeMessage(id, '5'), 80)),- // Not a copy-paste: a resubscribe replays what the refetch already- // delivered, and the sentinel after it proves the replay was received.+ // A resubscribe replays what the refetch already delivered; the sentinel+ // after it proves the replay was received.{...addedFrame(makeMessage(FLOW_A_RECONNECT_ID, '5'), 0),whenFlag: REPLAY_FLAG,@@ -199,12 +202,38 @@ export const flowsCassette = (override: Cassette = {}): Cassette =>override,);-export const variedMessagesCassette = (): Cassette =>+export const FLOW_B_SENTINEL_ID = '205';+export const PAGER_SWITCH_FLAG = 'pager-switched';++/** Holds flow B a frame back so the spec can prove the new stream still delivers after the switch. */+export const pagerStreamsCassette = (): Cassette =>flowsCassette({- queries: { flow: [{ data: flowQueryData(FLOW_A, VARIED_MESSAGES), variables: { id: '5' } }] },- subscriptions: { messageLogAdded: [{ frames: [], variables: { flowId: '5' } }] },+ subscriptions: {+ messageLogAdded: [+ {+ frames: FLOW_A_STREAMED_IDS.map((id) => addedFrame(makeMessage(id, '5'), 80)),+ variables: { flowId: '5' },+ },+ {+ frames: [+ ...FLOW_B_STREAMED_IDS.map((id) => addedFrame(makeMessage(id, '6'), 80)),+ { ...addedFrame(makeMessage(FLOW_B_SENTINEL_ID, '6'), 0), whenFlag: PAGER_SWITCH_FLAG },+ ],+ variables: { flowId: '6' },+ },+ ],+ },});+export const variedMessagesCassette = (override: Cassette = {}): Cassette =>+ mergeCassettes(+ flowsCassette({+ queries: { flow: [{ data: flowQueryData(FLOW_A, VARIED_MESSAGES), variables: { id: '5' } }] },+ subscriptions: { messageLogAdded: [{ frames: [], variables: { flowId: '5' } }] },+ }),+ override,+ );+const TABS_TASK = entity('Task', {createdAt: T,flowId: '5',@@ -371,6 +400,139 @@ const flowStatsByFlow: ResultOf<typeof FlowStatsByFlowDocument> = {flowStatsByFlow: entity('FlowStats', { totalAssistantsCount: 1, totalSubtasksCount: 3, totalTasksCount: 1 }),};+/** Text that exists only in a streamed frame, so a panel that ignores its subscription stays blank. */+export const STREAMED = {+ agent: 'E2E streamed agent step',+ search: 'E2E streamed search',+ task: 'E2E Streamed Task',+ taskRetitled: 'E2E Task Alpha (revised)',+ terminal: 'e2e-streamed-terminal-line',+ vector: 'E2E streamed recall',+};++const streamedFrame = (payload: Record<string, unknown>) => ({ delayMs: 60, payload: { data: payload } });++export const livePanelsCassette = (): Cassette =>+ mergeCassettes(flowTabsCassette(), {+ subscriptions: {+ agentLogAdded: [+ {+ frames: [+ streamedFrame({+ agentLogAdded: entity('AgentLog', {+ createdAt: T,+ executor: AgentType.Pentester,+ flowId: '5',+ id: '42',+ initiator: AgentType.Adviser,+ result: 'Streamed step complete',+ subtaskId: null,+ task: STREAMED.agent,+ taskId: '11',+ }),+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ searchLogAdded: [+ {+ frames: [+ streamedFrame({+ searchLogAdded: entity('SearchLog', {+ createdAt: T,+ engine: 'duckduckgo',+ executor: AgentType.Searcher,+ flowId: '5',+ id: '52',+ initiator: AgentType.Pentester,+ query: STREAMED.search,+ result: 'Streamed advisories',+ subtaskId: null,+ taskId: '11',+ }),+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ taskCreated: [+ {+ frames: [+ streamedFrame({+ taskCreated: entity('Task', {+ createdAt: T,+ flowId: '5',+ id: '12',+ input: 'Exploit the open port',+ result: '',+ status: StatusType.Running,+ subtasks: [],+ title: STREAMED.task,+ updatedAt: T,+ }),+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ taskUpdated: [+ {+ frames: [+ streamedFrame({+ taskUpdated: { ...TABS_TASK, status: StatusType.Running, title: STREAMED.taskRetitled },+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ terminalLogAdded: [+ {+ frames: [+ streamedFrame({+ terminalLogAdded: terminalLog('303', TerminalLogType.Stdout, STREAMED.terminal),+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ vectorStoreLogAdded: [+ {+ frames: [+ streamedFrame({+ vectorStoreLogAdded: entity('VectorStoreLog', {+ action: VectorStoreAction.Retrieve,+ createdAt: T,+ executor: AgentType.Memorist,+ filter: '{}',+ flowId: '5',+ id: '62',+ initiator: AgentType.Pentester,+ query: STREAMED.vector,+ result: 'Streamed recall complete',+ subtaskId: null,+ taskId: '11',+ }),+ }),+ ],+ variables: { flowId: '5' },+ },+ ],+ },+ });++const flowReportData: ResultOf<typeof FlowReportDocument> = { flow: FLOW_A, tasks: [TABS_TASK] };++/** The Report menu only appears when the flow query returns tasks, so this overrides `flow` too. */+export const flowReportCassette = (): Cassette =>+ flowsCassette({+ queries: {+ flow: [{ data: flowTabsData, variables: { id: '5' } }],+ flowReport: [{ data: flowReportData, variables: { id: '5' } }],+ },+ subscriptions: { messageLogAdded: [{ frames: [], variables: { flowId: '5' } }] },+ });+export const flowTabsCassette = (): Cassette =>flowsCassette({queries: {diff --git a/frontend/e2e/mocks/cassettes/knowledges.ts b/frontend/e2e/mocks/cassettes/knowledges.tsindex e542a931..2ed91c41 100644--- a/frontend/e2e/mocks/cassettes/knowledges.ts+++ b/frontend/e2e/mocks/cassettes/knowledges.ts@@ -1,6 +1,10 @@import type { ResultOf } from '@graphql-typed-document-node/core';-import type { KnowledgeDocumentFragmentFragment, KnowledgeDocumentsDocument } from '@/graphql/types';+import type {+ KnowledgeDocumentDocument,+ KnowledgeDocumentFragmentFragment,+ KnowledgeDocumentsDocument,+} from '@/graphql/types';import { KnowledgeAnswerType, KnowledgeDocType } from '@/graphql/types';@@ -46,3 +50,18 @@ export const knowledgesCassette = (override: Cassette = {}): Cassette =>},override,);++const knowledgeDocument: ResultOf<typeof KnowledgeDocumentDocument> = { knowledgeDocument: KNOWLEDGE_DOC };++/** Adds the single-document query the detail route issues for KNOWLEDGE_DOC. */+export const knowledgeDetailCassette = (override: Cassette = {}): Cassette =>+ knowledgesCassette(+ mergeCassettes(+ {+ queries: {+ knowledgeDocument: [{ data: knowledgeDocument, variables: { id: KNOWLEDGE_DOC.id } }],+ },+ },+ override,+ ),+ );diff --git a/frontend/e2e/mocks/cassettes/resources.ts b/frontend/e2e/mocks/cassettes/resources.tsindex b896e3d0..0e715432 100644--- a/frontend/e2e/mocks/cassettes/resources.ts+++ b/frontend/e2e/mocks/cassettes/resources.ts@@ -33,6 +33,20 @@ export const CREATED_FOLDER: UserResourceFragmentFragment = entity('UserResourceuserId: '1',});+export const UPLOADED_RESOURCE = makeRestResource(4, 'uploaded-notes.txt', 42, false);++/** What the server broadcasts once the upload lands — the list only grows through this frame. */+export const UPLOADED_FRAGMENT: UserResourceFragmentFragment = entity('UserResource', {+ createdAt: '2026-01-15T12:00:00Z',+ id: '4',+ isDir: false,+ name: UPLOADED_RESOURCE.name,+ path: UPLOADED_RESOURCE.path,+ size: UPLOADED_RESOURCE.size,+ updatedAt: '2026-01-15T12:00:00Z',+ userId: '1',+});+const seededList: RestResourceList = { items: [FOLDER_RESOURCE, FILE_RESOURCE], total: 2 };export const emptyResourcesCassette = (): Cassette => ({@@ -40,6 +54,30 @@ export const emptyResourcesCassette = (): Cassette => ({rest: baseRest(),});+export const RENAMED_PATH = 'renamed-notes.txt';+export const COPY_DESTINATION = 'archive/notes.txt';++/** The write verbs differ per action — move is a PUT, copy a POST, delete a DELETE with the paths in+ * the query string. A method mismatch does not 404 here: it falls through to the SPA and answers 200+ * with HTML, so each entry pins the method as well as the payload. */+export const resourceWrites = (): Cassette['rest'] => ({+ 'DELETE /api/v1/resources/': [+ { body: { data: {}, status: 'success' }, querySubset: { 'paths[]': FILE_RESOURCE.path } },+ ],+ 'POST /api/v1/resources/copy': [+ {+ body: { data: {}, status: 'success' },+ bodySubset: { destination: COPY_DESTINATION, sources: [FILE_RESOURCE.path] },+ },+ ],+ 'PUT /api/v1/resources/move': [+ {+ body: { data: {}, status: 'success' },+ bodySubset: { destination: RENAMED_PATH, sources: [FILE_RESOURCE.path] },+ },+ ],+});+export const resourcesCassette = (override: Cassette = {}): Cassette =>mergeCassettes({diff --git a/frontend/e2e/mocks/cassettes/settings-prompts.ts b/frontend/e2e/mocks/cassettes/settings-prompts.tsindex b75b94b4..981a4fd5 100644--- a/frontend/e2e/mocks/cassettes/settings-prompts.ts+++ b/frontend/e2e/mocks/cassettes/settings-prompts.ts@@ -1,6 +1,10 @@import type { ResultOf } from '@graphql-typed-document-node/core';-import type { DefaultPromptFragmentFragment, SettingsPromptsDocument } from '@/graphql/types';+import type {+ DefaultPromptFragmentFragment,+ SettingsPromptsDocument,+ UserPromptFragmentFragment,+} from '@/graphql/types';import { PromptType } from '@/graphql/types';@@ -32,7 +36,7 @@ export const RICH_PROMPT_TEMPLATE = ['- report every finding with evidence','','```bash',- 'nmap -sV {{.Target}}',+ 'nmap -sV {{.Target}} --script <default>','```','','| Field | Value |',@@ -48,6 +52,7 @@ const richPentesterSystem = entity('DefaultPrompt', {const makeSettingsPrompts = (pentesterSystem: DefaultPromptFragmentFragment = prompt(PromptType.Pentester),+ userDefined: UserPromptFragmentFragment[] = [],): ResultOf<typeof SettingsPromptsDocument> => ({settingsPrompts: entity('PromptsConfig', {default: entity('DefaultPrompts', {@@ -86,7 +91,7 @@ const makeSettingsPrompts = (wrapAgentTask: prompt(PromptType.TaskAssignmentWrapper),}),}),- userDefined: [],+ userDefined,}),});@@ -107,6 +112,44 @@ export const settingsPromptsCassette = (override: Cassette = {}): Cassette =>/** The agent key the prompt detail route resolves from its `:promptId` param. */export const PROMPT_DETAIL_AGENT = 'pentester';+/** The operator's own copy of the pentester system prompt: its presence is what switches the editor+ * from the create branch to the update branch, and its id is what a save has to carry. */+export const PROMPT_OVERRIDE = {+ id: 'user-prompt-1',+ // Shares no line with the default on purpose: an override that merely appends to it makes+ // "the default came back" indistinguishable from "nothing happened".+ template: ['# Operator override', '', 'This copy replaces the shipped prompt for {{.Target}}.'].join('\n'),+};++const promptOverride = (): UserPromptFragmentFragment =>+ entity('UserPrompt', {+ createdAt: '2026-01-15T09:00:00Z',+ id: PROMPT_OVERRIDE.id,+ template: PROMPT_OVERRIDE.template,+ type: PromptType.Pentester,+ updatedAt: '2026-01-15T09:00:00Z',+ });++/** Raised by a spec's deletePrompt entry so the refetch can answer without the override. */+export const PROMPT_RESET_FLAG = 'prompt-override-deleted';++/** The same agent, but already overridden — the branch where Save updates instead of creating. The+ * second answer models the row actually being gone, so a reset has a real post-state to observe. */+export const promptOverrideCassette = (override: Cassette = {}): Cassette =>+ mergeCassettes(+ {+ queries: {+ ...baseQueries(),+ settingsPrompts: [+ { data: makeSettingsPrompts(richPentesterSystem, [promptOverride()]) },+ { data: makeSettingsPrompts(richPentesterSystem), whenFlag: PROMPT_RESET_FLAG },+ ],+ },+ rest: baseRest(),+ },+ override,+ );+/** Same config, but that agent's system prompt carries RICH_PROMPT_TEMPLATE. */export const promptDetailCassette = (override: Cassette = {}): Cassette =>mergeCassettes(diff --git a/frontend/e2e/mocks/cassettes/settings-providers.ts b/frontend/e2e/mocks/cassettes/settings-providers.tsindex 7ca89a22..0eb56049 100644--- a/frontend/e2e/mocks/cassettes/settings-providers.ts+++ b/frontend/e2e/mocks/cassettes/settings-providers.ts@@ -3,8 +3,12 @@ import type { ResultOf } from '@graphql-typed-document-node/core';import type {AgentConfigFragmentFragment,AgentsConfigFragmentFragment,+ AgentTestResultFragmentFragment,+ ModelConfigFragmentFragment,ProviderConfigFragmentFragment,+ ProviderTestResultFragmentFragment,SettingsProvidersDocument,+ TestResultFragmentFragment,} from '@/graphql/types';import { ProviderType } from '@/graphql/types';@@ -16,65 +20,104 @@ import { baseQueries, baseRest } from './base.ts';const T = '2026-01-15T09:00:00Z';-const agentConfig = (): AgentConfigFragmentFragment =>+/** `n: 1` and `json: true` are the shipped simple_json defaults; they are pinned in the create payload+ * because dropping exactly these on the way to the wire is a regression this repo has already had. */+const agentConfig = (model = 'e2e-model'): AgentConfigFragmentFragment =>entity('AgentConfig', {extraBody: null,frequencyPenalty: null,+ json: true,maxLength: null,- maxTokens: null,+ maxTokens: 4096,minLength: null,- model: 'e2e-model',+ minP: null,+ model,+ n: 1,presencePenalty: null,price: null,reasoning: null,repetitionPenalty: null,+ responseMimeType: null,temperature: null,topK: null,topP: null,});-const agentsConfig = (): AgentsConfigFragmentFragment =>+const agentsConfig = (model?: string): AgentsConfigFragmentFragment =>entity('AgentsConfig', {- adviser: agentConfig(),- assistant: agentConfig(),- coder: agentConfig(),- enricher: agentConfig(),- generator: agentConfig(),- installer: agentConfig(),- pentester: agentConfig(),- primaryAgent: agentConfig(),- refiner: agentConfig(),- reflector: agentConfig(),- searcher: agentConfig(),- simple: agentConfig(),- simpleJson: agentConfig(),+ adviser: agentConfig(model),+ assistant: agentConfig(model),+ coder: agentConfig(model),+ enricher: agentConfig(model),+ generator: agentConfig(model),+ installer: agentConfig(model),+ pentester: agentConfig(model),+ primaryAgent: agentConfig(model),+ refiner: agentConfig(model),+ reflector: agentConfig(model),+ searcher: agentConfig(model),+ simple: agentConfig(model),+ simpleJson: agentConfig(model),});-const defaultConfig = (id: string, type: ProviderType): ProviderConfigFragmentFragment =>+/**+ * Defaults are not database rows: the resolver builds them without an ID, so the wire carries the+ * bare number `0` for every one. `ProviderConfig.keyFields`'s id-0 branch exists for that shape, and+ * a distinct string id here leaves it unexercised.+ */+const defaultConfig = (type: ProviderType): ProviderConfigFragmentFragment =>entity('ProviderConfig', {- agents: agentsConfig(),+ // Distinct per type, so two defaults collapsing onto one cache entry is observable.+ agents: agentsConfig(`e2e-${type}-model`),createdAt: T,- id,- name: `default-${type}`,+ id: 0 as unknown as string,+ name: type,type,updatedAt: T,});+const modelConfig = (name: string): ModelConfigFragmentFragment =>+ entity('ModelConfig', { name, price: null, reasoning: null, thinking: null });++// The backend fills a default config AND a model catalog for EVERY type, keyed or not (verified live:+// gemini/deepseek/ollama all return a non-null default and a populated catalog with zero keys). A+// cassette leaving them null/[] encodes a wire state the resolver never emits and leaves the+// create-form's model-dropdown seeding path structurally unreachable.+const allDefaults = () =>+ entity('DefaultProvidersConfig', {+ anthropic: defaultConfig(ProviderType.Anthropic),+ bedrock: defaultConfig(ProviderType.Bedrock),+ custom: defaultConfig(ProviderType.Custom),+ deepseek: defaultConfig(ProviderType.Deepseek),+ gemini: defaultConfig(ProviderType.Gemini),+ glm: defaultConfig(ProviderType.Glm),+ kimi: defaultConfig(ProviderType.Kimi),+ minimax: defaultConfig(ProviderType.Minimax),+ ollama: defaultConfig(ProviderType.Ollama),+ openai: defaultConfig(ProviderType.Openai),+ qwen: defaultConfig(ProviderType.Qwen),+ });++const catalog = (type: ProviderType) => [modelConfig(`e2e-${type}-model`), modelConfig(`e2e-${type}-model-mini`)];++const allModels = () =>+ entity('ProvidersModelsList', {+ anthropic: catalog(ProviderType.Anthropic),+ bedrock: catalog(ProviderType.Bedrock),+ custom: catalog(ProviderType.Custom),+ deepseek: catalog(ProviderType.Deepseek),+ gemini: catalog(ProviderType.Gemini),+ glm: catalog(ProviderType.Glm),+ kimi: catalog(ProviderType.Kimi),+ minimax: catalog(ProviderType.Minimax),+ ollama: catalog(ProviderType.Ollama),+ openai: catalog(ProviderType.Openai),+ qwen: catalog(ProviderType.Qwen),+ });+const noProviders: ResultOf<typeof SettingsProvidersDocument> = {settingsProviders: entity('ProvidersConfig', {- default: entity('DefaultProvidersConfig', {- anthropic: defaultConfig('default-anthropic', ProviderType.Anthropic),- bedrock: null,- custom: null,- deepseek: null,- gemini: null,- glm: null,- kimi: null,- minimax: null,- ollama: null,- openai: defaultConfig('default-openai', ProviderType.Openai),- qwen: null,- }),+ default: allDefaults(),enabled: entity('ProvidersReadinessStatus', {anthropic: false,bedrock: false,@@ -88,19 +131,7 @@ const noProviders: ResultOf<typeof SettingsProvidersDocument> = {openai: false,qwen: false,}),- models: entity('ProvidersModelsList', {- anthropic: [],- bedrock: [],- custom: [],- deepseek: [],- gemini: [],- glm: [],- kimi: [],- minimax: [],- ollama: [],- openai: [],- qwen: [],- }),+ models: allModels(),userDefined: [],}),};@@ -117,21 +148,27 @@ export const settingsProvidersCassette = (override: Cassette = {}): Cassette =>override,);-const populatedProviders: ResultOf<typeof SettingsProvidersDocument> = {+export const SEEDED_PROVIDER = {+ id: 'custom-1',+ name: 'My Custom Endpoint',+ type: ProviderType.Custom,+};++export const seededProviderRow = (): ProviderConfigFragmentFragment =>+ entity('ProviderConfig', {+ agents: agentsConfig(),+ createdAt: T,+ id: SEEDED_PROVIDER.id,+ name: SEEDED_PROVIDER.name,+ type: SEEDED_PROVIDER.type,+ updatedAt: T,+ });++/** The whole settingsProviders answer with a chosen set of user-defined rows — a delete asserts against+ * the follow-up answer, so the list has to be expressible without the deleted row. */+export const providersList = (...userDefined: ProviderConfigFragmentFragment[]) => ({settingsProviders: entity('ProvidersConfig', {- default: entity('DefaultProvidersConfig', {- anthropic: defaultConfig('default-anthropic', ProviderType.Anthropic),- bedrock: null,- custom: null,- deepseek: null,- gemini: null,- glm: null,- kimi: null,- minimax: null,- ollama: null,- openai: defaultConfig('default-openai', ProviderType.Openai),- qwen: null,- }),+ default: allDefaults(),enabled: entity('ProvidersReadinessStatus', {anthropic: true,bedrock: false,@@ -145,32 +182,73 @@ const populatedProviders: ResultOf<typeof SettingsProvidersDocument> = {openai: true,qwen: false,}),- models: entity('ProvidersModelsList', {- anthropic: [],- bedrock: [],- custom: [],- deepseek: [],- gemini: [],- glm: [],- kimi: [],- minimax: [],- ollama: [],- openai: [],- qwen: [],- }),- userDefined: [- entity('ProviderConfig', {- agents: agentsConfig(),- createdAt: T,- id: 'custom-1',- name: 'My Custom Endpoint',- type: ProviderType.Custom,- updatedAt: T,- }),- ],+ models: allModels(),+ userDefined,}),+});++/** A second row so a delete spec can operate a row that is not index 0, and prove the table survived. */+export const OTHER_PROVIDER = {+ id: 'custom-2',+ name: 'Second Endpoint',};+export const OTHER_PROVIDER_ROW = (): ProviderConfigFragmentFragment =>+ entity('ProviderConfig', {+ agents: agentsConfig(),+ createdAt: T,+ id: OTHER_PROVIDER.id,+ name: OTHER_PROVIDER.name,+ type: ProviderType.Custom,+ updatedAt: T,+ });++/** updateProvider answers with ProviderConfig, and Apollo writes it straight onto the row the list+ * renders — returning the pre-edit name would make the list contradict the save. */+export const renamedProviderRow = (name: string): ProviderConfigFragmentFragment =>+ entity('ProviderConfig', {+ agents: agentsConfig(),+ createdAt: T,+ id: SEEDED_PROVIDER.id,+ name,+ type: SEEDED_PROVIDER.type,+ updatedAt: T,+ });++const populatedProviders: ResultOf<typeof SettingsProvidersDocument> = providersList(seededProviderRow());++const testResult = (name: string, result: boolean): TestResultFragmentFragment =>+ entity('TestResult', {+ error: result ? null : 'e2e simulated failure',+ latency: 42,+ name,+ reasoning: false,+ result,+ streaming: false,+ type: 'chat',+ });++export const agentTestResult = (result = true): AgentTestResultFragmentFragment =>+ entity('AgentTestResult', { tests: [testResult('chat completion', result)] });++/** One agent fails on purpose: a dialog that renders only the passing rows would still look right. */+export const providerTestResult = (): ProviderTestResultFragmentFragment =>+ entity('ProviderTestResult', {+ adviser: agentTestResult(),+ assistant: agentTestResult(),+ coder: agentTestResult(),+ enricher: agentTestResult(),+ generator: agentTestResult(),+ installer: agentTestResult(),+ pentester: agentTestResult(false),+ primaryAgent: agentTestResult(),+ refiner: agentTestResult(),+ reflector: agentTestResult(),+ searcher: agentTestResult(),+ simple: agentTestResult(),+ simpleJson: agentTestResult(),+ });+export const populatedSettingsProvidersCassette = (override: Cassette = {}): Cassette =>mergeCassettes({diff --git a/frontend/e2e/mocks/install.ts b/frontend/e2e/mocks/install.tsindex 0e766d4c..a374d73d 100644--- a/frontend/e2e/mocks/install.ts+++ b/frontend/e2e/mocks/install.ts@@ -1,20 +1,21 @@-import type { Page } from '@playwright/test';+import type { BrowserContext, Route } from '@playwright/test';import type { MockWorld } from './world.ts';import { installWsMock } from './ws-graphql.ts';+const API_GLOB = '**/api/v1/**';const GRAPHQL_PATH = '/api/v1/graphql';-export const installMockRoutes = async (page: Page, world: MockWorld): Promise<void> => {- await installWsMock(page, world);+export const installMockRoutes = async (context: BrowserContext, world: MockWorld): Promise<void> => {+ await installWsMock(context, world);// Single catch-all over the whole API surface: anything without a cassette// entry fails fast (501 + recorded in world.unmatched, asserted at teardown)// instead of leaking through the vite preview proxy to a live backend.- await page.route('**/api/v1/**', async (route) => {+ const serve = async (route: Route) => {const request = route.request();- const { pathname } = new URL(request.url());+ const { pathname, searchParams } = new URL(request.url());if (pathname === GRAPHQL_PATH && request.method() === 'POST') {const body = request.postDataJSON() as {@@ -26,10 +27,11 @@ export const installMockRoutes = async (page: Page, world: MockWorld): Promise<vif (entry) {await route.fulfill({- json: {+ json: entry.body ?? {...(entry.data === undefined ? {} : { data: entry.data }),...(entry.errors ? { errors: entry.errors } : {}),},+ status: entry.status ?? 200,});return;@@ -50,7 +52,7 @@ export const installMockRoutes = async (page: Page, world: MockWorld): Promise<vconst body = contentType.includes('application/json')? (request.postDataJSON() as Record<string, unknown> | undefined): undefined;- const entry = world.matchRest(request.method(), pathname, body ?? undefined);+ const entry = world.matchRest(request.method(), pathname, body ?? undefined, searchParams);if (entry) {await route.fulfill(@@ -66,10 +68,15 @@ export const installMockRoutes = async (page: Page, world: MockWorld): Promise<vreturn;}- world.reportUnmatched(`${request.method()} ${pathname}`);+ world.reportUnmatched(`${request.method()} ${pathname}${searchParams.size ? `?${searchParams}` : ''}`);await route.fulfill({json: { error: `e2e: no cassette entry for ${request.method()} ${pathname}`, status: 'error' },status: 501,});- });+ };++ // A page route is not inherited by the popups that page opens, so arm every page the context gets.+ context.on('page', (opened) => void opened.route(API_GLOB, serve));++ await Promise.all(context.pages().map((existing) => existing.route(API_GLOB, serve)));};diff --git a/frontend/e2e/mocks/world.ts b/frontend/e2e/mocks/world.tsindex 81028d50..2688b4d1 100644--- a/frontend/e2e/mocks/world.ts+++ b/frontend/e2e/mocks/world.ts@@ -39,6 +39,17 @@ const isSubsetMatch = (expected?: Record<string, unknown>, actual?: Record<strinconst sleep = (delayMs: number) => new Promise<void>((resolve) => setTimeout(resolve, delayMs));+/** Repeated keys (`paths[]=a&paths[]=b`) collapse to the full list, so a subset match sees both. */+const queryRecord = (search?: URLSearchParams): Record<string, string | string[]> =>+ Object.fromEntries(+ [...(search?.keys() ?? [])]+ .map((key) => [key, search!.getAll(key)])+ .map(([key, values]) => [key, (values as string[]).length > 1 ? values : (values as string[])[0]]),+ );++export const subscriptionStreamKey = (operationName: string, variables?: Record<string, unknown>): string =>+ `sub:${operationName}:${stableStringify(variables ?? {})}`;+export interface MockSocket {close: (options?: { code?: number; reason?: string }) => unknown;}@@ -100,29 +111,46 @@ export class MockWorld {const candidates = this.eligible(matching);if (matching && candidates?.length) {- return this.nextEntry(`gql:${operationName}:${stableStringify(variables ?? {})}`, candidates, matching);+ // Same cursor rule as matchRest below: key on the selected entries' pins, so an+ // operation whose variables carry a per-call volatile field still advances its+ // sequence instead of re-serving step one.+ const signature = matching.map((entry) => stableStringify(entry.variables ?? null)).join('|');++ return this.nextEntry(`gql:${operationName}:${signature}`, candidates, matching);}}return undefined;}- matchRest(method: string, pathname: string, body?: Record<string, unknown>): RestCassetteEntry | undefined {+ matchRest(+ method: string,+ pathname: string,+ body?: Record<string, unknown>,+ search?: URLSearchParams,+ ): RestCassetteEntry | undefined {const normalized = pathname.replace(/\/+$/, '');const key = Object.keys(this.cassette.rest ?? {}).find((candidate) => {const [candidateMethod, candidatePath = ''] = candidate.split(' ');return candidateMethod === method && candidatePath.replace(/\/+$/, '') === normalized;});- const matching = (key ? this.cassette.rest?.[key] : undefined)?.filter((entry) =>- isSubsetMatch(entry.bodySubset, body),+ const query = queryRecord(search);+ const matching = (key ? this.cassette.rest?.[key] : undefined)?.filter(+ (entry) => isSubsetMatch(entry.bodySubset, body) && isSubsetMatch(entry.querySubset, query),);const candidates = this.eligible(matching);- // Include the body in the cursor key (as the GraphQL half keys on variables): two- // body-differentiated sequences for one path must not reset each other's cursor.+ // Key the cursor on which entries the request selected — their pins — not the raw body/query.+ // Two payload-differentiated sequences still get distinct keys (their entries pin different+ // subsets), but a request carrying a per-call volatile field (an idempotency key, a timestamp)+ // no longer fragments its own cursor into a fresh sequence on every call.+ const signature = matching+ ?.map((entry) => stableStringify([entry.bodySubset ?? null, entry.querySubset ?? null]))+ .join('|');+return matching && candidates?.length- ? this.nextEntry(`rest:${method}:${normalized}:${stableStringify(body ?? {})}`, candidates, matching)+ ? this.nextEntry(`rest:${method}:${normalized}:${signature}`, candidates, matching): undefined;}@@ -136,7 +164,7 @@ export class MockWorld {// Key on the request's variables, not the entry's: an entry written without variables would// otherwise merge every flow's subscribers onto one stream, and the second would join delta-only.- return entry ? { entry, streamKey: `sub:${operationName}:${stableStringify(variables ?? {})}` } : undefined;+ return entry ? { entry, streamKey: subscriptionStreamKey(operationName, variables) } : undefined;}raiseFlag(flag: string): void {@@ -157,6 +185,10 @@ export class MockWorld {this.unmatchedSubscriptions.push(description);}+ subscriberCount(streamKey: string): number {+ return this.streams.get(streamKey)?.subscribers.size ?? 0;+ }+subscribeStream(streamKey: string, entry: SubscriptionCassetteEntry, subscriber: StreamSubscriber): () => void {const state = this.streams.get(streamKey) ?? { cursor: 0, isDriving: false, subscribers: new Set() };diff --git a/frontend/e2e/mocks/world.unit.test.ts b/frontend/e2e/mocks/world.unit.test.tsindex dba376e5..d0c6d6f4 100644--- a/frontend/e2e/mocks/world.unit.test.ts+++ b/frontend/e2e/mocks/world.unit.test.ts@@ -56,6 +56,66 @@ describe('MockWorld matching', () => {expect(world.matchRest('POST', '/api/v1/resources/mkdir/', { path: 'new-folder' })).toBeDefined();});+ it('pins a query-carrying request on querySubset, the way bodySubset pins a payload', () => {+ const world = new MockWorld({+ rest: {+ 'DELETE /api/v1/resources/': [+ { body: { deleted: 'notes' }, querySubset: { 'paths[]': 'notes.txt' } },+ { body: { deleted: 'both' }, querySubset: { 'paths[]': ['a.txt', 'b.txt'] } },+ ],+ },+ });+ const query = (search: string) => new URLSearchParams(search);++ expect(world.matchRest('DELETE', '/api/v1/resources/', undefined, query('paths[]=notes.txt'))?.body).toEqual({+ deleted: 'notes',+ });+ expect(+ world.matchRest('DELETE', '/api/v1/resources/', undefined, query('paths[]=a.txt&paths[]=b.txt'))?.body,+ ).toEqual({ deleted: 'both' });+ // The path alone must not answer for a payload no entry describes.+ expect(world.matchRest('DELETE', '/api/v1/resources/', undefined, query('paths[]=secret.txt'))).toBeUndefined();+ });++ it('advances a REST sequence even when each request carries a volatile body field', () => {+ const world = new MockWorld({+ rest: {+ 'POST /api/v1/resources/mkdir': [{ body: { step: 1 } }, { body: { step: 2 } }],+ },+ });+ // Each call sends a fresh idempotency key — a field no entry pins. The cursor must key on the+ // selected entries, not the raw body, or every call re-serves step 1.+ const first = world.matchRest('POST', '/api/v1/resources/mkdir', { idempotencyKey: 'a1' });+ const second = world.matchRest('POST', '/api/v1/resources/mkdir', { idempotencyKey: 'b2' });++ expect(first?.body).toEqual({ step: 1 });+ expect(second?.body).toEqual({ step: 2 });+ });++ it('advances a GraphQL sequence even when each request carries a volatile variable', () => {+ const world = new MockWorld({+ queries: { flows: [{ data: { step: 1 } }, { data: { step: 2 } }] },+ });++ expect(world.matchGraphQL('flows', { nonce: 'a' })?.data).toEqual({ step: 1 });+ expect(world.matchGraphQL('flows', { nonce: 'b' })?.data).toEqual({ step: 2 });+ });++ it('keeps variable-pinned sequences apart from one another', () => {+ const world = new MockWorld({+ queries: {+ stats: [+ { data: { period: 'week' }, variables: { period: 'week' } },+ { data: { period: 'month' }, variables: { period: 'month' } },+ ],+ },+ });++ expect(world.matchGraphQL('stats', { period: 'week' })?.data).toEqual({ period: 'week' });+ expect(world.matchGraphQL('stats', { period: 'month' })?.data).toEqual({ period: 'month' });+ expect(world.matchGraphQL('stats', { period: 'week' })?.data).toEqual({ period: 'week' });+ });+it('hides a flag-gated entry until the flag is raised, then lets it outrank the unflagged one', () => {const world = new MockWorld({mutations: { login: [{ data: { ok: true }, setFlag: 'logged-in' }] },@@ -67,6 +127,26 @@ describe('MockWorld matching', () => {expect(world.matchGraphQL('info', {})?.data).toEqual({ role: 'user' });});+ it('prefers the newly-enabled entry over the next unserved one, not merely the next in order', () => {+ // Three candidates, so sequencing and the flag rule disagree: with the rule the raised flag+ // jumps straight to `flagged`; without it the cursor would just hand out `second`. The+ // two-entry cases above cannot tell the two apart.+ const world = new MockWorld({+ mutations: { go: [{ data: {}, setFlag: 'go' }] },+ queries: {+ stage: [+ { data: { stage: 'first' } },+ { data: { stage: 'second' } },+ { data: { stage: 'flagged' }, whenFlag: 'go' },+ ],+ },+ });++ expect(world.matchGraphQL('stage', {})?.data).toEqual({ stage: 'first' });+ world.matchGraphQL('go', {});+ expect(world.matchGraphQL('stage', {})?.data).toEqual({ stage: 'flagged' });+ });+it('advances to the newly-enabled entry after a second flag, without replaying the first', () => {const world = new MockWorld({mutations: { f1: [{ data: {}, setFlag: 'f1' }], f2: [{ data: {}, setFlag: 'f2' }] },diff --git a/frontend/e2e/mocks/ws-graphql.ts b/frontend/e2e/mocks/ws-graphql.tsindex 8273b42e..c27a81ea 100644--- a/frontend/e2e/mocks/ws-graphql.ts+++ b/frontend/e2e/mocks/ws-graphql.ts@@ -1,4 +1,4 @@-import type { Page } from '@playwright/test';+import type { BrowserContext } from '@playwright/test';import type { MockWorld } from './world.ts';@@ -54,7 +54,7 @@ export const handleWsConnection = (case 'connection_init': {// Ack immediately; a frame sent before the ack is a graphql-ws protocol- // violation that closes the socket. Ack-first ordering is pinned by the unit test.+ // violation that closes the socket.send({ type: 'connection_ack' });break;}@@ -98,8 +98,8 @@ export const handleWsConnection = (};};-export const installWsMock = async (page: Page, world: MockWorld): Promise<void> => {- await page.routeWebSocket('**/api/v1/graphql', (ws) => {+export const installWsMock = async (context: BrowserContext, world: MockWorld): Promise<void> => {+ await context.routeWebSocket('**/api/v1/graphql', (ws) => {const connection = handleWsConnection(world, ws);ws.onMessage((raw) => connection.onMessage(String(raw)));diff --git a/frontend/e2e/mocks/ws-graphql.unit.test.ts b/frontend/e2e/mocks/ws-graphql.unit.test.tsindex e622b7f2..2149958b 100644--- a/frontend/e2e/mocks/ws-graphql.unit.test.ts+++ b/frontend/e2e/mocks/ws-graphql.unit.test.ts@@ -155,8 +155,12 @@ describe('graphql-ws mock protocol contract', () => {world.dropSockets();- // graphql-ws resubscribes active sinks after the retry connect.+ // graphql-ws resubscribes active sinks in a microtask AFTER the retry connect, so gating on+ // the reconnect alone races the resubscribe: raising the flag before the sink re-registers+ // delivers seq:2 to an empty subscriber set and the no-replay contract loses it. Gate on the+ // server-side resubscription instead.await vi.waitFor(() => expect(retries).toEqual([false, true]));+ await vi.waitFor(() => expect(world.subscriberCount('sub:stream:{}')).toBe(1));world.matchGraphQL('raise');diff --git a/frontend/e2e/playwright.config.ts b/frontend/e2e/playwright.config.tsindex 9f936482..fb5b7fc8 100644--- a/frontend/e2e/playwright.config.ts+++ b/frontend/e2e/playwright.config.ts@@ -26,7 +26,7 @@ const here = (relative: string) => fileURLToPath(new URL(relative, import.meta.uexport const AUTH_STATE_PATH = here('./.auth/user.json');const TIERS: Record<BackendTier, { baseURL: string; installMocks: boolean }> = {- local: { baseURL: process.env.E2E_BASE_URL ?? 'https://localhost:8443', installMocks: false },+ local: { baseURL: process.env.E2E_BASE_URL ?? '', installMocks: false },mock: { baseURL: `http://localhost:${PREVIEW_PORT}`, installMocks: true },stand: { baseURL: process.env.E2E_BASE_URL ?? '', installMocks: false },};@@ -37,19 +37,20 @@ if (!(rawTier in TIERS)) {const tier = rawTier as BackendTier;-if (tier === 'stand' && !TIERS.stand.baseURL) {- throw new Error('E2E_TIER=stand requires E2E_BASE_URL');+// Both stand and local hit a real backend and bake the real (paid) flow-run specs, so neither may+// fall back to a default: a bare `E2E_TIER=local` must not silently target the dev stack. run-local-tier.sh+// supplies E2E_BASE_URL for the legitimate path.+if ((tier === 'stand' || tier === 'local') && !TIERS[tier].baseURL) {+ throw new Error(`E2E_TIER=${tier} requires E2E_BASE_URL`);}export default defineConfig<BackendOptions>({- // A colour change must move enough pixels to fail. The baselines and the run both- // render in the pinned container (the host path is blocked above), so there is no- // host-vs-CI rasterisation noise to absorb — tighten the per-pixel threshold below- // Playwright's default 0.2 so a one-step palette shift is caught, with a small- // maxDiffPixelRatio for anti-aliasing at glyph edges. cross/contrast.spec.ts still- // measures colour numerically as the belt-and-suspenders check.+ // Absolute, not a ratio: 1% of a 1280x720 baseline is 9,216 pixels, more than any one foreground+ // token covers, so a token could change hue with every baseline still matching. Baselines and+ // run both render in the pinned container (the host path is blocked above), so 200px absorbs the+ // glyph anti-aliasing without host-vs-CI noise.expect: {- toHaveScreenshot: { maxDiffPixelRatio: 0.01, threshold: 0.02 },+ toHaveScreenshot: { maxDiffPixels: 200, threshold: 0.02 },},forbidOnly: isCI,fullyParallel: true,@@ -110,7 +111,10 @@ export default defineConfig<BackendOptions>({// Stand traces/videos embed the live session cookie and the setup// project's password fill; CI uploads test-results as a public-repo// artifact, so they must never be recorded on that tier.- trace: tier === 'stand' ? 'off' : 'on-first-retry',+ // retain-on-failure, not on-first-retry: the mock PR gate runs retries:0,+ // so on-first-retry would never write a trace — yet the docs and the PR+ // comment tell you to open trace.zip from that tier's report.+ trace: tier === 'stand' ? 'off' : 'retain-on-failure',video: tier === 'stand' ? 'off' : 'retain-on-failure',},// The gate must test the shipped artifact: keep this on the production build,diff --git a/frontend/e2e/route-manifest.unit.test.ts b/frontend/e2e/route-manifest.unit.test.tsindex 9823a70d..d1380793 100644--- a/frontend/e2e/route-manifest.unit.test.ts+++ b/frontend/e2e/route-manifest.unit.test.ts@@ -1,9 +1,17 @@+import { readdirSync, readFileSync } from 'node:fs';+import { join } from 'node:path';+import { pathToFileURL } from 'node:url';import { describe, expect, it } from 'vitest';import { routes } from '@/lib/routes';+import { affectedRoutes } from './affected-routes.ts';import { ROUTE_MANIFEST } from './routes.ts';+const { RULES } = (await import(pathToFileURL(join(__dirname, 'mock-llm', 'scenario.mjs')).href)) as {+ RULES: { label: string; match: RegExp }[];+};+/*** Routes deliberately outside the manifest sweeps (nav, visual, a11y,* diff-scoping), each with the reason. Adding a route to lib/routes forces a@@ -75,3 +83,42 @@ describe('ROUTE_MANIFEST completeness', () => {expect(dynamicRouteKeys(routes).sort()).toEqual(Object.keys(DYNAMIC_ROUTES).sort());});});++const SHELL_DIR = 'components/layouts/main';++const shellImports = (): string[] => {+ const dir = join(__dirname, '..', 'src', SHELL_DIR);++ return readdirSync(dir)+ .filter((file) => file.endsWith('.tsx') && !file.endsWith('.test.tsx'))+ .flatMap((file) => [...readFileSync(join(dir, file), 'utf8').matchAll(/from '@\/([^']+)'/g)])+ .flatMap(([, imported]) => (imported ? [`frontend/src/${imported}`] : []));+};++describe('ROUTE_MANIFEST ownership', () => {+ it('never scopes a source the app shell imports to a subset of the swept routes', () => {+ const underScoped = shellImports().filter(+ (file) => affectedRoutes([file], ROUTE_MANIFEST).length < ROUTE_MANIFEST.length,+ );++ expect(underScoped).toEqual([]);+ });+});++describe('mock-llm rule matching', () => {+ const rule = RULES.find((entry) => entry.label === 'subagent-terminal-report');++ it('answers only a request carrying both markers', () => {+ expect(rule?.match.test('{"tools":["hack_result"],"text":"E2E_TERMINAL_OK"}')).toBe(true);+ expect(rule?.match.test('{"tools":["hack_result"]}')).toBe(false);+ expect(rule?.match.test('{"text":"E2E_TERMINAL_OK"}')).toBe(false);+ });++ it('rejects a marker-less request without re-scanning from every offset', () => {+ const request = JSON.stringify({ messages: 'a'.repeat(120 * 1024) });+ const started = performance.now();++ expect(rule?.match.test(request)).toBe(false);+ expect(performance.now() - started).toBeLessThan(500);+ });+});diff --git a/frontend/e2e/routes.ts b/frontend/e2e/routes.tsindex dcccbb10..e20c2179 100644--- a/frontend/e2e/routes.ts+++ b/frontend/e2e/routes.ts@@ -7,7 +7,7 @@ import type { Cassette } from './mocks/cassette.ts';import { apiTokensCassette } from './mocks/cassettes/api-tokens.ts';import { dashboardCassette } from './mocks/cassettes/dashboard.ts';-import { flowsCassette, flowTabsCassette } from './mocks/cassettes/flows.ts';+import { flowsCassette, flowTabsCassette, TABS_FILE_NAME, TABS_SCREENSHOT_URL } from './mocks/cassettes/flows.ts';import { knowledgesCassette } from './mocks/cassettes/knowledges.ts';import { resourcesCassette } from './mocks/cassettes/resources.ts';import { settingsPromptsCassette } from './mocks/cassettes/settings-prompts.ts';@@ -27,9 +27,31 @@ export interface RouteManifestEntry {*/sources: string[];/** Radix unmounts inactive tab panels, so one scan of the default view sees none of them. */- tabs?: string[];+ tabs?: RouteTab[];}+export interface RouteTab {+ name: string;+ /**+ * Must be absent while the panel loads: a marker that also renders on the+ * skeleton lets every per-tab scan pass on an empty panel.+ */+ ready: (page: Page) => Locator;+}++/** Order matters: the flow auto-opens Assistant, so tabs.spec pins that no entry is already open. */+export const FLOW_DETAIL_TABS: RouteTab[] = [+ { name: 'Dashboard', ready: (page) => page.getByText('Usage by Model & Provider') },+ { name: 'Assistant', ready: (page) => page.getByText('New assistant', { exact: true }) },+ { name: 'Automation', ready: (page) => page.getByText('No active tasks') },+ { name: 'Tasks', ready: (page) => page.getByText('E2E Task Alpha') },+ { name: 'Agents', ready: (page) => page.getByText('E2E agent reconnaissance') },+ { name: 'Searches', ready: (page) => page.getByText('E2E search for the CVE') },+ { name: 'Vector Store', ready: (page) => page.getByText('E2E recall prior findings') },+ { name: 'Files', ready: (page) => page.getByText(TABS_FILE_NAME) },+ { name: 'Screenshots', ready: (page) => page.getByText(TABS_SCREENSHOT_URL) },+];+/*** The routes swept by NAV/visual/a11y specs and CI diff-scoping. This is a* subset of the app's routes — route-manifest.unit.test.ts pins the excluded@@ -47,18 +69,20 @@ export const ROUTE_MANIFEST: RouteManifestEntry[] = [sources: ['src/pages/flows/flows.tsx', 'src/features/flows', 'src/providers/flows-provider.tsx'],},{- // Message metadata (date + ID) renders at 50% opacity by design; revisit- // with the design pass.+ // Message metadata (date + ID) is by design and route-wide; the rest are defects awaiting a+ // fix, each scoped to the tab whose panel owns it so it cannot silence the rule elsewhere.a11yWaivers: [{ rule: 'color-contrast', target: /text-muted-foreground\\?\/50/ },- // The tab-panel ones below are defects awaiting a fix, not accepted design.- { rule: 'aria-progressbar-name', target: /bg-primary/ },- { rule: 'button-name', target: /span\[data-slot|button\[aria-label/ },- { rule: 'target-size', target: /text-blue-400|button\[aria-label/ },- { rule: 'color-contrast', target: /font-semibold\.truncate/ },- // The same file-manager row metadata waived on /resources — this tab embeds it.- { rule: 'color-contrast', target: /text-muted-foreground\\?\/80/ },- { rule: 'scrollable-region-focusable', target: /table-container/ },+ { rule: 'aria-progressbar-name', tabs: ['Tasks'], target: /\.bg-primary\\\/20/ },+ { rule: 'button-name', tabs: ['Files'], target: /tooltip-trigger.*size-8\[data-slot="button"\]/ },+ { rule: 'target-size', tabs: ['Files'], target: /text-blue-400|button\[aria-label="Select / },+ // The same file-manager row metadata waived on /resources — the Files tab embeds it.+ { rule: 'color-contrast', tabs: ['Files'], target: /text-muted-foreground\\?\/80/ },+ {+ rule: 'scrollable-region-focusable',+ tabs: ['Dashboard', 'Files'],+ target: /\[data-slot="table-container"\]/,+ },],// Must stay the populated cassette: the empty seed renders none of the sources below.cassette: flowTabsCassette,@@ -73,21 +97,27 @@ export const ROUTE_MANIFEST: RouteManifestEntry[] = ['src/providers/flows-provider.tsx','src/components/shared/file-manager','src/components/dashboard',- 'src/features/resources',+ // Assistant-tab FlowForm reads useTemplates, so a provider change reaches this route too.+ 'src/providers/templates-provider.tsx',],- tabs: ['Assistant', 'Dashboard', 'Tasks', 'Agents', 'Searches', 'Vector Store', 'Files', 'Screenshots'],+ tabs: FLOW_DETAIL_TABS,},{cassette: templatesCassette,path: routes.templates,ready: (page) => page.getByRole('row', { name: /E2E Seed Template/ }),- sources: ['src/pages/templates', 'src/providers/templates-provider.tsx'],+ // The list file, not the dir: template.tsx sits beside it and no manifest route renders it,+ // so owning the dir scopes a detail-only diff here instead of to the run-everything path.+ sources: ['src/pages/templates/templates.tsx', 'src/providers/templates-provider.tsx'],},{cassette: knowledgesCassette,path: routes.knowledges,ready: (page) => page.getByRole('row', { name: /E2E Seed Question/ }),- sources: ['src/pages/knowledges', 'src/features/knowledges', 'src/providers/knowledges-provider.tsx'],+ // `src/features/knowledges` is left unowned deliberately: knowledge.tsx is its only importer+ // and that route is not swept, so claiming it here would scope its diffs to a route that+ // never renders it rather than to the run-everything fallback.+ sources: ['src/pages/knowledges/knowledges.tsx', 'src/providers/knowledges-provider.tsx'],},{cassette: apiTokensCassette,@@ -102,8 +132,9 @@ export const ROUTE_MANIFEST: RouteManifestEntry[] = [a11yWaivers: [{ rule: 'aria-valid-attr-value', target: /radix-.*-trigger-/ }],cassette: dashboardCassette,path: routes.dashboard,- ready: (page) => page.getByRole('heading', { name: 'Flows Activity Over Time' }),+ ready: (page) => page.getByText('E2E Alpha'),sources: ['src/pages/dashboard', 'src/components/dashboard'],+ tabs: [{ name: 'Overview', ready: (page) => page.getByRole('cell', { exact: true, name: 'e2e-provider' }) }],},{cassette: settingsPromptsCassette,@@ -123,13 +154,17 @@ export const ROUTE_MANIFEST: RouteManifestEntry[] = [// target floor — widening them is a density decision for the file manager.a11yWaivers: [{ rule: 'color-contrast', target: /text-muted-foreground\\?\/80/ },- // `.rounded` unanchored would also match every rounded-* utility, so a- // future under-sized control anywhere on the page would be waived too.- { rule: 'target-size', target: /\.rounded(?![-\w])|aria-label="Select / },+ // `.rounded` is anchored with a boundary so it can't match every rounded-* utility. axe+ // emits the row-select buttons as a bare `button[aria-label="Select <name>"]` with no+ // parent path, so the label is the only available anchor — require the button tag at+ // least, rather than a bare `aria-label="Select ` that would also waive a non-button.+ { rule: 'target-size', target: /\.rounded(?![-\w])|button\[aria-label="Select / },],cassette: resourcesCassette,path: routes.resources,ready: (page) => page.getByRole('treeitem', { name: /reports/ }),- sources: ['src/pages/resources', 'src/features/resources', 'src/components/shared/file-manager'],+ // `src/features/resources` is left unowned deliberately: main-sidebar.tsx pulls its upload+ // hook into every route's shell, so any per-route listing under-reports the rest.+ sources: ['src/pages/resources', 'src/components/shared/file-manager'],},];diff --git a/frontend/e2e/specs/cross/a11y.spec.ts b/frontend/e2e/specs/cross/a11y.spec.tsindex 9e9fdb77..fb2539bd 100644--- a/frontend/e2e/specs/cross/a11y.spec.ts+++ b/frontend/e2e/specs/cross/a11y.spec.ts@@ -1,5 +1,7 @@import { expect, test } from '../../fixtures/test.ts';-import { scanA11y } from '../../helpers/a11y.ts';+import { scanA11y, waiversForScan } from '../../helpers/a11y.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { FILE_RESOURCE, resourcesCassette } from '../../mocks/cassettes/resources.ts';import { populatedSettingsProvidersCassette } from '../../mocks/cassettes/settings-providers.ts';import { loginJourneyCassette } from '../../mocks/cassettes/smoke.ts';import { ROUTE_MANIFEST } from '../../routes.ts';@@ -48,19 +50,66 @@ for (const theme of THEMES) {await expect(entry.ready(page)).toBeVisible();// Not redundant: a theme seed that silently stops applying reruns light under a dark label.await expect(page.locator('html')).toHaveClass(theme === 'dark' ? /dark/ : /light/);- await scanA11y(page, entry.path, entry.a11yWaivers);+ await scanA11y(page, entry.path, waiversForScan(entry.a11yWaivers));});for (const tab of entry.tabs ?? []) {- test(`tab "${tab}" has no axe violations`, async ({ page }) => {+ test(`tab "${tab.name}" has no axe violations`, async ({ page }) => {await page.goto(entry.path);await expect(entry.ready(page)).toBeVisible();await expect(page.locator('html')).toHaveClass(theme === 'dark' ? /dark/ : /light/);- await page.getByRole('tab', { name: tab }).click();- await scanA11y(page, `${entry.path} [${tab}]`, entry.a11yWaivers);+ await page.getByRole('tab', { name: tab.name }).click();+ await expect(tab.ready(page)).toBeVisible();+ await scanA11y(+ page,+ `${entry.path} [${tab.name}]`,+ waiversForScan(entry.a11yWaivers, tab.name),+ );});}});}});}++test.describe('dialog keyboard contract', { tag: '@cross' }, () => {+ test.use({ cassette: resourcesCassette() });++ // Closing a dialog must hand focus back to whatever opened it. Radix only does that for its own+ // DialogTrigger, and this app opens dialogs from controlled state, so without help focus lands on+ // <body> and a keyboard user starts again from the top of the page.+ test('Escape returns focus to the control that opened the dialog', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');++ const opener = page.getByRole('button', { name: 'New folder' });++ await opener.focus();+ await page.keyboard.press('Enter');+ await expect(page.getByRole('dialog')).toBeVisible();++ await page.keyboard.press('Escape');+ await expect(page.getByRole('dialog')).toBeHidden();++ await expect(opener).toBeFocused();+ expectCleanPage(pageErrorLog);+ });++ // The other dialog family: ConfirmationDialog renders its DialogContent unconditionally, so a+ // focus hook living on the wrapper would capture whatever had focus when the PAGE mounted and+ // restore it on navigation instead. This case is what tells the two apart.+ test('Escape returns focus for a dialog whose content is always mounted', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');+ await page.getByRole('checkbox', { name: `Select ${FILE_RESOURCE.name}` }).click();++ const opener = page.getByRole('button', { exact: true, name: 'Delete' });++ await opener.click();+ await expect(page.getByRole('dialog')).toBeVisible();++ await page.keyboard.press('Escape');+ await expect(page.getByRole('dialog')).toBeHidden();++ await expect(opener).toBeFocused();+ expectCleanPage(pageErrorLog);+ });+});diff --git a/frontend/e2e/specs/cross/contrast.spec.ts b/frontend/e2e/specs/cross/contrast.spec.tsindex 0c1756ca..1ec0dec5 100644--- a/frontend/e2e/specs/cross/contrast.spec.ts+++ b/frontend/e2e/specs/cross/contrast.spec.ts@@ -1,6 +1,7 @@import { readFileSync } from 'node:fs';import type { BadgeVariant } from '@/components/ui/badge';+import type { ButtonVariant } from '@/components/ui/button';import { badgeVariants } from '@/components/ui/badge';import { buttonVariants } from '@/components/ui/button';@@ -8,8 +9,39 @@ import { buttonVariants } from '@/components/ui/button';import type { EditorProbe } from '../../helpers/contrast.ts';import { expect, test } from '../../fixtures/test.ts';-import { AA_NORMAL, measureContrast, mountContrastProbes, mountEditorProbes } from '../../helpers/contrast.ts';+import {+ AA_NORMAL,+ measureContrast,+ measureContrastAt,+ mountContrastProbes,+ mountEditorProbes,+ mountFenceProbes,+} from '../../helpers/contrast.ts';import { flowsCassette } from '../../mocks/cassettes/flows.ts';+import { PROMPT_DETAIL_AGENT, promptDetailCassette } from '../../mocks/cassettes/settings-prompts.ts';++const HLJS_TOKENS = [+ 'hljs-comment',+ 'hljs-keyword',+ 'hljs-section',+ 'hljs-literal',+ 'hljs-string',+ 'hljs-attr',+ 'hljs-symbol',+ 'hljs-built_in',+];++const SYNTAX_TOKEN_CLASS: Record<string, string> = {+ 'editor-syntax-attr': 'hljs-attr',+ 'editor-syntax-class': 'hljs-built_in',+ 'editor-syntax-comment': 'hljs-comment',+ 'editor-syntax-entity': 'hljs-section',+ 'editor-syntax-fg': 'fence text',+ 'editor-syntax-keyword': 'hljs-keyword',+ 'editor-syntax-literal': 'hljs-literal',+ 'editor-syntax-string': 'hljs-string',+ 'editor-syntax-symbol': 'hljs-symbol',+};const EDITOR_PROBES = {'editor-accent': { tag: 'a' },@@ -25,7 +57,16 @@ const declaredEditorTokens = (): string[] => {return [...new Set(css.match(/--editor-[\w-]+/g) ?? [])].map((token) => token.slice(2));};-// Keyed off the union so a newly added variant fails to compile until it is probed.+// Keyed off the unions so a newly added variant fails to compile until it is probed.+const BUTTON_VARIANTS = Object.keys({+ default: true,+ destructive: true,+ ghost: true,+ link: true,+ outline: true,+ secondary: true,+} satisfies Record<ButtonVariant, true>) as ButtonVariant[];+const BADGE_VARIANTS = Object.keys({blue: true,default: true,@@ -46,12 +87,23 @@ test('every editor colour token is probed', { tag: '@cross' }, () => {const probed = new Set(Object.keys(EDITOR_PROBES));// A `-bg` token is the paired ground of its base probe, measured with it.const uncovered = declaredEditorTokens().filter(- (token) => !probed.has(token) && !(token.endsWith('-bg') && probed.has(token.slice(0, -3))),+ (token) =>+ !probed.has(token) &&+ !(token.endsWith('-bg') && probed.has(token.slice(0, -3))) &&+ !(token in SYNTAX_TOKEN_CLASS),);expect(uncovered).toEqual([]);});+test('every syntax token is measured through a mounted hljs class', { tag: '@cross' }, () => {+ const measured = new Set([...HLJS_TOKENS, 'fence text']);+ const declared = declaredEditorTokens().filter((token) => token.startsWith('editor-syntax-'));++ expect(declared.filter((token) => !measured.has(SYNTAX_TOKEN_CLASS[token] ?? ''))).toEqual([]);+ expect(declared.sort()).toEqual(Object.keys(SYNTAX_TOKEN_CLASS).sort());+});+for (const theme of THEMES) {test.describe(`contrast (${theme})`, { tag: '@cross' }, () => {test.use({ cassette: flowsCassette() });@@ -84,19 +136,26 @@ for (const theme of THEMES) {}});- test('the destructive button clears AA at rest and on hover', async ({ page }) => {+ test('every button variant clears AA at rest and on hover', async ({ page }) => {await page.goto('/flows');await expect(page.getByRole('row', { name: /E2E Alpha/ })).toBeVisible();await expect(page.locator('html')).toHaveClass(theme === 'dark' ? /dark/ : /light/);- await mountContrastProbes(page, { destructive: buttonVariants({ variant: 'destructive' }) });+ await mountContrastProbes(+ page,+ Object.fromEntries(BUTTON_VARIANTS.map((variant) => [variant, buttonVariants({ variant })])),+ );- expect.soft(await measureContrast(page, 'destructive'), 'button at rest').toBeGreaterThanOrEqual(AA_NORMAL);+ for (const variant of BUTTON_VARIANTS) {+ expect+ .soft(await measureContrast(page, variant), `button ${variant} at rest`)+ .toBeGreaterThanOrEqual(AA_NORMAL);- await page.locator('[data-contrast="destructive"]').hover();- expect- .soft(await measureContrast(page, 'destructive'), 'button on hover')- .toBeGreaterThanOrEqual(AA_NORMAL);+ await page.locator(`[data-contrast="${variant}"]`).hover();+ expect+ .soft(await measureContrast(page, variant), `button ${variant} on hover`)+ .toBeGreaterThanOrEqual(AA_NORMAL);+ }});test('editor highlight tokens clear AA on the editor surface', async ({ page }) => {@@ -113,4 +172,59 @@ for (const theme of THEMES) {}});});++ test.describe(`contrast in a code block (${theme})`, { tag: '@cross' }, () => {+ test.use({ cassette: promptDetailCassette() });++ if (theme === 'dark') {+ test.beforeEach(async ({ page }) => {+ await page.addInitScript(() => window.localStorage.setItem('theme', 'dark'));+ });+ }++ test('editor highlight tokens clear AA inside a fence', async ({ page }) => {+ await page.goto(`/settings/prompts/${PROMPT_DETAIL_AGENT}`);++ const fence = page.locator('.tiptap-content .ProseMirror pre');++ await expect(fence).toBeVisible();+ await expect(page.locator('html')).toHaveClass(theme === 'dark' ? /dark/ : /light/);++ // Resolve the token through a probe, not getPropertyValue: the minifier rewrites the authored+ // text (`oklch(0.94 …)` ships as `oklch(94% …)`), which never equals the computed colour.+ const surface = await page.evaluate(() => {+ const probe = document.createElement('div');++ probe.style.backgroundColor = 'var(--editor-code-bg)';+ document.body.append(probe);++ const resolved = getComputedStyle(probe).backgroundColor;++ probe.remove();++ return resolved;+ });++ expect(surface).not.toBe('');+ await expect(fence).toHaveCSS('background-color', surface);++ await mountFenceProbes(page, HLJS_TOKENS);++ for (const token of HLJS_TOKENS) {+ expect+ .soft(await measureContrast(page, token), `${token} inside a code block (${theme})`)+ .toBeGreaterThanOrEqual(AA_NORMAL);+ }++ for (const token of ['variable', 'tag'] as const) {+ await expect(fence.locator(`.template-${token}`).first()).toBeVisible();+ expect+ .soft(+ await measureContrastAt(page, `.tiptap-content .ProseMirror pre .template-${token}`),+ `editor-${token} inside a code block (${theme})`,+ )+ .toBeGreaterThanOrEqual(AA_NORMAL);+ }+ });+ });}diff --git a/frontend/e2e/specs/cross/palette.spec.ts b/frontend/e2e/specs/cross/palette.spec.tsindex c4ed6574..ac0d1a89 100644--- a/frontend/e2e/specs/cross/palette.spec.ts+++ b/frontend/e2e/specs/cross/palette.spec.ts@@ -1,9 +1,13 @@+import type { Page } from '@playwright/test';+import type { BadgeVariant } from '@/components/ui/badge';import { badgeVariants } from '@/components/ui/badge';import { buttonVariants } from '@/components/ui/button';+import { routes } from '@/lib/routes';import { expect, test } from '../../fixtures/test.ts';+import { populatedSettingsProvidersCassette } from '../../mocks/cassettes/settings-providers.ts';import { ROUTE_MANIFEST } from '../../routes.ts';const BADGE_VARIANTS = Object.keys({@@ -22,27 +26,88 @@ const BADGE_VARIANTS = Object.keys({const BUTTON_VARIANTS = ['default', 'destructive', 'ghost', 'link', 'outline', 'secondary'] as const;-const SANCTIONED = new Set(- [- ...BADGE_VARIANTS.map((variant) => badgeVariants({ variant })),- ...BUTTON_VARIANTS.map((variant) => buttonVariants({ variant })),- ]- .join(' ')- .split(/\s+/),-);--// A hard-coded hue (`text-green-800`, `bg-[#16a34a]`) rather than a semantic token-// (`bg-primary`, `text-muted-foreground`) or a non-colour utility (`text-xs`).+// A hard-coded colour (`text-green-800`, `bg-[#16a34a]`, `text-white`) rather than a semantic token+// (`bg-primary`, `text-muted-foreground`) or a non-colour utility (`text-xs`). white/black/transparent+// are absolute too: an overlay like `text-white` on a coloured badge is off-palette, not a token.const PALETTE_UTILITY =- /^(?:[a-z-]+:)*(?:bg|text|border|ring|from|via|to|fill|stroke|shadow|outline|decoration|divide|accent|caret|placeholder)-(?:\[[^\]]*\]|(?:slate|gray|zinc|neutral|stone|red|orange|amber|yellow|lime|green|emerald|teal|cyan|sky|blue|indigo|violet|purple|fuchsia|pink|rose)-\d{2,3}(?:\/\d{1,3})?)$/;+ /^(?:[a-z-]+:)*(?:bg|text|border|ring|from|via|to|fill|stroke|shadow|outline|decoration|divide|accent|caret|placeholder)-(?:white|black|transparent|\[[^\]]*\]|(?:slate|gray|zinc|neutral|stone|red|orange|amber|yellow|lime|green|emerald|teal|cyan|sky|blue|indigo|violet|purple|fuchsia|pink|rose)-\d{2,3})(?:\/\d{1,3})?$/;++/**+ * Per-variant, not one union: a flat union sanctions every variant's hue on every badge and button,+ * so the wrong-variant reuse this gate exists for reads as legal.+ */+const paletteTokensOf = (classes: string) => classes.split(/\s+/).filter((token) => PALETTE_UTILITY.test(token));++const SANCTIONED_VARIANTS = [+ ...BADGE_VARIANTS.map((variant) => ({+ slot: 'badge',+ tokens: paletteTokensOf(badgeVariants({ variant })),+ variant,+ })),+ ...BUTTON_VARIANTS.map((variant) => ({+ slot: 'button',+ tokens: paletteTokensOf(buttonVariants({ variant })),+ variant,+ })),+];-/** Off-palette colours already on the page, by route. Exact strings: they waive one node, not a rule. */+/**+ * Off-palette colours already on the page, keyed by scan surface. A route's default view is keyed by+ * its path; a tab panel by `${path} [${tab}]`. Exact strings: they waive one node, not a rule.+ */const ACCEPTED: Record<string, string[]> = {- // file-manager.tsx expand-all control; changing it moves pixels, so it goes with the design pass.+ // file-manager.tsx expand-all control, on /resources and embedded in the flow Files tab.'/resources': ['button: hover:text-blue-400'],+ [`${routes.flow('5')} [Files]`]: ['button: hover:text-blue-400'],};+const scanOffenders = (page: Page) =>+ page.evaluate(+ ({ pattern, variants }) => {+ const palette = new RegExp(pattern);++ return [...document.querySelectorAll('[data-slot="badge"],[data-slot="button"]')].flatMap((element) => {+ const slot = element.getAttribute('data-slot') ?? '';+ const used = [...element.classList].filter((token) => palette.test(token));++ if (!used.length) {+ return [];+ }++ // Equality, not containment: a single token borrowed from another variant is a+ // subset of that variant's set, so containment would wave through exactly the+ // wrong-variant reuse this gate exists to catch.+ const covered = variants.some(+ (candidate) =>+ candidate.slot === slot &&+ candidate.tokens.length === used.length &&+ used.every((token) => candidate.tokens.includes(token)),+ );++ return covered ? [] : used.map((token) => `${slot}: ${token}`);+ });+ },+ { pattern: PALETTE_UTILITY.source, variants: SANCTIONED_VARIANTS },+ );+test.describe('palette compliance', { tag: '@cross' }, () => {+ // The manifest sweeps this route with the empty seed, so the provider cards — the surface the+ // shipped badge defect actually lived on — render nowhere in the loop below. The a11y and visual+ // gates each carry the same dedicated populated sweep.+ test.describe('settings providers (populated)', () => {+ test.use({ cassette: populatedSettingsProvidersCassette() });++ test('provider cards carry no off-palette colour', async ({ page }) => {+ await page.goto(routes.settings.providers);+ await expect(page.getByText('My Custom Endpoint')).toBeVisible();++ const offenders = await scanOffenders(page);+ const key = `${routes.settings.providers} (populated)`;++ expect(offenders.sort(), `off-palette colours on ${key}`).toEqual([...(ACCEPTED[key] ?? [])].sort());+ });+ });+for (const entry of ROUTE_MANIFEST) {test.describe(entry.path, () => {test.use({ cassette: entry.cassette() });@@ -51,25 +116,30 @@ test.describe('palette compliance', { tag: '@cross' }, () => {await page.goto(entry.path);await expect(entry.ready(page)).toBeVisible();- const offenders = await page.evaluate(- ({ pattern, sanctioned }) => {- const palette = new RegExp(pattern);- const allowed = new Set(sanctioned);-- return [...document.querySelectorAll('[data-slot="badge"],[data-slot="button"]')].flatMap(- (element) =>- [...element.classList]- .filter((token) => palette.test(token) && !allowed.has(token))- .map((token) => `${element.getAttribute('data-slot')}: ${token}`),- );- },- { pattern: PALETTE_UTILITY.source, sanctioned: [...SANCTIONED] },+ const offenders = await scanOffenders(page);++ expect(offenders.sort(), `off-palette colours on ${entry.path}`).toEqual(+ [...(ACCEPTED[entry.path] ?? [])].sort(),);+ });- const accepted = ACCEPTED[entry.path] ?? [];+ // Tabs mount their panels lazily (Radix unmounts inactive ones), so the default-view scan+ // above never sees them — sweep each panel like the a11y gate does.+ for (const tab of entry.tabs ?? []) {+ test(`tab "${tab.name}" carries no off-palette colour`, async ({ page }) => {+ await page.goto(entry.path);+ await expect(entry.ready(page)).toBeVisible();+ await page.getByRole('tab', { name: tab.name }).click();+ await expect(tab.ready(page)).toBeVisible();- expect([...new Set(offenders)], `off-palette colours on ${entry.path}`).toEqual(accepted);- });+ const offenders = await scanOffenders(page);+ const key = `${entry.path} [${tab.name}]`;++ expect(offenders.sort(), `off-palette colours on ${key}`).toEqual(+ [...(ACCEPTED[key] ?? [])].sort(),+ );+ });+ }});}});diff --git a/frontend/e2e/specs/cross/responsive.spec.ts b/frontend/e2e/specs/cross/responsive.spec.tsindex 8d47f23b..4f29b24a 100644--- a/frontend/e2e/specs/cross/responsive.spec.ts+++ b/frontend/e2e/specs/cross/responsive.spec.ts@@ -37,6 +37,22 @@ test.describe('responsive', { tag: '@cross' }, () => {});});+ test.describe('sidebar boundary', () => {+ test('768 keeps the sidebar inline, 767 collapses it to the mobile sheet', async ({ page, pageErrorLog }) => {+ await page.setViewportSize({ height: 800, width: 768 });+ await page.goto('/flows');+ await expect(page.getByRole('link', { name: 'Dashboard' })).toBeVisible();++ await page.setViewportSize({ height: 800, width: 767 });+ // `hidden md:block` hides the desktop tree either way, so its absence — the closed mobile+ // sheet renders nothing — is the only reading that tells the hook's answer from the CSS.+ await expect(page.locator('[data-sidebar="sidebar"]')).toHaveCount(0);+ await expect(page.getByRole('link', { name: 'Dashboard' })).toBeHidden();+ expect(await page.evaluate(hasHorizontalOverflow)).toBe(false);+ expectCleanPage(pageErrorLog);+ });+ });+test.describe('split boundary', () => {test('1280 shows the resizable split, 1279 merges into one tab row', async ({ page, pageErrorLog }) => {await page.setViewportSize({ height: 800, width: 1280 });diff --git a/frontend/e2e/specs/cross/session-expiry.spec.ts b/frontend/e2e/specs/cross/session-expiry.spec.tsnew file mode 100644index 00000000..007a4080--- /dev/null+++ b/frontend/e2e/specs/cross/session-expiry.spec.ts@@ -0,0 +1,143 @@+import type { Page } from '@playwright/test';++import type { Cassette } from '../../mocks/cassette.ts';++import { authenticatedInfoEntry, guestInfoEntry } from '../../fixtures/auth.ts';+import { expect, test } from '../../fixtures/test.ts';+import { baseQueries, baseRest } from '../../mocks/cassettes/base.ts';+import { flowsCassette } from '../../mocks/cassettes/flows.ts';++const EXPIRED = 'session-expired';++const infoTurningGuest = (): Cassette['rest'] => ({+ 'GET /api/v1/info': [authenticatedInfoEntry(), { ...guestInfoEntry(), whenFlag: EXPIRED }],+});++const storedUser = (page: Page) =>+ page.evaluate(() => JSON.parse(window.localStorage.getItem('auth') ?? 'null')?.user ?? null);++test.describe('session expiry', { tag: '@cross' }, () => {+ // A private endpoint answers an expired session with 403 + code AuthRequired, never 401 — pinning+ // 401 here would drive an interceptor branch production never reaches.+ test.describe('a REST 403', () => {+ test.use({+ cassette: {+ queries: baseQueries(),+ rest: {+ ...baseRest(),+ ...infoTurningGuest(),+ 'GET /api/v1/resources/': [+ {+ body: { code: 'AuthRequired', msg: 'auth required', status: 'error' },+ setFlag: EXPIRED,+ status: 403,+ },+ ],+ },+ },+ });++ test('bounces to the login page with a way back and drops the stored session', async ({ page }) => {+ const rejected: string[] = [];++ page.on('request', (request) => {+ if (new URL(request.url()).pathname === '/api/v1/resources/') {+ rejected.push(request.url());+ }+ });++ await page.goto('/resources');++ await expect(page).toHaveURL(/\/login\?returnUrl=%2Fresources/);+ await expect(page.getByRole('button', { name: 'Sign in' })).toBeVisible();+ // The login page's own /info rewrites the key, so only the identity inside it matters.+ expect(await storedUser(page), 'the expired identity must not survive in storage').toBeNull();++ // A login page that kept honouring the return URL would land back on the 403 and loop.+ expect(rejected, 'the rejected endpoint is called once').toHaveLength(1);+ });+ });++ // `/api/v1/graphql` is registered on the same private group as the REST endpoints, so an expired+ // session is refused by the middleware and gqlgen never runs: the client sees a transport 403+ // carrying the REST error body, not a GraphQL `errors` array.+ test.describe('a GraphQL 403', () => {+ test.use({+ cassette: flowsCassette({+ queries: {+ flows: [+ {+ body: { code: 'AuthRequired', msg: 'auth required', status: 'error' },+ setFlag: EXPIRED,+ status: 403,+ },+ ],+ },+ rest: { ...baseRest(), ...infoTurningGuest() },+ }),+ });++ test('re-checks the session and sends the operator to login', async ({ page }) => {+ await page.goto('/flows');++ await expect(page).toHaveURL(/\/login\?returnUrl=%2Fflows/);+ await expect(page.getByRole('button', { name: 'Sign in' })).toBeVisible();+ });+ });++ test.describe('a GraphQL auth error', () => {+ test.use({+ cassette: flowsCassette({+ queries: { flows: [{ errors: [{ message: 'auth required' }], setFlag: EXPIRED }] },+ rest: { ...baseRest(), ...infoTurningGuest() },+ }),+ });++ test('re-checks the session on an auth-worded resolver error too', async ({ page }) => {+ await page.goto('/flows');++ await expect(page).toHaveURL(/\/login\?returnUrl=%2Fflows/);+ await expect(page.getByRole('button', { name: 'Sign in' })).toBeVisible();+ });+ });++ test.describe('the interceptor itself', () => {+ test.use({+ cassette: {+ queries: baseQueries(),+ rest: {+ ...baseRest(),+ // The login page re-reads /info and would write the key back; failing that read is+ // the only way to observe what the interceptor left behind.+ 'GET /api/v1/info': [+ authenticatedInfoEntry(),+ { body: { code: 'Internal', status: 'error' }, status: 500, whenFlag: EXPIRED },+ ],+ 'GET /api/v1/resources/': [+ {+ body: { code: 'AuthRequired', msg: 'auth required', status: 'error' },+ setFlag: EXPIRED,+ status: 403,+ },+ ],+ },+ },+ });++ test('clears the stored session outright, not just its user', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');++ await expect(page).toHaveURL(/\/login/);+ expect(+ await page.evaluate(() => window.localStorage.getItem('auth')),+ 'the key is removed, not overwritten',+ ).toBeNull();++ expect(pageErrorLog.pageErrors, 'no uncaught page errors').toEqual([]);+ expect(+ pageErrorLog.consoleErrors.filter((text) => !/403|500/.test(text)),+ 'only the rejected requests are logged',+ ).toEqual([]);+ });+ });+});diff --git a/frontend/e2e/specs/cross/themes.spec.ts b/frontend/e2e/specs/cross/themes.spec.tsindex c3e916d3..743f9201 100644--- a/frontend/e2e/specs/cross/themes.spec.ts+++ b/frontend/e2e/specs/cross/themes.spec.ts@@ -1,8 +1,12 @@+import type { Page } from '@playwright/test';+import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';-import { MESSAGE_ID_TESTID } from '../../helpers/subscriptions.ts';+import { MESSAGE_ID_SELECTOR } from '../../helpers/subscriptions.ts';import { flowsCassette } from '../../mocks/cassettes/flows.ts';+const storedTheme = (page: Page) => page.evaluate(() => window.localStorage.getItem('theme'));+test.describe('themes', { tag: '@cross' }, () => {test.use({ cassette: flowsCassette() });@@ -12,12 +16,15 @@ test.describe('themes', { tag: '@cross' }, () => {await page.getByRole('row', { name: /E2E Alpha/ }).click();await expect(page.locator('html')).toHaveClass(/dark/);- await expect(page.getByTestId(MESSAGE_ID_TESTID).first()).toBeVisible();+ await expect(page.locator(MESSAGE_ID_SELECTOR).first()).toBeVisible();await expect(page.locator('.xterm')).toBeVisible();expectCleanPage(pageErrorLog);});- test('switches themes from the sidebar user menu', async ({ page, pageErrorLog }) => {+ test('switches themes from the sidebar user menu, and the pick outlives the page', async ({+ page,+ pageErrorLog,+ }) => {await page.goto('/flows');await expect(page.locator('html')).toHaveClass(/light/);@@ -25,9 +32,18 @@ test.describe('themes', { tag: '@cross' }, () => {await page.getByRole('button', { name: /admin@pentagi\.com/ }).click();await page.getByRole('tab', { name: 'Dark theme' }).click();await expect(page.locator('html')).toHaveClass(/dark/);+ expect(await storedTheme(page), 'the pick is written, not only applied to the live document').toBe('dark');++ await page.reload();+ await expect(page.locator('html'), 'the reloaded page starts dark').toHaveClass(/dark/);+ await page.getByRole('button', { name: /admin@pentagi\.com/ }).click();await page.getByRole('tab', { name: 'Light theme' }).click();await expect(page.locator('html')).toHaveClass(/light/);+ expect(await storedTheme(page)).toBe('light');++ await page.reload();+ await expect(page.locator('html'), 'the reloaded page starts light').toHaveClass(/light/);expectCleanPage(pageErrorLog);});});diff --git a/frontend/e2e/specs/crud/api-tokens.spec.ts b/frontend/e2e/specs/crud/api-tokens.spec.tsindex 9953bac9..d4d56f36 100644--- a/frontend/e2e/specs/crud/api-tokens.spec.ts+++ b/frontend/e2e/specs/crud/api-tokens.spec.ts@@ -2,6 +2,7 @@ import type { ResultOf } from '@graphql-typed-document-node/core';import type { CreateApiTokenDocument, DeleteApiTokenDocument } from '@/graphql/types';+import { CASSETTE_EPOCH } from '../../fixtures/backend.ts';import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';import {@@ -40,6 +41,10 @@ test.describe('api tokens crud', { tag: '@crud' }, () => {}),});+ // The picker's date and the pinned clock together fix what the form must put on the wire.+ const EXPIRES_AT = new Date('2026-01-20T00:00:00Z');+ const EXPECTED_TTL = Math.ceil((EXPIRES_AT.getTime() - CASSETTE_EPOCH.getTime()) / 1000);+test('creates a token through the inline row and reveals the secret', async ({ page, pageErrorLog }) => {await page.goto('/settings/api-tokens');@@ -57,8 +62,21 @@ test.describe('api tokens crud', { tag: '@crud' }, () => {await page.keyboard.press('Escape');await expect(submit).toBeEnabled();++ // The cassette cannot pin a clock-derived value, so the expiry the operator picked is+ // asserted on the request itself: without this the mutation matches with any ttl at all,+ // including the 60s floor a broken calculateTTL would send.+ const createRequest = page.waitForRequest(+ (request) => request.method() === 'POST' && request.postDataJSON()?.operationName === 'createAPIToken',+ );+await submit.click();+ const { variables } = (await createRequest).postDataJSON();++ expect(variables.input.ttl).toBeLessThanOrEqual(EXPECTED_TTL);+ expect(variables.input.ttl).toBeGreaterThan(EXPECTED_TTL - 1_000);+const dialog = page.getByRole('dialog');await expect(dialog.getByText('API Token Created')).toBeVisible();diff --git a/frontend/e2e/specs/crud/knowledges.spec.ts b/frontend/e2e/specs/crud/knowledges.spec.tsindex daf0da8e..56099557 100644--- a/frontend/e2e/specs/crud/knowledges.spec.ts+++ b/frontend/e2e/specs/crud/knowledges.spec.ts@@ -12,7 +12,12 @@ import { ResultType } from '@/graphql/types';import { expect, test } from '../../fixtures/test.ts';import { typeIntoEditor } from '../../helpers/editor.ts';import { expectCleanPage } from '../../helpers/errors.ts';-import { KNOWLEDGE_DOC, knowledgesCassette, makeKnowledge } from '../../mocks/cassettes/knowledges.ts';+import {+ KNOWLEDGE_DOC,+ knowledgeDetailCassette,+ knowledgesCassette,+ makeKnowledge,+} from '../../mocks/cassettes/knowledges.ts';const openNewKnowledgeForm = async (page: Page) => {await page.goto('/knowledges');@@ -122,4 +127,103 @@ test.describe('knowledges crud', { tag: '@crud' }, () => {expectCleanPage(pageErrorLog);});});++ // A real load failure on the detail route used to be mislabelled "not found" and bounced to+ // the list with no way back in; it must keep the user on the route behind Retry instead.+ test.describe('detail load failure', () => {+ test.use({+ cassette: knowledgesCassette({+ queries: { knowledgeDocument: [{ errors: [{ message: 'e2e induced load failure' }] }] },+ }),+ });++ test('shows an in-page error with Retry, not a bounce to the list', async ({ page }) => {+ await page.goto(`/knowledges/${KNOWLEDGE_DOC.id}`);++ await expect(page.getByRole('button', { name: 'Try again' })).toBeVisible();+ await expect(page).toHaveURL(new RegExp(`/knowledges/${KNOWLEDGE_DOC.id}$`));+ });+ });++ // The backend authz denial (graph/context.go) contains "not found", so a naive match would+ // mistake it for a missing record and bounce a user who merely lacks access.+ test.describe('detail authz denial', () => {+ test.use({+ cassette: knowledgesCassette({+ queries: {+ knowledgeDocument: [{ errors: [{ message: "requested permission 'knowledge.read' not found" }] }],+ },+ }),+ });++ test('does not bounce a permission denial to the list', async ({ page }) => {+ await page.goto(`/knowledges/${KNOWLEDGE_DOC.id}`);++ await expect(page.getByRole('button', { name: 'Try again' })).toBeVisible();+ await expect(page).toHaveURL(new RegExp(`/knowledges/${KNOWLEDGE_DOC.id}$`));+ });+ });++ test.describe('save', () => {+ test.use({+ cassette: knowledgesCassette({+ mutations: {+ updateKnowledgeDocument: [{ data: { updateKnowledgeDocument: KNOWLEDGE_DOC } as never }],+ },+ queries: {+ knowledgeDocument: [+ { data: { knowledgeDocument: KNOWLEDGE_DOC }, variables: { id: KNOWLEDGE_DOC.id } },+ ],+ },+ }),+ });++ // The write half of the editor: until now the suite proved the document loads and round-trips+ // in memory, never that Save puts the edited bytes on the wire.+ test('Save sends the edited content and keeps the document id', async ({ page, pageErrorLog }) => {+ await page.goto(`/knowledges/${KNOWLEDGE_DOC.id}`);++ await typeIntoEditor(page, 'Content', 'E2E-SAVE-MARK');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' &&+ candidate.postDataJSON()?.operationName === 'updateKnowledgeDocument',+ );++ await page.getByRole('button', { exact: true, name: 'Save' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.id).toBe(KNOWLEDGE_DOC.id);+ expect(variables.input.content).toContain('E2E-SAVE-MARK');+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('detail header', () => {+ test.use({ cassette: knowledgeDetailCassette() });++ test('keeps the pager left of save and the actions menu', async ({ page }) => {+ await page.goto(`/knowledges/${KNOWLEDGE_DOC.id}`);+ await expect(page.getByRole('button', { name: 'Knowledge actions' })).toBeVisible();++ const labels = await page+ .locator('header button')+ .evaluateAll((buttons) =>+ buttons.map((button) => button.getAttribute('aria-label') ?? button.textContent),+ );+ const positionOf = (label: string) => labels.findIndex((candidate) => (candidate ?? '').includes(label));++ // findIndex returns -1 for an absent label, and -1 < any real index, so the ordering below+ // passes vacuously when a button is missing. Require presence first.+ for (const label of ['Save', 'Previous', 'Next', 'Knowledge actions']) {+ expect(positionOf(label), `header is missing the "${label}" button`).toBeGreaterThanOrEqual(0);+ }++ expect(positionOf('Previous')).toBeLessThan(positionOf('Save'));+ expect(positionOf('Next')).toBeLessThan(positionOf('Save'));+ expect(positionOf('Save')).toBeLessThan(positionOf('Knowledge actions'));+ });+ });});diff --git a/frontend/e2e/specs/crud/resources-upload.spec.ts b/frontend/e2e/specs/crud/resources-upload.spec.tsnew file mode 100644index 00000000..55f06da2--- /dev/null+++ b/frontend/e2e/specs/crud/resources-upload.spec.ts@@ -0,0 +1,134 @@+import type { Page } from '@playwright/test';++import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { resourcesCassette, UPLOADED_FRAGMENT, UPLOADED_RESOURCE } from '../../mocks/cassettes/resources.ts';++const UPLOAD_ENDPOINT = '/api/v1/resources/';++const pickFiles = (page: Page, files: Array<{ buffer: Buffer; mimeType: string; name: string }>) =>+ // The sidebar's quick-upload mounts an input of its own; this is the library page's.+ page.locator('main input[name="resource-upload"]').setInputFiles(files);++const textFile = (name: string, body: string) => ({+ buffer: Buffer.from(body),+ mimeType: 'text/plain',+ name,+});++test.describe('resources upload', { tag: '@crud' }, () => {+ test.describe('accepted', () => {+ test.use({+ cassette: resourcesCassette({+ rest: {+ 'POST /api/v1/resources/': [+ {+ body: { data: { items: [UPLOADED_RESOURCE], total: 1 }, status: 'success' },+ setFlag: 'resource-uploaded',+ },+ ],+ },+ subscriptions: {+ resourceAdded: [+ {+ frames: [+ {+ payload: { data: { resourceAdded: UPLOADED_FRAGMENT } },+ whenFlag: 'resource-uploaded',+ },+ ],+ },+ ],+ },+ }),+ });++ test('sends the picked file as multipart and shows it in the library', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');+ await expect(page.getByRole('treeitem', { name: /notes\.txt/ })).toBeVisible();++ const posted = page.waitForRequest(+ (request) => request.method() === 'POST' && new URL(request.url()).pathname === UPLOAD_ENDPOINT,+ );++ await pickFiles(page, [textFile(UPLOADED_RESOURCE.name, 'e2e upload payload')]);++ const body = (await posted).postData() ?? '';++ expect((await posted).headers()['content-type']).toMatch(/^multipart\/form-data; boundary=/);+ // The field name is the contract with the Go handler: rename it and the server sees+ // an upload with no files at all.+ expect(body).toContain('name="files"');+ expect(body).toContain(`filename="${UPLOADED_RESOURCE.name}"`);+ expect(body).toContain('e2e upload payload');++ await expect(page.getByText('File uploaded')).toBeVisible();+ await expect(page.getByRole('treeitem', { name: new RegExp(UPLOADED_RESOURCE.name) })).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('a zero-byte file', () => {+ test.use({+ cassette: resourcesCassette({+ rest: {+ 'POST /api/v1/resources/': [+ { body: { data: { items: [UPLOADED_RESOURCE], total: 1 }, status: 'success' } },+ ],+ },+ }),+ });++ // The Go handler bounds a part only from above (UploadResources rejects fh.Size over the cap,+ // never a zero one), so refusing an empty file here would make `.gitkeep` unuploadable through+ // the UI while the API accepts it.+ test('reaches the wire like any other', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');+ await expect(page.getByRole('treeitem', { name: /notes\.txt/ })).toBeVisible();++ const posted = page.waitForRequest(+ (request) => request.method() === 'POST' && new URL(request.url()).pathname === UPLOAD_ENDPOINT,+ );++ await pickFiles(page, [textFile('hollow.txt', '')]);++ expect((await posted).postData() ?? '').toContain('filename="hollow.txt"');+ await expect(page.getByText('is empty')).toHaveCount(0);+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('refused by the backend', () => {+ test.use({+ cassette: resourcesCassette({+ rest: {+ 'POST /api/v1/resources/': [+ {+ // The Go response layer writes `msg` on every error, so this copy — not the+ // client's own 409 fallback — is what an operator reads.+ body: {+ code: 'Resources.AlreadyExists',+ msg: 'resource already exists',+ status: 'error',+ },+ status: 409,+ },+ ],+ },+ }),+ });++ test('a name clash is explained instead of failing silently', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');+ await expect(page.getByRole('treeitem', { name: /notes\.txt/ })).toBeVisible();++ await pickFiles(page, [textFile('notes.txt', 'same name, new bytes')]);++ await expect(page.getByText('Upload failed')).toBeVisible();+ await expect(page.getByText('resource already exists', { exact: true })).toBeVisible();++ expect(pageErrorLog.pageErrors, 'no uncaught page errors').toEqual([]);+ expect(pageErrorLog.consoleErrors.filter((text) => !text.includes('409'))).toEqual([]);+ });+ });+});diff --git a/frontend/e2e/specs/crud/resources.spec.ts b/frontend/e2e/specs/crud/resources.spec.tsindex e16bbe33..ae33e0a1 100644--- a/frontend/e2e/specs/crud/resources.spec.ts+++ b/frontend/e2e/specs/crud/resources.spec.ts@@ -1,10 +1,25 @@import type { ResultOf } from '@graphql-typed-document-node/core';+import type { Page } from '@playwright/test';import type { ResourceAddedDocument } from '@/graphql/types';import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';-import { CREATED_FOLDER, emptyResourcesCassette, resourcesCassette } from '../../mocks/cassettes/resources.ts';+import {+ COPY_DESTINATION,+ CREATED_FOLDER,+ emptyResourcesCassette,+ FILE_RESOURCE,+ FOLDER_RESOURCE,+ RENAMED_PATH,+ resourcesCassette,+ resourceWrites,+} from '../../mocks/cassettes/resources.ts';++interface DownloadClick {+ download: string;+ href: string;+}test.describe('resources', { tag: '@coverage' }, () => {test.describe('listing', () => {@@ -72,6 +87,170 @@ test.describe('resources', { tag: '@coverage' }, () => {await page.goto('/resources');await expect(page.getByText('No resources yet')).toBeVisible();+ // Scope to the drop zone (its hint is unique) so the toolbar's Upload button is excluded.+ const dropZone = page.locator('div').filter({ hasText: 'Up to 300 MB per file' }).last();++ await expect(dropZone.getByRole('button', { name: 'Upload files' })).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ // Every write here is a different verb on a path that also serves the SPA: a wrong method answers+ // 200 with HTML instead of 404, so these tests pin the method and the payload, not just the toast.+ test.describe('write verbs', () => {+ test.use({ cassette: resourcesCassette({ rest: resourceWrites() }) });++ const rowActions = (page: Page, name: string) =>+ page.getByRole('treeitem', { name: new RegExp(name) }).getByRole('button', { name: 'Row actions' });++ test('rename issues a PUT to /resources/move carrying the typed destination', async ({+ page,+ pageErrorLog,+ }) => {+ await page.goto('/resources');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'PUT' && new URL(candidate.url()).pathname === '/api/v1/resources/move',+ );++ await rowActions(page, FILE_RESOURCE.name).click();+ await page.getByRole('menuitem', { name: 'Rename or move' }).click();++ const dialog = page.getByRole('dialog');++ await dialog.getByLabel('New path').fill(RENAMED_PATH);+ await dialog.getByRole('button', { exact: true, name: 'Move' }).click();++ expect((await request).postDataJSON()).toMatchObject({+ destination: RENAMED_PATH,+ sources: [FILE_RESOURCE.path],+ });+ expectCleanPage(pageErrorLog);+ });++ test('copy issues a POST to /resources/copy', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' && new URL(candidate.url()).pathname === '/api/v1/resources/copy',+ );++ await rowActions(page, FILE_RESOURCE.name).click();+ await page.getByRole('menuitem', { name: 'Copy to…' }).click();++ const dialog = page.getByRole('dialog');++ await dialog.getByLabel('Destination path').fill(COPY_DESTINATION);+ await dialog.getByRole('button', { exact: true, name: 'Copy' }).click();++ expect((await request).postDataJSON()).toMatchObject({+ destination: COPY_DESTINATION,+ sources: [FILE_RESOURCE.path],+ });+ expectCleanPage(pageErrorLog);+ });++ // Copying onto an existing name must stop at a confirmation instead of overwriting silently:+ // the request may not leave until the user takes the second decision.+ test('a colliding destination raises the replace guard before any request', async ({ page }) => {+ await page.goto('/resources');++ let copyRequests = 0;++ page.on('request', (candidate) => {+ if (new URL(candidate.url()).pathname === '/api/v1/resources/copy') {+ copyRequests += 1;+ }+ });++ await rowActions(page, FILE_RESOURCE.name).click();+ await page.getByRole('menuitem', { name: 'Copy to…' }).click();+ await page.getByRole('dialog').getByLabel('Destination path').fill(FOLDER_RESOURCE.name);+ await page.getByRole('dialog').getByRole('button', { exact: true, name: 'Copy' }).click();++ await expect(page.getByRole('dialog', { name: 'Replace existing item?' })).toBeVisible();+ expect(copyRequests, 'nothing is sent while the guard is open').toBe(0);++ await page.getByRole('button', { name: 'Cancel' }).click();+ expect(copyRequests, 'cancelling the guard sends nothing at all').toBe(0);+ });++ test('delete issues a DELETE whose query carries the row path', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'DELETE' && new URL(candidate.url()).pathname === '/api/v1/resources/',+ );++ await rowActions(page, FILE_RESOURCE.name).click();+ await page.getByRole('menuitem', { name: 'Delete' }).click();+ await page.getByRole('dialog').getByRole('button', { exact: true, name: 'Delete' }).click();++ expect(new URL((await request).url()).searchParams.getAll('paths[]')).toEqual([FILE_RESOURCE.path]);+ expectCleanPage(pageErrorLog);+ });++ // An `<a download>` transfer is carried out by the browser outside the page, so no Playwright+ // route — page- or context-scoped — is ever offered it: one started here leaves for whatever+ // the preview proxy targets. The bytes are asserted in specs/real/resources-download.spec.ts.+ test('the row download action links at the row, saved under its name', async ({ page, pageErrorLog }) => {+ await page.goto('/resources');+ await rowActions(page, FILE_RESOURCE.name).click();++ const link = page.getByRole('menuitem', { name: 'Download' });++ await expect(link).toHaveAttribute('download', FILE_RESOURCE.name);++ const href = new URL((await link.getAttribute('href')) ?? '', page.url());++ expect(href.pathname).toBe('/api/v1/resources/download');+ expect(href.searchParams.getAll('paths[]')).toEqual([FILE_RESOURCE.path]);+ expectCleanPage(pageErrorLog);+ });++ // Multi-select is a different code path: one transfer carrying every selected path, saved+ // under an archive name. Neither is derivable from the single-row case.+ test('the bulk action asks for every selected path in one archive', async ({ page, pageErrorLog }) => {+ // Its anchor is created, clicked and dropped inside one handler, so nothing survives in+ // the DOM to read — record the click and swallow it instead of starting a transfer.+ await page.addInitScript(() => {+ const recorded: DownloadClick[] = [];++ (window as unknown as { e2eDownloads: DownloadClick[] }).e2eDownloads = recorded;++ const { click } = HTMLAnchorElement.prototype;++ HTMLAnchorElement.prototype.click = function (this: HTMLAnchorElement) {+ if (!this.hasAttribute('download')) {+ click.call(this);++ return;+ }++ recorded.push({ download: this.download, href: this.href });+ };+ });+ await page.goto('/resources');+ await page.getByRole('checkbox', { name: `Select ${FILE_RESOURCE.name}` }).click();+ await page.getByRole('checkbox', { name: `Select ${FOLDER_RESOURCE.name}` }).click();+ await page.getByRole('button', { exact: true, name: 'Download' }).click();++ const clicks = await page.evaluate(+ () => (window as unknown as { e2eDownloads: DownloadClick[] }).e2eDownloads,+ );++ expect(clicks, 'one transfer for the whole selection').toHaveLength(1);++ const { download, href } = clicks[0]!;++ expect(new URL(href).pathname).toBe('/api/v1/resources/download');+ expect(new URL(href).searchParams.getAll('paths[]').sort()).toEqual(+ [FILE_RESOURCE.path, FOLDER_RESOURCE.path].sort(),+ );+ expect(download).toMatch(/\.zip$/);expectCleanPage(pageErrorLog);});});diff --git a/frontend/e2e/specs/crud/template-detail.spec.ts b/frontend/e2e/specs/crud/template-detail.spec.tsindex 39ec9403..7cbe1db0 100644--- a/frontend/e2e/specs/crud/template-detail.spec.ts+++ b/frontend/e2e/specs/crud/template-detail.spec.ts@@ -5,7 +5,13 @@ import { expectCleanPage } from '../../helpers/errors.ts';import { RICH_TEMPLATE_TEXT, TEMPLATE_DETAIL, templateDetailCassette } from '../../mocks/cassettes/templates.ts';test.describe('template detail', { tag: '@coverage' }, () => {- test.use({ cassette: templateDetailCassette() });+ test.use({+ cassette: templateDetailCassette({+ mutations: {+ updateFlowTemplate: [{ data: { updateFlowTemplate: TEMPLATE_DETAIL } as never }],+ },+ }),+ });const EDITOR = 'Template content';@@ -16,7 +22,7 @@ test.describe('template detail', { tag: '@coverage' }, () => {await page.keyboard.press('Escape');};- test('keeps the pager between save and the actions menu', async ({ page }) => {+ test('keeps the pager left of save and the actions menu', async ({ page }) => {await page.goto(`/templates/${TEMPLATE_DETAIL.id}`);await expect(page.getByRole('button', { name: 'Template actions' })).toBeVisible();@@ -25,8 +31,15 @@ test.describe('template detail', { tag: '@coverage' }, () => {.evaluateAll((buttons) => buttons.map((button) => button.getAttribute('aria-label') ?? button.textContent));const positionOf = (label: string) => labels.findIndex((candidate) => (candidate ?? '').includes(label));- expect(positionOf('Save')).toBeLessThan(positionOf('Previous'));- expect(positionOf('Next')).toBeLessThan(positionOf('Template actions'));+ // findIndex returns -1 for an absent label, and -1 < any real index, so the ordering below+ // passes vacuously when a button is missing. Require presence first.+ for (const label of ['Save', 'Previous', 'Next', 'Template actions']) {+ expect(positionOf(label), `header is missing the "${label}" button`).toBeGreaterThanOrEqual(0);+ }++ expect(positionOf('Previous')).toBeLessThan(positionOf('Save'));+ expect(positionOf('Next')).toBeLessThan(positionOf('Save'));+ expect(positionOf('Save')).toBeLessThan(positionOf('Template actions'));});test('loads the template body into the editor byte-exact', async ({ page, pageErrorLog }) => {@@ -66,4 +79,54 @@ test.describe('template detail', { tag: '@coverage' }, () => {expect(raw).toContain('E2E-MARK');expectCleanPage(pageErrorLog);});++ // A real load failure must offer Retry in place, not the "Template not found" card that a+ // genuine 404 shows — the two used to collapse into the same dead-end.++ // Save is the only operation that can destroy a user's template, and no spec has ever let it reach+ // the wire — the round-trip units stop at the editor boundary.+ test('Save sends the edited body verbatim, placeholders intact', async ({ page, pageErrorLog }) => {+ await page.goto(`/templates/${TEMPLATE_DETAIL.id}`);++ const editor = page.getByRole('textbox', { name: EDITOR });++ await expect(editor.getByRole('heading', { name: 'Recon' })).toBeVisible();+ await editor.click();+ await page.keyboard.press('ControlOrMeta+End');+ await editor.pressSequentially(' E2E-SAVE-MARK');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === 'updateFlowTemplate',+ );++ await page.getByRole('button', { exact: true, name: 'Save' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.templateId).toBe(TEMPLATE_DETAIL.id);+ expect(variables.input.text).toContain('E2E-SAVE-MARK');++ for (const atom of ['# Recon', '{{TARGET}}', 'nmap -sV']) {+ expect(variables.input.text, `"${atom}" survived the save`).toContain(atom);+ }++ expectCleanPage(pageErrorLog);+ });++ test.describe('load failure', () => {+ test.use({+ cassette: templateDetailCassette({+ queries: { flowTemplate: [{ errors: [{ message: 'e2e induced load failure' }] }] },+ }),+ });++ test('shows an in-page error with Retry, not "not found"', async ({ page }) => {+ await page.goto(`/templates/${TEMPLATE_DETAIL.id}`);++ await expect(page.getByRole('button', { name: 'Try again' })).toBeVisible();+ await expect(page.getByText('Template not found')).toBeHidden();+ await expect(page).toHaveURL(new RegExp(`/templates/${TEMPLATE_DETAIL.id}$`));+ });+ });});diff --git a/frontend/e2e/specs/dashboard/dashboard.spec.ts b/frontend/e2e/specs/dashboard/dashboard.spec.tsindex 66c2c2bd..b34d9c1c 100644--- a/frontend/e2e/specs/dashboard/dashboard.spec.ts+++ b/frontend/e2e/specs/dashboard/dashboard.spec.ts@@ -26,8 +26,12 @@ test.describe('dashboard', { tag: '@coverage' }, () => {test('overview tab loads lazily and renders metrics and usage tables', async ({ page, pageErrorLog }) => {await page.goto('/dashboard');- // Lazy: the overview metrics are not mounted while the Analytics tab is active.- await expect(page.getByRole('heading', { exact: true, name: 'Total Flows' })).toBeHidden();+ // The route is lazy, so this must wait for the Analytics panel first: a bare negative+ // assert is satisfied by "nothing has rendered yet" and can never fail.+ await expect(page.getByRole('heading', { name: 'Flows Activity Over Time' })).toBeVisible();+ // not.toBeAttached, not toBeHidden — the latter also passes for a mounted-but-hidden node,+ // so it would not catch the panel being eagerly mounted (all its queries firing).+ await expect(page.getByRole('heading', { exact: true, name: 'Total Flows' })).not.toBeAttached();await page.getByRole('tab', { name: 'Overview' }).click();for (const title of ['Total Flows', 'Tool Calls', 'Total Tokens', 'Total Cost']) {diff --git a/frontend/e2e/specs/flows/assistants.spec.ts b/frontend/e2e/specs/flows/assistants.spec.tsnew file mode 100644index 00000000..5e667263--- /dev/null+++ b/frontend/e2e/specs/flows/assistants.spec.ts@@ -0,0 +1,265 @@+import type { ResultOf } from '@graphql-typed-document-node/core';+import type { Page } from '@playwright/test';++import type { CallAssistantDocument, DeleteAssistantDocument } from '@/graphql/types';++import { ResultType, StatusType } from '@/graphql/types';++import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import {+ assistantsCassette,+ CREATED_ASSISTANT,+ makeAssistant,+ RUNNING_ASSISTANT,+ WAITING_ASSISTANT,+} from '../../mocks/cassettes/assistants.ts';+import { PROVIDER } from '../../mocks/cassettes/flows.ts';++const openAssistantTab = async (page: Page) => {+ await page.goto('/flows/5');+ await page.getByRole('tab', { name: 'Assistant' }).click();+ await expect(page.getByPlaceholder('Search messages...')).toBeVisible();+};++const openPicker = async (page: Page) => {+ await page.getByRole('button', { name: 'Select assistant' }).click();+ await expect(page.getByPlaceholder('Search assistants...')).toBeVisible();+};++const operationRequest = (page: Page, operationName: string) =>+ page.waitForRequest(+ (request) => request.method() === 'POST' && request.postDataJSON()?.operationName === operationName,+ );++test.describe('flow assistants', { tag: '@flows' }, () => {+ test.describe('create', () => {+ test.use({+ cassette: assistantsCassette({+ mutations: {+ createAssistant: [+ {+ data: {+ createAssistant: {+ assistant: CREATED_ASSISTANT,+ flow: { __typename: 'Flow', id: '5' },+ },+ } as never,+ setFlag: 'assistant-created',+ variables: { flowId: '5', input: 'plan the recon', modelProvider: PROVIDER.name },+ },+ ],+ },+ subscriptions: {+ assistantCreated: [+ {+ frames: [+ {+ payload: { data: { assistantCreated: CREATED_ASSISTANT } },+ whenFlag: 'assistant-created',+ },+ ],+ },+ ],+ },+ }),+ });++ test('creates an assistant from the empty composer and selects it', async ({ page, pageErrorLog }) => {+ await openAssistantTab(page);+ await openPicker(page);+ await page.getByRole('option', { name: 'Create new assistant' }).click();++ const composer = page.getByPlaceholder('Type a message to create a new assistant...');+ const picker = page.getByRole('button', { name: 'Select assistant' });++ await expect(composer).toBeVisible();+ await expect(picker).toHaveText('New');+ await composer.fill('plan the recon');++ // A brand-new assistant inherits no provider. The only one on offer is also the one the+ // previously selected assistant used — the case a defaults-sync that ignores the picked+ // value silently reverts.+ await page.getByRole('button', { name: 'Select Provider' }).click();+ await page.getByRole('menuitem', { name: PROVIDER.name }).click();++ const request = operationRequest(page, 'createAssistant');++ await page.getByRole('button', { name: 'Submit' }).click();++ expect((await request).postDataJSON().variables).toEqual({+ flowId: '5',+ input: 'plan the recon',+ modelProvider: PROVIDER.name,+ useAgents: false,+ });++ // `Create new assistant` leaves the picker on an explicit "none" that the+ // fall-back-to-first selection never overrides — only the create response does.+ await expect(picker).toHaveText(/1$/);++ await openPicker(page);+ await expect(page.getByRole('option', { name: new RegExp(CREATED_ASSISTANT.title) })).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('call', () => {+ const called: ResultOf<typeof CallAssistantDocument> = { callAssistant: ResultType.Success };++ test.use({+ cassette: assistantsCassette({+ mutations: {+ callAssistant: [+ {+ data: called,+ variables: { assistantId: '11', flowId: '5', input: 'and the other ports?' },+ },+ ],+ },+ }),+ });++ test('sends a follow-up to the assistant the picker already selected', async ({ page, pageErrorLog }) => {+ await openAssistantTab(page);++ const composer = page.getByPlaceholder('Continue the conversation...');++ await composer.fill('and the other ports?');++ const request = operationRequest(page, 'callAssistant');++ await page.getByRole('button', { name: 'Submit' }).click();++ expect((await request).postDataJSON().variables).toEqual({+ assistantId: WAITING_ASSISTANT.id,+ flowId: '5',+ input: 'and the other ports?',+ useAgents: false,+ });+ await expect(composer).toHaveValue('');+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('stop', () => {+ test.use({+ cassette: assistantsCassette({+ mutations: {+ stopAssistant: [+ {+ data: {+ stopAssistant: makeAssistant(+ RUNNING_ASSISTANT.id,+ RUNNING_ASSISTANT.title,+ StatusType.Waiting,+ ),+ },+ setFlag: 'assistant-stopped',+ variables: { assistantId: '12', flowId: '5' },+ },+ ],+ },+ subscriptions: {+ assistantUpdated: [+ {+ frames: [+ {+ payload: {+ data: {+ assistantUpdated: makeAssistant(+ RUNNING_ASSISTANT.id,+ RUNNING_ASSISTANT.title,+ StatusType.Waiting,+ ),+ },+ },+ whenFlag: 'assistant-stopped',+ },+ ],+ },+ ],+ },+ }),+ });++ test('stops the running assistant and hands the composer back', async ({ page, pageErrorLog }) => {+ await openAssistantTab(page);+ await openPicker(page);+ await page.getByRole('option', { name: new RegExp(RUNNING_ASSISTANT.title) }).click();++ const stop = page.getByRole('button', { name: 'Cancel' });++ await expect(stop).toBeVisible();++ const request = operationRequest(page, 'stopAssistant');++ await stop.click();++ expect((await request).postDataJSON().variables).toEqual({+ assistantId: RUNNING_ASSISTANT.id,+ flowId: '5',+ });+ await expect(page.getByPlaceholder('Continue the conversation...')).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('delete', () => {+ const deleted: ResultOf<typeof DeleteAssistantDocument> = { deleteAssistant: ResultType.Success };++ test.use({+ cassette: assistantsCassette({+ mutations: {+ deleteAssistant: [+ {+ data: deleted,+ setFlag: 'assistant-deleted',+ variables: { assistantId: '12', flowId: '5' },+ },+ ],+ },+ subscriptions: {+ assistantDeleted: [+ {+ frames: [+ {+ payload: { data: { assistantDeleted: RUNNING_ASSISTANT } },+ whenFlag: 'assistant-deleted',+ },+ ],+ },+ ],+ },+ }),+ });++ test('deletes an assistant through the confirm dialog', async ({ page, pageErrorLog }) => {+ await openAssistantTab(page);+ await openPicker(page);++ const doomed = page.getByRole('option', { name: new RegExp(RUNNING_ASSISTANT.title) });++ await doomed.hover();+ await doomed.getByRole('button').click();++ const dialog = page.getByRole('dialog');++ await expect(dialog.getByText('Delete Assistant')).toBeVisible();++ const request = operationRequest(page, 'deleteAssistant');++ await dialog.getByRole('button', { name: 'Delete' }).click();++ expect((await request).postDataJSON().variables).toEqual({+ assistantId: RUNNING_ASSISTANT.id,+ flowId: '5',+ });++ await openPicker(page);+ await expect(page.getByRole('option', { name: new RegExp(WAITING_ASSISTANT.title) })).toBeVisible();+ await expect(page.getByRole('option', { name: new RegExp(RUNNING_ASSISTANT.title) })).toBeHidden();+ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/flows/interrupt.spec.ts b/frontend/e2e/specs/flows/interrupt.spec.tsnew file mode 100644index 00000000..7aeaab2a--- /dev/null+++ b/frontend/e2e/specs/flows/interrupt.spec.ts@@ -0,0 +1,118 @@+import type { ResultOf } from '@graphql-typed-document-node/core';+import type { Page } from '@playwright/test';++import type { PutUserInputDocument, StopFlowDocument } from '@/graphql/types';++import { ResultType, StatusType } from '@/graphql/types';++import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import {+ FLOW_A_INITIAL_IDS,+ FLOW_B,+ flowQueryData,+ flowsCassette,+ makeFlow,+ makeMessage,+ PROVIDER,+} from '../../mocks/cassettes/flows.ts';++const WAITING_FLOW = makeFlow('5', 'E2E Alpha', StatusType.Waiting);++const openFlowA = async (page: Page) => {+ await page.goto('/flows/5?tab=automation');+ await expect(page.locator('header').getByText('E2E Alpha', { exact: true })).toBeVisible();+};++const operationRequest = (page: Page, operationName: string) =>+ page.waitForRequest(+ (request) => request.method() === 'POST' && request.postDataJSON()?.operationName === operationName,+ );++test.describe('flow interrupt', { tag: '@flows' }, () => {+ test.describe('stop', () => {+ const stopped: ResultOf<typeof StopFlowDocument> = { stopFlow: ResultType.Success };++ test.use({+ cassette: flowsCassette({+ mutations: { stopFlow: [{ data: stopped, setFlag: 'flow-stopped', variables: { flowId: '5' } }] },+ subscriptions: {+ flowUpdated: [+ {+ frames: [{ payload: { data: { flowUpdated: WAITING_FLOW } }, whenFlag: 'flow-stopped' }],+ },+ ],+ },+ }),+ });++ test('stops a running flow from the composer and hands the input back', async ({ page, pageErrorLog }) => {+ await openFlowA(page);++ const stop = page.getByRole('button', { name: 'Cancel' });++ await expect(stop, 'a running flow offers Stop, not Submit').toBeVisible();+ await expect(page.getByRole('button', { name: 'Submit' })).toBeHidden();++ const request = operationRequest(page, 'stopFlow');++ await stop.click();+ expect((await request).postDataJSON().variables).toEqual({ flowId: '5' });++ await expect(page.getByRole('button', { name: 'Submit' })).toBeVisible();+ await expect(page.getByPlaceholder('Provide additional context or instructions...')).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('user input', () => {+ const accepted: ResultOf<typeof PutUserInputDocument> = { putUserInput: ResultType.Success };++ test.use({+ cassette: flowsCassette({+ mutations: {+ putUserInput: [+ {+ data: accepted,+ variables: { flowId: '5', input: 'follow up on the open port' },+ },+ ],+ },+ queries: {+ flow: [+ {+ data: flowQueryData(+ WAITING_FLOW,+ FLOW_A_INITIAL_IDS.map((id) => makeMessage(id, '5')),+ ),+ variables: { id: '5' },+ },+ ],+ // The list query normalizes into the same cache entry, so a Running row here+ // would overwrite the status the detail query just delivered.+ flows: [{ data: { flows: [WAITING_FLOW, FLOW_B] } }],+ },+ }),+ });++ test('sends the typed message to the waiting flow', async ({ page, pageErrorLog }) => {+ await openFlowA(page);++ const composer = page.getByPlaceholder('Provide additional context or instructions...');++ await composer.fill('follow up on the open port');++ const request = operationRequest(page, 'putUserInput');++ await page.getByRole('button', { name: 'Submit' }).click();++ expect((await request).postDataJSON().variables).toEqual({+ flowId: '5',+ input: 'follow up on the open port',+ modelProvider: PROVIDER.name,+ });+ await expect(composer).toHaveValue('');+ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/flows/live-panels.spec.ts b/frontend/e2e/specs/flows/live-panels.spec.tsnew file mode 100644index 00000000..e6b290cc--- /dev/null+++ b/frontend/e2e/specs/flows/live-panels.spec.ts@@ -0,0 +1,78 @@+import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { MESSAGE_ID_SELECTOR } from '../../helpers/subscriptions.ts';+import { readTerminalBuffer } from '../../helpers/terminal.ts';+import {+ livePanelsCassette,+ makeMessage,+ STREAMED,+ VARIED_MESSAGES,+ variedMessagesCassette,+} from '../../mocks/cassettes/flows.ts';++const REVISED_ANSWER = 'Revised plan after the retry';++test.describe('live panels', { tag: '@flows' }, () => {+ test.use({ cassette: livePanelsCassette() });++ // Each panel below is fed by a subscription and nothing else: the seeded query answers hold+ // none of these strings, so a frame wired to the wrong cache field leaves its panel stale.+ test('every streamed panel picks up its own frame', async ({ page, pageErrorLog }) => {+ await page.goto('/flows/5');+ await expect(page.locator('header').getByRole('button', { name: 'Toggle favorite' })).toBeEnabled();++ await page.getByRole('tab', { name: 'Tasks' }).click();+ await expect(page.getByText(STREAMED.task)).toBeVisible();+ await expect(page.getByText(STREAMED.taskRetitled)).toBeVisible();++ await page.getByRole('tab', { name: 'Agents' }).click();+ await expect(page.getByText(STREAMED.agent)).toBeVisible();++ await page.getByRole('tab', { name: 'Searches' }).click();+ await expect(page.getByText(STREAMED.search)).toBeVisible();++ await page.getByRole('tab', { name: 'Vector Store' }).click();+ await expect(page.getByText(STREAMED.vector)).toBeVisible();++ await page.getByRole('tab', { name: 'Terminal' }).click();+ await expect(async () => {+ expect(await readTerminalBuffer(page)).toContain(STREAMED.terminal);+ }).toPass();++ expectCleanPage(pageErrorLog);+ });++ test.describe('a revised message', () => {+ test.use({+ cassette: variedMessagesCassette({+ subscriptions: {+ messageLogUpdated: [+ {+ frames: [+ {+ delayMs: 60,+ payload: {+ data: {+ messageLogUpdated: makeMessage('501', '5', { message: REVISED_ANSWER }),+ },+ },+ },+ ],+ variables: { flowId: '5' },+ },+ ],+ },+ }),+ });++ test('replaces the message in place instead of appending a second one', async ({ page, pageErrorLog }) => {+ await page.goto('/flows/5?tab=automation');++ await expect(page.getByText(REVISED_ANSWER)).toBeVisible();+ await expect(page.getByText(VARIED_MESSAGES[0]!.message)).toBeHidden();+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(VARIED_MESSAGES.length);++ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/flows/messages.spec.ts b/frontend/e2e/specs/flows/messages.spec.tsindex 18d8e0af..7b4c1643 100644--- a/frontend/e2e/specs/flows/messages.spec.ts+++ b/frontend/e2e/specs/flows/messages.spec.ts@@ -1,5 +1,6 @@import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';+import { MESSAGE_ID_SELECTOR } from '../../helpers/subscriptions.ts';import { variedMessagesCassette } from '../../mocks/cassettes/flows.ts';type XtermHost = {@@ -36,7 +37,7 @@ test.describe('flow message rendering', { tag: '@flows' }, () => {pageErrorLog,}) => {await page.goto('/flows/5?tab=automation');- await expect(page.getByTestId('flow-message-id')).toHaveCount(4);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(4);const thinkingToggle = page.getByText('Show thinking');@@ -50,6 +51,11 @@ test.describe('flow message rendering', { tag: '@flows' }, () => {await expect(page.getByRole('heading', { name: 'Report' })).toBeVisible();await expect(page.getByText('Hide details').first()).toBeVisible();+ // Only a report auto-expands, so the terminal message starts collapsed and its xterm is+ // not mounted — the panel's is the only one on screen until the toggle is used.+ await expect(page.locator('.xterm')).toHaveCount(1);+ await page.getByText('Show details').click();+await expect(page.locator('.xterm')).toHaveCount(2);await expect(async () => {expect(await page.evaluate(anyTerminalContains, 'e2e-terminal-marker')).toBe(true);diff --git a/frontend/e2e/specs/flows/pager.spec.ts b/frontend/e2e/specs/flows/pager.spec.tsindex e32c9666..58cfedbb 100644--- a/frontend/e2e/specs/flows/pager.spec.ts+++ b/frontend/e2e/specs/flows/pager.spec.ts@@ -8,7 +8,7 @@ test.describe('flow pager', { tag: ['@flows', '@smoke'] }, () => {test.describe('with a report to show', () => {test.use({ cassette: flowTabsCassette() });- test('keeps the variable action left of the fixed ones', async ({ page }) => {+ test('keeps the variable Report action left of the pager and fixed actions', async ({ page }) => {await page.goto('/flows/5');await expect(page.locator('header').getByRole('button', { name: 'Report' })).toBeVisible();@@ -17,52 +17,59 @@ test.describe('flow pager', { tag: ['@flows', '@smoke'] }, () => {.evaluateAll((buttons) => buttons.map((button) => button.getAttribute('aria-label') ?? ''));const positionOf = (label: string) => labels.findIndex((candidate) => candidate.startsWith(label));- expect(positionOf('Report')).toBeLessThan(positionOf('Toggle favorite'));- expect(positionOf('Toggle favorite')).toBeLessThan(positionOf('Previous'));- expect(positionOf('Next')).toBeLessThan(positionOf('Flow actions'));+ // findIndex returns -1 for an absent label, and -1 < any real index, so the ordering below+ // passes vacuously when a button is missing. Require presence first.+ for (const label of ['Report', 'Toggle favorite', 'Previous', 'Next', 'Flow actions']) {+ expect(positionOf(label), `header is missing the "${label}" button`).toBeGreaterThanOrEqual(0);+ }++ expect(positionOf('Report')).toBeLessThan(positionOf('Previous'));+ expect(positionOf('Previous')).toBeLessThan(positionOf('Next'));+ expect(positionOf('Next')).toBeLessThan(positionOf('Toggle favorite'));+ expect(positionOf('Toggle favorite')).toBeLessThan(positionOf('Flow actions'));});});test('steps to the sibling flow and back without passing through the list', async ({ page, pageErrorLog }) => {const header = page.locator('header');- await page.goto('/flows/5');- await expect(header.getByText('E2E Alpha')).toBeVisible();+ await page.addInitScript(() => {+ const trail: string[] = [];- await page.route('**/graphql', async (route) => {- await new Promise((resolve) => setTimeout(resolve, 300));- await route.fallback();- });+ (window as unknown as { __routeTrail: string[] }).__routeTrail = trail;- await header.getByRole('button', { name: 'Next' }).click();-- const samples = await page.evaluate(async () => {- const taken = [];+ for (const method of ['pushState', 'replaceState'] as const) {+ const original = history[method].bind(history);- for (let index = 0; index < 10; index += 1) {- taken.push({- hasPager: !!document.querySelector('header button[aria-label="Next"]'),- isSiblingShown: document.querySelector('header')?.textContent?.includes('E2E Beta') ?? false,- path: window.location.pathname,- });- await new Promise((resolve) => setTimeout(resolve, 30));+ history[method] = (state: unknown, unused: string, url?: null | string | URL) => {+ original(state, unused, url);+ trail.push(window.location.pathname);+ };}+ });- return taken;+ await page.goto('/flows/5');+ await expect(header.getByText('E2E Alpha')).toBeVisible();++ // Drop the router's own normalising replaceState from the initial load.+ await page.evaluate(() => {+ (window as unknown as { __routeTrail: string[] }).__routeTrail.length = 0;});+ await header.getByRole('button', { name: 'Next' }).click();+await expect(page).toHaveURL(/\/flows\/6$/);await expect(header.getByText('E2E Beta')).toBeVisible();-- // Guards the delay above as much as the pager: without it the sibling lands inside the- // first sample and the loop measures nothing.- expect(samples.filter((sample) => !sample.isSiblingShown).length).toBeGreaterThan(2);- expect(samples.every((sample) => sample.hasPager)).toBe(true);- expect(samples.map((sample) => sample.path)).not.toContain('/flows');+ await expect(header.getByRole('button', { name: 'Next' })).toBeVisible();await header.getByRole('button', { name: 'Previous' }).click();await expect(page).toHaveURL(/\/flows\/5$/);+ await expect(header.getByText('E2E Alpha')).toBeVisible();++ const trail = await page.evaluate(() => (window as unknown as { __routeTrail: string[] }).__routeTrail);++ expect(trail, 'the pager must step straight between siblings').toEqual(['/flows/6', '/flows/5']);expectCleanPage(pageErrorLog);});});diff --git a/frontend/e2e/specs/flows/reconnect.spec.ts b/frontend/e2e/specs/flows/reconnect.spec.tsindex cc2288cd..d8b24650 100644--- a/frontend/e2e/specs/flows/reconnect.spec.ts+++ b/frontend/e2e/specs/flows/reconnect.spec.ts@@ -1,7 +1,7 @@import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';import { dropAndReconnect } from '../../helpers/reconnect.ts';-import { assertNoDuplicates, extractMessageIds, MESSAGE_ID_TESTID } from '../../helpers/subscriptions.ts';+import { assertNoDuplicates, extractMessageIds, MESSAGE_ID_SELECTOR } from '../../helpers/subscriptions.ts';import {FLOW_A_INITIAL_IDS,FLOW_A_RECONNECT_ID,@@ -19,17 +19,34 @@ test.describe('flow reconnect', { tag: ['@flows', '@smoke'] }, () => {test.use({ cassette: flowsCassette() });test('reconciles the missed delta exactly once after a socket drop', async ({ page, pageErrorLog, world }) => {+ // The GraphQL sweep after a reconnect skips the resources slot (it is cache-only), so the+ // REST re-hydration rides on the `ws:reconnected` event alone. Count the calls rather than+ // arming a one-shot expectation: the mount-time hydration would satisfy that on its own.+ const resourceLoads: string[] = [];++ page.on('request', (request) => {+ if (request.method() === 'GET' && new URL(request.url()).pathname.startsWith('/api/v1/resources')) {+ resourceLoads.push(request.url());+ }+ });+await page.goto('/flows');await page.getByRole('row', { name: /E2E Alpha/ }).click();- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(BEFORE_DROP.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(BEFORE_DROP.length);++ const loadsBeforeDrop = resourceLoads.length;await dropAndReconnect(page, world);- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(AFTER_RECONNECT.length);+ await expect+ .poll(() => resourceLoads.length, { message: 'the reconnect re-hydrates the REST resources slot' })+ .toBe(loadsBeforeDrop + 1);++ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(AFTER_RECONNECT.length);world.raiseFlag(REPLAY_FLAG);- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(AFTER_REPLAY.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(AFTER_REPLAY.length);const ids = await extractMessageIds(page.locator('body'));diff --git a/frontend/e2e/specs/flows/report.spec.ts b/frontend/e2e/specs/flows/report.spec.tsnew file mode 100644index 00000000..13148c46--- /dev/null+++ b/frontend/e2e/specs/flows/report.spec.ts@@ -0,0 +1,123 @@+import type { Page } from '@playwright/test';++import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { inspectPdf } from '../../helpers/pdf.ts';+import { flowReportCassette } from '../../mocks/cassettes/flows.ts';++const REPORT_FILE = /^report_flow_5_e2e_alpha_2026\d{10}\.md$/;+const REPORT_PDF = /^report_flow_5_e2e_alpha_2026\d{10}\.pdf$/;++const openReportMenu = async (page: Page) => {+ await page.goto('/flows/5');+ await page.getByRole('button', { name: 'Report' }).click();+};++test.describe('flow report', { tag: '@flows' }, () => {+ test.use({ cassette: flowReportCassette() });++ test('the standalone route renders the generated markdown', async ({ page, pageErrorLog }) => {+ await page.goto('/flows/5/report');++ await expect(page.getByRole('heading', { name: /E2E Alpha/ })).toBeVisible();+ await expect(page.getByRole('heading', { level: 3, name: /E2E Task Alpha/ })).toBeVisible();+ await expect(page.getByText('Ports 22, 80 open')).toBeVisible();+ // The contents links are slugs of the rendered headings; a mismatch scrolls nowhere.+ await expect(page.getByRole('link', { name: /E2E Subtask Scan/ })).toHaveAttribute('href', /#.+/);++ expectCleanPage(pageErrorLog);+ });++ test('"Open web view" opens the report in its own tab', async ({ page, pageErrorLog }) => {+ await openReportMenu(page);++ const popup = page.waitForEvent('popup');++ await page.getByRole('menuitem', { name: 'Open web view' }).click();++ const opened = await popup;++ expect(new URL(opened.url()).pathname).toBe('/flows/5/report');+ // This tab is mocked only because the fixture re-arms the route on every page the context+ // opens; without that it talks to the preview proxy and the report never arrives.+ await expect(opened.getByRole('heading', { name: /E2E Alpha/ })).toBeVisible();+ await opened.close();+ expectCleanPage(pageErrorLog);+ });++ test('"Download PDF" opens the silent print route', async ({ page, pageErrorLog }) => {+ await openReportMenu(page);++ const popup = page.waitForEvent('popup');++ await page.getByRole('menuitem', { name: 'Download PDF' }).click();++ const opened = await popup;+ const url = new URL(opened.url());++ expect(url.pathname).toBe('/flows/5/report');+ // `download` starts the PDF and `silent` closes the tab; without it the export looks hung.+ expect(url.searchParams.get('download')).toBe('true');+ expect(url.searchParams.get('silent')).toBe('true');+ await opened.close();+ expectCleanPage(pageErrorLog);+ });++ test('"Download MD" writes the report to a named file', async ({ page, pageErrorLog }) => {+ await openReportMenu(page);++ const download = page.waitForEvent('download');++ await page.getByRole('menuitem', { name: 'Download MD' }).click();++ const file = await download;++ expect(file.suggestedFilename()).toMatch(REPORT_FILE);++ const stream = await file.createReadStream();+ const body = (await stream.toArray()).join('');++ expect(body).toContain('E2E Task Alpha');+ expect(body).toContain('Ports 22, 80 open');+ expectCleanPage(pageErrorLog);+ });++ test('"Copy to clipboard" puts the same report on the clipboard', async ({ context, page, pageErrorLog }) => {+ await context.grantPermissions(['clipboard-read', 'clipboard-write']);+ await openReportMenu(page);+ await page.getByRole('menuitem', { name: 'Copy to clipboard' }).click();++ await expect(page.getByText('Report copied to clipboard')).toBeVisible();+ expect(await page.evaluate(() => navigator.clipboard.readText())).toContain('E2E Task Alpha');+ expectCleanPage(pageErrorLog);+ });++ test('the print route writes a real PDF, not just a file with the right name', async ({ page, pageErrorLog }) => {+ const download = page.waitForEvent('download');++ await page.goto('/flows/5/report?download=true');++ const file = await download;++ expect(file.suggestedFilename()).toMatch(REPORT_PDF);++ const stream = await file.createReadStream();+ const chunks: Buffer[] = [];++ for await (const chunk of stream) {+ chunks.push(Buffer.from(chunk));+ }++ const shape = inspectPdf(Buffer.concat(chunks));++ // A generator that silently produced a blank document, or an error page saved under a .pdf+ // name, passes a filename check and fails every line of this one.+ expect(shape.isPdf && shape.trailerComplete, 'a complete PDF document').toBe(true);+ expect(shape.pages, 'the report paginated').toBeGreaterThan(0);+ // The seeded report is small; the threshold only has to be above what a title-only or blank+ // document produces, which is what a silently failing generator emits.+ expect(shape.textRuns, 'glyphs were actually drawn').toBeGreaterThan(5);+ expect(shape.fonts, 'a font subset was embedded').toBeGreaterThan(0);+ expectCleanPage(pageErrorLog);+ });+});diff --git a/frontend/e2e/specs/flows/subscriptions.spec.ts b/frontend/e2e/specs/flows/subscriptions.spec.tsindex 79457b82..723d5633 100644--- a/frontend/e2e/specs/flows/subscriptions.spec.ts+++ b/frontend/e2e/specs/flows/subscriptions.spec.ts@@ -5,15 +5,19 @@ import {assertNoDuplicates,attachIdSet,extractMessageIds,- MESSAGE_ID_TESTID,+ MESSAGE_ID_SELECTOR,} from '../../helpers/subscriptions.ts';import {FLOW_A_INITIAL_IDS,FLOW_A_STREAMED_IDS,FLOW_B_INITIAL_IDS,+ FLOW_B_SENTINEL_ID,FLOW_B_STREAMED_IDS,flowsCassette,+ PAGER_SWITCH_FLAG,+ pagerStreamsCassette,} from '../../mocks/cassettes/flows.ts';+import { subscriptionStreamKey } from '../../mocks/world.ts';const FLOW_A_IDS = [...FLOW_A_INITIAL_IDS, ...FLOW_A_STREAMED_IDS];const FLOW_B_IDS = [...FLOW_B_INITIAL_IDS, ...FLOW_B_STREAMED_IDS];@@ -25,7 +29,7 @@ test.describe('flow subscriptions', { tag: ['@flows', '@smoke'] }, () => {await page.goto('/flows');await page.getByRole('row', { name: /E2E Alpha/ }).click();- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(FLOW_A_IDS.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_A_IDS.length);const ids = await extractMessageIds(page.locator('body'));@@ -38,13 +42,13 @@ test.describe('flow subscriptions', { tag: ['@flows', '@smoke'] }, () => {test('keeps concurrent flows exact-set disjoint across a round trip', async ({ page, pageErrorLog }, testInfo) => {await page.goto('/flows');await page.getByRole('row', { name: /E2E Alpha/ }).click();- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(FLOW_A_IDS.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_A_IDS.length);const idsA = await extractMessageIds(page.locator('body'));await page.goBack();await page.getByRole('row', { name: /E2E Beta/ }).click();- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(FLOW_B_IDS.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_B_IDS.length);const idsB = await extractMessageIds(page.locator('body'));@@ -55,7 +59,7 @@ test.describe('flow subscriptions', { tag: ['@flows', '@smoke'] }, () => {await page.goBack();await page.getByRole('row', { name: /E2E Alpha/ }).click();- await expect(page.getByTestId(MESSAGE_ID_TESTID)).toHaveCount(FLOW_A_IDS.length);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_A_IDS.length);const idsAgain = await extractMessageIds(page.locator('body'));@@ -63,3 +67,47 @@ test.describe('flow subscriptions', { tag: ['@flows', '@smoke'] }, () => {expectCleanPage(pageErrorLog);});});++/**+ * Leaving via `/flows` unmounts FlowProvider (app.tsx wraps only `flows/:flowId`), so stream A is+ * already closed there. Only the pager keeps the provider mounted and merely swaps the subscription+ * variables — the one path where a superseded stream can still write into the flow on screen.+ */+test.describe('flow subscriptions across a pager switch', { tag: '@flows' }, () => {+ test.use({ cassette: pagerStreamsCassette() });++ test('drops the stream it switched away from', async ({ page, pageErrorLog, world }, testInfo) => {+ const streamA = subscriptionStreamKey('messageLogAdded', { flowId: '5' });+ const streamB = subscriptionStreamKey('messageLogAdded', { flowId: '6' });++ await page.goto('/flows/5');+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_A_IDS.length);+ expect(world.subscriberCount(streamA), 'flow A must be streaming before the switch').toBe(1);++ const idsA = await extractMessageIds(page.locator('body'));++ await page.locator('header').getByRole('button', { name: 'Next' }).click();+ await expect(page).toHaveURL(/\/flows\/6$/);+ await expect(page.locator(MESSAGE_ID_SELECTOR)).toHaveCount(FLOW_B_IDS.length);++ // The DOM cannot witness this leak: `messageLogs` is keyed by flowId, so a frame carrying+ // {flowId:'5'} is written to flow A's cache slot and never rendered under flow 6 however long+ // the stale stream stays open. The live subscriber set is the only place it shows.+ await expect.poll(() => world.subscriberCount(streamA), 'the superseded stream must be torn down').toBe(0);+ expect(world.subscriberCount(streamB), 'the switched-to flow must be streaming').toBe(1);++ world.raiseFlag(PAGER_SWITCH_FLAG);++ await expect(page.locator(MESSAGE_ID_SELECTOR).filter({ hasText: FLOW_B_SENTINEL_ID })).toHaveCount(1);++ const idsB = await extractMessageIds(page.locator('body'));++ expect([...idsB].sort(), 'the switched-to flow renders exactly its own stream').toEqual(+ [...FLOW_B_IDS, FLOW_B_SENTINEL_ID].sort(),+ );+ assertNoDuplicates(idsB);+ assertDisjoint(idsA, idsB);+ await attachIdSet(testInfo, 'pager-flow-6-message-ids', idsB);+ expectCleanPage(pageErrorLog);+ });+});diff --git a/frontend/e2e/specs/flows/tab-deeplink.spec.ts b/frontend/e2e/specs/flows/tab-deeplink.spec.tsnew file mode 100644index 00000000..3e0d4c22--- /dev/null+++ b/frontend/e2e/specs/flows/tab-deeplink.spec.ts@@ -0,0 +1,70 @@+import type { Page } from '@playwright/test';++import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { FLOW_A, flowQueryData, flowsCassette } from '../../mocks/cassettes/flows.ts';++/** A flow whose message list stays empty, so the auto-detect resolves to Assistant. */+const emptyFlowCassette = () =>+ flowsCassette({+ queries: { flow: [{ data: flowQueryData(FLOW_A, []), variables: { id: '5' } }] },+ subscriptions: { messageLogAdded: [{ frames: [], variables: { flowId: '5' } }] },+ });++const expectSelectedTab = async (page: Page, name: string) => {+ await expect(page.getByRole('tab', { name })).toHaveAttribute('aria-selected', 'true');+};++test.describe('flow tab deep link', { tag: '@flows' }, () => {+ test.describe('over a populated flow', () => {+ test.use({ cassette: flowsCassette() });++ test('?tab=assistant beats the auto-detect that would have shown Automation', async ({+ page,+ pageErrorLog,+ }) => {+ await page.goto('/flows/5?tab=assistant');+ await expectSelectedTab(page, 'Assistant');+ await expect(page.getByText('New assistant', { exact: true })).toBeVisible();++ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('over a flow with no messages', () => {+ test.use({ cassette: emptyFlowCassette() });++ test('?tab=automation beats the auto-detect that would have shown Assistant', async ({+ page,+ pageErrorLog,+ }) => {+ await page.goto('/flows/5?tab=automation');+ await expectSelectedTab(page, 'Automation');+ await expect(page.getByRole('tabpanel', { name: 'Automation' })).toBeVisible();++ expectCleanPage(pageErrorLog);+ });++ test('a tab click records itself in the URL', async ({ page, pageErrorLog }) => {+ await page.goto('/flows/5');+ await expectSelectedTab(page, 'Assistant');++ await page.getByRole('tab', { name: 'Automation' }).click();++ await expect(page).toHaveURL(/[?&]tab=automation/);+ await expectSelectedTab(page, 'Automation');++ expectCleanPage(pageErrorLog);+ });++ test('an unknown tab falls back to the auto-detect', async ({ page, pageErrorLog }) => {+ await page.goto('/flows/5?tab=not-a-tab');+ await expectSelectedTab(page, 'Assistant');+ // The bogus value is left alone rather than rewritten, so a shared link keeps working+ // once the tab it names exists again.+ await expect(page).toHaveURL(/[?&]tab=not-a-tab/);++ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/flows/tabs.spec.ts b/frontend/e2e/specs/flows/tabs.spec.tsindex 216d75b3..0adbb7d5 100644--- a/frontend/e2e/specs/flows/tabs.spec.ts+++ b/frontend/e2e/specs/flows/tabs.spec.ts@@ -1,20 +1,7 @@import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';-import {- flowTabsCassette,- TABS_FILE_NAME,- TABS_SCREENSHOT_NAME,- TABS_SCREENSHOT_URL,-} from '../../mocks/cassettes/flows.ts';--const TABS = [- { marker: 'E2E Task Alpha', name: 'Tasks' },- { marker: 'E2E agent reconnaissance', name: 'Agents' },- { marker: 'E2E search for the CVE', name: 'Searches' },- { marker: 'E2E recall prior findings', name: 'Vector Store' },- { marker: TABS_FILE_NAME, name: 'Files' },- { marker: TABS_SCREENSHOT_URL, name: 'Screenshots' },-] as const;+import { flowTabsCassette, TABS_SCREENSHOT_NAME } from '../../mocks/cassettes/flows.ts';+import { FLOW_DETAIL_TABS } from '../../routes.ts';test.describe('flow detail tabs', { tag: '@flows' }, () => {test.use({ cassette: flowTabsCassette() });@@ -23,9 +10,12 @@ test.describe('flow detail tabs', { tag: '@flows' }, () => {await page.goto('/flows/5');await expect(page.locator('header').getByRole('button', { name: 'Toggle favorite' })).toBeEnabled();- for (const { marker, name } of TABS) {+ for (const { name, ready } of FLOW_DETAIL_TABS) {+ // Pins that the click is what reveals the panel. Ordering this sweep so a tab is already+ // open when its turn comes (the flow auto-opens Assistant) makes its iteration a no-op.+ await expect(ready(page), `"${name}" must not be on screen before its own click`).not.toBeAttached();await page.getByRole('tab', { name }).click();- await expect(page.getByText(marker)).toBeVisible();+ await expect(ready(page)).toBeVisible();}expectCleanPage(pageErrorLog);diff --git a/frontend/e2e/specs/real/account-password.spec.ts b/frontend/e2e/specs/real/account-password.spec.tsnew file mode 100644index 00000000..7d2df616--- /dev/null+++ b/frontend/e2e/specs/real/account-password.spec.ts@@ -0,0 +1,135 @@+import type { APIRequestContext } from '@playwright/test';++import { request as apiRequest, expect, test } from '@playwright/test';++const INITIAL_PASSWORD = 'InitPass1!e2e';+const MAX_BYTES = 72;+const AT_LIMIT = 'a'.repeat(MAX_BYTES);+const OVER_LIMIT = 'a'.repeat(MAX_BYTES + 1);+const MULTIBYTE_OVER_LIMIT = 'é'.repeat(40);++const changePassword = (+ api: APIRequestContext,+ body: { confirm_password?: string; current_password: string; password: string },+) => api.put('/api/v1/user/password', { data: { confirm_password: body.password, ...body } });++const login = (api: APIRequestContext, mail: string, password: string) =>+ api.post('/api/v1/auth/login', { data: { mail, password } });++const ADMIN_USER = process.env.E2E_USER ?? '[email protected]';+const ADMIN_PASSWORD = process.env.E2E_PASSWORD ?? 'admin';++test.describe('account password at the trust boundary', { tag: '@real' }, () => {+ // Deliberately bypasses the form: a client-side guard is one DevTools click from gone, so the+ // matrix has to reach the endpoint the way an attacker would.+ test('enforces the password policy on the endpoint, not just in the form', async ({ baseURL }) => {+ const admin = await apiRequest.newContext({ baseURL, ignoreHTTPSErrors: true });+ const victim = await apiRequest.newContext({ baseURL, ignoreHTTPSErrors: true });++ const adminLogin = await login(admin, ADMIN_USER, ADMIN_PASSWORD);++ expect(adminLogin.status(), 'seeded admin credentials').toBe(200);++ const mail = `e2e-pwd-${Date.now()}@pentagi.com`;+ const created = await admin.post('/api/v1/users/', {+ data: {+ mail,+ name: `e2epwd${Date.now()}`,+ password: INITIAL_PASSWORD,+ role_id: 2,+ status: 'active',+ type: 'local',+ },+ });++ expect(created.status(), 'throwaway user created').toBe(201);++ const hash = (await created.json()).data.hash as string;++ try {+ const tooLongAtCreate = await admin.post('/api/v1/users/', {+ data: {+ mail: `e2e-long-${Date.now()}@pentagi.com`,+ name: `e2elong${Date.now()}`,+ password: OVER_LIMIT,+ role_id: 2,+ status: 'active',+ type: 'local',+ },+ });++ expect(tooLongAtCreate.status(), 'over-length password at user creation').toBe(400);++ expect((await login(victim, mail, INITIAL_PASSWORD)).status()).toBe(200);++ for (const [name, body, wantStatus, wantCode] of [+ [+ 'wrong current password',+ { current_password: 'NotTheOne1!', password: 'NewPass1!abc' },+ 403,+ 'Users.ChangePasswordCurrentUser.InvalidCurrentPassword',+ ],+ [+ 'confirmation mismatch',+ {+ confirm_password: 'NewPass1!abcd',+ current_password: INITIAL_PASSWORD,+ password: 'NewPass1!abc',+ },+ 400,+ 'Users.ChangePasswordCurrentUser.InvalidPassword',+ ],+ [+ 'seven characters with every class',+ { current_password: INITIAL_PASSWORD, password: 'Ab1$cde' },+ 400,+ 'Users.ChangePasswordCurrentUser.InvalidPassword',+ ],+ [+ 'fifteen characters without a special',+ { current_password: INITIAL_PASSWORD, password: 'Abcdefghij12345' },+ 400,+ 'Users.ChangePasswordCurrentUser.InvalidPassword',+ ],+ [+ 'one byte over the bcrypt limit',+ { current_password: INITIAL_PASSWORD, password: OVER_LIMIT },+ 400,+ 'Users.ChangePasswordCurrentUser.InvalidPassword',+ ],+ [+ 'within the rune count but over the byte limit',+ { current_password: INITIAL_PASSWORD, password: MULTIBYTE_OVER_LIMIT },+ 400,+ 'Users.ChangePasswordCurrentUser.InvalidPassword',+ ],+ ] as const) {+ const response = await changePassword(victim, body);++ expect([name, response.status(), (await response.json()).code]).toEqual([name, wantStatus, wantCode]);+ }++ expect((await login(victim, mail, INITIAL_PASSWORD)).status(), 'no rejected row was saved').toBe(200);++ expect(+ (+ await changePassword(victim, { current_password: INITIAL_PASSWORD, password: 'Abcdefghij123$4' })+ ).status(),+ 'fifteen characters with every class is the short-branch maximum',+ ).toBe(200);+ expect(+ (await changePassword(victim, { current_password: 'Abcdefghij123$4', password: AT_LIMIT })).status(),+ 'exactly the bcrypt limit is accepted',+ ).toBe(200);++ expect((await login(victim, mail, AT_LIMIT)).status(), 'the accepted password authenticates').toBe(200);+ expect((await login(victim, mail, INITIAL_PASSWORD)).status(), 'the replaced password does not').not.toBe(+ 200,+ );+ } finally {+ await admin.delete(`/api/v1/users/${hash}`);+ await admin.dispose();+ await victim.dispose();+ }+ });+});diff --git a/frontend/e2e/specs/real/flow-run.spec.ts b/frontend/e2e/specs/real/flow-run.spec.tsindex 3f4218c8..ad260c76 100644--- a/frontend/e2e/specs/real/flow-run.spec.ts+++ b/frontend/e2e/specs/real/flow-run.spec.ts@@ -1,10 +1,13 @@import { expect, test } from '@playwright/test';+import { MESSAGE_ID_SELECTOR } from '../../helpers/subscriptions.ts';import { readTerminalBuffer } from '../../helpers/terminal.ts';test.describe('real backend flow run', { tag: '@real' }, () => {test('runs a flow end-to-end through the mock LLM', async ({ page }) => {- test.setTimeout(240_000);+ // Above the sum of the step timeouts below (60+30+90+90+90+60 = 420s), so a slow-but-passing+ // run is not killed mid-step with a generic timeout that masks the real state.+ test.setTimeout(450_000);const pageErrors: string[] = [];@@ -12,7 +15,13 @@ test.describe('real backend flow run', { tag: '@real' }, () => {await page.goto('/flows/new');await page.getByPlaceholder(/Describe what you would like PentAGI to test/).fill('Say hello');- await page.getByRole('button', { name: 'Submit' }).click();++ // The form is invalid until the providers query lands, so a cold stack keeps Submit+ // disabled for a while — clicking straight away spends the whole test timeout on it.+ const submit = page.getByRole('button', { name: 'Submit' });++ await expect(submit).toBeEnabled({ timeout: 60_000 });+ await submit.click();await expect(page).toHaveURL(/\/flows\/\d+/, { timeout: 30_000 });// Scope the list assertion to this attempt's flow id: a retry runs@@ -21,7 +30,7 @@ test.describe('real backend flow run', { tag: '@real' }, () => {// violation.const flowId = new URL(page.url()).pathname.match(/\d+/)?.[0] ?? '';- await expect(page.getByTestId('flow-message-id').first()).toBeVisible({ timeout: 90_000 });+ await expect(page.locator(MESSAGE_ID_SELECTOR).first()).toBeVisible({ timeout: 90_000 });await expect(page.getByText('Hello from the e2e mock LLM!').first()).toBeVisible({ timeout: 90_000 });// The scenario's `uname -a` exec must stream its sandbox output backdiff --git a/frontend/e2e/specs/real/resources-download.spec.ts b/frontend/e2e/specs/real/resources-download.spec.tsnew file mode 100644index 00000000..ada44d91--- /dev/null+++ b/frontend/e2e/specs/real/resources-download.spec.ts@@ -0,0 +1,67 @@+import { expect, test } from '@playwright/test';++const CONTENT = 'e2e download payload\nsecond line\n';+const ZIP_MAGIC = 'PK';+const END_OF_CENTRAL_DIRECTORY = Buffer.from([0x50, 0x4b, 0x05, 0x06]);+const CENTRAL_DIRECTORY_ENTRY = 0x02014b50;++/** Entry names straight out of the central directory — an empty archive is a valid zip too. */+const zipEntryNames = (archive: Buffer): string[] => {+ const end = archive.lastIndexOf(END_OF_CENTRAL_DIRECTORY);++ if (end === -1) {+ throw new Error(`not a zip archive: ${archive.subarray(0, 16).toString('hex')}`);+ }++ const names: string[] = [];+ let cursor = archive.readUInt32LE(end + 16);++ for (let left = archive.readUInt16LE(end + 10); left > 0; left -= 1) {+ expect(archive.readUInt32LE(cursor), 'central directory entry header').toBe(CENTRAL_DIRECTORY_ENTRY);++ const nameLength = archive.readUInt16LE(cursor + 28);++ names.push(archive.subarray(cursor + 46, cursor + 46 + nameLength).toString());+ cursor += 46 + nameLength + archive.readUInt16LE(cursor + 30) + archive.readUInt16LE(cursor + 32);+ }++ return names;+};++test.describe('resources download at the endpoint', { tag: '@real' }, () => {+ // The browser performs an `<a download>` transfer outside the page context, so the mock tier can+ // only see the URL it asked for. Whether those bytes come back is decided here.+ test('returns the stored bytes, and a zip when several paths are asked for', async ({ request }) => {+ const stamp = Date.now();+ const name = `e2e-download-${stamp}.txt`;+ const second = `e2e-download-${stamp}-b.txt`;++ for (const file of [name, second]) {+ const upload = await request.post('/api/v1/resources/', {+ multipart: { files: { buffer: Buffer.from(CONTENT), mimeType: 'text/plain', name: file } },+ });++ expect(upload.status(), `seed ${file}`).toBe(200);+ }++ try {+ const single = await request.get('/api/v1/resources/download', { params: { 'paths[]': name } });++ expect(single.status()).toBe(200);+ expect(await single.text(), 'the file comes back byte for byte').toBe(CONTENT);++ // Several paths cannot be one file, so the server has to archive them; a plain 200 with the+ // first file's bytes would look like success to any caller that only checks the status.+ const archive = await request.get(`/api/v1/resources/download?paths[]=${name}&paths[]=${second}`);++ expect(archive.status()).toBe(200);++ const body = await archive.body();++ expect(body.subarray(0, 2).toString(), 'a zip, not a bare file').toBe(ZIP_MAGIC);+ expect(zipEntryNames(body).sort(), 'both files are inside it').toEqual([name, second].sort());+ } finally {+ await request.delete(`/api/v1/resources/?paths[]=${name}&paths[]=${second}`);+ }+ });+});diff --git a/frontend/e2e/specs/real/resources-upload-limits.spec.ts b/frontend/e2e/specs/real/resources-upload-limits.spec.tsnew file mode 100644index 00000000..86e9b82f--- /dev/null+++ b/frontend/e2e/specs/real/resources-upload-limits.spec.ts@@ -0,0 +1,116 @@+import type { APIRequestContext } from '@playwright/test';++import { expect, test } from '@playwright/test';++const BOUNDARY = 'e2e-upload-boundary';++/** Builds the multipart body by hand: the point is to send what the client refuses to build. */+const multipart = (files: Array<{ body: string; name: string }>): Buffer => {+ const parts = files+ .map(+ ({ body, name }) =>+ `--${BOUNDARY}\r\nContent-Disposition: form-data; name="files"; filename="${name}"\r\n` ++ `Content-Type: application/octet-stream\r\n\r\n${body}\r\n`,+ )+ .join('');++ return Buffer.from(`${parts}--${BOUNDARY}--\r\n`);+};++const upload = (request: APIRequestContext, files: Array<{ body: string; name: string }>) =>+ request.post('/api/v1/resources/', {+ data: multipart(files),+ headers: { 'content-type': `multipart/form-data; boundary=${BOUNDARY}` },+ });++test.describe('resources upload limits at the endpoint', { tag: '@real' }, () => {+ // The browser-side guard is one DevTools click from gone, so what matters is the set of rules the+ // endpoint itself keeps — a smaller set than the client's, as the empty-file case below records.+ // The size caps (300 MB per file, 2 GB per batch) are left to the backend's own tests: proving+ // them here means pushing gigabytes through the stand.+ test('caps a batch at 1000 files and writes nothing from an over-cap batch', async ({ request }) => {+ const stamp = Date.now();+ const many = Array.from({ length: 1001 }, (_, index) => ({+ body: 'x',+ name: `e2e-many-${stamp}-${index}.txt`,+ }));++ const tooMany = await upload(request, many);++ // 400, but not from the handler's own count check: Go's multipart reader caps a form at 1000+ // parts and answers `multipart: message too large` first (confirmed in the backend log), which+ // makes `resources.MaxUploadFiles` unreachable for this endpoint. What this pins is the+ // user-visible contract — 1001 is refused and nothing is written.+ expect(tooMany.status(), 'a batch past 1000 files is refused').toBe(400);++ const afterReject = await request.get('/api/v1/resources/', { params: { recursive: 'true' } });+ const rejectedPaths = ((await afterReject.json()).data.items ?? []).map((item: { path: string }) => item.path);++ expect(+ rejectedPaths.filter((path: string) => path.startsWith(`e2e-many-${stamp}`)),+ 'a rejected batch writes nothing at all, not a partial prefix',+ ).toEqual([]);++ // Exactly on the cap is the other half of the boundary: a server that rejected 1000 as well+ // would look just as "safe" and be wrong.+ const atCap = await upload(request, many.slice(0, 1000));++ expect(atCap.status(), 'a batch exactly on the cap').toBe(200);++ // Repeated keys, not an object: `Object.fromEntries` keeps only the last of 1000 identical+ // `paths[]` entries and would delete one file while leaving 999 on the stand.+ const cleanup = new URLSearchParams();++ many.slice(0, 1000).forEach(({ name }) => cleanup.append('paths[]', name));++ const deleted = await request.delete(`/api/v1/resources/?${cleanup}`);++ expect(deleted.status(), 'the seeded batch is removed again').toBe(200);+ });++ // What licenses the client to send a 0-byte file at all: the endpoint stores it. A client-side+ // refusal here would only have hidden an upload the API accepts.+ test('stores an empty file rather than refusing it', async ({ request }) => {+ const name = `e2e-hollow-${Date.now()}.txt`;+ const accepted = await upload(request, [{ body: '', name }]);++ expect(accepted.status(), 'a 0-byte part is not a server-side error').toBe(200);++ const [stored] = (await accepted.json()).data.items ?? [];++ expect(stored?.path, 'it is created, not silently dropped').toBe(name);+ expect(stored?.size, 'as a zero-byte resource').toBe(0);++ await request.delete('/api/v1/resources/', { params: { 'paths[]': name } });+ });++ test('refuses a batch that carries no file part at all', async ({ request }) => {+ const nothing = await upload(request, []);++ expect(nothing.status(), 'at least one file is required').toBe(400);+ });++ // The server sanitises rather than rejects, which is a legitimate choice — what must hold is that+ // nothing lands outside the library. Asserting a 400 here would pin an implementation the server+ // does not have; asserting the stored path is what actually protects the filesystem.+ test('strips a traversal out of the file name instead of honouring it', async ({ request }) => {+ const name = `e2e-escape-${Date.now()}.txt`;+ const escaped = await upload(request, [{ body: 'owned', name: `../${name}` }]);++ expect(escaped.status(), 'the request is answered, not crashed').toBeLessThan(500);++ const listing = await request.get('/api/v1/resources/', { params: { recursive: 'true' } });+ const paths: string[] = ((await listing.json()).data.items ?? []).map((item: { path: string }) => item.path);++ expect(+ paths.filter((path) => path.includes('..')),+ 'no stored path may climb out',+ ).toEqual([]);+ expect(+ paths.filter((path) => path.endsWith(name)),+ 'it landed under the sanitised name',+ ).toEqual([name]);++ await request.delete('/api/v1/resources/', { params: { 'paths[]': name } });+ });+});diff --git a/frontend/e2e/specs/real/stand-smoke.spec.ts b/frontend/e2e/specs/real/stand-smoke.spec.tsindex e806e6f8..44989512 100644--- a/frontend/e2e/specs/real/stand-smoke.spec.ts+++ b/frontend/e2e/specs/real/stand-smoke.spec.ts@@ -11,6 +11,10 @@ const ROUTES = [{ emptyTitle: 'No API tokens configured', path: '/settings/api-tokens', title: 'API Tokens' },];+// The data assertion waits on a real backend query, so it must not run on the 5s default expect+// timeout — a healthy but slow stand would flake. The config overrides only the screenshot timeout.+const STAND_DATA_TIMEOUT = 30_000;+test.describe('stand smoke', { tag: '@stand' }, () => {for (const { emptyTitle, path, title } of ROUTES) {test(`renders ${path} without a page error`, async ({ page }) => {@@ -29,7 +33,9 @@ test.describe('stand smoke', { tag: '@stand' }, () => {// settings-sidebar <a> at runtime, the breadcrumb title is a span.await expect(page.locator('span[aria-current="page"]')).toHaveText(title);// Either branch: a query error renders neither, and a stand may hold no rows.- await expect(page.locator('[data-slot="table"]').first().or(page.getByText(emptyTitle))).toBeVisible();+ await expect(page.locator('[data-slot="table"]').first().or(page.getByText(emptyTitle))).toBeVisible({+ timeout: STAND_DATA_TIMEOUT,+ });expect(pageErrors, `uncaught errors on ${path}`).toEqual([]);});}diff --git a/frontend/e2e/specs/settings/account.spec.ts b/frontend/e2e/specs/settings/account.spec.tsnew file mode 100644index 00000000..c8aa9358--- /dev/null+++ b/frontend/e2e/specs/settings/account.spec.ts@@ -0,0 +1,193 @@+import type { Locator, Page } from '@playwright/test';++import type { Cassette } from '../../mocks/cassette.ts';++import { SEEDED_USER } from '../../fixtures/auth.ts';+import { expect, test } from '../../fixtures/test.ts';+import { expectCleanPage } from '../../helpers/errors.ts';+import { baseQueries, baseRest } from '../../mocks/cassettes/base.ts';++const CURRENT_PASSWORD = 'CurrentPass1!';+// The server-side half of this boundary lives in specs/real/account-password.spec.ts.+const MAX_LENGTH_PASSWORD = 'n'.repeat(72);++const accountCassette = (rest: Cassette['rest'] = {}): Cassette => ({+ queries: baseQueries(),+ rest: { ...baseRest(), ...rest },+});++const section = (page: Page, title: string): Locator =>+ page.locator('[data-slot="card"]').filter({ has: page.locator('[data-slot="card-title"]', { hasText: title }) });++const openSection = async (page: Page, title: string): Promise<Locator> => {+ const card = section(page, title);++ await card.getByRole('button', { name: 'Change' }).click();++ return card;+};++const fillPasswordForm = async (page: Page, next: string, confirm = next): Promise<void> => {+ await page.getByLabel('Current Password').fill(CURRENT_PASSWORD);+ await page.getByLabel('New Password', { exact: true }).fill(next);+ await page.getByLabel('Confirm New Password').fill(confirm);+};++const submitPasswordForm = (page: Page): Promise<void> => page.getByRole('button', { name: 'Update Password' }).click();++test.describe('account settings', { tag: '@settings' }, () => {+ test.describe('read', () => {+ test.use({ cassette: accountCassette() });++ test('renders the signed-in identity and every editable section', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/account');++ await expect(page.getByRole('heading', { exact: true, name: SEEDED_USER.name })).toBeVisible();+ await expect(page.getByText('Member since January 2026')).toBeVisible();+ await expect(page.getByText('Local account')).toBeVisible();+ await expect(section(page, 'Display name').getByText(SEEDED_USER.name)).toBeVisible();+ await expect(section(page, 'Email address').getByText(SEEDED_USER.mail)).toBeVisible();+ await expect(section(page, 'Password').getByText('••••••••••••')).toBeVisible();++ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('password validation', () => {+ test.use({ cassette: accountCassette() });++ // The cassette deliberately holds no `PUT /user/password` entry: adding one to "fix" a+ // failure here would destroy the oracle.+ test('rejects each invalid password without touching the network', async ({ page, pageErrorLog }) => {+ const attempts: string[] = [];++ page.on('request', (request) => {+ if (request.method() === 'PUT' && new URL(request.url()).pathname === '/api/v1/user/password') {+ attempts.push(request.url());+ }+ });++ await page.goto('/settings/account');+ await openSection(page, 'Password');++ // Only the first row clicks: the submit disables itself once a submitted form is invalid,+ // and every later row is then validated live on change.+ await fillPasswordForm(page, 'NewPass1!abc', 'OtherPass1!abc');+ await submitPasswordForm(page);+ await expect(page.getByText("Passwords don't match")).toBeVisible();++ await fillPasswordForm(page, 'newpass1');+ await expect(page.getByText('Password must be either longer than 15 characters')).toBeVisible();++ await fillPasswordForm(page, 'short1!');+ await expect(page.getByText('Password must be at least 8 characters')).toBeVisible();++ await fillPasswordForm(page, `${MAX_LENGTH_PASSWORD}x`);+ await expect(page.getByText('Password must not exceed 72 characters')).toBeVisible();++ await fillPasswordForm(page, CURRENT_PASSWORD);+ await expect(page.getByText('New password must be different from current password')).toBeVisible();++ expect(attempts, 'no invalid password may reach the backend').toEqual([]);+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('password submit', () => {+ test.use({+ cassette: accountCassette({+ 'PUT /api/v1/user/password': [+ {+ body: { data: {}, status: 'success' },+ bodySubset: {+ confirm_password: MAX_LENGTH_PASSWORD,+ current_password: CURRENT_PASSWORD,+ password: MAX_LENGTH_PASSWORD,+ },+ },+ ],+ }),+ });++ test('sends the three snake_case fields and closes the section', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/account');+ await openSection(page, 'Password');+ await fillPasswordForm(page, MAX_LENGTH_PASSWORD);+ await submitPasswordForm(page);++ await expect(page.getByText('Password successfully changed')).toBeVisible();+ await expect(section(page, 'Password').getByText('••••••••••••')).toBeVisible();++ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('password rejection', () => {+ test.use({+ cassette: accountCassette({+ 'PUT /api/v1/user/password': [+ {+ body: {+ code: 'Users.ChangePasswordCurrentUser.InvalidCurrentPassword',+ msg: 'invalid current password',+ status: 'error',+ },+ status: 403,+ },+ ],+ }),+ });++ test('translates the backend error code instead of showing the raw message', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/account');+ await openSection(page, 'Password');+ await fillPasswordForm(page, 'NewPass1!abc');+ await submitPasswordForm(page);++ await expect(page.getByText('Current password is incorrect')).toBeVisible();+ await expect(page.getByText('invalid current password')).toBeHidden();+ await expect(page.getByRole('button', { name: 'Update Password' })).toBeVisible();++ expect(pageErrorLog.pageErrors, 'no uncaught page errors').toEqual([]);+ expect(+ pageErrorLog.consoleErrors.filter((text) => !text.includes('403')),+ 'the rejected request is the only console error',+ ).toEqual([]);+ });+ });++ test.describe('name and email', () => {+ test.use({+ cassette: accountCassette({+ 'PUT /api/v1/user/email': [+ {+ body: { data: {}, status: 'success' },+ bodySubset: { current_password: CURRENT_PASSWORD, mail: '[email protected]' },+ },+ ],+ 'PUT /api/v1/user/name': [+ { body: { data: {}, status: 'success' }, bodySubset: { name: 'E2E renamed admin' } },+ ],+ }),+ });++ test('sends the display name and the credential-guarded email change', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/account');++ const nameCard = await openSection(page, 'Display name');++ await nameCard.getByLabel('Display name').fill('E2E renamed admin');+ await nameCard.getByRole('button', { name: 'Update Name' }).click();+ await expect(page.getByText('Name successfully updated')).toBeVisible();++ const emailCard = await openSection(page, 'Email address');++ await emailCard.getByLabel('Current Password').fill(CURRENT_PASSWORD);+ await emailCard.getByLabel('New Email').fill('[email protected]');+ await emailCard.getByRole('button', { name: 'Update Email' }).click();+ await expect(page.getByText('Email successfully updated')).toBeVisible();++ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/settings/prompt-detail.spec.ts b/frontend/e2e/specs/settings/prompt-detail.spec.tsindex c61f6b1b..d26150a3 100644--- a/frontend/e2e/specs/settings/prompt-detail.spec.ts+++ b/frontend/e2e/specs/settings/prompt-detail.spec.ts@@ -4,12 +4,34 @@ import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';import {PROMPT_DETAIL_AGENT,+ PROMPT_OVERRIDE,+ PROMPT_RESET_FLAG,promptDetailCassette,+ promptOverrideCassette,RICH_PROMPT_TEMPLATE,} from '../../mocks/cassettes/settings-prompts.ts';test.describe('settings prompt detail', { tag: '@coverage' }, () => {- test.use({ cassette: promptDetailCassette() });+ test.use({+ cassette: promptDetailCassette({+ mutations: {+ createPrompt: [+ {+ data: {+ createPrompt: {+ __typename: 'UserPrompt',+ createdAt: '2026-01-15T12:00:00Z',+ id: '77',+ template: 'saved',+ type: 'pentester',+ updatedAt: '2026-01-15T12:00:00Z',+ },+ } as never,+ },+ ],+ },+ }),+ });const EDITOR = 'System prompt template';@@ -57,4 +79,136 @@ test.describe('settings prompt detail', { tag: '@coverage' }, () => {expect(raw).toContain('E2E-MARK');expectCleanPage(pageErrorLog);});++ // The editor is where a Go template's byte fidelity is decided, and Save is the only operation+ // that can destroy one. Until now no spec let it reach the wire, so the whole form → mutation hop+ // was unverified: the round-trip units cannot see it.+ test('Save sends the edited template verbatim, atoms intact', async ({ page, pageErrorLog }) => {+ await page.goto(`/settings/prompts/${PROMPT_DETAIL_AGENT}`);++ const editor = page.getByRole('textbox', { name: EDITOR });++ await expect(editor.getByRole('heading', { name: 'Pentester' })).toBeVisible();++ await editor.click();+ await page.keyboard.press('ControlOrMeta+End');+ await editor.pressSequentially(' E2E-SAVE-MARK');++ const request = page.waitForRequest(+ (candidate) => candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === 'createPrompt',+ );++ await page.getByRole('button', { exact: true, name: 'Save' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.template, 'the edit reached the wire').toContain('E2E-SAVE-MARK');++ for (const atom of ['# Pentester', '{{.Target}}', '{{.Scope}}', '```bash', '| Scope | {{.Scope}} |']) {+ expect(variables.template, `"${atom}" survived the save`).toContain(atom);+ }++ expectCleanPage(pageErrorLog);+ });+});++test.describe('settings prompt detail, already overridden', { tag: '@coverage' }, () => {+ const EDITOR = 'System prompt template';++ test.describe('save', () => {+ test.use({+ cassette: promptOverrideCassette({+ mutations: {+ updatePrompt: [+ {+ data: {+ updatePrompt: {+ __typename: 'UserPrompt',+ createdAt: '2026-01-15T09:00:00Z',+ id: PROMPT_OVERRIDE.id,+ template: 'saved',+ type: 'pentester',+ updatedAt: '2026-01-15T12:00:00Z',+ },+ } as never,+ variables: { promptId: PROMPT_OVERRIDE.id },+ },+ ],+ },+ }),+ });++ test('Save updates the existing override instead of creating another', async ({ page, pageErrorLog }) => {+ await page.goto(`/settings/prompts/${PROMPT_DETAIL_AGENT}`);++ const editor = page.getByRole('textbox', { name: EDITOR });++ await expect(editor.getByRole('heading', { name: 'Operator override' })).toBeVisible();++ await editor.click();+ await page.keyboard.press('ControlOrMeta+End');+ await editor.pressSequentially(' E2E-UPDATE-MARK');++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === 'updatePrompt',+ );++ await page.getByRole('button', { exact: true, name: 'Save' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.promptId, "the operator's own row is the one rewritten").toBe(PROMPT_OVERRIDE.id);+ expect(variables.template).toContain('E2E-UPDATE-MARK');+ expect(variables.template, 'the override travels whole').toContain('# Operator override');+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('reset', () => {+ test.use({+ cassette: promptOverrideCassette({+ mutations: {+ deletePrompt: [+ {+ data: { deletePrompt: 'success' } as never,+ setFlag: PROMPT_RESET_FLAG,+ variables: { promptId: PROMPT_OVERRIDE.id },+ },+ ],+ },+ }),+ });++ test('Reset deletes the override and puts the default back in the editor', async ({ page, pageErrorLog }) => {+ await page.goto(`/settings/prompts/${PROMPT_DETAIL_AGENT}`);++ const editor = page.getByRole('textbox', { name: EDITOR });++ await expect(editor.getByRole('heading', { name: 'Operator override' })).toBeVisible();++ await page.getByRole('button', { name: 'Prompt actions' }).click();+ await page.getByRole('menuitem', { name: 'Reset' }).click();++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === 'deletePrompt',+ );++ await page.getByRole('dialog').getByRole('button', { exact: true, name: 'Reset' }).click();++ expect((await request).postDataJSON().variables).toEqual({ promptId: PROMPT_OVERRIDE.id });++ // Wait for the dialog to go first: a role-based locator does not resolve while the modal+ // holds the background out of the a11y tree, and Playwright reads "0 elements" as hidden —+ // so asserting through the open dialog passes whatever the editor actually shows.+ await expect(page.getByRole('dialog')).toBeHidden();++ // Deleting the row is only half the operation: the editor has to fall back to the default,+ // or the operator is left looking at text that no longer exists anywhere.+ await expect(editor.getByRole('heading', { name: 'Pentester' })).toBeVisible();+ await expect(editor.getByRole('heading', { name: 'Operator override' })).toBeHidden();+ expectCleanPage(pageErrorLog);+ });+ });});diff --git a/frontend/e2e/specs/settings/providers.spec.ts b/frontend/e2e/specs/settings/providers.spec.tsindex 876b770f..5ab403ce 100644--- a/frontend/e2e/specs/settings/providers.spec.ts+++ b/frontend/e2e/specs/settings/providers.spec.ts@@ -1,6 +1,24 @@+import type { Page } from '@playwright/test';+import { expect, test } from '../../fixtures/test.ts';import { expectCleanPage } from '../../helpers/errors.ts';-import { settingsProvidersCassette } from '../../mocks/cassettes/settings-providers.ts';+import {+ agentTestResult,+ OTHER_PROVIDER,+ OTHER_PROVIDER_ROW,+ populatedSettingsProvidersCassette,+ providersList,+ providerTestResult,+ renamedProviderRow,+ SEEDED_PROVIDER,+ seededProviderRow,+ settingsProvidersCassette,+} from '../../mocks/cassettes/settings-providers.ts';++/** The per-agent Test control repeats its name for all 13 agents, so it is addressed through the+ * accordion item that names the agent. */+const agentRow = (page: Page, agentName: string) =>+ page.locator('[data-slot="accordion-item"]').filter({ hasText: agentName });test.describe('settings providers', { tag: '@coverage' }, () => {test.use({ cassette: settingsProvidersCassette() });@@ -27,3 +45,290 @@ test.describe('settings providers', { tag: '@coverage' }, () => {expectCleanPage(pageErrorLog);});});++test.describe('settings providers create form', { tag: '@coverage' }, () => {+ // Needs a cassette where the type is enabled: the create form bounces `?type=` for a disabled+ // one, so the empty seed would just redirect to the list.+ test.use({ cassette: populatedSettingsProvidersCassette() });++ // A selected type seeds each agent's model from that type's catalog. The catalog must carry the+ // shape the backend actually emits (a non-empty model list for every type, keyed or not); an+ // empty catalog makes this whole path unreachable and any assertion on it vacuous. `?type=` is+ // the URL the type picker produces, driven directly to avoid the dirty-form navigation blocker.+ test('seeds the agent model from the selected type catalog', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/providers/new?type=anthropic');++ await page.getByRole('button', { name: /^Adviser/ }).click();+ await page.getByRole('button', { name: 'Open model list' }).first().click();++ // A catalog-only model (not the seeded agent default), so it can only appear if the type's+ // model list reached the dropdown — the path an empty catalog leaves unreachable.+ await expect(page.getByRole('option', { name: 'e2e-anthropic-model-mini' })).toBeVisible();++ expectCleanPage(pageErrorLog);+ });+});++test.describe('settings providers write path', { tag: '@coverage' }, () => {+ const CREATED_NAME = 'E2E created provider';++ test.use({+ cassette: populatedSettingsProvidersCassette({+ mutations: {+ createProvider: [+ {+ data: { createProvider: { __typename: 'ResultType', result: 'success' } } as never,+ variables: { name: CREATED_NAME, type: 'anthropic' },+ },+ ],+ },+ }),+ });++ // The create form is seeded from the type's defaults and then serialises the whole agents map back.+ // Fields the user never touches are exactly the ones that get dropped on the way to the wire — this+ // asserts the payload, because the UI looks identical either way.+ test('create sends every agent field it was seeded with, zero-ish values included', async ({+ page,+ pageErrorLog,+ }) => {+ await page.goto('/settings/providers/new?type=anthropic');++ await expect(page.getByLabel('Name', { exact: true })).toBeVisible();+ await page.getByLabel('Name', { exact: true }).fill(CREATED_NAME);++ const request = page.waitForRequest(+ (candidate) =>+ candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === 'createProvider',+ );++ await page.getByRole('button', { exact: true, name: 'Create' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.name).toBe(CREATED_NAME);+ expect(variables.type).toBe('anthropic');+ expect(Object.keys(variables.agents), 'every agent is serialised, not just the edited one').toHaveLength(13);+ expect(variables.agents.simpleJson).toMatchObject({+ json: true,+ maxTokens: 4096,+ model: 'e2e-anthropic-model',+ n: 1,+ });+ expectCleanPage(pageErrorLog);+ });+});++test.describe('settings provider edit paths', { tag: '@coverage' }, () => {+ const RENAMED = 'E2E renamed endpoint';++ const editCassette = (override: Parameters<typeof populatedSettingsProvidersCassette>[0] = {}) =>+ populatedSettingsProvidersCassette(override);++ const openProvider = async (page: Page) => {+ await page.goto(`/settings/providers/${SEEDED_PROVIDER.id}`);+ await expect(page.getByLabel('Name', { exact: true })).toHaveValue(SEEDED_PROVIDER.name);+ };++ const mutationRequest = (page: Page, operationName: string) =>+ page.waitForRequest(+ (candidate) => candidate.method() === 'POST' && candidate.postDataJSON()?.operationName === operationName,+ );++ test.describe('update', () => {+ test.use({+ cassette: editCassette({+ mutations: {+ updateProvider: [+ {+ data: { updateProvider: renamedProviderRow(RENAMED) } as never,+ variables: { name: RENAMED, providerId: SEEDED_PROVIDER.id },+ },+ ],+ },+ }),+ });++ test('Save carries the id of the provider being edited', async ({ page, pageErrorLog }) => {+ await openProvider(page);+ await page.getByLabel('Name', { exact: true }).fill(RENAMED);++ const request = mutationRequest(page, 'updateProvider');++ await page.getByRole('button', { exact: true, name: 'Save' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.providerId).toBe(SEEDED_PROVIDER.id);+ expect(variables.name).toBe(RENAMED);+ expect(Object.keys(variables.agents), 'the whole agents map is resubmitted').toHaveLength(13);+ await expect(page, 'a saved provider returns to the list').toHaveURL(/\/settings\/providers$/);+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('delete from the editor', () => {+ test.use({+ cassette: editCassette({+ mutations: {+ deleteProvider: [+ {+ data: { deleteProvider: 'success' } as never,+ variables: { providerId: SEEDED_PROVIDER.id },+ },+ ],+ },+ }),+ });++ test('Delete confirms by name, sends the id, and returns to the list', async ({ page, pageErrorLog }) => {+ await openProvider(page);+ await page.getByRole('button', { name: 'Provider actions' }).click();+ await page.getByRole('menuitem', { name: 'Delete' }).click();++ const dialog = page.getByRole('dialog');++ // A confirm dialog wired to the wrong row shows the wrong name here instead of deleting silently.+ await expect(dialog).toContainText(SEEDED_PROVIDER.name);++ const request = mutationRequest(page, 'deleteProvider');++ await dialog.getByRole('button', { name: 'Delete' }).click();++ expect((await request).postDataJSON().variables).toEqual({ providerId: SEEDED_PROVIDER.id });+ await expect(page).toHaveURL(/\/settings\/providers$/);+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('delete from the list', () => {+ test.use({+ cassette: editCassette({+ mutations: {+ deleteProvider: [+ {+ data: { deleteProvider: 'success' } as never,+ setFlag: 'provider-deleted',+ variables: { providerId: OTHER_PROVIDER.id },+ },+ ],+ },+ queries: {+ settingsProviders: [+ { data: providersList(seededProviderRow(), OTHER_PROVIDER_ROW()) },+ { data: providersList(seededProviderRow()), whenFlag: 'provider-deleted' },+ ],+ },+ }),+ });++ test('the row menu deletes the row it belongs to', async ({ page, pageErrorLog }) => {+ await page.goto('/settings/providers');++ // The second row on purpose: a menu wired to a fixed index would still send the first+ // row's id, and a spec that operated row one could not tell the two apart.+ const row = page.getByRole('row', { name: new RegExp(OTHER_PROVIDER.name) });++ await expect(row).toBeVisible();+ await row.hover();+ await row.getByRole('button', { name: 'Open menu' }).click();+ await page.getByRole('menuitem', { name: 'Delete' }).click();++ const request = mutationRequest(page, 'deleteProvider');++ await page.getByRole('dialog').getByRole('button', { name: 'Delete' }).click();++ expect((await request).postDataJSON().variables).toEqual({ providerId: OTHER_PROVIDER.id });+ // The row goes only because the refetch answers without it, and the sibling proves the+ // table itself survived — a vanished table would satisfy a bare toBeHidden() too.+ await expect(row).toBeHidden();+ await expect(page.getByRole('row', { name: new RegExp(SEEDED_PROVIDER.name) })).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('test one agent', () => {+ test.use({+ cassette: editCassette({+ mutations: {+ testAgent: [+ {+ data: { testAgent: agentTestResult() } as never,+ variables: { agentType: 'adviser', type: SEEDED_PROVIDER.type },+ },+ ],+ },+ }),+ });++ test("a single agent's Test sends that agent, its type, and shows the verdict", async ({+ page,+ pageErrorLog,+ }) => {+ await openProvider(page);++ const request = mutationRequest(page, 'testAgent');++ await agentRow(page, 'Adviser').getByRole('button', { exact: true, name: 'Test' }).click();++ const { variables } = (await request).postDataJSON();++ expect(variables.agentType, 'the enum the backend keys the agent by').toBe('adviser');+ expect(variables.type).toBe(SEEDED_PROVIDER.type);+ expect(variables.agent, 'the edited agent config travels with the request').toMatchObject({+ json: true,+ maxTokens: 4096,+ model: 'e2e-model',+ n: 1,+ });++ const dialog = page.getByRole('dialog');++ // Only the agent that was tested appears — the dialog is keyed by the clicked agent, so a+ // handler that tested the wrong one would name it here.+ await expect(dialog.getByRole('heading', { name: 'Adviser 1/1 passed' })).toBeVisible();+ await expect(dialog.getByRole('heading', { name: /passed/ })).toHaveCount(1);+ expectCleanPage(pageErrorLog);+ });+ });++ test.describe('test the whole provider', () => {+ test.use({+ cassette: editCassette({+ mutations: {+ testProvider: [+ {+ data: { testProvider: providerTestResult() } as never,+ variables: { type: SEEDED_PROVIDER.type },+ },+ ],+ },+ }),+ });++ test('the header Test sends every agent and renders a verdict per agent', async ({ page, pageErrorLog }) => {+ await openProvider(page);++ const request = mutationRequest(page, 'testProvider');++ await page.locator('header').getByRole('button', { exact: true, name: 'Test' }).click();++ const { variables } = (await request).postDataJSON();++ expect(Object.keys(variables.agents), 'the whole map is tested, not one agent').toHaveLength(13);+ expect(variables.type).toBe(SEEDED_PROVIDER.type);++ const dialog = page.getByRole('dialog');++ await expect(dialog.getByRole('heading', { name: /passed/ }), 'one row per agent').toHaveCount(13);+ await expect(dialog.getByRole('heading', { name: 'Pentester 0/1 passed' })).toBeVisible();++ await dialog.getByRole('button', { name: 'Pentester 0/1 passed' }).click();++ // The failing agent's own error must reach the operator; a dialog that renders only the+ // verdict leaves them with nothing to act on.+ await expect(dialog.getByText('e2e simulated failure')).toBeVisible();+ expectCleanPage(pageErrorLog);+ });+ });+});diff --git a/frontend/e2e/specs/smoke.spec.ts b/frontend/e2e/specs/smoke.spec.tsindex fba878c0..a9f4d616 100644--- a/frontend/e2e/specs/smoke.spec.ts+++ b/frontend/e2e/specs/smoke.spec.ts@@ -40,9 +40,13 @@ test.describe('smoke', { tag: '@smoke' }, () => {await expect(page.getByText('Login failed. Please try again.').first()).toBeVisible();await expect(page).toHaveURL(/\/login/);- // react-hook-form leaves Submit disabled after a failed submit until- // an input changes.+ // Disabled by FormSubmitButton's `requireValid` gate (`isSubmitted && !isValid`), not by+ // the 401: the typed values are still schema-valid, and only a change recomputes validity.await expect(page.getByRole('button', { name: 'Sign in' })).toBeDisabled();++ await page.getByRole('textbox', { name: 'Password' }).fill('another-password');++ await expect(page.getByRole('button', { name: 'Sign in' })).toBeEnabled();// The 401 logs an expected browser console error, but the path must raise no// uncaught JS exception / unhandled rejection.expect(pageErrorLog.pageErrors).toEqual([]);diff --git a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.pngindex 76d0ea0e..0e712e38 100644Binary files a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png and b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png differdiff --git a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.pngindex 7709f9ab..f112ece8 100644Binary files a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png and b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png differdiff --git a/frontend/e2e/tools/review-sandbox.sh b/frontend/e2e/tools/review-sandbox.shnew file mode 100755index 00000000..f8e02236--- /dev/null+++ b/frontend/e2e/tools/review-sandbox.sh@@ -0,0 +1,187 @@+#!/usr/bin/env bash+# A throwaway checkout for agents that need to MUTATE code to test something — inject a+# regression, delete a guard, probe a fixture. Review runs kept doing that in the live tree:+# probe specs left behind, tracked files edited, and once an `rm -rf` of a directory the run+# did not create.+#+# Usage:+# review-sandbox.sh create [--dirty] [--with-deps] # prints the sandbox path on stdout+# review-sandbox.sh clean <path> # one sandbox, refuses anything else+# review-sandbox.sh clean --all # sweep sandboxes untouched for 2h+#+# --dirty carry the uncommitted working tree across, for a scope that includes it+# --with-deps hardlink node_modules in, for agents that run pnpm/playwright/vitest+#+# A git worktree carries no ignored files, so node_modules has to be supplied. It is hardlinked+# rather than symlinked because pnpm treats a symlinked node_modules as foreign and tries to+# purge and reinstall it — through the link, into the real tree. Hardlinks share data, so the+# copy is cheap, but a tool that rewrites a dependency IN PLACE (rather than the usual+# write-temp-then-rename) would still reach the original: don't hand --with-deps to an agent+# whose job is patching libraries.+set -euo pipefail++REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../../.." && pwd)"+SANDBOX_ROOT="${PENTAGI_SANDBOX_ROOT:-${TMPDIR:-/tmp}}/pentagi-review-sandboxes"+# A hardlink cannot cross filesystems, so --with-deps is unusable when $TMPDIR is its own mount+# (tmpfs /tmp, a separate /home, a container volume): `cp -al` fails outright and no sandbox is+# built. This sibling of the repo is on the repo's filesystem by construction.+# Under the escape hatch BOTH roots move: `clean --all` sweeps this one too, so a caller that cannot+# afford a sweep of the repo's parent (the unit test, which otherwise rm -rf's real directories on the+# developer's machine) needs a single variable that contains every path this script may delete.+FALLBACK_ROOT="${PENTAGI_SANDBOX_ROOT:+${PENTAGI_SANDBOX_ROOT}/.pentagi-review-sandboxes}"+FALLBACK_ROOT="${FALLBACK_ROOT:-$(dirname "$REPO_ROOT")/.pentagi-review-sandboxes}"++# Pick a root node_modules can actually be hardlinked into: probe with a real link, fall back to+# the repo's own filesystem when the probe hits EXDEV.+linkable_root() {+ local probe="$SANDBOX_ROOT/.linkprobe"++ mkdir -p "$SANDBOX_ROOT"++ if ln "${BASH_SOURCE[0]}" "$probe" 2>/dev/null; then+ rm -f "$probe"+ echo "$SANDBOX_ROOT"++ return+ fi++ if ! mkdir -p "$FALLBACK_ROOT" 2>/dev/null; then+ echo "review-sandbox: $SANDBOX_ROOT is on another filesystem than the repo and" \+ "$FALLBACK_ROOT is not writable — set PENTAGI_SANDBOX_ROOT to a same-filesystem path" >&2+ exit 2+ fi++ echo "review-sandbox: hardlinks cannot reach $SANDBOX_ROOT — using $FALLBACK_ROOT" >&2+ echo "$FALLBACK_ROOT"+}++create() {+ local carry_dirty="" with_deps="" path root="$SANDBOX_ROOT"++ for arg in "$@"; do+ case "$arg" in+ --dirty) carry_dirty=1 ;;+ --with-deps) with_deps=1 ;;+ *)+ echo "unknown option: $arg" >&2+ exit 2+ ;;+ esac+ done++ if [[ -n "$with_deps" ]]; then+ root="$(linkable_root)"+ fi++ path="$root/wt-$$-$(date +%s)"+ mkdir -p "$root"+ git -C "$REPO_ROOT" worktree add --detach --quiet "$path" HEAD+ # Anything that fails from here leaves a worktree behind, and the caller reads stdout as the+ # sandbox path — so take the worktree down and say so on stderr rather than printing a stub.+ trap 'clean "$path" >/dev/null 2>&1; echo "review-sandbox: failed to prepare $path" >&2' ERR++ if [[ -n "$carry_dirty" ]]; then+ # --binary or a regenerated PNG baseline aborts the patch ("cannot apply binary patch+ # without full index line"). Untracked files are absent from the diff entirely, so a new+ # spec would never reach the sandbox — copy them separately, minus the ignored ones.+ if ! git -C "$REPO_ROOT" diff --quiet HEAD; then+ git -C "$REPO_ROOT" diff HEAD --binary | git -C "$path" apply --allow-empty+ fi++ while IFS= read -r -d '' file; do+ mkdir -p "$path/$(dirname "$file")"+ cp "$REPO_ROOT/$file" "$path/$file"+ done < <(git -C "$REPO_ROOT" ls-files --others --exclude-standard -z)+ fi++ if [[ -n "$with_deps" ]]; then+ for dir in frontend/node_modules node_modules; do+ [[ -d "$REPO_ROOT/$dir" ]] && cp -al "$REPO_ROOT/$dir" "$path/$dir"+ done+ fi++ echo "$path"+}++# `git worktree remove` exits 128 for the main working tree and for any directory that is not a+# worktree, so the rm fallback is what runs for every wrong argument — and being left of `||` it+# does not trip `set -e`. Resolve the target and refuse anything outside the sandbox root before+# going near it. The sweep is opt-in and age-filtered for the same reason: this root is shared by+# every agent on the host, so a bare `clean` used to take out a concurrent agent's live sandbox.+STALE_MINUTES=120++# A worktree directory's own mtime moves only when a top-level entry is added or removed, so it dates+# the sandbox's creation — an agent editing frontend/src/... for hours never refreshes it. Age the+# sandbox by the newest write anywhere inside it instead.+recently_touched() {+ [[ -n "$(find "$1" -mmin "-$STALE_MINUTES" -print -quit 2>/dev/null)" ]]+}++# A strict child of either sandbox root — never a root itself, so a sibling like <root>-old and the+# root's own path are both rejected.+contained() {+ local candidate="$1" root++ for root in "$SANDBOX_ROOT" "$FALLBACK_ROOT"; do+ mkdir -p "$root"++ case "$candidate" in+ "$(cd "$root" && pwd -P)"/?*) return 0 ;;+ esac+ done++ return 1+}++clean() {+ local target="${1:-}" root resolved++ case "$target" in+ --all)+ for root in "$SANDBOX_ROOT" "$FALLBACK_ROOT"; do+ # The roots are derived, not passed in: naming them is how a caller — or a test —+ # can tell where this is about to delete.+ echo "swept $root"+ for path in "$root"/wt-*; do+ if [[ -d "$path" ]] && ! recently_touched "$path"; then+ rm -rf "$path"+ fi+ done+ done+ ;;+ '')+ echo "review-sandbox: clean needs a sandbox path, or --all to sweep stale ones" >&2+ exit 2+ ;;+ *)+ resolved="$(cd "$(dirname "$target")" 2>/dev/null && pwd -P || true)/$(basename "$target")"++ case "$resolved" in+ */. | */..) resolved="" ;;+ *) contained "$resolved" || resolved="" ;;+ esac++ if [[ -z "$resolved" ]]; then+ echo "review-sandbox: refusing to clean '$target' — not a sandbox under" \+ "$SANDBOX_ROOT or $FALLBACK_ROOT" >&2+ exit 2+ fi++ git -C "$REPO_ROOT" worktree remove --force "$resolved" || rm -rf "$resolved"+ ;;+ esac++ git -C "$REPO_ROOT" worktree prune+}++case "${1:-}" in+ create)+ shift+ create "$@"+ ;;+ clean) clean "${2:-}" ;;+ *)+ echo "usage: $(basename "$0") create [--dirty] [--with-deps] | clean <path>|--all" >&2+ exit 2+ ;;+esacdiff --git a/frontend/e2e/tools/review-sandbox.unit.test.ts b/frontend/e2e/tools/review-sandbox.unit.test.tsnew file mode 100644index 00000000..7d81500a--- /dev/null+++ b/frontend/e2e/tools/review-sandbox.unit.test.ts@@ -0,0 +1,148 @@+import { execFileSync } from 'node:child_process';+import { existsSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { afterEach, beforeEach, describe, expect, it } from 'vitest';++const SCRIPT = join(__dirname, 'review-sandbox.sh');++let sandboxRoot = '';++// TMPDIR alone does NOT contain this script: `clean --all` also sweeps a fallback root derived from+// the script's own location, so a bare `pnpm test` used to rm -rf real directories in the repo's+// parent. PENTAGI_SANDBOX_ROOT moves both roots, which is what keeps a run inside its own tree.+const run = (...args: string[]) => {+ try {+ const stdout = execFileSync(SCRIPT, args, {+ encoding: 'utf8',+ env: { ...process.env, PENTAGI_SANDBOX_ROOT: sandboxRoot, TMPDIR: sandboxRoot },+ stdio: ['ignore', 'pipe', 'pipe'],+ });++ return { code: 0, stdout: stdout.trim() };+ } catch (error) {+ const failure = error as { status: number; stdout: string };++ return { code: failure.status, stdout: failure.stdout.trim() };+ }+};++// -h, because the checkout contains symlinks and touch would otherwise age their targets while the+// links themselves keep a current mtime — which is what the sweep reads.+const backdate = (sandbox: string) =>+ execFileSync('find', [sandbox, '-exec', 'touch', '-h', '-t', '202001010000', '{}', '+']);++beforeEach(() => {+ sandboxRoot = mkdtempSync(join(tmpdir(), 'sandbox-test-'));+});++afterEach(() => {+ rmSync(sandboxRoot, { force: true, recursive: true });+ // The worktrees a case created are registered in the real repo, so dropping the directory is+ // only half of it — an unpruned registration would follow the developer around.+ execFileSync('git', ['worktree', 'prune'], { cwd: join(__dirname, '..', '..') });+});++describe('review-sandbox clean — containment', () => {+ it('removes a sandbox it created', () => {+ const { stdout: sandbox } = run('create');++ expect(existsSync(sandbox)).toBe(true);+ expect(run('clean', sandbox).code).toBe(0);+ expect(existsSync(sandbox)).toBe(false);+ });++ it('refuses a path outside the sandbox root and leaves it intact', () => {+ const outsider = mkdtempSync(join(tmpdir(), 'outsider-'));++ writeFileSync(join(outsider, 'keep-me'), 'payload');++ expect(run('clean', outsider).code).not.toBe(0);+ expect(existsSync(join(outsider, 'keep-me'))).toBe(true);++ rmSync(outsider, { force: true, recursive: true });+ });++ it('refuses the sandbox root itself, and a sibling of it', () => {+ const { stdout: sandbox } = run('create');+ const root = join(sandboxRoot, 'pentagi-review-sandboxes');++ expect(run('clean', root).code).not.toBe(0);+ expect(run('clean', `${root}-old`).code).not.toBe(0);+ expect(existsSync(sandbox)).toBe(true);+ });++ it('refuses a traversal that lands outside the root', () => {+ const { stdout: sandbox } = run('create');++ expect(run('clean', `${sandbox}/../../..`).code).not.toBe(0);+ expect(existsSync(sandbox)).toBe(true);+ });+});++describe('review-sandbox create — where the sandbox lands', () => {+ // `clean --all` also sweeps a root derived from the script's own location, which no TMPDIR can+ // move: before PENTAGI_SANDBOX_ROOT governed it too, running this very file deleted real stale+ // sandboxes from the repo's parent directory on the developer's machine.+ it('sweeps no root outside the one it was given', () => {+ const swept = run('clean', '--all')+ .stdout.split('\n')+ .filter((line) => line.startsWith('swept '))+ .map((line) => line.slice('swept '.length));++ expect(swept.length, 'clean --all names every root it sweeps').toBeGreaterThan(0);++ for (const root of swept) {+ expect(root.startsWith(sandboxRoot), `${root} is outside ${sandboxRoot}`).toBe(true);+ }+ });++ it('honours PENTAGI_SANDBOX_ROOT, the escape hatch for a $TMPDIR on another filesystem', () => {+ const override = mkdtempSync(join(tmpdir(), 'override-root-'));+ const sandbox = execFileSync(SCRIPT, ['create'], {+ encoding: 'utf8',+ env: { ...process.env, PENTAGI_SANDBOX_ROOT: override, TMPDIR: sandboxRoot },+ }).trim();++ expect(sandbox.startsWith(`${override}/pentagi-review-sandboxes/`)).toBe(true);++ execFileSync(SCRIPT, ['clean', sandbox], {+ env: { ...process.env, PENTAGI_SANDBOX_ROOT: override, TMPDIR: sandboxRoot },+ });+ expect(existsSync(sandbox)).toBe(false);++ rmSync(override, { force: true, recursive: true });+ });+});++describe('review-sandbox clean — the sweep', () => {+ it('refuses a bare clean rather than taking the whole root', () => {+ const { stdout: sandbox } = run('create');++ expect(run('clean').code).not.toBe(0);+ expect(existsSync(sandbox)).toBe(true);+ });++ it('sweeps only what has gone stale', () => {+ const { stdout: fresh } = run('create');++ expect(run('clean', '--all').code).toBe(0);+ expect(existsSync(fresh), 'a live sandbox survives the sweep').toBe(true);++ backdate(fresh);+ expect(run('clean', '--all').code).toBe(0);+ expect(existsSync(fresh), 'a stale sandbox is swept').toBe(false);+ });++ it('keeps a sandbox an agent is still working in, however deep the edit sits', () => {+ const { stdout: busy } = run('create');++ backdate(busy);+ writeFileSync(join(busy, 'frontend', 'src', 'probe.tsx'), 'export const probe = 1;\n');++ expect(run('clean', '--all').code).toBe(0);+ expect(existsSync(busy), 'a live sandbox survives the sweep').toBe(true);++ expect(run('clean', busy).code).toBe(0);+ });+});diff --git a/frontend/e2e/tools/run-local-tier.sh b/frontend/e2e/tools/run-local-tier.shindex 2e83c0f5..f46ffcb3 100755--- a/frontend/e2e/tools/run-local-tier.sh+++ b/frontend/e2e/tools/run-local-tier.sh@@ -23,9 +23,8 @@ compose() {# sandboxes for any flow id starting with 9.remove_e2e_sandboxes() {docker ps -aq --filter 'name=^/?pentagi-terminal-9[0-9]{4,}$' | xargs -r docker rm -f- # Each sandbox also gets a `<container>-data` volume, created on the socket- # outside the compose project — removing the container leaves it behind, so- # every Tier-2 run used to add one more dangling volume.+ # Each sandbox also gets a `<container>-data` volume, created on the socket outside the compose+ # project — removing the container leaves it behind, so it needs its own cleanup.docker volume ls -q --filter 'name=^pentagi-terminal-9[0-9]{4,}-data$' | xargs -r docker volume rm}diff --git a/frontend/graphql-schema.graphql b/frontend/graphql-schema.graphqlindex 115c39e1..0547b3d0 100644--- a/frontend/graphql-schema.graphql+++ b/frontend/graphql-schema.graphql@@ -321,6 +321,10 @@ fragment agentConfigFragment on AgentConfig {repetitionPenaltyfrequencyPenaltypresencePenalty+ minP+ n+ json+ responseMimeTypereasoning {modeeffortdiff --git a/frontend/src/components/shared/detail-navigation/use-navigation.ts b/frontend/src/components/shared/detail-navigation/use-navigation.tsindex 67541ff3..3f7fddf7 100644--- a/frontend/src/components/shared/detail-navigation/use-navigation.ts+++ b/frontend/src/components/shared/detail-navigation/use-navigation.ts@@ -1,6 +1,6 @@import { useMemo } from 'react';-import { createTextMatcher } from './text-filter';+import { createTextMatcher } from '@/lib/text-filter';interface NavigationInput<T> {currentId: null | string | undefined;diff --git a/frontend/src/components/shared/file-manager/file-manager.tsx b/frontend/src/components/shared/file-manager/file-manager.tsxindex 895174f5..e576a066 100644--- a/frontend/src/components/shared/file-manager/file-manager.tsx+++ b/frontend/src/components/shared/file-manager/file-manager.tsx@@ -365,7 +365,7 @@ export function FileManager({return (<Buttonaria-label={sortHeaderAriaLabel(column, direction)}- className="text-muted-foreground hover:text-primary -mx-2 flex h-auto justify-start gap-1.5 px-2 py-1 text-xs font-medium no-underline hover:no-underline"+ className="text-muted-foreground hover:text-link -mx-2 flex h-auto justify-start gap-1.5 px-2 py-1 text-xs font-medium no-underline hover:no-underline"onClick={() => toggleSort(column)}variant="link">diff --git a/frontend/src/components/shared/inline-edit/inline-edit-input.test.tsx b/frontend/src/components/shared/inline-edit/inline-edit-input.test.tsxnew file mode 100644index 00000000..80ffa192--- /dev/null+++ b/frontend/src/components/shared/inline-edit/inline-edit-input.test.tsx@@ -0,0 +1,57 @@+import { fireEvent, render, screen } from '@testing-library/react';+import { describe, expect, it, vi } from 'vitest';++import { InlineEditInput } from './inline-edit-input';++const renderInput = (busy: boolean) => {+ const onCancel = vi.fn();+ const onSave = vi.fn();++ render(+ <InlineEditInput+ busy={busy}+ defaultValue="Alpha"+ onCancel={onCancel}+ onSave={onSave}+ />,+ );++ return { input: screen.getByRole('textbox'), onCancel, onSave };+};++describe('InlineEditInput', () => {+ it('saves on Enter and cancels on Escape while idle', () => {+ const { input, onCancel, onSave } = renderInput(false);++ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onSave).toHaveBeenCalledTimes(1);+ expect(onCancel).not.toHaveBeenCalled();++ fireEvent.keyDown(input, { key: 'Escape' });+ expect(onCancel).toHaveBeenCalledTimes(1);+ });++ it('ignores Enter while busy, matching the disabled Save button', () => {+ const { input, onSave } = renderInput(true);++ expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled();++ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onSave).not.toHaveBeenCalled();+ });++ it('ignores Escape while busy, matching the disabled Cancel button', () => {+ const { input, onCancel } = renderInput(true);++ expect(screen.getByRole('button', { name: 'Cancel' })).toBeDisabled();++ fireEvent.keyDown(input, { key: 'Escape' });+ expect(onCancel).not.toHaveBeenCalled();+ });++ it('keeps the input editable while busy', () => {+ const { input } = renderInput(true);++ expect(input).not.toBeDisabled();+ });+});diff --git a/frontend/src/components/shared/inline-edit/inline-edit-input.tsx b/frontend/src/components/shared/inline-edit/inline-edit-input.tsxindex 5abecd0f..127ced6c 100644--- a/frontend/src/components/shared/inline-edit/inline-edit-input.tsx+++ b/frontend/src/components/shared/inline-edit/inline-edit-input.tsx@@ -13,7 +13,10 @@ interface InlineEditInputProps {* so focus must be requested explicitly.*/autoFocus?: boolean;- /** Disable the Save + Cancel buttons while a mutation is in flight. The input stays editable. */+ /**+ * Inert Save + Cancel while a mutation is in flight — both the buttons and+ * the `Enter`/`Escape` shortcuts. The input itself stays editable.+ */busy?: boolean;/** Optional className passed through to the outer `<InputGroup>`. */className?: string;@@ -66,6 +69,10 @@ export function InlineEditInput({placeholder,}: InlineEditInputProps) {const handleKeyDown = (event: KeyboardEvent<HTMLInputElement>) => {+ if (busy) {+ return;+ }+if (event.key === 'Enter') {event.preventDefault();onSave();diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-code-fence.test.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-code-fence.test.tsindex 01bdaef4..d90dfe77 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-code-fence.test.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-code-fence.test.ts@@ -25,7 +25,29 @@ describe('code-block fence lengthening — a block documenting a ``` fence stays});it('leaves an ordinary code block on a 3-backtick fence', () => {- expect(roundTrip('```js\nconst x = 1;\n```')).toContain('```js');+ expect(roundTrip('```js\nconst x = 1;\n```')).toBe('```js\nconst x = 1;\n```');+ });+});++// A tilde fence's info string may hold a backtick; a backtick fence's may not — re-emitting such a block on a+// backtick fence produces an opening line that is no longer a fence at all, and the code block is destroyed.+describe('code-block fence character — a language containing a backtick keeps its tilde fence', () => {+ it('re-emits a tilde fence so the block survives reload', () => {+ const src = '~~~`js`\nconst x = 1;\n~~~';+ const out = roundTrip(src);++ expect(out).toBe(src);+ expect(nodeCount(out, 'codeBlock')).toBe(1);+ expect(roundTrip(out)).toBe(out);+ });++ it('widens the tilde fence past an inner ~~~ run', () => {+ const src = '~~~~`js`\ninner\n~~~\nafter\n~~~~';+ const out = roundTrip(src);++ expect(out).toBe(src);+ expect(nodeCount(out, 'codeBlock')).toBe(1);+ expect(roundTrip(out)).toBe(out);});});@@ -47,23 +69,93 @@ describe('code-block language attribute', () => {it('round-trips the language on the fence for several languages', () => {for (const lang of ['ts', 'python', 'bash', 'json', 'go']) {- expect(roundTrip(`\`\`\`${lang}\ncode\n\`\`\``)).toContain(`\`\`\`${lang}`);+ expect(roundTrip(`\`\`\`${lang}\ncode\n\`\`\``)).toBe(`\`\`\`${lang}\ncode\n\`\`\``);}});});-// KNOWN UPSTREAM LIMITATION — not fixable in this layer. @tiptap/markdown derives a MARK's opening/closing-// delimiter by rendering it around a fixed placeholder (getMarkOpening/getMarkClosing), so the `code` mark's-// real content is never seen at delimiter time and it always emits a SINGLE backtick. A code span whose-// content contains a backtick therefore collapses on save and never converges. A NODE (codeBlock, above) DOES-// receive its real content and is content-aware — hence the fence widening is fixable but this is not. Pinned so-// the gap stays visible: this test turns RED (the canary to revisit it) if a future @tiptap/markdown makes mark-// delimiters content-aware and the span starts round-tripping.-describe('inline code containing a backtick — known lossy on save (upstream mark-delimiter limitation)', () => {- it('collapses a backtick-containing code span (does not round-trip)', () => {+describe('code-block highlighting', () => {+ const highlightClasses = (md: string): string[] => {+ const element = document.createElement('div');+ const editor = new Editor({+ content: md,+ contentType: 'markdown',+ element,+ extensions: createMarkdownExtensions(),+ });+ const classes = [...editor.view.dom.querySelectorAll('pre code span')].flatMap((span) => [...span.classList]);+ editor.destroy();++ return [...new Set(classes)];+ };++ const SNIPPET = 'const total = items.map((item) => item.price).reduce((a, b) => a + b, 0);';++ it('highlights a fence that declares its language', () => {+ expect(highlightClasses(`\`\`\`javascript\n${SNIPPET}\n\`\`\``)).toContain('hljs-keyword');+ });++ // An undeclared fence must resolve to the plaintext grammar, not to highlightAuto: auto-detection re-runs+ // over every code block in the document on each keystroke inside one, and it is quadratic in document size.+ it('leaves a fence with no language unhighlighted rather than guessing', () => {+ expect(highlightClasses(`\`\`\`\n${SNIPPET}\n\`\`\``)).toEqual([]);+ });+});++// Guards the two paired seams of the code-span fix: serializeCodeSpan (markdown-editor-marked.ts) and the+// code-mark renderMarkdown override that zeroes the placeholder fence. A regression in either turns these red.+describe('inline code containing a backtick round-trips exactly', () => {+ it('preserves and converges a backtick-containing code span', () => {const out = roundTrip('x ``a `b` c`` y');- expect(out).not.toContain('``a `b` c``');- expect(roundTrip(out)).not.toBe(out);+ expect(out).toContain('``a `b` c``');+ expect(roundTrip(out)).toBe(out);+ });++ it.each([+ 'a ``` `XSS` ``` b',+ 'x ``` `key` = value ``` y',+ 'run ``` echo `whoami` ``` now',+ 'p ```` a```b ```` q',+ 'a `simple` b',+ 'use `{{.Host}}` here',+ ])('reaches a stable fixed point for %j', (src) => {+ const once = roundTrip(src);++ expect(roundTrip(once)).toBe(once);+ });+});++// A block created in the editor carries no author-chosen language, so it must serialize as a bare fence.+// `defaultLanguage` exists for the highlight plugin (`attrs.language || defaultLanguage`); leaking it into+// the attribute default writes ```plaintext into every prompt, template and knowledge document saved.+describe('a code block created in the editor', () => {+ const created = (): { language: null | string; markdown: string } => {+ const editor = new Editor({+ content: 'hello',+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });++ editor.commands.selectAll();+ editor.commands.toggleCodeBlock();++ const node = (editor.getJSON().content ?? []).find((candidate) => candidate.type === 'codeBlock');+ const result = {+ language: (node?.attrs?.language as null | string) ?? null,+ markdown: editor.getMarkdown(),+ };++ editor.destroy();++ return result;+ };++ it('serializes as a bare fence, not as ```plaintext', () => {+ const { language, markdown } = created();++ expect(language).toBeNull();+ expect(markdown).toContain('```\nhello\n```');+ expect(markdown).not.toContain('plaintext');});});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.test.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.test.tsindex d70c2dfd..810fb579 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.test.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.test.ts@@ -1,7 +1,9 @@import { Editor } from '@tiptap/core';+import { OrderedList, TaskList } from '@tiptap/extension-list';+import { TextSelection } from '@tiptap/pm/state';import { beforeAll, describe, expect, it } from 'vitest';-import { createMarkdownExtensions } from './markdown-editor-extensions';+import { createMarkdownExtensions, isBlockApplied } from './markdown-editor-extensions';import { roundTrip, setupEditorJsdom, structuralCounts } from './markdown-editor-test-setup';import { findVariableOccurrences } from './markdown-editor-variable-highlight';@@ -489,3 +491,745 @@ describe('multi-paragraph table cell does not persist a raw control byte on saveexpect(md).toContain('z');});});++type MarkdownTokenizerShape = {+ start?: (src: string) => number;+ tokenize: (src: string, tokens: unknown[], lexer: unknown) => unknown;+};++describe('list tokenizers are guarded against the upstream per-block full-source split', () => {+ type Layer = {+ config: { markdownTokenizer?: MarkdownTokenizerShape };+ parent?: Layer;+ };++ // `.extend()` MERGES config into the child, so every wrapper layer reports a `markdownTokenizer` and+ // walking to "the first layer that has one" lands on a wrapper, not on upstream. The root of the chain is+ // the only unambiguous handle on the untouched implementation.+ const rootOf = (layer: Layer): Layer => {+ let current = layer;++ while (current.parent) {+ current = current.parent;+ }++ return current;+ };++ const extensionOf = (name: string) => {+ const editor = new Editor({ content: '', extensions: createMarkdownExtensions() });+ const extension = editor.extensionManager.extensions.find((e) => e.name === name) as Layer | undefined;++ editor.destroy();++ return extension;+ };++ const tokenizerOf = (name: string) => extensionOf(name)?.config.markdownTokenizer;++ const upstreamTokenizerOf = (name: string) => {+ const extension = extensionOf(name);++ return extension ? rootOf(extension).config.markdownTokenizer : undefined;+ };++ it.each([+ ['orderedList', OrderedList],+ ['taskList', TaskList],+ ])('%s tokenize is wrapped, not the upstream function', (name, upstream) => {+ const ours = tokenizerOf(name);+ const theirs = (upstream.config as { markdownTokenizer?: { tokenize: unknown } }).markdownTokenizer;++ expect(theirs?.tokenize).toBeTypeOf('function');+ expect(ours?.tokenize).toBeTypeOf('function');+ // An unwrapped tokenizer splits the whole remaining document at every block boundary — O(n²) loads.+ expect(ours?.tokenize).not.toBe(theirs?.tokenize);+ });++ // The guard must stay at least as wide as ORDERED_LIST_MARKER_PATTERN+ // (`\d+|[ivxlcdmIVXLCDM]+|[a-zA-Z]{1,2}`); a marker form it rejects is silently demoted to a paragraph.+ it.each([+ ['single digit', '1. alpha\n2. beta'],+ ['multi digit', '10. alpha\n11. beta'],+ ['lower roman', 'i. alpha\nii. beta'],+ ['upper roman', 'IX. alpha\nX. beta'],+ ['single alpha', 'a. alpha\nb. beta'],+ ['two-letter alpha', 'aa. alpha\nab. beta'],+ ['two-letter upper alpha', 'AB. alpha\nAC. beta'],+ ])('ordered list with a %s marker survives the guard', (_name, md) => {+ // Byte equality alone is blind here: a demoted paragraph holding the same two lines re-serialises+ // to identical bytes, so the node type is the only assertion that can see the marker being rejected.+ expect(structuralCounts(roundTrip(md)).orderedList).toBe(1);+ expect(roundTrip(md)).toBe(md);+ });++ // Upstream normalises `)` to `.` and drops a leading indent (verified identical without the guard), so+ // these two assert only what the guard governs: the block is still a list, not demoted to a paragraph.+ it.each([+ ['paren delimiter', 'aa) alpha\nab) beta'],+ ['indented', ' 1. alpha\n 2. beta'],+ ])('ordered list with a %s marker is not demoted to a paragraph', (_name, md) => {+ expect(structuralCounts(roundTrip(md)).orderedList).toBe(1);+ });++ // Identity alone would also hold for a pass-through wrapper, which would silently restore the O(n^2)+ // load. This is the assertion that the short-circuit itself is wired.+ it.each(['orderedList', 'taskList'])(+ '%s never reaches upstream tokenize when the source does not open a list',+ (name) => {+ const upstream = upstreamTokenizerOf(name);+ const wrapped = tokenizerOf(name);++ expect(upstream?.tokenize).toBeTypeOf('function');++ const real = upstream!.tokenize;+ let calls = 0;++ upstream!.tokenize = (...args: Parameters<typeof real>) => {+ calls += 1;++ return real(...args);+ };++ try {+ expect(wrapped?.tokenize('plain paragraph line\n'.repeat(500), [], undefined)).toBeUndefined();+ expect(calls).toBe(0);+ } finally {+ upstream!.tokenize = real;+ }+ },+ );++ it.each([+ ['dash unchecked', '- [ ] open'],+ ['dash checked', '- [x] done'],+ ['asterisk', '* [ ] open'],+ ['plus', '+ [x] done'],+ ['upper X', '- [X] done'],+ ])('task list with a %s marker survives the guard', (_name, md) => {+ expect(structuralCounts(roundTrip(md)).taskList).toBe(1);+ });+});++describe('block toggles are reversible under a whole-document selection', () => {+ const CONTROLS = [+ ['blockquote', 'toggleBlockquote'],+ ['bulletList', 'toggleBulletList'],+ ['orderedList', 'toggleOrderedList'],+ ['taskList', 'toggleTaskList'],+ ['codeBlock', 'toggleCodeBlock'],+ ] as const;++ const apply = (editor: Editor, command: string) =>+ (editor.chain().focus() as unknown as Record<string, () => { run: () => boolean }>)[command]!().run();++ const editorWith = (markdown: string) =>+ new Editor({ content: markdown, contentType: 'markdown', extensions: createMarkdownExtensions() });++ it.each(CONTROLS)('%s applied over Ctrl+A is removed by a second press', (node, command) => {+ const editor = editorWith('sample text');++ editor.commands.selectAll();+ apply(editor, command);++ expect(structuralCounts(editor.getMarkdown())[node]).toBe(1);++ editor.commands.selectAll();+ apply(editor, command);++ const out = editor.getMarkdown();++ editor.destroy();++ // Node counts, not bytes: a second wrap nests a quote / adds an empty item, and several of those+ // re-serialise to text that still "contains" the original words.+ expect(structuralCounts(out)[node]).toBeUndefined();+ expect(out.trim()).toBe('sample text');+ });++ it.each(CONTROLS)('%s stays reversible over a multi-block Ctrl+A', (node, command) => {+ const editor = editorWith('one\n\ntwo\n\nthree');++ editor.commands.selectAll();+ apply(editor, command);+ editor.commands.selectAll();+ apply(editor, command);++ const out = editor.getMarkdown();++ editor.destroy();++ expect(structuralCounts(out)[node]).toBeUndefined();+ expect(words(out).sort()).toEqual(['one', 'three', 'two']);+ });++ // The keyboard shortcuts (Mod-Shift-b / Mod-Alt-c / Mod-Shift-7..9) go through `editor.commands.x()`,+ // not through a chain, so the retarget has to hold on that path too or only the toolbar is fixed.+ it.each(CONTROLS)('%s is reversible through editor.commands, the path the shortcuts use', (node, command) => {+ const editor = editorWith('sample text');+ const run = () => (editor.commands as unknown as Record<string, () => boolean>)[command]!();++ editor.commands.selectAll();+ run();++ expect(structuralCounts(editor.getMarkdown())[node]).toBe(1);++ editor.commands.selectAll();+ run();++ const out = editor.getMarkdown();++ editor.destroy();++ expect(structuralCounts(out)[node]).toBeUndefined();+ expect(out.trim()).toBe('sample text');+ });++ it.each(CONTROLS)('%s is unaffected for a caret selection', (node, command) => {+ const editor = editorWith('sample text');++ editor.commands.setTextSelection(4);+ apply(editor, command);++ expect(structuralCounts(editor.getMarkdown())[node]).toBe(1);++ apply(editor, command);++ const out = editor.getMarkdown();++ editor.destroy();++ expect(structuralCounts(out)[node]).toBeUndefined();+ expect(out.trim()).toBe('sample text');+ });+});++describe('a task checkbox is announced with its own text, not its subtree', () => {+ const labelsFor = (markdown: string) => {+ const element = document.createElement('div');++ document.body.appendChild(element);++ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ element,+ extensions: createMarkdownExtensions(),+ });+ const labels = [...element.querySelectorAll('input[type=checkbox]')].map(+ (checkbox) => (checkbox as HTMLInputElement).ariaLabel,+ );++ editor.destroy();+ element.remove();++ return labels;+ };++ it('a parent task does not absorb the text of its nested tasks', () => {+ expect(labelsFor('- [ ] task open\n- [x] task done\n - [ ] nested open\n - [x] nested done\n')).toEqual([+ 'Task item checkbox for task open',+ 'Task item checkbox for task done',+ 'Task item checkbox for nested open',+ 'Task item checkbox for nested done',+ ]);+ });++ it('an empty task still gets a name', () => {+ expect(labelsFor('- [ ] \n')).toEqual(['Task item checkbox for empty task item']);+ });+});++describe('whole-document block toggles across document shapes', () => {+ const TOGGLES = [+ ['blockquote', 'toggleBlockquote'],+ ['bulletList', 'toggleBulletList'],+ ['orderedList', 'toggleOrderedList'],+ ['taskList', 'toggleTaskList'],+ ['codeBlock', 'toggleCodeBlock'],+ ] as const;++ // The shapes whose first child is not a textblock are the ones a hardcoded start position gets wrong; the+ // plain ones pass either way, so trimming the list to them takes the coverage away.+ const SHAPES = [+ ['single paragraph', 'sample text'],+ ['three paragraphs', 'one\n\ntwo\n\nthree'],+ ['table only', '| A | B |\n| --- | --- |\n| 1 | 2 |'],+ ['table then paragraph', '| A | B |\n| --- | --- |\n| 1 | 2 |\n\ntail'],+ ['list only', '- a\n- b\n- c'],+ ['nested list', '- a\n - b\n- c'],+ ['leading rule', '---\n\nbody text'],+ ['leading image', '\n\nbody text'],+ ['leading heading', '# Title\n\nbody'],+ ['fenced code only', '```js\nconst a = 1;\n```'],+ ['already quoted', '> quoted\n\nplain'],+ ] as const;++ const editorWith = (markdown: string) =>+ new Editor({ content: markdown, contentType: 'markdown', extensions: createMarkdownExtensions() });++ const press = (editor: Editor, command: string) =>+ (editor.commands as unknown as Record<string, () => boolean>)[command]!();++ const topLevelTypes = (editor: Editor) => {+ const types: string[] = [];++ editor.state.doc.forEach((node) => types.push(node.type.name));++ return types;+ };++ // Conversions that drop an attribute the target block cannot carry (a listItem holds no heading level, a+ // paragraph no fence info-string). Measured irreversible with a plain caret too, so making these byte-exact+ // is an upstream change, not a bug in this path.+ const LOSSY = new Set([+ 'fenced code only|toggleBulletList',+ 'fenced code only|toggleCodeBlock',+ 'fenced code only|toggleOrderedList',+ 'fenced code only|toggleTaskList',+ 'leading heading|toggleBulletList',+ 'leading heading|toggleCodeBlock',+ 'leading heading|toggleOrderedList',+ 'leading heading|toggleTaskList',+ 'list only|toggleOrderedList',+ 'list only|toggleTaskList',+ 'nested list|toggleOrderedList',+ ]);++ const cases = SHAPES.flatMap(([shape, source]) =>+ TOGGLES.map(([, command]) => ({ command, isLossy: LOSSY.has(`${shape}|${command}`), shape, source })),+ );++ // structuralCounts is blind to the destruction this guards: a rule left OUTSIDE the quote and one inside it+ // produce identical counts, and a table rebuilt around itself still counts one table.+ it.each(cases)(+ '$shape + $command either applies reversibly or refuses harmlessly',+ ({ command, isLossy, source }) => {+ const editor = editorWith(source);++ // Baseline AFTER selectAll: TrailingNode materialises its empty paragraph on that transaction, so a+ // baseline taken before it would blame the toggle for a block the selection itself added.+ editor.commands.selectAll();++ const original = editor.getMarkdown();+ const originalText = editor.state.doc.textContent;+ const originalTypes = topLevelTypes(editor);+ const applied = press(editor, command);++ if (!applied) {+ const { selection } = editor.state;++ expect(editor.getMarkdown()).toBe(original);+ expect(topLevelTypes(editor)).toEqual(originalTypes);+ expect(selection.empty).toBe(false);+ editor.destroy();++ return;+ }++ expect(editor.getMarkdown()).not.toBe(original);++ editor.commands.selectAll();+ press(editor, command);++ const out = editor.getMarkdown();+ const outText = editor.state.doc.textContent;++ editor.destroy();++ if (isLossy) {+ // Text content, not markdown: the declared loss is an attribute (heading level, fence info-string),+ // and comparing source words would count `js` from ```js as content.+ sameWords(originalText, outText);++ return;+ }++ expect(out.trimEnd()).toBe(original.trimEnd());+ },+ );++ // Selecting everything with the mouse is a TextSelection, so a guard keyed on AllSelection misses it entirely+ // and leaves this path on the unfixed code.+ it.each(TOGGLES)('%s is reversible under a drag-style whole-document selection', (_node, command) => {+ const editor = editorWith('one\n\ntwo');++ const selectByDrag = () => {+ const { doc } = editor.state;++ editor.view.dispatch(+ editor.state.tr.setSelection(TextSelection.between(doc.resolve(1), doc.resolve(doc.content.size - 1))),+ );+ };++ selectByDrag();++ expect(editor.state.selection).toBeInstanceOf(TextSelection);+ expect(press(editor, command)).toBe(true);++ selectByDrag();+ press(editor, command);++ const out = editor.getMarkdown();++ editor.destroy();++ expect(out.trimEnd()).toBe('one\n\ntwo');+ });++ it.each(TOGGLES)('%s reports the same state to the toolbar as its own click performs', (node, command) => {+ const editor = editorWith('sample text');++ editor.commands.selectAll();++ expect(isBlockApplied(editor, node)).toBe(false);++ press(editor, command);+ editor.commands.selectAll();++ expect(isBlockApplied(editor, node)).toBe(true);++ press(editor, command);+ editor.commands.selectAll();++ expect(isBlockApplied(editor, node)).toBe(false);+ editor.destroy();+ });++ it('reports an already-quoted document as quoted under a whole-document selection', () => {+ const editor = editorWith('> quoted');++ editor.commands.selectAll();++ expect(isBlockApplied(editor, 'blockquote')).toBe(true);+ editor.destroy();+ });++ it.each(TOGGLES)('%s leaves the document untouched when only probed through can()', (_node, command) => {+ const editor = editorWith('| A | B |\n| --- | --- |\n| 1 | 2 |');++ editor.commands.selectAll();++ const original = editor.getMarkdown();++ (editor.can() as unknown as Record<string, () => boolean>)[command]!();++ const out = editor.getMarkdown();++ editor.destroy();++ expect(out).toBe(original);+ });++ // Only these commands may drive a disabled state in the toolbar. `can()` runs with dispatch undefined, and+ // `toggleList`'s `clearNodes()` fallback is a no-op there, so the three list kinds, toggleCodeBlock and+ // toggleHeading report false for conversions that work. A tiptap upgrade that makes one faithful may add it.+ it.each([+ [+ 'toggleBlockquote',+ (editor: Editor) => editor.can().toggleBlockquote(),+ (editor: Editor) => editor.commands.toggleBlockquote(),+ ],+ ['toggleBold', (editor: Editor) => editor.can().toggleBold(), (editor: Editor) => editor.commands.toggleBold()],+ ['toggleCode', (editor: Editor) => editor.can().toggleCode(), (editor: Editor) => editor.commands.toggleCode()],+ [+ 'toggleItalic',+ (editor: Editor) => editor.can().toggleItalic(),+ (editor: Editor) => editor.commands.toggleItalic(),+ ],+ [+ 'toggleStrike',+ (editor: Editor) => editor.can().toggleStrike(),+ (editor: Editor) => editor.commands.toggleStrike(),+ ],+ [+ 'setLink',+ (editor: Editor) => editor.can().setLink({ href: 'https://example.com' }),+ (editor: Editor) => editor.commands.setLink({ href: 'https://example.com' }),+ ],+ ] as const)(+ '%s answers can() exactly as it performs, on every shape and both selection modes',+ (_name, ask, perform) => {+ const disagreements: string[] = [];++ for (const [shape, source] of SHAPES) {+ for (const mode of ['caret', 'selectAll'] as const) {+ const probe = editorWith(source);++ if (mode === 'caret') {+ probe.commands.setTextSelection(3);+ } else {+ probe.commands.selectAll();+ }++ const canSays = ask(probe);+ const commandSays = perform(probe);++ probe.destroy();++ if (canSays !== commandSays) {+ disagreements.push(`${shape}/${mode}: can=${canSays} command=${commandSays}`);+ }+ }+ }++ expect(disagreements).toEqual([]);+ },+ );++ it('builds exactly one lowlight plugin', () => {+ const editor = new Editor({ content: '', extensions: createMarkdownExtensions() });+ const lowlightPlugins = editor.state.plugins.filter((plugin) =>+ String((plugin as { key?: string }).key).startsWith('lowlight'),+ );++ editor.destroy();++ expect(lowlightPlugins).toHaveLength(1);+ });+});++describe('line-leading block markers are escaped to marked grammar, inline backslashes are not touched', () => {+ // marked's heading is /^ {0,3}(#{1,6})(?=\s|$)…/ and its blockquote is /^( {0,3}> ?…)+/ — the space after+ // the marker is a lookahead, not a literal. A serializer that escapes only `# `/`> ` leaves these live, and+ // the block type flips on the next load.+ // Starts from a PARAGRAPH node, not from markdown: `>foo` as stored markdown is legitimately a quote. The+ // defect is that a paragraph the user typed serializes to bytes that read back as a different block.+ const paragraphSurvives = (text: string) => {+ const editor = new Editor({+ content: { content: [{ content: [{ text, type: 'text' }], type: 'paragraph' }], type: 'doc' },+ extensions: createMarkdownExtensions(),+ });+ const saved = editor.getMarkdown();++ editor.destroy();++ const reloaded = new Editor({+ content: saved,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const out = { counts: structuralCounts(saved), text: reloaded.state.doc.textContent };++ reloaded.destroy();++ return out;+ };++ it.each([+ ['>foo', 'a quote marker with no space'],+ ['#', 'a lone hash'],+ ['###', 'three hashes alone'],+ ['#\tfoo', 'a hash followed by a tab'],+ ['>', 'a lone quote marker'],+ ])('a typed paragraph of %s stays a paragraph (%s)', (text) => {+ expect(paragraphSurvives(text)).toEqual({ counts: {}, text });+ });++ it('leaves a real heading and a real quote alone', () => {+ expect(structuralCounts(roundTrip('# real heading'))).toEqual({ heading: 1 });+ expect(structuralCounts(roundTrip('> real quote'))).toEqual({ blockquote: 1 });+ });++ it('leaves seven hashes as a paragraph, exactly as marked reads them', () => {+ expect(roundTrip('####### seven')).toBe('####### seven');+ });++ // The load side used to unescape `\#`/`\>` at ANY inline position while the serializer only re-escaped them+ // line-leading, so a backslash in the middle of a line was eaten. `\<root\>` is a GNU-grep word boundary;+ // dropping the second backslash changes what the command matches.+ it.each([+ 'use \\# for comments and \\> for redirect',+ "grep '\\<root\\>' /etc/passwd",+ 'sed -e "s/\\>/gt/" file',+ 'shell: cat file \\> out.txt',+ ])('keeps an inline backslash escape byte-identical: %s', (source) => {+ expect(roundTrip(source)).toBe(source);+ });+});++describe('a setext underline after a hard break does not turn the paragraph into a heading', () => {+ const hardBreakParagraph = (first: string, second: string) => {+ const editor = new Editor({+ content: {+ content: [+ {+ content: [{ text: first, type: 'text' }, { type: 'hardBreak' }, { text: second, type: 'text' }],+ type: 'paragraph',+ },+ ],+ type: 'doc',+ },+ extensions: createMarkdownExtensions(),+ });+ const saved = editor.getMarkdown();++ editor.destroy();++ const reloaded = new Editor({+ content: saved,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const out = { counts: structuralCounts(saved), saved, text: reloaded.state.doc.textContent };++ reloaded.destroy();++ return out;+ };++ // marked's lheading run is `(=+|-+) *` — no three-character minimum, and trailing spaces are allowed. A+ // single `-` on the line after a hard break was enough to swallow the paragraph into an H2.+ it.each(['===', '---', '=', '-', '--', '=== '])('a continuation line of %s stays text', (underline) => {+ const result = hardBreakParagraph('foo', underline);++ expect(result.counts).toEqual({});+ expect(result.text).toBe(`foo${underline}`);+ });++ it('leaves a real setext heading in stored markdown alone', () => {+ expect(structuralCounts(roundTrip('Title\n===')).heading).toBe(1);+ });++ // The escape must not leak a literal backslash into the document text, and it must not eat a backslash the+ // author wrote inside a character class.+ it.each(['char class [a-z\\-_] here', 'sed s/a\\=b/x/', 'a \\- b and c \\= d'])(+ 'keeps an inline backslash before = or - byte-identical: %s',+ (source) => {+ expect(roundTrip(source)).toBe(source);+ },+ );+});++describe('brackets in a link label or an image alt do not break the node on reload', () => {+ const reload = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const out = {+ counts: structuralCounts(markdown),+ markdown: editor.getMarkdown(),+ text: editor.state.doc.textContent,+ };++ editor.destroy();++ return out;+ };++ const linkDoc = (label: string) => ({+ content: [+ {+ content: [+ { marks: [{ attrs: { href: 'https://example.com/a' }, type: 'link' }], text: label, type: 'text' },+ ],+ type: 'paragraph',+ },+ ],+ type: 'doc',+ });++ const imageDoc = (alt: string) => ({+ content: [{ attrs: { alt, src: 'https://example.com/a.png' }, type: 'image' }],+ type: 'doc',+ });++ const saveOf = (content: object) => {+ const editor = new Editor({ content, extensions: createMarkdownExtensions() });+ const saved = editor.getMarkdown();++ editor.destroy();++ return saved;+ };++ // A bracket-free label round-trips; the bracket case is handled where the link is inserted, because the+ // label text is serialized by the text path and @tiptap/markdown hands a mark's renderMarkdown a+ // placeholder rather than the text, so the escape cannot live there.+ it.each(['a\\b', 'plain label', 'http://[::1]:8080/x'])('a link label of %s survives a round trip', (label) => {+ const saved = saveOf(linkDoc(label));+ const first = reload(saved);++ expect(first.text).toBe(label);+ expect(reload(first.markdown).markdown).toBe(first.markdown);+ });++ // An unbalanced bracket in alt broke `` outright: the reload parsed ZERO image nodes.+ it.each(['a]b', 'a[b'])('an image alt of %s keeps the image node', (alt) => {+ const saved = saveOf(imageDoc(alt));++ expect(structuralCounts(saved).image).toBe(1);+ expect(reload(saved).markdown).toBe(saved);+ });+});++describe('a URL inserted as its own link label settles instead of growing', () => {+ // The Link popover inserts the URL as the visible text when there is no selection. A `]` in that text+ // closed the markdown label early — `[https://example.com/a]b](…)` — and the serialized form grew on+ // every load+save cycle (measured 50 → 103 → 156 → 260). The form keeps brackets out of the label; this+ // pins the property that matters, that the document converges.+ it.each(['https://example.com/a]b', 'http://[::1]:8080/x', 'https://example.com/plain'])(+ 'inserting %s converges',+ (url) => {+ const editor = new Editor({ content: '', extensions: createMarkdownExtensions() });++ editor+ .chain()+ .insertContent({+ marks: [{ attrs: { href: url }, type: 'link' }],+ text: url.replace(/[[\]]/g, ''),+ type: 'text',+ })+ .run();++ const first = editor.getMarkdown();++ editor.destroy();++ expect(roundTrip(first)).toBe(first);+ },+ );+});++describe('a heading applied over the whole document', () => {+ const apply = (source: string, level: number) => {+ const editor = new Editor({ content: source, contentType: 'markdown', extensions: createMarkdownExtensions() });++ editor.commands.selectAll();+ editor.commands.toggleHeading({ level: level as 1 | 2 | 3 | 4 | 5 | 6 });++ // selectAll materialises TrailingNode's empty paragraph, which serialises as a trailing blank line.+ const out = editor.getMarkdown().trimEnd();++ editor.destroy();++ return out;+ };++ // toggleHeading had no whole-document wrapper, so Ctrl+A + "Heading 2" converted every table cell paragraph+ // to a heading; saved as `| ## h | ## i |`, it reloads as literal cell text and escalates on each save.+ it('leaves table cells alone', () => {+ const source = ['lead', '', '| h | i |', '| --- | --- |', '| x | y |'].join('\n');+ const out = apply(source, 2);++ expect(out).not.toContain('## h');+ expect(out).toContain('| h');+ expect(out).toContain('## lead');+ });++ // The level the user picked has to reach setBlockType — a family that drops the attrs stamps H1 for every+ // choice, and one that compares only the node type reads an all-H1 document as "already Heading 2".+ it('applies the level the user chose, not the schema default', () => {+ expect(apply('intro\n\nsecond', 2)).toBe('## intro\n\n## second');+ });++ it('promotes an all-H1 document to the chosen level instead of demoting it', () => {+ expect(apply('# one\n\n# two', 2)).toBe('## one\n\n## two');+ });++ it('demotes to paragraphs when the chosen level is already applied', () => {+ expect(apply('## one\n\n## two', 2)).toBe('one\n\ntwo');+ });+});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.tsindex 739c1f2d..853c3cf8 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-extensions.ts@@ -1,17 +1,25 @@import type {+ AnyExtension,+ CommandProps,+ Editor,JSONContent,MarkdownParseHelpers,MarkdownParseResult,MarkdownRendererHelpers,MarkdownToken,} from '@tiptap/core';+import type { NodeType, Node as ProseMirrorNode } from '@tiptap/pm/model';+import type { EditorState } from '@tiptap/pm/state';-import { mergeAttributes } from '@tiptap/core';+import { isList, mergeAttributes } from '@tiptap/core';import { CodeBlockLowlight } from '@tiptap/extension-code-block-lowlight';import { Image } from '@tiptap/extension-image';import { TaskItem, TaskList } from '@tiptap/extension-list';import { TableCell, TableHeader, TableRow } from '@tiptap/extension-table';import { Placeholder } from '@tiptap/extensions';+import { NodeRange } from '@tiptap/pm/model';+import { Selection, TextSelection } from '@tiptap/pm/state';+import { findWrapping, liftTarget } from '@tiptap/pm/transform';import StarterKit from '@tiptap/starter-kit';import { common, createLowlight } from 'lowlight';@@ -24,22 +32,349 @@ import { VariableHighlight } from './markdown-editor-variable-highlight';const dropUnderscoreRules = (rules: { find: unknown }[]) =>rules.filter((rule) => !(rule.find instanceof RegExp && rule.find.source.includes('_')));-const longestBacktickRun = (text: string): number =>- (text.match(/`+/g) ?? []).reduce((max, run) => Math.max(max, run.length), 0);+type BlockAttrs = Record<string, unknown> | undefined;+type BlockFamily = {+ isApplied: (type: NodeType, state: EditorState, attrs?: BlockAttrs) => boolean;+ toggle: (type: NodeType, props: CommandProps, delegate: DelegatedToggle, attrs?: BlockAttrs) => boolean;+};+type CommandMap = Record<string, ToggleCommand | undefined>;+type DelegatedToggle = (props?: CommandProps) => boolean;+type ToggleCommand = (...args: never[]) => (props: never) => boolean;+type TopLevelChild = { node: ProseMirrorNode; pos: number };++// Ctrl+A and a mouse drag across everything are different Selection classes but the same intent, so keying off+// `instanceof AllSelection` silently leaves the drag path on the broken code path.+const isWholeDocumentSelection = ({ doc, selection }: EditorState): boolean => {+ const { empty, from, to } = selection;++ return (+ !empty &&+ ((from === 0 && to === doc.content.size) ||+ (from <= Selection.atStart(doc).from && to >= Selection.atEnd(doc).to))+ );+};++// TrailingNode appends its empty paragraph on the selectAll transaction itself, so it is already inside the+// user's selection before any toggle runs. Counting it makes an already-wrapped document read as unwrapped.+const contentChildren = (doc: ProseMirrorNode): TopLevelChild[] => {+ const children: TopLevelChild[] = [];++ doc.forEach((node, pos) => children.push({ node, pos }));++ const last = children.at(-1);++ if (children.length > 1 && last?.node.isTextblock && last.node.content.size === 0) {+ children.pop();+ }++ return children;+};++const contentSpan = (children: TopLevelChild[]) => {+ const last = children.at(-1)!;++ return { end: last.pos + last.node.nodeSize, start: children[0]!.pos };+};++// `liftTarget` is null for EVERY range at depth 0, so `commands.lift` can never undo a wrapper spanning the+// whole document. A range over the wrapper's own content resolves at depth 1, which does have a target.+const liftRangeOf = (doc: ProseMirrorNode, pos: number, node: ProseMirrorNode) =>+ doc.resolve(pos + 1).blockRange(doc.resolve(pos + node.nodeSize - 1));++const wrapFamily: BlockFamily = {+ isApplied: (type, { doc }) => {+ const children = contentChildren(doc);++ return children.length > 0 && children.every(({ node }) => node.type === type);+ },+ toggle: (type, { dispatch, state, tr }) => {+ const children = contentChildren(state.doc);++ if (!children.length) {+ return false;+ }++ if (wrapFamily.isApplied(type, state)) {+ const targets = children.map(({ node, pos }) => {+ const range = liftRangeOf(state.doc, pos, node);++ return range ? liftTarget(range) : null;+ });++ if (targets.some((target) => target === null)) {+ return false;+ }++ if (dispatch) {+ for (const { node, pos } of [...children].reverse()) {+ const range = liftRangeOf(tr.doc, tr.mapping.map(pos), node);+ const target = range ? liftTarget(range) : null;++ if (range && target !== null) {+ tr.lift(range, target);+ }+ }+ }++ return true;+ }++ const { end, start } = contentSpan(children);+ const range = new NodeRange(state.doc.resolve(start), state.doc.resolve(end), 0);+ const wrapping = findWrapping(range, type);++ if (!wrapping) {+ return false;+ }++ if (dispatch) {+ tr.wrap(range, wrapping);+ }++ return true;+ },+};++const canRetype = (doc: ProseMirrorNode, pos: number, type: NodeType) => {+ const $pos = doc.resolve(pos);++ return $pos.parent.canReplaceWith($pos.index(), $pos.index() + 1, type);+};++const blockTypeCandidates = (state: EditorState, type: NodeType): TopLevelChild[] => {+ const children = contentChildren(state.doc);++ if (!children.length) {+ return [];+ }++ const { end, start } = contentSpan(children);+ const candidates: TopLevelChild[] = [];++ state.doc.nodesBetween(start, end, (node, pos) => {+ // A cell serialises inline, so a fence placed inside one comes back from the next load as literal+ // backticks. Descending into a table trades a reversible refusal for silent corruption.+ if (node.type.spec.tableRole === 'table') {+ return false;+ }++ if (node.isTextblock && (node.type === type || canRetype(state.doc, pos, type))) {+ candidates.push({ node, pos });+ }++ return true;+ });++ return candidates;+};++// A heading carries its level in attrs, so "already applied" and the value written both have to account for+// them: comparing node type alone reads an all-H1 document as already being Heading 2 and demotes it, and+// dropping the attrs on the way in stamps the schema default level for every choice the user makes.+const hasAttrs = (node: ProseMirrorNode, attrs: BlockAttrs) =>+ !attrs || Object.entries(attrs).every(([key, value]) => node.attrs[key] === value);++const blockTypeFamily: BlockFamily = {+ isApplied: (type, state, attrs) => {+ const candidates = blockTypeCandidates(state, type);++ return candidates.length > 0 && candidates.every(({ node }) => node.type === type && hasAttrs(node, attrs));+ },+ toggle: (type, { dispatch, state, tr }, _delegate, attrs) => {+ const candidates = blockTypeCandidates(state, type);++ if (!candidates.length) {+ return false;+ }++ const isApplied = blockTypeFamily.isApplied(type, state, attrs);+ const target = isApplied ? state.schema.nodes.paragraph! : type;+ const targetAttrs = isApplied ? null : ((attrs ?? null) as null | Record<string, unknown>);++ if (+ !candidates.some(+ ({ node, pos }) =>+ (node.type !== target || !hasAttrs(node, attrs)) && canRetype(state.doc, pos, target),+ )+ ) {+ return false;+ }++ if (dispatch) {+ for (const { node, pos } of [...candidates].reverse()) {+ tr.setBlockType(pos, pos + node.nodeSize, target, targetAttrs);+ }+ }++ return true;+ },+};++const listFamily: BlockFamily = {+ isApplied: (type, state) => {+ const children = contentChildren(state.doc);++ return children.length > 0 && children.every(({ node }) => node.type === type);+ },+ toggle: (type, { chain, editor, state }, delegate) => {+ const { extensions } = editor.extensionManager;+ const children = contentChildren(state.doc);+ // Derived from `children` rather than recomputed, so the index lookups below compare the same objects.+ const candidates = children.filter(({ node }) => node.isTextblock || isList(node.type.name, extensions));+ const first = candidates[0];+ const last = candidates.at(-1);++ if (!first || !last) {+ return false;+ }++ const isApplied = children.every(({ node }) => node.type === type);+ const hasGap = children.indexOf(last) - children.indexOf(first) + 1 !== candidates.length;++ if (!isApplied && hasGap) {+ return false;+ }++ const { end, start } = contentSpan(candidates);+ const seated = isApplied+ ? TextSelection.between(state.doc.resolve(start + 1), state.doc.resolve(end - 1))+ : TextSelection.between(state.doc.resolve(start), state.doc.resolve(end));+ const restored = state.selection;+ let hasToggled = false;++ return (+ // Nothing here may branch on `dispatch`. Under `can()` the transaction is discarded anyway, so+ // seating costs nothing — but skipping it there hands the delegate the whole-document selection it+ // cannot use, and the control reports unavailable for a click that would have worked.+ chain()+ .command(({ tr }) => {+ tr.setSelection(seated);++ return true;+ })+ .command((chained) => {+ hasToggled = delegate(chained);++ return hasToggled;+ })+ // A chain dispatches what its callbacks already wrote even when one returns false, so a delegate+ // that half-applied its `clearNodes` fallback would commit a flattened document without this.+ .command(({ tr }) => {+ if (hasToggled) {+ tr.setSelection(restored.map(tr.doc, tr.mapping));+ } else {+ tr.setMeta('preventDispatch', true);+ }++ return true;+ })+ .run()+ );+ },+};++const BLOCK_FAMILIES: Record<string, BlockFamily | undefined> = {+ blockquote: wrapFamily,+ bulletList: listFamily,+ codeBlock: blockTypeFamily,+ orderedList: listFamily,+ taskList: listFamily,+};++/**+ * The toolbar MUST read its pressed state from here rather than from `editor.isActive`: tiptap's predicate+ * demands the type cover the whole selection, so an already-quoted document under Ctrl+A reads as not quoted+ * and the button would contradict what its own click does.+ */+export const isBlockApplied = (editor: Editor, nodeName: string): boolean => {+ const { state } = editor;+ const family = BLOCK_FAMILIES[nodeName];+ const type = state.schema.nodes[nodeName];++ if (!family || !type || !isWholeDocumentSelection(state)) {+ return editor.isActive(nodeName);+ }++ return family.isApplied(type, state);+};++const withWholeDocumentToggle = <T extends AnyExtension>(extension: T, commandName: string, family: BlockFamily): T =>+ extension.extend({+ addCommands() {+ const parent = (this.parent?.() ?? {}) as CommandMap;+ const original = parent[commandName];+ const { name } = this;++ if (!original) {+ return parent;+ }++ return {+ ...parent,+ [commandName]:+ (...args: never[]) =>+ (props: never) => {+ const commandProps = props as CommandProps;+ const delegate = (chained: CommandProps = commandProps) => original(...args)(chained as never);++ if (!isWholeDocumentSelection(commandProps.state)) {+ return delegate();+ }++ return family.toggle(+ commandProps.state.schema.nodes[name]!,+ commandProps,+ delegate,+ args[0] as BlockAttrs,+ );+ },+ };+ },+ }) as T;++type MarkdownTokenizer = {+ start?: (src: string) => number;+ tokenize: (src: string, tokens: unknown[], lexer: unknown) => unknown;+};++// marked runs every block extension's `tokenize` at EVERY block boundary, handing it the whole remaining+// document, and @tiptap/extension-list's ordered/task tokenizers open with `src.split('\n')` before bailing+// on a first line that isn't a list item — so each boundary materialises all remaining lines, O(n²).+//+// The gate is the tokenizer's OWN `start`, never a copy of its marker syntax: `start` is anchored and cheap,+// and reusing it means the guard cannot drift narrower than the grammar upstream accepts. A non-zero result+// says the block does not begin here, which is exactly when `tokenize` would have returned undefined anyway.+const guardBlockTokenizer = <T extends AnyExtension>(extension: T): T => {+ const original = (extension.config as { markdownTokenizer?: MarkdownTokenizer }).markdownTokenizer;+ const start = original?.start;++ if (!original || !start) {+ return extension;+ }++ return extension.extend({+ markdownTokenizer: {+ ...original,+ tokenize: (src: string, tokens: unknown[], lexer: unknown) =>+ start(src) === 0 ? original.tokenize(src, tokens, lexer) : undefined,+ },+ }) as T;+};++const longestRun = (text: string, runs: RegExp): number =>+ (text.match(runs) ?? []).reduce((max, run) => Math.max(max, run.length), 0);// @tiptap/extension-code-block's renderMarkdown always emits a 3-backtick fence, so a code block whose content// contains a ``` line (a doc demonstrating fenced markdown — common in knowledge/prompt examples) re-parses as// TWO blocks on the next load: the inner fence closes the outer one. CommonMark requires the fence to be longer-// than any backtick run inside — widen it. Otherwise identical to upstream.+// than any backtick run inside — widen it. CommonMark also forbids a backtick in a BACKTICK fence's info+// string while allowing one in a tilde fence's, so a language holding a backtick must ride a `~~~` fence.+// Otherwise identical to upstream.const renderTunedCodeBlock = (node: JSONContent, helpers: MarkdownRendererHelpers): string => {- const language = node.attrs?.language || '';-- if (!node.content) {- return `\`\`\`${language}\n\n\`\`\``;- }-- const content = helpers.renderChildren(node.content);- const fence = '`'.repeat(Math.max(3, longestBacktickRun(content) + 1));+ const language: string = node.attrs?.language || '';+ const [marker, runs] = language.includes('`') ? (['~', /~+/g] as const) : (['`', /`+/g] as const);+ const content = node.content ? helpers.renderChildren(node.content) : '';+ const fence = marker.repeat(Math.max(3, longestRun(content, runs) + 1));return [`${fence}${language}`, content, fence].join('\n');};@@ -71,6 +406,20 @@ const lowlight = createLowlight(common);// stamps the fence language onto the `<pre>` as data-language so a CSS caption// (index.css) can name the block — the label lives in the DOM, not the document.const TunedCodeBlock = CodeBlockLowlight.extend({+ // `defaultLanguage` below feeds the highlight plugin, which reads `attrs.language || defaultLanguage`.+ // As an ATTRIBUTE default it would also stamp `plaintext` onto every block created in the editor, and+ // renderMarkdown would write that into the fence — a language the author never typed.+ addAttributes() {+ const attributes = this.parent?.() as undefined | { language?: Record<string, unknown> };++ return { ...attributes, language: { ...attributes?.language, default: null } };+ },+ // CodeBlockLowlight builds its plugins as `[...this.parent?.(), LowlightPlugin(...)]` and `.extend()` copies+ // that into every layer, so each layer highlights the whole document again. Measured: this pass-through+ // collapses them to one only from INSIDE this literal — as an outer `.extend()` layer it leaves three.+ addProseMirrorPlugins() {+ return this.parent?.() ?? [];+ },parseMarkdown: parseTunedCodeBlock,renderHTML({ HTMLAttributes, node }) {const language = (node.attrs.language as null | string) || null;@@ -82,7 +431,9 @@ const TunedCodeBlock = CodeBlockLowlight.extend({];},renderMarkdown: renderTunedCodeBlock,-}).configure({ HTMLAttributes: { class: 'hljs' }, lowlight });+ // Without defaultLanguage an info-string-less fence falls to highlightAuto, which re-scans all 37 `common`+ // grammars over every code block in the document on each keystroke inside one.+}).configure({ defaultLanguage: 'plaintext', HTMLAttributes: { class: 'hljs' }, lowlight });// A paragraph line that literally starts with `# ` or `> ` re-parses as a heading / blockquote on the next load// (an ATX heading interrupts a paragraph; `>` opens a quote), silently changing the block TYPE of body text —@@ -91,10 +442,27 @@ const TunedCodeBlock = CodeBlockLowlight.extend({// `1.`/fences overlap with literal regex/glob/backref escapes (`\*`, `\1`, `\|`) the editor must preserve.const escapeLineLeadingBlockMarkers = (markdown: string): string =>markdown.replace(- /(^|\n)( {0,3})(#{1,6} |> )/g,+ /(^|\n)( {0,3})(#{1,6}(?=[ \t\n]|$)|>)/g,(_match, lineStart: string, indent: string, marker: string) => `${lineStart}${indent}\\${marker}`,);+// marked reads a line of only `=` or `-` sitting directly under text as a setext underline (`(=+|-+) *` — no+// three-character minimum), so a hard break followed by such a line turns the whole paragraph into a heading+// and eats the run. Only continuation lines need it: a paragraph's first line is preceded by a blank line,+// which stops lheading. The load side unescapes exactly this shape, so an author's `\-` inside a character+// class is left alone.+const escapeSetextUnderlines = (markdown: string): string =>+ markdown.replace(+ /(\n {0,3})((?:=+|-+) *)(?=\n|$)/g,+ (_match, lineStart: string, run: string) => `${lineStart}\\${run}`,+ );++// A `]` inside an image alt closes the markdown label early and the image loses its node entirely on reload.+// marked unescapes `\[`/`\]` inside a label through its own outputLink pass, independent of the neutralised+// inline escape tokenizer, so escaping just those two closes the round trip. A lone `\` is NOT escaped —+// marked would not unescape it back.+const escapeBracketsInLabel = (text: string): string => text.replace(/[[\]]/g, (bracket) => `\\${bracket}`);+// StarterKit's Bold/Italic register BOTH `**`/`*` and `__`/`_` input+paste rules. The marked layer keeps// `_`-emphasis literal on load/paste, so leaving the underscore TYPING rules on would diverge — typed// `__init__`/`_word_` would emphasize (→ `**init**`/`*word*`) while the same text loaded stays literal,@@ -114,10 +482,39 @@ const TunedStarterKit = StarterKit.extend({});}+ if (extension.name === 'orderedList') {+ return withWholeDocumentToggle(guardBlockTokenizer(extension), 'toggleOrderedList', listFamily);+ }++ if (extension.name === 'bulletList') {+ return withWholeDocumentToggle(extension, 'toggleBulletList', listFamily);+ }++ if (extension.name === 'blockquote') {+ return withWholeDocumentToggle(extension, 'toggleBlockquote', wrapFamily);+ }++ if (extension.name === 'heading') {+ return withWholeDocumentToggle(extension, 'toggleHeading', blockTypeFamily);+ }+if (extension.name === 'paragraph') {return extension.extend({renderMarkdown(node: JSONContent, helpers: MarkdownRendererHelpers) {- return escapeLineLeadingBlockMarkers(helpers.renderChildren(node.content ?? []));+ return escapeSetextUnderlines(+ escapeLineLeadingBlockMarkers(helpers.renderChildren(node.content ?? [])),+ );+ },+ });+ }++ // Emit the code mark's content with NO backtick fence: the real content-sized fence comes from+ // serializeCodeSpan in the text encoder (markdown-editor-marked.ts). The two are paired — restoring a+ // fence here double-wraps every code span.+ if (extension.name === 'code') {+ return extension.extend({+ renderMarkdown(node: JSONContent, helpers: MarkdownRendererHelpers) {+ return node.content ? helpers.renderChildren(node.content) : '';},});}@@ -143,15 +540,27 @@ export const createMarkdownExtensions = (placeholder?: string) => [link: { autolink: true, linkOnPaste: true, openOnClick: false },underline: false,}),- TunedCodeBlock,+ withWholeDocumentToggle(TunedCodeBlock, 'toggleCodeBlock', blockTypeFamily),HeadingAutoformat,TunedTable.configure({ resizable: true }),TableRow,TableHeader,TableCell,- TaskList,- TaskItem.configure({ nested: true }),- Image,+ withWholeDocumentToggle(guardBlockTokenizer(TaskList), 'toggleTaskList', listFamily),+ TaskItem.configure({+ a11y: {+ checkboxLabel: (node) => `Task item checkbox for ${node.firstChild?.textContent || 'empty task item'}`,+ },+ nested: true,+ }),+ Image.extend({+ renderMarkdown(node: JSONContent) {+ const { alt = '', src = '', title = '' } = node.attrs ?? {};+ const label = escapeBracketsInLabel(String(alt));++ return title ? `` : ``;+ },+ }),VariableHighlight,TagHighlight,Placeholder.configure({ emptyEditorClass: 'is-editor-empty', placeholder }),diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-focus.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-focus.tsnew file mode 100644index 00000000..406b228b--- /dev/null+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-focus.ts@@ -0,0 +1,17 @@+import type { Editor } from '@tiptap/react';++/**+ * `onCloseAutoFocus` handler shared by every editor popover and dropdown: keep focus on the caret instead of+ * the trigger so the user can keep typing.+ *+ * The destroyed check is load-bearing, not defensive. Radix closes a still-open layer asynchronously, so+ * unmounting the editor with a menu open lands this callback on a torn-down instance and `editor.commands`+ * throws — reproduced by the toolbar tests, which took `vitest run` to exit 1 while every test read green.+ */+export const returnFocusToEditor = (editor: Editor) => (event: Event) => {+ event.preventDefault();++ if (!editor.isDestroyed) {+ editor.commands.focus();+ }+};diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.test.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.test.tsindex 25964082..425c4520 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.test.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.test.ts@@ -592,6 +592,18 @@ describe('re-entrancy & inert nodes', () => {expect(firstBlock(json).type).toBe('codeBlock');});+ it('a leading code span whose content starts with "# " keeps its hash and stays a paragraph', () => {+ const editor = new Editor({ content: '', contentType: 'markdown', extensions: createMarkdownExtensions() });++ // The plugin runs from appendTransaction, so a bare `new Editor({ content })` never reaches it —+ // the load has to arrive as a transaction, the way every real load does.+ editor.commands.setContent('`# Title` trailing', { contentType: 'markdown' });++ expect(liveHeadings(editor)).toBe(0);+ expect(editor.state.doc.textContent).toBe('# Title trailing');+ expect(editor.getMarkdown().trimEnd()).toBe('`# Title` trailing');+ });+it('an empty paragraph is skipped without throwing during the scan', () => {expect(() =>run(doc(para(), para(t('body'))), (editor) => {diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.tsindex 489cbd7e..f203e7b2 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-heading-autoformat.ts@@ -55,7 +55,8 @@ export const HeadingAutoformat = Extension.create({}const first = node.firstChild;- const match = first?.isText && first.text ? HEADING_MARKER.exec(first.text) : null;+ const isMarkup = first?.isText && !first.marks.some((mark) => mark.type.name === 'code');+ const match = isMarkup && first.text ? HEADING_MARKER.exec(first.text) : null;if (match && !containsHardBreak(node, hardBreak)) {const start = pos + 1;diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-image-handle.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-image-handle.tsxindex 22a08c7c..e998bf07 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-image-handle.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-image-handle.tsx@@ -6,6 +6,7 @@ import { useEffect, useState } from 'react';import { Popover, PopoverAnchor, PopoverContent } from '@/components/ui/popover';+import { returnFocusToEditor } from './markdown-editor-focus';import { ImageEditForm } from './markdown-editor-image-edit-form';import { getEditorScrollParent } from './markdown-editor-styles';@@ -45,10 +46,7 @@ export function ImageHandle({ editor }: { editor: Editor }) {align="start"className="w-80"data-image-handle=""- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}onOpenAutoFocus={(event) => {// The popover appears when an image is selected — keep focus in the doc so it doesn't steal it;// the user clicks into the URL field only to actually edit.diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-image-src.test.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-image-src.test.tsindex 624082b1..4d7dac5e 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-image-src.test.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-image-src.test.ts@@ -65,3 +65,46 @@ describe('normalizeLinkUrl — prepend https to scheme-less input, validate protexpect(normalizeLinkUrl(input)).toBeNull();});});++describe('whitespace and unknown schemes are rejected, not laundered into the document', () => {+ // `new URL()` accepts a space, so the raw candidate persisted as `[hello](https://example.com/my page)` —+ // which reloads with the link destroyed and the brackets leaking into the text.+ it.each(['example.com/my page', 'https://example.com/a b', ' https://example.com/a\tb '])(+ 'rejects a URL containing whitespace: %s',+ (value) => {+ expect(normalizeLinkUrl(value)).toBeNull();+ expect(normalizeImageSrc(value)).toBeNull();+ },+ );++ // `https://` was prefixed onto anything unrecognised, so `ftp://host/file` became `https://ftp://host/file`+ // — parsed as host `ftp`, shown as valid, and persisted as a dead link with no error.+ it.each(['ftp://example.com/a', 'chrome://settings', 'ssh://host/x', 'file:///etc/passwd'])(+ 'rejects the unknown scheme %s instead of prefixing https:// onto it',+ (value) => {+ expect(normalizeLinkUrl(value)).toBeNull();+ },+ );++ // Values the guard must NOT catch: a scheme-less host:port reads like a scheme but is ordinary input.+ it.each(['example.com:8080/path', 'localhost:3000', 'localhost:3000/a', 'a.b.c:9200/_search'])(+ 'still accepts the scheme-less host:port %s',+ (value) => {+ expect(normalizeLinkUrl(value)).toBe(`https://${value}`);+ },+ );++ it('still accepts a protocol-relative URL', () => {+ expect(normalizeImageSrc('//cdn.example.com/a.png')).toBe('https://cdn.example.com/a.png');+ });++ // Byte-fidelity: routing the value through `new URL().href` would rewrite all three, which is why the fix+ // rejects whitespace rather than re-encoding.+ it.each([+ ['example.com', 'https://example.com'],+ ['https://example.com/{{HOST}}/x', 'https://example.com/{{HOST}}/x'],+ ['https://example.com/путь', 'https://example.com/путь'],+ ])('keeps %s byte-identical', (input, expected) => {+ expect(normalizeLinkUrl(input)).toBe(expected);+ });+});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-link-edit-form.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-link-edit-form.tsxindex 835eaefc..44d7f2e9 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-link-edit-form.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-link-edit-form.tsx@@ -39,10 +39,20 @@ export function LinkEditForm({ autoFocus = true, editor, initialUrl, isActive, oif (empty && !isActive) {// No selection to wrap → insert the URL as its own linked text: the visible text is what the user// typed, but the href is the normalized value.+ //+ // A `]` in that text would close the markdown label early — `[https://x/a]b](…)` — and the whole+ // construct leaks into literal text, growing on every load+save cycle. The label is serialized by+ // the text path, which has no mark context, so the escape cannot live in the link's renderMarkdown+ // (@tiptap/markdown hands that renderer a placeholder, not the text). Keep the brackets out of the+ // label here instead; the href itself still carries them verbatim.editor.chain().focus()- .insertContent({ marks: [{ attrs: { href }, type: 'link' }], text: url.trim(), type: 'text' })+ .insertContent({+ marks: [{ attrs: { href }, type: 'link' }],+ text: url.trim().replace(/[[\]]/g, ''),+ type: 'text',+ }).run();} else {editor.chain().focus().extendMarkRange('link').setLink({ href }).run();diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-link-handle.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-link-handle.tsxindex 71dd36e1..6f38521e 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-link-handle.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-link-handle.tsx@@ -1,10 +1,11 @@import type { Editor } from '@tiptap/react';import { getMarkRange, posToDOMRect } from '@tiptap/core';-import { useEffect, useState } from 'react';+import { useEffect, useRef, useState } from 'react';import { Popover, PopoverAnchor, PopoverContent } from '@/components/ui/popover';+import { returnFocusToEditor } from './markdown-editor-focus';import { LinkEditForm } from './markdown-editor-link-edit-form';import { getEditorScrollParent } from './markdown-editor-styles';@@ -47,10 +48,7 @@ export function LinkHandle({ editor }: { editor: Editor }) {align="start"className="w-80 p-2"data-link-handle=""- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}onOpenAutoFocus={(event) => {// The popover appears whenever the caret enters a link, so keep focus in the doc — stealing it// would interrupt typing/navigation. The user clicks into the URL field only to actually edit.@@ -74,6 +72,10 @@ export function LinkHandle({ editor }: { editor: Editor }) {function useLinkHandle(editor: Editor) {const [target, setTarget] = useState<LinkTarget | null>(null);+ // Escape only cleared `target`, and the next selectionUpdate re-targeted unconditionally while the caret+ // was still in the link — so a dismiss lasted exactly one keystroke. Remember which link was dismissed and+ // stay closed for it until the caret leaves, an edit shifts its start, or the toolbar opens it on purpose.+ const dismissedKeyRef = useRef<null | string>(null);useEffect(() => {const linkType = editor.schema.marks.link;@@ -82,6 +84,7 @@ function useLinkHandle(editor: Editor) {const { selection } = editor.state;if (!linkType || !selection.empty || !editor.isActive('link')) {+ dismissedKeyRef.current = null;setTarget(null);return;@@ -90,11 +93,16 @@ function useLinkHandle(editor: Editor) {const range = getMarkRange(selection.$from, linkType);if (!range) {+ dismissedKeyRef.current = null;setTarget(null);return;}+ if (dismissedKeyRef.current === `${range.from}`) {+ return;+ }+const rect = posToDOMRect(editor.view, range.from, range.to);const href = (editor.getAttributes('link').href as string | undefined) ?? '';@@ -106,7 +114,13 @@ function useLinkHandle(editor: Editor) {const clear = () => setTarget(null);+ // An edit before the link moves its start, so the remembered key no longer identifies it.+ const forget = () => {+ dismissedKeyRef.current = null;+ };+editor.on('selectionUpdate', update);+ editor.on('update', forget);// Fixed-positioned anchor goes stale on scroll/resize — drop it (it reappears on the next caret entry).const scrollParent = getEditorScrollParent(editor.view.dom);@@ -116,10 +130,17 @@ function useLinkHandle(editor: Editor) {return () => {editor.off('selectionUpdate', update);+ editor.off('update', forget);scrollParent.removeEventListener('scroll', clear);window.removeEventListener('resize', clear);};}, [editor]);- return { close: () => setTarget(null), target };+ return {+ close: () => {+ dismissedKeyRef.current = target?.key ?? null;+ setTarget(null);+ },+ target,+ };}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-marked.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-marked.tsindex f64633dc..f8f6a92b 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-marked.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-marked.ts@@ -5,7 +5,7 @@ import { renderTableToMarkdown, Table } from '@tiptap/extension-table';import { Markdown } from '@tiptap/markdown';import { Marked } from 'marked';-import { escapeTablePipes } from './markdown-editor-table-pipes';+import { escapeTablePipes, TEMPLATE_ACTION } from './markdown-editor-table-pipes';// @tiptap/markdown parses with `marked`, which — unlike markdown-it's `html: false` — always tries to// interpret `<...>` as HTML. Our content uses literal XML-ish tags (`<container_environment>`, `<input>`)@@ -23,9 +23,10 @@ const createTunedMarked = () => {// • del — keep GFM `~~strike~~`, drop a lone `~…~` (else `~5~` / ranges become <del>)// • emStrong — keep `*`/`**`, drop `_`-delimited emphasis (else `__init__`/`_word_` become em/strong)// • escape — keep `\`+punct literal (`\.` `\*` `\|` `\\`); marked's default DROPS the backslash- // (CommonMark unescape), silently corrupting regex/paths on the first load. EXCEPT- // `\#`/`\>`: unescape those, symmetric with the paragraph serializer escaping a- // line-leading `# `/`> ` so body text doesn't re-parse as a heading/quote+ // (CommonMark unescape), silently corrupting regex/paths on the first load. The+ // `\#`/`\>` counterpart to the paragraph serializer is NOT here: an inline tokenizer+ // fires at any position, so it also ate the backslash mid-line (`grep '\<root\>'`).+ // It lives in the Lexer's inlineTokens override below, which sees line starts.// • html/tag — keep `<xml-like>` tags literal (marked swallows real-HTML-element names)// NB: autolink/url are intentionally NOT neutralised — a bare `https://…`, `<url>` or email is// meant to become a link (see markdown-editor-extensions.ts link config, kept symmetric with typing).@@ -36,11 +37,7 @@ const createTunedMarked = () => {// `<` — that re-freezes the artifacts.del: (src: string) => (/^~~(?!~)/.test(src) ? false : undefined),emStrong: (src: string) => (/^_/.test(src) ? undefined : false),- escape: (src: string) => {- const marker = /^\\([#>])/.exec(src);-- return marker ? { raw: marker[0], text: marker[1]!, type: 'escape' as const } : undefined;- },+ escape: () => undefined,html: () => undefined,tag: () => undefined,},@@ -51,10 +48,24 @@ const createTunedMarked = () => {// tokenization, dropping trailing cells). @tiptap/markdown's manager builds its block lexer via// `new markedInstance.Lexer(...)` — including for the construction-time initial parse — so subclassing// this PRIVATE instance's Lexer keeps the transform instance-scoped (no shared-class mutation) and still- // catches every load. `inlineTokens` is inherited unchanged, so inline fragments are not touched.+ // catches every load.const BaseLexer = instance.Lexer;instance.Lexer = class extends BaseLexer {+ // Undo the paragraph serializer's line-leading `\#`/`\>` here rather than in an inline tokenizer or in+ // `lex`. An inline tokenizer has no notion of position and ate the backslash mid-line; `lex` runs+ // BEFORE block tokenization, so unescaping there hands marked a live `#`/`>` and the paragraph the+ // escape exists to protect becomes a heading or a quote again.+ override inlineTokens(src: string, tokens = []) {+ const unescaped = src+ .replace(/(^|\n)\\([#>])/g, '$1$2')+ // Only a backslash before a run that FILLS the line, matching what the serializer escapes —+ // an author's `\-` inside `[a-z\-_]` keeps its backslash.+ .replace(/(\n {0,3})\\((?:=+|-+) *)(?=\n|$)/g, '$1$2');++ return super.inlineTokens(unescaped, tokens);+ }+override lex(src: string) {return super.lex(escapeTablePipes(src));}@@ -64,13 +75,30 @@ const createTunedMarked = () => {return instance;};-// The serialize-side counterpart to createTunedMarked. @tiptap/markdown's MarkdownManager-// .encodeTextForMarkdown HTML-entity-encodes text (`<` → `<`) and backslash-escapes ``` ` * _ [ ] ~ \ ```.-// Both are wrong here: the load side keeps `\`+punct literal (escape tokenizer off), so re-escaping on save-// would double every backslash; and named HTML entities are DECODED on load (`<`→`<`), so re-encoding-// would freeze them back into `<`. Serialization is hard-coded in the manager (no per-extension hook), so-// replace that one method with identity — save emits exactly the text the doc holds.-type ManagerWithEncode = { encodeTextForMarkdown: (text: string) => string };+type ManagerWithEncode = { encodeTextForMarkdown: (text: string, node?: SerializedNode, parent?: unknown) => string };+type SerializedNode = { marks?: (string | { type?: string })[]; text?: string };++const hasCodeMark = (node?: SerializedNode): boolean =>+ (node?.marks ?? []).some((mark) => (typeof mark === 'string' ? mark : mark.type) === 'code');++// Serialize a literal string as a CommonMark code span (spec 0.31.2 §6.1). @tiptap/markdown's mark path+// can't do this: it derives the code fence by rendering the mark against a placeholder, so the fence is a+// fixed single backtick blind to the content — a span whose text holds a backtick (`` `x` ``, common in+// pentest write-ups) serialises to invalid `` ``x`` `` and degrades further on every save. Choose a fence+// one longer than the longest backtick run inside, and pad with a space when the content starts or ends+// with a backtick (or is all-but-not-only spaces) so the reader strips exactly that pad back off. Mirrors+// prosemirror-markdown's backticksFor; the code-mark renderMarkdown override in markdown-editor-extensions.ts+// zeroes the placeholder fence so this is the ONLY fence emitted.+export const serializeCodeSpan = (content: string): string => {+ const longestRun = (content.match(/`+/g) ?? []).reduce((max, run) => Math.max(max, run.length), 0);+ const fence = '`'.repeat(longestRun + 1);+ const needsPad =+ content.startsWith('`') ||+ content.endsWith('`') ||+ (content.startsWith(' ') && content.endsWith(' ') && /\S/.test(content));++ return `${fence}${needsPad ? ` ${content} ` : content}${fence}`;+};const TunedMarkdownText = Extension.create({name: 'tunedMarkdownText',@@ -80,7 +108,14 @@ const TunedMarkdownText = Extension.create({// lossy default encoder.const manager = this.editor.markdown as unknown as ManagerWithEncode;- manager.encodeTextForMarkdown = (text) => text;+ // Replace the manager's encoder. Upstream HTML-entity-encodes (`<`→`<`) and backslash-escapes+ // ``` ` * _ [ ] ~ \ ```; both are wrong here — the load side keeps `\`+punct literal and decodes named+ // entities, so re-applying either would double backslashes or re-freeze `<`. Prose is therefore+ // emitted verbatim. The one exception is an inline code span: it needs a real CommonMark fence sized to+ // its content (see serializeCodeSpan). The code MARK is the discriminator, NOT the manager's broader+ // isInsideCode — a code BLOCK's body arrives here with empty marks (parent is codeBlock) and must stay+ // verbatim, its fence coming from TunedCodeBlock.+ manager.encodeTextForMarkdown = (text, node) => (hasCodeMark(node) ? serializeCodeSpan(text) : text);},// Lower priority than the Markdown extension so this runs AFTER its onBeforeCreate has created the// manager and assigned editor.markdown. onBeforeCreate (not onCreate) because it is synchronous —@@ -93,14 +128,50 @@ const TunedMarkdownText = Extension.create({// has NO exact GFM encoding: escaping the pipe alone yields `\\|`, a live delimiter that drops the trailing// cells on the next load. Pad an odd run by one backslash — the cell gains a `\`, the table keeps its cells,// and the padded form is byte-stable from the first save.-export const escapeCellPipes = (text: string): string =>- text.replace(/(\\*)\|/g, (_, run: string) => `${run}${run.length % 2 ? '\\\\|' : '\\|'}`);+// A pipe inside a Go action is the template's pipeline operator. Escaping it makes text/template reject the+// whole prompt (`unexpected "\" in operand`), so the file cannot be saved at all — and every save re-added the+// backslash, leaving no way out from rich mode. The loader counts cells with action pipes masked, so leaving+// them raw no longer skews the header/delimiter comparison.+export const escapeCellPipes = (text: string): string => {+ const escapeOutsideActions = (segment: string) =>+ segment.replace(/(\\*)\|/g, (_, run: string) => `${run}${run.length % 2 ? '\\\\|' : '\\|'}`);+ let result = '';+ let cursor = 0;++ for (const action of text.matchAll(TEMPLATE_ACTION)) {+ result += escapeOutsideActions(text.slice(cursor, action.index)) + action[0];+ cursor = action.index + action[0].length;+ }++ return result + escapeOutsideActions(text.slice(cursor));+};// @tiptap/extension-table's renderTableToMarkdown is alignment-aware but never escapes pipes, so a literal// `|` a cell emits (even from inside inline code) would re-parse as a column delimiter on the next SAVE and// drop cells (tiptap PR #7884). renderTableToMarkdown emits cell content only via h.renderChildren, so wrapping// that one call to escape pipes fixes the save side, on the official alignment-aware renderer.// The LOAD side of the same class is covered by the tuned Lexer subclass in createTunedMarked above.+// GFM has no headerless table, and renderTableToMarkdown answers that by emitting an EMPTY header row above+// the demoted rows — so every header-off + save + reload cycle grew the table by one blank row and the header+// switch silently flipped back on. Promote the first row instead: the row count and every cell survive, and a+// second save is a no-op because the promoted table already has a header.+const withPromotedHeaderRow = (node: JSONContent): JSONContent => {+ const rows = node.content ?? [];+ const firstRow = rows[0];++ if (!firstRow?.content?.length || firstRow.content.some((cell) => cell.type === 'tableHeader')) {+ return node;+ }++ return {+ ...node,+ content: [+ { ...firstRow, content: firstRow.content.map((cell) => ({ ...cell, type: 'tableHeader' })) },+ ...rows.slice(1),+ ],+ };+};+export const TunedTable = Table.extend({renderMarkdown(node: JSONContent, helpers: MarkdownRendererHelpers) {const pipeEscaping: MarkdownRendererHelpers = {@@ -111,7 +182,14 @@ export const TunedTable = Table.extend({// renderTableToMarkdown joins a multi-block cell's children (e.g. two paragraphs from Enter-in-cell) with// a U+001F separator, outside renderChildren. A GFM cell is single-line, so collapse it to a space rather// than persist a raw control byte that survives into the saved .tmpl/knowledge and round-trips unchanged.- return renderTableToMarkdown(node, pipeEscaping).replaceAll(String.fromCharCode(0x1f), ' ');+ // Trim the renderer's own surrounding blank lines. It emits a leading and trailing newline on top of the+ // block separator the manager already adds, and between two ADJACENT tables that extra line reloads as an+ // empty paragraph — which serialises to another blank line on the next save. Measured before the trim:+ // two tables separated by one blank line gained one empty paragraph per cycle and never converged.+ return renderTableToMarkdown(withPromotedHeaderRow(node), pipeEscaping)+ .replaceAll(String.fromCharCode(0x1f), ' ')+ .replace(/^\n+/, '')+ .replace(/\n+$/, '');},});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-table-handles.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-table-handles.tsxindex 01e864b5..9081c614 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-table-handles.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-table-handles.tsx@@ -28,6 +28,7 @@ import {} from '@/components/ui/dropdown-menu';import { Switch } from '@/components/ui/switch';+import { returnFocusToEditor } from './markdown-editor-focus';import { getEditorScrollParent } from './markdown-editor-styles';import { ALIGN_OPTIONS, clearLineContents, hasHeaderRow, setColumnAlign } from './markdown-editor-table-commands';@@ -93,10 +94,7 @@ export function TableHandles({ editor }: { editor: Editor }) {<DropdownMenuContentalign="start"className="min-w-[176px]"- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}><DropdownMenuItem onSelect={() => focusTarget().addColumnBefore().run()}><ArrowLeft className="text-muted-foreground size-4 shrink-0" />@@ -168,10 +166,7 @@ export function TableHandles({ editor }: { editor: Editor }) {<DropdownMenuContentalign="start"className="min-w-[176px]"- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}><RowHeaderToggleItemcellPos={target.cellPos}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.test.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.test.tsindex 0e8419f4..a605a23d 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.test.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.test.ts@@ -1,5 +1,7 @@+import { Editor } from '@tiptap/core';import { describe, expect, it } from 'vitest';+import { createMarkdownExtensions } from './markdown-editor-extensions';import { escapeTablePipes } from './markdown-editor-table-pipes';import { roundTrip, setupEditorJsdom } from './markdown-editor-test-setup';@@ -70,11 +72,23 @@ describe('table cell with a piped code span — content survives load and converexpect(roundTrip(out)).toBe(out);});+ // This used to pin `{{.X \| upper}}` — the escaped form, which Go text/template rejects outright+ // (`unexpected "\" in operand`), so the prompt could not be saved at all. The pipe is the template's+ // pipeline operator and stays raw; the cell count survives because the loader masks action pipes.it('keeps a Go-template action with a pipe inside a cell', () => {const out = roundTrip('| Var | Out |\n| --- | --- |\n| {{.X | upper}} | done |');expect(out).toContain('done');- expect(out).toContain('{{.X \\| upper}}');+ expect(out).toContain('{{.X | upper}}');+ expect(out).not.toContain('\\|');+ expect(roundTrip(out)).toBe(out);+ });++ it('keeps a code span with a backtick and a pipe inside a cell', () => {+ const out = roundTrip('| Op | Meaning |\n| --- | --- |\n| `` `x` | y `` | kept |');++ expect(out).toContain('kept');+ expect(out).toContain('`` `x` \\| y ``');expect(roundTrip(out)).toBe(out);});});@@ -98,7 +112,7 @@ describe('pipe-less GFM tables (no outer pipe) — cells survive too', () => {const out = roundTrip('Var | Out\n--- | ---\n{{.Host | lower}} | done');expect(out).toContain('done');- expect(out).toContain('{{.Host \\| lower}}');+ expect(out).toContain('{{.Host | lower}}');});it('protects rows whether or not each has a leading pipe (mixed)', () => {@@ -237,3 +251,275 @@ describe('TABLE_DELIMITER_LINE is linear (ReDoS guard)', () => {expect(performance.now() - started).toBeLessThan(100);});});++describe('a backtick in a backtick fence info string is not a fence opener', () => {+ const cellsOf = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const cells: string[] = [];++ editor.state.doc.descendants((node) => {+ if (node.type.name === 'tableCell' || node.type.name === 'tableHeader') {+ cells.push(node.textContent);+ }++ return true;+ });+ editor.destroy();++ return cells;+ };++ const TABLE = ['| Op | Meaning |', '| --- | --- |', '| `x | y` | KEEP |'].join('\n');++ // marked's fence rule is /^ {0,3}(`{3,}(?=[^`\n]*(?:\n|$))|~{3,})…/ — the no-backtick lookahead applies to+ // the BACKTICK branch only. A prose line holding an inline triple-backtick span is not a fence for marked,+ // so treating it as one desynchronises the scanner from the parser.+ it('keeps pipe protection for a table that follows an inline triple-backtick span', () => {+ expect(cellsOf(['```pnpm run dev``` starts it', '', TABLE].join('\n'))).toEqual([+ 'Op',+ 'Meaning',+ 'x | y',+ 'KEEP',+ ]);+ });++ it('protects a table that follows no fence at all, unchanged', () => {+ expect(cellsOf(TABLE)).toEqual(['Op', 'Meaning', 'x | y', 'KEEP']);+ });++ // The opposite direction of the same desynchronisation: once the phantom fence closes, the scanner's parity+ // is inverted and it escapes pipes INSIDE a real code block, injecting a backslash into code content.+ it('leaves a real code block byte-identical, injecting no escape into its content', () => {+ const source = ['```a`b', '```', '', TABLE].join('\n');+ const editor = new Editor({ content: source, contentType: 'markdown', extensions: createMarkdownExtensions() });+ const codeBlocks: string[] = [];++ editor.state.doc.descendants((node) => {+ if (node.type.name === 'codeBlock') {+ codeBlocks.push(node.textContent);+ }++ return true;+ });+ editor.destroy();++ expect(codeBlocks.join('')).not.toContain('\\|');+ });++ it('still treats a genuine fence as a fence', () => {+ expect(escapeTablePipes(['```js', '| a | b |', '```'].join('\n'))).toBe(+ ['```js', '| a | b |', '```'].join('\n'),+ );+ });+});++describe('tables nested inside list items keep their pipe protection', () => {+ const cellsOf = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const cells: string[] = [];++ editor.state.doc.descendants((node) => {+ if (node.type.name === 'tableCell' || node.type.name === 'tableHeader') {+ cells.push(node.textContent);+ }++ return true;+ });+ editor.destroy();++ return cells;+ };++ const table = (indent: string) =>+ [`${indent}| Op | Meaning |`, `${indent}| --- | --- |`, `${indent}| \`x | y\` | KEEP |`].join('\n');++ const EXPECTED = ['Op', 'Meaning', 'x | y', 'KEEP'];++ it('protects a table under a bullet at its natural content column', () => {+ expect(cellsOf(['- item', '', table(' ')].join('\n'))).toEqual(EXPECTED);+ });++ // The ordinary way anyone writes a table under a sub-bullet: the content column is 4, which the top-level+ // scanner reads as indented code and skips.+ it('protects a table under a nested bullet', () => {+ expect(cellsOf(['- outer', ' - inner', '', table(' ')].join('\n'))).toEqual(EXPECTED);+ });++ it('protects a table under an ordered item', () => {+ expect(cellsOf(['1. item', '', table(' ')].join('\n'))).toEqual(EXPECTED);+ });++ it('protects a table under a bullet inside a blockquote', () => {+ expect(cellsOf(['> - item', '>', `> ${table(' ').split('\n').join('\n> ')}`].join('\n'))).toEqual(EXPECTED);+ });++ // Relative to the item's content column, four more spaces is still indented code — marked does not make a+ // table there, so escaping it would write a backslash into code content.+ it('leaves a table indented four columns past the item content alone', () => {+ const source = ['- item', '', table(' ')].join('\n');++ expect(escapeTablePipes(source)).toBe(source);+ });++ // The same rule at top level, which is what a blanket relaxation of the leading-space cap would break.+ it('leaves a four-space-indented table at top level alone', () => {+ const source = table(' ');++ expect(escapeTablePipes(source)).toBe(source);+ });++ it('does not swallow the next item at the same level', () => {+ const source = ['- first', '', table(' '), '', '- second | not a table'].join('\n');++ expect(escapeTablePipes(source)).toContain('- second | not a table');+ });+});++describe('a Go template pipeline in a table cell keeps its own pipe', () => {+ const cellsOf = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const cells: string[] = [];++ editor.state.doc.descendants((node) => {+ if (node.type.name === 'tableCell' || node.type.name === 'tableHeader') {+ cells.push(node.textContent);+ }++ return true;+ });+ editor.destroy();++ return cells;+ };++ // `{{.Host | urlquery}}` is a Go text/template pipeline. Escaping its pipe makes text/template reject the+ // whole file with `unexpected "\" in operand`, so the prompt cannot be saved at all.+ it('does not escape a pipeline in a body cell on save', () => {+ expect(roundTrip('| host | value |\n| --- | --- |\n| a | {{.Host | urlquery}} |')).not.toContain('\\|');+ });++ it('keeps every cell of a table whose body holds a pipeline', () => {+ expect(cellsOf('| host | value |\n| --- | --- |\n| a | {{.Host | urlquery}} |')).toEqual([+ 'host',+ 'value',+ 'a',+ '{{.Host | urlquery}}',+ ]);+ });++ // The header row is where dropping the escape without an action-aware cell count destroys the table: the+ // raw pipe makes the header count 3 against the delimiter's 2, detection bails, and marked degrades the+ // whole table to a paragraph.+ it('keeps every cell of a table whose HEADER holds a pipeline', () => {+ expect(cellsOf('| {{.A | urlquery}} | note |\n| --- | --- |\n| x | y |')).toEqual([+ '{{.A | urlquery}}',+ 'note',+ 'x',+ 'y',+ ]);+ });++ it('round-trips a pipeline-bearing table byte-identically on the second save', () => {+ const source = '| host | value |\n| --- | --- |\n| a | {{.Host | urlquery}} |';+ const once = roundTrip(source);++ expect(roundTrip(once)).toBe(once);+ });++ // A structural pipe still has to be escaped when it is real content, not a template operator.+ it('still escapes a pipe inside a code span', () => {+ expect(roundTrip('| a | b |\n| --- | --- |\n| `x | y` | z |')).toContain('\\|');+ });+});++describe('a table with no header row keeps its row count across a save', () => {+ const rowsOf = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ let rows = 0;++ editor.state.doc.descendants((node) => {+ if (node.type.name === 'tableRow') {+ rows += 1;+ }++ return true;+ });++ const saved = editor.getMarkdown();++ editor.destroy();++ return { rows, saved };+ };++ // GFM has no headerless table, so the serializer used to emit an EMPTY header row above the demoted rows:+ // every header-off + save + reload cycle grew the table by one blank row (2 → 3 → 4) and the switch+ // silently flipped back on. Promoting the first row keeps the row count and every cell.+ it('does not grow when the header row is toggled off', () => {+ const editor = new Editor({+ content: ['| a | b |', '| --- | --- |', '| 1 | 2 |'].join('\n'),+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });++ editor.commands.setTextSelection(3);+ editor.commands.toggleHeaderRow();++ const saved = editor.getMarkdown();++ editor.destroy();++ const first = rowsOf(saved);++ expect(first.rows).toBe(2);+ expect(saved).toContain('a');+ expect(saved).toContain('1');+ expect(rowsOf(first.saved).rows).toBe(2);+ });+});++describe('adjacent tables do not accumulate blank paragraphs', () => {+ const kindsOf = (markdown: string) => {+ const editor = new Editor({+ content: markdown,+ contentType: 'markdown',+ extensions: createMarkdownExtensions(),+ });+ const kinds: string[] = [];++ editor.state.doc.forEach((node) => kinds.push(node.type.name));+ editor.destroy();++ return kinds.join(',');+ };++ // The table renderer emits a newline of its own on top of the block separator, so between two adjacent+ // tables that extra line reloaded as an empty paragraph — which serialised to another blank line on the+ // next save. Measured before the fix: 68 → 88 → 90 → 92 → 94 bytes, one paragraph per cycle, no fixed point.+ it('keeps two tables adjacent across repeated saves', () => {+ const source = ['| a | b |', '| --- | --- |', '| 1 | 2 |', '', '| c | d |', '| --- | --- |', '| 3 | 4 |'].join(+ '\n',+ );+ const once = roundTrip(source);++ expect(kindsOf(source)).toBe('table,table');+ expect(kindsOf(once)).toBe('table,table');+ expect(roundTrip(once)).toBe(once);+ });+});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.tsindex 4e44610f..cbecc8b6 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-table-pipes.ts@@ -20,15 +20,28 @@// Capture the full fence run (not a fixed 3) plus the trailing text: renderTunedCodeBlock widens a fence to// 4+ backticks when its content holds a ``` line, and CommonMark closes a fence only with a run of the same// char, length >= the opener, and no info string — so length- and char-aware tracking is load-bearing.-const FENCE_LINE = /^ {0,3}(`{3,}|~{3,})(.*)$/;+// The backtick branch carries marked's own lookahead: a backtick anywhere in the rest of the line means this+// is prose holding an inline code span, not a fence. Without it the scanner opens a fence marked never opened+// and the two run out of step in BOTH directions — tables after it lose pipe protection, and once the phantom+// closes the parity is inverted and pipes get escaped inside real code. Tilde fences carry no such rule.+const FENCE_LINE = /^ {0,3}(`{3,}(?=[^`\n]*$)|~{3,})(.*)$/;// Written to be linear: the trailing `(?: *\|)? *$` (not `\|? *$`) plus per-cell spacing keep any two space// runs from competing for the same characters, so a crafted delimiter-looking line can't force O(n²) backtracking.const TABLE_DELIMITER_LINE = /^ {0,3}\|? *:?-+:?(?: *\| *:?-+:?)*(?: *\|)? *$/;-const TEMPLATE_ACTION = /\{\{[^{}]*\}\}/g;+export const TEMPLATE_ACTION = /\{\{[^{}]*\}\}/g;+// A pipe inside a Go action is the template's pipeline operator, never a column separator — marked's splitter+// does not know that, so the scanner masks those pipes before counting. Without this the serializer cannot+// stop escaping them: an unescaped pipeline in the HEADER row would count one cell too many, detection would+// bail, and marked would degrade the whole table to a paragraph.+const maskActionPipes = (row: string): string => row.replace(TEMPLATE_ACTION, (action) => action.replace(/\|/g, ''));// One blockquote marker (`>` + an optional space). The line scanner only recognizes top-level tables, but marked// strips this prefix and re-lexes the inner content, so a table inside a blockquote needs the prefix removed// before detection — see the recursive handling in escapeTablePipes.const BLOCKQUOTE_PREFIX = /^ {0,3}> ?/;+// A list item whose content actually starts on the same line. CommonMark puts that content at the column after+// the marker plus its following spaces, except that 5+ spaces mean the item opens with indented code and the+// content column is one past the marker.+const LIST_ITEM_START = /^( {0,3})([*+-]|\d{1,9}[.)])( +)(?=\S)/;// A table's body ends at a blank line or the first line that starts a different block — the same interrupts// marked's gfmTable body-row negative lookahead lists (heading, blockquote, fences, list, hr, indented code).@@ -60,7 +73,7 @@ const escapeUnescapedPipes = (text: string): string =>// Mirrors marked's splitCells: split on unescaped pipes, drop a blank leading/trailing cell.const countCells = (row: string): number => {- const cells = row+ const cells = maskActionPipes(row).replace(/\|/g, (pipe, offset: number, source: string) => (isEscapedAt(source, offset) ? pipe : ' |')).split(/ \|/);@@ -213,6 +226,46 @@ export const escapeTablePipes = (markdown: string): string => {continue;}+ // A list item indents its content to its own column, and once that column reaches 4 the top-level scan+ // reads the table as indented code and skips it — while marked dedents the item and re-lexes, where the+ // table is live. Mirror that: dedent by the content column, recurse, re-indent. The indented-code rule+ // then applies RELATIVE to the item, so a line four columns past the content start stays unprotected —+ // which is why this recurses instead of relaxing TABLE_DELIMITER_LINE's leading-space cap.+ const item = LIST_ITEM_START.exec(line);++ if (item) {+ const [, indent = '', marker = '', spaces = ''] = item;+ const contentColumn = indent.length + marker.length + (spaces.length >= 5 ? 1 : spaces.length);+ let end = index + 1;++ while (end < lines.length && (!lines[end]!.trim() || /^ */.exec(lines[end]!)![0].length >= contentColumn)) {+ end++;+ }++ while (end > index + 1 && !lines[end - 1]!.trim()) {+ end--;+ }++ const run = lines.slice(index, end);++ if (end > index + 1 && run.some((row) => row.includes('|'))) {+ const escaped = escapeTablePipes(run.map((row) => row.slice(contentColumn)).join('\n')).split('\n');++ for (let row = index; row < end; row++) {+ const rebuilt = lines[row]!.slice(0, contentColumn) + escaped[row - index]!;++ if (rebuilt !== lines[row]) {+ lines[row] = rebuilt;+ isChanged = true;+ }+ }++ index = end - 1;++ continue;+ }+ }+if (!line.includes('|')) {continue;}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-heading.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-heading.tsxindex bbda19f4..bad343f6 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-heading.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-heading.tsx@@ -13,6 +13,8 @@ import {import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';import { cn } from '@/lib/utils';+import { returnFocusToEditor } from './markdown-editor-focus';+export type HeadingLevel = 1 | 2 | 3 | 4 | 5 | 6;interface HeadingOption {@@ -40,23 +42,15 @@ interface HeadingMenuProps {activeLevel: 0 | HeadingLevel;disabled?: boolean;editor: Editor;+ isInTableCell: boolean;}-export function HeadingMenu({ activeLevel, disabled, editor }: HeadingMenuProps) {- const isSelected = (value: HeadingOption['value']) =>- value === 'paragraph' ? activeLevel === 0 : value === activeLevel;- const active = OPTIONS.find((option) => isSelected(option.value)) ?? OPTIONS[0];- const ActiveIcon = active?.icon ?? Type;+const isSelectedIn = (activeLevel: 0 | HeadingLevel, value: HeadingOption['value']) =>+ value === 'paragraph' ? activeLevel === 0 : value === activeLevel;- const applyOption = (value: HeadingOption['value']) => {- if (value === 'paragraph') {- editor.chain().focus().setParagraph().run();-- return;- }-- editor.chain().focus().toggleHeading({ level: value }).run();- };+export function HeadingMenu({ activeLevel, disabled, editor, isInTableCell }: HeadingMenuProps) {+ const active = OPTIONS.find((option) => isSelectedIn(activeLevel, option.value)) ?? OPTIONS[0];+ const ActiveIcon = active?.icon ?? Type;return (<DropdownMenu>@@ -82,25 +76,48 @@ export function HeadingMenu({ activeLevel, disabled, editor }: HeadingMenuProps)<DropdownMenuContentalign="start"className="min-w-[140px]"- onCloseAutoFocus={(event) => {- // Return focus to the editor caret (not the trigger button) so the user keeps typing.- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}>- {OPTIONS.map((option) => (- <DropdownMenuItem- aria-checked={isSelected(option.value)}- key={option.value}- onSelect={() => applyOption(option.value)}- role="menuitemradio"- >- <option.icon className={cn('text-muted-foreground size-4 shrink-0', option.iconClassName)} />- <span>{option.label}</span>- {isSelected(option.value) ? <Check className="ml-auto size-4 shrink-0" /> : null}- </DropdownMenuItem>- ))}+ <HeadingMenuItems+ activeLevel={activeLevel}+ editor={editor}+ isInTableCell={isInTableCell}+ /></DropdownMenuContent></DropdownMenu>);}++function HeadingMenuItems({+ activeLevel,+ editor,+ isInTableCell,+}: {+ activeLevel: 0 | HeadingLevel;+ editor: Editor;+ isInTableCell: boolean;+}) {+ const applyOption = (value: HeadingOption['value']) => {+ if (value === 'paragraph') {+ editor.chain().focus().setParagraph().run();++ return;+ }++ editor.chain().focus().toggleHeading({ level: value }).run();+ };++ return OPTIONS.map((option) => (+ <DropdownMenuItem+ aria-checked={isSelectedIn(activeLevel, option.value)}+ disabled={isInTableCell && option.value !== 'paragraph'}+ key={option.value}+ onSelect={() => applyOption(option.value)}+ role="menuitemradio"+ >+ <option.icon className={cn('text-muted-foreground size-4 shrink-0', option.iconClassName)} />+ <span>{option.label}</span>+ {isSelectedIn(activeLevel, option.value) ? <Check className="ml-auto size-4 shrink-0" /> : null}+ </DropdownMenuItem>+ ));+}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-image.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-image.tsxindex 1064b392..76a00f46 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-image.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-image.tsx@@ -7,6 +7,7 @@ import { Button } from '@/components/ui/button';import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover';import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';+import { returnFocusToEditor } from './markdown-editor-focus';import { ImageEditForm } from './markdown-editor-image-edit-form';interface ImagePopoverProps {@@ -42,10 +43,7 @@ export function ImagePopover({ disabled, editor }: ImagePopoverProps) {<PopoverContentalign="start"className="w-80"- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}><ImageEditFormeditor={editor}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-link.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-link.tsxindex 0970d585..99fd76c1 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-link.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-link.tsx@@ -7,6 +7,7 @@ import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popoverimport { Toggle } from '@/components/ui/toggle';import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';+import { returnFocusToEditor } from './markdown-editor-focus';import { LinkEditForm } from './markdown-editor-link-edit-form';interface LinkPopoverProps {@@ -42,11 +43,7 @@ export function LinkPopover({ disabled, editor, isActive }: LinkPopoverProps) {<PopoverContentalign="start"className="w-80 p-2"- onCloseAutoFocus={(event) => {- // Return focus to the editor caret (not the trigger) so the user keeps typing after apply/cancel.- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}><LinkEditFormeditor={editor}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-list.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-list.tsxindex dedf28d4..541228b6 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-list.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-list.tsx@@ -13,6 +13,8 @@ import {import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';import { cn } from '@/lib/utils';+import { returnFocusToEditor } from './markdown-editor-focus';+export type ListType = 'bullet' | 'ordered' | 'task';interface ListOption {@@ -31,26 +33,15 @@ interface ListMenuProps {activeType: ListType | null;disabled?: boolean;editor: Editor;+ isInTableCell: boolean;}-export function ListMenu({ activeType, disabled, editor }: ListMenuProps) {+export function ListMenu({ activeType, disabled, editor, isInTableCell }: ListMenuProps) {const active = OPTIONS.find((option) => option.value === activeType);// The bullet-list icon doubles as the resting affordance, so the active background — not the glyph — is what// distinguishes "in a bullet list" from "no list".const TriggerIcon = active?.icon ?? List;- const applyOption = (value: ListType) => {- const chain = editor.chain().focus();-- if (value === 'bullet') {- chain.toggleBulletList().run();- } else if (value === 'ordered') {- chain.toggleOrderedList().run();- } else {- chain.toggleTaskList().run();- }- };-return (<DropdownMenu><Tooltip>@@ -75,24 +66,50 @@ export function ListMenu({ activeType, disabled, editor }: ListMenuProps) {<DropdownMenuContentalign="start"className="min-w-[160px]"- onCloseAutoFocus={(event) => {- event.preventDefault();- editor.commands.focus();- }}+ onCloseAutoFocus={returnFocusToEditor(editor)}>- {OPTIONS.map((option) => (- <DropdownMenuItem- aria-checked={activeType === option.value}- key={option.value}- onSelect={() => applyOption(option.value)}- role="menuitemradio"- >- <option.icon className="text-muted-foreground size-4 shrink-0" />- <span>{option.label}</span>- {activeType === option.value ? <Check className="ml-auto size-4 shrink-0" /> : null}- </DropdownMenuItem>- ))}+ <ListMenuItems+ activeType={activeType}+ editor={editor}+ isInTableCell={isInTableCell}+ /></DropdownMenuContent></DropdownMenu>);}++function ListMenuItems({+ activeType,+ editor,+ isInTableCell,+}: {+ activeType: ListType | null;+ editor: Editor;+ isInTableCell: boolean;+}) {+ const applyOption = (value: ListType) => {+ const chain = editor.chain().focus();++ if (value === 'bullet') {+ chain.toggleBulletList().run();+ } else if (value === 'ordered') {+ chain.toggleOrderedList().run();+ } else {+ chain.toggleTaskList().run();+ }+ };++ return OPTIONS.map((option) => (+ <DropdownMenuItem+ aria-checked={activeType === option.value}+ disabled={isInTableCell}+ key={option.value}+ onSelect={() => applyOption(option.value)}+ role="menuitemradio"+ >+ <option.icon className="text-muted-foreground size-4 shrink-0" />+ <span>{option.label}</span>+ {activeType === option.value ? <Check className="ml-auto size-4 shrink-0" /> : null}+ </DropdownMenuItem>+ ));+}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-url.ts b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-url.tsindex e4df2e58..2e17b5d6 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-url.ts+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar-url.ts@@ -10,11 +10,21 @@ const KNOWN_LINK_SCHEME = /^(?:https?:\/\/|mailto:|tel:)/i;// Make a scheme-less value absolute so the URL constructor reads it as one, without laundering a root-relative// path into a bogus host. `//host/x` (protocol-relative) just needs a scheme; a single leading slash is a// root-relative path this field never supports (`/settings` must NOT become `https://settings`) → reject it.+// A scheme this field does not allow must be REJECTED, not prefixed: `https://` + `ftp://host/file` parses as+// host `ftp`, so the popover showed no error and persisted a dead link. Matched on `scheme://` rather than a+// bare `scheme:` so a scheme-less `localhost:3000` or `example.com:8080/path` still reads as host:port, and so+// the protocol-relative `//cdn…` form below is untouched.+const FOREIGN_SCHEME = /^[a-z][a-z0-9+.-]*:\/\//i;+const toAbsoluteCandidate = (value: string, hasScheme: RegExp): null | string => {if (hasScheme.test(value)) {return value;}+ if (FOREIGN_SCHEME.test(value)) {+ return null;+ }+if (/^\/\/[^/]/.test(value)) {return `https:${value}`;}@@ -33,7 +43,11 @@ const toAbsoluteCandidate = (value: string, hasScheme: RegExp): null | string =>export const normalizeLinkUrl = (raw: string): null | string => {const url = raw.trim();- if (!url) {+ // `new URL()` accepts an inner space, so a raw candidate reached the document as+ // `[hello](https://example.com/my page)` — which reloads with the link gone and the brackets as text.+ // Rejected rather than percent-encoded: routing the value through `.href` would also rewrite a trailing+ // slash, a `{{VAR}}` placeholder and a non-ASCII path, all of which this editor must keep byte-identical.+ if (!url || /\s/.test(url)) {return null;}@@ -59,7 +73,7 @@ const KNOWN_IMAGE_SCHEME = /^(?:https?:\/\/|data:)/i;export const normalizeImageSrc = (raw: string): null | string => {const src = raw.trim();- if (!src) {+ if (!src || /\s/.test(src)) {return null;}diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.test.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.test.tsxnew file mode 100644index 00000000..d973c295--- /dev/null+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.test.tsx@@ -0,0 +1,214 @@+import { render, screen, waitFor } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { Editor } from '@tiptap/core';+import { beforeAll, describe, expect, it } from 'vitest';++import { createMarkdownExtensions } from './markdown-editor-extensions';+import { returnFocusToEditor } from './markdown-editor-focus';+import { setupEditorJsdom } from './markdown-editor-test-setup';+import { MarkdownEditorToolbar } from './markdown-editor-toolbar';++beforeAll(setupEditorJsdom);++const DOC = ['paragraph text', '', '```js', 'const a = 1;', '```'].join('\n');+const CODE_BLOCK_CARET = 20;+const PARAGRAPH_CARET = 3;++const mount = (caret: number) => {+ const element = document.createElement('div');++ document.body.append(element);++ const editor = new Editor({+ content: DOC,+ contentType: 'markdown',+ element,+ extensions: createMarkdownExtensions(),+ });++ editor.commands.setTextSelection(caret);++ const view = render(<MarkdownEditorToolbar editor={editor} />);++ return {+ cleanup: () => {+ view.unmount();+ editor.destroy();+ element.remove();+ },+ editor,+ };+};++describe('toolbar disables controls whose command reports unavailable', () => {+ it.each(['Bold', 'Italic', 'Strikethrough', 'Inline code', 'Link'])(+ '%s is disabled inside a code block and enabled in a paragraph',+ async (label) => {+ const inCode = mount(CODE_BLOCK_CARET);++ await waitFor(() => expect(screen.getByLabelText(label)).toBeDisabled());+ inCode.cleanup();++ const inParagraph = mount(PARAGRAPH_CARET);++ await waitFor(() => expect(screen.getByLabelText(label)).toBeEnabled());+ inParagraph.cleanup();+ },+ );++ it('keeps Blockquote enabled inside a code block, where it does apply', async () => {+ const mounted = mount(CODE_BLOCK_CARET);++ await waitFor(() => expect(screen.getByLabelText('Blockquote')).toBeEnabled());+ mounted.cleanup();+ });++ it('keeps Code block enabled inside a code block, where a second press unwraps it', async () => {+ const mounted = mount(CODE_BLOCK_CARET);++ await waitFor(() => expect(screen.getByLabelText('Code block')).toBeEnabled());+ mounted.cleanup();+ });++ // Turning a code block into a list WORKS, but `can().toggleBulletList()` reports false for it, because the+ // `clearNodes()` fallback inside toggleList does nothing when dispatch is undefined. Disabling on that+ // answer would take a working conversion away from the user, so these items stay enabled.+ it.each(['Bullet list', 'Ordered list', 'Task list'])(+ '%s stays enabled inside a code block, where can() under-reports it',+ async (label) => {+ const mounted = mount(CODE_BLOCK_CARET);+ const user = userEvent.setup();++ expect(mounted.editor.can().toggleBulletList()).toBe(false);++ await user.click(screen.getByLabelText(/^List:/));++ await waitFor(() =>+ expect(screen.getByRole('menuitemradio', { name: new RegExp(label) })).not.toHaveAttribute(+ 'aria-disabled',+ 'true',+ ),+ );+ mounted.cleanup();+ },+ );+});++describe('returnFocusToEditor', () => {+ const editorWithElement = () => {+ const element = document.createElement('div');++ document.body.append(element);++ return {+ cleanup: () => element.remove(),+ editor: new Editor({ content: 'text', element, extensions: createMarkdownExtensions() }),+ };+ };++ // jsdom never reports real DOM focus for the contenteditable, so the observable proof that the call reached+ // the editor is the transaction `focus()` dispatches.+ it('reaches the editor while it is alive', () => {+ const { cleanup, editor } = editorWithElement();+ let transactions = 0;++ editor.on('transaction', () => {+ transactions += 1;+ });++ returnFocusToEditor(editor)(new Event('closeAutoFocus'));++ expect(transactions).toBeGreaterThan(0);+ editor.destroy();+ cleanup();+ });++ // Radix closes a still-open layer asynchronously, so unmounting with a menu open lands this callback on a+ // destroyed editor. Without the guard `editor.commands` throws outside any test's stack: every test still+ // reads green and `vitest run` exits 1.+ it('does nothing once the editor is destroyed, instead of throwing off-stack', () => {+ const { cleanup, editor } = editorWithElement();++ editor.destroy();++ expect(() => returnFocusToEditor(editor)(new Event('closeAutoFocus'))).not.toThrow();+ cleanup();+ });+});++describe('block controls that a table cell cannot hold are disabled inside one', () => {+ const TABLE_DOC = ['| A | B |', '| --- | --- |', '| alpha | beta |'].join('\n');++ const mountWithCaretInCell = () => {+ const element = document.createElement('div');++ document.body.append(element);++ const editor = new Editor({+ content: TABLE_DOC,+ contentType: 'markdown',+ element,+ extensions: createMarkdownExtensions(),+ });+ let caret = 0;++ editor.state.doc.descendants((node, pos) => {+ if (!caret && node.type.name === 'tableCell') {+ caret = pos + 2;+ }++ return true;+ });+ editor.commands.setTextSelection(caret);++ const view = render(<MarkdownEditorToolbar editor={editor} />);++ return {+ cleanup: () => {+ view.unmount();+ editor.destroy();+ element.remove();+ },+ editor,+ };+ };++ // A cell serialises inline, so one click silently degrades the document: a code block in a cell saves as+ // `| ``` alpha ``` |` and reloads as INLINE code, and a horizontal rule applied mid-word splits the word.+ it.each(['Code block', 'Horizontal rule'])('%s is disabled with the caret inside a cell', async (label) => {+ const mounted = mountWithCaretInCell();++ await waitFor(() => expect(screen.getByLabelText(label)).toBeDisabled());+ mounted.cleanup();+ });++ it('disables every list kind inside a cell', async () => {+ const mounted = mountWithCaretInCell();+ const user = userEvent.setup();++ await user.click(screen.getByLabelText(/^List:/));++ for (const label of ['Bullet list', 'Ordered list', 'Task list']) {+ await waitFor(() =>+ expect(screen.getByRole('menuitemradio', { name: new RegExp(label) })).toHaveAttribute(+ 'aria-disabled',+ 'true',+ ),+ );+ }++ mounted.cleanup();+ });++ it('disables every heading level inside a cell', async () => {+ const mounted = mountWithCaretInCell();+ const user = userEvent.setup();++ await user.click(screen.getByLabelText(/^Text style:/));++ await waitFor(() =>+ expect(screen.getByRole('menuitemradio', { name: /Heading 2/ })).toHaveAttribute('aria-disabled', 'true'),+ );+ mounted.cleanup();+ });+});diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.tsxindex c3bb5308..1030948f 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor-toolbar.tsx@@ -18,11 +18,13 @@ import { memo, useEffect, useRef } from 'react';import { Separator } from '@/components/ui/separator';import { TooltipProvider } from '@/components/ui/tooltip';import { cn } from '@/lib/utils';+import { isMac } from '@/lib/utils/platform';import type { HeadingLevel } from './markdown-editor-toolbar-heading';import type { ListType } from './markdown-editor-toolbar-list';import type { ColumnAlign } from './markdown-editor-toolbar-table';+import { isBlockApplied } from './markdown-editor-extensions';import { hasHeaderRow } from './markdown-editor-table-commands';import { ToolbarButton, ToolbarToggle } from './markdown-editor-toolbar-button';import { HeadingMenu } from './markdown-editor-toolbar-heading';@@ -38,6 +40,29 @@ interface MarkdownEditorToolbarProps {const HEADING_LEVELS: HeadingLevel[] = [1, 2, 3, 4, 5, 6];+// prosemirror-keymap resolves `Mod` per platform, so advertising ⌘ on Windows and Linux names a key the+// binding does not use. Same shape as input-search.tsx's `modifier`. Redo is `Shift+Ctrl+Z` rather than+// `Ctrl+Y` because both are registered and the shifted form matches the Mac label the user sees elsewhere.+const shortcutFor = (key: string) => (isMac() ? `⌘${key}` : `Ctrl+${key}`);+const shiftShortcutFor = (key: string) => (isMac() ? `⇧⌘${key}` : `Ctrl+Shift+${key}`);++// Only commands whose dry run is FAITHFUL belong here. tiptap runs `can()` with dispatch undefined, so+// `toggleList`'s `clearNodes()` fallback does nothing and the following `wrapInList` fails — the three list+// kinds, `toggleCodeBlock` and `toggleHeading` all report false for conversions that work. Disabling on that+// answer takes a working action away from the user, which is worse than a no-op click.+const blockAvailability = (editor: Editor) => {+ const can = editor.can();++ return {+ canBlockquote: can.toggleBlockquote(),+ canBold: can.toggleBold(),+ canCode: can.toggleCode(),+ canItalic: can.toggleItalic(),+ canLink: can.setLink({ href: 'https://example.com' }),+ canStrike: can.toggleStrike(),+ };+};+// A mouse wheel emits deltaY, which the browser applies to the nearest VERTICAL scroller — never to this// overflow-x strip, so a wheel-mouse user can't reach overflowed controls (trackpads emit deltaX and already// work). Translate a vertical-dominant wheel into horizontal scroll, releasing at the ends so the page can@@ -163,13 +188,18 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({const state = useEditorState({editor,selector: ({ editor }) => ({- activeListType: (editor.isActive('bulletList')+ activeListType: (isBlockApplied(editor, 'bulletList')? 'bullet'- : editor.isActive('orderedList')+ : isBlockApplied(editor, 'orderedList')? 'ordered'- : editor.isActive('taskList')+ : isBlockApplied(editor, 'taskList')? 'task': null) as ListType | null,+ // A control whose command reports unavailable is disabled, because these commands return false+ // without dispatching and the click would be a silent no-op. Only the always-visible strip is+ // answered here — the menus ask for their own items on open, since `can()` rebuilds the whole+ // command map per call (~40µs measured, flat in document size) and this selector runs per keystroke.+ ...blockAvailability(editor),canRedo: editor.can().redo(),canUndo: editor.can().undo(),columnAlign: (editor.getAttributes('tableHeader').align ??@@ -178,11 +208,16 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({headingLevel: (HEADING_LEVELS.find((level) => editor.isActive('heading', { level })) ?? 0) as| 0| HeadingLevel,- isBlockquote: editor.isActive('blockquote'),+ isBlockquote: isBlockApplied(editor, 'blockquote'),isBold: editor.isActive('bold'),isCode: editor.isActive('code'),- isCodeBlock: editor.isActive('codeBlock'),+ isCodeBlock: isBlockApplied(editor, 'codeBlock'),isHeaderRow: hasHeaderRow(editor),+ // A cell serialises inline, so these controls silently degrade the document from a caret inside+ // one: a code block becomes an inline span on reload, a horizontal rule applied mid-word splits+ // the word permanently, a list marker and a quote marker survive only as literal text. `can()`+ // reports true for all of them, so the guard is structural rather than command-driven.+ isInTableCell: editor.isActive('tableCell') || editor.isActive('tableHeader'),isItalic: editor.isActive('italic'),isLink: editor.isActive('link'),isStrike: editor.isActive('strike'),@@ -220,6 +255,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({activeLevel={state.headingLevel}disabled={disabled}editor={editor}+ isInTableCell={state.isInTableCell}/><Separator@@ -232,25 +268,25 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({role="group"><ToolbarToggle- disabled={disabled}+ disabled={disabled || !state.canBold}label="Bold"onPressedChange={() => editor.chain().focus().toggleBold().run()}pressed={state.isBold}- shortcut="⌘B"+ shortcut={shortcutFor('B')}><Bold /></ToolbarToggle><ToolbarToggle- disabled={disabled}+ disabled={disabled || !state.canItalic}label="Italic"onPressedChange={() => editor.chain().focus().toggleItalic().run()}pressed={state.isItalic}- shortcut="⌘I"+ shortcut={shortcutFor('I')}><Italic /></ToolbarToggle><ToolbarToggle- disabled={disabled}+ disabled={disabled || !state.canStrike}label="Strikethrough"onPressedChange={() => editor.chain().focus().toggleStrike().run()}pressed={state.isStrike}@@ -258,7 +294,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({<Strikethrough /></ToolbarToggle><ToolbarToggle- disabled={disabled}+ disabled={disabled || !state.canCode}label="Inline code"onPressedChange={() => editor.chain().focus().toggleCode().run()}pressed={state.isCode}@@ -266,7 +302,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({<Code /></ToolbarToggle><LinkPopover- disabled={disabled}+ disabled={disabled || !state.canLink}editor={editor}isActive={state.isLink}/>@@ -281,6 +317,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({activeType={state.activeListType}disabled={disabled}editor={editor}+ isInTableCell={state.isInTableCell}/><Separator@@ -306,7 +343,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({role="group"><ToolbarToggle- disabled={disabled}+ disabled={disabled || !state.canBlockquote}label="Blockquote"onPressedChange={() => editor.chain().focus().toggleBlockquote().run()}pressed={state.isBlockquote}@@ -314,7 +351,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({<Quote /></ToolbarToggle><ToolbarToggle- disabled={disabled}+ disabled={disabled || state.isInTableCell}label="Code block"onPressedChange={() => editor.chain().focus().toggleCodeBlock().run()}pressed={state.isCodeBlock}@@ -326,7 +363,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({editor={editor}/><ToolbarButton- disabled={disabled}+ disabled={disabled || state.isInTableCell}label="Horizontal rule"onClick={() => editor.chain().focus().setHorizontalRule().run()}>@@ -361,7 +398,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({disabled={disabled || !state.canUndo}label="Undo"onClick={() => editor.chain().focus().undo().run()}- shortcut="⌘Z"+ shortcut={shortcutFor('Z')}><Undo /></ToolbarButton>@@ -369,7 +406,7 @@ export const MarkdownEditorToolbar = memo(function MarkdownEditorToolbar({disabled={disabled || !state.canRedo}label="Redo"onClick={() => editor.chain().focus().redo().run()}- shortcut="⇧⌘Z"+ shortcut={shiftShortcutFor('Z')}><Redo /></ToolbarButton>diff --git a/frontend/src/components/shared/markdown-editor/markdown-editor.tsx b/frontend/src/components/shared/markdown-editor/markdown-editor.tsxindex 2b407690..2ff3aba6 100644--- a/frontend/src/components/shared/markdown-editor/markdown-editor.tsx+++ b/frontend/src/components/shared/markdown-editor/markdown-editor.tsx@@ -5,8 +5,6 @@ import { history } from '@tiptap/pm/history';import { EditorState, TextSelection } from '@tiptap/pm/state';import { EditorContent, useEditor } from '@tiptap/react';import { useEffect, useImperativeHandle, useMemo, useRef, useState } from 'react';-// Code-block syntax highlighting theme for TunedCodeBlock (lowlight), matching the viewer.-import 'highlight.js/styles/atom-one-dark.css';import { Spinner } from '@/components/ui/spinner';import { cn } from '@/lib/utils';diff --git a/frontend/src/components/shared/markdown.tsx b/frontend/src/components/shared/markdown.tsxindex 42e8ff54..83d5df40 100644--- a/frontend/src/components/shared/markdown.tsx+++ b/frontend/src/components/shared/markdown.tsx@@ -17,7 +17,6 @@ import python from 'highlight.js/lib/languages/python';import sql from 'highlight.js/lib/languages/sql';import xml from 'highlight.js/lib/languages/xml';import yaml from 'highlight.js/lib/languages/yaml';-import 'highlight.js/styles/atom-one-dark.css';import { common, createLowlight } from 'lowlight';import { isValidElement, type ReactElement, type ReactNode, useCallback, useMemo } from 'react';import ReactMarkdown, { type Components } from 'react-markdown';diff --git a/frontend/src/components/ui/button.tsx b/frontend/src/components/ui/button.tsxindex 5aeb0dff..edc0e60a 100644--- a/frontend/src/components/ui/button.tsx+++ b/frontend/src/components/ui/button.tsx@@ -27,7 +27,7 @@ const buttonVariants = cva(destructive:'bg-destructive text-destructive-foreground shadow-xs hover:bg-destructive/90 dark:bg-destructive/80 dark:hover:bg-destructive/70',ghost: 'hover:bg-accent hover:text-accent-foreground',- link: 'text-primary underline-offset-4 hover:underline',+ link: 'text-link underline-offset-4 hover:underline',outline: 'border border-input bg-background shadow-xs hover:bg-accent hover:text-accent-foreground',secondary: 'bg-secondary text-secondary-foreground shadow-xs hover:bg-secondary/80',},@@ -39,6 +39,8 @@ export interface ButtonProps extends React.ComponentProps<'button'>, VariantPropasChild?: boolean;}+export type ButtonVariant = NonNullable<VariantProps<typeof buttonVariants>['variant']>;+function Button({ asChild = false, className, size, type, variant, ...props }: ButtonProps) {const Comp = asChild ? Slot : 'button';diff --git a/frontend/src/components/ui/context-menu.tsx b/frontend/src/components/ui/context-menu.tsxindex 9f8da8a9..d658c325 100644--- a/frontend/src/components/ui/context-menu.tsx+++ b/frontend/src/components/ui/context-menu.tsx@@ -214,6 +214,8 @@ function ContextMenuTrigger({ ...props }: React.ComponentProps<typeof ContextMenreturn (<ContextMenuPrimitive.Triggerdata-slot="context-menu-trigger"+ // Radix renders this as a plain span, which cannot take focus back from a closing dialog.+ tabIndex={-1}{...props}/>);diff --git a/frontend/src/components/ui/data-table.test.tsx b/frontend/src/components/ui/data-table.test.tsxindex 307fdad6..6fec7a57 100644--- a/frontend/src/components/ui/data-table.test.tsx+++ b/frontend/src/components/ui/data-table.test.tsx@@ -9,7 +9,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';import { TooltipProvider } from '@/components/ui/tooltip';-import { cycleColumnSort, DataTable } from './data-table';+import { cycleColumnSort, DataTable, DataTableColumnHeader } from './data-table';interface Row {id: string;@@ -861,6 +861,32 @@ describe('DataTable — multi-column search', () => {expect(screen.getByText('Charlie')).toBeInTheDocument();});+ it('folds diacritics so an unaccented query matches an accented cell', async () => {+ const user = userEvent.setup();+ const accentedRows: MultiRow[] = [+ { id: 'a', name: 'Café Runner', role: 'admin' },+ { id: 'b', name: 'Plain', role: 'user' },+ ];++ render(+ <DataTable<MultiRow>+ columns={MULTI_COLUMNS}+ data={accentedRows}+ filterPlaceholder="Filter..."+ />,+ { wrapper: Wrapper },+ );++ await user.type(screen.getByPlaceholderText('Filter...'), 'cafe');++ // The list filter shares matching semantics with detail-navigation's+ // Prev/Next subset — if this stops matching, the two have diverged.+ await waitFor(() => {+ expect(screen.queryByText('Plain')).not.toBeInTheDocument();+ });+ expect(screen.getByText('Café Runner')).toBeInTheDocument();+ });+it('narrows the search when the picker disables a candidate', async () => {const user = userEvent.setup();render(@@ -1020,6 +1046,58 @@ describe('DataTable — multi-column search', () => {});});+describe('DataTable — sort state is exposed to assistive technology', () => {+ const SORTABLE_COLUMNS: ColumnDef<Row>[] = [+ {+ accessorKey: 'name',+ header: ({ column }) => (+ <DataTableColumnHeader+ column={column}+ title="Name"+ />+ ),+ },+ { enableSorting: false, header: 'Actions', id: 'actions' },+ ];++ const nameHeader = () => screen.getByRole('columnheader', { name: 'Name' });++ it('cycles `aria-sort` on the header cell as the column is sorted', () => {+ render(+ <DataTable<Row>+ columns={SORTABLE_COLUMNS}+ data={ROWS}+ />,+ { wrapper: Wrapper },+ );++ expect(nameHeader()).toHaveAttribute('aria-sort', 'none');++ const sortButton = screen.getByRole('button', { name: 'Name' });++ fireEvent.click(sortButton);+ expect(nameHeader()).toHaveAttribute('aria-sort', 'ascending');++ fireEvent.click(sortButton);+ expect(nameHeader()).toHaveAttribute('aria-sort', 'descending');++ fireEvent.click(sortButton);+ expect(nameHeader()).toHaveAttribute('aria-sort', 'none');+ });++ it('omits `aria-sort` on a column that cannot be sorted', () => {+ render(+ <DataTable<Row>+ columns={SORTABLE_COLUMNS}+ data={ROWS}+ />,+ { wrapper: Wrapper },+ );++ expect(screen.getByRole('columnheader', { name: 'Actions' })).not.toHaveAttribute('aria-sort');+ });+});+interface FakeColumn {clearSorting: ReturnType<typeof vi.fn>;getIsSorted: ReturnType<typeof vi.fn>;diff --git a/frontend/src/components/ui/data-table.tsx b/frontend/src/components/ui/data-table.tsxindex db738b48..ca4c6654 100644--- a/frontend/src/components/ui/data-table.tsx+++ b/frontend/src/components/ui/data-table.tsx@@ -59,6 +59,7 @@ import { useLatestRef } from '@/hooks/use-latest-ref';import { usePageStorageKeys } from '@/hooks/use-page-storage-keys';import { useWindowVirtualList } from '@/hooks/use-window-virtual-list';import { migrateLegacyTableState, updateTableState } from '@/lib/table-state';+import { matchesTextFilter } from '@/lib/text-filter';import { cn } from '@/lib/utils';/**@@ -283,6 +284,26 @@ export function cycleColumnSort<TData, TValue = unknown>(column: Column<TData, Tcolumn.toggleSorting(false);}+function columnAriaSort<TData, TValue = unknown>(+ column: Column<TData, TValue>,+): 'ascending' | 'descending' | 'none' | undefined {+ if (!column.getCanSort()) {+ return undefined;+ }++ const sorted = column.getIsSorted();++ if (sorted === 'asc') {+ return 'ascending';+ }++ if (sorted === 'desc') {+ return 'descending';+ }++ return 'none';+}+function DataTable<TData, TValue = unknown>({columns,columnVisibility: externalColumnVisibility,@@ -558,10 +579,9 @@ function DataTable<TData, TValue = unknown>({[handlePaginationChange],);- // Case-insensitive substring predicate that consults the composite- // filter for both "what to look for" and "where to look". Returning- // `true` for the empty query keeps the default "no filter = all rows"- // behaviour identical to TanStack's built-in `includesString`.+ // Matching is delegated to the shared text-filter because the same `?q=`+ // also drives detail-navigation's Prev/Next subset, and the two must agree+ // on what matches.const globalFilterFn = useCallback<FilterFn<TData>>((row, columnId, filter: DataTableGlobalFilter) => {if (!filter.query) {return true;@@ -573,9 +593,7 @@ function DataTable<TData, TValue = unknown>({const value = row.getValue(columnId);- return String(value ?? '')- .toLowerCase()- .includes(filter.query.toLowerCase());+ return matchesTextFilter(String(value ?? ''), filter.query);}, []);const table = useReactTable({@@ -764,6 +782,7 @@ function DataTable<TData, TValue = unknown>({>{headerGroup.headers.map((header) => (<TableHead+ aria-sort={columnAriaSort(header.column)}className={cn('truncate', header.column.columnDef.meta?.headerClassName)}key={header.id}style={@@ -939,7 +958,7 @@ function DataTableColumnHeader<TData, TValue = unknown>({ column, title }: DataTreturn (<Button- className="text-muted-foreground hover:text-primary flex items-center gap-2 p-0 no-underline hover:no-underline"+ className="text-muted-foreground hover:text-link flex items-center gap-2 p-0 no-underline hover:no-underline"onClick={() => cycleColumnSort(column)}variant="link">@@ -1043,6 +1062,7 @@ function DataTableFilter({ onQueryChange, placeholder, query }: DataTableFilterP{localValue ? (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear search"onClick={handleClear}type="button">diff --git a/frontend/src/components/ui/dialog.test.tsx b/frontend/src/components/ui/dialog.test.tsxnew file mode 100644index 00000000..3f61fae3--- /dev/null+++ b/frontend/src/components/ui/dialog.test.tsx@@ -0,0 +1,142 @@+import { render, screen, waitFor } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { useState } from 'react';+import { describe, expect, it } from 'vitest';++import { ContextMenu, ContextMenuContent, ContextMenuItem, ContextMenuTrigger } from '@/components/ui/context-menu';+import {+ DropdownMenu,+ DropdownMenuContent,+ DropdownMenuItem,+ DropdownMenuTrigger,+} from '@/components/ui/dropdown-menu';++import { Dialog, DialogContent, DialogDescription, DialogTitle } from './dialog';++const DialogFromButton = () => {+ const [isOpen, setIsOpen] = useState(false);++ return (+ <>+ <button+ onClick={() => setIsOpen(true)}+ type="button"+ >+ Delete resource+ </button>+ <Dialog+ onOpenChange={setIsOpen}+ open={isOpen}+ >+ <DialogContent>+ <DialogTitle>Delete resource</DialogTitle>+ <DialogDescription>This cannot be undone.</DialogDescription>+ </DialogContent>+ </Dialog>+ </>+ );+};++const DialogFromDropdown = () => {+ const [isOpen, setIsOpen] = useState(false);++ return (+ <>+ <DropdownMenu>+ <DropdownMenuTrigger>Row actions</DropdownMenuTrigger>+ <DropdownMenuContent>+ <DropdownMenuItem onSelect={() => setIsOpen(true)}>Delete</DropdownMenuItem>+ </DropdownMenuContent>+ </DropdownMenu>+ <Dialog+ onOpenChange={setIsOpen}+ open={isOpen}+ >+ <DialogContent>+ <DialogTitle>Delete resource</DialogTitle>+ <DialogDescription>This cannot be undone.</DialogDescription>+ </DialogContent>+ </Dialog>+ </>+ );+};++describe('Dialog focus return', () => {+ it('returns focus to the button that opened the dialog', async () => {+ const user = userEvent.setup();+ render(<DialogFromButton />);++ const opener = screen.getByRole('button', { name: 'Delete resource' });+ await user.click(opener);+ await screen.findByRole('dialog');++ await user.keyboard('{Escape}');+ await waitFor(() => {+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();+ });++ expect(document.activeElement).toBe(opener);+ });++ it('returns focus to the menu trigger when the dialog was opened from a menu item', async () => {+ const user = userEvent.setup();+ render(<DialogFromDropdown />);++ const trigger = screen.getByRole('button', { name: 'Row actions' });+ await user.click(trigger);+ await user.click(await screen.findByRole('menuitem', { name: 'Delete' }));+ await screen.findByRole('dialog');++ await user.keyboard('{Escape}');+ await waitFor(() => {+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();+ });++ expect(document.activeElement).toBe(trigger);+ });+});++const DialogFromContextMenu = () => {+ const [isOpen, setIsOpen] = useState(false);++ return (+ <>+ <ContextMenu>+ <ContextMenuTrigger>Row</ContextMenuTrigger>+ <ContextMenuContent>+ <ContextMenuItem onSelect={() => setIsOpen(true)}>Delete</ContextMenuItem>+ </ContextMenuContent>+ </ContextMenu>+ <Dialog+ onOpenChange={setIsOpen}+ open={isOpen}+ >+ <DialogContent>+ <DialogTitle>Delete resource</DialogTitle>+ <DialogDescription>This cannot be undone.</DialogDescription>+ </DialogContent>+ </Dialog>+ </>+ );+};++describe('Dialog opened from a context menu', () => {+ it('returns focus to the context-menu trigger', async () => {+ const user = userEvent.setup();++ render(<DialogFromContextMenu />);++ const trigger = document.querySelector<HTMLElement>('[data-slot="context-menu-trigger"]')!;++ await user.pointer({ keys: '[MouseRight]', target: trigger });+ await user.click(await screen.findByRole('menuitem', { name: 'Delete' }));+ await screen.findByRole('dialog');++ await user.keyboard('{Escape}');+ await waitFor(() => {+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();+ });++ expect(document.activeElement).toBe(trigger);+ });+});diff --git a/frontend/src/components/ui/dialog.tsx b/frontend/src/components/ui/dialog.tsxindex b0915fe5..6efcbab6 100644--- a/frontend/src/components/ui/dialog.tsx+++ b/frontend/src/components/ui/dialog.tsx@@ -34,6 +34,10 @@ function DialogContent({ children, className, ...props }: React.ComponentProps<tdata-slot="dialog-content"{...props}>+ {/* Radix returns focus to its own DialogTrigger; these dialogs are opened from state,+ and their content is often unmounted before Radix's close sequence runs, so its+ `onCloseAutoFocus` never fires. */}+ <FocusReturn />{children}<DialogPrimitive.CloseclassName="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-sm opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none"@@ -119,6 +123,46 @@ function DialogTrigger({ ...props }: React.ComponentProps<typeof DialogPrimitive);}+/**+ * Rendered inside the content, so it mounts when the overlay opens and unmounts when it closes —+ * a wrapper-level hook would instead run when the PAGE mounts, because most dialogs and sheets here+ * render their content unconditionally and let Radix decide whether it is on screen.+ */+function FocusReturn() {+ // Captured during this component's first render: by the time effects run, Radix has already+ // moved focus inside the content.+ const [opener] = React.useState(resolveOpener);++ React.useEffect(+ () => () => {+ if (opener?.isConnected) {+ opener.focus();+ }+ },+ [opener],+ );++ return null;+}++function resolveOpener(): HTMLElement | null {+ const active = document.activeElement as HTMLElement | null;+ const menu = active?.closest('[role="menu"]');++ if (!menu) {+ return active;+ }++ // Radix labels dropdown content with its trigger's id; context-menu content carries no such+ // link, so the still-open trigger has to be found by slot.+ const triggerId = menu.getAttribute('aria-labelledby');+ const trigger = triggerId+ ? document.getElementById(triggerId)+ : document.querySelector<HTMLElement>('[data-slot="context-menu-trigger"][data-state="open"]');++ return trigger ?? active;+}+export {Dialog,DialogClose,@@ -128,4 +172,5 @@ export {DialogHeader,DialogTitle,DialogTrigger,+ FocusReturn,};diff --git a/frontend/src/components/ui/empty.tsx b/frontend/src/components/ui/empty.tsxindex 67d75537..a714a549 100644--- a/frontend/src/components/ui/empty.tsx+++ b/frontend/src/components/ui/empty.tsx@@ -54,7 +54,7 @@ function EmptyDescription({ className, ...props }: React.ComponentProps<'p'>) {return (<divclassName={cn(- 'text-muted-foreground [&>a:hover]:text-primary text-sm/relaxed [&>a]:underline [&>a]:underline-offset-4',+ 'text-muted-foreground [&>a:hover]:text-link text-sm/relaxed [&>a]:underline [&>a]:underline-offset-4',className,)}data-slot="empty-description"diff --git a/frontend/src/components/ui/sheet.test.tsx b/frontend/src/components/ui/sheet.test.tsxnew file mode 100644index 00000000..9f70a4cd--- /dev/null+++ b/frontend/src/components/ui/sheet.test.tsx@@ -0,0 +1,96 @@+import { render, screen, waitFor } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { useState } from 'react';+import { describe, expect, it } from 'vitest';++import {+ DropdownMenu,+ DropdownMenuContent,+ DropdownMenuItem,+ DropdownMenuTrigger,+} from '@/components/ui/dropdown-menu';++import { Sheet, SheetContent, SheetDescription, SheetTitle } from './sheet';++const SheetFromButton = () => {+ const [isOpen, setIsOpen] = useState(false);++ return (+ <>+ <button+ onClick={() => setIsOpen(true)}+ type="button"+ >+ Open details+ </button>+ <Sheet+ onOpenChange={setIsOpen}+ open={isOpen}+ >+ <SheetContent>+ <SheetTitle>Details</SheetTitle>+ <SheetDescription>Everything about this row.</SheetDescription>+ </SheetContent>+ </Sheet>+ </>+ );+};++const SheetFromDropdown = () => {+ const [isOpen, setIsOpen] = useState(false);++ return (+ <>+ <DropdownMenu>+ <DropdownMenuTrigger>Row actions</DropdownMenuTrigger>+ <DropdownMenuContent>+ <DropdownMenuItem onSelect={() => setIsOpen(true)}>Details</DropdownMenuItem>+ </DropdownMenuContent>+ </DropdownMenu>+ <Sheet+ onOpenChange={setIsOpen}+ open={isOpen}+ >+ <SheetContent>+ <SheetTitle>Details</SheetTitle>+ <SheetDescription>Everything about this row.</SheetDescription>+ </SheetContent>+ </Sheet>+ </>+ );+};++describe('Sheet focus return', () => {+ it('returns focus to the button that opened the sheet', async () => {+ const user = userEvent.setup();+ render(<SheetFromButton />);++ const opener = screen.getByRole('button', { name: 'Open details' });+ await user.click(opener);+ await screen.findByRole('dialog');++ await user.keyboard('{Escape}');+ await waitFor(() => {+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();+ });++ expect(document.activeElement).toBe(opener);+ });++ it('returns focus to the menu trigger when the sheet was opened from a menu item', async () => {+ const user = userEvent.setup();+ render(<SheetFromDropdown />);++ const trigger = screen.getByRole('button', { name: 'Row actions' });+ await user.click(trigger);+ await user.click(await screen.findByRole('menuitem', { name: 'Details' }));+ await screen.findByRole('dialog');++ await user.keyboard('{Escape}');+ await waitFor(() => {+ expect(screen.queryByRole('dialog')).not.toBeInTheDocument();+ });++ expect(document.activeElement).toBe(trigger);+ });+});diff --git a/frontend/src/components/ui/sheet.tsx b/frontend/src/components/ui/sheet.tsxindex ff21cd4a..3735bec4 100644--- a/frontend/src/components/ui/sheet.tsx+++ b/frontend/src/components/ui/sheet.tsx@@ -5,6 +5,7 @@ import { cva, type VariantProps } from 'class-variance-authority';import { X } from 'lucide-react';import * as React from 'react';+import { FocusReturn } from '@/components/ui/dialog';import { cn } from '@/lib/utils';function Sheet({ ...props }: React.ComponentProps<typeof SheetPrimitive.Root>) {@@ -88,6 +89,7 @@ function SheetContent({ children, className, container, overlay = true, side = 'data-slot="sheet-content"{...props}>+ <FocusReturn /><SheetPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-secondary absolute top-4 right-4 rounded-sm opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none"><X className="h-4 w-4" />{/* Not "Close": a sheet with its own footer Close button woulddiff --git a/frontend/src/features/authentication/password-change-form.tsx b/frontend/src/features/authentication/password-change-form.tsxindex 96058bb1..218b7900 100644--- a/frontend/src/features/authentication/password-change-form.tsx+++ b/frontend/src/features/authentication/password-change-form.tsx@@ -17,7 +17,10 @@ const passwordChangeSchema = znewPassword: z.string().min(8, { message: 'Password must be at least 8 characters' })- .max(100, { message: 'Password must not exceed 100 characters' })+ // bcrypt, which hashes it server-side, refuses anything longer than 72 bytes.+ .refine((password) => new TextEncoder().encode(password).length <= 72, {+ message: 'Password must not exceed 72 characters',+ }).refine((password) => {if (password.length > 15) {diff --git a/frontend/src/features/flows/agents/flow-agents.tsx b/frontend/src/features/flows/agents/flow-agents.tsxindex d13fb7c2..9823cff1 100644--- a/frontend/src/features/flows/agents/flow-agents.tsx+++ b/frontend/src/features/flows/agents/flow-agents.tsx@@ -157,6 +157,7 @@ function FlowAgents() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear agent search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -206,6 +207,7 @@ function FlowAgents() {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest agent log"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/files/flow-files-attach-resources-dialog.tsx b/frontend/src/features/flows/files/flow-files-attach-resources-dialog.tsxindex 66ee05e2..7396e1d6 100644--- a/frontend/src/features/flows/files/flow-files-attach-resources-dialog.tsx+++ b/frontend/src/features/flows/files/flow-files-attach-resources-dialog.tsx@@ -235,6 +235,7 @@ function FlowFilesAttachResourcesDialogBody({{searchQuery && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear resource search"onClick={() => setSearchQuery('')}type="button">diff --git a/frontend/src/features/flows/files/flow-files-pull-dialog.tsx b/frontend/src/features/flows/files/flow-files-pull-dialog.tsxindex fb15d678..b76d4275 100644--- a/frontend/src/features/flows/files/flow-files-pull-dialog.tsx+++ b/frontend/src/features/flows/files/flow-files-pull-dialog.tsx@@ -421,6 +421,7 @@ function FlowFilesPullDialogForm({ cachedFiles, flowId, onClose, onSuccess }: Fl<TooltipTrigger asChild><span><Button+ aria-label="Parent directory"disabled={isUpDisabled}onClick={handleNavigateUp}size="icon-sm"@@ -438,6 +439,7 @@ function FlowFilesPullDialogForm({ cachedFiles, flowId, onClose, onSuccess }: Fl<TooltipTrigger asChild><span><Button+ aria-label="Refresh listing"disabled={isListingLoading || isPulling}onClick={handleRefresh}size="icon-sm"diff --git a/frontend/src/features/flows/files/flow-files.tsx b/frontend/src/features/flows/files/flow-files.tsxindex eccb6eab..c08108b7 100644--- a/frontend/src/features/flows/files/flow-files.tsx+++ b/frontend/src/features/flows/files/flow-files.tsx@@ -204,7 +204,7 @@ function FlowFiles() {{isDragging && (<div className="bg-primary/10 border-primary pointer-events-none absolute inset-0 z-30 flex items-center justify-center rounded-lg border-2 border-dashed">- <div className="text-primary flex flex-col items-center gap-2">+ <div className="text-link flex flex-col items-center gap-2"><FolderUp className="size-8" /><span className="text-sm font-medium">Drop files to upload</span></div>@@ -233,6 +233,7 @@ function FlowFiles() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear file search"onClick={search.resetSearch}type="button">@@ -250,6 +251,7 @@ function FlowFiles() {<TooltipTrigger asChild><span><Button+ aria-label="Upload files"disabled={upload.isUploading || isLoading}onClick={upload.openFilePicker}size="icon-sm"@@ -272,6 +274,7 @@ function FlowFiles() {<TooltipTrigger asChild><span><Button+ aria-label="Attach resources"disabled={isAttachResourcesDisabled}onClick={handleOpenAttachResourcesDialog}size="icon-sm"@@ -295,6 +298,7 @@ function FlowFiles() {<TooltipTrigger asChild><span><Button+ aria-label="Pull from container"disabled={isPullDisabled}onClick={handleOpenPullDialog}size="icon-sm"diff --git a/frontend/src/features/flows/flow-form.test.tsx b/frontend/src/features/flows/flow-form.test.tsxnew file mode 100644index 00000000..fd20bf23--- /dev/null+++ b/frontend/src/features/flows/flow-form.test.tsx@@ -0,0 +1,127 @@+import { render, screen, waitFor } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { beforeEach, describe, expect, it, vi } from 'vitest';++const { setSelectedProvider, uploadParams } = vi.hoisted(() => ({+ setSelectedProvider: vi.fn(),+ uploadParams: { current: null } as { current: null | { onSuccess: (uploaded: { items: unknown[] }) => void } },+}));++vi.mock('@/providers/providers-provider', () => ({+ useProviders: () => ({+ providers: [{ name: 'openai', type: 'openai' }],+ setSelectedProvider,+ }),+}));++vi.mock('@/providers/templates-provider', () => ({+ useTemplates: () => ({ templates: [] }),+}));++vi.mock('@/providers/resources-provider', () => ({+ useResources: () => ({+ resources: [+ {+ createdAt: '',+ id: '7',+ isDir: false,+ name: 'scope.txt',+ path: 'scope.txt',+ size: 12,+ updatedAt: '',+ userId: '1',+ },+ ],+ }),+}));++vi.mock('@/features/resources/use-resources-upload', () => ({+ useResourcesUpload: (params: { onSuccess: (uploaded: { items: unknown[] }) => void }) => {+ uploadParams.current = params;++ return { isUploading: false, uploadFiles: vi.fn() };+ },+}));++const { FlowForm } = await import('./flow-form');++const attachResource = async () => {+ await waitFor(() => expect(uploadParams.current).not.toBeNull());+ uploadParams.current!.onSuccess({ items: [{ id: 7 }] });+ await screen.findByRole('button', { name: 'Remove scope.txt' });+};++beforeEach(() => {+ uploadParams.current = null;+ setSelectedProvider.mockClear();+});++describe('FlowForm attachments', () => {+ it('clears the attached resources after a submit', async () => {+ const user = userEvent.setup({ delay: null });+ const onSubmit = vi.fn();++ render(+ <FlowForm+ defaultValues={{ providerName: 'openai' }}+ onSubmit={onSubmit}+ type="assistant"+ />,+ );++ await attachResource();++ await user.type(screen.getByRole('textbox'), 'scan it');+ await user.click(screen.getByRole('button', { name: 'Submit' }));++ await waitFor(() => expect(onSubmit).toHaveBeenCalledOnce());+ expect(onSubmit.mock.calls[0]?.[0]).toMatchObject({ message: 'scan it', resourceIds: ['7'] });++ await waitFor(() => expect(screen.queryByRole('button', { name: 'Remove scope.txt' })).not.toBeInTheDocument());+ });++ it('does not resend the previous attachments on the next submit', async () => {+ const user = userEvent.setup({ delay: null });+ const onSubmit = vi.fn();++ render(+ <FlowForm+ defaultValues={{ providerName: 'openai' }}+ onSubmit={onSubmit}+ type="assistant"+ />,+ );++ await attachResource();++ await user.type(screen.getByRole('textbox'), 'first');+ await user.click(screen.getByRole('button', { name: 'Submit' }));+ await waitFor(() => expect(onSubmit).toHaveBeenCalledOnce());++ await user.type(screen.getByRole('textbox'), 'second');+ await user.click(screen.getByRole('button', { name: 'Submit' }));++ await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(2));+ expect(onSubmit.mock.calls[1]?.[0]).toMatchObject({ message: 'second', resourceIds: [] });+ });++ it('adopts resourceIds that arrive through defaultValues after mount', async () => {+ const { rerender } = render(+ <FlowForm+ defaultValues={{ providerName: 'openai' }}+ onSubmit={vi.fn()}+ type="assistant"+ />,+ );++ rerender(+ <FlowForm+ defaultValues={{ providerName: 'openai', resourceIds: ['7'] }}+ onSubmit={vi.fn()}+ type="assistant"+ />,+ );++ expect(await screen.findByRole('button', { name: 'Remove scope.txt' })).toBeInTheDocument();+ });+});diff --git a/frontend/src/features/flows/flow-form.tsx b/frontend/src/features/flows/flow-form.tsxindex 1e0e3efb..1dd18744 100644--- a/frontend/src/features/flows/flow-form.tsx+++ b/frontend/src/features/flows/flow-form.tsx@@ -13,7 +13,7 @@ import {} from 'lucide-react';import { useCallback, useEffect, useMemo, useState } from 'react';import { useRef } from 'react';-import { useWatch } from 'react-hook-form';+import { useController } from 'react-hook-form';import { z } from 'zod';import type { UserResourceFragmentFragment } from '@/graphql/types';@@ -164,7 +164,10 @@ export function FlowForm({setValue,} = form;- const resourceIds = useWatch({ control, name: 'resourceIds' });+ // useController registers the field; with useWatch alone `resetField('resourceIds')` is a no-op.+ const {+ field: { value: resourceIds },+ } = useController({ control, name: 'resourceIds' });const updateResourceIds = useCallback((updater: ((current: string[]) => string[]) | Array<number | string>) => {@@ -234,9 +237,12 @@ export function FlowForm({}).forEach(([fieldName, defaultValue]) => {const typedFieldName = fieldName as keyof FlowFormValues;- setValue(typedFieldName, defaultValue as never, { shouldDirty: false });+ // resetField, not setValue: it moves react-hook-form's own baseline too, so a later+ // pick that happens to equal the mount-time default still counts as dirty and this+ // effect leaves it alone.+ resetField(typedFieldName, { defaultValue: defaultValue as never });});- }, [defaultValues, dirtyFields, setValue, getValues]);+ }, [defaultValues, dirtyFields, resetField, getValues]);const isFormDisabled = isDisabled || isLoading || isSubmitting || isCanceling;@@ -336,6 +342,7 @@ export function FlowForm({{templateSearch && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear template search"onClick={(event) => {event.stopPropagation();setTemplateSearch('');@@ -390,6 +397,7 @@ export function FlowForm({{resourceSearch && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear resource search"onClick={(event) => {event.stopPropagation();setResourceSearch('');@@ -574,6 +582,7 @@ export function FlowForm({{providerSearch && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear provider search"onClick={(event) => {event.stopPropagation();setProviderSearch('');diff --git a/frontend/src/features/flows/flow-scroll-to-latest.test.tsx b/frontend/src/features/flows/flow-scroll-to-latest.test.tsxnew file mode 100644index 00000000..cf97d119--- /dev/null+++ b/frontend/src/features/flows/flow-scroll-to-latest.test.tsx@@ -0,0 +1,101 @@+import { render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import { describe, expect, it, vi } from 'vitest';++import { TooltipProvider } from '@/components/ui/tooltip';+import { StatusType } from '@/graphql/types';++const flowState = vi.hoisted(() => ({ current: {} as Record<string, unknown> }));++vi.mock('@/hooks/use-auto-scroll', () => ({+ useAutoScroll: () => ({+ containerRef: () => {},+ endRef: { current: null },+ hasNewMessages: false,+ isScrolledToBottom: false,+ scrollToEnd: vi.fn(),+ }),+}));++vi.mock('@/providers/flow-provider', () => ({ useFlow: () => flowState.current }));+vi.mock('@/providers/providers-provider', () => ({ useProviders: () => ({ providers: [] }) }));+vi.mock('@/providers/system-settings-provider', () => ({ useSystemSettings: () => ({ settings: null }) }));++vi.mock('./flow-form', () => ({ FlowForm: () => <div /> }));+vi.mock('./flow-tasks-dropdown', () => ({ default: () => <div /> }));+vi.mock('./agents/flow-agent', () => ({ default: () => <div /> }));+vi.mock('./tools/flow-tool', () => ({ default: () => <div /> }));+vi.mock('./vector-stores/flow-vector-store', () => ({ default: () => <div /> }));+vi.mock('./tasks/flow-task', () => ({ default: () => <div /> }));+vi.mock('./screenshots/flow-screenshot', () => ({ default: () => <div /> }));+vi.mock('./messages/flow-message', () => ({ default: () => <div /> }));++const { default: FlowAgents } = await import('./agents/flow-agents');+const { default: FlowScreenshots } = await import('./screenshots/flow-screenshots');+const { default: FlowTasks } = await import('./tasks/flow-tasks');+const { default: FlowTools } = await import('./tools/flow-tools');+const { default: FlowVectorStores } = await import('./vector-stores/flow-vector-stores');+const { default: FlowAssistantMessages } = await import('./messages/flow-assistant-messages');+const { default: FlowAutomationMessages } = await import('./messages/flow-automation-messages');++const item = { id: '1' };++const assistantFlowState = {+ assistantLogs: [{ assistantId: '5', id: '1' }],+ assistants: [{ id: '5', provider: { name: 'openai' }, status: StatusType.Running, title: 'Recon assistant' }],+ createAssistant: vi.fn(),+ deleteAssistant: vi.fn(),+ flowId: '42',+ flowStatus: StatusType.Running,+ initiateAssistantCreation: vi.fn(),+ selectAssistant: vi.fn(),+ selectedAssistantId: '5',+ stopAssistant: vi.fn(),+ submitAssistantMessage: vi.fn(),+};++const renderWithFlow = (state: Record<string, unknown>, ui: React.ReactElement) => {+ flowState.current = { flowId: '42', ...state };++ return render(<TooltipProvider>{ui}</TooltipProvider>);+};++describe('scroll-to-latest buttons carry an accessible name', () => {+ it.each([+ ['Scroll to latest agent log', { flowData: { agentLogs: [item] } }, <FlowAgents key="agents" />],+ ['Scroll to latest tool log', { flowData: { searchLogs: [item] } }, <FlowTools key="tools" />],+ [+ 'Scroll to latest vector store log',+ { flowData: { vectorStoreLogs: [item] } },+ <FlowVectorStores key="vector-stores" />,+ ],+ ['Scroll to latest task', { flowData: { tasks: [item] } }, <FlowTasks key="tasks" />],+ ['Scroll to latest screenshot', { flowData: { screenshots: [item] } }, <FlowScreenshots key="screenshots" />],+ [+ 'Scroll to latest message',+ {+ flowData: { messageLogs: [item] },+ flowStatus: StatusType.Running,+ stopAutomation: vi.fn(),+ submitAutomationMessage: vi.fn(),+ },+ <FlowAutomationMessages key="automation" />,+ ],+ ['Scroll to latest message', assistantFlowState, <FlowAssistantMessages key="assistant" />],+ ])('names the %s button', (name, state, ui) => {+ renderWithFlow(state, ui);++ expect(screen.getByRole('button', { name })).toBeInTheDocument();+ });+});++describe('assistant list', () => {+ it('names the per-assistant delete button after the assistant', async () => {+ const user = userEvent.setup({ delay: null });+ renderWithFlow(assistantFlowState, <FlowAssistantMessages />);++ await user.click(screen.getByRole('button', { name: 'Select assistant' }));++ expect(await screen.findByRole('button', { name: 'Delete Recon assistant' })).toBeInTheDocument();+ });+});diff --git a/frontend/src/features/flows/messages/flow-assistant-messages.tsx b/frontend/src/features/flows/messages/flow-assistant-messages.tsxindex 9dfb5980..680d6804 100644--- a/frontend/src/features/flows/messages/flow-assistant-messages.tsx+++ b/frontend/src/features/flows/messages/flow-assistant-messages.tsx@@ -159,6 +159,7 @@ function AssistantsDropdown({{!isDisabled && (<Button+ aria-label={`Delete ${assistant.title}`}className="text-muted-foreground hover:text-destructive absolute top-1/2 right-0.5 shrink-0 -translate-y-1/2 opacity-0 transition-opacity group-hover:opacity-100"onClick={(event) => {event.stopPropagation();@@ -182,6 +183,7 @@ function AssistantsDropdown({><PopoverTrigger asChild><Button+ aria-label="Select assistant"className="px-2"disabled={isAssistantCreating}variant="outline"@@ -525,6 +527,7 @@ function FlowAssistantMessages({ className }: FlowAssistantMessagesProps) {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear message search"disabled={isAssistantCreating}onClick={() => {form.reset({ search: '' });@@ -575,6 +578,7 @@ function FlowAssistantMessages({ className }: FlowAssistantMessagesProps) {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest message"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/messages/flow-automation-messages.tsx b/frontend/src/features/flows/messages/flow-automation-messages.tsxindex 8469f0cc..963c2a38 100644--- a/frontend/src/features/flows/messages/flow-automation-messages.tsx+++ b/frontend/src/features/flows/messages/flow-automation-messages.tsx@@ -216,6 +216,7 @@ function FlowAutomationMessages({ className }: FlowAutomationMessagesProps) {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear message search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -265,6 +266,7 @@ function FlowAutomationMessages({ className }: FlowAutomationMessagesProps) {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest message"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/messages/flow-message.tsx b/frontend/src/features/flows/messages/flow-message.tsxindex 7f8cb0e3..b95bc2da 100644--- a/frontend/src/features/flows/messages/flow-message.tsx+++ b/frontend/src/features/flows/messages/flow-message.tsx@@ -210,7 +210,7 @@ function FlowMessage({ log, searchValue = '' }: FlowMessageProps) {<span className="text-muted-foreground/50">{formatDate(new Date(createdAt))}</span><spanclassName="text-muted-foreground/50"- data-testid="flow-message-id"+ data-slot="flow-message-id">{log.id}</span>diff --git a/frontend/src/features/flows/screenshots/flow-screenshots.tsx b/frontend/src/features/flows/screenshots/flow-screenshots.tsxindex df81a101..51cf2a9a 100644--- a/frontend/src/features/flows/screenshots/flow-screenshots.tsx+++ b/frontend/src/features/flows/screenshots/flow-screenshots.tsx@@ -99,6 +99,7 @@ function FlowScreenshots() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear screenshot search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -135,6 +136,7 @@ function FlowScreenshots() {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest screenshot"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/tasks/flow-tasks.tsx b/frontend/src/features/flows/tasks/flow-tasks.tsxindex ec0881f6..ea203b8d 100644--- a/frontend/src/features/flows/tasks/flow-tasks.tsx+++ b/frontend/src/features/flows/tasks/flow-tasks.tsx@@ -115,6 +115,7 @@ function FlowTasks() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear task search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -152,6 +153,7 @@ function FlowTasks() {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest task"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/terminal/flow-terminal.tsx b/frontend/src/features/flows/terminal/flow-terminal.tsxindex af10bca2..c7909f9a 100644--- a/frontend/src/features/flows/terminal/flow-terminal.tsx+++ b/frontend/src/features/flows/terminal/flow-terminal.tsx@@ -192,6 +192,7 @@ function FlowTerminal() {)}{field.value && (<InputGroupButton+ aria-label="Clear terminal search"onClick={handleClearSearch}size="icon-xs"title="Clear search"diff --git a/frontend/src/features/flows/tools/flow-tools.tsx b/frontend/src/features/flows/tools/flow-tools.tsxindex 80c93fb6..dee01dec 100644--- a/frontend/src/features/flows/tools/flow-tools.tsx+++ b/frontend/src/features/flows/tools/flow-tools.tsx@@ -158,6 +158,7 @@ function FlowTools() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear tool search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -207,6 +208,7 @@ function FlowTools() {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest tool log"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/flows/vector-stores/flow-vector-stores.tsx b/frontend/src/features/flows/vector-stores/flow-vector-stores.tsxindex 73ba19a5..799e9ac9 100644--- a/frontend/src/features/flows/vector-stores/flow-vector-stores.tsx+++ b/frontend/src/features/flows/vector-stores/flow-vector-stores.tsx@@ -159,6 +159,7 @@ function FlowVectorStores() {{field.value && (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear vector store search"onClick={() => {form.reset({ search: '' });setDebouncedSearchValue('');@@ -207,6 +208,7 @@ function FlowVectorStores() {{!isScrolledToBottom && (<Button+ aria-label="Scroll to latest vector store log"className="absolute right-4 bottom-4 z-10 shadow-md hover:shadow-lg"onClick={() => scrollToEnd()}size="icon-sm"diff --git a/frontend/src/features/knowledges/knowledge-form.tsx b/frontend/src/features/knowledges/knowledge-form.tsxindex 0c73259e..16614a15 100644--- a/frontend/src/features/knowledges/knowledge-form.tsx+++ b/frontend/src/features/knowledges/knowledge-form.tsx@@ -237,7 +237,12 @@ export function KnowledgeForm({ initialValues, isNew, knowledge, onSubmit }: Kno// Reset BEFORE the caller navigates so `isDirty` is false by the// time the blocker re-evaluates (the caller also calls// `skipNextBlock` to cover reset's async state propagation).- reset(resetValues, { keepDefaultValues: false });+ //+ // `keepDirtyValues: false` is not the default here: RHF merges the form-level `resetOptions`+ // into every manual reset, and this form sets `keepDirtyValues` there to protect unsaved edits+ // during a subscription resync. Inherited by a POST-save reset it keeps the pre-save values and+ // their dirty flags, so a later save can send a stale field back and silently revert it.+ reset(resetValues, { keepDefaultValues: false, keepDirtyValues: false });return result;} catch (error) {diff --git a/frontend/src/features/knowledges/knowledge-header.tsx b/frontend/src/features/knowledges/knowledge-header.tsxindex 00eb4586..8e10cb4f 100644--- a/frontend/src/features/knowledges/knowledge-header.tsx+++ b/frontend/src/features/knowledges/knowledge-header.tsx@@ -195,6 +195,14 @@ export function KnowledgeHeader({</Breadcrumb></AppHeaderContent><AppHeaderActions>+ {!isNew && !isMobile && (+ <DetailNavigationToolbar<Knowledge>+ controller={knowledgeNav}+ renderItem={renderKnowledgeItem}+ sheetIcon={<LibraryBig className="size-4" />}+ sheetTitle="Knowledges"+ />+ )}{canAnonymize && !isMobile && (<AppHeaderActiondisabled={isAnonymizeDisabled}@@ -213,14 +221,6 @@ export function KnowledgeHeader({type="button"/>)}- {!isNew && !isMobile && (- <DetailNavigationToolbar<Knowledge>- controller={knowledgeNav}- renderItem={renderKnowledgeItem}- sheetIcon={<LibraryBig className="size-4" />}- sheetTitle="Knowledges"- />- )}<DropdownMenu><DropdownMenuTrigger asChild><Buttondiff --git a/frontend/src/graphql/types.ts b/frontend/src/graphql/types.tsindex 62ad1541..a1a2533e 100644--- a/frontend/src/graphql/types.ts+++ b/frontend/src/graphql/types.ts@@ -6,14 +6,18 @@ import type { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-export type AgentConfigInput = {extraBody?: Record<string, unknown> | null | undefined;frequencyPenalty?: number | null | undefined;+ json?: boolean | null | undefined;maxLength?: number | null | undefined;maxTokens?: number | null | undefined;minLength?: number | null | undefined;+ minP?: number | null | undefined;model: string;+ n?: number | null | undefined;presencePenalty?: number | null | undefined;price?: ModelPriceInput | null | undefined;reasoning?: ReasoningConfigInput | null | undefined;repetitionPenalty?: number | null | undefined;+ responseMimeType?: string | null | undefined;temperature?: number | null | undefined;topK?: number | null | undefined;topP?: number | null | undefined;@@ -547,6 +551,10 @@ export type AgentConfigFragmentFragment = {repetitionPenalty: number | null;frequencyPenalty: number | null;presencePenalty: number | null;+ minP: number | null;+ n: number | null;+ json: boolean | null;+ responseMimeType: string | null;extraBody: Record<string, unknown> | null;reasoning: { mode: ReasoningMode | null; effort: ReasoningEffort | null; maxTokens: number | null } | null;price: { input: number; output: number; cacheRead: number; cacheWrite: number } | null;@@ -2166,6 +2174,10 @@ export const AgentConfigFragmentFragmentDoc = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -2357,6 +2369,10 @@ export const AgentsConfigFragmentFragmentDoc = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -2433,6 +2449,10 @@ export const ProviderConfigFragmentFragmentDoc = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -3884,6 +3904,10 @@ export const SettingsProvidersDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -8789,6 +8813,10 @@ export const CreateProviderDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -9062,6 +9090,10 @@ export const UpdateProviderDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -11291,6 +11323,10 @@ export const ProviderCreatedDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -11527,6 +11563,10 @@ export const ProviderUpdatedDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },@@ -11763,6 +11803,10 @@ export const ProviderDeletedDocument = {{ kind: 'Field', name: { kind: 'Name', value: 'repetitionPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'frequencyPenalty' } },{ kind: 'Field', name: { kind: 'Name', value: 'presencePenalty' } },+ { kind: 'Field', name: { kind: 'Name', value: 'minP' } },+ { kind: 'Field', name: { kind: 'Name', value: 'n' } },+ { kind: 'Field', name: { kind: 'Name', value: 'json' } },+ { kind: 'Field', name: { kind: 'Name', value: 'responseMimeType' } },{kind: 'Field',name: { kind: 'Name', value: 'reasoning' },diff --git a/frontend/src/lib/apollo.test.ts b/frontend/src/lib/apollo.test.tsindex 4e320c17..965b9e8d 100644--- a/frontend/src/lib/apollo.test.ts+++ b/frontend/src/lib/apollo.test.ts@@ -284,3 +284,52 @@ describe('streaming assistant-log link (createStreamingLink)', () => {expect(emitted).toEqual([{ somethingElse: { id: '1' } }]);});});++describe('ProviderConfig cache identity', () => {+ const PROVIDERS = gql`+ query P {+ settingsProviders {+ default {+ anthropic {+ id+ name+ type+ }+ openai {+ id+ name+ type+ }+ }+ }+ }+ `;++ // The resolver builds default providers without an ID, so every one of them arrives as id 0.+ // Normalising on that shared id would collapse them onto a single cache entry and the last+ // write would win — the create form then seeds one provider type from another's defaults.+ it('keeps two defaults apart even though both carry id 0', () => {+ const cache = createCache();++ cache.writeQuery({+ data: {+ settingsProviders: {+ __typename: 'ProvidersConfig',+ default: {+ __typename: 'DefaultProvidersConfig',+ anthropic: { __typename: 'ProviderConfig', id: 0, name: 'anthropic', type: 'anthropic' },+ openai: { __typename: 'ProviderConfig', id: 0, name: 'openai', type: 'openai' },+ },+ },+ },+ query: PROVIDERS,+ });++ const read = cache.readQuery<{+ settingsProviders: { default: { anthropic: { name: string }; openai: { name: string } } };+ }>({ query: PROVIDERS });++ expect(read?.settingsProviders.default.anthropic.name).toBe('anthropic');+ expect(read?.settingsProviders.default.openai.name).toBe('openai');+ });+});diff --git a/frontend/src/lib/errors.test.ts b/frontend/src/lib/errors.test.tsnew file mode 100644index 00000000..34d7d8f8--- /dev/null+++ b/frontend/src/lib/errors.test.ts@@ -0,0 +1,27 @@+import { describe, expect, it } from 'vitest';++import { isNotFoundError } from './errors';++describe('isNotFoundError', () => {+ it.each(['no rows in result set', 'flow not found', 'template not found: sql: no rows', 'Record Not Found'])(+ 'treats %j as not-found',+ (message) => {+ expect(isNotFoundError(new Error(message))).toBe(true);+ },+ );++ // The authz strings are real backend messages that also contain "not found" (see errors.ts) —+ // they must stay classified as real failures, so do not drop them as odd-looking fixtures.+ it.each([+ 'network error',+ 'Failed to fetch',+ 'connection refused',+ 'internal server error',+ "requested permission 'flows.read' not found",+ 'not authorized to access this token',+ 'no permissions granted',+ 'privileges are not set',+ ])('treats %j as a real failure', (message) => {+ expect(isNotFoundError(new Error(message))).toBe(false);+ });+});diff --git a/frontend/src/lib/errors.ts b/frontend/src/lib/errors.tsnew file mode 100644index 00000000..8eda68d8--- /dev/null+++ b/frontend/src/lib/errors.ts@@ -0,0 +1,16 @@+/**+ * A backend "no rows in result set" / "not found" GraphQL error, as opposed to a real load+ * failure (network, 5xx, cold-cache backend error). Detail pages redirect to the list on the+ * former and render an in-page ErrorState + Retry on the latter — collapsing the two silently+ * bounces the user off a page that a retry would have loaded.+ */+export const isNotFoundError = (error: { message: string }) => {+ // The backend's authz failure "requested permission '<perm>' not found" (graph/context.go) also+ // contains "not found"; classing it as a missing record would silently redirect a user who only+ // lacks access, instead of surfacing the denial.+ if (/\b(permission|privilege|unauthori[sz]ed|not authori[sz]ed|forbidden|access denied)\b/i.test(error.message)) {+ return false;+ }++ return /no rows in result set|not found/i.test(error.message);+};diff --git a/frontend/src/components/shared/detail-navigation/text-filter.test.ts b/frontend/src/lib/text-filter.test.tssimilarity index 100%rename from frontend/src/components/shared/detail-navigation/text-filter.test.tsrename to frontend/src/lib/text-filter.test.tsdiff --git a/frontend/src/components/shared/detail-navigation/text-filter.ts b/frontend/src/lib/text-filter.tssimilarity index 87%rename from frontend/src/components/shared/detail-navigation/text-filter.tsrename to frontend/src/lib/text-filter.tsindex b3344d67..0a032ce5 100644--- a/frontend/src/components/shared/detail-navigation/text-filter.ts+++ b/frontend/src/lib/text-filter.ts@@ -21,10 +21,10 @@ export const normalizeForFilter = (text: string): string =>* allocation instead of N.** The matcher uses substring matching semantics, with case + diacritic- * folding (`café` matches `cafe`). It is intentionally close to TanStack- * Table's default `'includesString'` so a single instance can drive both- * the list page's column filter and the detail page's Prev/Next subset- * without the two paths drifting out of sync.+ * folding (`café` matches `cafe`). It backs both the DataTable global+ * filter and detail-navigation's Prev/Next subset — the same `?q=` drives+ * both, so a semantics change here shifts what matches on every list page+ * and its detail pager at once.** - Empty query → every row passes (matcher returns `true`).* - `text === null | undefined` with a non-empty query → no match.diff --git a/frontend/src/lib/upload-validation.test.ts b/frontend/src/lib/upload-validation.test.tsindex eef25c12..deb849e7 100644--- a/frontend/src/lib/upload-validation.test.ts+++ b/frontend/src/lib/upload-validation.test.ts@@ -34,6 +34,48 @@ describe('validateUploadBatch', () => {expect(validateUploadBatch(files, DEFAULT_LIMITS)).toBeNull();});+ // Every rule below is also exercised one unit UNDER its cap: a limit tested only from the+ // rejecting side cannot tell an off-by-one from a correct boundary.+ it('accepts a batch sitting exactly on every cap', () => {+ const limits = { maxFiles: 3, maxFileSizeMb: 10, maxTotalSizeMb: 30 };+ const files = Array.from({ length: 3 }, (_, i) => makeFile(`f-${i}.bin`, 10 * MB));++ expect(validateUploadBatch(files, limits)).toBeNull();+ });++ it('rejects one file past the per-file cap and accepts the file exactly on it', () => {+ expect(validateUploadBatch([makeFile('at.bin', 300 * MB)], DEFAULT_LIMITS)).toBeNull();+ expect(validateUploadBatch([makeFile('over.bin', 300 * MB + 1)], DEFAULT_LIMITS)).toBe(+ 'File "over.bin" is larger than 300 MB',+ );+ });++ it('rejects one file past the count cap and accepts the batch exactly on it', () => {+ const limits = { ...DEFAULT_LIMITS, maxFiles: 4 };++ expect(+ validateUploadBatch(+ Array.from({ length: 4 }, (_, i) => makeFile(`f-${i}.txt`, 1)),+ limits,+ ),+ ).toBeNull();+ expect(+ validateUploadBatch(+ Array.from({ length: 5 }, (_, i) => makeFile(`f-${i}.txt`, 1)),+ limits,+ ),+ ).toBe('Too many files: max 4 per upload');+ });++ it('rejects one byte past the total cap and accepts the batch exactly on it', () => {+ const limits = { ...DEFAULT_LIMITS, maxTotalSizeMb: 20 };++ expect(validateUploadBatch([makeFile('a.bin', 10 * MB), makeFile('b.bin', 10 * MB)], limits)).toBeNull();+ expect(validateUploadBatch([makeFile('a.bin', 10 * MB), makeFile('b.bin', 10 * MB + 1)], limits)).toBe(+ 'Total upload size exceeds the 20 MB limit',+ );+ });+it('rejects batches exceeding the file count cap', () => {const files = Array.from({ length: 5 }, (_, i) => makeFile(`f-${i}.txt`, 1));@@ -55,16 +97,16 @@ describe('validateUploadBatch', () => {);});- it('rejects 0-byte files by default', () => {- const files = [makeFile('ok.txt', 1 * MB), makeFile('empty.txt', 0)];+ it('accepts 0-byte files alongside other files', () => {+ const files = [makeFile('ok.txt', 1 * MB), makeFile('.gitkeep', 0)];- expect(validateUploadBatch(files, DEFAULT_LIMITS)).toBe('File "empty.txt" is empty');+ expect(validateUploadBatch(files, DEFAULT_LIMITS)).toBeNull();});- it('lets 0-byte files through when rejectEmpty is disabled', () => {- const files = [makeFile('ok.txt', 1 * MB), makeFile('empty.txt', 0)];+ it('accepts a batch made only of 0-byte files', () => {+ const files = [makeFile('.gitkeep', 0), makeFile('__init__.py', 0)];- expect(validateUploadBatch(files, { ...DEFAULT_LIMITS, rejectEmpty: false })).toBeNull();+ expect(validateUploadBatch(files, DEFAULT_LIMITS)).toBeNull();});it('reports the first violation when multiple rules would fail', () => {diff --git a/frontend/src/lib/upload-validation.ts b/frontend/src/lib/upload-validation.tsindex 1fcbc568..dcd690dd 100644--- a/frontend/src/lib/upload-validation.ts+++ b/frontend/src/lib/upload-validation.ts@@ -6,20 +6,14 @@* Mirrors the per-file / per-batch limits enforced by the backend* (`pkg/resources/resources.go` for the resources library and* `pkg/flowfiles/files.go` for the flow files cache). Both backends do not- * whitelist file extensions, so neither does this validator — it only checks- * size, count and emptiness.+ * whitelist file extensions and both accept 0-byte files, so neither does this+ * validator — it only checks size and count.*/export interface UploadValidationLimits {maxFiles: number;maxFileSizeMb: number;maxTotalSizeMb: number;- /**- * Reject 0-byte files. Defaults to `true` because both servers stream the- * upload body and surface a confusing `EOF on read` error mid-request when- * an empty file lands in the multipart payload.- */- rejectEmpty?: boolean;}const MEGABYTE = 1024 * 1024;@@ -40,14 +34,9 @@ export const validateUploadBatch = (files: readonly File[], limits: UploadValidaconst maxBytesPerFile = limits.maxFileSizeMb * MEGABYTE;const maxTotalBytes = limits.maxTotalSizeMb * MEGABYTE;- const rejectEmpty = limits.rejectEmpty ?? true;let totalBytes = 0;for (const file of files) {- if (rejectEmpty && file.size === 0) {- return `File "${file.name}" is empty`;- }-if (file.size > maxBytesPerFile) {return `File "${file.name}" is larger than ${limits.maxFileSizeMb} MB`;}diff --git a/frontend/src/pages/flows/flow-report.test.tsx b/frontend/src/pages/flows/flow-report.test.tsxnew file mode 100644index 00000000..4c257f3a--- /dev/null+++ b/frontend/src/pages/flows/flow-report.test.tsx@@ -0,0 +1,51 @@+import { render, screen } from '@testing-library/react';+import { describe, expect, it, vi } from 'vitest';++const queryResult = vi.hoisted(() => ({+ current: { data: undefined, error: undefined, loading: false } as Record<string, unknown>,+}));++vi.mock('@apollo/client/react', () => ({+ skipToken: Symbol('skipToken'),+ useQuery: () => queryResult.current,+}));++vi.mock('react-router-dom', () => ({+ useParams: () => ({ flowId: '42' }),+ useSearchParams: () => [new URLSearchParams()],+}));++vi.mock('@/components/shared/markdown', () => ({+ default: ({ children }: { children: string }) => <div data-testid="markdown">{children}</div>,+}));++vi.mock('@/lib/report', () => ({+ generateFileName: () => 'report',+ generatePDFFromMarkdown: vi.fn().mockResolvedValue(undefined),+ generateReport: (tasks: unknown[], flow: { title: string }) => `${flow.title}: ${tasks.length} tasks`,+}));++const { default: FlowReport } = await import('./flow-report');++describe('FlowReport load states', () => {+ it('renders the report when a partial error arrives alongside a usable flow', () => {+ queryResult.current = {+ data: { flow: { id: '42', title: 'Recon' }, tasks: null },+ error: new Error('failed to fetch tasks'),+ loading: false,+ };++ render(<FlowReport />);++ expect(screen.getByTestId('markdown')).toHaveTextContent('Recon: 0 tasks');+ expect(screen.queryByText('Failed to load flow data')).not.toBeInTheDocument();+ });++ it('reports a failure when the flow itself is missing', () => {+ queryResult.current = { data: { flow: null, tasks: null }, error: new Error('boom'), loading: false };++ render(<FlowReport />);++ expect(screen.getByText('Failed to load flow data')).toBeInTheDocument();+ });+});diff --git a/frontend/src/pages/flows/flow-report.tsx b/frontend/src/pages/flows/flow-report.tsxindex a375fb59..97ed0208 100644--- a/frontend/src/pages/flows/flow-report.tsx+++ b/frontend/src/pages/flows/flow-report.tsx@@ -29,13 +29,13 @@ function FlowReport() {setPdfError(null);}- const {- data,- error: queryError,- loading,- } = useQuery(FlowReportDocument, flowId ? { errorPolicy: 'all', variables: { id: flowId } } : skipToken);+ const { data, loading } = useQuery(+ FlowReportDocument,+ flowId ? { errorPolicy: 'all', variables: { id: flowId } } : skipToken,+ );- const dataReady = !loading && !queryError && !!data?.flow;+ // Under `errorPolicy:'all'` a partial error arrives alongside a flow that loaded fine.+ const dataReady = !loading && !!data?.flow;const reportContent = useMemo(() => (dataReady ? generateReport(data.tasks || [], data.flow!) : ''),@@ -53,7 +53,8 @@ function FlowReport() {pdfTriggered.current = true;- const fileName = `${generateFileName(data.flow)}.pdf`;+ // The generator appends the extension itself.+ const fileName = generateFileName(data.flow);generatePDFFromMarkdown(reportContent, fileName).then(() => {@@ -75,7 +76,7 @@ function FlowReport() {if (loading) {state = 'loading';- } else if (queryError || !data?.flow) {+ } else if (!data?.flow) {state = 'error';errorMessage = 'Failed to load flow data';} else if (pdfPhase === 'error') {diff --git a/frontend/src/pages/flows/flow.tsx b/frontend/src/pages/flows/flow.tsxindex 5996a649..52fb758f 100644--- a/frontend/src/pages/flows/flow.tsx+++ b/frontend/src/pages/flows/flow.tsx@@ -86,10 +86,6 @@ function Flow() {const flow = flowData?.flow;const actualFlowTitle = flow?.title ?? '';- // Surface an optimistic title while the rename mutation is in flight so the- // breadcrumb, document title and edit affordance flip immediately on Save.- // If the mutation rejects, React rolls back to `actualFlowTitle` on its own- // and we surface the toast below — no manual reconciliation needed.const [flowTitle, setOptimisticFlowTitle] = useOptimistic(actualFlowTitle, (_current, next: string) => next);const isFlowRunning = flow ? ![StatusType.Failed, StatusType.Finished].includes(flow.status) : false;@@ -121,12 +117,6 @@ function Flow() {return;}- // Drop the new title into the optimistic state immediately so the- // breadcrumb and document title flip before the network round-trip. The- // optimistic value lives only inside this transition — once the- // mutation settles, useOptimistic falls back to the Apollo cache- // (which the mutation response has already updated on success, or- // left untouched on error).startTransition(async () => {setOptimisticFlowTitle(newTitle);@@ -277,6 +267,14 @@ function Flow() {</AppHeaderContent><AppHeaderActions>{!!(flowData?.tasks ?? [])?.length && <FlowReportDropdown />}+ {!isMobile && (+ <DetailNavigationToolbar<FlowItem>+ controller={flowNav}+ renderItem={renderFlowItem}+ sheetIcon={<GitFork className="size-4" />}+ sheetTitle="Flows"+ />+ )}{flowId && !isMobile && (<Buttonaria-label="Toggle favorite"@@ -290,14 +288,6 @@ function Flow() {<Star className={isFavoriteFlow(flowId) ? 'fill-yellow-500 stroke-yellow-500' : ''} /></Button>)}- {!isMobile && (- <DetailNavigationToolbar<FlowItem>- controller={flowNav}- renderItem={renderFlowItem}- sheetIcon={<GitFork className="size-4" />}- sheetTitle="Flows"- />- )}<DropdownMenu><DropdownMenuTrigger asChild><Buttondiff --git a/frontend/src/pages/knowledges/knowledge.test.tsx b/frontend/src/pages/knowledges/knowledge.test.tsxnew file mode 100644index 00000000..30bc34d8--- /dev/null+++ b/frontend/src/pages/knowledges/knowledge.test.tsx@@ -0,0 +1,78 @@+import { render, screen } from '@testing-library/react';+import { beforeEach, describe, expect, it, vi } from 'vitest';++import { routes } from '@/lib/routes';++const { navigate } = vi.hoisted(() => ({ navigate: vi.fn() }));+const { toastError } = vi.hoisted(() => ({ toastError: vi.fn() }));+const queryResult = vi.hoisted(() => ({+ current: { data: undefined, error: undefined, loading: false, refetch: vi.fn() } as Record<string, unknown>,+}));++vi.mock('@apollo/client/react', () => ({+ skipToken: Symbol('skipToken'),+ useQuery: () => queryResult.current,+}));++vi.mock('react-router-dom', () => ({+ useNavigate: () => navigate,+ useParams: () => ({ knowledgeId: '7' }),+}));++vi.mock('sonner', () => ({ toast: { error: toastError } }));++vi.mock('@/providers/knowledges-provider', () => ({+ useKnowledges: () => ({ createKnowledge: vi.fn(), updateKnowledge: vi.fn() }),+}));++// The layout shell and the form drag in the header/editor tree; the branching under test sits+// above them in Knowledge itself, so stub them to a marker.+vi.mock('@/features/knowledges/knowledge-layout', () => ({+ KnowledgeLayout: ({ children }: { children: React.ReactNode }) => <div data-testid="layout">{children}</div>,+}));+vi.mock('@/features/knowledges/knowledge-form', async (importOriginal) => ({+ ...(await importOriginal<Record<string, unknown>>()),+ KnowledgeForm: () => <div data-testid="form" />,+}));++const { default: Knowledge } = await import('./knowledge');++describe('Knowledge detail load states', () => {+ beforeEach(() => {+ navigate.mockClear();+ toastError.mockClear();+ });++ it('renders an in-page error with Retry on a real load failure, without redirecting', () => {+ queryResult.current = { data: undefined, error: new Error('network down'), loading: false, refetch: vi.fn() };++ render(<Knowledge />);++ expect(screen.getByText('Error loading knowledge document')).toBeInTheDocument();+ expect(screen.getByRole('button', { name: /Try again/ })).toBeInTheDocument();+ expect(navigate).not.toHaveBeenCalled();+ });++ it('redirects to the list on a genuine not-found error', () => {+ queryResult.current = {+ data: undefined,+ error: new Error('no rows in result set'),+ loading: false,+ refetch: vi.fn(),+ };++ render(<Knowledge />);++ expect(screen.queryByText('Error loading knowledge document')).not.toBeInTheDocument();+ expect(toastError).toHaveBeenCalled();+ expect(navigate).toHaveBeenCalledWith(routes.knowledges, { replace: true });+ });++ it('redirects to the list when the query resolves with no document', () => {+ queryResult.current = { data: { knowledgeDocument: null }, error: undefined, loading: false, refetch: vi.fn() };++ render(<Knowledge />);++ expect(navigate).toHaveBeenCalledWith(routes.knowledges, { replace: true });+ });+});diff --git a/frontend/src/pages/knowledges/knowledge.tsx b/frontend/src/pages/knowledges/knowledge.tsxindex 672015dc..01a2d7a2 100644--- a/frontend/src/pages/knowledges/knowledge.tsx+++ b/frontend/src/pages/knowledges/knowledge.tsx@@ -3,6 +3,7 @@ import { useCallback, useEffect, useMemo } from 'react';import { useNavigate, useParams } from 'react-router-dom';import { toast } from 'sonner';+import { ErrorState } from '@/components/shared/error-state';import { Spinner } from '@/components/ui/spinner';import {type DirtyFlags,@@ -16,6 +17,7 @@ import {} from '@/features/knowledges/knowledge-form';import { KnowledgeLayout } from '@/features/knowledges/knowledge-layout';import { KnowledgeDocumentDocument } from '@/graphql/types';+import { isNotFoundError } from '@/lib/errors';import { routes } from '@/lib/routes';import { useKnowledges } from '@/providers/knowledges-provider';@@ -27,19 +29,33 @@ function Knowledge() {const isNew = knowledgeId === 'new';const shouldFetch = Boolean(knowledgeId) && !isNew;- const { data, loading: isLoadingKnowledge } = useQuery(+ const {+ data,+ error,+ loading: isLoadingKnowledge,+ refetch,+ } = useQuery(KnowledgeDocumentDocument,shouldFetch && knowledgeId ? { variables: { id: knowledgeId } } : skipToken,);const knowledge = data?.knowledgeDocument ?? null;+ // A real load failure that left nothing to show, as opposed to a genuine not-found: the page+ // renders it as an in-page ErrorState + Retry instead of bouncing to the list. Mirrors flow.+ const loadError = error && !knowledge && !isNotFoundError(error) ? error : undefined;useEffect(() => {- if (!isNew && !isLoadingKnowledge && !knowledge) {+ // Redirect only when the document is genuinely gone (query settled with no document, or a+ // not-found error) — never on a transient load failure, which Retry can recover.+ if (isNew || isLoadingKnowledge || loadError) {+ return;+ }++ if (!knowledge) {toast.error('Knowledge document not found');navigate(routes.knowledges, { replace: true });}- }, [isNew, isLoadingKnowledge, knowledge, navigate]);+ }, [isNew, isLoadingKnowledge, knowledge, loadError, navigate]);const initialValues = useMemo<FormValues>(() => (knowledge ? documentToFormValues(knowledge) : newDocumentDefaults),@@ -73,6 +89,23 @@ function Knowledge() {[createKnowledge, isNew, knowledgeId, updateKnowledge],);+ if (loadError) {+ return (+ <KnowledgeLayout+ isNew={false}+ knowledge={null}+ >+ <div className="flex flex-1 flex-col gap-4 p-4">+ <ErrorState+ message={loadError.message}+ onRetry={() => refetch()}+ title="Error loading knowledge document"+ />+ </div>+ </KnowledgeLayout>+ );+ }+if (!isNew && !knowledge) {return (<KnowledgeLayoutdiff --git a/frontend/src/pages/resources/resources.tsx b/frontend/src/pages/resources/resources.tsxindex 1e407337..7f0cc957 100644--- a/frontend/src/pages/resources/resources.tsx+++ b/frontend/src/pages/resources/resources.tsx@@ -469,7 +469,7 @@ function Resources() {{isDragging && hasResources && (<div className="bg-primary/10 border-primary pointer-events-none absolute inset-2 z-30 flex items-center justify-center rounded-lg border-2 border-dashed">- <div className="text-primary flex flex-col items-center gap-2">+ <div className="text-link flex flex-col items-center gap-2"><FolderUp className="size-8" /><span className="text-sm font-medium">Drop files to upload</span></div>@@ -489,6 +489,7 @@ function Resources() {{search.rawQuery ? (<InputGroupAddon align="inline-end"><InputGroupButton+ aria-label="Clear resource search"onClick={search.resetSearch}type="button">diff --git a/frontend/src/pages/settings/settings-api-tokens.tsx b/frontend/src/pages/settings/settings-api-tokens.tsxindex caf87bf9..680a293d 100644--- a/frontend/src/pages/settings/settings-api-tokens.tsx+++ b/frontend/src/pages/settings/settings-api-tokens.tsx@@ -854,7 +854,7 @@ function SettingsAPITokens() {</AppHeader>);- if (isLoading) {+ if (isLoading && !data) {return (<>{pageHeader}diff --git a/frontend/src/pages/settings/settings-prompt.tsx b/frontend/src/pages/settings/settings-prompt.tsxindex d67f7bf8..a50a9b9b 100644--- a/frontend/src/pages/settings/settings-prompt.tsx+++ b/frontend/src/pages/settings/settings-prompt.tsx@@ -44,7 +44,6 @@ import {variableUseRegex,} from '@/components/shared/markdown-editor';-type AgentPrompt = AgentPrompts;type AgentPrompts = { human?: DefaultPrompt; system: DefaultPrompt };import {@@ -285,8 +284,22 @@ function FormMarkdownItem<T extends FieldValues>({);}+// Same class as templates: one element serves every `/settings/prompts/:promptId`, so a POP across prompt+// URLs kept the previous prompt's dirty template — and the previous `activeTab`, which on a tool prompt renders+// no TabsContent and left the header Save submitting a form id that no longer exists. A key per prompt gives+// both a fresh start.function SettingsPrompt() {const { promptId } = useParams<{ promptId: string }>();++ return (+ <SettingsPromptEditor+ key={promptId ?? 'new'}+ promptId={promptId}+ />+ );+}++function SettingsPromptEditor({ promptId }: { promptId?: string }) {const { isDesktop } = useBreakpoint();const { data, error, loading, refetch } = useQuery(SettingsPromptsDocument);@@ -364,7 +377,7 @@ function SettingsPrompt() {if (activeTab === 'system') {if (promptInfo.type === 'agent') {- const agentData = promptInfo.data as AgentPrompt | AgentPrompts;+ const agentData = promptInfo.data as AgentPrompts;promptType = agentData.system.type;} else {const toolData = promptInfo.data as DefaultPrompt;@@ -429,7 +442,7 @@ function SettingsPrompt() {const { agents, tools } = defaultPrompts;- const agentData = agents?.[promptId as keyof typeof agents] as AgentPrompt | AgentPrompts | undefined;+ const agentData = agents?.[promptId as keyof typeof agents] as AgentPrompts | undefined;if (agentData) {const userSystemPrompt = userDefined?.find((p) => p.type === agentData.system.type);@@ -481,7 +494,7 @@ function SettingsPrompt() {if (activeTab === 'system') {variables =promptInfo.type === 'agent'- ? (promptInfo.data as AgentPrompt | AgentPrompts)?.system?.variables || []+ ? (promptInfo.data as AgentPrompts)?.system?.variables || []: (promptInfo.data as DefaultPrompt)?.variables || [];} else if (activeTab === 'human' && promptInfo.type === 'agent' && promptInfo.hasHuman) {variables = (promptInfo.data as AgentPrompts)?.human?.variables || [];@@ -529,7 +542,7 @@ function SettingsPrompt() {let promptType: PromptType;if (promptInfo.type === 'agent') {- const agentData = promptInfo.data as AgentPrompt | AgentPrompts;+ const agentData = promptInfo.data as AgentPrompts;promptType = agentData.system.type;} else {const toolData = promptInfo.data as DefaultPrompt;@@ -727,7 +740,7 @@ function SettingsPrompt() {</AppHeader>);- if (loading) {+ if (loading && !data) {return (<>{pageHeader}@@ -741,7 +754,7 @@ function SettingsPrompt() {);}- if (error) {+ if (error && !data) {return (<>{pageHeader}diff --git a/frontend/src/pages/settings/settings-prompts.tsx b/frontend/src/pages/settings/settings-prompts.tsxindex 5a6002bb..e5e51977 100644--- a/frontend/src/pages/settings/settings-prompts.tsx+++ b/frontend/src/pages/settings/settings-prompts.tsx@@ -21,7 +21,6 @@ import { toast } from 'sonner';import type { DefaultPromptFragmentFragment as DefaultPrompt, PromptType } from '@/graphql/types';-type AgentPrompt = AgentPrompts;type AgentPrompts = { human?: DefaultPrompt; system: DefaultPrompt };import { AppHeader, AppHeaderContent, AppHeaderTitle } from '@/components/layouts/app/app-header';@@ -45,6 +44,8 @@ import { DeletePromptDocument, SettingsPromptsDocument } from '@/graphql/types';import { usePageStorageKeys } from '@/hooks/use-page-storage-keys';import { routes } from '@/lib/routes';+const formatName = (key: string): string => key.replaceAll(/([A-Z])/g, ' $1').replace(/^./, (str) => str.toUpperCase());+type AgentPromptTableData = {displayName: string;hasHuman: boolean;@@ -233,11 +234,8 @@ function SettingsPrompts() {case 'system': {return systemType ? userDefined.some((p) => p.type === systemType) : false;}- // No default}}-- return false;};const getAgentPromptsData = (): AgentPromptTableData[] => {@@ -249,16 +247,12 @@ function SettingsPrompts() {const userDefined = data.settingsPrompts.userDefined || [];const agentEntries: AgentPromptTableData[] = [];- const formatName = (key: string): string => {- return key.replaceAll(/([A-Z])/g, ' $1').replace(/^./, (str) => str.toUpperCase());- };-Object.entries(agents).forEach(([key, prompts]) => {if (key === '__typename') {return;}- const systemType = (prompts as AgentPrompt | AgentPrompts)?.system?.type;+ const systemType = (prompts as AgentPrompts)?.system?.type;const humanType = (prompts as AgentPrompts)?.human?.type;const hasCustomSystem = userDefined.some((p) => p.type === systemType);@@ -267,17 +261,13 @@ function SettingsPrompts() {const agentData: AgentPromptTableData = {displayName: formatName(key),hasHuman: !!(prompts as AgentPrompts)?.human,- hasSystem: !!(prompts as AgentPrompt | AgentPrompts)?.system,+ hasSystem: !!(prompts as AgentPrompts)?.system,humanStatus: (prompts as AgentPrompts)?.human ? (hasCustomHuman ? 'Custom' : 'Default') : 'N/A',humanTemplate: (prompts as AgentPrompts)?.human?.template,humanType,name: key,- systemStatus: (prompts as AgentPrompt | AgentPrompts)?.system- ? hasCustomSystem- ? 'Custom'- : 'Default'- : 'N/A',- systemTemplate: (prompts as AgentPrompt | AgentPrompts)?.system?.template || '',+ systemStatus: (prompts as AgentPrompts)?.system ? (hasCustomSystem ? 'Custom' : 'Default') : 'N/A',+ systemTemplate: (prompts as AgentPrompts)?.system?.template || '',systemType,};@@ -296,10 +286,6 @@ function SettingsPrompts() {const userDefined = data.settingsPrompts.userDefined || [];const toolEntries: ToolPromptTableData[] = [];- const formatName = (key: string): string => {- return key.replaceAll(/([A-Z])/g, ' $1').replace(/^./, (str) => str.toUpperCase());- };-Object.entries(tools).forEach(([key, prompt]) => {if (key === '__typename') {return;@@ -336,7 +322,7 @@ function SettingsPrompts() {return (<Button- className="text-muted-foreground hover:text-primary flex items-center gap-2 p-0 no-underline hover:no-underline"+ className="text-muted-foreground hover:text-link flex items-center gap-2 p-0 no-underline hover:no-underline"onClick={() => handleColumnSort(column)}variant="link">@@ -512,7 +498,7 @@ function SettingsPrompts() {return (<Button- className="text-muted-foreground hover:text-primary flex items-center gap-2 p-0 hover:no-underline"+ className="text-muted-foreground hover:text-link flex items-center gap-2 p-0 hover:no-underline"onClick={() => handleColumnSort(column)}variant="link">@@ -792,7 +778,7 @@ function SettingsPrompts() {</AppHeader>);- if (isLoading) {+ if (isLoading && !data) {return (<>{pageHeader}diff --git a/frontend/src/pages/settings/settings-provider.test.tsx b/frontend/src/pages/settings/settings-provider.test.tsxindex 5688c160..7ad1938d 100644--- a/frontend/src/pages/settings/settings-provider.test.tsx+++ b/frontend/src/pages/settings/settings-provider.test.tsx@@ -1,12 +1,13 @@-import { render } from '@testing-library/react';+import { fireEvent, render, screen, waitFor } from '@testing-library/react';+import { toast } from 'sonner';import { beforeEach, describe, expect, it, vi } from 'vitest';import { ProviderType } from '@/graphql/types';import { routes } from '@/lib/routes';-const { navigate } = vi.hoisted(() => ({ navigate: vi.fn() }));+const { mutate, navigate } = vi.hoisted(() => ({ mutate: vi.fn(), navigate: vi.fn() }));-const state = vi.hoisted(() => ({ params: new URLSearchParams() }));+const state = vi.hoisted(() => ({ params: new URLSearchParams(), providerId: 'new' }));const setSearch = (search: string) => {state.params = new URLSearchParams(search);@@ -26,8 +27,6 @@ const enabled = {qwen: true,};-const emptyProvider = { agents: {} };-const userDefined = [{agents: {},@@ -37,25 +36,43 @@ const userDefined = [type: ProviderType.Minimax,updatedAt: '',},+ {+ agents: {},+ createdAt: '',+ id: 'edit-1',+ name: 'Persisted Name',+ type: ProviderType.Anthropic,+ updatedAt: '',+ },];+// The create form seeds agents from the type's defaults, and bails when the type has no models —+// so a fixture with an empty catalogue would make the seeding tests vacuously green.+const agentDefaults = (model: string, temperature: number) => ({+ simple: { maxTokens: 1000, model, temperature },+});+const settingsProviders = {default: {- anthropic: emptyProvider,- openai: emptyProvider,+ anthropic: { agents: agentDefaults('claude-e2e', 0.2) },+ openai: { agents: agentDefaults('gpt-e2e', 0.7) },},enabled,- models: { anthropic: [], minimax: [], openai: [] },+ models: {+ anthropic: [{ name: 'claude-e2e' }],+ minimax: [],+ openai: [{ name: 'gpt-e2e' }],+ },userDefined,};// A stable `data` identity matters: the page's seeding effect lists `data` as a// dependency, so a fresh object each render would loop it (Apollo returns a// cached reference in production).-const queryResult = { data: { settingsProviders }, error: undefined, loading: false };+const queryResult = { data: { settingsProviders }, error: undefined as Error | undefined, loading: false };vi.mock('@apollo/client/react', () => ({- useMutation: () => [vi.fn(), {}],+ useMutation: () => [mutate, {}],useQuery: () => queryResult,}));@@ -65,7 +82,7 @@ vi.mock('react-router-dom', async (importOriginal) => ({...(await importOriginal<typeof import('react-router-dom')>()),useBlocker: () => ({ proceed: undefined, reset: undefined, state: 'unblocked' }),useNavigate: () => navigate,- useParams: () => ({ providerId: 'new' }),+ useParams: () => ({ providerId: state.providerId }),useSearchParams: () => [state.params, vi.fn()],}));@@ -77,10 +94,20 @@ vi.mock('@/hooks/use-breakpoint', () => ({// whole family so the guard effect under test renders without that scaffolding.vi.mock('@/components/layouts/app/app-header', () => {const Pass = ({ children }: { children?: React.ReactNode }) => <div>{children}</div>;+ const Action = ({+ icon: _icon,+ label,+ loading: _loading,+ ...props+ }: React.ComponentProps<'button'> & {+ icon?: React.ReactNode;+ label?: React.ReactNode;+ loading?: boolean;+ }) => <button {...props}>{label}</button>;return {AppHeader: Pass,- AppHeaderAction: Pass,+ AppHeaderAction: Action,AppHeaderActions: Pass,AppHeaderContent: Pass,AppHeaderTitle: Pass,@@ -92,8 +119,14 @@ vi.mock('sonner', () => ({ toast: { error: vi.fn(), info: vi.fn(), success: vi.fimport SettingsProvider from './settings-provider';beforeEach(() => {+ mutate.mockClear();navigate.mockClear();+ vi.mocked(toast.error).mockClear();setSearch('');+ state.providerId = 'new';+ queryResult.data = { settingsProviders };+ queryResult.error = undefined;+ queryResult.loading = false;});describe('SettingsProvider create-form type guards', () => {@@ -124,4 +157,134 @@ describe('SettingsProvider create-form type guards', () => {expect(navigate).not.toHaveBeenCalled();});++ // cache-and-network means an error can arrive with cached data still present; the form must+ // survive it rather than flip to the full-page error screen.+ it('keeps the form on a refetch error while cached data is present', () => {+ setSearch('type=anthropic');+ queryResult.error = new Error('e2e induced refetch failure');+ render(<SettingsProvider />);++ expect(screen.queryByText('Error loading provider data')).not.toBeInTheDocument();+ expect(navigate).not.toHaveBeenCalled();+ });++ // The loading branch runs before the error branch, so it needs the same guard: a background+ // refetch reports loading:true with cached data and must not blank the form to the spinner.+ it('keeps the form on a background refetch while cached data is present', () => {+ setSearch('type=anthropic');+ queryResult.loading = true;+ render(<SettingsProvider />);++ expect(screen.queryByText('Loading provider data...')).not.toBeInTheDocument();+ expect(navigate).not.toHaveBeenCalled();+ });++ const expandAgent = () => {+ if (!screen.queryByLabelText('Temperature')) {+ fireEvent.click(screen.getByRole('button', { name: /Simple/ }));+ }+ };++ const temperatureInput = () => screen.getByLabelText('Temperature') as HTMLInputElement;++ it('preserves an in-flight agent edit on the create form across a background refetch', () => {+ setSearch('type=openai');+ const { rerender } = render(<SettingsProvider />);++ expandAgent();+ expect(temperatureInput().value).toBe('0.7');++ fireEvent.change(temperatureInput(), { target: { value: '1.5' } });++ // A refetch that carries no change leaves `data` referentially equal and is inert, so the+ // payload has to actually differ for this to exercise the seeding effect.+ queryResult.data = {+ settingsProviders: { ...settingsProviders, userDefined: [...userDefined] },+ };+ rerender(<SettingsProvider />);++ expect(temperatureInput().value).toBe('1.5');+ });++ it('still re-seeds the agents when the type changes mid-edit', () => {+ setSearch('type=openai');+ const { rerender } = render(<SettingsProvider />);++ expandAgent();+ fireEvent.change(temperatureInput(), { target: { value: '1.5' } });++ setSearch('type=anthropic');+ rerender(<SettingsProvider />);+ expandAgent();++ expect(temperatureInput().value).toBe('0.2');+ });++ it('preserves an in-flight edit across a background refetch', () => {+ state.providerId = 'edit-1';+ const { rerender } = render(<SettingsProvider />);++ const nameInput = screen.getByPlaceholderText('Enter provider name') as HTMLInputElement;++ expect(nameInput.value).toBe('Persisted Name');++ fireEvent.change(nameInput, { target: { value: 'My Unsaved Edit' } });++ queryResult.data = { settingsProviders };+ rerender(<SettingsProvider />);++ expect((screen.getByPlaceholderText('Enter provider name') as HTMLInputElement).value).toBe('My Unsaved Edit');+ });+});++describe('SettingsProvider save feedback', () => {+ const toggleAgent = () => fireEvent.click(screen.getByRole('button', { name: /Simple/ }));++ const saveButton = () => screen.getByRole('button', { name: 'Create' });++ const renderCreateForm = () => {+ setSearch('type=openai');+ render(<SettingsProvider />);+ fireEvent.change(screen.getByPlaceholderText('Enter provider name'), { target: { value: 'My Provider' } });+ };++ const typeInvalidExtraBody = () => {+ toggleAgent();+ fireEvent.change(screen.getByLabelText('Extra Body (JSON)'), { target: { value: '{ nope' } });+ toggleAgent();+ };++ it('toasts an agent-level error raised inside a collapsed panel', async () => {+ renderCreateForm();+ typeInvalidExtraBody();++ expect(screen.queryByLabelText('Extra Body (JSON)')).not.toBeInTheDocument();++ fireEvent.click(saveButton());++ await waitFor(() => expect(toast.error).toHaveBeenCalledTimes(1));+ expect(toast.error).toHaveBeenCalledWith(expect.stringContaining('Must be a valid JSON object'));+ expect(mutate).not.toHaveBeenCalled();+ });++ it('toasts again when the same invalid form is submitted twice', async () => {+ renderCreateForm();+ typeInvalidExtraBody();++ fireEvent.click(saveButton());+ await waitFor(() => expect(toast.error).toHaveBeenCalledTimes(1));++ fireEvent.click(saveButton());+ await waitFor(() => expect(toast.error).toHaveBeenCalledTimes(2));+ });++ it('runs the create mutation when the form is valid', async () => {+ renderCreateForm();++ fireEvent.click(saveButton());++ await waitFor(() => expect(mutate).toHaveBeenCalledTimes(1));+ expect(toast.error).not.toHaveBeenCalled();+ });});diff --git a/frontend/src/pages/settings/settings-provider.tsx b/frontend/src/pages/settings/settings-provider.tsxindex 0cbda151..31e74ba6 100644--- a/frontend/src/pages/settings/settings-provider.tsx+++ b/frontend/src/pages/settings/settings-provider.tsx@@ -12,9 +12,10 @@ import {Trash2,XCircle,} from 'lucide-react';-import { type ComponentProps, useEffect, useMemo, useState } from 'react';+import { type ComponentProps, type FormEvent, useEffect, useMemo, useRef, useState } from 'react';import {type Control,+ type FieldErrors,type FieldPath,type FieldValues,useController,@@ -611,10 +612,13 @@ const agentConfigSchema = z.object({extraBody: optionalJsonObject,frequencyPenalty: optionalNumber,+ json: z.boolean().nullable().optional(),maxLength: optionalNumber,maxTokens: optionalNumber,minLength: optionalNumber,+ minP: optionalNumber,model: requiredString('Model is required'),+ n: optionalNumber,presencePenalty: optionalNumber,price: z.object({@@ -634,6 +638,7 @@ const agentConfigSchema = z.nullable().optional(),repetitionPenalty: optionalNumber,+ responseMimeType: z.string().nullable().optional(),temperature: optionalNumber,topK: optionalNumber,topP: optionalNumber,@@ -886,10 +891,15 @@ export const transformFormToGraphQL = (const config: AgentConfigInput = {extraBody: data?.extraBody?.trim() ? (JSON.parse(data.extraBody) as Record<string, unknown>) : null,frequencyPenalty: data?.frequencyPenalty ?? null,+ // Not user-editable: carried through so saving a provider does not strip what the+ // shipped defaults set (json drives WithJSONMode on the simple_json agent).+ json: data?.json ?? null,maxLength: data?.maxLength ?? null,maxTokens: data?.maxTokens ?? null,minLength: data?.minLength ?? null,+ minP: data?.minP ?? null,model: data?.model ?? '',+ n: data?.n ?? null,presencePenalty: data?.presencePenalty ?? null,price:data?.price &&@@ -912,6 +922,7 @@ export const transformFormToGraphQL = (}: null,repetitionPenalty: data?.repetitionPenalty ?? null,+ responseMimeType: data?.responseMimeType ?? null,temperature: data?.temperature ?? null,topK: data?.topK ?? null,topP: data?.topP ?? null,@@ -1203,12 +1214,17 @@ function SettingsProvider() {name: undefined,type: undefined,},+ // The seeding effect re-runs on every settingsProviders refetch (cache-and-network ++ // replaceWithIncoming gives a fresh `data`); without this a background refetch landing+ // mid-edit silently wipes the unsaved form.+ resetOptions: { keepDirtyValues: true },schema: formSchema,});const { control, formState, handleSubmit: handleFormSubmit, reset, setValue, trigger, watch } = form;const { isDirty } = useFormState({ control });+ const seededTypeRef = useRef<null | string>(null);useEffect(() => {if (submitError) {@@ -1279,6 +1295,17 @@ function SettingsProvider() {return;}+ // setValue is outside the form's keepDirtyValues, so a background refetch re-runs this effect+ // with a fresh `data` identity and overwrites agent edits the user has not saved. Re-seed only+ // when the type actually changed — that is the case where the previous type's agents are wrong.+ const isSameType = seededTypeRef.current === selectedType;++ seededTypeRef.current = selectedType;++ if (isSameType && form.getFieldState('agents').isDirty) {+ return;+ }+const defaultProvider =data.settingsProviders.default[selectedType as keyof typeof data.settingsProviders.default];@@ -1509,6 +1536,18 @@ function SettingsProvider() {}};+ const handleInvalidSubmit = (errors: FieldErrors<FormInput>) => {+ setSubmitError(+ `Please fix the following validation errors:\n\n${formatFormErrors(errors as Record<string, unknown>)}`,+ );+ };++ const handleFormEvent = async (event: FormEvent<HTMLFormElement>) => {+ setSubmitError(null);++ await handleFormSubmit(handleSubmit, handleInvalidSubmit)(event);+ };+const handleDelete = () => {if (isNew || !providerId) {return;@@ -1605,7 +1644,7 @@ function SettingsProvider() {}};- if (loading) {+ if (loading && !data) {return (<><AppHeader>@@ -1625,7 +1664,7 @@ function SettingsProvider() {);}- if (error) {+ if (error && !data) {return (<><AppHeader>@@ -2002,7 +2041,7 @@ function SettingsProvider() {className="flex min-h-0 flex-1 flex-col"id="provider-form"noValidate- onSubmit={handleFormSubmit(handleSubmit)}+ onSubmit={handleFormEvent}>{isDesktop ? (<DetailSplitLayoutdiff --git a/frontend/src/pages/settings/settings-providers.test.tsx b/frontend/src/pages/settings/settings-providers.test.tsxindex bd5a8a94..7d351d11 100644--- a/frontend/src/pages/settings/settings-providers.test.tsx+++ b/frontend/src/pages/settings/settings-providers.test.tsx@@ -1,20 +1,9 @@import { render, screen } from '@testing-library/react';import userEvent from '@testing-library/user-event';+import { MemoryRouter } from 'react-router-dom';import { beforeEach, describe, expect, it, vi } from 'vitest';-const state = vi.hoisted(() => ({ enabled: {} as Record<string, boolean> | undefined }));--vi.mock('@apollo/client/react', () => ({- useMutation: () => [vi.fn(), {}],- useQuery: () => ({ data: { settingsProviders: { enabled: state.enabled } } }),-}));--vi.mock('react-router-dom', async (importOriginal) => ({- ...(await importOriginal<typeof import('react-router-dom')>()),- useNavigate: () => vi.fn(),-}));--import { SettingsProvidersHeader } from './settings-providers';+import { ProviderType } from '@/graphql/types';const ALL_TYPES = ['anthropic',@@ -30,11 +19,57 @@ const ALL_TYPES = ['qwen',];-beforeEach(() => {- state.enabled = Object.fromEntries(ALL_TYPES.map((type) => [type, type !== 'minimax' && type !== 'custom']));+const emptyProvider = { agents: {} };++const makeData = (userDefined: unknown[]) => ({+ settingsProviders: {+ default: { anthropic: emptyProvider, openai: emptyProvider },+ enabled: Object.fromEntries(ALL_TYPES.map((type) => [type, type !== 'minimax' && type !== 'custom'])),+ models: {},+ userDefined,+ },+});++const queryResult = vi.hoisted(() => ({+ current: { data: undefined, error: undefined, loading: false, refetch: () => {} } as Record<string, unknown>,+}));++vi.mock('@apollo/client/react', () => ({+ useMutation: () => [vi.fn(), {}],+ useQuery: () => queryResult.current,+}));++vi.mock('react-router-dom', async (importOriginal) => ({+ ...(await importOriginal<typeof import('react-router-dom')>()),+ useNavigate: () => vi.fn(),+}));++vi.mock('@/hooks/use-table-state', () => ({+ useTableState: () => ({ filter: '', pageIndex: 0, setFilter: vi.fn(), setPage: vi.fn() }),+}));++// AppHeader pulls in SidebarTrigger (needs a SidebarProvider context); stub the family so the+// list's load-state branches render without that scaffolding. SettingsProvidersHeader builds its+// own trigger from a plain Button, so this does not touch the create-menu tests.+vi.mock('@/components/layouts/app/app-header', () => {+ const Pass = ({ children }: { children?: React.ReactNode }) => <div>{children}</div>;++ return {+ AppHeader: Pass,+ AppHeaderAction: Pass,+ AppHeaderActions: Pass,+ AppHeaderContent: Pass,+ AppHeaderTitle: Pass,+ };});+import SettingsProviders, { SettingsProvidersHeader } from './settings-providers';+describe('SettingsProvidersHeader create menu', () => {+ beforeEach(() => {+ queryResult.current = { data: makeData([]), error: undefined, loading: false, refetch: () => {} };+ });+it('offers only provider types whose API key is configured', async () => {const user = userEvent.setup();render(<SettingsProvidersHeader />);@@ -48,7 +83,17 @@ describe('SettingsProvidersHeader create menu', () => {});it('shows a placeholder, not an empty menu, when no type is enabled', async () => {- state.enabled = Object.fromEntries(ALL_TYPES.map((type) => [type, false]));+ queryResult.current = {+ data: {+ settingsProviders: {+ ...makeData([]).settingsProviders,+ enabled: Object.fromEntries(ALL_TYPES.map((type) => [type, false])),+ },+ },+ error: undefined,+ loading: false,+ refetch: () => {},+ };const user = userEvent.setup();render(<SettingsProvidersHeader />);@@ -58,3 +103,31 @@ describe('SettingsProvidersHeader create menu', () => {expect(screen.queryByRole('menuitem', { name: /OpenAI/ })).not.toBeInTheDocument();});});++describe('SettingsProviders list load states', () => {+ const seeded = [+ {+ agents: {},+ createdAt: '2026-01-15T00:00:00Z',+ id: '1',+ name: 'Seeded Provider',+ type: ProviderType.Custom,+ updatedAt: '2026-01-15T00:00:00Z',+ },+ ];++ // cache-and-network flips loading true with cached rows still present; the table must survive+ // it rather than flip to the full-page spinner.+ it('keeps the populated table on a background refetch instead of flashing the loader', () => {+ queryResult.current = { data: makeData(seeded), error: undefined, loading: true, refetch: () => {} };++ render(+ <MemoryRouter>+ <SettingsProviders />+ </MemoryRouter>,+ );++ expect(screen.getByText('Seeded Provider')).toBeInTheDocument();+ expect(screen.queryByText('Loading providers...')).not.toBeInTheDocument();+ });+});diff --git a/frontend/src/pages/settings/settings-providers.tsx b/frontend/src/pages/settings/settings-providers.tsxindex cfd8766e..fe0c9181 100644--- a/frontend/src/pages/settings/settings-providers.tsx+++ b/frontend/src/pages/settings/settings-providers.tsx@@ -404,7 +404,7 @@ function SettingsProviders() {</AppHeader>);- if (isLoading) {+ if (isLoading && !data) {return (<>{pageHeader}diff --git a/frontend/src/pages/templates/template.tsx b/frontend/src/pages/templates/template.tsxindex 5f87e393..e1e5f441 100644--- a/frontend/src/pages/templates/template.tsx+++ b/frontend/src/pages/templates/template.tsx@@ -15,6 +15,7 @@ import {DetailNavigationToolbar,} from '@/components/shared/detail-navigation';import { DetailSplitLayout } from '@/components/shared/detail-split-layout';+import { ErrorState } from '@/components/shared/error-state';import { InlineEditInput, useInlineEdit } from '@/components/shared/inline-edit';import { type EditorViewMode, EditorViewModeToggle, MarkdownEditorField } from '@/components/shared/markdown-editor';import { UnsavedChangesDialog, useUnsavedChangesGuard } from '@/components/shared/unsaved-changes';@@ -39,6 +40,7 @@ import { useTemplateDetailNavigation } from '@/features/templates/use-template-dimport { FlowTemplateDocument } from '@/graphql/types';import { useAppForm } from '@/hooks/use-app-form';import { useBreakpoint } from '@/hooks/use-breakpoint';+import { isNotFoundError } from '@/lib/errors';import { routes } from '@/lib/routes';import { cn } from '@/lib/utils';import { type Template, useTemplates } from '@/providers/templates-provider';@@ -233,9 +235,23 @@ const renderTemplateItem = (item: Template, isCurrent: boolean): ReactNode => (<span className={cn('min-w-0 flex-1 truncate', isCurrent && 'font-medium')}>{item.title}</span>);+// One React element serves every `/templates/:templateId`, so without a key the form instance — which sets+// `keepDirtyValues` so a subscription resync cannot wipe an unsaved body — carried one template's edited text+// onto the next template and Save wrote it to the wrong row. Keying by id gives each entity its own form, the+// way knowledge.tsx already keys <KnowledgeForm>. It also stops `/templates/new` inheriting an abandoned draft.function Template() {- const navigate = useNavigate();const { templateId } = useParams<{ templateId?: string }>();++ return (+ <TemplateForm+ key={templateId ?? 'new'}+ templateId={templateId}+ />+ );+}++function TemplateForm({ templateId }: { templateId?: string }) {+ const navigate = useNavigate();const { createTemplate, deleteTemplate, updateTemplate } = useTemplates();const { isDesktop, isMobile } = useBreakpoint();@@ -261,10 +277,17 @@ function Template() {stopEdit: handleTemplateRenameCancel,} = useInlineEdit({ resetKey: templateId });- const { data: templateData, loading: isLoadingTemplate } = useQuery(- FlowTemplateDocument,- templateId && !isNew ? { variables: { templateId } } : skipToken,- );+ const {+ data: templateData,+ error: templateError,+ loading: isLoadingTemplate,+ refetch: refetchTemplate,+ } = useQuery(FlowTemplateDocument, templateId && !isNew ? { variables: { templateId } } : skipToken);++ const template = templateData?.flowTemplate;+ // A real load failure that left nothing to show, as opposed to a genuine not-found: the page+ // renders it as an in-page ErrorState + Retry instead of the "not found" card. Mirrors flow.+ const templateLoadError = templateError && !template && !isNotFoundError(templateError) ? templateError : undefined;// `values` re-syncs the form whenever the cache refreshes (an inline rename, a refetch), while// `keepDirtyValues` preserves the user's in-flight edits — without it an external re-emit would@@ -345,7 +368,9 @@ function Template() {await createTemplate(values.title, values.text);} else if (templateId) {await updateTemplate(templateId, { text: values.text, title: values.title });- reset(values, { keepDefaultValues: false });+ // See knowledge-form.tsx: the form-level `resetOptions` are merged into every manual+ // reset, so a post-save reset inherits `keepDirtyValues` unless it opts out.+ reset(values, { keepDefaultValues: false, keepDirtyValues: false });}return true;@@ -413,7 +438,7 @@ function Template() {}, [pendingPreset, setValue]);const hasTemplate = !!templateData?.flowTemplate;- const isTemplatePending = !isNew && (isLoadingTemplate || !hasTemplate);+ const isTemplatePending = !isNew && !hasTemplate;const isTemplateMissing = !isNew && !isLoadingTemplate && !hasTemplate;const pageHeader = (@@ -456,14 +481,6 @@ function Template() {</AppHeaderContent>{!isTemplateMissing && (<AppHeaderActions>- <AppHeaderAction- disabled={isTemplatePending || (!isNew && !hasUnsavedChanges)}- form="template-form"- icon={<Save />}- label={isNew ? 'Create' : 'Save'}- loading={isSaving}- type="submit"- />{!isNew && !isMobile && (<DetailNavigationToolbar<Template>controller={templateNav}@@ -472,6 +489,14 @@ function Template() {sheetTitle="Templates"/>)}+ <AppHeaderAction+ disabled={isTemplatePending || (!isNew && !hasUnsavedChanges)}+ form="template-form"+ icon={<Save />}+ label={isNew ? 'Create' : 'Save'}+ loading={isSaving}+ type="submit"+ /><DropdownMenu><DropdownMenuTrigger asChild><Button@@ -725,7 +750,7 @@ function Template() {/>);- if (!isNew && isLoadingTemplate) {+ if (!isNew && isLoadingTemplate && !template) {return (<div className={isDesktop ? 'flex h-[100dvh] min-h-0 flex-col' : 'flex min-h-[100dvh] flex-col'}>{pageHeader}@@ -736,7 +761,22 @@ function Template() {);}- if (!isNew && !isLoadingTemplate && !templateData?.flowTemplate) {+ if (templateLoadError) {+ return (+ <div className={isDesktop ? 'flex h-[100dvh] min-h-0 flex-col' : 'flex min-h-[100dvh] flex-col'}>+ {pageHeader}+ <div className="flex flex-1 flex-col gap-4 p-4">+ <ErrorState+ message={templateLoadError.message}+ onRetry={() => refetchTemplate()}+ title="Error loading template"+ />+ </div>+ </div>+ );+ }++ if (!isNew && !isLoadingTemplate && !template) {return (<div className={isDesktop ? 'flex h-[100dvh] min-h-0 flex-col' : 'flex min-h-[100dvh] flex-col'}>{pageHeader}diff --git a/frontend/src/providers/flow-provider.test.ts b/frontend/src/providers/flow-provider.test.tsnew file mode 100644index 00000000..7651a728--- /dev/null+++ b/frontend/src/providers/flow-provider.test.ts@@ -0,0 +1,30 @@+import { describe, expect, it } from 'vitest';++import { deriveFlowMissing } from './flow-provider';++const flow = { flow: { id: '1' } };+const notFound = new Error('flow not found');+const partialNotFound = new Error('assistant not found'); // a nested resolver under errorPolicy:'all'++describe('deriveFlowMissing', () => {+ it('is true when the query settled with the flow genuinely absent', () => {+ expect(deriveFlowMissing({ flow: null }, undefined)).toBe(true);+ });++ it('is true on a not-found error with no flow loaded', () => {+ expect(deriveFlowMissing(undefined, notFound)).toBe(true);+ });++ // Reverting the `!flowData?.flow` gate turns this red — it is the regression guard.+ it('is false when a not-found error rides alongside a loaded flow', () => {+ expect(deriveFlowMissing(flow, partialNotFound)).toBe(false);+ });++ it('is false on a real load failure (kept behind Retry, not redirected)', () => {+ expect(deriveFlowMissing(undefined, new Error('network error'))).toBe(false);+ });++ it('is false while loading (no data, no error yet)', () => {+ expect(deriveFlowMissing(undefined, undefined)).toBe(false);+ });+});diff --git a/frontend/src/providers/flow-provider.tsx b/frontend/src/providers/flow-provider.tsxindex badfa5ae..113db421 100644--- a/frontend/src/providers/flow-provider.tsx+++ b/frontend/src/providers/flow-provider.tsx@@ -34,9 +34,19 @@ import {TerminalLogAddedDocument,VectorStoreLogAddedDocument,} from '@/graphql/types';+import { isNotFoundError } from '@/lib/errors';import { Log } from '@/lib/log';-const isFlowNotFoundError = (error: Error) => /no rows in result set|not found/i.test(error.message);+/**+ * Under `errorPolicy:'all'` a partial not-found error surfaces alongside a flow that loaded fine, so+ * the not-found disjunct gates on `!flowData?.flow`. Without the gate that partial error redirects+ * the user off a flow that rendered correctly.+ */+export const deriveFlowMissing = (+ flowData: null | undefined | { flow: unknown },+ flowError: undefined | { message: string },+): boolean =>+ Boolean(flowData && !flowData.flow) || Boolean(flowError && !flowData?.flow && isNotFoundError(flowError));interface FlowContextValue {assistantLogs: Array<AssistantLogFragmentFragment>;@@ -92,9 +102,9 @@ export function FlowProvider({ children }: FlowProviderProps) {// A real load failure that left nothing to show (cold cache + backend error on a// deep link), as opposed to a genuine not-found. The detail page renders this as an// in-page ErrorState + Retry instead of silently bouncing to the list.- const flowLoadError = flowError && !flowData?.flow && !isFlowNotFoundError(flowError) ? flowError : undefined;+ const flowLoadError = flowError && !flowData?.flow && !isNotFoundError(flowError) ? flowError : undefined;- const isFlowMissing = Boolean(flowData && !flowData.flow) || Boolean(flowError && isFlowNotFoundError(flowError));+ const isFlowMissing = deriveFlowMissing(flowData, flowError);const { data: assistantsData, loading: isAssistantsLoading } = useQuery(AssistantsDocument, {fetchPolicy: 'cache-first',@@ -196,7 +206,7 @@ export function FlowProvider({ children }: FlowProviderProps) {return;}- if (isFlowNotFoundError(flowError)) {+ if (isNotFoundError(flowError)) {toast.error('Flow not found', { id: 'flow-load-error' });}diff --git a/frontend/src/styles/index.css b/frontend/src/styles/index.cssindex 18d214ae..e0716cea 100644--- a/frontend/src/styles/index.css+++ b/frontend/src/styles/index.css@@ -166,6 +166,7 @@--color-popover-foreground: var(--popover-foreground);--color-primary: var(--primary);--color-primary-foreground: var(--primary-foreground);+ --color-link: var(--link);--color-secondary: var(--secondary);--color-secondary-foreground: var(--secondary-foreground);--color-muted: var(--muted);@@ -306,6 +307,9 @@--sidebar-accent-foreground: oklch(0.32 0 0);--sidebar-border: oklch(0.93 0.01 240);--sidebar-ring: oklch(0.25 0.14 245);+ /* Link TEXT. --primary is a fill (paired with white --primary-foreground) and cannot double as+ text: on dark it measures 3.12:1 on --card, and no lightness clears AA in both roles at once. */+ --link: oklch(0.25 0.14 245);/* Editor highlight TEXT, tuned for readable contrast on the editor surface (unlike --primary, a fillcolor that fails WCAG AA as text on dark). Four distinct hues so adjacent tokens don't blur:link = theme blue 245; variable = green 155 (matches the panel's "used" badge); tag = violet 300;@@ -316,6 +320,17 @@--editor-tag: oklch(0.25 0.12 300);--editor-code: oklch(0.5 0.16 25);--editor-code-bg: oklch(0.94 0.006 245);+ /* Stock atom-one-light is NOT usable as-is: on this surface it fails AA on 6 of its 8 token colours.+ These hold its hues and chroma but lower lightness until each clears it. */+ --editor-syntax-fg: oklch(0.35 0.014 274.5);+ --editor-syntax-comment: oklch(0.52 0.009 278.6);+ --editor-syntax-keyword: oklch(0.524 0.211 328.8);+ --editor-syntax-entity: oklch(0.539 0.179 28.3);+ --editor-syntax-literal: oklch(0.511 0.126 236.7);+ --editor-syntax-string: oklch(0.503 0.142 143.5);+ --editor-syntax-attr: oklch(0.524 0.116 76.9);+ --editor-syntax-symbol: oklch(0.527 0.193 263.2);+ --editor-syntax-class: oklch(0.523 0.138 76.2);--font-sans: Inter, 'Inter Fallback', sans-serif;--font-serif: Inter, 'Inter Fallback', serif;--font-mono: 'Roboto Mono', monospace;@@ -371,11 +386,23 @@--sidebar-accent-foreground: oklch(0.92 0.02 245);--sidebar-border: oklch(0.3 0.04 245);--sidebar-ring: oklch(0.5 0.16 245);+ --link: oklch(0.68 0.13 245);--editor-accent: oklch(0.68 0.13 245);--editor-variable: oklch(0.72 0.12 155);--editor-tag: oklch(0.68 0.13 300);--editor-code: oklch(0.7 0.15 25);--editor-code-bg: oklch(0.27 0.03 245);+ /* atom-one-dark's hues, which already clear AA here — except comment and entity, tuned because+ stock measures 2.49 and 4.70. */+ --editor-syntax-fg: oklch(0.762 0.02 263);+ --editor-syntax-comment: oklch(0.688 0.019 261.3);+ --editor-syntax-keyword: oklch(0.694 0.164 318.2);+ --editor-syntax-entity: oklch(0.694 0.131 16.3);+ --editor-syntax-literal: oklch(0.723 0.092 206.3);+ --editor-syntax-string: oklch(0.768 0.11 133);+ --editor-syntax-attr: oklch(0.727 0.095 63.8);+ --editor-syntax-symbol: oklch(0.728 0.121 245.6);+ --editor-syntax-class: oklch(0.826 0.097 81.6);--font-sans: Inter, 'Inter Fallback', sans-serif;--font-serif: Inter, 'Inter Fallback', serif;--font-mono: 'Roboto Mono', monospace;@@ -563,13 +590,19 @@.prose pre code.hljs {color: inherit;background: transparent;-}--.prose pre code.hljs {padding: 0;overflow: visible;}+/* Without these the viewer falls back to Tailwind Typography's own pre colours, which are dark in BOTH+ themes (gray-800 light / `rgb(0 0 0 / 50%)` dark) and are plugin internals, not project tokens. */+.prose {+ --tw-prose-pre-bg: var(--editor-code-bg);+ --tw-prose-pre-code: var(--editor-syntax-fg);+ --tw-prose-invert-pre-bg: var(--editor-code-bg);+ --tw-prose-invert-pre-code: var(--editor-syntax-fg);+}+/* Sonner */[data-sonner-toast][data-styled='true'] {gap: 8px !important;@@ -634,7 +667,6 @@font-size: 0.875em;}-/* No background/colour here — the .hljs highlight.js theme (imported in markdown-editor.tsx) supplies them. */.tiptap-content .ProseMirror pre {position: relative;padding: 0.75rem 1rem;@@ -642,16 +674,27 @@overflow-x: auto;}+.tiptap-content .ProseMirror pre,+.prose pre {+ background: var(--editor-code-bg);+ color: var(--editor-syntax-fg);+}++.dark .tiptap-content .ProseMirror pre {+ --editor-variable: oklch(0.76 0.12 155);+ --editor-tag: oklch(0.76 0.13 300);+}+/* data-language is a DOM-only attribute (stamped by renderHTML); it never enters the serialized markdown. */.tiptap-content .ProseMirror pre[data-language]::before {content: attr(data-language);display: block;margin: -0.75rem -1rem 0.75rem;padding: 0.25rem 1rem;- border-bottom: 1px solid oklch(1 0 0 / 0.1);+ border-bottom: 1px solid color-mix(in oklab, var(--editor-syntax-fg) 14%, transparent);border-radius: calc(var(--radius) - 2px) calc(var(--radius) - 2px) 0 0;- background-color: oklch(1 0 0 / 0.05);- color: oklch(1 0 0 / 0.55);+ background-color: color-mix(in oklab, var(--editor-syntax-fg) 7%, transparent);+ color: color-mix(in oklab, var(--editor-syntax-fg) 85%, transparent);font-family: var(--font-mono);font-size: 0.7rem;letter-spacing: 0.05em;@@ -664,6 +707,74 @@font-size: 0.875em;}+/* Do not go back to importing a highlight.js stylesheet: a side-effect CSS import cannot be scoped to a+ theme, so the fence could not follow light/dark at all. Groups mirror atom-one's. */+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-comment,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-quote {+ color: var(--editor-syntax-comment);+ font-style: italic;+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-doctag,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-keyword,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-formula {+ color: var(--editor-syntax-keyword);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-section,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-name,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-selector-tag,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-deletion,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-subst {+ color: var(--editor-syntax-entity);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-literal {+ color: var(--editor-syntax-literal);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-string,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-regexp,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-addition,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-attribute,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-meta .hljs-string {+ color: var(--editor-syntax-string);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-attr,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-variable,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-template-variable,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-type,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-selector-class,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-selector-attr,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-selector-pseudo,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-number {+ color: var(--editor-syntax-attr);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-symbol,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-bullet,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-link,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-meta,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-selector-id,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-title {+ color: var(--editor-syntax-symbol);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-built_in,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-title.class_,+:is(.tiptap-content .ProseMirror, .prose) pre .hljs-class .hljs-title {+ color: var(--editor-syntax-class);+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-emphasis {+ font-style: italic;+}++:is(.tiptap-content .ProseMirror, .prose) pre .hljs-strong {+ font-weight: 700;+}+.tiptap-content .ProseMirror blockquote {border-left: 3px solid var(--border);padding-left: 1rem;@@ -764,8 +875,24 @@border-radius: calc(var(--radius) - 4px);}-.tiptap-content .ProseMirror img.ProseMirror-selectednode {+/* Every selectable node, not just images: a NodeSelection on an `hr` had no visual at all, and since+ `.ProseMirror-hideselection` blanks the native highlight at the same time, the next keystroke replaced a+ node the user could not see was selected. prosemirror-view ships an outline rule for this, but its+ stylesheet is imported nowhere and tiptap's injected CSS carries no equivalent. */+.tiptap-content .ProseMirror .ProseMirror-selectednode {outline: 2px solid var(--primary);+ outline-offset: 2px;+}++.tiptap-content .ProseMirror img.ProseMirror-selectednode {+ outline-offset: 0;+}++/* tiptap injects `border-top: 1px solid black` for the gap cursor, so on the dark theme the caret you get+ between two block nodes (pressing left/up at the start of a leading table or fence) is a black line on a+ near-black background — a caret position with no visible caret. */+.tiptap-content .ProseMirror-gapcursor::after {+ border-top-color: var(--foreground);}/* `{{ ... }}` Go-template actions, highlighted via view-only decorations (document bytes untouched). */