Skip to content

Fully autonomous AI Agents system capable of performing complex penetration testing tasks

fix(ui): repair what the always-rendered header exposed on the other two pages

Sergey Kozyrenko46457026e8a5
diff --git a/frontend/e2e/specs/crud/template-detail.spec.ts b/frontend/e2e/specs/crud/template-detail.spec.ts
index 5128c3ac..273df168 100644
--- a/frontend/e2e/specs/crud/template-detail.spec.ts
+++ b/frontend/e2e/specs/crud/template-detail.spec.ts
@@ -18,6 +18,20 @@ test.describe('template detail', { tag: '@coverage' }, () => {
await page.keyboard.press('Escape');
};
+ // This route has no visual baseline at all, so the header order is asserted nowhere else.
+ test('keeps the pager between save and the actions menu', async ({ page }) => {
+ await page.goto(`/templates/${TEMPLATE_DETAIL.id}`);
+ await expect(page.getByRole('button', { name: 'Template actions' })).toBeVisible();
+
+ const labels = await page
+ .locator('header button')
+ .evaluateAll((buttons) => buttons.map((button) => button.getAttribute('aria-label') ?? button.textContent));
+ const positionOf = (label: string) => labels.findIndex((candidate) => (candidate ?? '').includes(label));
+
+ expect(positionOf('Save')).toBeLessThan(positionOf('Previous'));
+ expect(positionOf('Next')).toBeLessThan(positionOf('Template actions'));
+ });
+
test('loads the template body into the editor byte-exact', async ({ page, pageErrorLog }) => {
await page.goto(`/templates/${TEMPLATE_DETAIL.id}`);
diff --git a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png
index c357674f..76d0ea0e 100644
Binary files a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png and b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-dark-visual-linux.png differ
diff --git a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png
index 724793c1..7709f9ab 100644
Binary files a/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png and b/frontend/e2e/specs/visual/routes.spec.ts-snapshots/flows-5-light-visual-linux.png differ
diff --git a/frontend/src/features/knowledges/knowledge-header.tsx b/frontend/src/features/knowledges/knowledge-header.tsx
index 52e69118..848c8852 100644
--- a/frontend/src/features/knowledges/knowledge-header.tsx
+++ b/frontend/src/features/knowledges/knowledge-header.tsx
@@ -2,7 +2,7 @@ import type { ReactNode } from 'react';
import { Ellipsis, HatGlasses, LibraryBig, Pencil, Save, Trash } from 'lucide-react';
import { useCallback, useState } from 'react';
-import { useNavigate } from 'react-router-dom';
+import { useNavigate, useParams } from 'react-router-dom';
import { toast } from 'sonner';
import type { KnowledgeDocumentFragmentFragment } from '@/graphql/types';
@@ -40,7 +40,6 @@ interface KnowledgeHeaderProps {
canAnonymize?: boolean;
isAnonymizeDisabled?: boolean;
isAnonymizing?: boolean;
- isLoading?: boolean;
isNew: boolean;
knowledge?: KnowledgeDocumentFragmentFragment | null;
/**
@@ -72,7 +71,6 @@ export function KnowledgeHeader({
canAnonymize = false,
isAnonymizeDisabled = false,
isAnonymizing = false,
- isLoading = false,
isNew,
knowledge,
onAnonymize,
@@ -82,6 +80,7 @@ export function KnowledgeHeader({
viewMode = 'rich',
}: KnowledgeHeaderProps) {
const navigate = useNavigate();
+ const { knowledgeId: routeKnowledgeId } = useParams();
const { isMobile } = useBreakpoint();
const { deleteKnowledge, renameKnowledge } = useKnowledges();
const [isRenaming, setIsRenaming] = useState(false);
@@ -89,8 +88,9 @@ export function KnowledgeHeader({
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false);
const knowledgeId = knowledge?.id ?? null;
-
- const knowledgeNav = useKnowledgeDetailNavigation(knowledgeId);
+ // The route's id, not the loaded document's: the pager walks siblings, so it has to work
+ // while this document is in flight — as it already does on the flow and template pages.
+ const knowledgeNav = useKnowledgeDetailNavigation(isNew ? null : (routeKnowledgeId ?? null));
// Title source-of-truth is the server-side `question`. We intentionally do
// not read it from the form draft below — the inline rename flow in this
@@ -98,7 +98,7 @@ export function KnowledgeHeader({
// the cache, and the form picks up the new value separately.
const knowledgeName = knowledge?.question ?? null;
const hasKnowledge = !!knowledge;
- const isEntityPending = isLoading || !hasKnowledge;
+ const isEntityPending = !hasKnowledge;
const hasAnonymizeRow = isMobile && canAnonymize;
const hasEntityRows = !isNew;
const hasNavRow = isMobile && !isNew;
@@ -308,7 +308,9 @@ export function KnowledgeHeader({
) : null}
{hasEntityRows && (
<>
- <DropdownMenuSeparator />
+ {/* The View row is the only thing between the two groups, and the
+ loading shell has no mode toggle: unconditional, the rules double up. */}
+ {onModeChange ? <DropdownMenuSeparator /> : null}
<DropdownMenuItem
disabled={isDeleting || isEntityPending}
onClick={() => setIsDeleteDialogOpen(true)}
diff --git a/frontend/src/features/knowledges/knowledge-layout.tsx b/frontend/src/features/knowledges/knowledge-layout.tsx
index 4ed26e64..1902c41f 100644
--- a/frontend/src/features/knowledges/knowledge-layout.tsx
+++ b/frontend/src/features/knowledges/knowledge-layout.tsx
@@ -9,7 +9,6 @@ import { KnowledgeHeader } from './knowledge-header';
interface KnowledgeLayoutProps {
children: ReactNode;
className?: string;
- isLoading?: boolean;
isNew: boolean;
knowledge?: KnowledgeDocumentFragmentFragment | null;
saveButton?: ReactNode;
@@ -21,18 +20,10 @@ interface KnowledgeLayoutProps {
* renders the header inline because the form must be the parent of every
* input.
*/
-export function KnowledgeLayout({
- children,
- className,
- isLoading,
- isNew,
- knowledge,
- saveButton,
-}: KnowledgeLayoutProps) {
+export function KnowledgeLayout({ children, className, isNew, knowledge, saveButton }: KnowledgeLayoutProps) {
return (
<div className={cn('flex min-h-[100dvh] flex-col', className)}>
<KnowledgeHeader
- isLoading={isLoading}
isNew={isNew}
knowledge={knowledge}
saveButton={saveButton}
diff --git a/frontend/src/pages/knowledges/knowledge.tsx b/frontend/src/pages/knowledges/knowledge.tsx
index 3c53998f..672015dc 100644
--- a/frontend/src/pages/knowledges/knowledge.tsx
+++ b/frontend/src/pages/knowledges/knowledge.tsx
@@ -76,7 +76,6 @@ function Knowledge() {
if (!isNew && !knowledge) {
return (
<KnowledgeLayout
- isLoading={isLoadingKnowledge}
isNew={false}
knowledge={knowledge}
>
diff --git a/frontend/src/pages/templates/template.tsx b/frontend/src/pages/templates/template.tsx
index 1abb993c..f04e4022 100644
--- a/frontend/src/pages/templates/template.tsx
+++ b/frontend/src/pages/templates/template.tsx
@@ -414,6 +414,7 @@ function Template() {
const hasTemplate = !!templateData?.flowTemplate;
const isTemplatePending = !isNew && (isLoadingTemplate || !hasTemplate);
+ const isTemplateMissing = !isNew && !isLoadingTemplate && !hasTemplate;
const pageHeader = (
<>
@@ -453,105 +454,109 @@ function Template() {
</BreadcrumbList>
</Breadcrumb>
</AppHeaderContent>
- <AppHeaderActions>
- <AppHeaderAction
- disabled={isTemplatePending || (!isNew && !hasUnsavedChanges)}
- form="template-form"
- icon={<Save />}
- label={isNew ? 'Create' : 'Save'}
- loading={isSaving}
- type="submit"
- />
- {!isNew && !isMobile && (
- <DetailNavigationToolbar<Template>
- controller={templateNav}
- renderItem={renderTemplateItem}
- sheetIcon={<FileText className="size-4" />}
- sheetTitle="Templates"
+ {/* The not-found card reuses this header; a Save aimed at a form that is not
+ there and a pager for an id that is not in the list are not "always meaningful". */}
+ {!isTemplateMissing && (
+ <AppHeaderActions>
+ <AppHeaderAction
+ disabled={isTemplatePending || (!isNew && !hasUnsavedChanges)}
+ form="template-form"
+ icon={<Save />}
+ label={isNew ? 'Create' : 'Save'}
+ loading={isSaving}
+ type="submit"
/>
- )}
- <DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button
- aria-label="Template actions"
- className="size-8 p-0"
- variant="ghost"
- >
- <Ellipsis />
- </Button>
- </DropdownMenuTrigger>
- <DropdownMenuContent
- align="end"
- className="min-w-24"
- onCloseAutoFocus={handleDropdownCloseAutoFocus}
- >
- {!isNew && (
- <>
- {isMobile && (
- <>
- <DropdownMenuItem
- className="cursor-default hover:bg-transparent focus:bg-transparent"
- onSelect={(event) => event.preventDefault()}
- >
- <FileText />
- Templates
- <div className="-my-1.5 -mr-2 ml-auto flex items-center">
- <DetailNavigationButtons<Template>
- controller={templateNav}
- sheetTitle="Templates"
- size="sm"
- />
- </div>
- </DropdownMenuItem>
- <DropdownMenuSeparator />
- </>
- )}
- <DropdownMenuItem
- disabled={isTemplatePending}
- onClick={handleTemplateRenameStart}
- >
- <Pencil />
- Rename
- </DropdownMenuItem>
- <DropdownMenuSeparator />
- </>
- )}
- <DropdownMenuItem
- className="cursor-default gap-4 hover:bg-transparent focus:bg-transparent"
- onSelect={(event) => event.preventDefault()}
+ {!isNew && !isMobile && (
+ <DetailNavigationToolbar<Template>
+ controller={templateNav}
+ renderItem={renderTemplateItem}
+ sheetIcon={<FileText className="size-4" />}
+ sheetTitle="Templates"
+ />
+ )}
+ <DropdownMenu>
+ <DropdownMenuTrigger asChild>
+ <Button
+ aria-label="Template actions"
+ className="size-8 p-0"
+ variant="ghost"
+ >
+ <Ellipsis />
+ </Button>
+ </DropdownMenuTrigger>
+ <DropdownMenuContent
+ align="end"
+ className="min-w-24"
+ onCloseAutoFocus={handleDropdownCloseAutoFocus}
>
- View
- <EditorViewModeToggle
- className="-my-1.5 -mr-2 ml-auto"
- mode={viewMode}
- onModeChange={setViewMode}
- rawTooltip="Edit the raw template"
- />
- </DropdownMenuItem>
- {!isNew && (
- <>
- <DropdownMenuSeparator />
- <DropdownMenuItem
- disabled={isDeleting || isTemplatePending}
- onClick={() => setIsDeleteDialogOpen(true)}
- >
- {isDeleting ? (
- <>
- <Spinner variant="circle" />
- Deleting...
- </>
- ) : (
+ {!isNew && (
+ <>
+ {isMobile && (
<>
- <Trash />
- Delete
+ <DropdownMenuItem
+ className="cursor-default hover:bg-transparent focus:bg-transparent"
+ onSelect={(event) => event.preventDefault()}
+ >
+ <FileText />
+ Templates
+ <div className="-my-1.5 -mr-2 ml-auto flex items-center">
+ <DetailNavigationButtons<Template>
+ controller={templateNav}
+ sheetTitle="Templates"
+ size="sm"
+ />
+ </div>
+ </DropdownMenuItem>
+ <DropdownMenuSeparator />
</>
)}
- </DropdownMenuItem>
- </>
- )}
- </DropdownMenuContent>
- </DropdownMenu>
- </AppHeaderActions>
+ <DropdownMenuItem
+ disabled={isTemplatePending}
+ onClick={handleTemplateRenameStart}
+ >
+ <Pencil />
+ Rename
+ </DropdownMenuItem>
+ <DropdownMenuSeparator />
+ </>
+ )}
+ <DropdownMenuItem
+ className="cursor-default gap-4 hover:bg-transparent focus:bg-transparent"
+ onSelect={(event) => event.preventDefault()}
+ >
+ View
+ <EditorViewModeToggle
+ className="-my-1.5 -mr-2 ml-auto"
+ mode={viewMode}
+ onModeChange={setViewMode}
+ rawTooltip="Edit the raw template"
+ />
+ </DropdownMenuItem>
+ {!isNew && (
+ <>
+ <DropdownMenuSeparator />
+ <DropdownMenuItem
+ disabled={isDeleting || isTemplatePending}
+ onClick={() => setIsDeleteDialogOpen(true)}
+ >
+ {isDeleting ? (
+ <>
+ <Spinner variant="circle" />
+ Deleting...
+ </>
+ ) : (
+ <>
+ <Trash />
+ Delete
+ </>
+ )}
+ </DropdownMenuItem>
+ </>
+ )}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </AppHeaderActions>
+ )}
</AppHeader>
{isMobile && !isNew && (
<DetailNavigationSheet<Template>