Fully autonomous AI Agents system capable of performing complex penetration testing tasks
Go ai-agentsai-security-toolanthropicautonomous-agentsgolanggptgraphqlmulti-agent-systemoffensive-securityopen-sourceopenaipenetration-testingpenetration-testing-toolsreactsecurity-automationsecurity-testingsecurity-toolsself-hosted
fix: clarify Ollama models without tool support
mason5052552eda8746b4
diff --git a/backend/pkg/providers/helpers.go b/backend/pkg/providers/helpers.goindex 7c714473..cc80eeaf 100644--- a/backend/pkg/providers/helpers.go+++ b/backend/pkg/providers/helpers.go@@ -44,6 +44,32 @@ type dummyMessage struct {Message string `json:"message"`}+// wrapToolCallIDTemplateError annotates an error returned by+// Provider.GetToolCallIDTemplate so the user sees an actionable hint when a+// known upstream limitation blocks flow creation. Currently it covers the+// Ollama "model does not support tools" case (issue #280): the underlying+// error is returned by the Ollama API itself and surfaces five wraps deep,+// which previously left the user with a cryptic "failed to determine tool+// call ID template" message.+//+// The function preserves the original error chain via %w so downstream code+// (logs, langfuse spans, errors.Is/As) keeps working.+func wrapToolCallIDTemplateError(err error) error {+ if err == nil {+ return nil+ }+ if strings.Contains(err.Error(), "does not support tools") {+ return fmt.Errorf(+ "failed to determine tool call ID template: the selected model "++ "does not support tool/function calling, which PentAGI requires "++ "for flow execution; pick an Ollama model that advertises the "++ "\"tools\" capability (for example llama3.1, qwen2.5, or "++ "mistral-nemo) and update the provider configuration: %w",+ err)+ }+ return fmt.Errorf("failed to determine tool call ID template: %w", err)+}+type reflectorRetryContextKey struct{}// isReflectorRetry checks if we are already in a reflector retry cyclediff --git a/backend/pkg/providers/helpers_test.go b/backend/pkg/providers/helpers_test.goindex 88a610ca..a59188c0 100644--- a/backend/pkg/providers/helpers_test.go+++ b/backend/pkg/providers/helpers_test.go@@ -2,7 +2,10 @@ package providersimport ("encoding/json"+ "errors"+ "fmt""slices"+ "strings""sync""sync/atomic""testing"@@ -1171,3 +1174,84 @@ func TestExecutionMonitorDetector_TotalCallsSequence(t *testing.T) {func mockToolCall(name string) llms.ToolCall {return llms.ToolCall{FunctionCall: &llms.FunctionCall{Name: name}}}++func TestWrapToolCallIDTemplateError(t *testing.T) {+ t.Parallel()++ // Mirror the real upstream wrap chain so the test traps regressions in+ // substring detection if the inner wraps ever change.+ ollamaErr := fmt.Errorf(+ "all sample collection attempts failed: %w",+ fmt.Errorf("failed to call LLM: %w",+ errors.New("400 Bad Request: registry.ollama.ai/library/gemma3:27b-it-q4_K_M does not support tools")),+ )+ genericErr := errors.New("connection refused")++ cases := []struct {+ name string+ input error+ wantNil bool+ wantContains []string+ wantUnwrapsTo error+ wantNotContain []string+ }{+ {+ name: "nil error passes through",+ input: nil,+ wantNil: true,+ },+ {+ name: "ollama tools error gets actionable hint",+ input: ollamaErr,+ wantContains: []string{+ "failed to determine tool call ID template",+ "does not support tool/function calling",+ "PentAGI requires",+ "\"tools\" capability",+ "does not support tools",+ },+ wantUnwrapsTo: ollamaErr,+ },+ {+ name: "non-tools error keeps existing wrap",+ input: genericErr,+ wantContains: []string{+ "failed to determine tool call ID template",+ "connection refused",+ },+ wantNotContain: []string{+ "does not support tool/function calling",+ "\"tools\" capability",+ },+ wantUnwrapsTo: genericErr,+ },+ }++ for _, tc := range cases {+ t.Run(tc.name, func(t *testing.T) {+ t.Parallel()++ got := wrapToolCallIDTemplateError(tc.input)+ if tc.wantNil {+ assert.Nil(t, got)+ return+ }+ if !assert.NotNil(t, got) {+ return+ }+ msg := got.Error()+ for _, want := range tc.wantContains {+ assert.Truef(t, strings.Contains(msg, want),+ "expected error message to contain %q; got %q", want, msg)+ }+ for _, banned := range tc.wantNotContain {+ assert.Falsef(t, strings.Contains(msg, banned),+ "expected error message NOT to contain %q; got %q", banned, msg)+ }+ if tc.wantUnwrapsTo != nil {+ assert.True(t, errors.Is(got, tc.wantUnwrapsTo),+ "expected wrapped error to unwrap to original via errors.Is")+ }+ })+ }+}diff --git a/backend/pkg/providers/providers.go b/backend/pkg/providers/providers.goindex 9a9a5a7d..e2947a3c 100644--- a/backend/pkg/providers/providers.go+++ b/backend/pkg/providers/providers.go@@ -439,7 +439,7 @@ func (pc *providerController) NewFlowProvider(tcIDTemplate, err := prv.GetToolCallIDTemplate(ctx, prompter)if err != nil {- return nil, fmt.Errorf("failed to determine tool call ID template: %w", err)+ return nil, wrapToolCallIDTemplateError(err)}fp := &flowProvider{@@ -581,7 +581,7 @@ func (pc *providerController) NewAssistantProvider(tcIDTemplate, err := prv.GetToolCallIDTemplate(ctx, prompter)if err != nil {- return nil, fmt.Errorf("failed to determine tool call ID template: %w", err)+ return nil, wrapToolCallIDTemplateError(err)}ap := &assistantProvider{