Skip to content

Fully autonomous AI Agents system capable of performing complex penetration testing tasks

feat(providers): guard cloning a disabled-type provider + test the menu filter

Sergey Kozyrenko579fac8b694b
diff --git a/frontend/src/pages/settings/settings-provider.tsx b/frontend/src/pages/settings/settings-provider.tsx
index 3329c086..1c63cc25 100644
--- a/frontend/src/pages/settings/settings-provider.tsx
+++ b/frontend/src/pages/settings/settings-provider.tsx
@@ -1262,7 +1262,7 @@ function SettingsProvider() {
// A hand-typed ?type= URL bypasses the create menu's enabled-only filter; an
// unknown or disabled type would otherwise create a dead provider or dump a raw
- // zod error on submit. Bounce it to the list. (Clone-by-id, below, is exempt.)
+ // zod error on submit. Bounce it to the list. (Clone-by-id is gated separately below.)
if (!queryId && queryType && !providers.enabled[queryType as keyof typeof providers.enabled]) {
toast.error(`Provider type "${queryType}" is not available`);
navigate(routes.settings.providers, { replace: true });
@@ -1276,6 +1276,15 @@ function SettingsProvider() {
if (sourceProvider) {
const { agents, name, type: sourceType } = sourceProvider;
+ // Cloning a provider whose type is now disabled would only make
+ // another dead one — gate it the same as the ?type= path.
+ if (sourceType && !providers.enabled[sourceType as keyof typeof providers.enabled]) {
+ toast.error(`Provider type "${sourceType}" is not available`);
+ navigate(routes.settings.providers, { replace: true });
+
+ return;
+ }
+
reset({
agents: agents ? (normalizeGraphQLData(agents) as FormAgents) : {},
name: `${name} (Copy)`,
diff --git a/frontend/src/pages/settings/settings-providers.test.tsx b/frontend/src/pages/settings/settings-providers.test.tsx
new file mode 100644
index 00000000..7c5c03fd
--- /dev/null
+++ b/frontend/src/pages/settings/settings-providers.test.tsx
@@ -0,0 +1,43 @@
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { describe, expect, it, vi } from 'vitest';
+
+const enabled = {
+ anthropic: true,
+ bedrock: true,
+ custom: false,
+ deepseek: true,
+ gemini: true,
+ glm: true,
+ kimi: true,
+ minimax: false,
+ ollama: true,
+ openai: true,
+ qwen: true,
+};
+
+vi.mock('@apollo/client/react', () => ({
+ useMutation: () => [vi.fn(), {}],
+ useQuery: () => ({ data: { settingsProviders: { enabled } } }),
+}));
+
+vi.mock('react-router-dom', async (importOriginal) => ({
+ ...(await importOriginal<typeof import('react-router-dom')>()),
+ useNavigate: () => vi.fn(),
+}));
+
+import { SettingsProvidersHeader } from './settings-providers';
+
+describe('SettingsProvidersHeader create menu', () => {
+ it('offers only provider types whose API key is configured', async () => {
+ const user = userEvent.setup();
+ render(<SettingsProvidersHeader />);
+
+ await user.click(screen.getByRole('button', { name: /create provider/i }));
+
+ expect(screen.queryByRole('menuitem', { name: /MiniMax/ })).not.toBeInTheDocument();
+ expect(screen.queryByRole('menuitem', { name: /Custom/ })).not.toBeInTheDocument();
+ expect(screen.getByRole('menuitem', { name: /Anthropic/ })).toBeInTheDocument();
+ expect(screen.getByRole('menuitem', { name: /OpenAI/ })).toBeInTheDocument();
+ });
+});
diff --git a/frontend/src/pages/settings/settings-providers.tsx b/frontend/src/pages/settings/settings-providers.tsx
index acb81b8f..4d1233a7 100644
--- a/frontend/src/pages/settings/settings-providers.tsx
+++ b/frontend/src/pages/settings/settings-providers.tsx
@@ -50,6 +50,69 @@ const providerTypes = (Object.keys(providerLabels) as ProviderType[]).map((type)
type,
}));
+export function SettingsProvidersHeader() {
+ const navigate = useNavigate();
+ // Cached: the list above already fetched this query, so the read is local.
+ const { data } = useQuery(SettingsProvidersDocument);
+ const enabled = data?.settingsProviders?.enabled;
+
+ const handleProviderCreate = (providerType: string) => {
+ navigate(routes.settings.newProvider({ type: providerType }));
+ };
+
+ return (
+ <div className="flex items-center justify-between gap-4">
+ <p className="text-muted-foreground min-w-0 flex-1 truncate">Manage language model providers</p>
+
+ {/*
+ * "Create Provider" is a dropdown trigger, not a submit-style action — it
+ * opens a menu listing provider types (OpenAI, Anthropic, Custom, …). The
+ * `<ChevronDown />` icon plus Radix's `aria-haspopup="menu"` already signal
+ * "menu opens" to sighted and AT users; the explicit aria-label adds the
+ * intent ("create provider") so screen readers don't just announce
+ * "Create Provider, menu" but "Create provider, choose type, menu".
+ */}
+ <DropdownMenu>
+ <DropdownMenuTrigger asChild>
+ <Button
+ aria-label="Create provider — choose type"
+ className="shrink-0"
+ variant="secondary"
+ >
+ Create Provider
+ <ChevronDown className="size-4" />
+ </Button>
+ </DropdownMenuTrigger>
+ <DropdownMenuContent
+ align="end"
+ style={{
+ width: 'var(--radix-dropdown-menu-trigger-width)',
+ }}
+ >
+ {/* Only offer types whose API key is configured — creating a provider of a
+ disabled type yields one that's unusable for flows (the create form guards
+ the same against a hand-typed ?type=). */}
+ {providerTypes
+ .filter(({ type }) => enabled?.[type as keyof typeof enabled])
+ .map(({ label, type }) => {
+ const Icon = providerIcons[type]?.icon;
+
+ return (
+ <DropdownMenuItem
+ key={type}
+ onClick={() => handleProviderCreate(type)}
+ >
+ {Icon && <Icon className="size-4" />}
+ {label}
+ </DropdownMenuItem>
+ );
+ })}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ </div>
+ );
+}
+
function SettingsProviders() {
const { data, error, loading: isLoading } = useQuery(SettingsProvidersDocument);
const [deleteProvider, { error: deleteError, loading: isDeleteLoading }] = useMutation(DeleteProviderDocument);
@@ -450,67 +513,4 @@ function SettingsProviders() {
);
}
-function SettingsProvidersHeader() {
- const navigate = useNavigate();
- // Cached: the list above already fetched this query, so the read is local.
- const { data } = useQuery(SettingsProvidersDocument);
- const enabled = data?.settingsProviders?.enabled;
-
- const handleProviderCreate = (providerType: string) => {
- navigate(routes.settings.newProvider({ type: providerType }));
- };
-
- return (
- <div className="flex items-center justify-between gap-4">
- <p className="text-muted-foreground min-w-0 flex-1 truncate">Manage language model providers</p>
-
- {/*
- * "Create Provider" is a dropdown trigger, not a submit-style action — it
- * opens a menu listing provider types (OpenAI, Anthropic, Custom, …). The
- * `<ChevronDown />` icon plus Radix's `aria-haspopup="menu"` already signal
- * "menu opens" to sighted and AT users; the explicit aria-label adds the
- * intent ("create provider") so screen readers don't just announce
- * "Create Provider, menu" but "Create provider, choose type, menu".
- */}
- <DropdownMenu>
- <DropdownMenuTrigger asChild>
- <Button
- aria-label="Create provider — choose type"
- className="shrink-0"
- variant="secondary"
- >
- Create Provider
- <ChevronDown className="size-4" />
- </Button>
- </DropdownMenuTrigger>
- <DropdownMenuContent
- align="end"
- style={{
- width: 'var(--radix-dropdown-menu-trigger-width)',
- }}
- >
- {/* Only offer types whose API key is configured — creating a provider of a
- disabled type yields one that's unusable for flows (the create form guards
- the same against a hand-typed ?type=). */}
- {providerTypes
- .filter(({ type }) => enabled?.[type as keyof typeof enabled])
- .map(({ label, type }) => {
- const Icon = providerIcons[type]?.icon;
-
- return (
- <DropdownMenuItem
- key={type}
- onClick={() => handleProviderCreate(type)}
- >
- {Icon && <Icon className="size-4" />}
- {label}
- </DropdownMenuItem>
- );
- })}
- </DropdownMenuContent>
- </DropdownMenu>
- </div>
- );
-}
-
export default SettingsProviders;