Fully autonomous AI Agents system capable of performing complex penetration testing tasks
Go ai-agentsai-security-toolanthropicautonomous-agentsgolanggptgraphqlmulti-agent-systemoffensive-securityopen-sourceopenaipenetration-testingpenetration-testing-toolsreactsecurity-automationsecurity-testingsecurity-toolsself-hosted
perf(frontend): debounce DataTable filter input commits
Sergey Kozyrenko63d059834ff7
diff --git a/frontend/src/components/ui/data-table.test.tsx b/frontend/src/components/ui/data-table.test.tsxindex 0433146d..42de4fd5 100644--- a/frontend/src/components/ui/data-table.test.tsx+++ b/frontend/src/components/ui/data-table.test.tsx@@ -1,7 +1,7 @@import type { Column, ColumnDef } from '@tanstack/react-table';import type { ReactNode } from 'react';-import { fireEvent, render, screen, within } from '@testing-library/react';+import { fireEvent, render, screen, waitFor, within } from '@testing-library/react';import userEvent from '@testing-library/user-event';import { MemoryRouter } from 'react-router-dom';import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';@@ -80,7 +80,7 @@ describe('DataTable — controlled filter projection', () => {expect(screen.getByText('Charlie')).toBeInTheDocument();});- it('invokes `onFilterChange` with the typed value as the user edits the input', async () => {+ it('invokes `onFilterChange` with the typed value after the debounce settles', async () => {const onFilterChange = vi.fn();const user = userEvent.setup();@@ -99,12 +99,14 @@ describe('DataTable — controlled filter projection', () => {const input = screen.getByPlaceholderText('Filter name...');await user.type(input, 'al');- // userEvent fires keystroke-by-keystroke; the last call carries the- // full input — controlled-mode parents receive every intermediate- // value because the input is controlled by the column filter API.- expect(onFilterChange).toHaveBeenCalled();+ // The input debounces its commit to the parent — intermediate values+ // never reach `onFilterChange`. After the debounce settles, the parent+ // sees exactly one call carrying the final value.+ await waitFor(() => {+ expect(onFilterChange).toHaveBeenCalled();+ });const lastCall = onFilterChange.mock.calls.at(-1);- expect(lastCall?.[0]).toBe('l');+ expect(lastCall?.[0]).toBe('al');});it('clears the filter when the trailing X button is clicked', async () => {@@ -151,10 +153,13 @@ describe('DataTable — uncontrolled filter is still routed through the same inpconst input = screen.getByPlaceholderText('Filter...');await user.type(input, 'Bra');- // The input is uncontrolled here — TanStack reflects the value back- // via `column.getFilterValue()`, and only matching rows survive.+ // Wait for the input's debounced commit; Bravo was in the initial+ // render, so the only authoritative signal is the disappearance of+ // the non-matching row.+ await waitFor(() => {+ expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ });expect(screen.getByText('Bravo')).toBeInTheDocument();- expect(screen.queryByText('Alpha')).not.toBeInTheDocument();});});@@ -330,9 +335,14 @@ describe('DataTable — multi-column search', () => {// must surface Charlie even though her `name` doesn't contain it.await user.type(input, 'reader');- expect(screen.getByText('Charlie')).toBeInTheDocument();- expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ // Wait for the non-matching rows to disappear; Alpha and Bravo are+ // present in the initial render, so finding Charlie is not enough —+ // we need to confirm the filter actually narrowed the row set.+ await waitFor(() => {+ expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ });expect(screen.queryByText('Bravo')).not.toBeInTheDocument();+ expect(screen.getByText('Charlie')).toBeInTheDocument();});it('narrows the search when the picker disables a candidate', async () => {@@ -357,7 +367,7 @@ describe('DataTable — multi-column search', () => {const input = screen.getByPlaceholderText('Filter...');await user.type(input, 'reader');- expect(screen.getByText('No results.')).toBeInTheDocument();+ expect(await screen.findByText('No results.')).toBeInTheDocument();});it('persists the narrowed search column set to the unified storage slot', async () => {@@ -391,7 +401,7 @@ describe('DataTable — multi-column search', () => {// "admin" appears only in `role` on Alpha. Confirm the multi-column// search surfaces her *before* we narrow the picker.await user.type(screen.getByPlaceholderText('Filter...'), 'admin');- expect(screen.getByText('Alpha')).toBeInTheDocument();+ expect(await screen.findByText('Alpha')).toBeInTheDocument();// Now uncheck `Role`. The previous closure-based implementation kept// Alpha visible here because `state.globalFilter` stayed equal and@@ -401,7 +411,9 @@ describe('DataTable — multi-column search', () => {await user.click(screen.getByRole('button', { name: /Search in/ }));await user.click(await screen.findByRole('menuitemcheckbox', { name: /role/i }));- expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ await waitFor(() => {+ expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ });});it('prunes stale ids from persisted searchColumns when the candidate set shrinks', () => {@@ -447,9 +459,13 @@ describe('DataTable — multi-column search', () => {await user.type(input, 'user');// "user" matches Bravo's role; Alpha and Charlie don't contain it.- expect(screen.getByText('Bravo')).toBeInTheDocument();- expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ // Wait for them to disappear instead of relying on `Bravo` being+ // present (it was in the initial render too).+ await waitFor(() => {+ expect(screen.queryByText('Alpha')).not.toBeInTheDocument();+ });expect(screen.queryByText('Charlie')).not.toBeInTheDocument();+ expect(screen.getByText('Bravo')).toBeInTheDocument();});it('hides the input entirely when filterColumn is undefined and no column opts in', () => {diff --git a/frontend/src/components/ui/data-table.tsx b/frontend/src/components/ui/data-table.tsxindex 20e4a56e..2679d325 100644--- a/frontend/src/components/ui/data-table.tsx+++ b/frontend/src/components/ui/data-table.tsx@@ -9,7 +9,6 @@ import {getFilteredRowModel,getPaginationRowModel,getSortedRowModel,- type Table as ReactTable,type Row,type SortingState,useReactTable,@@ -41,6 +40,7 @@ import {import { InputGroup, InputGroupAddon, InputGroupButton, InputGroupInput } from '@/components/ui/input-group';import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from '@/components/ui/table';+import { useDebouncedValue } from '@/hooks/use-debounced-value';import { useEffectAfterMount } from '@/hooks/use-effect-after-mount';import { useLatestRef } from '@/hooks/use-latest-ref';import { usePageStorageKeys } from '@/hooks/use-page-storage-keys';@@ -119,20 +119,54 @@ const getColumnId = <TData, TValue>(column: ColumnDef<TData, TValue>): string |return typeof withAccessor.accessorKey === 'string' ? withAccessor.accessorKey : undefined;};-interface DataTableFilterProps<TData> {+interface DataTableFilterProps {+ onQueryChange: (value: string) => void;placeholder: string;- table: ReactTable<TData>;+ query: string;}+const FILTER_DEBOUNCE_MS = 150;+/**- * Search input bound to TanStack's `state.globalFilter`. Reads `.query` out of- * the composite filter value and writes back a raw string — the normalising- * `onGlobalFilterChange` handler upstream takes care of folding it back into- * the composite shape (and forwarding the parent-visible string in- * controlled mode).+ * Search input for the table's global filter. Keystrokes update an internal+ * `localValue` state synchronously so the input feels instant; the debounced+ * mirror is what we propagate upstream via `onQueryChange`. The previous+ * design committed every keystroke straight into `useTableQueryFilter`, which+ * synchronously walked the router and re-rendered the entire route subtree —+ * with the Flows page that ran ~250 ms per keystroke, so consecutive+ * keypresses queued behind the in-flight reconciliation and showed up as+ * input-delay INP. Debouncing the commit drops the upstream cascade rate+ * from per-keystroke to once per typing pause.+ *+ * External `query` changes (X button, programmatic clear, URL back-button,+ * route swap) are reconciled into `localValue` through the sync effect: we+ * skip when the incoming value matches what we last emitted, so our own+ * round-trip through the parent doesn't fight with active typing.*/-const DataTableFilter = <TData,>({ placeholder, table }: DataTableFilterProps<TData>) => {- const filterValue = (table.getState().globalFilter as DataTableGlobalFilter | undefined)?.query ?? '';+const DataTableFilter = ({ onQueryChange, placeholder, query }: DataTableFilterProps) => {+ const [localValue, setLocalValue] = useState(query);+ const debouncedValue = useDebouncedValue(localValue, FILTER_DEBOUNCE_MS);+ const lastEmittedReference = useRef(query);++ useEffect(() => {+ if (query !== lastEmittedReference.current) {+ setLocalValue(query);+ lastEmittedReference.current = query;+ }+ }, [query]);++ useEffect(() => {+ if (debouncedValue !== lastEmittedReference.current) {+ lastEmittedReference.current = debouncedValue;+ onQueryChange(debouncedValue);+ }+ }, [debouncedValue, onQueryChange]);++ const handleClear = useCallback(() => {+ setLocalValue('');+ lastEmittedReference.current = '';+ onQueryChange('');+ }, [onQueryChange]);return (<InputGroup className="max-w-sm">@@ -144,15 +178,15 @@ const DataTableFilter = <TData,>({ placeholder, table }: DataTableFilterProps<TDautoComplete="off"id="data-table-search"name="search"- onChange={(event) => table.setGlobalFilter(event.target.value)}+ onChange={(event) => setLocalValue(event.target.value)}placeholder={placeholder}type="text"- value={filterValue}+ value={localValue}/>- {filterValue ? (+ {localValue ? (<InputGroupAddon align="inline-end"><InputGroupButton- onClick={() => table.setGlobalFilter('')}+ onClick={handleClear}type="button"><X />@@ -563,22 +597,26 @@ function DataTable<TData, TValue = unknown>({return (<div className="w-full">- <div className="flex items-center gap-4 py-4">+ <div className="flex items-center gap-2 py-4">{searchCandidateIds.length > 0 ? (<DataTableFilter+ onQueryChange={(value) => table.setGlobalFilter(value)}placeholder={filterPlaceholder}- table={table}+ query={effectiveQuery}/>) : null}{isMultiMode && searchCandidateIds.length > 1 ? (<DropdownMenu><DropdownMenuTrigger asChild>- <Button variant="outline">- <ListFilter className="mr-2" />- Search in <ChevronDown className="ml-2" />+ <Button+ aria-label="Search in"+ size="icon"+ variant="outline"+ >+ <ListFilter /></Button></DropdownMenuTrigger>- <DropdownMenuContent align="start">+ <DropdownMenuContent align="end">{searchCandidateIds.map((id) => {const column = table.getColumn(id);