Skip to content

Fully autonomous AI Agents system capable of performing complex penetration testing tasks

refactor(ui): toast settings mutation failures instead of a standing banner

Sergey Kozyrenko84c55969d5a7
diff --git a/frontend/src/components/shared/error-alert.tsx b/frontend/src/components/shared/error-alert.tsx
deleted file mode 100644
index 29f7fe2a..00000000
--- a/frontend/src/components/shared/error-alert.tsx
+++ /dev/null
@@ -1,18 +0,0 @@
-import { AlertCircle } from 'lucide-react';
-
-import { Alert, AlertDescription, AlertTitle } from '@/components/ui/alert';
-
-interface ErrorAlertProps {
- message?: null | string;
- title: string;
-}
-
-export function ErrorAlert({ message, title }: ErrorAlertProps) {
- return (
- <Alert variant="destructive">
- <AlertCircle className="size-4" />
- <AlertTitle>{title}</AlertTitle>
- {message ? <AlertDescription>{message}</AlertDescription> : null}
- </Alert>
- );
-}
diff --git a/frontend/src/pages/settings/settings-api-tokens.tsx b/frontend/src/pages/settings/settings-api-tokens.tsx
index 54320b7b..d9c6c69a 100644
--- a/frontend/src/pages/settings/settings-api-tokens.tsx
+++ b/frontend/src/pages/settings/settings-api-tokens.tsx
@@ -19,7 +19,6 @@ import {
AppHeaderTitle,
} from '@/components/layouts/app/app-header';
import ConfirmationDialog from '@/components/shared/confirmation-dialog';
-import { ErrorAlert } from '@/components/shared/error-alert';
import { ErrorState } from '@/components/shared/error-state';
import { Badge } from '@/components/ui/badge';
import { Button } from '@/components/ui/button';
@@ -232,15 +231,14 @@ function EditRowActions({
function SettingsAPITokens() {
const { data, error, loading: isLoading } = useQuery(ApiTokensDocument);
- const [createAPIToken, { error: createError, loading: isCreateLoading }] = useMutation(CreateApiTokenDocument);
- const [updateAPIToken, { error: updateError, loading: isUpdateLoading }] = useMutation(UpdateApiTokenDocument);
- const [deleteAPIToken, { error: deleteError, loading: isDeleteLoading }] = useMutation(DeleteApiTokenDocument);
+ const [createAPIToken, { loading: isCreateLoading }] = useMutation(CreateApiTokenDocument);
+ const [updateAPIToken, { loading: isUpdateLoading }] = useMutation(UpdateApiTokenDocument);
+ const [deleteAPIToken, { loading: isDeleteLoading }] = useMutation(DeleteApiTokenDocument);
const [editingTokenId, setEditingTokenId] = useState<null | string>(null);
const [creatingToken, setCreatingToken] = useState(false);
const [tokenSecret, setTokenSecret] = useState<null | string>(null);
const [showTokenDialog, setShowTokenDialog] = useState(false);
- const [deleteErrorMessage, setDeleteErrorMessage] = useState<null | string>(null);
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false);
const [deletingToken, setDeletingToken] = useState<APIToken | null>(null);
@@ -319,7 +317,9 @@ function SettingsAPITokens() {
setEditingTokenId(null);
editForm.reset(EDIT_TOKEN_DEFAULTS);
} catch (error) {
- console.error('Failed to update token:', error);
+ toast.error('Failed to update token', {
+ description: error instanceof Error ? error.message : undefined,
+ });
}
},
[editForm, updateAPIToken],
@@ -371,7 +371,9 @@ function SettingsAPITokens() {
setCreatingToken(false);
createForm.reset(CREATE_TOKEN_DEFAULTS);
} catch (error) {
- console.error('Failed to create token:', error);
+ toast.error('Failed to create token', {
+ description: error instanceof Error ? error.message : undefined,
+ });
}
}, [createAPIToken, createForm]);
@@ -387,17 +389,16 @@ function SettingsAPITokens() {
}
try {
- setDeleteErrorMessage(null);
-
await deleteAPIToken({
refetchQueries: ['apiTokens'],
variables: { tokenId },
});
setDeletingToken(null);
- setDeleteErrorMessage(null);
} catch (error) {
- setDeleteErrorMessage(error instanceof Error ? error.message : 'An error occurred while deleting');
+ toast.error('Failed to delete token', {
+ description: error instanceof Error ? error.message : undefined,
+ });
}
},
[deleteAPIToken],
@@ -924,15 +925,6 @@ function SettingsAPITokens() {
<>
{pageHeader}
<div className="flex flex-1 flex-col gap-4 p-4">
- {(createError || updateError || deleteError || deleteErrorMessage) && (
- <ErrorAlert
- message={
- createError?.message || updateError?.message || deleteError?.message || deleteErrorMessage
- }
- title="Error"
- />
- )}
-
<DataTable<APIToken>
columns={columns}
data={creatingToken ? [createNewTokenPlaceholder, ...tokens] : tokens}
diff --git a/frontend/src/pages/settings/settings-providers.tsx b/frontend/src/pages/settings/settings-providers.tsx
index 48fab48d..59015168 100644
--- a/frontend/src/pages/settings/settings-providers.tsx
+++ b/frontend/src/pages/settings/settings-providers.tsx
@@ -4,13 +4,13 @@ import { useMutation, useQuery } from '@apollo/client/react';
import { ChevronDown, Copy, Ellipsis, Pencil, Plug, Plus, Settings, Trash } from 'lucide-react';
import { useCallback, useMemo, useState } from 'react';
import { useNavigate } from 'react-router-dom';
+import { toast } from 'sonner';
import type { ProviderConfigFragmentFragment } from '@/graphql/types';
import { providerIcons } from '@/components/icons/provider-icon';
import { AppHeader, AppHeaderActions, AppHeaderContent, AppHeaderTitle } from '@/components/layouts/app/app-header';
import ConfirmationDialog from '@/components/shared/confirmation-dialog';
-import { ErrorAlert } from '@/components/shared/error-alert';
import { ErrorState } from '@/components/shared/error-state';
import { Badge } from '@/components/ui/badge';
import { Button } from '@/components/ui/button';
@@ -105,8 +105,7 @@ export function SettingsProvidersHeader() {
function SettingsProviders() {
const { data, error, loading: isLoading } = useQuery(SettingsProvidersDocument);
- const [deleteProvider, { error: deleteError, loading: isDeleteLoading }] = useMutation(DeleteProviderDocument);
- const [deleteErrorMessage, setDeleteErrorMessage] = useState<null | string>(null);
+ const [deleteProvider, { loading: isDeleteLoading }] = useMutation(DeleteProviderDocument);
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false);
const [deletingProvider, setDeletingProvider] = useState<null | Provider>(null);
const navigate = useNavigate();
@@ -120,17 +119,16 @@ function SettingsProviders() {
}
try {
- setDeleteErrorMessage(null);
-
await deleteProvider({
refetchQueries: ['settingsProviders'],
variables: { providerId: providerId.toString() },
});
setDeletingProvider(null);
- setDeleteErrorMessage(null);
} catch (error) {
- setDeleteErrorMessage(error instanceof Error ? error.message : 'An error occurred while deleting');
+ toast.error('Failed to delete provider', {
+ description: error instanceof Error ? error.message : undefined,
+ });
}
},
[deleteProvider],
@@ -477,13 +475,6 @@ function SettingsProviders() {
<>
{pageHeader}
<div className="flex flex-1 flex-col gap-4 p-4">
- {(deleteError || deleteErrorMessage) && (
- <ErrorAlert
- message={deleteError?.message || deleteErrorMessage}
- title="Error deleting provider"
- />
- )}
-
<DataTable<Provider>
columns={columns}
data={providers}