Fully autonomous AI Agents system capable of performing complex penetration testing tasks
Go ai-agentsai-security-toolanthropicautonomous-agentsgolanggptgraphqlmulti-agent-systemoffensive-securityopen-sourceopenaipenetration-testingpenetration-testing-toolsreactsecurity-automationsecurity-testingsecurity-toolsself-hosted
refactor(providers): apply review follow-ups (degrade log, count helper, empty menu)
Sergey Kozyrenko84d87cf47408
diff --git a/backend/pkg/providers/providers.go b/backend/pkg/providers/providers.goindex f492c7b7..94d18d48 100644--- a/backend/pkg/providers/providers.go+++ b/backend/pkg/providers/providers.go@@ -613,9 +613,11 @@ func (pc *providerController) GetProviders(for _, prv := range providers {p, err := pc.NewProvider(prv)if err != nil {- // A saved provider of a now-disabled type must not fail the whole list —- // skip it (like startup tolerates disabled defaults) so the rest stay usable.- logrus.WithError(err).Warnf("skipping user provider '%s' of unavailable type '%s'", prv.Name, prv.Type)+ // Any unbuildable saved provider (its type is disabled, or its stored+ // config is stale/invalid) is skipped, not propagated — one bad row must+ // not take down the whole list. Debug, not Warn: it re-fires on every+ // providers fetch; WithError carries the specific reason.+ logrus.WithError(err).Debugf("skipping unusable user provider '%s' (type '%s')", prv.Name, prv.Type)continue}providersMap[provider.ProviderName(prv.Name)] = pdiff --git a/frontend/src/pages/settings/settings-prompt.tsx b/frontend/src/pages/settings/settings-prompt.tsxindex 61252efd..f4cfba09 100644--- a/frontend/src/pages/settings/settings-prompt.tsx+++ b/frontend/src/pages/settings/settings-prompt.tsx@@ -18,7 +18,17 @@ import {Wrench,XCircle,} from 'lucide-react';-import { type ComponentProps, lazy, type Ref, Suspense, useCallback, useEffect, useMemo, useRef, useState } from 'react';+import {+ type ComponentProps,+ lazy,+ type Ref,+ Suspense,+ useCallback,+ useEffect,+ useMemo,+ useRef,+ useState,+} from 'react';import ReactDiffViewer from 'react-diff-viewer-continued';import {type Control,@@ -199,12 +209,8 @@ const variableActionRegex = (variable: string): RegExp => new RegExp(`\\{\\{[^{}// One pass over the `{{ … }}` blocks — the naive per-variable `.match` over the whole template is// O(variables × length) on every keystroke.function countVariableUses(template: string, variables: string[]): Record<string, number> {+ const probes = variables.map((variable) => [variable, new RegExp(`\\.${variable}\\b`)] as const);const counts: Record<string, number> = {};- const probes = variables.map((variable) => {- counts[variable] = 0;-- return [variable, new RegExp(`\\.${variable}\\b`)] as const;- });for (const block of template.match(/\{\{[^{}]*\}\}/g) ?? []) {for (const [variable, probe] of probes) {@@ -351,7 +357,10 @@ function SettingsPrompt() {const matchStart = target.index;textarea.focus();textarea.setSelectionRange(matchStart, matchStart + target[0].length);- textarea.scrollTop = Math.max(0, caretOffsetTop(textarea, matchStart) - textarea.clientHeight / 2);+ textarea.scrollTop = Math.max(+ 0,+ caretOffsetTop(textarea, matchStart) - textarea.clientHeight / 2,+ );}} else {const start = textarea.selectionStart;diff --git a/frontend/src/pages/settings/settings-providers.test.tsx b/frontend/src/pages/settings/settings-providers.test.tsxindex 7c5c03fd..bd5a8a94 100644--- a/frontend/src/pages/settings/settings-providers.test.tsx+++ b/frontend/src/pages/settings/settings-providers.test.tsx@@ -1,24 +1,12 @@import { render, screen } from '@testing-library/react';import userEvent from '@testing-library/user-event';-import { describe, expect, it, vi } from 'vitest';--const enabled = {- anthropic: true,- bedrock: true,- custom: false,- deepseek: true,- gemini: true,- glm: true,- kimi: true,- minimax: false,- ollama: true,- openai: true,- qwen: true,-};+import { beforeEach, describe, expect, it, vi } from 'vitest';++const state = vi.hoisted(() => ({ enabled: {} as Record<string, boolean> | undefined }));vi.mock('@apollo/client/react', () => ({useMutation: () => [vi.fn(), {}],- useQuery: () => ({ data: { settingsProviders: { enabled } } }),+ useQuery: () => ({ data: { settingsProviders: { enabled: state.enabled } } }),}));vi.mock('react-router-dom', async (importOriginal) => ({@@ -28,6 +16,24 @@ vi.mock('react-router-dom', async (importOriginal) => ({import { SettingsProvidersHeader } from './settings-providers';+const ALL_TYPES = [+ 'anthropic',+ 'bedrock',+ 'custom',+ 'deepseek',+ 'gemini',+ 'glm',+ 'kimi',+ 'minimax',+ 'ollama',+ 'openai',+ 'qwen',+];++beforeEach(() => {+ state.enabled = Object.fromEntries(ALL_TYPES.map((type) => [type, type !== 'minimax' && type !== 'custom']));+});+describe('SettingsProvidersHeader create menu', () => {it('offers only provider types whose API key is configured', async () => {const user = userEvent.setup();@@ -40,4 +46,15 @@ describe('SettingsProvidersHeader create menu', () => {expect(screen.getByRole('menuitem', { name: /Anthropic/ })).toBeInTheDocument();expect(screen.getByRole('menuitem', { name: /OpenAI/ })).toBeInTheDocument();});++ it('shows a placeholder, not an empty menu, when no type is enabled', async () => {+ state.enabled = Object.fromEntries(ALL_TYPES.map((type) => [type, false]));+ const user = userEvent.setup();+ render(<SettingsProvidersHeader />);++ await user.click(screen.getByRole('button', { name: /create provider/i }));++ expect(screen.getByRole('menuitem', { name: /no available provider types/i })).toBeInTheDocument();+ expect(screen.queryByRole('menuitem', { name: /OpenAI/ })).not.toBeInTheDocument();+ });});diff --git a/frontend/src/pages/settings/settings-providers.tsx b/frontend/src/pages/settings/settings-providers.tsxindex 4d1233a7..e4195b70 100644--- a/frontend/src/pages/settings/settings-providers.tsx+++ b/frontend/src/pages/settings/settings-providers.tsx@@ -55,6 +55,10 @@ export function SettingsProvidersHeader() {// Cached: the list above already fetched this query, so the read is local.const { data } = useQuery(SettingsProvidersDocument);const enabled = data?.settingsProviders?.enabled;+ // Only offer types whose API key is configured — a disabled-type provider is unusable+ // for flows (the create form guards the same against a hand-typed ?type=). Empty while+ // the query is in flight or when no key is configured anywhere.+ const availableTypes = providerTypes.filter(({ type }) => enabled?.[type as keyof typeof enabled]);const handleProviderCreate = (providerType: string) => {navigate(routes.settings.newProvider({ type: providerType }));@@ -89,12 +93,10 @@ export function SettingsProvidersHeader() {width: 'var(--radix-dropdown-menu-trigger-width)',}}>- {/* Only offer types whose API key is configured — creating a provider of a- disabled type yields one that's unusable for flows (the create form guards- the same against a hand-typed ?type=). */}- {providerTypes- .filter(({ type }) => enabled?.[type as keyof typeof enabled])- .map(({ label, type }) => {+ {availableTypes.length === 0 ? (+ <DropdownMenuItem disabled>No available provider types</DropdownMenuItem>+ ) : (+ availableTypes.map(({ label, type }) => {const Icon = providerIcons[type]?.icon;return (@@ -106,7 +108,8 @@ export function SettingsProvidersHeader() {{label}</DropdownMenuItem>);- })}+ })+ )}</DropdownMenuContent></DropdownMenu></div>