Fully autonomous AI Agents system capable of performing complex penetration testing tasks
Go ai-agentsai-security-toolanthropicautonomous-agentsgolanggptgraphqlmulti-agent-systemoffensive-securityopen-sourceopenaipenetration-testingpenetration-testing-toolsreactsecurity-automationsecurity-testingsecurity-toolsself-hosted
fix(flow): task execution handling with cancellable contexts on subtasks generation stage
Dmitry Ngce06a0d26ae1
diff --git a/backend/pkg/controller/flow.go b/backend/pkg/controller/flow.goindex 5035af39..2ba6cdb3 100644--- a/backend/pkg/controller/flow.go+++ b/backend/pkg/controller/flow.go@@ -998,40 +998,72 @@ func (fw *flowWorker) processInput(flin flowInput) (TaskWorker, error) {// anyway there need to set flow status to Running to disable user input_ = fw.SetStatus(fw.ctx, database.FlowStatusRunning)- if task, err := fw.tc.CreateTask(fw.ctx, flin.input, fw); err != nil {+ // Pre-create the per-task cancellable context BEFORE calling CreateTask.+ // GenerateSubtasks (an LLM call) runs synchronously inside CreateTask and may take+ // many seconds. Without this, a concurrent Stop() would invoke a no-op taskST and+ // find taskWG at zero—reporting success while the generator is still running.+ fw.taskMX.Lock()+ fw.taskST()+ ctx, taskST := context.WithCancel(fw.ctx)+ fw.taskST = taskST+ fw.taskMX.Unlock()++ defer taskST()++ fw.taskWG.Add(1)+ defer fw.taskWG.Done()+ defer fw.signalTaskComplete()++ task, err := fw.tc.CreateTask(ctx, flin.input, fw)+ if err != nil {+ if errors.Is(err, context.Canceled) && fw.ctx.Err() == nil {+ // CreateTask was cancelled by Stop() — not a fatal flow error.+ // Keep the worker alive and return the flow to Waiting state.+ flin.done <- nil+ _ = fw.SetStatus(fw.ctx, database.FlowStatusWaiting)+ return nil, nil+ }err = fmt.Errorf("failed to create task for flow %d: %w", fw.flowCtx.FlowID, err)flin.done <- errreturn nil, err- } else {- flin.done <- nil- spanName := fmt.Sprintf("perform task %d: %s", task.GetTaskID(), task.GetTitle())- return task, fw.runTask(spanName, flin.input, task)}++ flin.done <- nil+ spanName := fmt.Sprintf("perform task %d: %s", task.GetTaskID(), task.GetTitle())+ return task, fw.execTask(ctx, spanName, flin.input, task)}+// runTask creates a fresh per-task cancellable context and runs an already-created task.+// Use this for tasks that were previously created and are being resumed (e.g. after waiting).func (fw *flowWorker) runTask(spanName, input string, task TaskWorker) error {- _, observation := obs.Observer.NewObservation(fw.ctx)- span := observation.Span(- langfuse.WithSpanName(spanName),- langfuse.WithSpanInput(input),- langfuse.WithSpanMetadata(langfuse.Metadata{- "task_id": task.GetTaskID(),- }),- )-fw.taskMX.Lock()fw.taskST()ctx, taskST := context.WithCancel(fw.ctx)fw.taskST = taskSTfw.taskMX.Unlock()- ctx, _ = span.Observation(ctx)defer taskST()fw.taskWG.Add(1)defer fw.taskWG.Done()defer fw.signalTaskComplete()+ return fw.execTask(ctx, spanName, input, task)+}++// execTask executes a task using an already-prepared context and cancel function.+func (fw *flowWorker) execTask(ctx context.Context, spanName, input string, task TaskWorker) error {+ _, observation := obs.Observer.NewObservation(fw.ctx)+ span := observation.Span(+ langfuse.WithSpanName(spanName),+ langfuse.WithSpanInput(input),+ langfuse.WithSpanMetadata(langfuse.Metadata{+ "task_id": task.GetTaskID(),+ }),+ )++ ctx, _ = span.Observation(ctx)+if err := task.Run(ctx); err != nil {// if task is stopped by user and it's not finished yetif errors.Is(err, context.Canceled) && fw.ctx.Err() == nil {