Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor(network): name the tab-scoped route path once per client (PIN-357)

Luigi Agosti066df9134cb5
diff --git a/internal/cli/actions/actions_network_route.go b/internal/cli/actions/actions_network_route.go
index 75247e68..90c07595 100644
--- a/internal/cli/actions/actions_network_route.go
+++ b/internal/cli/actions/actions_network_route.go
@@ -60,10 +60,7 @@ func NetworkRoute(client *http.Client, base, token string, cmd *cobra.Command, p
req["method"] = method
}
- path := "/network/route"
- if tab, _ := cmd.Flags().GetString("tab"); tab != "" {
- path = fmt.Sprintf("/tabs/%s/network/route", url.PathEscape(tab))
- }
+ path := networkRoutePath(cmd)
result := requireMap(apiclient.DoPostQuiet(client, base, token, path, req), 1, "Failed to install route")
jsonOutput, _ := cmd.Flags().GetBool("json")
@@ -81,10 +78,7 @@ func NetworkUnroute(client *http.Client, base, token string, cmd *cobra.Command,
if pattern != "" {
params.Set("pattern", pattern)
}
- path := "/network/route"
- if tab, _ := cmd.Flags().GetString("tab"); tab != "" {
- path = fmt.Sprintf("/tabs/%s/network/route", url.PathEscape(tab))
- }
+ path := networkRoutePath(cmd)
result := requireMap(apiclient.DoDelete(client, base, token, path, params), 1, "Failed to remove route(s)")
jsonOutput, _ := cmd.Flags().GetBool("json")
@@ -100,10 +94,7 @@ func NetworkUnroute(client *http.Client, base, token string, cmd *cobra.Command,
}
func NetworkRules(client *http.Client, base, token string, cmd *cobra.Command) {
- path := "/network/route"
- if tab, _ := cmd.Flags().GetString("tab"); tab != "" {
- path = fmt.Sprintf("/tabs/%s/network/route", url.PathEscape(tab))
- }
+ path := networkRoutePath(cmd)
result := requireMap(apiclient.DoGet(client, base, token, path, nil), 1, "Failed to list routes")
jsonOutput, _ := cmd.Flags().GetBool("json")
@@ -134,3 +125,10 @@ func describeRouteRule(rule map[string]any) string {
}
return line
}
+
+func networkRoutePath(cmd *cobra.Command) string {
+ if tab, _ := cmd.Flags().GetString("tab"); tab != "" {
+ return fmt.Sprintf("/tabs/%s/network/route", url.PathEscape(tab))
+ }
+ return "/network/route"
+}
diff --git a/internal/mcp/handlers_network.go b/internal/mcp/handlers_network.go
index 868f1365..8239ef91 100644
--- a/internal/mcp/handlers_network.go
+++ b/internal/mcp/handlers_network.go
@@ -109,7 +109,7 @@ func handleNetworkRoute(c *Client) func(context.Context, mcp.CallToolRequest) (*
payload["method"] = method
}
- path := "/tabs/" + url.PathEscape(tabID) + "/network/route"
+ path := tabNetworkRoutePath(tabID)
respBody, code, err := c.Post(ctx, path, payload)
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
@@ -128,7 +128,7 @@ func handleNetworkUnroute(c *Client) func(context.Context, mcp.CallToolRequest)
if pattern := optString(r, "pattern"); pattern != "" {
q.Set("pattern", pattern)
}
- path := "/tabs/" + url.PathEscape(tabID) + "/network/route"
+ path := tabNetworkRoutePath(tabID)
respBody, code, err := c.Delete(ctx, path, q)
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
@@ -143,7 +143,7 @@ func handleNetworkRules(c *Client) func(context.Context, mcp.CallToolRequest) (*
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
}
- path := "/tabs/" + url.PathEscape(tabID) + "/network/route"
+ path := tabNetworkRoutePath(tabID)
respBody, code, err := c.Get(ctx, path, nil)
if err != nil {
return mcp.NewToolResultError(err.Error()), nil
@@ -151,3 +151,7 @@ func handleNetworkRules(c *Client) func(context.Context, mcp.CallToolRequest) (*
return resultFromBytes(respBody, code)
}
}
+
+func tabNetworkRoutePath(tabID string) string {
+ return "/tabs/" + url.PathEscape(tabID) + "/network/route"
+}