High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
fix: resolve remaining lint errors and CodeQL issues
Mario0bd5e5affda7
diff --git a/cmd/pinchtab/cmd_cli.go b/cmd/pinchtab/cmd_cli.goindex df9713a9..5119addd 100644--- a/cmd/pinchtab/cmd_cli.go+++ b/cmd/pinchtab/cmd_cli.go@@ -657,7 +657,9 @@ func getInstances(client *http.Client, base, token string) []map[string]any {defer func() { _ = result.Body.Close() }()var data map[string]any- json.NewDecoder(result.Body).Decode(&data)+ if err := json.NewDecoder(result.Body).Decode(&data); err != nil {+ log.Printf("warning: error decoding instances response: %v", err)+ }if instances, ok := data["instances"].([]interface{}); ok {converted := make([]map[string]any, len(instances))diff --git a/internal/orchestrator/handlers.go b/internal/orchestrator/handlers.goindex 73e4f682..d4c8b2ef 100644--- a/internal/orchestrator/handlers.go+++ b/internal/orchestrator/handlers.go@@ -145,10 +145,7 @@ func (o *Orchestrator) handleLaunchByName(w http.ResponseWriter, r *http.Request}// Default: headless=true unless mode="headed"- headless := true- if req.Mode == "headed" {- headless = false- }+ headless := req.Mode != "headed"// Generate unique instance name (internal use only)name := fmt.Sprintf("instance-%d", time.Now().UnixNano())@@ -218,10 +215,7 @@ func (o *Orchestrator) handleStartInstance(w http.ResponseWriter, r *http.Reques}// Parse mode: "headed" or "headless" (default: headless)- headless := true- if req.Mode == "headed" {- headless = false- }+ headless := req.Mode != "headed"// Port is optional - Launch() will auto-allocate if not providedinst, err := o.Launch(profileName, req.Port, headless)@@ -365,7 +359,7 @@ func (o *Orchestrator) proxyToInstance(w http.ResponseWriter, r *http.Request) {web.Error(w, 502, fmt.Errorf("failed to proxy to instance: %w", err))return}- defer resp.Body.Close()+ defer func() { _ = resp.Body.Close() }()// Copy response headersfor key, values := range resp.Header {@@ -469,7 +463,7 @@ func (o *Orchestrator) handleTabList(w http.ResponseWriter, r *http.Request) {web.Error(w, 500, fmt.Errorf("failed to get tabs from instance: %w", err))return}- defer tabResp.Body.Close()+ defer func() { _ = tabResp.Body.Close() }()if tabResp.StatusCode == 200 {var instanceTabs []map[string]any@@ -500,7 +494,7 @@ func (o *Orchestrator) handleTabList(w http.ResponseWriter, r *http.Request) {if err != nil {continue}- defer tabResp.Body.Close()+ defer func() { _ = tabResp.Body.Close() }()if tabResp.StatusCode == 200 {var instanceTabs []map[string]any@@ -540,7 +534,7 @@ func (o *Orchestrator) handleTabGet(w http.ResponseWriter, r *http.Request) {if err != nil {continue}- defer tabResp.Body.Close()+ defer func() { _ = tabResp.Body.Close() }()if tabResp.StatusCode == 200 {var tab map[string]any@@ -581,7 +575,7 @@ func (o *Orchestrator) handleTabClose(w http.ResponseWriter, r *http.Request) {if err != nil {continue}- defer closeResp.Body.Close()+ defer func() { _ = closeResp.Body.Close() }()if closeResp.StatusCode == 200 || closeResp.StatusCode == 204 {web.JSON(w, 200, map[string]string{"id": tabID, "status": "closed"})diff --git a/internal/orchestrator/ports.go b/internal/orchestrator/ports.goindex 9c6f96f6..0cd23871 100644--- a/internal/orchestrator/ports.go+++ b/internal/orchestrator/ports.go@@ -108,6 +108,6 @@ func isPortAvailableInt(port int) bool {if err != nil {return false}- listener.Close()+ _ = listener.Close()return true}diff --git a/scripts/update-api-reference.go b/scripts/update-api-reference.goindex 70e0dde6..64e996b3 100644--- a/scripts/update-api-reference.go+++ b/scripts/update-api-reference.go@@ -7,7 +7,6 @@ import ("go/ast""go/parser""go/token"- "io/ioutil""log""os""regexp"@@ -91,7 +90,7 @@ func main() {log.Fatalf("Error marshaling JSON: %v", err)}- err = ioutil.WriteFile(outputPath, append(data, '\n'), 0644)+ err = os.WriteFile(outputPath, append(data, '\n'), 0644)if err != nil {log.Fatalf("Error writing file: %v", err)}@@ -137,7 +136,7 @@ func generateEndpoints() []Endpoint {func readExistingReference() APIReference {path := "docs/references/api-reference.json"- data, err := ioutil.ReadFile(path)+ data, err := os.ReadFile(path)if err != nil {fmt.Printf("Could not read existing file (%v), starting fresh\n", err)return APIReference{