Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: resolve go vet copylocks and unchecked errors in scheduler

Yash Jadhav16697cc1cf4e
diff --git a/internal/scheduler/handlers.go b/internal/scheduler/handlers.go
index 024fdf4a..6da6232e 100644
--- a/internal/scheduler/handlers.go
+++ b/internal/scheduler/handlers.go
@@ -103,7 +103,7 @@ func (s *Scheduler) handleList(w http.ResponseWriter, r *http.Request) {
tasks := s.ListTasks(agentID, states)
if tasks == nil {
- tasks = []Task{}
+ tasks = []*Task{}
}
web.JSON(w, 200, map[string]any{"tasks": tasks, "count": len(tasks)})
}
diff --git a/internal/scheduler/handlers_test.go b/internal/scheduler/handlers_test.go
index d2aa8a35..594a27bd 100644
--- a/internal/scheduler/handlers_test.go
+++ b/internal/scheduler/handlers_test.go
@@ -13,7 +13,9 @@ func setupHandlerTest(t *testing.T) (*Scheduler, *http.ServeMux, *httptest.Serve
executor := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
- json.NewEncoder(w).Encode(map[string]bool{"success": true})
+ if err := json.NewEncoder(w).Encode(map[string]bool{"success": true}); err != nil {
+ t.Errorf("encode failed: %v", err)
+ }
}))
parts := strings.Split(executor.URL, ":")
@@ -46,7 +48,9 @@ func TestHandlerSubmit(t *testing.T) {
}
var resp map[string]any
- json.Unmarshal(w.Body.Bytes(), &resp)
+ if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
+ t.Fatalf("unmarshal failed: %v", err)
+ }
if resp["taskId"] == nil {
t.Error("response should contain taskId")
}
@@ -90,9 +94,12 @@ func TestHandlerGet(t *testing.T) {
s, mux, executor := setupHandlerTest(t)
defer executor.Close()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1", Action: "click", TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
req := httptest.NewRequest("GET", "/tasks/"+task.ID, nil)
w := httptest.NewRecorder()
@@ -104,7 +111,9 @@ func TestHandlerGet(t *testing.T) {
}
var resp map[string]any
- json.Unmarshal(w.Body.Bytes(), &resp)
+ if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
+ t.Fatalf("unmarshal failed: %v", err)
+ }
if resp["taskId"] != task.ID {
t.Errorf("expected task ID %s, got %v", task.ID, resp["taskId"])
}
@@ -128,9 +137,12 @@ func TestHandlerCancel(t *testing.T) {
s, mux, executor := setupHandlerTest(t)
defer executor.Close()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1", Action: "click", TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
req := httptest.NewRequest("POST", "/tasks/"+task.ID+"/cancel", nil)
w := httptest.NewRecorder()
@@ -160,8 +172,12 @@ func TestHandlerList(t *testing.T) {
s, mux, executor := setupHandlerTest(t)
defer executor.Close()
- s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"})
- s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"})
+ if _, err := s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
+ if _, err := s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
req := httptest.NewRequest("GET", "/tasks", nil)
w := httptest.NewRecorder()
@@ -172,7 +188,9 @@ func TestHandlerList(t *testing.T) {
}
var resp map[string]any
- json.Unmarshal(w.Body.Bytes(), &resp)
+ if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
+ t.Fatalf("unmarshal failed: %v", err)
+ }
if resp["count"] == nil {
t.Error("response should contain count")
}
@@ -182,8 +200,12 @@ func TestHandlerListWithFilters(t *testing.T) {
s, mux, executor := setupHandlerTest(t)
defer executor.Close()
- s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"})
- s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"})
+ if _, err := s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
+ if _, err := s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
req := httptest.NewRequest("GET", "/tasks?agentId=a1&state=queued", nil)
w := httptest.NewRecorder()
@@ -194,7 +216,9 @@ func TestHandlerListWithFilters(t *testing.T) {
}
var resp map[string]any
- json.Unmarshal(w.Body.Bytes(), &resp)
+ if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
+ t.Fatalf("unmarshal failed: %v", err)
+ }
count := int(resp["count"].(float64))
if count != 1 {
t.Errorf("expected 1 filtered task, got %d", count)
diff --git a/internal/scheduler/queue_test.go b/internal/scheduler/queue_test.go
index 0e0f4851..d45f43f0 100644
--- a/internal/scheduler/queue_test.go
+++ b/internal/scheduler/queue_test.go
@@ -36,8 +36,12 @@ func TestQueueEnqueueDequeue(t *testing.T) {
func TestQueueGlobalLimit(t *testing.T) {
q := NewTaskQueue(2, 10)
- q.Enqueue(&Task{ID: "t1", AgentID: "a1", CreatedAt: time.Now()})
- q.Enqueue(&Task{ID: "t2", AgentID: "a1", CreatedAt: time.Now()})
+ if _, err := q.Enqueue(&Task{ID: "t1", AgentID: "a1", CreatedAt: time.Now()}); err != nil {
+ t.Fatalf("enqueue failed: %v", err)
+ }
+ if _, err := q.Enqueue(&Task{ID: "t2", AgentID: "a1", CreatedAt: time.Now()}); err != nil {
+ t.Fatalf("enqueue failed: %v", err)
+ }
_, err := q.Enqueue(&Task{ID: "t3", AgentID: "a1", CreatedAt: time.Now()})
if err == nil {
t.Error("should reject when global limit reached")
@@ -47,8 +51,12 @@ func TestQueueGlobalLimit(t *testing.T) {
func TestQueuePerAgentLimit(t *testing.T) {
q := NewTaskQueue(100, 2)
- q.Enqueue(&Task{ID: "t1", AgentID: "a1", CreatedAt: time.Now()})
- q.Enqueue(&Task{ID: "t2", AgentID: "a1", CreatedAt: time.Now()})
+ if _, err := q.Enqueue(&Task{ID: "t1", AgentID: "a1", CreatedAt: time.Now()}); err != nil {
+ t.Fatalf("enqueue failed: %v", err)
+ }
+ if _, err := q.Enqueue(&Task{ID: "t2", AgentID: "a1", CreatedAt: time.Now()}); err != nil {
+ t.Fatalf("enqueue failed: %v", err)
+ }
_, err := q.Enqueue(&Task{ID: "t3", AgentID: "a1", CreatedAt: time.Now()})
if err == nil {
t.Error("should reject when per-agent limit reached")
diff --git a/internal/scheduler/results.go b/internal/scheduler/results.go
index 2f70b570..d0309d24 100644
--- a/internal/scheduler/results.go
+++ b/internal/scheduler/results.go
@@ -52,7 +52,7 @@ func (rs *ResultStore) Stop() {
func (rs *ResultStore) Store(t *Task) {
snap := t.Snapshot()
rs.mu.Lock()
- rs.tasks[snap.ID] = &snap
+ rs.tasks[snap.ID] = snap
rs.mu.Unlock()
}
@@ -64,7 +64,7 @@ func (rs *ResultStore) Get(taskID string) *Task {
}
// List returns all stored tasks, optionally filtered.
-func (rs *ResultStore) List(agentID string, states []TaskState) []Task {
+func (rs *ResultStore) List(agentID string, states []TaskState) []*Task {
rs.mu.RLock()
defer rs.mu.RUnlock()
@@ -73,7 +73,7 @@ func (rs *ResultStore) List(agentID string, states []TaskState) []Task {
stateSet[s] = true
}
- var out []Task
+ var out []*Task
for _, t := range rs.tasks {
if agentID != "" && t.AgentID != agentID {
continue
@@ -81,7 +81,7 @@ func (rs *ResultStore) List(agentID string, states []TaskState) []Task {
if len(stateSet) > 0 && !stateSet[t.State] {
continue
}
- out = append(out, *t)
+ out = append(out, t.Snapshot())
}
return out
}
diff --git a/internal/scheduler/scheduler.go b/internal/scheduler/scheduler.go
index ef4d5b71..13785e99 100644
--- a/internal/scheduler/scheduler.go
+++ b/internal/scheduler/scheduler.go
@@ -238,7 +238,7 @@ func (s *Scheduler) Cancel(taskID string) error {
}
// ListTasks returns tasks matching the given filters.
-func (s *Scheduler) ListTasks(agentID string, states []TaskState) []Task {
+func (s *Scheduler) ListTasks(agentID string, states []TaskState) []*Task {
return s.results.List(agentID, states)
}
diff --git a/internal/scheduler/scheduler_test.go b/internal/scheduler/scheduler_test.go
index 0b48d318..22f19057 100644
--- a/internal/scheduler/scheduler_test.go
+++ b/internal/scheduler/scheduler_test.go
@@ -28,7 +28,9 @@ func newTestScheduler(t *testing.T) (*Scheduler, *httptest.Server) {
// Mock executor that returns success.
executor := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
- json.NewEncoder(w).Encode(map[string]bool{"success": true})
+ if err := json.NewEncoder(w).Encode(map[string]bool{"success": true}); err != nil {
+ t.Errorf("encode failed: %v", err)
+ }
}))
// Extract port from executor URL.
@@ -120,11 +122,14 @@ func TestSchedulerCancel_Queued(t *testing.T) {
s, executor := newTestScheduler(t)
defer executor.Close()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1",
Action: "click",
TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
if err := s.Cancel(task.ID); err != nil {
t.Fatalf("cancel failed: %v", err)
@@ -152,8 +157,12 @@ func TestSchedulerListTasks(t *testing.T) {
s, executor := newTestScheduler(t)
defer executor.Close()
- s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"})
- s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"})
+ if _, err := s.Submit(SubmitRequest{AgentID: "a1", Action: "click", TabID: "tab-1"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
+ if _, err := s.Submit(SubmitRequest{AgentID: "a2", Action: "navigate", TabID: "tab-2"}); err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
all := s.ListTasks("", nil)
if len(all) < 2 {
@@ -169,7 +178,9 @@ func TestSchedulerListTasks(t *testing.T) {
func TestSchedulerDispatchAndComplete(t *testing.T) {
executor := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
- json.NewEncoder(w).Encode(map[string]bool{"success": true})
+ if err := json.NewEncoder(w).Encode(map[string]bool{"success": true}); err != nil {
+ t.Errorf("encode failed: %v", err)
+ }
}))
defer executor.Close()
@@ -219,7 +230,9 @@ func TestSchedulerDispatchAndComplete(t *testing.T) {
func TestSchedulerDispatchFailure(t *testing.T) {
executor := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(500)
- fmt.Fprint(w, `{"error":"internal"}`)
+ if _, err := fmt.Fprint(w, `{"error":"internal"}`); err != nil {
+ t.Errorf("fprint failed: %v", err)
+ }
}))
defer executor.Close()
@@ -233,11 +246,14 @@ func TestSchedulerDispatchFailure(t *testing.T) {
s.Start()
defer s.Stop()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1",
Action: "click",
TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
deadline := time.After(5 * time.Second)
for {
@@ -266,11 +282,14 @@ func TestSchedulerResolverError(t *testing.T) {
s.Start()
defer s.Stop()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1",
Action: "click",
TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
deadline := time.After(5 * time.Second)
for {
@@ -305,11 +324,14 @@ func TestSchedulerStopCancelsQueued(t *testing.T) {
s, executor := newTestScheduler(t)
defer executor.Close()
- task, _ := s.Submit(SubmitRequest{
+ task, err := s.Submit(SubmitRequest{
AgentID: "a1",
Action: "click",
TabID: "tab-1",
})
+ if err != nil {
+ t.Fatalf("submit failed: %v", err)
+ }
s.Stop()
diff --git a/internal/scheduler/task.go b/internal/scheduler/task.go
index 92c8a1f3..a35a6a94 100644
--- a/internal/scheduler/task.go
+++ b/internal/scheduler/task.go
@@ -101,10 +101,10 @@ func (t *Task) GetState() TaskState {
}
// Snapshot returns a read-consistent copy of the task for serialization.
-func (t *Task) Snapshot() Task {
+func (t *Task) Snapshot() *Task {
t.mu.RLock()
defer t.mu.RUnlock()
- return Task{
+ return &Task{
ID: t.ID,
AgentID: t.AgentID,
Action: t.Action,