Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor: fold the address-change query into applyServerAddressFlags

Luigi Agosti19e4826004ff
diff --git a/cmd/pinchtab/cmd_server.go b/cmd/pinchtab/cmd_server.go
index e8450154..e075bc43 100644
--- a/cmd/pinchtab/cmd_server.go
+++ b/cmd/pinchtab/cmd_server.go
@@ -32,7 +32,7 @@ var serverCmd = &cobra.Command{
bind, _ := cmd.Flags().GetString("bind")
port, _ := cmd.Flags().GetString("port")
- addressChanged := detachedAddressChanged(cfg, bind, port)
+ addressChanged := applyServerAddressFlags(cfg, bind, port)
yolo, _ := cmd.Flags().GetBool("yolo")
if yolo {
@@ -89,22 +89,15 @@ var serverCmd = &cobra.Command{
},
}
-// applyServerAddressFlags applies the --bind/--port overrides, mirroring the
-// bridge's precedence: a non-empty flag wins over config, an omitted one leaves
-// the configured value in place.
-func applyServerAddressFlags(cfg *config.RuntimeConfig, bind, port string) {
+func applyServerAddressFlags(cfg *config.RuntimeConfig, bind, port string) bool {
+ configuredBind, configuredPort := cfg.Bind, cfg.Port
if v := strings.TrimSpace(bind); v != "" {
cfg.Bind = v
}
if v := strings.TrimSpace(port); v != "" {
cfg.Port = v
}
-}
-
-func detachedAddressChanged(cfg *config.RuntimeConfig, bind, port string) bool {
- daemonBind, daemonPort := cfg.Bind, cfg.Port
- applyServerAddressFlags(cfg, bind, port)
- return cfg.Bind != daemonBind || cfg.Port != daemonPort
+ return cfg.Bind != configuredBind || cfg.Port != configuredPort
}
// resolveLogLevel settles a run's threshold from the only inputs that carry it, in
diff --git a/cmd/pinchtab/cmd_server_background_test.go b/cmd/pinchtab/cmd_server_background_test.go
index 7ceed38f..dd8670cb 100644
--- a/cmd/pinchtab/cmd_server_background_test.go
+++ b/cmd/pinchtab/cmd_server_background_test.go
@@ -39,7 +39,7 @@ func TestDetachedDaemonOwnershipTreatsUnsupportedOSAsNotInstalled(t *testing.T)
}
}
-func TestDetachedAddressChanged(t *testing.T) {
+func TestApplyServerAddressFlagsReportsAddressChange(t *testing.T) {
cases := []struct {
name string
bind, port string
@@ -57,8 +57,8 @@ func TestDetachedAddressChanged(t *testing.T) {
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
cfg := &config.RuntimeConfig{Bind: tc.bind, Port: tc.port}
- if got := detachedAddressChanged(cfg, tc.flagBind, tc.flagPort); got != tc.want {
- t.Fatalf("detachedAddressChanged() = %v, want %v", got, tc.want)
+ if got := applyServerAddressFlags(cfg, tc.flagBind, tc.flagPort); got != tc.want {
+ t.Fatalf("applyServerAddressFlags() changed = %v, want %v", got, tc.want)
}
})
}