High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
fix: probe the local server before the bare banner reports its state
Luigi Agosti1fe51bd9bc2c
diff --git a/cmd/pinchtab/root_hints.go b/cmd/pinchtab/root_hints.goindex 19138fc5..3906abf2 100644--- a/cmd/pinchtab/root_hints.go+++ b/cmd/pinchtab/root_hints.go@@ -10,19 +10,11 @@ import ()// printAgentHints renders the bare-landing banner for `pinchtab` with no-// arguments. It intentionally does NOT probe localhost: running the bare-// command just to read help/next-step output must not block on a stopped or-// firewalled local server. The banner reflects the on-disk config as the-// "stopped" state; use printAgentHintsWithHealth when live server status is-// required.+// arguments. The probe is bounded by fetchHealthSnapshot's timeout: a live+// listener answers in single-digit milliseconds and a stopped one refuses the+// loopback connect immediately, so only a firewalled port pays the ceiling —+// cheaper than the banner asserting a server state it never checked.func printAgentHints(cfg *config.RuntimeConfig) {- renderAgentHints(os.Stdout, projectAgentStatus(cfg, nil, healthSnapshotStopped))-}--// printAgentHintsWithHealth probes localhost and renders the banner with live-// server status. Used by status/health-style paths that genuinely need the-// probe.-func printAgentHintsWithHealth(cfg *config.RuntimeConfig) {snap, state := fetchHealthSnapshot(cfg.Port)renderAgentHints(os.Stdout, projectAgentStatus(cfg, snap, state))}diff --git a/cmd/pinchtab/root_test.go b/cmd/pinchtab/root_test.goindex 8a0bdffd..4c7734c0 100644--- a/cmd/pinchtab/root_test.go+++ b/cmd/pinchtab/root_test.go@@ -78,7 +78,7 @@ func TestPrintAgentHintsDoesNotTreatAuthFailureAsRunning(t *testing.T) {cfg.Token = "wrong-token"output := captureStdout(t, func() {- printAgentHintsWithHealth(cfg)+ printAgentHints(cfg)})if !strings.Contains(output, "protected listener") {t.Fatalf("expected protected listener status, got\n%s", output)@@ -88,7 +88,7 @@ func TestPrintAgentHintsDoesNotTreatAuthFailureAsRunning(t *testing.T) {}}-func TestPrintAgentHintsDoesNotProbeHealth(t *testing.T) {+func TestPrintAgentHintsReportsALiveListenerAsRunning(t *testing.T) {var probed boolsrv := newLocalhostHealthServerWithHandler(t, func(w http.ResponseWriter, r *http.Request) {probed = true@@ -107,11 +107,73 @@ func TestPrintAgentHintsDoesNotProbeHealth(t *testing.T) {output := captureStdout(t, func() {printAgentHints(cfg)})- if probed {- t.Fatal("bare-help path probed localhost; it must not contact the server")+ if !probed {+ t.Fatal("bare banner did not probe localhost, so it can only be guessing the server state")+ }+ if strings.Contains(output, string(healthSnapshotStopped)) {+ t.Fatalf("bare banner reported %q while a listener was answering on the configured port\n%s", healthSnapshotStopped, output)+ }+ if !strings.Contains(output, string(healthSnapshotRunning)) {+ t.Fatalf("expected %q status, got\n%s", healthSnapshotRunning, output)+ }+}++func TestPrintAgentHintsNeverOffersToStartAListeningServer(t *testing.T) {+ for _, tc := range []struct {+ name string+ status int+ body string+ }{+ {"running", http.StatusOK, `{"status":"ok","mode":"dashboard","version":"dev"}`},+ {"protected listener", http.StatusUnauthorized, `{"code":"missing_token","message":"unauthorized"}`},+ {"unhealthy", http.StatusInternalServerError, `{"status":"error"}`},+ {"foreign listener", http.StatusOK, `not json`},+ } {+ t.Run(tc.name, func(t *testing.T) {+ srv := newLocalhostHealthServer(t, tc.status, tc.body)+ defer srv.Close()++ _, port, err := net.SplitHostPort(srv.Listener.Addr().String())+ if err != nil {+ t.Fatalf("SplitHostPort() error = %v", err)+ }+ cfg := testRuntimeConfig()+ cfg.Port = port++ output := captureStdout(t, func() {+ printAgentHints(cfg)+ })+ if strings.Contains(output, "# start the server") {+ t.Fatalf("banner told the user to start a server that is already listening\n%s", output)+ }+ })}+}++func TestPrintAgentHintsReportsAStoppedServerWhenNothingListens(t *testing.T) {+ listener, err := net.Listen("tcp", "localhost:0")+ if err != nil {+ t.Fatalf("Listen() error = %v", err)+ }+ _, port, err := net.SplitHostPort(listener.Addr().String())+ if err != nil {+ t.Fatalf("SplitHostPort() error = %v", err)+ }+ if err := listener.Close(); err != nil {+ t.Fatalf("Close() error = %v", err)+ }++ cfg := testRuntimeConfig()+ cfg.Port = port++ output := captureStdout(t, func() {+ printAgentHints(cfg)+ })if !strings.Contains(output, string(healthSnapshotStopped)) {- t.Fatalf("expected %q status without probing, got\n%s", healthSnapshotStopped, output)+ t.Fatalf("expected %q status with nothing listening, got\n%s", healthSnapshotStopped, output)+ }+ if !strings.Contains(output, "# start the server") {+ t.Fatalf("a stopped server should still be offered a start hint\n%s", output)}}