High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
test(authn): harden client identity header census (PIN-309)
Luigi Agosti2756fa7fea21
diff --git a/internal/authn/client_ip_test.go b/internal/authn/client_ip_test.goindex 5b76367a..a15eb06d 100644--- a/internal/authn/client_ip_test.go+++ b/internal/authn/client_ip_test.go@@ -3,6 +3,7 @@ package authnimport ("context""net/http/httptest"+ "regexp""sort""strings""testing"@@ -83,29 +84,71 @@ func TestClientIPFallsBackToThePeerWhenNothingResolvedOne(t *testing.T) {// clientIdentityHeaders are the headers a caller can set to claim an identity.// Exactly one file may read one: a second reader is a second trust decision, and// the two drift the moment trustProxyHeaders means different things to each.-var clientIdentityHeaders = []string{`"X-Forwarded-For"`, `"X-Real-Ip"`, `"X-Real-IP"`, `"X-Client-Ip"`}--func TestOneFileReadsAForwardingHeaderForClientIdentity(t *testing.T) {- files := srccensus.Tree(t, "../..", 200)+var clientIdentityHeaders = []string{+ "X-Forwarded-For",+ "X-Real-Ip",+ "X-Client-Ip",+ "Forwarded",+ "CF-Connecting-IP",+ "True-Client-IP",+ "X-Cluster-Client-IP",+ "Fastly-Client-IP",+}+func clientIdentityHeaderReaders(files []srccensus.SourceFile) []string {var readers []stringfor _, file := range files {for _, header := range clientIdentityHeaders {- if strings.Contains(file.Text, header) {- readers = append(readers, file.Name+" ("+header+")")- break+ getHeader := regexp.MustCompile(`(?i)\.Header\.Get\(\s*"` + regexp.QuoteMeta(header) + `"\s*\)`)+ if getHeader.MatchString(file.Text) {+ readers = append(readers, file.Name+` ("`+header+`")`)}}}-- want := []string{`internal/authn/client_ip.go ("X-Forwarded-For")`}sort.Strings(readers)+ return readers+}++func TestOneFileReadsAForwardingHeaderForClientIdentity(t *testing.T) {+ files := srccensus.Tree(t, "../..", 200)+ readers := clientIdentityHeaderReaders(files)++ want := []string{+ `internal/authn/client_ip.go ("Forwarded")`,+ `internal/authn/client_ip.go ("X-Forwarded-For")`,+ `internal/authn/forwarded.go ("Forwarded")`,+ }if strings.Join(readers, "\n ") != strings.Join(want, "\n ") {- t.Fatalf("client-identity header readers are:\n %s\nwant exactly:\n %s\nresolve the identity in ResolveClientIP and read it back with ClientIP rather than adding a second reader",+ t.Fatalf("client-identity header readers are:\n %s\nwant exactly:\n %s\na client-identity header is any header in clientIdentityHeaders; add new spellings to that list, never work around it, and resolve identity in ResolveClientIP rather than adding a second reader",strings.Join(readers, "\n "), strings.Join(want, "\n "))}}+func TestClientIdentityHeaderCensusCatchesEverySpellingAndExcludesSchemeHeaders(t *testing.T) {+ for _, header := range clientIdentityHeaders {+ t.Run(header, func(t *testing.T) {+ files := []srccensus.SourceFile{{+ Name: "internal/handlers/planted_reader.go",+ Text: `package handlers; func planted(r *http.Request) { _ = r.Header.Get("` + strings.ToLower(header) + `") }`,+ }}+ readers := clientIdentityHeaderReaders(files)+ if len(readers) != 1 || !strings.Contains(readers[0], header) {+ t.Fatalf("a planted case-insensitive reader for %q escaped the census: %v", header, readers)+ }+ })+ }++ for _, header := range []string{"X-Forwarded-Proto", "X-Forwarded-Host"} {+ files := []srccensus.SourceFile{{+ Name: "internal/handlers/non_identity_reader.go",+ Text: `package handlers; func planted(r *http.Request) { _ = r.Header.Get("` + header + `") }`,+ }}+ if readers := clientIdentityHeaderReaders(files); len(readers) != 0 {+ t.Fatalf("%q carries connection metadata, not client identity, but the census matched it: %v", header, readers)+ }+ }+}+func TestOnlyTheClientIPResolverReadsTheForwardedForDirective(t *testing.T) {pkg := srccensus.Load(t, ".", 5)