Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix(handlers): list the valid action kinds in a stable sorted order on an unknown-kind refusal (PIN-007)

Luigi Agosti2b272401e077
diff --git a/internal/handlers/action_unknown_kind_test.go b/internal/handlers/action_unknown_kind_test.go
index 566a9507..cf79a45f 100644
--- a/internal/handlers/action_unknown_kind_test.go
+++ b/internal/handlers/action_unknown_kind_test.go
@@ -63,6 +63,32 @@ func TestUnknownActionKindAnswersOneCodedRefusalFromEitherPath(t *testing.T) {
}
}
+func TestUnknownActionKindListsTheValidKindsInAStableOrder(t *testing.T) {
+ available := []string{"type", "click", "hover"}
+ mb := &mockBridge{availableActions: available}
+ h := New(mb, &config.RuntimeConfig{ActionTimeout: time.Second}, nil, nil, nil)
+ w := postAction(t, h, `{"kind":"zap","tabId":"tab1"}`)
+ var body struct {
+ Error string `json:"error"`
+ Details struct {
+ ValidKinds []string `json:"validKinds"`
+ } `json:"details"`
+ }
+ if err := json.Unmarshal(w.Body.Bytes(), &body); err != nil {
+ t.Fatalf("decode: %v: %s", err, w.Body.String())
+ }
+ want := []string{"click", "hover", "type"}
+ if strings.Join(body.Details.ValidKinds, ",") != strings.Join(want, ",") {
+ t.Fatalf("validKinds = %v, want %v", body.Details.ValidKinds, want)
+ }
+ if !strings.HasSuffix(body.Error, "valid values: click, hover, type") {
+ t.Fatalf("message %q does not list the kinds sorted", body.Error)
+ }
+ if strings.Join(available, ",") != "type,click,hover" {
+ t.Fatalf("the bridge's own list was reordered in place: %v", available)
+ }
+}
+
func TestAnUnwrappedUnknownActionMessageIsNoLongerRecoveredByPrefix(t *testing.T) {
mb := &mockBridge{availableActions: []string{}, executeActionErr: fmt.Errorf("unknown action: zap")}
h := New(mb, &config.RuntimeConfig{ActionTimeout: time.Second}, nil, nil, nil)
diff --git a/internal/handlers/actions.go b/internal/handlers/actions.go
index 0ed53b36..4b233376 100644
--- a/internal/handlers/actions.go
+++ b/internal/handlers/actions.go
@@ -715,8 +715,10 @@ func (h *Handlers) writeUnknownActionKind(w http.ResponseWriter, kind string) {
message := fmt.Sprintf("%s: %s", bridge.ErrUnknownAction, kind)
var details map[string]any
if available := h.Bridge.AvailableActions(); len(available) > 0 {
- message += " - valid values: " + strings.Join(available, ", ")
- details = map[string]any{"validKinds": available}
+ kinds := append([]string(nil), available...)
+ sort.Strings(kinds)
+ message += " - valid values: " + strings.Join(kinds, ", ")
+ details = map[string]any{"validKinds": kinds}
}
httpx.ErrorCode(w, http.StatusBadRequest, "unknown_action_kind", message, false, details)
}