Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor(cli): migrate snap command to proper cobra flags + add diff/selector tests

Bosch466048eabc64
diff --git a/cmd/pinchtab/cmd_cli.go b/cmd/pinchtab/cmd_cli.go
index d0c60336..d250316c 100644
--- a/cmd/pinchtab/cmd_cli.go
+++ b/cmd/pinchtab/cmd_cli.go
@@ -42,7 +42,7 @@ var snapCmd = &cobra.Command{
Run: func(cmd *cobra.Command, args []string) {
cfg := config.Load()
runCLIWith(cfg, func(client *http.Client, base, token string) {
- browseractions.Snapshot(client, base, token, args)
+ browseractions.SnapshotWithFlags(client, base, token, cmd)
})
},
}
@@ -287,7 +287,7 @@ func init() {
// Disable cobra flag parsing for commands that parse flags manually.
// FParseErrWhitelist silently swallows unknown flags (dropping them from args),
// so we must disable cobra's parser entirely and let the action code handle flags.
- snapCmd.DisableFlagParsing = true
+ // snapCmd now uses proper cobra flags (see below)
// screenshotCmd now uses proper cobra flags (see below)
// pdfCmd now uses proper cobra flags (see below)
// findCmd now uses proper cobra flags (see below)
@@ -300,6 +300,15 @@ func init() {
uploadCmd.Flags().StringP("selector", "s", "", "CSS selector for file input")
downloadCmd.Flags().StringP("output", "o", "", "Save downloaded file to path")
+ snapCmd.Flags().BoolP("interactive", "i", false, "Filter interactive elements only")
+ snapCmd.Flags().BoolP("compact", "c", false, "Compact output format")
+ snapCmd.Flags().Bool("text", false, "Text output format")
+ snapCmd.Flags().BoolP("diff", "d", false, "Show diff from previous snapshot")
+ snapCmd.Flags().StringP("selector", "s", "", "CSS selector to scope snapshot")
+ snapCmd.Flags().String("max-tokens", "", "Maximum token budget")
+ snapCmd.Flags().String("depth", "", "Tree depth limit")
+ snapCmd.Flags().String("tab", "", "Tab ID")
+
screenshotCmd.Flags().StringP("output", "o", "", "Save screenshot to file path")
screenshotCmd.Flags().StringP("quality", "q", "", "JPEG quality (0-100)")
screenshotCmd.Flags().String("tab", "", "Tab ID")
diff --git a/internal/cli/actions/actions_snapshot.go b/internal/cli/actions/actions_snapshot.go
index 84c03736..b168685e 100644
--- a/internal/cli/actions/actions_snapshot.go
+++ b/internal/cli/actions/actions_snapshot.go
@@ -2,6 +2,7 @@ package actions
import (
"github.com/pinchtab/pinchtab/internal/cli/apiclient"
+ "github.com/spf13/cobra"
"net/http"
"net/url"
)
@@ -43,3 +44,33 @@ func Snapshot(client *http.Client, base, token string, args []string) {
result := apiclient.DoGet(client, base, token, "/snapshot", params)
apiclient.SuggestNextAction("snapshot", result)
}
+
+func SnapshotWithFlags(client *http.Client, base, token string, cmd *cobra.Command) {
+ params := url.Values{}
+ if v, _ := cmd.Flags().GetBool("interactive"); v {
+ params.Set("filter", "interactive")
+ }
+ if v, _ := cmd.Flags().GetBool("compact"); v {
+ params.Set("format", "compact")
+ }
+ if v, _ := cmd.Flags().GetBool("text"); v {
+ params.Set("format", "text")
+ }
+ if v, _ := cmd.Flags().GetBool("diff"); v {
+ params.Set("diff", "true")
+ }
+ if v, _ := cmd.Flags().GetString("selector"); v != "" {
+ params.Set("selector", v)
+ }
+ if v, _ := cmd.Flags().GetString("max-tokens"); v != "" {
+ params.Set("maxTokens", v)
+ }
+ if v, _ := cmd.Flags().GetString("depth"); v != "" {
+ params.Set("depth", v)
+ }
+ if v, _ := cmd.Flags().GetString("tab"); v != "" {
+ params.Set("tabId", v)
+ }
+ result := apiclient.DoGet(client, base, token, "/snapshot", params)
+ apiclient.SuggestNextAction("snapshot", result)
+}
diff --git a/tests/e2e/scenarios-cli/26-snap-flags.sh b/tests/e2e/scenarios-cli/26-snap-flags.sh
index f44f476e..b4100845 100755
--- a/tests/e2e/scenarios-cli/26-snap-flags.sh
+++ b/tests/e2e/scenarios-cli/26-snap-flags.sh
@@ -38,3 +38,21 @@ start_test "pinchtab snap --max-tokens 100"
pt_ok snap --max-tokens 100
end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab snap --diff"
+
+pt_ok snap
+assert_exit_ok "first snapshot"
+pt_ok snap --diff
+assert_exit_ok "snap diff mode"
+
+end_test
+
+# ─────────────────────────────────────────────────────────────────
+start_test "pinchtab snap -s 'body'"
+
+pt_ok snap -s "body"
+assert_exit_ok "snap with selector"
+
+end_test