Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: synchronize browsersession accessors and make session persist atomic

Luigi Agosti519467d24aa8
diff --git a/internal/browsersession/session.go b/internal/browsersession/session.go
index bc810e5a..d6f9cef6 100644
--- a/internal/browsersession/session.go
+++ b/internal/browsersession/session.go
@@ -168,6 +168,8 @@ func (m *Manager) MaxLifetime() time.Duration {
if m == nil {
return DefaultSessionMaxLifetime
}
+ m.mu.Lock()
+ defer m.mu.Unlock()
return m.maxLifetime
}
@@ -175,6 +177,8 @@ func (m *Manager) IdleTimeout() time.Duration {
if m == nil {
return DefaultSessionIdleTimeout
}
+ m.mu.Lock()
+ defer m.mu.Unlock()
return m.idleTimeout
}
@@ -182,6 +186,8 @@ func (m *Manager) ElevationWindow() time.Duration {
if m == nil {
return DefaultSessionElevationWindow
}
+ m.mu.Lock()
+ defer m.mu.Unlock()
return m.elevationWindow
}
@@ -190,15 +196,13 @@ func (m *Manager) UpdateConfig(cfg Config) {
return
}
- persistPath := strings.TrimSpace(cfg.PersistPath)
- persist := cfg.Persist && persistPath != ""
-
m.mu.Lock()
oldPath := m.persistPath
oldPersist := m.persist
m.applyConfigLocked(cfg)
m.pruneExpiredLocked(m.now())
m.saveLocked()
+ persist, persistPath := m.persist, m.persistPath
m.mu.Unlock()
if oldPersist && oldPath != "" && (!persist || oldPath != persistPath) {
@@ -341,9 +345,15 @@ func (m *Manager) saveLocked() {
if err := os.MkdirAll(filepath.Dir(m.persistPath), 0755); err != nil {
return
}
- if err := os.WriteFile(m.persistPath, data, 0600); err != nil {
+ // Atomic write: a torn file here fails to unmarshal on the next start and
+ // silently logs every dashboard user out.
+ tmpPath := m.persistPath + ".tmp"
+ if err := os.WriteFile(tmpPath, data, 0600); err != nil {
return
}
+ if err := os.Rename(tmpPath, m.persistPath); err != nil {
+ _ = os.Remove(tmpPath)
+ }
}
func randomSessionID() (string, error) {
diff --git a/internal/browsersession/session_race_test.go b/internal/browsersession/session_race_test.go
new file mode 100644
index 00000000..b16e4acd
--- /dev/null
+++ b/internal/browsersession/session_race_test.go
@@ -0,0 +1,67 @@
+package browsersession
+
+import (
+ "os"
+ "path/filepath"
+ "sync"
+ "testing"
+ "time"
+)
+
+// The duration accessors are read on the per-request auth path while the
+// dashboard config API can call UpdateConfig concurrently.
+func TestDurationAccessorsAreSynchronized(t *testing.T) {
+ m := NewManager(Config{IdleTimeout: time.Hour, MaxLifetime: time.Hour, ElevationWindow: time.Minute})
+
+ var wg sync.WaitGroup
+ wg.Add(2)
+ go func() {
+ defer wg.Done()
+ for i := 0; i < 500; i++ {
+ m.UpdateConfig(Config{
+ IdleTimeout: time.Duration(i+1) * time.Minute,
+ MaxLifetime: time.Duration(i+1) * time.Hour,
+ ElevationWindow: time.Duration(i+1) * time.Second,
+ })
+ }
+ }()
+ go func() {
+ defer wg.Done()
+ for i := 0; i < 500; i++ {
+ _ = m.MaxLifetime()
+ _ = m.IdleTimeout()
+ _ = m.ElevationWindow()
+ }
+ }()
+ wg.Wait()
+}
+
+// The persist file is written via a temp file + rename; the temp must never
+// survive a successful save.
+func TestPersistLeavesNoTempFile(t *testing.T) {
+ dir := t.TempDir()
+ path := filepath.Join(dir, "dashboard-auth-sessions.json")
+
+ mgr := NewManager(Config{
+ IdleTimeout: time.Hour,
+ MaxLifetime: time.Hour,
+ Persist: true,
+ PersistPath: path,
+ })
+ if _, err := mgr.Create("secret"); err != nil {
+ t.Fatalf("Create() error = %v", err)
+ }
+
+ entries, err := os.ReadDir(dir)
+ if err != nil {
+ t.Fatal(err)
+ }
+ for _, e := range entries {
+ if filepath.Ext(e.Name()) == ".tmp" {
+ t.Errorf("temp file %q left behind after save", e.Name())
+ }
+ }
+ if len(entries) != 1 {
+ t.Errorf("persist dir has %d entries, want 1", len(entries))
+ }
+}