Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor(cli): remove top-level close command

Bosch62ba4465cba8
diff --git a/cmd/pinchtab/cmd_cli.go b/cmd/pinchtab/cmd_cli.go
index 2f725869..d9fc240c 100644
--- a/cmd/pinchtab/cmd_cli.go
+++ b/cmd/pinchtab/cmd_cli.go
@@ -100,26 +100,6 @@ var openCmd = &cobra.Command{
},
}
-var closeCmd = &cobra.Command{
- Use: "close [tabId]",
- Short: "Close a tab",
- Args: cobra.MaximumNArgs(1),
- Run: func(cmd *cobra.Command, args []string) {
- cfg := config.Load()
- runCLIWith(cfg, func(client *http.Client, base, token string) {
- tabID, _ := cmd.Flags().GetString("tab")
- if len(args) > 0 {
- tabID = args[0]
- }
- if tabID == "" {
- fmt.Fprintln(os.Stderr, "error: specify a tab ID as argument or via --tab")
- os.Exit(1)
- }
- browseractions.TabClose(client, base, token, tabID)
- })
- },
-}
-
var tabsCmd = &cobra.Command{
Use: "tabs",
Short: "List or manage tabs",
@@ -308,7 +288,6 @@ var selectCmd = &cobra.Command{
func init() {
quickCmd.GroupID = "browser"
openCmd.GroupID = "browser"
- closeCmd.GroupID = "browser"
navCmd.GroupID = "browser"
snapCmd.GroupID = "browser"
clickCmd.GroupID = "browser"
@@ -409,7 +388,6 @@ func init() {
openCmd.Flags().Bool("block-ads", false, "Block ads")
openCmd.Flags().String("tab", "", "Tab ID")
- closeCmd.Flags().String("tab", "", "Tab ID")
navCmd.Flags().Bool("new-tab", false, "Open in new tab")
navCmd.Flags().Bool("block-images", false, "Block image loading")
@@ -427,7 +405,6 @@ func init() {
rootCmd.AddCommand(quickCmd)
rootCmd.AddCommand(openCmd)
- rootCmd.AddCommand(closeCmd)
rootCmd.AddCommand(navCmd)
rootCmd.AddCommand(snapCmd)
rootCmd.AddCommand(clickCmd)
diff --git a/tests/e2e/scenarios-cli/35-open-close.sh b/tests/e2e/scenarios-cli/35-open-close.sh
index e4757c4e..5794fadf 100755
--- a/tests/e2e/scenarios-cli/35-open-close.sh
+++ b/tests/e2e/scenarios-cli/35-open-close.sh
@@ -1,5 +1,5 @@
#!/bin/bash
-# 35-open-close.sh — CLI open/close commands
+# 35-open.sh — CLI open command + aliases
source "$(dirname "$0")/common.sh"
@@ -30,50 +30,6 @@ assert_output_contains "requires" "shows usage error"
end_test
-# ─────────────────────────────────────────────────────────────────
-start_test "pinchtab close <tabId>"
-
-# Open a tab to close
-pt_ok open --new-tab "${FIXTURES_URL}/index.html"
-TAB_ID=$(echo "$PT_OUT" | jq -r '.tabId // empty')
-
-if [ -n "$TAB_ID" ]; then
- pt_ok close "$TAB_ID"
- echo -e " ${GREEN}✓${NC} closed tab $TAB_ID"
- ((ASSERTIONS_PASSED++)) || true
-else
- echo -e " ${RED}✗${NC} could not get tab ID to close"
- ((ASSERTIONS_FAILED++)) || true
-fi
-
-end_test
-
-# ─────────────────────────────────────────────────────────────────
-start_test "pinchtab close --tab <tabId>"
-
-pt_ok open --new-tab "${FIXTURES_URL}/index.html"
-TAB_ID=$(echo "$PT_OUT" | jq -r '.tabId // empty')
-
-if [ -n "$TAB_ID" ]; then
- pt_ok close --tab "$TAB_ID"
- echo -e " ${GREEN}✓${NC} closed tab via --tab flag"
- ((ASSERTIONS_PASSED++)) || true
-else
- echo -e " ${RED}✗${NC} could not get tab ID to close"
- ((ASSERTIONS_FAILED++)) || true
-fi
-
-end_test
-
-# ─────────────────────────────────────────────────────────────────
-start_test "pinchtab close (no args, no --tab → error)"
-
-pt_fail close
-assert_output_contains "specify a tab ID" "requires tab ID"
-
-end_test
-
-# ─────────────────────────────────────────────────────────────────
# ─────────────────────────────────────────────────────────────────
start_test "pinchtab goto <url> (alias for open)"
@@ -93,11 +49,10 @@ assert_output_contains "tabId" "navigate works as alias"
end_test
# ─────────────────────────────────────────────────────────────────
-start_test "pinchtab nav shows deprecation notice"
+start_test "pinchtab nav <url> (deprecated alias)"
pt_ok nav "${FIXTURES_URL}/index.html"
-# Cobra prints deprecation to stderr, but output should still work
assert_output_json
-assert_output_contains "tabId" "nav still works as alias"
+assert_output_contains "tabId" "nav still works as deprecated alias"
end_test