Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor: remove CHROME_BIN env var, config-only for Chrome binary path

Bosch6ed86d284dac
diff --git a/cmd/pinchtab/cmd_cli.go b/cmd/pinchtab/cmd_cli.go
index 80074a85..81263296 100644
--- a/cmd/pinchtab/cmd_cli.go
+++ b/cmd/pinchtab/cmd_cli.go
@@ -83,7 +83,6 @@ ENVIRONMENT:
PINCHTAB_URL Server URL (default: http://127.0.0.1:9867)
PINCHTAB_TOKEN Auth token
PINCHTAB_PORT Server port (default: 9867)
- CHROME_BIN Chrome binary path
FLAGS (global, place before or after command):
--instance <id> Target a specific instance by ID (e.g., pinchtab nav --instance abc123 https://...)
diff --git a/docs/guides/docker.md b/docs/guides/docker.md
index 4a607197..51235332 100644
--- a/docs/guides/docker.md
+++ b/docs/guides/docker.md
@@ -101,11 +101,10 @@ For current runtime overrides, rely on:
- `PINCHTAB_BIND` — bind address (default: 127.0.0.1, overridden to 0.0.0.0 in managed-config containers)
- `PINCHTAB_PORT` — server port (default: 9867)
- `PINCHTAB_TOKEN` — auth token (prefer Docker secrets; see below)
-- `CHROME_BIN` — path to Chrome binary (auto-detected)
-Everything else should go in `config.json`.
+Everything else, including Chrome binary path, should go in `config.json`.
-In the bundled image, you usually do not need to set `PINCHTAB_BIND`, `PINCHTAB_PORT`, or `CHROME_BIN` manually unless you are overriding the generated config or replacing the browser binary. The managed-config entrypoint supplies `PINCHTAB_BIND=0.0.0.0` at runtime so Docker port publishing works without broadening the persisted config.
+In the bundled image, you usually do not need to set `PINCHTAB_BIND` or `PINCHTAB_PORT` manually. The managed-config entrypoint supplies `PINCHTAB_BIND=0.0.0.0` at runtime so Docker port publishing works without broadening the persisted config. To customize the Chrome binary path, use `config.json`.
### About `PINCHTAB_BIND=0.0.0.0` in Containers
diff --git a/internal/bridge/init.go b/internal/bridge/init.go
index 6e8b1b9c..40be3cde 100644
--- a/internal/bridge/init.go
+++ b/internal/bridge/init.go
@@ -282,9 +282,9 @@ func startChromeWithRecovery(parentCtx context.Context, cfg *config.RuntimeConfi
slog.Info(" fedora/rhel: sudo dnf install -y chromium")
slog.Info(" arch: sudo pacman -S chromium")
slog.Info(" macos: brew install chromium")
- slog.Info(" or set CHROME_BIN environment variable to chrome binary path")
+ slog.Info(" or set 'binary' in config.json to override the chrome binary path")
- return nil, nil, fmt.Errorf("chrome/chromium not found: please install chrome or chromium, or set CHROME_BIN environment variable")
+ return nil, nil, fmt.Errorf("chrome/chromium not found: please install chrome or chromium, or set 'binary' in config.json")
}
// Startup timeout: Chrome is running but did not announce its DevTools URL via
@@ -346,13 +346,13 @@ func startChromeWithRemoteAllocator(parentCtx context.Context, cfg *config.Runti
chromeBinary = findChromeBinary()
}
if chromeBinary == "" {
- return nil, nil, fmt.Errorf("chrome/chromium not found: please install chrome or chromium, or set CHROME_BIN environment variable")
+ return nil, nil, fmt.Errorf("chrome/chromium not found: please install chrome or chromium, or set 'binary' in config.json")
}
args := buildChromeArgs(cfg, debugPort)
slog.Debug("launching chrome directly", "binary", chromeBinary, "port", debugPort, "args", args)
- // #nosec G204 -- chromeBinary from CHROME_BIN env var, user config, or findChromeBinary() known system paths
+ // #nosec G204 -- chromeBinary from user config or findChromeBinary() known system paths
cmd := exec.Command(chromeBinary, args...)
cmd.Stdout = newPrefixedLogWriter(os.Stdout, "chrome stdout")
cmd.Stderr = newPrefixedLogWriter(os.Stderr, "chrome stderr")
diff --git a/internal/config/config.go b/internal/config/config.go
index 015fa785..9f328987 100644
--- a/internal/config/config.go
+++ b/internal/config/config.go
@@ -507,7 +507,7 @@ func Load() *RuntimeConfig {
BlockAds: false,
MaxTabs: 20,
MaxParallelTabs: 0,
- ChromeBinary: os.Getenv("CHROME_BIN"),
+ ChromeBinary: "", // Set via config.json only; env var CHROME_BIN removed
ChromeExtraFlags: "",
ExtensionPaths: nil,
UserAgent: "",
@@ -626,7 +626,7 @@ func applyFileConfig(cfg *RuntimeConfig, fc *FileConfig) {
if fc.Browser.ChromeVersion != "" {
cfg.ChromeVersion = fc.Browser.ChromeVersion
}
- if fc.Browser.ChromeBinary != "" && os.Getenv("CHROME_BIN") == "" {
+ if fc.Browser.ChromeBinary != "" {
cfg.ChromeBinary = fc.Browser.ChromeBinary
}
if fc.Browser.ChromeExtraFlags != "" {
diff --git a/internal/config/config_test.go b/internal/config/config_test.go
index 53ac6974..52914d7b 100644
--- a/internal/config/config_test.go
+++ b/internal/config/config_test.go
@@ -135,13 +135,11 @@ func TestLoadConfigEnvOverrides(t *testing.T) {
_ = os.Setenv("PINCHTAB_PORT", "1234")
_ = os.Setenv("PINCHTAB_BIND", "0.0.0.0")
_ = os.Setenv("PINCHTAB_TOKEN", "secret")
- _ = os.Setenv("CHROME_BIN", "/tmp/chrome")
defer func() {
_ = os.Unsetenv("PINCHTAB_CONFIG")
_ = os.Unsetenv("PINCHTAB_PORT")
_ = os.Unsetenv("PINCHTAB_BIND")
_ = os.Unsetenv("PINCHTAB_TOKEN")
- _ = os.Unsetenv("CHROME_BIN")
}()
cfg := Load()
@@ -154,9 +152,7 @@ func TestLoadConfigEnvOverrides(t *testing.T) {
if cfg.Token != "secret" {
t.Errorf("env Token = %v, want secret", cfg.Token)
}
- if cfg.ChromeBinary != "/tmp/chrome" {
- t.Errorf("env ChromeBinary = %v, want /tmp/chrome", cfg.ChromeBinary)
- }
+ // ChromeBinary is config-only, no longer available as env var
}
func TestPinchtabEnvTakesPrecedence(t *testing.T) {
@@ -616,7 +612,6 @@ func clearConfigEnvVars(t *testing.T) {
t.Helper()
envVars := []string{
"PINCHTAB_PORT", "PINCHTAB_BIND", "PINCHTAB_TOKEN", "PINCHTAB_CONFIG",
- "CHROME_BIN",
}
for _, v := range envVars {
_ = os.Unsetenv(v)
diff --git a/internal/orchestrator/orchestrator.go b/internal/orchestrator/orchestrator.go
index 882c2ce3..9191e017 100644
--- a/internal/orchestrator/orchestrator.go
+++ b/internal/orchestrator/orchestrator.go
@@ -309,9 +309,7 @@ func (o *Orchestrator) Launch(name, port string, headless bool, extensionPaths [
"PINCHTAB_PORT": port,
"PINCHTAB_CONFIG": childConfigPath,
}
- if o.runtimeCfg != nil && o.runtimeCfg.ChromeBinary != "" {
- envOverrides["CHROME_BIN"] = o.runtimeCfg.ChromeBinary
- }
+ // ChromeBinary is passed via config.json, not as env var
env := mergeEnvWithOverrides(filterEnvWithPrefixes(os.Environ(), "BRIDGE_", "PINCHTAB_"), envOverrides)
logBuf := newRingBuffer(256 * 1024)
diff --git a/tests/testutil/server.go b/tests/testutil/server.go
index 49783b20..f71f1e83 100644
--- a/tests/testutil/server.go
+++ b/tests/testutil/server.go
@@ -150,12 +150,7 @@ func StartServer(cfg ServerConfig) (*Server, error) {
"PINCHTAB_CONFIG="+filepath.Join(s.Dir, "config.json"), // Isolate from host config
)
- // Chrome binary from host (for CI environments)
- if bin := os.Getenv("CHROME_BIN"); bin != "" {
- env = append(env, "CHROME_BIN="+bin)
- } else if legacyBin := os.Getenv("CHROME_BINARY"); legacyBin != "" {
- env = append(env, "CHROME_BIN="+legacyBin)
- }
+ // Chrome binary is configured via config.json, not env vars
s.cmd = exec.Command(s.BinaryPath) // #nosec G204 -- BinaryPath is from os.MkdirTemp, not user input
s.cmd.Env = env