Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix(e2e-runner): servicesToBuild adds the pinchtab image-builder when only image-only variants are named (PIN-380)

Luigi Agosti87001bc04e8c
diff --git a/tests/tools/runner/internal/e2e/runner_test.go b/tests/tools/runner/internal/e2e/runner_test.go
index 64e17abc..ad521913 100644
--- a/tests/tools/runner/internal/e2e/runner_test.go
+++ b/tests/tools/runner/internal/e2e/runner_test.go
@@ -37,6 +37,11 @@ func TestServicesToBuildAddsOnlyTheRunnersThePlansExecute(t *testing.T) {
},
want: []string{"pinchtab", "pinchtab-secure", "fixtures", "runner-api", "runner-cli"},
},
+ {
+ name: "an image-only variant pulls in the pinchtab service that builds the shared image",
+ plans: []suitePlan{planWithServices(apiExtendedSuite(), "pinchtab-secure", "fixtures")},
+ want: []string{"pinchtab", "pinchtab-secure", "fixtures", "runner-api"},
+ },
} {
t.Run(tc.name, func(t *testing.T) {
got := servicesToBuild(tc.plans, fallback)
diff --git a/tests/tools/runner/internal/e2e/suite.go b/tests/tools/runner/internal/e2e/suite.go
index f5a71699..4a658d71 100644
--- a/tests/tools/runner/internal/e2e/suite.go
+++ b/tests/tools/runner/internal/e2e/suite.go
@@ -294,11 +294,21 @@ func servicesForPlans(plans []suitePlan, fallback []string) []string {
return out
}
+const pinchtabImageBuilder = "pinchtab"
+
func servicesToBuild(plans []suitePlan, fallback []string) []string {
services := append([]string(nil), servicesForPlans(plans, fallback)...)
seen := map[string]bool{}
+ needsImageBuilder := false
for _, svc := range services {
seen[svc] = true
+ if strings.HasPrefix(svc, pinchtabImageBuilder+"-") {
+ needsImageBuilder = true
+ }
+ }
+ if needsImageBuilder && !seen[pinchtabImageBuilder] {
+ seen[pinchtabImageBuilder] = true
+ services = append([]string{pinchtabImageBuilder}, services...)
}
for _, plan := range plans {
if runner := plan.def.Runner; runner != "" && !seen[runner] {