High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
fix: write saved browser state atomically so an interrupted save cannot destroy it
Luigi Agosti9c6f5de90079
diff --git a/internal/state/load_test.go b/internal/state/load_test.goindex 5f6e3096..4b1b5723 100644--- a/internal/state/load_test.go+++ b/internal/state/load_test.go@@ -1,6 +1,7 @@package stateimport (+ "os""strings""testing")@@ -68,3 +69,36 @@ func TestLoadEncryptedStateWithoutKeyExplainsItself(t *testing.T) {t.Errorf("error = %v, want it to mention the file is encrypted", err)}}++// Save writes through a temp file; the temp must never survive, and it must not+// be picked up as a state file by List/Clean.+func TestSaveLeavesNoTempFile(t *testing.T) {+ dir := t.TempDir()+ if _, err := Save(dir, &StateFile{Name: "session"}, ""); err != nil {+ t.Fatalf("Save: %v", err)+ }+ if _, err := Save(dir, &StateFile{Name: "session"}, ""); err != nil {+ t.Fatalf("Save (overwrite): %v", err)+ }++ entries, err := os.ReadDir(SessionsDir(dir))+ if err != nil {+ t.Fatal(err)+ }+ for _, e := range entries {+ if strings.HasSuffix(e.Name(), ".tmp") {+ t.Errorf("temp file %q left behind after save", e.Name())+ }+ }+ if len(entries) != 1 {+ t.Errorf("sessions dir has %d entries, want 1", len(entries))+ }++ list, err := List(dir)+ if err != nil {+ t.Fatalf("List: %v", err)+ }+ if len(list) != 1 || list[0].Name != "session" {+ t.Errorf("List() = %+v, want a single \"session\" entry", list)+ }+}diff --git a/internal/state/state.go b/internal/state/state.goindex bb105f6f..e5545cc8 100644--- a/internal/state/state.go+++ b/internal/state/state.go@@ -126,7 +126,15 @@ func Save(stateDir string, sf *StateFile, encryptionKey string) (string, error)return "", fmt.Errorf("invalid state file name: resolved path escapes state directory")}- if err := os.WriteFile(path, data, 0600); err != nil {+ // Atomic write: Save overwrites by name, so a torn write would destroy the+ // previously saved state as well as the new one — and a truncated encrypted+ // payload fails GCM authentication, losing the session entirely.+ tmpPath := path + ".tmp"+ if err := os.WriteFile(tmpPath, data, 0600); err != nil {+ return "", fmt.Errorf("write state file: %w", err)+ }+ if err := os.Rename(tmpPath, path); err != nil {+ _ = os.Remove(tmpPath)return "", fmt.Errorf("write state file: %w", err)}