Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix(daemon): stop overwriting user config on daemon install

Boscha12efdb034ef
diff --git a/cmd/pinchtab/cmd_daemon.go b/cmd/pinchtab/cmd_daemon.go
index a7fa19d1..c7a9b298 100644
--- a/cmd/pinchtab/cmd_daemon.go
+++ b/cmd/pinchtab/cmd_daemon.go
@@ -230,19 +230,24 @@ func ensureDaemonConfig(force bool) (string, *config.FileConfig, configBootstrap
return configPath, &defaults, status, nil
}
- // If file exists and not forced, check if it needs recovery to secure baseline
- _, changed, err := cli.RestoreSecurityDefaults()
- if err != nil {
- fileCfg, _, _ := config.LoadFileConfig()
- return configPath, fileCfg, configVerified, err
+ // File exists — load it as-is, don't overwrite security settings.
+ // Security recovery is now handled by the wizard or `pinchtab security up`.
+ fileCfg, _, _ := config.LoadFileConfig()
+ if fileCfg == nil {
+ return configPath, nil, "", fmt.Errorf("failed to load existing config at %s", configPath)
}
- status := configVerified
- if changed {
- status = configRecovered
+
+ // Only generate a token if one is missing (security essential)
+ if strings.TrimSpace(fileCfg.Server.Token) == "" {
+ token, err := config.GenerateAuthToken()
+ if err == nil {
+ fileCfg.Server.Token = token
+ _ = config.SaveFileConfig(fileCfg, configPath)
+ return configPath, fileCfg, configRecovered, nil
+ }
}
- fileCfg, _, _ := config.LoadFileConfig()
- return configPath, fileCfg, status, nil
+ return configPath, fileCfg, configVerified, nil
}
type configBootstrapStatus string
diff --git a/cmd/pinchtab/cmd_daemon_test.go b/cmd/pinchtab/cmd_daemon_test.go
index 1d2e5fad..0c89bed6 100644
--- a/cmd/pinchtab/cmd_daemon_test.go
+++ b/cmd/pinchtab/cmd_daemon_test.go
@@ -86,11 +86,13 @@ func TestEnsureOnboardConfigRecoversExistingSecuritySettings(t *testing.T) {
if err != nil {
t.Fatalf("ensureDaemonConfig returned error: %v", err)
}
+ // Only token recovery happens now — security settings are preserved for wizard
if status != configRecovered {
t.Fatalf("status = %q, want %q", status, configRecovered)
}
- if cfg.Server.Bind != "127.0.0.1" {
- t.Fatalf("bind = %q, want 127.0.0.1", cfg.Server.Bind)
+ // Bind is preserved as-is (wizard handles security changes, not daemon config)
+ if cfg.Server.Bind != "0.0.0.0" {
+ t.Fatalf("bind = %q, want 0.0.0.0 (preserved)", cfg.Server.Bind)
}
if cfg.Server.Port != "9999" {
t.Fatalf("port = %q, want 9999", cfg.Server.Port)
@@ -98,9 +100,11 @@ func TestEnsureOnboardConfigRecoversExistingSecuritySettings(t *testing.T) {
if cfg.Browser.ChromeBinary != "/custom/chrome" {
t.Fatalf("chrome binary = %q, want /custom/chrome", cfg.Browser.ChromeBinary)
}
- if boolPtrValue(cfg.Security.AllowEvaluate) {
- t.Fatal("expected allowEvaluate to be reset to false")
+ // Security settings preserved — not overwritten
+ if !boolPtrValue(cfg.Security.AllowEvaluate) {
+ t.Fatal("expected allowEvaluate to be preserved as true")
}
+ // Token should be generated (was empty)
if strings.TrimSpace(cfg.Server.Token) == "" {
t.Fatal("expected recovery to generate a token")
}