Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

refactor: finish chrome-to-browser rename across tests and handlers

Boschb8efe47f1c6c
diff --git a/cmd/pinchtab/cmd_config_test.go b/cmd/pinchtab/cmd_config_test.go
index 1768c4df..aa3681aa 100644
--- a/cmd/pinchtab/cmd_config_test.go
+++ b/cmd/pinchtab/cmd_config_test.go
@@ -105,8 +105,8 @@ func TestConfigSetAllowsDashPrefixedValue(t *testing.T) {
if err != nil {
t.Fatalf("LoadFileConfig() error = %v", err)
}
- if saved.Browser.ChromeExtraFlags != "--disable-gpu --ash-no-nudges" {
- t.Fatalf("ChromeExtraFlags = %q, want %q", saved.Browser.ChromeExtraFlags, "--disable-gpu --ash-no-nudges")
+ if saved.Browser.BrowserExtraFlags != "--disable-gpu --ash-no-nudges" {
+ t.Fatalf("BrowserExtraFlags = %q, want %q", saved.Browser.BrowserExtraFlags, "--disable-gpu --ash-no-nudges")
}
}
@@ -140,8 +140,8 @@ func TestConfigSetRejectsUnsafeChromeExtraFlags(t *testing.T) {
if err != nil {
t.Fatalf("LoadFileConfig() error = %v", err)
}
- if saved.Browser.ChromeExtraFlags != "" {
- t.Fatalf("ChromeExtraFlags = %q, want empty string after declining unsafe save", saved.Browser.ChromeExtraFlags)
+ if saved.Browser.BrowserExtraFlags != "" {
+ t.Fatalf("BrowserExtraFlags = %q, want empty string after declining unsafe save", saved.Browser.BrowserExtraFlags)
}
}
diff --git a/cmd/pinchtab/cmd_doctor_test.go b/cmd/pinchtab/cmd_doctor_test.go
index 8295d94c..5b98c8fe 100644
--- a/cmd/pinchtab/cmd_doctor_test.go
+++ b/cmd/pinchtab/cmd_doctor_test.go
@@ -74,7 +74,7 @@ func TestRunDoctorReturnsUsageErrorWithoutMutatingCheckFlag(t *testing.T) {
func TestRunDoctorReturnsFailureCodeWithoutExiting(t *testing.T) {
missingBinary := filepath.Join(t.TempDir(), "missing-browser")
writeDoctorTestConfig(t, func(fc *config.FileConfig) {
- fc.Browser.ChromeBinary = missingBinary
+ fc.Browser.BrowserBinary = missingBinary
})
restore := setDoctorGlobals("binary_exists", false)
t.Cleanup(restore)
diff --git a/internal/bridge/runtime/init.go b/internal/bridge/runtime/init.go
index eeb78fe6..1135316b 100644
--- a/internal/bridge/runtime/init.go
+++ b/internal/bridge/runtime/init.go
@@ -529,13 +529,3 @@ func cryptoRandSeed() int64 {
}
return n.Int64()
}
-
-// defaultBrowserToLaunchMode maps the DefaultBrowser identifier to the appropriate
-// LaunchMode. ghost-chrome uses LaunchModeAuto; everything else (chrome, cloak, ...)
-// uses LaunchModeChrome.
-func defaultBrowserToLaunchMode(defaultBrowser string) browsers.LaunchMode {
- if config.NormalizeBrowser(defaultBrowser) == config.BrowserGhostChrome {
- return browsers.LaunchModeAuto
- }
- return browsers.LaunchModeChrome
-}
diff --git a/internal/browsers/ghostchrome/bridge_proxy.go b/internal/browsers/ghostchrome/bridge_proxy.go
index 4e4082dd..a024a60a 100644
--- a/internal/browsers/ghostchrome/bridge_proxy.go
+++ b/internal/browsers/ghostchrome/bridge_proxy.go
@@ -46,11 +46,11 @@ const (
// transparent ghost-chrome routing. Lite tabs are lazily escalated to
// Chrome when Chrome-only operations are requested.
type BridgeProxy struct {
- chrome ChromeBridge // underlying Chrome bridge (all unhandled methods forwarded here)
- lite *staticfetch.Browser // static fetch browser (may be nil → pure passthrough)
- ensureBrowser func() error // ensures the browser runtime is running before escalation
- tabMap tabMapping // lite tabID → Chrome tabID
- escalationMu sync.Map // lite tabID → *sync.Mutex (serializes per-tab escalation)
+ chrome ChromeBridge // underlying Chrome bridge (all unhandled methods forwarded here)
+ lite *staticfetch.Browser // static fetch browser (may be nil → pure passthrough)
+ ensureBrowser func() error // ensures the browser runtime is running before escalation
+ tabMap tabMapping // lite tabID → Chrome tabID
+ escalationMu sync.Map // lite tabID → *sync.Mutex (serializes per-tab escalation)
}
// NewBridgeProxy creates a BridgeProxy that transparently routes between
@@ -59,8 +59,8 @@ type BridgeProxy struct {
// call the bridge browser-init path with the appropriate config.
func NewBridgeProxy(chrome ChromeBridge, lite *staticfetch.Browser, ensureBrowser func() error) *BridgeProxy {
return &BridgeProxy{
- chrome: chrome,
- lite: lite,
+ chrome: chrome,
+ lite: lite,
ensureBrowser: ensureBrowser,
}
}
diff --git a/internal/config/browser_provider_test.go b/internal/config/browser_provider_test.go
index 8ba5cd3a..365eaf9c 100644
--- a/internal/config/browser_provider_test.go
+++ b/internal/config/browser_provider_test.go
@@ -4,7 +4,9 @@ import (
"strings"
"testing"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/ghostchrome"
)
func TestParseBrowser(t *testing.T) {
diff --git a/internal/config/browser_targets_test.go b/internal/config/browser_targets_test.go
index 77c234af..fe2eae55 100644
--- a/internal/config/browser_targets_test.go
+++ b/internal/config/browser_targets_test.go
@@ -5,7 +5,9 @@ import (
"strings"
"testing"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/ghostchrome"
)
func TestMigrateLegacyBrowserConfig_LegacyOnlySynthesizesDefaultTarget(t *testing.T) {
diff --git a/internal/config/browsers_config_test.go b/internal/config/browsers_config_test.go
index dc2e882e..e0d12a22 100644
--- a/internal/config/browsers_config_test.go
+++ b/internal/config/browsers_config_test.go
@@ -7,7 +7,9 @@ import (
"strings"
"testing"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/ghostchrome"
)
// --- Validation tests ---
diff --git a/internal/config/validate_test.go b/internal/config/validate_test.go
index 08b226c5..3cf9ee30 100644
--- a/internal/config/validate_test.go
+++ b/internal/config/validate_test.go
@@ -7,7 +7,9 @@ import (
"testing"
"github.com/pinchtab/pinchtab/internal/browsers"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/ghostchrome"
)
func TestValidateFileConfig_Valid(t *testing.T) {
diff --git a/internal/config/workflow/security_test.go b/internal/config/workflow/security_test.go
index f4b08352..faf830df 100644
--- a/internal/config/workflow/security_test.go
+++ b/internal/config/workflow/security_test.go
@@ -6,7 +6,9 @@ import (
"strings"
"testing"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/ghostchrome"
"github.com/pinchtab/pinchtab/internal/config"
)
diff --git a/internal/handlers/capture.go b/internal/handlers/capture.go
index e11b4c1e..3f676124 100644
--- a/internal/handlers/capture.go
+++ b/internal/handlers/capture.go
@@ -218,7 +218,7 @@ func (h *Handlers) HandleCapture(w http.ResponseWriter, r *http.Request) {
return
}
opts.ScopeBackendNodeID = nodeID
- clip, cErr := bridge.ScreenshotClipForNode(tCtx, nodeID)
+ clip, cErr := bridge.ScreenshotClipForNode(tCtx, nodeID)
if cErr != nil {
httpx.Error(w, 500, fmt.Errorf("selector clip: %w", cErr))
return
diff --git a/internal/handlers/handlers_test.go b/internal/handlers/handlers_test.go
index eb320d2e..ad86e3f4 100644
--- a/internal/handlers/handlers_test.go
+++ b/internal/handlers/handlers_test.go
@@ -25,9 +25,9 @@ type mockBridge struct {
lastErrorLimit int
fingerprintTabs map[string]bool
frameScopes map[string]bridge.FrameScope
- ensureBrowserErr error
- ensureBrowserCall int
- ensureBrowserCfg *config.RuntimeConfig
+ ensureBrowserErr error
+ ensureBrowserCall int
+ ensureBrowserCfg *config.RuntimeConfig
dialogManager *bridge.DialogManager
executeActionErr error
autoCloseArmed []string
diff --git a/internal/handlers/health_tabs.go b/internal/handlers/health_tabs.go
index bc69b08b..e8ce3c15 100644
--- a/internal/handlers/health_tabs.go
+++ b/internal/handlers/health_tabs.go
@@ -32,9 +32,9 @@ func (h *Handlers) HandleHealth(w http.ResponseWriter, r *http.Request) {
if h.writeBridgeUnavailable(w, err) {
return
}
- httpx.JSON(w, 503, map[string]any{"status": "error", "reason": fmt.Sprintf("browser initialization failed: %v", err)})
- return
- }
+ httpx.JSON(w, 503, map[string]any{"status": "error", "reason": fmt.Sprintf("browser initialization failed: %v", err)})
+ return
+ }
targets, err := h.Bridge.ListTargets()
if err != nil {
diff --git a/internal/handlers/health_tabs_test.go b/internal/handlers/health_tabs_test.go
index 6f127a9c..8c2a9428 100644
--- a/internal/handlers/health_tabs_test.go
+++ b/internal/handlers/health_tabs_test.go
@@ -217,7 +217,7 @@ func TestHandleTabs_CurrentTrackedTabIsReturnedFirst(t *testing.T) {
// TestHandleHealth_EnsureBrowserFailure verifies /health returns 503 when browser initialization fails
func TestHandleHealth_EnsureBrowserFailure(t *testing.T) {
mockBridge := &MockBridge{
- targets: []bridge.TabTarget{},
+ targets: []bridge.TabTarget{},
ensureBrowserErr: "failed to start browser: connection refused",
ensureBrowserCalled: false,
}
@@ -309,13 +309,13 @@ func contains(s, substr string) bool {
// MockBridge is a test implementation of the BridgeAPI interface
type MockBridge struct {
- targets []bridge.TabTarget
- listTargetsErr string
+ targets []bridge.TabTarget
+ listTargetsErr string
ensureBrowserCalled bool
ensureBrowserErr string
- currentTabID string
- draining bool
- retryAfter time.Duration
+ currentTabID string
+ draining bool
+ retryAfter time.Duration
}
func (m *MockBridge) ListTargets() ([]bridge.TabTarget, error) {
diff --git a/internal/handlers/navigation.go b/internal/handlers/navigation.go
index c56544c2..2efed3b4 100644
--- a/internal/handlers/navigation.go
+++ b/internal/handlers/navigation.go
@@ -262,8 +262,8 @@ func (h *Handlers) HandleNavigate(w http.ResponseWriter, r *http.Request) {
blockPatterns = bridge.CombineBlockPatterns(blockPatterns, bridge.ImageBlockPatterns)
}
- if req.NewTab {
- h.navigateNewTabBrowser(w, r, navigateBrowserOptions{
+ if req.NewTab {
+ h.navigateNewTabBrowser(w, r, navigateBrowserOptions{
URL: req.URL,
WaitFor: req.WaitFor,
WaitSelector: req.WaitSelector,
@@ -281,8 +281,8 @@ func (h *Handlers) HandleNavigate(w http.ResponseWriter, r *http.Request) {
ctx, resolvedTabID, err := h.tabContext(r, req.TabID)
if err != nil {
- if scopedCurrentForNavigate {
- h.navigateNewTabBrowser(w, r, navigateBrowserOptions{
+ if scopedCurrentForNavigate {
+ h.navigateNewTabBrowser(w, r, navigateBrowserOptions{
URL: req.URL,
WaitFor: req.WaitFor,
WaitSelector: req.WaitSelector,
diff --git a/internal/stealth/bundle_test.go b/internal/stealth/bundle_test.go
index d6f90850..38b789af 100644
--- a/internal/stealth/bundle_test.go
+++ b/internal/stealth/bundle_test.go
@@ -4,7 +4,8 @@ import (
"strings"
"testing"
- _ "github.com/pinchtab/pinchtab/internal/browsers/all"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/chrome"
+ _ "github.com/pinchtab/pinchtab/internal/browsers/cloak"
"github.com/pinchtab/pinchtab/internal/config"
)
diff --git a/tests/e2e/scenarios/infra/system-basic.sh b/tests/e2e/scenarios/infra/system-basic.sh
index 80781509..0a8df4b4 100644
--- a/tests/e2e/scenarios/infra/system-basic.sh
+++ b/tests/e2e/scenarios/infra/system-basic.sh
@@ -241,8 +241,8 @@ if [ -n "$DEFAULT_INST_ID" ] && [ "$DEFAULT_INST_ID" != "null" ]; then
assert_instance_logs_poll \
"$DEFAULT_INST_ID" \
- "chrome initialized successfully" \
- "default instance chrome initialized"
+ "browser initialized successfully" \
+ "default instance browser initialized"
fi
if [ $DEFAULT_LOG_PASS -ne 0 ]; then