High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
fix: name the e2e server log level explicitly instead of borrowing --verbose, whose meaning changed under the logging fix (PIN-101)
Luigi Agostic00527f83407
diff --git a/tests/e2e/docker-compose-multi.yml b/tests/e2e/docker-compose-multi.ymlindex a19e0c3e..36aeeebc 100644--- a/tests/e2e/docker-compose-multi.yml+++ b/tests/e2e/docker-compose-multi.yml@@ -6,9 +6,16 @@# "debug"), and the level silently moved with it. `--log-level` wins over any# config file, so nothing under tests/e2e/config/ can override it.#-# `--verbose` is kept alongside for the startup banner, which is the sole place the-# log states the guard posture and the allowed-domain list — the fact that explains-# a scenario failing on a blocked fixture host.+# `--verbose` is kept alongside for the two things it alone puts in the artifact,+# both gated on cfg.VerboseBanner in internal/server/server.go: the startup banner,+# whose security line reads `security ELEVATED`, and cli.LogSecurityWarnings — four+# `category=security` WARN lines (sensitive_endpoints_enabled, non_loopback_bind,+# idpi_warn_mode, attach_external_hosts with its `allowHosts` list) that vanish+# entirely without the flag. The warnings are the diagnostic half; the attach+# `allowHosts` list is the attach trust boundary, NOT the netguard allowed domains.+# Nothing in the server log prints the netguard allowlist at any level — `Guard: UP`+# and `Allowed domains:` come from cmd_wizard.go, the interactive setup wizard, and+# never reach a `docker compose logs` capture.## Both flags must stay, and the reason is a precedence detail worth stating exactly.# `--verbose` contributes ONLY the banner *while* `--log-level` is set: applyLogLeveldiff --git a/tests/e2e/docker-compose.yml b/tests/e2e/docker-compose.ymlindex 90b0e94e..baa0a440 100644--- a/tests/e2e/docker-compose.yml+++ b/tests/e2e/docker-compose.yml@@ -6,9 +6,16 @@# "debug"), and the level silently moved with it. `--log-level` wins over any# config file, so nothing under tests/e2e/config/ can override it.#-# `--verbose` is kept alongside for the startup banner, which is the sole place the-# log states the guard posture and the allowed-domain list — the fact that explains-# a scenario failing on a blocked fixture host.+# `--verbose` is kept alongside for the two things it alone puts in the artifact,+# both gated on cfg.VerboseBanner in internal/server/server.go: the startup banner,+# whose security line reads `security ELEVATED`, and cli.LogSecurityWarnings — four+# `category=security` WARN lines (sensitive_endpoints_enabled, non_loopback_bind,+# idpi_warn_mode, attach_external_hosts with its `allowHosts` list) that vanish+# entirely without the flag. The warnings are the diagnostic half; the attach+# `allowHosts` list is the attach trust boundary, NOT the netguard allowed domains.+# Nothing in the server log prints the netguard allowlist at any level — `Guard: UP`+# and `Allowed domains:` come from cmd_wizard.go, the interactive setup wizard, and+# never reach a `docker compose logs` capture.## Both flags must stay, and the reason is a precedence detail worth stating exactly.# `--verbose` contributes ONLY the banner *while* `--log-level` is set: applyLogLeveldiff --git a/tests/tools/runner/internal/e2e/e2e_test.go b/tests/tools/runner/internal/e2e/e2e_test.goindex da9dff12..92d391f8 100644--- a/tests/tools/runner/internal/e2e/e2e_test.go+++ b/tests/tools/runner/internal/e2e/e2e_test.go@@ -1068,9 +1068,10 @@ func TestEmptyLogSuffixMarksZeroByteArtifacts(t *testing.T) {// level used to be borrowed from --verbose, which once meant "log at all" and later// came to mean "debug"; the harness's diagnostic level moved when that definition// moved, which is the drift this pins. --verbose is still expected alongside for the-// startup banner — the only place the log states the guard posture and the-// allowed-domain list — and both flags are required together: --verbose contributes-// only the banner WHILE --log-level is set, and would govern the level again if+// startup banner and the four category=security WARN lines, both gated on+// cfg.VerboseBanner and absent from the artifact without it; the netguard allowlist+// is printed by neither, at any level. Both flags are required together: --verbose+// contributes only the banner WHILE --log-level is set, and would govern the level again if// --log-level were dropped. Bridge services are expected to carry neither, which// leaves them at info; that is this guard's scope, not a finding that info is the// right level for them.