Skip to content

High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.

fix: npm cli post release verification

Luigi Agostic7c2c49db380
diff --git a/.github/workflows/ci-e2e.yml b/.github/workflows/ci-e2e.yml
index b2569791..7373ae45 100644
--- a/.github/workflows/ci-e2e.yml
+++ b/.github/workflows/ci-e2e.yml
@@ -161,10 +161,3 @@ jobs:
summary_title: E2E Infra Extended Tests
timeout_minutes: 25
compose_file: tests/e2e/docker-compose-multi.yml
-
- npm-cli-macos:
- if: github.event_name == 'workflow_dispatch' && inputs.suite == 'all'
- uses: ./.github/workflows/reusable-npm-e2e.yml
- with:
- ref: ${{ github.sha }}
- summary_title: E2E npm CLI Tests (macOS)
diff --git a/.github/workflows/release-post-verify.yml b/.github/workflows/release-post-verify.yml
new file mode 100644
index 00000000..25d163dd
--- /dev/null
+++ b/.github/workflows/release-post-verify.yml
@@ -0,0 +1,57 @@
+name: Release / Post-Verify
+
+on:
+ workflow_dispatch:
+ inputs:
+ tag:
+ description: 'Published release tag to verify (e.g. v0.9.1)'
+ required: true
+
+permissions:
+ contents: read
+
+concurrency:
+ group: release-post-verify-${{ inputs.tag }}
+ cancel-in-progress: false
+
+jobs:
+ npm-cli-macos:
+ name: Post-Release npm CLI (macOS)
+ runs-on: macos-latest
+ timeout-minutes: 25
+ steps:
+ - uses: actions/checkout@v6
+
+ - uses: actions/setup-node@v6
+ with:
+ node-version: '22'
+
+ - name: Normalize release metadata
+ id: meta
+ run: |
+ TAG="${{ inputs.tag }}"
+ if [ "${TAG#v}" = "$TAG" ]; then
+ TAG="v$TAG"
+ fi
+
+ VERSION="${TAG#v}"
+ echo "tag=$TAG" >> "$GITHUB_OUTPUT"
+ echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+
+ - name: Wait for npm package availability
+ run: |
+ VERSION="${{ steps.meta.outputs.version }}"
+ for _ in $(seq 1 30); do
+ if npm view "pinchtab@${VERSION}" version >/dev/null 2>&1; then
+ exit 0
+ fi
+ sleep 20
+ done
+
+ echo "pinchtab@${VERSION} was not available on npm in time" >&2
+ exit 1
+
+ - name: Verify published npm CLI on macOS
+ run: |
+ chmod +x npm/scripts/npm-cli-e2e.sh
+ npm/scripts/npm-cli-e2e.sh "pinchtab@${{ steps.meta.outputs.version }}"
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 43f1f8fa..ab16b6cf 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -63,14 +63,6 @@ jobs:
ref: ${{ needs.validate.outputs.sha }}
version: ${{ needs.validate.outputs.version }}
- e2e-npm-cli-macos:
- needs: validate
- uses: ./.github/workflows/reusable-npm-e2e.yml
- with:
- ref: ${{ needs.validate.outputs.sha }}
- version: ${{ needs.validate.outputs.version }}
- summary_title: Release E2E npm CLI (macOS)
-
e2e-api-extended:
needs: validate
uses: ./.github/workflows/reusable-e2e.yml
@@ -165,7 +157,6 @@ jobs:
- dashboard-checks
- docs-checks
- npm-checks
- - e2e-npm-cli-macos
- e2e-api-extended
- e2e-cli-extended
- e2e-infra-extended
@@ -195,7 +186,6 @@ jobs:
echo "| Dashboard | ✅ |" >> "$GITHUB_STEP_SUMMARY"
echo "| Docs | ✅ |" >> "$GITHUB_STEP_SUMMARY"
echo "| npm | ✅ |" >> "$GITHUB_STEP_SUMMARY"
- echo "| E2E npm CLI (macOS) | ${{ needs.e2e-npm-cli-macos.result == 'success' && '✅' || '⚠️ ' }}${{ needs.e2e-npm-cli-macos.result }} |" >> "$GITHUB_STEP_SUMMARY"
echo "| Publish dry run | ✅ |" >> "$GITHUB_STEP_SUMMARY"
echo "| Docker smoke | ${{ needs.docker-smoke.result == 'success' && '✅' || '⚠️ ' }}${{ needs.docker-smoke.result }} |" >> "$GITHUB_STEP_SUMMARY"
echo "| E2E API | ${{ needs.e2e-api-extended.result == 'success' && '✅' || '⚠️ ' }}${{ needs.e2e-api-extended.result }} |" >> "$GITHUB_STEP_SUMMARY"
@@ -203,7 +193,7 @@ jobs:
echo "| E2E Infra | ${{ needs.e2e-infra-extended.result == 'success' && '✅' || '⚠️ ' }}${{ needs.e2e-infra-extended.result }} |" >> "$GITHUB_STEP_SUMMARY"
echo "" >> "$GITHUB_STEP_SUMMARY"
- if [ "${{ needs.e2e-npm-cli-macos.result }}" != "success" ] || [ "${{ needs.e2e-api-extended.result }}" != "success" ] || [ "${{ needs.e2e-cli-extended.result }}" != "success" ] || [ "${{ needs.e2e-infra-extended.result }}" != "success" ] || [ "${{ needs.docker-smoke.result }}" != "success" ]; then
+ if [ "${{ needs.e2e-api-extended.result }}" != "success" ] || [ "${{ needs.e2e-cli-extended.result }}" != "success" ] || [ "${{ needs.e2e-infra-extended.result }}" != "success" ] || [ "${{ needs.docker-smoke.result }}" != "success" ]; then
echo "⚠️ **Some checks failed — review artifacts before approving.**" >> "$GITHUB_STEP_SUMMARY"
fi
diff --git a/.github/workflows/reusable-npm-e2e.yml b/.github/workflows/reusable-npm-e2e.yml
deleted file mode 100644
index a7a6598d..00000000
--- a/.github/workflows/reusable-npm-e2e.yml
+++ /dev/null
@@ -1,63 +0,0 @@
-name: Reusable / npm E2E
-
-on:
- workflow_call:
- inputs:
- ref:
- required: true
- type: string
- version:
- required: false
- type: string
- summary_title:
- required: true
- type: string
-
-
-permissions:
- contents: read
-
-jobs:
- npm-cli-macos:
- name: ${{ inputs.summary_title }}
- runs-on: macos-latest
- timeout-minutes: 20
- steps:
- - uses: actions/checkout@v6
- with:
- ref: ${{ inputs.ref }}
-
- - uses: actions/setup-node@v6
- with:
- node-version: '22'
-
- - name: Update npm package version
- if: ${{ inputs.version != '' }}
- working-directory: npm
- run: |
- CURRENT=$(node -pe "require('./package.json').version")
- DESIRED="${{ inputs.version }}"
- if [ "$CURRENT" != "$DESIRED" ]; then
- npm version "$DESIRED" --no-git-tag-version
- else
- echo "Version already correct: $CURRENT"
- fi
-
- - name: Install dependencies
- working-directory: npm
- run: npm ci --ignore-scripts
-
- - name: Build TypeScript
- working-directory: npm
- run: npm run build
-
- - name: Pack npm tarball
- working-directory: npm
- run: npm pack
-
- - name: Run npm CLI E2E on macOS
- working-directory: npm
- run: |
- chmod +x scripts/npm-cli-e2e.sh
- TARBALL="$(ls -t pinchtab-*.tgz | head -1)"
- ./scripts/npm-cli-e2e.sh "$TARBALL"
diff --git a/npm/scripts/npm-cli-e2e.sh b/npm/scripts/npm-cli-e2e.sh
index 5c9f288f..393ea0bd 100755
--- a/npm/scripts/npm-cli-e2e.sh
+++ b/npm/scripts/npm-cli-e2e.sh
@@ -2,11 +2,11 @@
set -euo pipefail
if [ "$#" -ne 1 ]; then
- echo "usage: $0 <npm-tarball>" >&2
+ echo "usage: $0 <npm-install-target>" >&2
exit 1
fi
-TARBALL="$1"
+INSTALL_TARGET="$1"
TMP_ROOT="$(mktemp -d)"
HOME_DIR="$TMP_ROOT/home"
PREFIX_DIR="$TMP_ROOT/prefix"
@@ -29,8 +29,8 @@ mkdir -p "$HOME_DIR" "$PREFIX_DIR"
export HOME="$HOME_DIR"
export PATH="$BIN_DIR:$PATH"
-echo "Installing npm package from $TARBALL"
-npm install -g --prefix "$PREFIX_DIR" "$TARBALL"
+echo "Installing npm package from $INSTALL_TARGET"
+npm install -g --prefix "$PREFIX_DIR" "$INSTALL_TARGET"
echo "Initializing CLI config"
pinchtab config init
diff --git a/scripts/docker-smoke.sh b/scripts/docker-smoke.sh
index 52768296..6fe4d7a4 100644
--- a/scripts/docker-smoke.sh
+++ b/scripts/docker-smoke.sh
@@ -54,6 +54,13 @@ if [ "$bind_addr" != "0.0.0.0" ]; then
exit 1
fi
-docker exec "$NAME" test -f /data/.config/pinchtab/config.json
+config_path="$(docker exec "$NAME" pinchtab config path | tr -d '\r')"
+if [ -z "$config_path" ]; then
+ FAILED=1
+ echo "failed to determine container config path"
+ exit 1
+fi
+
+docker exec "$NAME" test -f "$config_path"
echo "Docker smoke test passed."