High-performance browser automation bridge and multi-instance orchestrator with advanced stealth injection and real-time dashboard.
fix(config): copy the cookie-secure pointer so no FileConfig write reaches the runtime (PIN-006)
Luigi Agosticcbd511bb81b
diff --git a/internal/config/config_file_marshal.go b/internal/config/config_file_marshal.goindex fdd315b5..6153b0ff 100644--- a/internal/config/config_file_marshal.go+++ b/internal/config/config_file_marshal.go@@ -415,7 +415,7 @@ func serverConfigFromRuntime(cfg *RuntimeConfig) ServerConfig {RetainNetworkBodies: ptr(cfg.RetainNetworkBodies),RetainNetworkBodyMaxBytes: ptr(cfg.RetainNetworkBodyMaxBytes),TrustProxyHeaders: ptr(cfg.TrustProxyHeaders),- CookieSecure: cfg.CookieSecure,+ CookieSecure: cloneBoolPtr(cfg.CookieSecure),}}diff --git a/internal/config/file_config_from_runtime_fresh_memory_test.go b/internal/config/file_config_from_runtime_fresh_memory_test.gonew file mode 100644index 00000000..9fee81d3--- /dev/null+++ b/internal/config/file_config_from_runtime_fresh_memory_test.go@@ -0,0 +1,77 @@+package config++import (+ "reflect"+ "testing"+)++func scribbleReferences(v reflect.Value) int {+ switch v.Kind() {+ case reflect.Pointer:+ if v.IsNil() {+ return 0+ }+ return 1 + scribbleValue(v.Elem())+ case reflect.Slice:+ n := 0+ for i := 0; i < v.Len(); i++ {+ n += 1 + scribbleValue(v.Index(i))+ }+ return n+ case reflect.Map:+ n := 0+ for _, key := range v.MapKeys() {+ elem := reflect.New(v.Type().Elem()).Elem()+ elem.Set(v.MapIndex(key))+ n += 1 + scribbleValue(elem)+ v.SetMapIndex(key, elem)+ }+ return n+ case reflect.Struct:+ n := 0+ for i := 0; i < v.NumField(); i++ {+ if v.Type().Field(i).IsExported() {+ n += scribbleReferences(v.Field(i))+ }+ }+ return n+ }+ return 0+}++func scribbleValue(v reflect.Value) int {+ switch v.Kind() {+ case reflect.Bool:+ v.SetBool(!v.Bool())+ case reflect.String:+ v.SetString(v.String() + "-mutated")+ case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:+ v.SetInt(v.Int() + 1)+ case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:+ v.SetUint(v.Uint() + 1)+ case reflect.Float32, reflect.Float64:+ v.SetFloat(v.Float() + 1)+ default:+ return scribbleReferences(v)+ }+ return 0+}++func TestWritingThroughEveryFileConfigReferenceLeavesTheRuntimeUnchanged(t *testing.T) {+ cfg := populatedRuntimeConfig(t)+ cfg.CookieSecure = ptr(true)+ want := populatedRuntimeConfig(t)+ want.CookieSecure = ptr(true)+ if !reflect.DeepEqual(cfg, want) {+ t.Fatal("populatedRuntimeConfig is not deterministic, so it cannot serve as the control")+ }++ fc := FileConfigFromRuntime(cfg)+ if written := scribbleReferences(reflect.ValueOf(&fc).Elem()); written < 80 {+ t.Fatalf("wrote through only %d references; the fixture no longer populates the reference-typed fields", written)+ }++ if !reflect.DeepEqual(cfg, want) {+ t.Fatalf("a write through the returned FileConfig reached the runtime:\n got %+v\nwant %+v", *cfg, *want)+ }+}